Ros-diffs February 2008

ros-diffs@reactos.org

21 participants
460 discussions

[fireball] 32518: - This bug most probably is solved ages ago, but for testing purposes I enable this message before removing the check. Later could be substituted with an ASSERT.
by fireball＠svn.reactos.org 27 Feb '08

27 Feb '08

Author: fireball Date: Wed Feb 27 23:54:27 2008 New Revision: 32518 URL: http://svn.reactos.org/svn/reactos?rev=32518&view=rev Log: - This bug most probably is solved ages ago, but for testing purposes I enable this message before removing the check. Later could be substituted with an ASSERT. Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c Modified: trunk/reactos/ntoskrnl/io/iomgr/driver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/driver.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/driver.c (original) +++ trunk/reactos/ntoskrnl/io/iomgr/driver.c Wed Feb 27 23:54:27 2008 @@ -280,7 +280,10 @@ /* FIXME: This check may be removed once the bug is fixed */ if (ServiceName->Buffer == NULL) + { + DPRINT1("If you see this, please report to Fireball or hpoussin!\n"); return STATUS_UNSUCCESSFUL; + } /* Open CurrentControlSet */ RtlInitUnicodeString(&CCSName,

1 0

[fireball] 32517: - The forgotten declaration.
by fireball＠svn.reactos.org 27 Feb '08

27 Feb '08

Author: fireball Date: Wed Feb 27 23:50:41 2008 New Revision: 32517 URL: http://svn.reactos.org/svn/reactos?rev=32517&view=rev Log: - The forgotten declaration. Modified: trunk/reactos/include/ddk/wdm.h Modified: trunk/reactos/include/ddk/wdm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/wdm.h?rev=3251… ============================================================================== --- trunk/reactos/include/ddk/wdm.h (original) +++ trunk/reactos/include/ddk/wdm.h Wed Feb 27 23:50:41 2008 @@ -20,5 +20,7 @@ #define CmResourceTypePcCardConfig 130 #define CmResourceTypeMfCardConfig 131 +extern ULONG NtGlobalFlag; + #endif

1 0

[fireball] 32516: Code cleanup: - Move NtGlobalFlag declaration to wdm.h (which Emanuele wanted to do since it was committed in revision 1137). - Remove unneeded declarations added by Filip in revision 9660 and Thomas in revision 14058, they all are in the proper headers already for a long time.
by fireball＠svn.reactos.org 27 Feb '08

27 Feb '08

Author: fireball Date: Wed Feb 27 23:35:51 2008 New Revision: 32516 URL: http://svn.reactos.org/svn/reactos?rev=32516&view=rev Log: Code cleanup: - Move NtGlobalFlag declaration to wdm.h (which Emanuele wanted to do since it was committed in revision 1137). - Remove unneeded declarations added by Filip in revision 9660 and Thomas in revision 14058, they all are in the proper headers already for a long time. Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/sysinfo.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ex/sysinfo.c (original) +++ trunk/reactos/ntoskrnl/ex/sysinfo.c Wed Feb 27 23:35:51 2008 @@ -1,12 +1,11 @@ -/* $Id$ - * +/* * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel * FILE: ntoskrnl/ex/sysinfo.c * PURPOSE: System information functions * * PROGRAMMERS: David Welch (welch(a)mcmail.com) - * Aleksey Bragin (aleksey(a)studiocerebral.com) + * Aleksey Bragin (aleksey(a)reactos.org) */ /* INCLUDES *****************************************************************/ @@ -14,10 +13,6 @@ #include <ntoskrnl.h> #define NDEBUG #include <internal/debug.h> - -extern PEPROCESS PsIdleProcess; -extern ULONG NtGlobalFlag; /* FIXME: it should go in a ddk/?.h */ -ULONGLONG STDCALL KeQueryInterruptTime(VOID); VOID MmPrintMemoryStatistic(VOID); @@ -159,10 +154,8 @@ * @implemented */ VOID -STDCALL -ExGetCurrentProcessorCpuUsage ( - PULONG CpuUsage - ) +NTAPI +ExGetCurrentProcessorCpuUsage(PULONG CpuUsage) { PKPRCB Prcb; ULONG TotalTime; @@ -182,12 +175,10 @@ * @implemented */ VOID -STDCALL -ExGetCurrentProcessorCounts ( - PULONG ThreadKernelTime, - PULONG TotalCpuTime, - PULONG ProcessorNumber - ) +NTAPI +ExGetCurrentProcessorCounts(PULONG ThreadKernelTime, + PULONG TotalCpuTime, + PULONG ProcessorNumber) { PKPRCB Prcb; @@ -202,7 +193,7 @@ * @implemented */ BOOLEAN -STDCALL +NTAPI ExIsProcessorFeaturePresent(IN ULONG ProcessorFeature) { /* Quick check to see if it exists at all */ @@ -216,14 +207,15 @@ * @implemented */ BOOLEAN -STDCALL +NTAPI ExVerifySuite(SUITE_TYPE SuiteType) { if (SuiteType == Personal) return TRUE; return FALSE; } -NTSTATUS STDCALL +NTSTATUS +NTAPI NtQuerySystemEnvironmentValue (IN PUNICODE_STRING VariableName, OUT PWSTR ValueBuffer, IN ULONG ValueBufferLength, @@ -372,7 +364,7 @@ } -NTSTATUS STDCALL +NTSTATUS NTAPI NtSetSystemEnvironmentValue (IN PUNICODE_STRING VariableName, IN PUNICODE_STRING Value) { @@ -1797,7 +1789,7 @@ /* * @implemented */ -NTSTATUS STDCALL +NTSTATUS NTAPI NtQuerySystemInformation (IN SYSTEM_INFORMATION_CLASS SystemInformationClass, OUT PVOID SystemInformation, IN ULONG Length, @@ -1861,7 +1853,7 @@ NTSTATUS -STDCALL +NTAPI NtSetSystemInformation ( IN SYSTEM_INFORMATION_CLASS SystemInformationClass, IN PVOID SystemInformation, @@ -1911,7 +1903,7 @@ NTSTATUS -STDCALL +NTAPI NtFlushInstructionCache ( IN HANDLE ProcessHandle, IN PVOID BaseAddress,

1 0

[fireball] 32515: - Automatically create an entry for ntldr-style booting of ReactOS kernel in freeldr.ini. - = EXPERIMENTAL, IT WON'T WORK YET, SO DON'T COMPLAIN = -
by fireball＠svn.reactos.org 27 Feb '08

27 Feb '08

Author: fireball Date: Wed Feb 27 23:13:34 2008 New Revision: 32515 URL: http://svn.reactos.org/svn/reactos?rev=32515&view=rev Log: - Automatically create an entry for ntldr-style booting of ReactOS kernel in freeldr.ini. - = EXPERIMENTAL, IT WON'T WORK YET, SO DON'T COMPLAIN = - Modified: trunk/reactos/base/setup/usetup/bootsup.c Modified: trunk/reactos/base/setup/usetup/bootsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/setup/usetup/bootsup.… ============================================================================== --- trunk/reactos/base/setup/usetup/bootsup.c (original) +++ trunk/reactos/base/setup/usetup/bootsup.c Wed Feb 27 23:13:34 2008 @@ -380,6 +380,13 @@ L"ReactOS_Debug", L"\"ReactOS (Debug)\""); + /* ReactOS_WinLdr="ReactOS (WinLdr)" */ + IniCacheInsertKey(IniSection, + NULL, + INSERT_LAST, + L"ReactOS_WinLdr", + L"\"ReactOS (WinLdr)\""); + /* Create "ReactOS" section */ IniSection = IniCacheAppendSection(IniCache, L"ReactOS"); @@ -415,6 +422,31 @@ INSERT_LAST, L"BootType", L"ReactOS"); + + /* SystemPath=<ArcPath> */ + IniCacheInsertKey(IniSection, + NULL, + INSERT_LAST, + L"SystemPath", + ArcPath); + + /* Options=/DEBUG /DEBUGPORT=COM1 /BAUDRATE=115200 /SOS*/ + IniCacheInsertKey(IniSection, + NULL, + INSERT_LAST, + L"Options", + L"/DEBUG /DEBUGPORT=COM1 /BAUDRATE=115200 /SOS"); + + /* Create "ReactOS_WinLdr" section */ + IniSection = IniCacheAppendSection(IniCache, + L"ReactOS_WinLdr"); + + /* BootType=ReactOS */ + IniCacheInsertKey(IniSection, + NULL, + INSERT_LAST, + L"BootType", + L"Windows2003"); /* SystemPath=<ArcPath> */ IniCacheInsertKey(IniSection,

1 0

[cfinck] 32514: The C99 __VA_ARGS__ is also supported under GCC, no reason to add a compiler switch here and use ##args for GCC
by cfinck＠svn.reactos.org 27 Feb '08

27 Feb '08

Author: cfinck Date: Wed Feb 27 22:58:48 2008 New Revision: 32514 URL: http://svn.reactos.org/svn/reactos?rev=32514&view=rev Log: The C99 __VA_ARGS__ is also supported under GCC, no reason to add a compiler switch here and use ##args for GCC Modified: trunk/reactos/include/reactos/debug.h Modified: trunk/reactos/include/reactos/debug.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/debug.h?re… ============================================================================== --- trunk/reactos/include/reactos/debug.h (original) +++ trunk/reactos/include/reactos/debug.h Wed Feb 27 22:58:48 2008 @@ -107,31 +107,16 @@ #define CHECKPOINT #endif - #define UNIMPLEMENTED \ - DbgPrint("WARNING: %s at %s:%d is UNIMPLEMENTED!\n",__FUNCTION__,__FILE__,__LINE__); + #define UNIMPLEMENTED DbgPrint("WARNING: %s at %s:%d is UNIMPLEMENTED!\n",__FUNCTION__,__FILE__,__LINE__); - #if defined(__GNUC__) - #define ERR_(ch, args...) DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_ERROR_LEVEL, "(%s:%d) ", __FILE__, __LINE__), \ - DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_ERROR_LEVEL, ##args) - #define WARN_(ch, args...) DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_WARNING_LEVEL, "(%s:%d) ", __FILE__, __LINE__), \ - DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_WARNING_LEVEL, ##args) - #define TRACE_(ch, args...) DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_TRACE_LEVEL, "(%s:%d) ", __FILE__, __LINE__), \ - DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_TRACE_LEVEL, ##args) - #define INFO_(ch, args...) DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_INFO_LEVEL, "(%s:%d) ", __FILE__, __LINE__), \ - DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_INFO_LEVEL, ##args) - #elif defined(_MSC_VER) #define ERR_(ch, ...) DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_ERROR_LEVEL, "(%s:%d) ", __FILE__, __LINE__), \ - DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_ERROR_LEVEL, __VA_ARGS__) + DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_ERROR_LEVEL, __VA_ARGS__) #define WARN_(ch, ...) DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_WARNING_LEVEL, "(%s:%d) ", __FILE__, __LINE__), \ - DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_WARNING_LEVEL, __VA_ARGS__) + DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_WARNING_LEVEL, __VA_ARGS__) #define TRACE_(ch, ...) DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_TRACE_LEVEL, "(%s:%d) ", __FILE__, __LINE__), \ - DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_TRACE_LEVEL, __VA_ARGS__) + DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_TRACE_LEVEL, __VA_ARGS__) #define INFO_(ch, ...) DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_INFO_LEVEL, "(%s:%d) ", __FILE__, __LINE__), \ - DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_INFO_LEVEL, __VA_ARGS__) - #else - #error Unknown compiler - #endif - + DbgPrintEx(DPFLTR_##ch##_ID, DPFLTR_INFO_LEVEL, __VA_ARGS__) #else /* On non-debug builds, we never show these */

1 0

[cfinck] 32513: - Remove an unneeded MSVC block in windef.h and indent the definition of the "min" and "max" macros - Shuffle the header inclusion order in charmap around, so that it compiles warning-free under MSVC (at /W3)
by cfinck＠svn.reactos.org 27 Feb '08

27 Feb '08

Author: cfinck Date: Wed Feb 27 17:57:47 2008 New Revision: 32513 URL: http://svn.reactos.org/svn/reactos?rev=32513&view=rev Log: - Remove an unneeded MSVC block in windef.h and indent the definition of the "min" and "max" macros - Shuffle the header inclusion order in charmap around, so that it compiles warning-free under MSVC (at /W3) Modified: trunk/reactos/base/applications/charmap/precomp.h trunk/reactos/include/psdk/windef.h Modified: trunk/reactos/base/applications/charmap/precomp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… ============================================================================== --- trunk/reactos/base/applications/charmap/precomp.h (original) +++ trunk/reactos/base/applications/charmap/precomp.h Wed Feb 27 17:57:47 2008 @@ -1,7 +1,9 @@ #ifndef __CHARMAP_PRECOMP_H #define __CHARMAP_PRECOMP_H + +#include <stdio.h> +#include <stdlib.h> #include <windows.h> -#include <stdio.h> #include <commctrl.h> #include "resource.h" Modified: trunk/reactos/include/psdk/windef.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/windef.h?rev=… ============================================================================== --- trunk/reactos/include/psdk/windef.h (original) +++ trunk/reactos/include/psdk/windef.h Wed Feb 27 17:57:47 2008 @@ -160,21 +160,14 @@ #endif #endif -#if defined(_MSC_VER) && defined(__cplusplus) - -#include <stdlib.h> -#define min __min -#define max __max - -#elif !defined(_MSC_VER) && !defined(NOMINMAX) - -#ifndef max -#define max(a,b) ((a)>(b)?(a):(b)) -#endif -#ifndef min -#define min(a,b) ((a)<(b)?(a):(b)) -#endif - +#ifndef NOMINMAX + #ifndef max + #define max(a,b) ((a)>(b)?(a):(b)) + #endif + + #ifndef min + #define min(a,b) ((a)<(b)?(a):(b)) + #endif #endif #define UNREFERENCED_PARAMETER(P) {(P)=(P);}

1 0

[cwittich] 32512: don't link to ntdll
by cwittich＠svn.reactos.org 27 Feb '08

27 Feb '08

Author: cwittich Date: Wed Feb 27 17:27:49 2008 New Revision: 32512 URL: http://svn.reactos.org/svn/reactos?rev=32512&view=rev Log: don't link to ntdll Modified: trunk/reactos/base/applications/charmap/charmap.rbuild Modified: trunk/reactos/base/applications/charmap/charmap.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… ============================================================================== --- trunk/reactos/base/applications/charmap/charmap.rbuild (original) +++ trunk/reactos/base/applications/charmap/charmap.rbuild Wed Feb 27 17:27:49 2008 @@ -4,7 +4,6 @@ <include base="charmap">.</include> <define name="_WIN32_IE">0x600</define> <define name="_WIN32_WINNT">0x501</define> - <library>ntdll</library> <library>gdi32</library> <library>kernel32</library> <library>user32</library>

1 0

[cwittich] 32511: revert last change - it is a problem with reactos psdk headers
by cwittich＠svn.reactos.org 27 Feb '08

27 Feb '08

Author: cwittich Date: Wed Feb 27 17:15:57 2008 New Revision: 32511 URL: http://svn.reactos.org/svn/reactos?rev=32511&view=rev Log: revert last change - it is a problem with reactos psdk headers Modified: trunk/reactos/base/applications/charmap/precomp.h Modified: trunk/reactos/base/applications/charmap/precomp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… ============================================================================== --- trunk/reactos/base/applications/charmap/precomp.h (original) +++ trunk/reactos/base/applications/charmap/precomp.h Wed Feb 27 17:15:57 2008 @@ -4,7 +4,6 @@ #include <stdio.h> #include <commctrl.h> #include "resource.h" -#include <stdlib.h> #define XCELLS 20 #define YCELLS 10

1 0

[cwittich] 32510: fix msvc build
by cwittich＠svn.reactos.org 27 Feb '08

27 Feb '08

Author: cwittich Date: Wed Feb 27 17:14:16 2008 New Revision: 32510 URL: http://svn.reactos.org/svn/reactos?rev=32510&view=rev Log: fix msvc build Modified: trunk/reactos/base/applications/charmap/precomp.h Modified: trunk/reactos/base/applications/charmap/precomp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/… ============================================================================== --- trunk/reactos/base/applications/charmap/precomp.h (original) +++ trunk/reactos/base/applications/charmap/precomp.h Wed Feb 27 17:14:16 2008 @@ -4,6 +4,7 @@ #include <stdio.h> #include <commctrl.h> #include "resource.h" +#include <stdlib.h> #define XCELLS 20 #define YCELLS 10

1 0

[cwittich] 32509: rc doesn't like \" - use "" instead
by cwittich＠svn.reactos.org 27 Feb '08

27 Feb '08

Author: cwittich Date: Wed Feb 27 16:51:10 2008 New Revision: 32509 URL: http://svn.reactos.org/svn/reactos?rev=32509&view=rev Log: rc doesn't like \" - use "" instead Modified: trunk/reactos/dll/cpl/appwiz-new/lang/it-IT.rc Modified: trunk/reactos/dll/cpl/appwiz-new/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/appwiz-new/lang/it… ============================================================================== --- trunk/reactos/dll/cpl/appwiz-new/lang/it-IT.rc (original) +++ trunk/reactos/dll/cpl/appwiz-new/lang/it-IT.rc Wed Feb 27 16:51:10 2008 @@ -105,7 +105,7 @@ FONT 8, "MS Shell Dlg" BEGIN CONTROL "", IDB_WATERMARK, "STATIC", SS_BITMAP | SS_REALSIZEIMAGE, 0, 0, WATERMARK_WIDTH, SHORTCUTDLG_HEIGHT - LTEXT "Cliccando fine verranno ripristinate le mappature di \"ini\".", IDC_HEADTEXT, 98, 7, 196, 40 + LTEXT "Cliccando fine verranno ripristinate le mappature di ""ini.""", IDC_HEADTEXT, 98, 7, 196, 40 END IDD_AFTERINST DIALOG 0, 0, SHORTCUTDLG_WIDTH, SHORTCUTDLG_HEIGHT

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs February 2008