Ros-diffs July 2008

ros-diffs@reactos.org

25 participants
761 discussions

[pschweitzer] 34278: Apply same fix to trunk, but without commented out code. This fixes ReactOS freezes when installing VMware driver using vmwinst and browsing a NTFS volume...

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Thu Jul 3 02:32:14 2008 New Revision: 34278 URL: http://svn.reactos.org/svn/reactos?rev=34278&view=rev Log: Apply same fix to trunk, but without commented out code. This fixes ReactOS freezes when installing VMware driver using vmwinst and browsing a NTFS volume... Modified: trunk/reactos/drivers/filesystems/ntfs/fcb.c Modified: trunk/reactos/drivers/filesystems/ntfs/fcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/ntfs/f… ============================================================================== --- trunk/reactos/drivers/filesystems/ntfs/fcb.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/ntfs/fcb.c [iso-8859-1] Thu Jul 3 02:32:14 2008 @@ -99,8 +99,6 @@ ExInitializeResourceLite(&Fcb->MainResource); Fcb->RFCB.Resource = &(Fcb->MainResource); - - InsertTailList(&(Vcb->FcbListHead), &(Fcb->FcbListEntry)); return(Fcb); } @@ -113,8 +111,6 @@ ASSERT(Fcb->Identifier.Type == NTFS_TYPE_FCB); ExDeleteResourceLite(&Fcb->MainResource); - - RemoveEntryList(&(Fcb->FcbListEntry)); ExFreePool(Fcb); }

16 years, 5 months

[pschweitzer] 34277: When dealing with FCBs list, it must be done synchronized. Because it still freezes, it's commented out. Lists won't be used yet.

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Thu Jul 3 02:30:50 2008 New Revision: 34277 URL: http://svn.reactos.org/svn/reactos?rev=34277&view=rev Log: When dealing with FCBs list, it must be done synchronized. Because it still freezes, it's commented out. Lists won't be used yet. Modified: branches/pierre-fsd/drivers/filesystems/ntfs/fcb.c Modified: branches/pierre-fsd/drivers/filesystems/ntfs/fcb.c URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/drivers/filesystems/… ============================================================================== --- branches/pierre-fsd/drivers/filesystems/ntfs/fcb.c [iso-8859-1] (original) +++ branches/pierre-fsd/drivers/filesystems/ntfs/fcb.c [iso-8859-1] Thu Jul 3 02:30:50 2008 @@ -97,10 +97,11 @@ } ExInitializeResourceLite(&Fcb->MainResource); - Fcb->RFCB.Resource = &(Fcb->MainResource); - - InsertTailList(&(Vcb->FcbListHead), &(Fcb->FcbListEntry)); + +#if 0 + ExInterlockedInsertTailList(&(Vcb->FcbListHead), &(Fcb->FcbListEntry), &(Vcb->FcbListLock)); +#endif return(Fcb); } @@ -109,12 +110,20 @@ VOID NtfsDestroyFCB(PNTFS_FCB Fcb) { +#if 0 + KIRQL oldIrql; +#endif + ASSERT(Fcb); ASSERT(Fcb->Identifier.Type == NTFS_TYPE_FCB); ExDeleteResourceLite(&Fcb->MainResource); +#if 0 + KeAcquireSpinLock(&(Fcb->Vcb->FcbListLock), &oldIrql); RemoveEntryList(&(Fcb->FcbListEntry)); + KeReleaseSpinLock(&(Fcb->Vcb->FcbListLock), oldIrql); +#endif ExFreePool(Fcb); }

16 years, 5 months

[jimtabor] 34276: GetLastActivePopup is still unimplemented, we return the current window handle if it is valid.

by jimtabor＠svn.reactos.org

Author: jimtabor Date: Thu Jul 3 02:17:32 2008 New Revision: 34276 URL: http://svn.reactos.org/svn/reactos?rev=34276&view=rev Log: GetLastActivePopup is still unimplemented, we return the current window handle if it is valid. Modified: trunk/reactos/dll/win32/user32/windows/window.c Modified: trunk/reactos/dll/win32/user32/windows/window.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/w… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/window.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/windows/window.c [iso-8859-1] Thu Jul 3 02:17:32 2008 @@ -921,8 +921,24 @@ HWND STDCALL GetLastActivePopup(HWND hWnd) { - UNIMPLEMENTED; - return 0; + PWINDOW Wnd, WndParent; + HWND Ret = NULL; + + Wnd = ValidateHwnd(hWnd); + if (Wnd != NULL) + { + _SEH_TRY + { + WndParent = NULL; + Ret = hWnd; + } + _SEH_HANDLE + { + /* Do nothing */ + } + _SEH_END; + } + return Ret; }

16 years, 5 months

[mkupfer] 34275: - Fix to allow characters for computer name as specified in MSDN, even '-' - See issue #3304 for more details.

by mkupfer＠svn.reactos.org

Author: mkupfer Date: Thu Jul 3 02:09:05 2008 New Revision: 34275 URL: http://svn.reactos.org/svn/reactos?rev=34275&view=rev Log: - Fix to allow characters for computer name as specified in MSDN, even '-' - See issue #3304 for more details. Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c Modified: trunk/reactos/dll/win32/kernel32/misc/computername.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/co… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/computername.c [iso-8859-1] Thu Jul 3 02:09:05 2008 @@ -298,22 +298,10 @@ p = (PWCHAR)lpComputerName; while (*p != 0) { - if ((!iswctype (*p, _ALPHA) && !iswctype (*p, _DIGIT)) || - *p == L'!' || - *p == L'@' || - *p == L'#' || - *p == L'$' || - *p == L'%' || - *p == L'^' || - *p == L'&' || - *p == L'\'' || - *p == L')' || - *p == L'(' || - *p == L'.' || - *p == L'_' || - *p == L'{' || - *p == L'}' || - *p == L'~') + if (!(iswalnum(*p) || *p == L'!' || *p == L'@' || *p == L'#' || + *p == L'$' || *p == L'%' || *p == L'^' || *p == L'&' || *p == L'\'' || + *p == L')' || *p == L'(' || *p == L'.' || *p == L'-' || *p == L'_' || + *p == L'{' || *p == L'}' || *p == L'~')) return FALSE; Length++;

16 years, 5 months

[jimtabor] 34274: - Fixed an issue with Avira AntiVir Personal, reported by Christoph von Wittich. - GetLastActivePopup is unimplemented and returns a zero. So User32 locally checks and sees the zero and passes it to win32k for processing. There an (kbug) exception is thrown.

by jimtabor＠svn.reactos.org

Author: jimtabor Date: Thu Jul 3 02:05:50 2008 New Revision: 34274 URL: http://svn.reactos.org/svn/reactos?rev=34274&view=rev Log: - Fixed an issue with Avira AntiVir Personal, reported by Christoph von Wittich. - GetLastActivePopup is unimplemented and returns a zero. So User32 locally checks and sees the zero and passes it to win32k for processing. There an (kbug) exception is thrown. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/window.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/window.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] Thu Jul 3 02:05:50 2008 @@ -3633,6 +3633,8 @@ } Wnd = Window->Wnd; + + if (!Wnd) return 0; // No go on zero. if ((INT)Index >= 0) {

16 years, 5 months

[cwittich] 34273: don't crash when no command line argument is given

by cwittich＠svn.reactos.org

Author: cwittich Date: Thu Jul 3 02:01:19 2008 New Revision: 34273 URL: http://svn.reactos.org/svn/reactos?rev=34273&view=rev Log: don't crash when no command line argument is given Modified: trunk/reactos/tools/gendib/gendib.c Modified: trunk/reactos/tools/gendib/gendib.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/gendib/gendib.c?rev=… ============================================================================== --- trunk/reactos/tools/gendib/gendib.c [iso-8859-1] (original) +++ trunk/reactos/tools/gendib/gendib.c [iso-8859-1] Thu Jul 3 02:01:19 2008 @@ -1025,6 +1025,9 @@ static unsigned DestBpp[] = { 8, 16, 32 }; + if (argc < 2) + return 0; + for (Index = 0; Index < sizeof(DestBpp) / sizeof(DestBpp[0]); Index++) { Generate(argv[1], DestBpp[Index]);

16 years, 5 months

[jimtabor] 34272: Move PostMessage out of gdi into user.

by jimtabor＠svn.reactos.org

Author: jimtabor Date: Thu Jul 3 01:29:30 2008 New Revision: 34272 URL: http://svn.reactos.org/svn/reactos?rev=34272&view=rev Log: Move PostMessage out of gdi into user. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c trunk/reactos/subsystems/win32/win32k/objects/stockobj.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c [iso-8859-1] Thu Jul 3 01:29:30 2008 @@ -540,6 +540,7 @@ ProbeForRead(lpaRgbValues, sizeof(INT), 1); +// Developers: We are thread locked and calling gdi. Ret = IntSetSysColors(cElements, (INT*)lpaElements, (COLORREF*)lpaRgbValues); } _SEH_HANDLE @@ -552,6 +553,10 @@ SetLastNtError(Status); Ret = FALSE; } + if (Ret) + { + UserPostMessage(HWND_BROADCAST, WM_SYSCOLORCHANGE, 0, 0); + } UserLeave(); return Ret; } Modified: trunk/reactos/subsystems/win32/win32k/objects/stockobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/stockobj.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/objects/stockobj.c [iso-8859-1] Thu Jul 3 01:29:30 2008 @@ -189,8 +189,6 @@ Elements++; Colors++; } - UserPostMessage(HWND_BROADCAST, WM_SYSCOLORCHANGE, 0, 0); - return nColors > 0; }

16 years, 5 months

[jimtabor] 34271: Fix MSVC issue.

by jimtabor＠svn.reactos.org

Author: jimtabor Date: Thu Jul 3 00:58:33 2008 New Revision: 34271 URL: http://svn.reactos.org/svn/reactos?rev=34271&view=rev Log: Fix MSVC issue. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/focus.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/focus.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/focus.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/focus.c [iso-8859-1] Thu Jul 3 00:58:33 2008 @@ -108,7 +108,8 @@ if (OldTID != NewTID) { - if ((List = IntWinListChildren(UserGetWindowObject(IntGetDesktopWindow())))) + List = IntWinListChildren(UserGetWindowObject(IntGetDesktopWindow())); + if (List) { for (phWnd = List; *phWnd; ++phWnd) {

16 years, 5 months

[jimtabor] 34270: Bug 972: - Fixes the problem of selecting Explorer START menu than mouse over and clicking another application. - Doesn't fix the problem of selecting Explorer START menu than mouse over to the opened file Explorer and clicking on it. - Why, one might ask? The file Explorer shares the same TID.

by jimtabor＠svn.reactos.org

Author: jimtabor Date: Wed Jul 2 23:51:51 2008 New Revision: 34270 URL: http://svn.reactos.org/svn/reactos?rev=34270&view=rev Log: Bug 972: - Fixes the problem of selecting Explorer START menu than mouse over and clicking another application. - Doesn't fix the problem of selecting Explorer START menu than mouse over to the opened file Explorer and clicking on it. - Why, one might ask? The file Explorer shares the same TID. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/focus.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/focus.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/focus.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/focus.c [iso-8859-1] Wed Jul 2 23:51:51 2008 @@ -96,6 +96,42 @@ MAKEWPARAM(MouseActivate ? WA_CLICKACTIVE : WA_ACTIVE, UserGetWindowLong(hWnd, GWL_STYLE, FALSE) & WS_MINIMIZE), (LPARAM)hWndPrev); + + if (Window && hWndPrev) + { + PWINDOW_OBJECT cWindow; + HWND *List, *phWnd; + HANDLE OldTID = IntGetWndThreadId(UserGetWindowObject(hWndPrev)); + HANDLE NewTID = IntGetWndThreadId(Window); + + DPRINT("SendActiveMessage Old -> %x, New -> %x\n", OldTID, NewTID); + + if (OldTID != NewTID) + { + if ((List = IntWinListChildren(UserGetWindowObject(IntGetDesktopWindow())))) + { + for (phWnd = List; *phWnd; ++phWnd) + { + cWindow = UserGetWindowObject(*phWnd); + if (cWindow && (IntGetWndThreadId(cWindow) == OldTID)) + { // FALSE if the window is being deactivated, + // ThreadId that owns the window being activated. + co_IntSendMessage(*phWnd, WM_ACTIVATEAPP, FALSE, (LPARAM)NewTID); + } + } + for (phWnd = List; *phWnd; ++phWnd) + { + cWindow = UserGetWindowObject(*phWnd); + if (cWindow && (IntGetWndThreadId(cWindow) == NewTID)) + { // TRUE if the window is being activated, + // ThreadId that owns the window being deactivated. + co_IntSendMessage(*phWnd, WM_ACTIVATEAPP, TRUE, (LPARAM)OldTID); + } + } + ExFreePool(List); + } + } + } } }

16 years, 5 months

[silverblade] 34269: Still not happy with my mmdrv from last year, so killed it. Starting again with a better-structured approach...

by silverblade＠svn.reactos.org

Author: silverblade Date: Wed Jul 2 17:27:45 2008 New Revision: 34269 URL: http://svn.reactos.org/svn/reactos?rev=34269&view=rev Log: Still not happy with my mmdrv from last year, so killed it. Starting again with a better-structured approach... Removed: branches/silverblade-audio/dll/win32/mmdrv/TODO branches/silverblade-audio/dll/win32/mmdrv/auxil.c branches/silverblade-audio/dll/win32/mmdrv/common.c branches/silverblade-audio/dll/win32/mmdrv/entry.c branches/silverblade-audio/dll/win32/mmdrv/kernel.c branches/silverblade-audio/dll/win32/mmdrv/midi.c branches/silverblade-audio/dll/win32/mmdrv/mmddk.h branches/silverblade-audio/dll/win32/mmdrv/mmdef.h branches/silverblade-audio/dll/win32/mmdrv/mmdrv.h branches/silverblade-audio/dll/win32/mmdrv/mme.c branches/silverblade-audio/dll/win32/mmdrv/mmioctl.h branches/silverblade-audio/dll/win32/mmdrv/session.c branches/silverblade-audio/dll/win32/mmdrv/utils.c branches/silverblade-audio/dll/win32/mmdrv/wave.c branches/silverblade-audio/dll/win32/mmdrv/wave.h branches/silverblade-audio/dll/win32/mmdrv/wave_io.c Modified: branches/silverblade-audio/dll/win32/mmdrv/mmdrv.def branches/silverblade-audio/dll/win32/mmdrv/mmdrv.rbuild branches/silverblade-audio/lib/drivers/sound/legacy/devname.c [This mail would be too long, it was shortened to contain the URLs only.] Removed: branches/silverblade-audio/dll/win32/mmdrv/TODO URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/auxil.c URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/common.c URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/entry.c URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/kernel.c URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/midi.c URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/mmddk.h URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/mmdef.h URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Modified: branches/silverblade-audio/dll/win32/mmdrv/mmdrv.def URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/mmdrv.h URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Modified: branches/silverblade-audio/dll/win32/mmdrv/mmdrv.rbuild URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/mme.c URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/mmioctl.h URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/session.c URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/utils.c URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/wave.c URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/wave.h URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Removed: branches/silverblade-audio/dll/win32/mmdrv/wave_io.c URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/dll/win32/mmd… Modified: branches/silverblade-audio/lib/drivers/sound/legacy/devname.c URL: http://svn.reactos.org/svn/reactos/branches/silverblade-audio/lib/drivers/s…

16 years, 5 months

← Newer
1
...
69
70
71
72
73
74
75
76
77
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs July 2008