Ros-diffs September 2008

ros-diffs@reactos.org

27 participants
747 discussions

[arty] 36423: Initialize DbgLoadOptions from the start. It would be unitialized if a bootcd was made without having the right section in txtsetup.sif.

by arty＠svn.reactos.org

Author: arty Date: Tue Sep 23 04:36:23 2008 New Revision: 36423 URL: http://svn.reactos.org/svn/reactos?rev=36423&view=rev Log: Initialize DbgLoadOptions from the start. It would be unitialized if a bootcd was made without having the right section in txtsetup.sif. Modified: trunk/reactos/boot/freeldr/freeldr/reactos/setupldr.c Modified: trunk/reactos/boot/freeldr/freeldr/reactos/setupldr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/react… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/reactos/setupldr.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/reactos/setupldr.c [iso-8859-1] Tue Sep 23 04:36:23 2008 @@ -46,7 +46,7 @@ { ULONG i; LPCSTR SourcePath; - LPCSTR LoadOptions, DbgLoadOptions; + LPCSTR LoadOptions, DbgLoadOptions = ""; LPCSTR sourcePaths[] = { "", /* Only for floppy boot */ #if defined(_M_IX86) @@ -153,8 +153,6 @@ if (!InfGetDataField (&InfContext, 1, &DbgLoadOptions)) DbgLoadOptions = ""; } -#else - DbgLoadOptions = ""; #endif if (!strlen(DbgLoadOptions) && !InfFindFirstLine (InfHandle, "SetupData",

16 years, 3 months

[arty] 36422: Count the end of the szApplicationName in the right units. (coverity 551).

by arty＠svn.reactos.org

Author: arty Date: Tue Sep 23 04:28:44 2008 New Revision: 36422 URL: http://svn.reactos.org/svn/reactos?rev=36422&view=rev Log: Count the end of the szApplicationName in the right units. (coverity 551). Modified: trunk/reactos/base/system/winlogon/screensaver.c Modified: trunk/reactos/base/system/winlogon/screensaver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/winlogon/scree… ============================================================================== --- trunk/reactos/base/system/winlogon/screensaver.c [iso-8859-1] (original) +++ trunk/reactos/base/system/winlogon/screensaver.c [iso-8859-1] Tue Sep 23 04:28:44 2008 @@ -243,7 +243,7 @@ HKEY hKey = NULL; WCHAR szApplicationName[MAX_PATH]; WCHAR szCommandLine[MAX_PATH + 3]; - DWORD bufferSize = sizeof(szApplicationName)- 1; + DWORD bufferSize = (sizeof(szApplicationName) / sizeof(WCHAR)) - 1; DWORD dwType; STARTUPINFOW StartupInfo; PROCESS_INFORMATION ProcessInformation;

16 years, 3 months

[arty] 36421: Fix a legitimate overrun in _widths (coverity 575), and try not to be as clever.

by arty＠svn.reactos.org

Author: arty Date: Tue Sep 23 04:09:16 2008 New Revision: 36421 URL: http://svn.reactos.org/svn/reactos?rev=36421&view=rev Log: Fix a legitimate overrun in _widths (coverity 575), and try not to be as clever. Modified: trunk/reactos/base/shell/explorer/shell/pane.cpp Modified: trunk/reactos/base/shell/explorer/shell/pane.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/shell/… ============================================================================== --- trunk/reactos/base/shell/explorer/shell/pane.cpp [iso-8859-1] (original) +++ trunk/reactos/base/shell/explorer/shell/pane.cpp [iso-8859-1] Tue Sep 23 04:09:16 2008 @@ -774,8 +774,8 @@ x = _positions[col] + cx; - for(; col<COLUMNS; ) { - _positions[++col] = x; + for(; col<COLUMNS; col++) { + _positions[col+1] = x; x += _widths[col]; }

16 years, 3 months

[arty] 36420: This bug could've caused mayhem in the icon cache. (coverity 790).

by arty＠svn.reactos.org

Author: arty Date: Tue Sep 23 03:58:19 2008 New Revision: 36420 URL: http://svn.reactos.org/svn/reactos?rev=36420&view=rev Log: This bug could've caused mayhem in the icon cache. (coverity 790). Modified: trunk/reactos/base/shell/explorer/shell/entries.cpp Modified: trunk/reactos/base/shell/explorer/shell/entries.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/shell/… ============================================================================== --- trunk/reactos/base/shell/explorer/shell/entries.cpp [iso-8859-1] (original) +++ trunk/reactos/base/shell/explorer/shell/entries.cpp [iso-8859-1] Tue Sep 23 03:58:19 2008 @@ -374,7 +374,7 @@ if (!(flags & ICF_OVERLAYS)) { IExtractIcon* pExtract; if (SUCCEEDED(GetUIObjectOf(0, IID_IExtractIcon, (LPVOID*)&pExtract))) { - unsigned gil_flags; + unsigned gil_flags = 0; int idx; if (flags & ICF_OPEN)

16 years, 3 months

[arty] 36419: Fix possible overrun of the last byte of dbuf (coverity 552).

by arty＠svn.reactos.org

Author: arty Date: Tue Sep 23 03:43:49 2008 New Revision: 36419 URL: http://svn.reactos.org/svn/reactos?rev=36419&view=rev Log: Fix possible overrun of the last byte of dbuf (coverity 552). Modified: trunk/reactos/base/services/dhcp/dhclient.c Modified: trunk/reactos/base/services/dhcp/dhclient.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/dhclien… ============================================================================== --- trunk/reactos/base/services/dhcp/dhclient.c [iso-8859-1] (original) +++ trunk/reactos/base/services/dhcp/dhclient.c [iso-8859-1] Tue Sep 23 03:43:49 2008 @@ -480,9 +480,9 @@ RegSetValueEx( RegKey, "DhcpNameServer", 0, REG_SZ, (LPBYTE)nsbuf, strlen(nsbuf) + 1); - - free( nsbuf ); } + // free(NULL) is defined to be OK too + free( nsbuf ); } } @@ -1706,7 +1706,7 @@ len = ip->client-> config->defaults[i].len + lease->options[i].len; - if (len > sizeof(dbuf)) { + if (len >= sizeof(dbuf)) { warning("no space to %s %s", "prepend option", dhcp_options[i].name);

16 years, 3 months

[cwittich] 36418: overrun of static array Fix for Coverity error CID: 529

by cwittich＠svn.reactos.org

Author: cwittich Date: Tue Sep 23 03:04:57 2008 New Revision: 36418 URL: http://svn.reactos.org/svn/reactos?rev=36418&view=rev Log: overrun of static array Fix for Coverity error CID: 529 Modified: trunk/reactos/base/applications/notepad/text.c Modified: trunk/reactos/base/applications/notepad/text.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/notepad/… ============================================================================== --- trunk/reactos/base/applications/notepad/text.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/notepad/text.c [iso-8859-1] Tue Sep 23 03:04:57 2008 @@ -317,7 +317,7 @@ BOOL WriteText(HANDLE hFile, LPCWSTR pszText, DWORD dwTextLen, int iEncoding, int iEoln) { WCHAR wcBom; - BYTE bEoln[1]; + BYTE bEoln[2]; LPBYTE pbEoln = NULL; DWORD dwDummy, dwPos, dwNext, dwEolnSize = 0;

16 years, 3 months

[fireball] 36417: - The check for SystemHive being non-NULL is meaningless, because CmpInitializeHive is already checked for failure earlier, and in success case it returns a valid Hive. - Fix for Coverity error CID: 280

by fireball＠svn.reactos.org

Author: fireball Date: Tue Sep 23 03:04:23 2008 New Revision: 36417 URL: http://svn.reactos.org/svn/reactos?rev=36417&view=rev Log: - The check for SystemHive being non-NULL is meaningless, because CmpInitializeHive is already checked for failure earlier, and in success case it returns a valid Hive. - Fix for Coverity error CID: 280 Modified: trunk/reactos/ntoskrnl/config/cmsysini.c Modified: trunk/reactos/ntoskrnl/config/cmsysini.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmsysini.c… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmsysini.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cmsysini.c [iso-8859-1] Tue Sep 23 03:04:23 2008 @@ -775,7 +775,7 @@ } /* Save the boot type */ - if (SystemHive) CmpBootType = SystemHive->Hive.BaseBlock->BootType; + CmpBootType = SystemHive->Hive.BaseBlock->BootType; /* Are we in self-healing mode? */ if (!CmSelfHeal)

16 years, 3 months

[cwittich] 36416: overrun of static array Fix for Coverity error CID: 532

by cwittich＠svn.reactos.org

Author: cwittich Date: Tue Sep 23 02:50:59 2008 New Revision: 36416 URL: http://svn.reactos.org/svn/reactos?rev=36416&view=rev Log: overrun of static array Fix for Coverity error CID: 532 Modified: trunk/reactos/dll/win32/kernel32/misc/sysinfo.c Modified: trunk/reactos/dll/win32/kernel32/misc/sysinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/sy… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/sysinfo.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/sysinfo.c [iso-8859-1] Tue Sep 23 02:50:59 2008 @@ -176,7 +176,7 @@ BOOL STDCALL IsProcessorFeaturePresent(DWORD ProcessorFeature) { - if (ProcessorFeature > PROCESSOR_FEATURE_MAX) + if (ProcessorFeature >= PROCESSOR_FEATURE_MAX) return(FALSE); return((BOOL)SharedUserData->ProcessorFeatures[ProcessorFeature]);

16 years, 3 months

[cwittich] 36415: overrun of static array Fix for Coverity error CID: 552

by cwittich＠svn.reactos.org

Author: cwittich Date: Tue Sep 23 02:44:15 2008 New Revision: 36415 URL: http://svn.reactos.org/svn/reactos?rev=36415&view=rev Log: overrun of static array Fix for Coverity error CID: 552 Modified: trunk/reactos/dll/cpl/powercfg/powershemes.c Modified: trunk/reactos/dll/cpl/powercfg/powershemes.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/powercfg/powershem… ============================================================================== --- trunk/reactos/dll/cpl/powercfg/powershemes.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/powercfg/powershemes.c [iso-8859-1] Tue Sep 23 02:44:15 2008 @@ -179,7 +179,7 @@ } } - for(i=0;i<17;i++) + for(i=0;i<16;i++) { if (Sec[i]==pp.user.VideoTimeoutAc) {

16 years, 3 months

[fireball] 36414: - Preinitialize ValueData with NULL. - Fix for Coverity error CID: 772.

by fireball＠svn.reactos.org

Author: fireball Date: Tue Sep 23 02:40:40 2008 New Revision: 36414 URL: http://svn.reactos.org/svn/reactos?rev=36414&view=rev Log: - Preinitialize ValueData with NULL. - Fix for Coverity error CID: 772. Modified: trunk/reactos/ntoskrnl/config/cmapi.c Modified: trunk/reactos/ntoskrnl/config/cmapi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmapi.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmapi.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cmapi.c [iso-8859-1] Tue Sep 23 02:40:40 2008 @@ -732,7 +732,7 @@ BOOLEAN IndexIsCached, ValueIsCached = FALSE; PCELL_DATA CellData; PCM_CACHED_VALUE *CachedValue; - PCM_KEY_VALUE ValueData; + PCM_KEY_VALUE ValueData = NULL; PAGED_CODE(); /* Acquire hive lock */

16 years, 3 months

← Newer
1
...
16
17
18
19
20
21
22
...
75
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2008