Ros-diffs January 2009

ros-diffs@reactos.org

30 participants
755 discussions

[pschweitzer] 39022: Don't leak IRPs in case of failure
by pschweitzer＠svn.reactos.org 22 Jan '09

22 Jan '09

Author: pschweitzer Date: Thu Jan 22 10:47:45 2009 New Revision: 39022 URL: http://svn.reactos.org/svn/reactos?rev=39022&view=rev Log: Don't leak IRPs in case of failure Modified: trunk/reactos/drivers/filesystems/fastfat_new/fsctl.c Modified: trunk/reactos/drivers/filesystems/fastfat_new/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/fsctl.c [iso-8859-1] Thu Jan 22 10:47:45 2009 @@ -100,8 +100,7 @@ /* TODO: Initialize VCB for this volume */ - /* Complete the request and return success */ - FatCompleteRequest(IrpContext, IrpContext->Irp, STATUS_SUCCESS); + /* Return success */ return STATUS_SUCCESS; } @@ -129,6 +128,10 @@ IrpSp->Parameters.MountVolume.DeviceObject, IrpSp->Parameters.MountVolume.Vpb, IrpSp->DeviceObject); + + if (!NT_SUCCESS(Status)) + FatCompleteRequest(IrpContext, Irp, Status); + break; case IRP_MN_VERIFY_VOLUME:

1 0

[dchapyshev] 39021: - Implement SHFlushClipboard (based on msdn info) - Implement DoEnvironmentSubstW (based on DoEnvironmentSubstA) - Add checking of params for SHQueryRecycleBinW
by dchapyshev＠svn.reactos.org 22 Jan '09

22 Jan '09

Author: dchapyshev Date: Thu Jan 22 10:25:31 2009 New Revision: 39021 URL: http://svn.reactos.org/svn/reactos?rev=39021&view=rev Log: - Implement SHFlushClipboard (based on msdn info) - Implement DoEnvironmentSubstW (based on DoEnvironmentSubstA) - Add checking of params for SHQueryRecycleBinW Modified: trunk/reactos/dll/win32/shell32/shellord.c Modified: trunk/reactos/dll/win32/shell32/shellord.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shellord… ============================================================================== --- trunk/reactos/dll/win32/shell32/shellord.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shellord.c [iso-8859-1] Thu Jan 22 10:25:31 2009 @@ -1414,7 +1414,7 @@ * */ HRESULT WINAPI DriveType(int DriveType) -{ +{ WCHAR root[] = L"A:\\"; root[0] = L'A' + DriveType; return GetDriveTypeW(root); @@ -1452,8 +1452,8 @@ * */ HRESULT WINAPI SHFlushClipboard(void) -{ FIXME("stub\n"); - return 1; +{ + return OleFlushClipboard(); } /************************************************************************* @@ -1547,8 +1547,21 @@ */ DWORD WINAPI DoEnvironmentSubstW(LPWSTR pszString, UINT cchString) { - FIXME("(%s, %d): stub\n", debugstr_w(pszString), cchString); - return MAKELONG(FALSE,cchString); + LPWSTR dst; + BOOL res = FALSE; + FIXME("(%s, %d): stub\n", debugstr_w(pszString), cchString); + if ((dst = HeapAlloc(GetProcessHeap(), 0, cchString * sizeof(WCHAR)))) + { + DWORD num = ExpandEnvironmentStringsW(pszString, dst, cchString); + if (num) + { + res = TRUE; + wcscpy(pszString, dst); + } + HeapFree(GetProcessHeap(), 0, dst); + } + + return MAKELONG(res,cchString); } /************************************************************************ @@ -2109,6 +2122,12 @@ { FIXME("%s, %p - stub\n", debugstr_w(pszRootPath), pSHQueryRBInfo); + if (!(pszRootPath) || (pszRootPath[0] == 0) || + !(pSHQueryRBInfo) || (pSHQueryRBInfo->cbSize < sizeof(SHQUERYRBINFO))) + { + return E_INVALIDARG; + } + pSHQueryRBInfo->i64Size = 0; pSHQueryRBInfo->i64NumItems = 0;

1 0

[hyperion] 39020: No harm in deleting this (it was previously disabled in r39016)
by hyperion＠svn.reactos.org 22 Jan '09

22 Jan '09

Author: hyperion Date: Thu Jan 22 10:12:02 2009 New Revision: 39020 URL: http://svn.reactos.org/svn/reactos?rev=39020&view=rev Log: No harm in deleting this (it was previously disabled in r39016) Removed: trunk/rostests/win32/kernel32/tests/

1 0

[tkreuzer] 39019: ks64: Don't truncate the Thread pointer. Silence a warning.
by tkreuzer＠svn.reactos.org 22 Jan '09

22 Jan '09

Author: tkreuzer Date: Thu Jan 22 09:55:21 2009 New Revision: 39019 URL: http://svn.reactos.org/svn/reactos?rev=39019&view=rev Log: ks64: Don't truncate the Thread pointer. Silence a warning. Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/kd64/kdapi.c Modified: branches/ros-amd64-bringup/reactos/ntoskrnl/kd64/kdapi.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/ntosk… ============================================================================== --- branches/ros-amd64-bringup/reactos/ntoskrnl/kd64/kdapi.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/ntoskrnl/kd64/kdapi.c [iso-8859-1] Thu Jan 22 09:55:21 2009 @@ -172,7 +172,7 @@ WaitStateChange->ProcessorLevel = KeProcessorLevel; WaitStateChange->Processor = (USHORT)KeGetCurrentPrcb()->Number; WaitStateChange->NumberProcessors = (ULONG)KeNumberProcessors; - WaitStateChange->Thread = (ULONG)(LONG_PTR)KeGetCurrentThread(); + WaitStateChange->Thread = (LONG_PTR)KeGetCurrentThread(); #if defined(_M_X86_) WaitStateChange->ProgramCounter = (ULONG)(LONG_PTR)Context->Eip; #elif defined(_M_AMD64) @@ -332,6 +332,7 @@ break; default: + RealLength = 0; ControlStart = NULL; ASSERT(FALSE); } @@ -980,7 +981,7 @@ STRING Header, Data; DBGKD_WAIT_STATE_CHANGE64 WaitStateChange; BOOLEAN Status; -FrLdrDbgPrint("Enter KdpReportExceptionStateChange, Rip = 0x%p\n", (PVOID)Context->Rip); + /* Start report loop */ do { @@ -1001,14 +1002,14 @@ /* Setup the trace data */ DumpTraceData(&Data); -FrLdrDbgPrint("KdpReportExceptionStateChange 5\n"); + /* Send State Change packet and wait for a reply */ Status = KdpSendWaitContinue(PACKET_TYPE_KD_STATE_CHANGE64, &Header, &Data, Context); } while (Status == KdPacketNeedsResend); -FrLdrDbgPrint("Leave KdpReportExceptionStateChange, Status = 0x%x\n", Status); + /* Return */ return Status; }

1 0

[cwittich] 39018: sync with wine 1.1.13
by cwittich＠svn.reactos.org 22 Jan '09

22 Jan '09

Author: cwittich Date: Thu Jan 22 09:38:51 2009 New Revision: 39018 URL: http://svn.reactos.org/svn/reactos?rev=39018&view=rev Log: sync with wine 1.1.13 Modified: trunk/reactos/include/psdk/mlang.idl Modified: trunk/reactos/include/psdk/mlang.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/mlang.idl?rev… ============================================================================== --- trunk/reactos/include/psdk/mlang.idl [iso-8859-1] (original) +++ trunk/reactos/include/psdk/mlang.idl [iso-8859-1] Thu Jan 22 09:38:51 2009 @@ -36,7 +36,7 @@ { HRESULT GetCharCodePages( [in] WCHAR chSrc, - DWORD *pdwCodePages); + [out] DWORD *pdwCodePages); HRESULT GetStrCodePages( [in, size_is(cchSrc)] const WCHAR *pszSrc, [in] long cchSrc,

1 0

[cwittich] 39017: add libjpeg enable JPEG support in oleaut32
by cwittich＠svn.reactos.org 22 Jan '09

22 Jan '09

Author: cwittich Date: Thu Jan 22 09:03:45 2009 New Revision: 39017 URL: http://svn.reactos.org/svn/reactos?rev=39017&view=rev Log: add libjpeg enable JPEG support in oleaut32 Added: trunk/reactos/dll/3rdparty/libjpeg/ (with props) trunk/reactos/dll/3rdparty/libjpeg/README (with props) trunk/reactos/dll/3rdparty/libjpeg/ansi2knr.c (with props) trunk/reactos/dll/3rdparty/libjpeg/cderror.h (with props) trunk/reactos/dll/3rdparty/libjpeg/cdjpeg.c (with props) trunk/reactos/dll/3rdparty/libjpeg/cdjpeg.h (with props) trunk/reactos/dll/3rdparty/libjpeg/change.log (with props) trunk/reactos/dll/3rdparty/libjpeg/cjpeg.c (with props) trunk/reactos/dll/3rdparty/libjpeg/ckconfig.c (with props) trunk/reactos/dll/3rdparty/libjpeg/djpeg.c (with props) trunk/reactos/dll/3rdparty/libjpeg/example.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jcapimin.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jcapistd.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jccoefct.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jccolor.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jcdctmgr.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jchuff.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jchuff.h (with props) trunk/reactos/dll/3rdparty/libjpeg/jcinit.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jcmainct.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jcmarker.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jcmaster.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jcomapi.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jconfig.h (with props) trunk/reactos/dll/3rdparty/libjpeg/jcparam.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jcphuff.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jcprepct.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jcsample.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jctrans.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdapimin.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdapistd.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdatadst.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdatasrc.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdcoefct.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdcolor.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdct.h (with props) trunk/reactos/dll/3rdparty/libjpeg/jddctmgr.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdhuff.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdhuff.h (with props) trunk/reactos/dll/3rdparty/libjpeg/jdinput.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdmainct.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdmarker.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdmaster.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdmerge.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdphuff.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdpostct.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdsample.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jdtrans.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jerror.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jerror.h (with props) trunk/reactos/dll/3rdparty/libjpeg/jfdctflt.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jfdctfst.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jfdctint.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jidctflt.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jidctfst.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jidctint.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jidctred.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jinclude.h (with props) trunk/reactos/dll/3rdparty/libjpeg/jmemansi.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jmemmgr.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jmemname.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jmemnobs.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jmemsys.h (with props) trunk/reactos/dll/3rdparty/libjpeg/jmorecfg.h (with props) trunk/reactos/dll/3rdparty/libjpeg/jpegexiforient.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jpegint.h (with props) trunk/reactos/dll/3rdparty/libjpeg/jpeglib.h (with props) trunk/reactos/dll/3rdparty/libjpeg/jpegtran.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jquant1.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jquant2.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jutils.c (with props) trunk/reactos/dll/3rdparty/libjpeg/jversion.h (with props) trunk/reactos/dll/3rdparty/libjpeg/libjpeg.rbuild (with props) trunk/reactos/dll/3rdparty/libjpeg/makefile.ansi (with props) trunk/reactos/dll/3rdparty/libjpeg/rdbmp.c (with props) trunk/reactos/dll/3rdparty/libjpeg/rdcolmap.c (with props) trunk/reactos/dll/3rdparty/libjpeg/rdgif.c (with props) trunk/reactos/dll/3rdparty/libjpeg/rdjpgcom.c (with props) trunk/reactos/dll/3rdparty/libjpeg/rdppm.c (with props) trunk/reactos/dll/3rdparty/libjpeg/rdrle.c (with props) trunk/reactos/dll/3rdparty/libjpeg/rdswitch.c (with props) trunk/reactos/dll/3rdparty/libjpeg/rdtarga.c (with props) trunk/reactos/dll/3rdparty/libjpeg/transupp.c (with props) trunk/reactos/dll/3rdparty/libjpeg/transupp.h (with props) trunk/reactos/dll/3rdparty/libjpeg/wrbmp.c (with props) trunk/reactos/dll/3rdparty/libjpeg/wrgif.c (with props) trunk/reactos/dll/3rdparty/libjpeg/wrjpgcom.c (with props) trunk/reactos/dll/3rdparty/libjpeg/wrppm.c (with props) trunk/reactos/dll/3rdparty/libjpeg/wrrle.c (with props) trunk/reactos/dll/3rdparty/libjpeg/wrtarga.c (with props) trunk/reactos/include/reactos/libs/libjpeg/ (with props) trunk/reactos/include/reactos/libs/libjpeg/cderror.h (with props) trunk/reactos/include/reactos/libs/libjpeg/cdjpeg.h (with props) trunk/reactos/include/reactos/libs/libjpeg/jchuff.h (with props) trunk/reactos/include/reactos/libs/libjpeg/jconfig.h (with props) trunk/reactos/include/reactos/libs/libjpeg/jdct.h (with props) trunk/reactos/include/reactos/libs/libjpeg/jdhuff.h (with props) trunk/reactos/include/reactos/libs/libjpeg/jerror.h (with props) trunk/reactos/include/reactos/libs/libjpeg/jinclude.h (with props) trunk/reactos/include/reactos/libs/libjpeg/jmemsys.h (with props) trunk/reactos/include/reactos/libs/libjpeg/jmorecfg.h (with props) trunk/reactos/include/reactos/libs/libjpeg/jpegint.h (with props) trunk/reactos/include/reactos/libs/libjpeg/jpeglib.h (with props) trunk/reactos/include/reactos/libs/libjpeg/jversion.h (with props) trunk/reactos/include/reactos/libs/libjpeg/transupp.h (with props) Modified: trunk/reactos/boot/bootdata/packages/reactos.dff trunk/reactos/dll/3rdparty/3rdparty.rbuild trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild trunk/reactos/include/reactos/wine/config.h [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/boot/bootdata/packages/reactos.dff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/rea… Modified: trunk/reactos/dll/3rdparty/3rdparty.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/3rdparty.rbui… Added: trunk/reactos/dll/3rdparty/libjpeg/README URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/READM… Added: trunk/reactos/dll/3rdparty/libjpeg/ansi2knr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/ansi2… Added: trunk/reactos/dll/3rdparty/libjpeg/cderror.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/cderr… Added: trunk/reactos/dll/3rdparty/libjpeg/cdjpeg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/cdjpe… Added: trunk/reactos/dll/3rdparty/libjpeg/cdjpeg.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/cdjpe… Added: trunk/reactos/dll/3rdparty/libjpeg/change.log URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/chang… Added: trunk/reactos/dll/3rdparty/libjpeg/cjpeg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/cjpeg… Added: trunk/reactos/dll/3rdparty/libjpeg/ckconfig.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/ckcon… Added: trunk/reactos/dll/3rdparty/libjpeg/djpeg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/djpeg… Added: trunk/reactos/dll/3rdparty/libjpeg/example.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/examp… Added: trunk/reactos/dll/3rdparty/libjpeg/jcapimin.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcapi… Added: trunk/reactos/dll/3rdparty/libjpeg/jcapistd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcapi… Added: trunk/reactos/dll/3rdparty/libjpeg/jccoefct.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jccoe… Added: trunk/reactos/dll/3rdparty/libjpeg/jccolor.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jccol… Added: trunk/reactos/dll/3rdparty/libjpeg/jcdctmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcdct… Added: trunk/reactos/dll/3rdparty/libjpeg/jchuff.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jchuf… Added: trunk/reactos/dll/3rdparty/libjpeg/jchuff.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jchuf… Added: trunk/reactos/dll/3rdparty/libjpeg/jcinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcini… Added: trunk/reactos/dll/3rdparty/libjpeg/jcmainct.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcmai… Added: trunk/reactos/dll/3rdparty/libjpeg/jcmarker.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcmar… Added: trunk/reactos/dll/3rdparty/libjpeg/jcmaster.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcmas… Added: trunk/reactos/dll/3rdparty/libjpeg/jcomapi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcoma… Added: trunk/reactos/dll/3rdparty/libjpeg/jconfig.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jconf… Added: trunk/reactos/dll/3rdparty/libjpeg/jcparam.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcpar… Added: trunk/reactos/dll/3rdparty/libjpeg/jcphuff.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcphu… Added: trunk/reactos/dll/3rdparty/libjpeg/jcprepct.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcpre… Added: trunk/reactos/dll/3rdparty/libjpeg/jcsample.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jcsam… Added: trunk/reactos/dll/3rdparty/libjpeg/jctrans.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jctra… Added: trunk/reactos/dll/3rdparty/libjpeg/jdapimin.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdapi… Added: trunk/reactos/dll/3rdparty/libjpeg/jdapistd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdapi… Added: trunk/reactos/dll/3rdparty/libjpeg/jdatadst.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdata… Added: trunk/reactos/dll/3rdparty/libjpeg/jdatasrc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdata… Added: trunk/reactos/dll/3rdparty/libjpeg/jdcoefct.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdcoe… Added: trunk/reactos/dll/3rdparty/libjpeg/jdcolor.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdcol… Added: trunk/reactos/dll/3rdparty/libjpeg/jdct.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdct.… Added: trunk/reactos/dll/3rdparty/libjpeg/jddctmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jddct… Added: trunk/reactos/dll/3rdparty/libjpeg/jdhuff.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdhuf… Added: trunk/reactos/dll/3rdparty/libjpeg/jdhuff.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdhuf… Added: trunk/reactos/dll/3rdparty/libjpeg/jdinput.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdinp… Added: trunk/reactos/dll/3rdparty/libjpeg/jdmainct.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdmai… Added: trunk/reactos/dll/3rdparty/libjpeg/jdmarker.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdmar… Added: trunk/reactos/dll/3rdparty/libjpeg/jdmaster.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdmas… Added: trunk/reactos/dll/3rdparty/libjpeg/jdmerge.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdmer… Added: trunk/reactos/dll/3rdparty/libjpeg/jdphuff.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdphu… Added: trunk/reactos/dll/3rdparty/libjpeg/jdpostct.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdpos… Added: trunk/reactos/dll/3rdparty/libjpeg/jdsample.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdsam… Added: trunk/reactos/dll/3rdparty/libjpeg/jdtrans.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jdtra… Added: trunk/reactos/dll/3rdparty/libjpeg/jerror.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jerro… Added: trunk/reactos/dll/3rdparty/libjpeg/jerror.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jerro… Added: trunk/reactos/dll/3rdparty/libjpeg/jfdctflt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jfdct… Added: trunk/reactos/dll/3rdparty/libjpeg/jfdctfst.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jfdct… Added: trunk/reactos/dll/3rdparty/libjpeg/jfdctint.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jfdct… Added: trunk/reactos/dll/3rdparty/libjpeg/jidctflt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jidct… Added: trunk/reactos/dll/3rdparty/libjpeg/jidctfst.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jidct… Added: trunk/reactos/dll/3rdparty/libjpeg/jidctint.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jidct… Added: trunk/reactos/dll/3rdparty/libjpeg/jidctred.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jidct… Added: trunk/reactos/dll/3rdparty/libjpeg/jinclude.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jincl… Added: trunk/reactos/dll/3rdparty/libjpeg/jmemansi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jmema… Added: trunk/reactos/dll/3rdparty/libjpeg/jmemmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jmemm… Added: trunk/reactos/dll/3rdparty/libjpeg/jmemname.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jmemn… Added: trunk/reactos/dll/3rdparty/libjpeg/jmemnobs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jmemn… Added: trunk/reactos/dll/3rdparty/libjpeg/jmemsys.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jmems… Added: trunk/reactos/dll/3rdparty/libjpeg/jmorecfg.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jmore… Added: trunk/reactos/dll/3rdparty/libjpeg/jpegexiforient.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jpege… Added: trunk/reactos/dll/3rdparty/libjpeg/jpegint.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jpegi… Added: trunk/reactos/dll/3rdparty/libjpeg/jpeglib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jpegl… Added: trunk/reactos/dll/3rdparty/libjpeg/jpegtran.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jpegt… Added: trunk/reactos/dll/3rdparty/libjpeg/jquant1.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jquan… Added: trunk/reactos/dll/3rdparty/libjpeg/jquant2.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jquan… Added: trunk/reactos/dll/3rdparty/libjpeg/jutils.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jutil… Added: trunk/reactos/dll/3rdparty/libjpeg/jversion.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/jvers… Added: trunk/reactos/dll/3rdparty/libjpeg/libjpeg.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/libjp… Added: trunk/reactos/dll/3rdparty/libjpeg/makefile.ansi URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/makef… Added: trunk/reactos/dll/3rdparty/libjpeg/rdbmp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/rdbmp… Added: trunk/reactos/dll/3rdparty/libjpeg/rdcolmap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/rdcol… Added: trunk/reactos/dll/3rdparty/libjpeg/rdgif.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/rdgif… Added: trunk/reactos/dll/3rdparty/libjpeg/rdjpgcom.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/rdjpg… Added: trunk/reactos/dll/3rdparty/libjpeg/rdppm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/rdppm… Added: trunk/reactos/dll/3rdparty/libjpeg/rdrle.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/rdrle… Added: trunk/reactos/dll/3rdparty/libjpeg/rdswitch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/rdswi… Added: trunk/reactos/dll/3rdparty/libjpeg/rdtarga.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/rdtar… Added: trunk/reactos/dll/3rdparty/libjpeg/transupp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/trans… Added: trunk/reactos/dll/3rdparty/libjpeg/transupp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/trans… Added: trunk/reactos/dll/3rdparty/libjpeg/wrbmp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/wrbmp… Added: trunk/reactos/dll/3rdparty/libjpeg/wrgif.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/wrgif… Added: trunk/reactos/dll/3rdparty/libjpeg/wrjpgcom.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/wrjpg… Added: trunk/reactos/dll/3rdparty/libjpeg/wrppm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/wrppm… Added: trunk/reactos/dll/3rdparty/libjpeg/wrrle.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/wrrle… Added: trunk/reactos/dll/3rdparty/libjpeg/wrtarga.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/3rdparty/libjpeg/wrtar… Modified: trunk/reactos/dll/win32/oleaut32/oleaut32.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oleaut32/oleaut3… Added: trunk/reactos/include/reactos/libs/libjpeg/cderror.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/cdjpeg.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/jchuff.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/jconfig.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/jdct.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/jdhuff.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/jerror.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/jinclude.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/jmemsys.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/jmorecfg.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/jpegint.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/jpeglib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/jversion.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Added: trunk/reactos/include/reactos/libs/libjpeg/transupp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/libjp… Modified: trunk/reactos/include/reactos/wine/config.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/wine/confi…

1 0

[hyperion] 39016: Wow, did you know about "test" modules? Seems nobody does, because they are broken in rbuild. Luckily, kernel32_test is the only such module left
by hyperion＠svn.reactos.org 22 Jan '09

22 Jan '09

Author: hyperion Date: Thu Jan 22 08:50:14 2009 New Revision: 39016 URL: http://svn.reactos.org/svn/reactos?rev=39016&view=rev Log: Wow, did you know about "test" modules? Seems nobody does, because they are broken in rbuild. Luckily, kernel32_test is the only such module left Modified: trunk/rostests/win32/kernel32/directory.rbuild Modified: trunk/rostests/win32/kernel32/directory.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rostests/win32/kernel32/directory.… ============================================================================== --- trunk/rostests/win32/kernel32/directory.rbuild [iso-8859-1] (original) +++ trunk/rostests/win32/kernel32/directory.rbuild [iso-8859-1] Thu Jan 22 08:50:14 2009 @@ -4,7 +4,4 @@ <directory name="queuetest"> <xi:include href="queuetest/queuetest.rbuild" /> </directory> -<directory name="tests"> - <xi:include href="tests/kernel32.rbuild" /> -</directory> </group>

1 0

[cwittich] 39015: Nikolay Sivov <bunglehead@gmail.com> Thu, 22 Jan 2009 12:00:33 +0000 (15:00 +0300) kernel32: Make GetOverlappedResult crash on NULL args as native does.
by cwittich＠svn.reactos.org 22 Jan '09

22 Jan '09

Author: cwittich Date: Thu Jan 22 08:49:59 2009 New Revision: 39015 URL: http://svn.reactos.org/svn/reactos?rev=39015&view=rev Log: Nikolay Sivov <bunglehead(a)gmail.com> Thu, 22 Jan 2009 12:00:33 +0000 (15:00 +0300) kernel32: Make GetOverlappedResult crash on NULL args as native does. Modified: trunk/reactos/dll/win32/ole32/rpc.c Modified: trunk/reactos/dll/win32/ole32/rpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ole32/rpc.c?rev=… ============================================================================== --- trunk/reactos/dll/win32/ole32/rpc.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ole32/rpc.c [iso-8859-1] Thu Jan 22 08:49:59 2009 @@ -1861,6 +1861,7 @@ BOOL multi_use = lsp->multi_use; OVERLAPPED ovl; HANDLE pipe_event; + DWORD bytes; TRACE("Starting threader for %s.\n",debugstr_guid(&lsp->clsid)); @@ -1929,7 +1930,7 @@ } WriteFile(hPipe,buffer,buflen,&res,&ovl); - GetOverlappedResult(hPipe, &ovl, NULL, TRUE); + GetOverlappedResult(hPipe, &ovl, &bytes, TRUE); HeapFree(GetProcessHeap(),0,buffer); FlushFileBuffers(hPipe);

1 0

[cwittich] 39014: add _mbsnbcpy_s to msvcrt (imported from wine)
by cwittich＠svn.reactos.org 22 Jan '09

22 Jan '09

Author: cwittich Date: Thu Jan 22 08:41:57 2009 New Revision: 39014 URL: http://svn.reactos.org/svn/reactos?rev=39014&view=rev Log: add _mbsnbcpy_s to msvcrt (imported from wine) Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.def trunk/reactos/include/crt/mbstring.h trunk/reactos/lib/sdk/crt/mbstring/mbsncpy.c Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.def URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/msvcrt.de… ============================================================================== --- trunk/reactos/dll/win32/msvcrt/msvcrt.def [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msvcrt/msvcrt.def [iso-8859-1] Thu Jan 22 08:41:57 2009 @@ -847,4 +847,6 @@ wprintf @841 wscanf @842 + _mbsnbcpy_s + _swprintf=swprintf Modified: trunk/reactos/include/crt/mbstring.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/mbstring.h?rev… ============================================================================== --- trunk/reactos/include/crt/mbstring.h [iso-8859-1] (original) +++ trunk/reactos/include/crt/mbstring.h [iso-8859-1] Thu Jan 22 08:41:57 2009 @@ -75,6 +75,7 @@ _CRTIMP size_t __cdecl _mbsnbcnt(const unsigned char *_Str,size_t _MaxCount); _CRTIMP size_t __cdecl _mbsnbcnt_l(const unsigned char *_Str,size_t _MaxCount,_locale_t _Locale); _CRTIMP unsigned char *__cdecl _mbsnbcpy(unsigned char *_Dest,const unsigned char *_Source,size_t _Count); + _CRTIMP int __cdecl _mbsnbcpy_s(unsigned char* dst, size_t size, const unsigned char* src, size_t n); _CRTIMP unsigned char *__cdecl _mbsnbcpy_l(unsigned char *_Dest,const unsigned char *_Source,size_t _Count,_locale_t _Locale); _CRTIMP int __cdecl _mbsnbicmp(const unsigned char *_Str1,const unsigned char *_Str2,size_t _MaxCount); _CRTIMP int __cdecl _mbsnbicmp_l(const unsigned char *_Str1,const unsigned char *_Str2,size_t _MaxCount,_locale_t _Locale); Modified: trunk/reactos/lib/sdk/crt/mbstring/mbsncpy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/mbstring/mbsnc… ============================================================================== --- trunk/reactos/lib/sdk/crt/mbstring/mbsncpy.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/mbstring/mbsncpy.c [iso-8859-1] Thu Jan 22 08:41:57 2009 @@ -10,6 +10,7 @@ * */ +#include <precomp.h> #include <mbstring.h> extern int g_mbcp_is_multibyte; @@ -91,3 +92,66 @@ while (n--) *dst++ = 0; return ret; } + +/* + * Unlike _mbsnbcpy this function does not pad the rest of the dest + * string with 0 +*/ +int CDECL _mbsnbcpy_s(unsigned char* dst, size_t size, const unsigned char* src, size_t n) +{ + size_t pos = 0; + + if(!dst || size == 0) + return EINVAL; + if(!src) + { + dst[0] = '\0'; + return EINVAL; + } + if(!n) + return 0; + + if(g_mbcp_is_multibyte) + { + int is_lead = 0; + while (*src && n) + { + if(pos == size) + { + dst[0] = '\0'; + return ERANGE; + } + is_lead = (!is_lead && _ismbblead(*src)); + n--; + dst[pos++] = *src++; + } + + if (is_lead) /* if string ends with a lead, remove it */ + dst[pos - 1] = 0; + } + else + { + while (n) + { + n--; + if(pos == size) + { + dst[0] = '\0'; + return ERANGE; + } + + if(!(*src)) break; + dst[pos++] = *src++; + } + } + + if(pos < size) + dst[pos] = '\0'; + else + { + dst[0] = '\0'; + return ERANGE; + } + + return 0; +}

1 0

[sginsberg] 39013: - Revert the Wine code changes too, as requested on ML
by sginsberg＠svn.reactos.org 22 Jan '09

22 Jan '09

Author: sginsberg Date: Thu Jan 22 07:51:17 2009 New Revision: 39013 URL: http://svn.reactos.org/svn/reactos?rev=39013&view=rev Log: - Revert the Wine code changes too, as requested on ML Removed: trunk/reactos/dll/win32/crypt32/crypt32_ros.diff trunk/reactos/dll/win32/ole32/ole32_ros.diff Modified: trunk/reactos/dll/win32/crypt32/chain.c trunk/reactos/dll/win32/crypt32/main.c trunk/reactos/dll/win32/crypt32/rootstore.c trunk/reactos/dll/win32/cryptui/main.c trunk/reactos/dll/win32/ole32/marshal.c Modified: trunk/reactos/dll/win32/crypt32/chain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/crypt32/chain.c?… ============================================================================== --- trunk/reactos/dll/win32/crypt32/chain.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/crypt32/chain.c [iso-8859-1] Thu Jan 22 07:51:17 2009 @@ -205,7 +205,7 @@ config.cbSize = sizeof(config); CertCreateCertificateChainEngine(&config, &engine); - (void)InterlockedCompareExchangePointer(&CRYPT_defaultChainEngine, engine, + InterlockedCompareExchangePointer(&CRYPT_defaultChainEngine, engine, NULL); if (CRYPT_defaultChainEngine != engine) CertFreeCertificateChainEngine(engine); Removed: trunk/reactos/dll/win32/crypt32/crypt32_ros.diff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/crypt32/crypt32_… ============================================================================== --- trunk/reactos/dll/win32/crypt32/crypt32_ros.diff [iso-8859-1] (original) +++ trunk/reactos/dll/win32/crypt32/crypt32_ros.diff (removed) @@ -1,39 +1,0 @@ -Index: chain.c -=================================================================== ---- chain.c (revision 38919) -+++ chain.c (working copy) -@@ -205,7 +205,7 @@ - - config.cbSize = sizeof(config); - CertCreateCertificateChainEngine(&config, &engine); -- InterlockedCompareExchangePointer(&CRYPT_defaultChainEngine, engine, -+ (void)InterlockedCompareExchangePointer(&CRYPT_defaultChainEngine, engine, - NULL); - if (CRYPT_defaultChainEngine != engine) - CertFreeCertificateChainEngine(engine); -Index: main.c -=================================================================== ---- main.c (revision 38919) -+++ main.c (working copy) -@@ -66,7 +66,7 @@ - - CryptAcquireContextW(&prov, NULL, MS_ENHANCED_PROV_W, PROV_RSA_FULL, - CRYPT_VERIFYCONTEXT); -- InterlockedCompareExchangePointer((PVOID *)&hDefProv, (PVOID)prov, -+ (void)InterlockedCompareExchangePointer((PVOID *)&hDefProv, (PVOID)prov, - NULL); - if (hDefProv != prov) - CryptReleaseContext(prov, 0); -Index: rootstore.c -=================================================================== ---- rootstore.c (revision 38919) -+++ rootstore.c (working copy) -@@ -759,7 +759,7 @@ - { - HCERTSTORE root = create_root_store(); - -- InterlockedCompareExchangePointer((PVOID *)&CRYPT_rootStore, root, -+ (void)InterlockedCompareExchangePointer((PVOID *)&CRYPT_rootStore, root, - NULL); - if (CRYPT_rootStore != root) - CertCloseStore(root, 0); Modified: trunk/reactos/dll/win32/crypt32/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/crypt32/main.c?r… ============================================================================== --- trunk/reactos/dll/win32/crypt32/main.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/crypt32/main.c [iso-8859-1] Thu Jan 22 07:51:17 2009 @@ -66,7 +66,7 @@ CryptAcquireContextW(&prov, NULL, MS_ENHANCED_PROV_W, PROV_RSA_FULL, CRYPT_VERIFYCONTEXT); - (void)InterlockedCompareExchangePointer((PVOID *)&hDefProv, (PVOID)prov, + InterlockedCompareExchangePointer((PVOID *)&hDefProv, (PVOID)prov, NULL); if (hDefProv != prov) CryptReleaseContext(prov, 0); Modified: trunk/reactos/dll/win32/crypt32/rootstore.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/crypt32/rootstor… ============================================================================== --- trunk/reactos/dll/win32/crypt32/rootstore.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/crypt32/rootstore.c [iso-8859-1] Thu Jan 22 07:51:17 2009 @@ -759,7 +759,7 @@ { HCERTSTORE root = create_root_store(); - (void)InterlockedCompareExchangePointer((PVOID *)&CRYPT_rootStore, root, + InterlockedCompareExchangePointer((PVOID *)&CRYPT_rootStore, root, NULL); if (CRYPT_rootStore != root) CertCloseStore(root, 0); Modified: trunk/reactos/dll/win32/cryptui/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/cryptui/main.c?r… ============================================================================== --- trunk/reactos/dll/win32/cryptui/main.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/cryptui/main.c [iso-8859-1] Thu Jan 22 07:51:17 2009 @@ -3277,9 +3277,6 @@ LVCOLUMNW column; PurposeSelection purposeSelection; - /* hack for retarded gcc */ - purposeSelection = 0; - GetWindowRect(lv, &rc); column.mask = LVCF_WIDTH; column.cx = rc.right - rc.left; Modified: trunk/reactos/dll/win32/ole32/marshal.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ole32/marshal.c?… ============================================================================== --- trunk/reactos/dll/win32/ole32/marshal.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ole32/marshal.c [iso-8859-1] Thu Jan 22 07:51:17 2009 @@ -824,7 +824,7 @@ } while (new_dest_context != old_dest_context); if (dest_context_data) - (void)InterlockedExchangePointer(&This->dest_context_data, dest_context_data); + InterlockedExchangePointer(&This->dest_context_data, dest_context_data); } static HRESULT proxy_manager_query_local_interface(struct proxy_manager * This, REFIID riid, void ** ppv) Removed: trunk/reactos/dll/win32/ole32/ole32_ros.diff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ole32/ole32_ros.… ============================================================================== --- trunk/reactos/dll/win32/ole32/ole32_ros.diff [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ole32/ole32_ros.diff (removed) @@ -1,13 +1,0 @@ -Index: marshal.c -=================================================================== ---- marshal.c (revision 38899) -+++ marshal.c (working copy) -@@ -824,7 +824,7 @@ - } while (new_dest_context != old_dest_context); - - if (dest_context_data) -- InterlockedExchangePointer(&This->dest_context_data, dest_context_data); -+ (void)InterlockedExchangePointer(&This->dest_context_data, dest_context_data); - } - - static HRESULT proxy_manager_query_local_interface(struct proxy_manager * This, REFIID riid, void ** ppv)

1 0

← Newer
1
...
21
22
23
24
25
26
27
...
76
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs January 2009