Ros-diffs January 2009

ros-diffs@reactos.org

30 participants
755 discussions

[jimtabor] 38540: - Add check for probed strings. Thanks, Timo and Thomas.

by jimtabor＠svn.reactos.org

Author: jimtabor Date: Sat Jan 3 22:09:19 2009 New Revision: 38540 URL: http://svn.reactos.org/svn/reactos?rev=38540&view=rev Log: - Add check for probed strings. Thanks, Timo and Thomas. Modified: trunk/reactos/subsystems/win32/win32k/ntuser/window.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/window.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/window.c [iso-8859-1] Sat Jan 3 22:09:19 2009 @@ -4548,6 +4548,7 @@ _SEH2_TRY { SafeText = ProbeForReadUnicodeString(WindowText); + ProbeForRead(SafeText.Buffer, SafeText.Length, sizeof(WCHAR)); } _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) {

15 years, 8 months

[cgutman] 38539: - The caller has already built RequestConnectionInfo so don't do it again - Fixes a memory leak

by cgutman＠svn.reactos.org

Author: cgutman Date: Sat Jan 3 20:46:05 2009 New Revision: 38539 URL: http://svn.reactos.org/svn/reactos?rev=38539&view=rev Log: - The caller has already built RequestConnectionInfo so don't do it again - Fixes a memory leak Modified: branches/aicom-network-fixes/drivers/network/afd/afd/tdi.c Modified: branches/aicom-network-fixes/drivers/network/afd/afd/tdi.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-fixes/drivers/net… ============================================================================== --- branches/aicom-network-fixes/drivers/network/afd/afd/tdi.c [iso-8859-1] (original) +++ branches/aicom-network-fixes/drivers/network/afd/afd/tdi.c [iso-8859-1] Sat Jan 3 20:46:05 2009 @@ -420,21 +420,13 @@ return STATUS_INVALID_PARAMETER; } - Status = TdiBuildNullConnectionInfo(RequestConnectionInfo, - TDI_ADDRESS_TYPE_IP); - if (!NT_SUCCESS(Status)) - return Status; - *Irp = TdiBuildInternalDeviceControlIrp(TDI_LISTEN, /* Sub function */ DeviceObject, /* Device object */ ConnectionObject, /* File object */ NULL, /* Event */ Iosb); /* Status */ if (*Irp == NULL) - { - ExFreePool(*RequestConnectionInfo); return STATUS_INSUFFICIENT_RESOURCES; - } TdiBuildListen(*Irp, /* IRP */ DeviceObject, /* Device object */

15 years, 8 months

[weiden] 38538: Fix usage of ProbeForReadUnicodeString

by weiden＠svn.reactos.org

Author: weiden Date: Sat Jan 3 19:50:37 2009 New Revision: 38538 URL: http://svn.reactos.org/svn/reactos?rev=38538&view=rev Log: Fix usage of ProbeForReadUnicodeString Modified: trunk/reactos/ntoskrnl/config/ntapi.c trunk/reactos/ntoskrnl/ob/oblife.c Modified: trunk/reactos/ntoskrnl/config/ntapi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/ntapi.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/config/ntapi.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/ntapi.c [iso-8859-1] Sat Jan 3 19:50:37 2009 @@ -44,11 +44,10 @@ if (Class) { /* Probe it */ - ProbeForReadUnicodeString(Class); + ParseContext.Class = ProbeForReadUnicodeString(Class); ProbeForRead(ParseContext.Class.Buffer, ParseContext.Class.Length, sizeof(WCHAR)); - ParseContext.Class = *Class; } /* Probe the key handle */ Modified: trunk/reactos/ntoskrnl/ob/oblife.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ob/oblife.c?rev=3… ============================================================================== --- trunk/reactos/ntoskrnl/ob/oblife.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ob/oblife.c [iso-8859-1] Sat Jan 3 19:50:37 2009 @@ -374,8 +374,7 @@ if (AccessMode != KernelMode) { /* First Probe the String */ - ProbeForReadUnicodeString(ObjectName); - LocalName = *ObjectName; + LocalName = ProbeForReadUnicodeString(ObjectName); ProbeForRead(LocalName.Buffer, LocalName.Length, sizeof(WCHAR)); } else

15 years, 8 months

[pschweitzer] 38537: Removed avtest.sys from package as it's been removed in r37748. Spotted by Olaf Siejka

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sat Jan 3 15:20:52 2009 New Revision: 38537 URL: http://svn.reactos.org/svn/reactos?rev=38537&view=rev Log: Removed avtest.sys from package as it's been removed in r37748. Spotted by Olaf Siejka Modified: trunk/reactos/boot/bootdata/packages/reactos.dff Modified: trunk/reactos/boot/bootdata/packages/reactos.dff URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/packages/rea… ============================================================================== --- trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/packages/reactos.dff [iso-8859-1] Sat Jan 3 15:20:52 2009 @@ -616,7 +616,6 @@ modules\rosapps\demos\ddraw\ddraw_demo.exe 1 optional modules\rosapps\demos\maze\maze.exe 1 optional modules\rosapps\dflat32\edit.exe 1 optional -modules\rosapps\drivers\avtest\avtest.sys 2 optional modules\rosapps\drivers\green\green.sys 2 optional modules\rosapps\templates\dialog\dialog.exe 1 optional modules\rostests\tests\pseh2\pseh2_test.exe 7 optional

15 years, 8 months

[pschweitzer] 38536: Call IoGetRelatedTargetDevice() where needed

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sat Jan 3 11:31:22 2009 New Revision: 38536 URL: http://svn.reactos.org/svn/reactos?rev=38536&view=rev Log: Call IoGetRelatedTargetDevice() where needed Modified: branches/pierre-fsd/ntoskrnl/io/iomgr/iofunc.c Modified: branches/pierre-fsd/ntoskrnl/io/iomgr/iofunc.c URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/io/iomgr/io… ============================================================================== --- branches/pierre-fsd/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] (original) +++ branches/pierre-fsd/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] Sat Jan 3 11:31:22 2009 @@ -3297,7 +3297,8 @@ } /* Get the device object */ - DeviceObject = IoGetRelatedDeviceObject(FileObject); + Status = IoGetRelatedTargetDevice(FileObject, &DeviceObject); + if (!NT_SUCCESS(Status)) return Status; /* Clear File Object event */ KeClearEvent(&FileObject->Event);

15 years, 8 months

[dgorbachev] 38535: - Add hack-sync again (bug #3591). - Silence linker warning.

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Sat Jan 3 09:51:10 2009 New Revision: 38535 URL: http://svn.reactos.org/svn/reactos?rev=38535&view=rev Log: - Add hack-sync again (bug #3591). - Silence linker warning. Modified: trunk/reactos/ntoskrnl/ke/i386/boot.S trunk/reactos/ntoskrnl/mm/mm.c Modified: trunk/reactos/ntoskrnl/ke/i386/boot.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/boot.S?re… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/boot.S [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/i386/boot.S [iso-8859-1] Sat Jan 3 09:51:10 2009 @@ -29,6 +29,7 @@ /* FUNCTIONS *****************************************************************/ .text +.globl _KiSystemStartup .func KiSystemStartup _KiSystemStartup: Modified: trunk/reactos/ntoskrnl/mm/mm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mm.c?rev=38535… ============================================================================== --- trunk/reactos/ntoskrnl/mm/mm.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/mm.c [iso-8859-1] Sat Jan 3 09:51:10 2009 @@ -34,6 +34,7 @@ PETHREAD Ethread = CONTAINING_RECORD(Thread, ETHREAD, Tcb); /* Hack Sync because Mm is broken */ + MmUpdatePageDir(Process, Ethread, sizeof(ETHREAD)); MmUpdatePageDir(Process, Ethread->ThreadsProcess, sizeof(EPROCESS)); MmUpdatePageDir(Process, (PVOID)Thread->StackLimit,

15 years, 8 months

[dgorbachev] 38534: Consistently use NULL, as suggested by Paolo Devotee.

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Sat Jan 3 09:50:55 2009 New Revision: 38534 URL: http://svn.reactos.org/svn/reactos?rev=38534&view=rev Log: Consistently use NULL, as suggested by Paolo Devotee. Modified: trunk/reactos/dll/win32/kernel32/misc/nls.c Modified: trunk/reactos/dll/win32/kernel32/misc/nls.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/misc/nl… ============================================================================== --- trunk/reactos/dll/win32/kernel32/misc/nls.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/misc/nls.c [iso-8859-1] Sat Jan 3 09:50:55 2009 @@ -208,7 +208,7 @@ sizeof(CodePage) / sizeof(WCHAR))) { /* Last error is set by GetLocaleInfoW. */ - return 0; + return NULL; } } else if (CodePage == CP_MACCP) @@ -219,7 +219,7 @@ sizeof(CodePage) / sizeof(WCHAR))) { /* Last error is set by GetLocaleInfoW. */ - return 0; + return NULL; } }

15 years, 8 months

[sginsberg] 38533: - Switch back to the previous implementation of GetPrivateObjectSecurity now that RtlQuerySecurityObject is implemented (thanks jimtabor)

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Sat Jan 3 09:20:47 2009 New Revision: 38533 URL: http://svn.reactos.org/svn/reactos?rev=38533&view=rev Log: - Switch back to the previous implementation of GetPrivateObjectSecurity now that RtlQuerySecurityObject is implemented (thanks jimtabor) Modified: trunk/reactos/dll/win32/advapi32/sec/misc.c Modified: trunk/reactos/dll/win32/advapi32/sec/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/sec/mis… ============================================================================== --- trunk/reactos/dll/win32/advapi32/sec/misc.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/sec/misc.c [iso-8859-1] Sat Jan 3 09:20:47 2009 @@ -2250,11 +2250,6 @@ } -#if 0 -// -// Use when RtlQuerySecurityObject is implemented -// - /* * @implemented */ @@ -2284,65 +2279,6 @@ /* Success */ return TRUE; } -#else -// -// Wine's implementation (as of December 30th 2008) -// - -/* - * @implemented - */ -BOOL -WINAPI -GetPrivateObjectSecurity(IN PSECURITY_DESCRIPTOR ObjectDescriptor, - IN SECURITY_INFORMATION SecurityInformation, - OUT PSECURITY_DESCRIPTOR ResultantDescriptor OPTIONAL, - IN DWORD DescriptorLength, - OUT PDWORD ReturnLength) -{ - SECURITY_DESCRIPTOR desc; - BOOL defaulted, present; - PACL pacl; - PSID psid; - - TRACE("(%p,0x%08x,%p,0x%08x,%p)\n", ObjectDescriptor, SecurityInformation, - ResultantDescriptor, DescriptorLength, ReturnLength); - - if (!InitializeSecurityDescriptor(&desc, SECURITY_DESCRIPTOR_REVISION)) - return FALSE; - - if (SecurityInformation & OWNER_SECURITY_INFORMATION) - { - if (!GetSecurityDescriptorOwner(ObjectDescriptor, &psid, &defaulted)) - return FALSE; - SetSecurityDescriptorOwner(&desc, psid, defaulted); - } - - if (SecurityInformation & GROUP_SECURITY_INFORMATION) - { - if (!GetSecurityDescriptorGroup(ObjectDescriptor, &psid, &defaulted)) - return FALSE; - SetSecurityDescriptorGroup(&desc, psid, defaulted); - } - - if (SecurityInformation & DACL_SECURITY_INFORMATION) - { - if (!GetSecurityDescriptorDacl(ObjectDescriptor, &present, &pacl, &defaulted)) - return FALSE; - SetSecurityDescriptorDacl(&desc, present, pacl, defaulted); - } - - if (SecurityInformation & SACL_SECURITY_INFORMATION) - { - if (!GetSecurityDescriptorSacl(ObjectDescriptor, &present, &pacl, &defaulted)) - return FALSE; - SetSecurityDescriptorSacl(&desc, present, pacl, defaulted); - } - - *ReturnLength = DescriptorLength; - return MakeSelfRelativeSD(&desc, ResultantDescriptor, ReturnLength); -} -#endif /*

15 years, 8 months

[pschweitzer] 38532: IopGetRelatedTargetDevice: Use IopGetDeviceNode instead of a "ugly triple-casting". Spotted by Alex

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sat Jan 3 08:55:23 2009 New Revision: 38532 URL: http://svn.reactos.org/svn/reactos?rev=38532&view=rev Log: IopGetRelatedTargetDevice: Use IopGetDeviceNode instead of a "ugly triple-casting". Spotted by Alex Modified: branches/pierre-fsd/ntoskrnl/io/iomgr/device.c Modified: branches/pierre-fsd/ntoskrnl/io/iomgr/device.c URL: http://svn.reactos.org/svn/reactos/branches/pierre-fsd/ntoskrnl/io/iomgr/de… ============================================================================== --- branches/pierre-fsd/ntoskrnl/io/iomgr/device.c [iso-8859-1] (original) +++ branches/pierre-fsd/ntoskrnl/io/iomgr/device.c [iso-8859-1] Sat Jan 3 08:55:23 2009 @@ -586,13 +586,13 @@ ASSERT(DeviceRelations->Count == 1); /* We finally get the device node */ - *DeviceNode = ((PEXTENDED_DEVOBJ_EXTENSION)DeviceRelations->Objects[0]->DeviceObjectExtension)->DeviceNode; + *DeviceNode = IopGetDeviceNode(DeviceRelations->Objects[0]); if (!*DeviceNode) { Status = STATUS_NO_SUCH_DEVICE; } - /* Free the DEVICE_RELATIONS structure, it's not needed it anymore */ + /* Free the DEVICE_RELATIONS structure, it's not needed anymore */ ExFreePool(DeviceRelations); }

15 years, 8 months

[fireball] 38531: - Don't leak a FileObject reference in case of failure.

by fireball＠svn.reactos.org

Author: fireball Date: Sat Jan 3 07:23:44 2009 New Revision: 38531 URL: http://svn.reactos.org/svn/reactos?rev=38531&view=rev Log: - Don't leak a FileObject reference in case of failure. Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] Sat Jan 3 07:23:44 2009 @@ -1148,7 +1148,11 @@ PreviousMode, (PVOID *)&Event, NULL); - if (Status != STATUS_SUCCESS) return Status; + if (Status != STATUS_SUCCESS) + { + ObDereferenceObject(FileObject); + return Status; + } KeClearEvent(Event); }

15 years, 8 months

← Newer
1
...
69
70
71
72
73
74
75
76
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs January 2009