Ros-diffs November 2009

ros-diffs@reactos.org

23 participants
444 discussions

[mjmartin] 43925: [user32] - Reapply changes from 40677 as the edit control does not receive the WM_COMMAND message from its context menu when doing clipboard ops. - Fixes crashes in applications created with visual basic when using edit controls context menu. - If we lose this in next sync, ill grovel and beg.

by mjmartin＠svn.reactos.org

Author: mjmartin Date: Mon Nov 2 22:17:50 2009 New Revision: 43925 URL: http://svn.reactos.org/svn/reactos?rev=43925&view=rev Log: [user32] - Reapply changes from 40677 as the edit control does not receive the WM_COMMAND message from its context menu when doing clipboard ops. - Fixes crashes in applications created with visual basic when using edit controls context menu. - If we lose this in next sync, ill grovel and beg. Modified: trunk/reactos/dll/win32/user32/controls/edit.c Modified: trunk/reactos/dll/win32/user32/controls/edit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/controls/… ============================================================================== --- trunk/reactos/dll/win32/user32/controls/edit.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/controls/edit.c [iso-8859-1] Mon Nov 2 22:17:50 2009 @@ -3383,15 +3383,60 @@ /********************************************************************* * - * WM_COMMAND - * - */ -static void EDIT_WM_Command(EDITSTATE *es, INT code, INT id, HWND control) -{ - if (code || control) - return; - - switch (id) { + * WM_CONTEXTMENU + * + * Note: the resource files resource/sysres_??.rc cannot define a + * single popup menu. Hence we use a (dummy) menubar + * containing the single popup menu as its first item. + * + * FIXME: the message identifiers have been chosen arbitrarily, + * hence we use MF_BYPOSITION. + * We might as well use the "real" values (anybody knows ?) + * The menu definition is in resources/sysres_??.rc. + * Once these are OK, we better use MF_BYCOMMAND here + * (as we do in EDIT_WM_Command()). + * + */ +static void EDIT_WM_ContextMenu(EDITSTATE *es, INT x, INT y) +{ +#ifdef __REACTOS__ + HMENU menu = LoadMenuA(User32Instance, "EDITMENU"); +#else + HMENU menu = LoadMenuA(user32_module, "EDITMENU"); +#endif + HMENU popup = GetSubMenu(menu, 0); + UINT start = es->selection_start; + UINT end = es->selection_end; + + BOOL selectedItem; + ORDER_UINT(start, end); + + /* undo */ + EnableMenuItem(popup, 0, MF_BYPOSITION | (EDIT_EM_CanUndo(es) && !(es->style & ES_READONLY) ? MF_ENABLED : MF_GRAYED)); + /* cut */ + EnableMenuItem(popup, 2, MF_BYPOSITION | ((end - start) && !(es->style & ES_PASSWORD) && !(es->style & ES_READONLY) ? MF_ENABLED : MF_GRAYED)); + /* copy */ + EnableMenuItem(popup, 3, MF_BYPOSITION | ((end - start) && !(es->style & ES_PASSWORD) ? MF_ENABLED : MF_GRAYED)); + /* paste */ + EnableMenuItem(popup, 4, MF_BYPOSITION | (IsClipboardFormatAvailable(CF_UNICODETEXT) && !(es->style & ES_READONLY) ? MF_ENABLED : MF_GRAYED)); + /* delete */ + EnableMenuItem(popup, 5, MF_BYPOSITION | ((end - start) && !(es->style & ES_READONLY) ? MF_ENABLED : MF_GRAYED)); + /* select all */ + EnableMenuItem(popup, 7, MF_BYPOSITION | (start || (end != get_text_length(es)) ? MF_ENABLED : MF_GRAYED)); + + if (x == -1 && y == -1) /* passed via VK_APPS press/release */ + { + RECT rc; + /* Windows places the menu at the edit's center in this case */ + GetClientRect(es->hwndSelf, &rc); + MapWindowPoints(es->hwndSelf, 0, (POINT *)&rc, 2); + x = rc.left + (rc.right - rc.left) / 2; + y = rc.top + (rc.bottom - rc.top) / 2; + } + + selectedItem = TrackPopupMenu(popup, TPM_LEFTALIGN | TPM_RIGHTBUTTON | TPM_RETURNCMD, x, y, 0, es->hwndSelf, NULL); + + switch (selectedItem) { case EM_UNDO: SendMessageW(es->hwndSelf, WM_UNDO, 0, 0); break; @@ -3415,62 +3460,7 @@ ERR("unknown menu item, please report\n"); break; } -} - - -/********************************************************************* - * - * WM_CONTEXTMENU - * - * Note: the resource files resource/sysres_??.rc cannot define a - * single popup menu. Hence we use a (dummy) menubar - * containing the single popup menu as its first item. - * - * FIXME: the message identifiers have been chosen arbitrarily, - * hence we use MF_BYPOSITION. - * We might as well use the "real" values (anybody knows ?) - * The menu definition is in resources/sysres_??.rc. - * Once these are OK, we better use MF_BYCOMMAND here - * (as we do in EDIT_WM_Command()). - * - */ -static void EDIT_WM_ContextMenu(EDITSTATE *es, INT x, INT y) -{ -#ifdef __REACTOS__ - HMENU menu = LoadMenuA(User32Instance, "EDITMENU"); -#else - HMENU menu = LoadMenuA(user32_module, "EDITMENU"); -#endif - HMENU popup = GetSubMenu(menu, 0); - UINT start = es->selection_start; - UINT end = es->selection_end; - - ORDER_UINT(start, end); - - /* undo */ - EnableMenuItem(popup, 0, MF_BYPOSITION | (EDIT_EM_CanUndo(es) && !(es->style & ES_READONLY) ? MF_ENABLED : MF_GRAYED)); - /* cut */ - EnableMenuItem(popup, 2, MF_BYPOSITION | ((end - start) && !(es->style & ES_PASSWORD) && !(es->style & ES_READONLY) ? MF_ENABLED : MF_GRAYED)); - /* copy */ - EnableMenuItem(popup, 3, MF_BYPOSITION | ((end - start) && !(es->style & ES_PASSWORD) ? MF_ENABLED : MF_GRAYED)); - /* paste */ - EnableMenuItem(popup, 4, MF_BYPOSITION | (IsClipboardFormatAvailable(CF_UNICODETEXT) && !(es->style & ES_READONLY) ? MF_ENABLED : MF_GRAYED)); - /* delete */ - EnableMenuItem(popup, 5, MF_BYPOSITION | ((end - start) && !(es->style & ES_READONLY) ? MF_ENABLED : MF_GRAYED)); - /* select all */ - EnableMenuItem(popup, 7, MF_BYPOSITION | (start || (end != get_text_length(es)) ? MF_ENABLED : MF_GRAYED)); - - if (x == -1 && y == -1) /* passed via VK_APPS press/release */ - { - RECT rc; - /* Windows places the menu at the edit's center in this case */ - GetClientRect(es->hwndSelf, &rc); - MapWindowPoints(es->hwndSelf, 0, (POINT *)&rc, 2); - x = rc.left + (rc.right - rc.left) / 2; - y = rc.top + (rc.bottom - rc.top) / 2; - } - - TrackPopupMenu(popup, TPM_LEFTALIGN | TPM_RIGHTBUTTON, x, y, 0, es->hwndSelf, NULL); + DestroyMenu(menu); } @@ -5300,11 +5290,7 @@ EDIT_WM_Clear(es); break; - case WM_COMMAND: - EDIT_WM_Command(es, HIWORD(wParam), LOWORD(wParam), (HWND)lParam); - break; - - case WM_CONTEXTMENU: + case WM_CONTEXTMENU: EDIT_WM_ContextMenu(es, (short)LOWORD(lParam), (short)HIWORD(lParam)); break;

15 years, 1 month

[sginsberg] 43924: - Fix a FreeLdr PCI detection bug introduced in revision 10742 5 years ago when PCI detection was added. FindPciBios was setting the HardwareMechanism entry in the PCI_REGISTRY_INFO structure (then called CM_PCI_BUS_DATA) to the wrong register returned from the PCI BIOS: CL instead of AL. CL is the number of the last PCI bus in the system (0 if you only have 1 bus, 1 if you have 2 buses). AL contains bit-fields for PCI characteristics, and HAL checks the 2 first bits to determ

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Mon Nov 2 22:13:45 2009 New Revision: 43924 URL: http://svn.reactos.org/svn/reactos?rev=43924&view=rev Log: - Fix a FreeLdr PCI detection bug introduced in revision 10742 5 years ago when PCI detection was added. FindPciBios was setting the HardwareMechanism entry in the PCI_REGISTRY_INFO structure (then called CM_PCI_BUS_DATA) to the wrong register returned from the PCI BIOS: CL instead of AL. CL is the number of the last PCI bus in the system (0 if you only have 1 bus, 1 if you have 2 buses). AL contains bit-fields for PCI characteristics, and HAL checks the 2 first bits to determine the type of the BUS. My VMWare test environment has 2 PCI buses, so the number happened to be correct. This doesn't work if there is only 1 PCI bus, such as in QEMU and Vbox, as we then get an invalid PCI type of 0. Fix this and re-enable the PCI detection in HAL to properly detect the PCI type instead of assuming type 1. Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/hwpci.c trunk/reactos/hal/halx86/generic/bus/pcibus.c Modified: trunk/reactos/boot/freeldr/freeldr/arch/i386/hwpci.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/i386/hwpci.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/i386/hwpci.c [iso-8859-1] Mon Nov 2 22:13:45 2009 @@ -132,7 +132,7 @@ BusData->NoBuses = RegsOut.b.cl + 1; BusData->MajorRevision = RegsOut.b.bh; BusData->MinorRevision = RegsOut.b.bl; - BusData->HardwareMechanism = RegsOut.b.cl; + BusData->HardwareMechanism = RegsOut.b.al; return TRUE; } Modified: trunk/reactos/hal/halx86/generic/bus/pcibus.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bus/pci… ============================================================================== --- trunk/reactos/hal/halx86/generic/bus/pcibus.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/generic/bus/pcibus.c [iso-8859-1] Mon Nov 2 22:13:45 2009 @@ -938,11 +938,7 @@ ULONG VendorId = 0; /* Query registry information */ -#ifdef WORKED_FOR_ME PciRegistryInfo = HalpQueryPciRegistryInfo(); -#else - PciRegistryInfo = NULL; -#endif if (!PciRegistryInfo) { /* Assume type 1 */

15 years, 1 month

[mjmartin] 43923: [User32] - menu.c: Fix a typo.

by mjmartin＠svn.reactos.org

Author: mjmartin Date: Mon Nov 2 21:38:53 2009 New Revision: 43923 URL: http://svn.reactos.org/svn/reactos?rev=43923&view=rev Log: [User32] - menu.c: Fix a typo. Modified: trunk/reactos/dll/win32/user32/windows/menu.c Modified: trunk/reactos/dll/win32/user32/windows/menu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/menu.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/windows/menu.c [iso-8859-1] Mon Nov 2 21:38:53 2009 @@ -3987,7 +3987,7 @@ Common = (PLOADMENU_CALLBACK_ARGUMENTS) Arguments; Result = (LRESULT)LoadMenuW( Common->hModule, - IS_INTRESOURCE(Common->MenuName) ? + IS_INTRESOURCE(Common->MenuName[0]) ? MAKEINTRESOURCE(Common->MenuName[0]) : (LPCWSTR)&Common->MenuName);

15 years, 1 month

[cgutman] 43922: - Fix some confusion between SignalState and State which resulted in queued IRPs being lost on socket closure - Call HandleSignalledConnection directly because the connection may not be in the signalled connections list - Remove State from CONNECTION_ENDPOINT to prevent this from happening again

by cgutman＠svn.reactos.org

Author: cgutman Date: Mon Nov 2 21:26:29 2009 New Revision: 43922 URL: http://svn.reactos.org/svn/reactos?rev=43922&view=rev Log: - Fix some confusion between SignalState and State which resulted in queued IRPs being lost on socket closure - Call HandleSignalledConnection directly because the connection may not be in the signalled connections list - Remove State from CONNECTION_ENDPOINT to prevent this from happening again Modified: trunk/reactos/drivers/network/tcpip/include/titypes.h trunk/reactos/lib/drivers/ip/transport/tcp/event.c trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c Modified: trunk/reactos/drivers/network/tcpip/include/titypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tcpip/incl… ============================================================================== --- trunk/reactos/drivers/network/tcpip/include/titypes.h [iso-8859-1] (original) +++ trunk/reactos/drivers/network/tcpip/include/titypes.h [iso-8859-1] Mon Nov 2 21:26:29 2009 @@ -299,8 +299,6 @@ PADDRESS_FILE AddressFile; /* Associated address file object (NULL if none) */ PVOID SocketContext; /* Context for lower layer */ - UINT State; /* Socket state W.R.T. oskit */ - /* Requests */ LIST_ENTRY ConnectRequest; /* Queued connect rqueusts */ LIST_ENTRY ListenRequest; /* Queued listen requests */ Modified: trunk/reactos/lib/drivers/ip/transport/tcp/event.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/ip/transport/t… ============================================================================== --- trunk/reactos/lib/drivers/ip/transport/tcp/event.c [iso-8859-1] (original) +++ trunk/reactos/lib/drivers/ip/transport/tcp/event.c [iso-8859-1] Mon Nov 2 21:26:29 2009 @@ -26,7 +26,7 @@ TI_DbgPrint(DEBUG_TCP,("Called: NewState %x (Conn %x) (Change %x)\n", NewState, Connection, - Connection ? Connection->State ^ NewState : + Connection ? Connection->SignalState ^ NewState : NewState)); if( !Connection ) { Modified: trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/ip/transport/t… ============================================================================== --- trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c [iso-8859-1] (original) +++ trunk/reactos/lib/drivers/ip/transport/tcp/tcp.c [iso-8859-1] Mon Nov 2 21:26:29 2009 @@ -601,11 +601,6 @@ return STATUS_NETWORK_UNREACHABLE; } - if (Connection->State & SEL_FIN) - { - return STATUS_REMOTE_DISCONNECT; - } - /* Freed in TCPSocketState */ TI_DbgPrint(DEBUG_TCP, ("Connecting to address %x:%x\n", @@ -683,8 +678,8 @@ ASSERT_LOCKED(&TCPLock); /* Make our code remove all pending IRPs */ - Connection->State |= SEL_FIN; - DrainSignals(); + Connection->SignalState |= SEL_FIN; + HandleSignalledConnection(Connection); Status = TCPTranslateError( OskitTCPClose( Connection->SocketContext ) ); if (Status == STATUS_SUCCESS) @@ -715,13 +710,6 @@ ASSERT_KM_POINTER(Connection->SocketContext); - /* Closing */ - if (Connection->State & SEL_FIN) - { - *BytesReceived = 0; - return STATUS_REMOTE_DISCONNECT; - } - NdisQueryBuffer( Buffer, &DataBuffer, &DataLen ); TI_DbgPrint(DEBUG_TCP,("TCP>|< Got an MDL %x (%x:%d)\n", Buffer, DataBuffer, DataLen)); @@ -786,12 +774,6 @@ TI_DbgPrint(DEBUG_TCP,("Connection->SocketContext = %x\n", Connection->SocketContext)); - /* Closing */ - if (Connection->State & SEL_FIN) - { - *BytesSent = 0; - return STATUS_REMOTE_DISCONNECT; - } Status = TCPTranslateError ( OskitTCPSend( Connection->SocketContext,

15 years, 1 month

[fireball] 43921: [uniata] - Revert 40896, uniata is back to "amazingly fast" mode.

by fireball＠svn.reactos.org

Author: fireball Date: Mon Nov 2 21:18:24 2009 New Revision: 43921 URL: http://svn.reactos.org/svn/reactos?rev=43921&view=rev Log: [uniata] - Revert 40896, uniata is back to "amazingly fast" mode. Modified: trunk/reactos/drivers/storage/ide/uniata/id_ata.cpp Modified: trunk/reactos/drivers/storage/ide/uniata/id_ata.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/uniata… ============================================================================== --- trunk/reactos/drivers/storage/ide/uniata/id_ata.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/ide/uniata/id_ata.cpp [iso-8859-1] Mon Nov 2 21:18:24 2009 @@ -493,10 +493,10 @@ { ULONG i; UCHAR Status; - for (i=0; i<20000; i++) { + for (i=0; i<200; i++) { GetStatus(chan, Status); if (Status & IDE_STATUS_BUSY) { - AtapiStallExecution(150); + AtapiStallExecution(10); continue; } else { break; @@ -537,10 +537,10 @@ { ULONG i; UCHAR Status; - for (i=0; i<20000; i++) { + for (i=0; i<200; i++) { GetBaseStatus(chan, Status); if (Status & IDE_STATUS_BUSY) { - AtapiStallExecution(150); + AtapiStallExecution(10); continue; } else { break; @@ -640,11 +640,11 @@ for (i=0; i<1000; i++) { GetStatus(chan, Status); if (Status & IDE_STATUS_BUSY) { - AtapiStallExecution(100); + AtapiStallExecution(10); } else if (Status & IDE_STATUS_DRQ) { break; } else { - AtapiStallExecution(200); + AtapiStallExecution(10); } } return Status; @@ -661,11 +661,11 @@ for (i=0; i<2; i++) { GetStatus(chan, Status); if (Status & IDE_STATUS_BUSY) { - AtapiStallExecution(100); + AtapiStallExecution(10); } else if (Status & IDE_STATUS_DRQ) { break; } else { - AtapiStallExecution(100); + AtapiStallExecution(10); } } return Status;

15 years, 1 month

[fireball] 43920: [uniata] - Don't wait so long for drive reset. Reapplying r26470 by Dmitriy Gorbachev.

by fireball＠svn.reactos.org

Author: fireball Date: Mon Nov 2 21:12:19 2009 New Revision: 43920 URL: http://svn.reactos.org/svn/reactos?rev=43920&view=rev Log: [uniata] - Don't wait so long for drive reset. Reapplying r26470 by Dmitriy Gorbachev. Modified: trunk/reactos/drivers/storage/ide/uniata/id_ata.cpp Modified: trunk/reactos/drivers/storage/ide/uniata/id_ata.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/uniata… ============================================================================== --- trunk/reactos/drivers/storage/ide/uniata/id_ata.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/ide/uniata/id_ata.cpp [iso-8859-1] Mon Nov 2 21:12:19 2009 @@ -679,7 +679,7 @@ ) { //ULONG c = chan->lChannel; - ULONG i; + ULONG i = 1000 * 1000; UCHAR dma_status = 0; KdPrint2((PRINT_PREFIX "AtapiSoftReset:\n")); UCHAR statusByte2; @@ -689,8 +689,10 @@ SelectDrive(chan, DeviceNumber); AtapiStallExecution(10000); AtapiWritePort1(chan, IDX_IO1_o_Command, IDE_COMMAND_ATAPI_RESET); - for (i = 0; i < 1000; i++) { - AtapiStallExecution(999); + while ((AtapiReadPort1(chan, IDX_IO1_i_Status) & IDE_STATUS_BUSY) && + i--) + { + AtapiStallExecution(30); } SelectDrive(chan, DeviceNumber); WaitOnBusy(chan);

15 years, 1 month

[spetreolle] 43919: add missing newlines

by spetreolle＠svn.reactos.org

Author: spetreolle Date: Mon Nov 2 21:09:00 2009 New Revision: 43919 URL: http://svn.reactos.org/svn/reactos?rev=43919&view=rev Log: add missing newlines Modified: trunk/reactos/base/applications/games/spider/lang/hu-HU.rc trunk/reactos/base/applications/paint/lang/hu-HU.rc Modified: trunk/reactos/base/applications/games/spider/lang/hu-HU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sp… ============================================================================== --- trunk/reactos/base/applications/games/spider/lang/hu-HU.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/games/spider/lang/hu-HU.rc [iso-8859-1] Mon Nov 2 21:09:00 2009 @@ -86,4 +86,4 @@ BEGIN VK_F1, IDM_HELP_CONTENTS, VIRTKEY, NOINVERT VK_F2, IDM_GAME_NEW, VIRTKEY, NOINVERT -END +END Modified: trunk/reactos/base/applications/paint/lang/hu-HU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/paint/la… ============================================================================== --- trunk/reactos/base/applications/paint/lang/hu-HU.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/paint/lang/hu-HU.rc [iso-8859-1] Mon Nov 2 21:09:00 2009 @@ -203,4 +203,4 @@ IDS_SAVEFILTER, "24 bites bitkép (*.bmp;*.dib)\1*.bmp;*.dib\1" IDS_FILESIZE, "%d bájt" IDS_PRINTRES, "%d x %d pixel per méter" -END +END

15 years, 1 month

[khornicek] 43918: - add dsound winetest

by khornicek＠svn.reactos.org

Author: khornicek Date: Mon Nov 2 20:19:39 2009 New Revision: 43918 URL: http://svn.reactos.org/svn/reactos?rev=43918&view=rev Log: - add dsound winetest Added: trunk/rostests/winetests/dsound/ (with props) trunk/rostests/winetests/dsound/capture.c (with props) trunk/rostests/winetests/dsound/ds3d.c (with props) trunk/rostests/winetests/dsound/ds3d8.c (with props) trunk/rostests/winetests/dsound/dsound.c (with props) trunk/rostests/winetests/dsound/dsound.rbuild (with props) trunk/rostests/winetests/dsound/dsound8.c (with props) trunk/rostests/winetests/dsound/dsound_test.h (with props) trunk/rostests/winetests/dsound/duplex.c (with props) trunk/rostests/winetests/dsound/propset.c (with props) trunk/rostests/winetests/dsound/testlist.c (with props) [This mail would be too long, it was shortened to contain the URLs only.] Added: trunk/rostests/winetests/dsound/capture.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/dsound/capture.… Added: trunk/rostests/winetests/dsound/ds3d.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/dsound/ds3d.c?r… Added: trunk/rostests/winetests/dsound/ds3d8.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/dsound/ds3d8.c?… Added: trunk/rostests/winetests/dsound/dsound.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/dsound/dsound.c… Added: trunk/rostests/winetests/dsound/dsound.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/dsound/dsound.r… Added: trunk/rostests/winetests/dsound/dsound8.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/dsound/dsound8.… Added: trunk/rostests/winetests/dsound/dsound_test.h URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/dsound/dsound_t… Added: trunk/rostests/winetests/dsound/duplex.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/dsound/duplex.c… Added: trunk/rostests/winetests/dsound/propset.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/dsound/propset.… Added: trunk/rostests/winetests/dsound/testlist.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/dsound/testlist…

15 years, 1 month

[sginsberg] 43917: - Temporarily disable the new HAL PCI detection code since it fails miserably on the build server.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Mon Nov 2 20:03:01 2009 New Revision: 43917 URL: http://svn.reactos.org/svn/reactos?rev=43917&view=rev Log: - Temporarily disable the new HAL PCI detection code since it fails miserably on the build server. Modified: trunk/reactos/hal/halx86/generic/bus/pcibus.c Modified: trunk/reactos/hal/halx86/generic/bus/pcibus.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bus/pci… ============================================================================== --- trunk/reactos/hal/halx86/generic/bus/pcibus.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/generic/bus/pcibus.c [iso-8859-1] Mon Nov 2 20:03:01 2009 @@ -938,7 +938,11 @@ ULONG VendorId = 0; /* Query registry information */ +#ifdef WORKED_FOR_ME PciRegistryInfo = HalpQueryPciRegistryInfo(); +#else + PciRegistryInfo = NULL; +#endif if (!PciRegistryInfo) { /* Assume type 1 */

15 years, 1 month

[sginsberg] 43916: - Commit something to get build server building -- Revert 20763: "Older binutils don't understand qword ptr", use a newer binutils then.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Mon Nov 2 19:40:24 2009 New Revision: 43916 URL: http://svn.reactos.org/svn/reactos?rev=43916&view=rev Log: - Commit something to get build server building -- Revert 20763: "Older binutils don't understand qword ptr", use a newer binutils then. Modified: trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S Modified: trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/i386/fastinter… ============================================================================== --- trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/i386/fastinterlck_asm.S [iso-8859-1] Mon Nov 2 19:40:24 2009 @@ -410,7 +410,7 @@ _ExpInterlockedPopEntrySListFault@0: mov ebx, [eax] _ExpInterlockedPopEntrySListEnd@0: - LOCK cmpxchg8b [ebp] + LOCK cmpxchg8b qword ptr [ebp] jnz _ExpInterlockedPopEntrySListResume@0 /* Restore registers and return */ @@ -454,7 +454,7 @@ lea ecx, [edx+0x10001] /* Do the exchange */ - LOCK cmpxchg8b [ebp] + LOCK cmpxchg8b qword ptr [ebp] jnz 1b /* Restore registers and return */ @@ -494,7 +494,7 @@ mov cx, bx /* Do the exchange */ - LOCK cmpxchg8b [ebp] + LOCK cmpxchg8b qword ptr [ebp] jnz 1b /* Restore registers and return */ @@ -578,7 +578,7 @@ mov edx, [edx+4] /* Do the op */ - LOCK cmpxchg8b [ebp] + LOCK cmpxchg8b qword ptr [ebp] /* Restore volatiles */ pop ebp @@ -610,7 +610,7 @@ mov edx, [edx+4] /* Do the op */ - LOCK cmpxchg8b [ebp] + LOCK cmpxchg8b qword ptr [ebp] /* Restore volatiles */ pop ebp

15 years, 1 month

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs November 2009