Ros-diffs May 2009

ros-diffs@reactos.org

27 participants
504 discussions

[dgorbachev] 41077: Make __CRT_INLINE always inline, use ceil instead of ceill. Fixed linking when compiling with -O0, it should now work.

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Sat May 23 19:02:28 2009 New Revision: 41077 URL: http://svn.reactos.org/svn/reactos?rev=41077&view=rev Log: Make __CRT_INLINE always inline, use ceil instead of ceill. Fixed linking when compiling with -O0, it should now work. Modified: trunk/reactos/config.template.rbuild trunk/reactos/include/crt/_mingw.h trunk/reactos/subsystems/win32/win32k/objects/drawing.c Modified: trunk/reactos/config.template.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/config.template.rbuild?rev… ============================================================================== --- trunk/reactos/config.template.rbuild [iso-8859-1] (original) +++ trunk/reactos/config.template.rbuild [iso-8859-1] Sat May 23 19:02:28 2009 @@ -42,7 +42,7 @@ <!-- What level of optimisation to use. - 0 = off (will not work) + 0 = off 1 = Default option, optimize for size (-Os) with some additional options 2 = -Os 3 = -O1 Modified: trunk/reactos/include/crt/_mingw.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/_mingw.h?rev=4… ============================================================================== --- trunk/reactos/include/crt/_mingw.h [iso-8859-1] (original) +++ trunk/reactos/include/crt/_mingw.h [iso-8859-1] Sat May 23 19:02:28 2009 @@ -58,9 +58,9 @@ # define __CRT_INLINE inline #else # if ( __MINGW_GNUC_PREREQ(4, 3) && __STDC_VERSION__ >= 199901L) -# define __CRT_INLINE extern inline __attribute__((__gnu_inline__)) +# define __CRT_INLINE extern inline __attribute__((__always_inline__,__gnu_inline__)) # else -# define __CRT_INLINE extern __inline__ +# define __CRT_INLINE extern __inline__ __attribute__((__always_inline__)) # endif #endif Modified: trunk/reactos/subsystems/win32/win32k/objects/drawing.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/drawing.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/objects/drawing.c [iso-8859-1] Sat May 23 19:02:28 2009 @@ -1265,8 +1265,8 @@ { PDC_ATTR pdcattr; PBRUSH pbrush; - int Start = ceill(StartArc); - int End = ceill(EndArc); + int Start = ceil(StartArc); + int End = ceil(EndArc); BOOL Chord = (arctype == GdiTypeChord), ret; pdcattr = dc->pdcattr; @@ -1300,8 +1300,8 @@ ARCTYPE arctype, PBRUSH pbrush) { - int Start = ceill(StartArc); - int End = ceill(EndArc); + int Start = ceil(StartArc); + int End = ceil(EndArc); BOOL Chord = (arctype == GdiTypeChord); // Sort out alignment here. return app_draw_arc(dc, rect( XLeft, YLeft, Width, Height),

15 years, 7 months

[dgorbachev] 41076: Fix buffer overflow, add some debug prints.

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Sat May 23 19:02:19 2009 New Revision: 41076 URL: http://svn.reactos.org/svn/reactos?rev=41076&view=rev Log: Fix buffer overflow, add some debug prints. Modified: trunk/reactos/base/system/smss/smapi.c trunk/reactos/include/reactos/subsys/sm/api.h Modified: trunk/reactos/base/system/smss/smapi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/smss/smapi.c?r… ============================================================================== --- trunk/reactos/base/system/smss/smapi.c [iso-8859-1] (original) +++ trunk/reactos/base/system/smss/smapi.c [iso-8859-1] Sat May 23 19:02:19 2009 @@ -68,7 +68,7 @@ ULONG CallbackPortNameLength = SM_SB_NAME_MAX_LENGTH; /* TODO: compute length */ SB_CONNECT_DATA SbConnectData; ULONG SbConnectDataLength = sizeof SbConnectData; - SECURITY_QUALITY_OF_SERVICE SecurityQos; + SECURITY_QUALITY_OF_SERVICE SecurityQos; DPRINT("SM: %s called\n", __FUNCTION__); @@ -118,7 +118,7 @@ HANDLE ConnectedPort = * (PHANDLE) pConnectedPort; DPRINT("SM: %s called\n", __FUNCTION__); - RtlZeroMemory(&Request, sizeof(SM_PORT_MESSAGE)); + RtlZeroMemory(&Request, sizeof(SM_PORT_MESSAGE)); while (TRUE) { @@ -160,10 +160,13 @@ } } else { /* LPC failed */ + DPRINT1("SM: %s: NtReplyWaitReceivePort() failed (Status=0x%08lx)\n", + __FUNCTION__, Status); break; } } NtClose (ConnectedPort); + DPRINT("SM: %s done\n", __FUNCTION__); NtTerminateThread (NtCurrentThread(), Status); } @@ -267,7 +270,7 @@ __FUNCTION__, Status); return Status; } else { - DPRINT("SM: %s: completing conn req\n", __FUNCTION__); + DPRINT("SM: %s: completing connection request\n", __FUNCTION__); Status = NtCompleteConnectPort (*ClientDataApiPort); if (!NT_SUCCESS(Status)) { @@ -293,6 +296,7 @@ * necessary in NT LPC, because server side connected ports are * never used to receive requests. */ +#if 0 VOID NTAPI SmpApiThread (HANDLE ListeningPort) { @@ -323,7 +327,7 @@ /* DIE */ NtTerminateThread(NtCurrentThread(), Status); } - +#endif /* LPC PORT INITIALIZATION **************************************************/ @@ -338,7 +342,7 @@ SmCreateApiPort(VOID) { OBJECT_ATTRIBUTES ObjectAttributes = {0}; - UNICODE_STRING UnicodeString = RTL_CONSTANT_STRING(L"\\SmApiPort"); + UNICODE_STRING UnicodeString = RTL_CONSTANT_STRING(SM_API_PORT_NAME); NTSTATUS Status = STATUS_SUCCESS; InitializeObjectAttributes(&ObjectAttributes, Modified: trunk/reactos/include/reactos/subsys/sm/api.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/subsys/sm/… ============================================================================== --- trunk/reactos/include/reactos/subsys/sm/api.h [iso-8859-1] (original) +++ trunk/reactos/include/reactos/subsys/sm/api.h [iso-8859-1] Sat May 23 19:02:19 2009 @@ -1,4 +1,3 @@ -/* $Id$ */ #ifndef __SM_API_H #define __SM_API_H @@ -107,7 +106,7 @@ /*** | ****************************************************************/ -typedef union _SM_PORT_MESSAGE +typedef struct _SM_PORT_MESSAGE { /*** LPC common header ***/ PORT_MESSAGE Header; @@ -115,7 +114,6 @@ { struct { - UCHAR LpcHeader[sizeof(PORT_MESSAGE)]; /*** SM common header ***/ struct { @@ -139,7 +137,7 @@ } Reply; }; }; - UCHAR PadBuffer[PORT_MAXIMUM_MESSAGE_LENGTH]; + SM_CONNECT_DATA ConnectData; }; } SM_PORT_MESSAGE, * PSM_PORT_MESSAGE;

15 years, 7 months

[dgorbachev] 41075: Fix compilation of RBuild. Bug #4415.

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Sat May 23 19:01:52 2009 New Revision: 41075 URL: http://svn.reactos.org/svn/reactos?rev=41075&view=rev Log: Fix compilation of RBuild. Bug #4415. Modified: trunk/reactos/tools/rbuild/pch.h Modified: trunk/reactos/tools/rbuild/pch.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/pch.h?rev=410… ============================================================================== --- trunk/reactos/tools/rbuild/pch.h [iso-8859-1] (original) +++ trunk/reactos/tools/rbuild/pch.h [iso-8859-1] Sat May 23 19:01:52 2009 @@ -43,7 +43,7 @@ #endif//WIN32 #include <stdarg.h> - +#include <stdio.h> #ifndef WIN32 #include <string.h>

15 years, 7 months

[khornicek] 41074: - don't return without UserLeave, should fix user32:input winetest crash

by khornicek＠svn.reactos.org

Author: khornicek Date: Sat May 23 17:15:47 2009 New Revision: 41074 URL: http://svn.reactos.org/svn/reactos?rev=41074&view=rev Log: - don't return without UserLeave, should fix user32:input winetest crash Modified: trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c Modified: trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/ntstubs.c [iso-8859-1] Sat May 23 17:15:47 2009 @@ -309,6 +309,7 @@ if ((cbSize != sizeof(MOUSEMOVEPOINT)) || (nBufPoints < 0) || (nBufPoints > 64)) { + UserLeave(); SetLastWin32Error(ERROR_INVALID_PARAMETER); return -1; }

15 years, 7 months

[spetreolle] 41073: Fix one bogus test in setupapi:devclass Ignore only bitmap font tests in gdi32:font

by spetreolle＠svn.reactos.org

Author: spetreolle Date: Sat May 23 16:59:46 2009 New Revision: 41073 URL: http://svn.reactos.org/svn/reactos?rev=41073&view=rev Log: Fix one bogus test in setupapi:devclass Ignore only bitmap font tests in gdi32:font Modified: trunk/rostests/winetests/gdi32/font.c trunk/rostests/winetests/setupapi/devclass.c Modified: trunk/rostests/winetests/gdi32/font.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/gdi32/font.c?re… ============================================================================== --- trunk/rostests/winetests/gdi32/font.c [iso-8859-1] (original) +++ trunk/rostests/winetests/gdi32/font.c [iso-8859-1] Sat May 23 16:59:46 2009 @@ -307,6 +307,9 @@ TEXTMETRICA tm_orig; SIZE size_orig; INT ret, i, width_orig, height_orig, scale, lfWidth; + + skip("ROS-HACK: Skipping bitmap font tests!\n"); + return; hdc = GetDC(0); @@ -2916,8 +2919,6 @@ init(); test_logfont(); - skip("ROS-HACK: Skipping bitmap font tests\n"); - return; test_bitmap_font(); test_outline_font(); test_bitmap_font_metrics(); Modified: trunk/rostests/winetests/setupapi/devclass.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/setupapi/devcla… ============================================================================== --- trunk/rostests/winetests/setupapi/devclass.c [iso-8859-1] (original) +++ trunk/rostests/winetests/setupapi/devclass.c [iso-8859-1] Sat May 23 16:59:46 2009 @@ -119,7 +119,6 @@ SetLastError( 0xdeadbeef ); ok( !SetupDiClassGuidsFromNameA( test_class_name, NULL, 0, &required_size ), "Fail expected\n" ); - SetLastError( 0xdeadbeef ); ok( GetLastError() == ERROR_INSUFFICIENT_BUFFER, "Expected error %lx, got %lx\n", ERROR_INSUFFICIENT_BUFFER, GetLastError() ); ok( required_size > 0, "Expected > 0, got %lu\n", required_size );

15 years, 7 months

[spetreolle] 41072: Fix 2 setupapi:devclass tests

by spetreolle＠svn.reactos.org

Author: spetreolle Date: Sat May 23 16:58:12 2009 New Revision: 41072 URL: http://svn.reactos.org/svn/reactos?rev=41072&view=rev Log: Fix 2 setupapi:devclass tests Modified: trunk/reactos/dll/win32/setupapi/devinst.c Modified: trunk/reactos/dll/win32/setupapi/devinst.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/devinst… ============================================================================== --- trunk/reactos/dll/win32/setupapi/devinst.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/setupapi/devinst.c [iso-8859-1] Sat May 23 16:58:12 2009 @@ -3560,7 +3560,7 @@ else { ERR("Invalid Flags parameter!\n"); - SetLastError(ERROR_INVALID_PARAMETER); + SetLastError(ERROR_INVALID_FLAGS); if (MachineName != NULL) RegCloseKey(HKLM); return INVALID_HANDLE_VALUE; }

15 years, 7 months

[tkreuzer] 41071: ndis.h: Fix definition of NdisQueryPacketLength

by tkreuzer＠svn.reactos.org

Author: tkreuzer Date: Sat May 23 15:40:44 2009 New Revision: 41071 URL: http://svn.reactos.org/svn/reactos?rev=41071&view=rev Log: ndis.h: Fix definition of NdisQueryPacketLength Modified: branches/ros-amd64-bringup/reactos/include/ddk/ndis.h Modified: branches/ros-amd64-bringup/reactos/include/ddk/ndis.h URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/inclu… ============================================================================== --- branches/ros-amd64-bringup/reactos/include/ddk/ndis.h [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/include/ddk/ndis.h [iso-8859-1] Sat May 23 15:40:44 2009 @@ -1997,34 +1997,10 @@ #define NdisQueryPacketLength(Packet, \ TotalPacketLength) \ { \ - if ((TotalPacketLength)) \ - { \ - if (!(Packet)->Private.ValidCounts) { \ - UINT _Offset; \ - UINT _PacketLength; \ - PNDIS_BUFFER _NdisBuffer; \ - UINT _PhysicalBufferCount = 0; \ - UINT _TotalPacketLength = 0; \ - UINT _Count = 0; \ - \ - for (_NdisBuffer = (Packet)->Private.Head; \ - _NdisBuffer != (PNDIS_BUFFER)NULL; \ - _NdisBuffer = _NdisBuffer->Next) \ - { \ - _PhysicalBufferCount += NDIS_BUFFER_TO_SPAN_PAGES(_NdisBuffer); \ - NdisQueryBufferOffset(_NdisBuffer, &_Offset, &_PacketLength); \ - _TotalPacketLength += _PacketLength; \ - _Count++; \ - } \ - (Packet)->Private.PhysicalCount = _PhysicalBufferCount; \ - (Packet)->Private.TotalLength = _TotalPacketLength; \ - (Packet)->Private.Count = _Count; \ - (Packet)->Private.ValidCounts = TRUE; \ - } \ - \ - if (TotalPacketLength) \ - *((PUINT)TotalPacketLength) = (Packet)->Private.TotalLength; \ - } \ + if (!(Packet)->Private.ValidCounts) \ + NdisQueryPacket(Packet, NULL, NULL, NULL, TotalPacketLength); \ + else \ + *(TotalPacketLength) = (Packet)->Private.TotalLength; \ }

15 years, 7 months

[tkreuzer] 41070: tcpip: fix a pointer to ULONG cast

by tkreuzer＠svn.reactos.org

Author: tkreuzer Date: Sat May 23 15:37:02 2009 New Revision: 41070 URL: http://svn.reactos.org/svn/reactos?rev=41070&view=rev Log: tcpip: fix a pointer to ULONG cast Modified: branches/ros-amd64-bringup/reactos/drivers/network/tcpip/datalink/lan.c Modified: branches/ros-amd64-bringup/reactos/drivers/network/tcpip/datalink/lan.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/drive… ============================================================================== --- branches/ros-amd64-bringup/reactos/drivers/network/tcpip/datalink/lan.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/drivers/network/tcpip/datalink/lan.c [iso-8859-1] Sat May 23 15:37:02 2009 @@ -684,7 +684,7 @@ if (Adapter->MTU < PacketLength) { /* This is NOT a pointer. MSDN explicitly says so. */ NDIS_PER_PACKET_INFO_FROM_PACKET(NdisPacket, - TcpLargeSendPacketInfo) = (PVOID)((ULONG)Adapter->MTU); + TcpLargeSendPacketInfo) = (PVOID)((ULONG_PTR)Adapter->MTU); } TcpipAcquireSpinLock( &Adapter->Lock, &OldIrql );

15 years, 7 months

[cwittich] 41069: add some registry values req. by user32 sysparams - patch by encoded

by cwittich＠svn.reactos.org

Author: cwittich Date: Sat May 23 15:11:58 2009 New Revision: 41069 URL: http://svn.reactos.org/svn/reactos?rev=41069&view=rev Log: add some registry values req. by user32 sysparams - patch by encoded Modified: trunk/reactos/boot/bootdata/hivedef_i386.inf Modified: trunk/reactos/boot/bootdata/hivedef_i386.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivedef_i386… ============================================================================== --- trunk/reactos/boot/bootdata/hivedef_i386.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivedef_i386.inf [iso-8859-1] Sat May 23 15:11:58 2009 @@ -21,6 +21,24 @@ HKCU,"Control Panel\Desktop","SCRNSAVE.EXE",0x00000000,"" HKCU,"Control Panel\Desktop","WaitToKillAppTimeout",0x00000002,"20000" HKCU,"Control Panel\Desktop","Wallpaper",0x00000000,"" +HKCU,"Control Panel\Desktop","FontSmoothing",2,"0" +HKCU,"Control Panel\Desktop","DragFullWindows",2,"0" +HKCU,"Control Panel\Desktop","SmoothScroll",3,00,00,00,00 +HKCU,"Control Panel\Desktop","UserPreferenceMask",3,10,00,00,80 +HKCU,"Control Panel\Desktop","LowPowerActive",,"0" +HKCU,"Control Panel\Desktop","MenuShowDelay",2,"400" + +HKCU,"Control Panel\Desktop\WindowMetrics","ScrollWidth",2,"16" +HKCU,"Control Panel\Desktop\WindowMetrics","ScrollHeight",2,"16" +HKCU,"Control Panel\Desktop\WindowMetrics","CaptionWidth",2,"18" +HKCU,"Control Panel\Desktop\WindowMetrics","CaptionHeight",2,"18" +HKCU,"Control Panel\Desktop\WindowMetrics","SmCaptionWidth",2,"13" +HKCU,"Control Panel\Desktop\WindowMetrics","SmCaptionHeight",2,"15" +HKCU,"Control Panel\Desktop\WindowMetrics","MenuWidth",2,"18" +HKCU,"Control Panel\Desktop\WindowMetrics","MenuHeight",2,"18" +HKCU,"Control Panel\Desktop\WindowMetrics","BorderWidth",2,"1" +HKCU,"Control Panel\Desktop\WindowMetrics","Shell Icon Size",2,"32" + HKCU,"Control Panel\International",,0x00000012 HKCU,"Control Panel\International","Locale",0x00000000,"0409" HKCU,"Control Panel\International\Geo","Nation",0x00000000,"1"

15 years, 7 months

[dchapyshev] 41068: - Sync comctl32 with Wine 1.1.22 (without listview.c. Somebody help to sync listview! Now after sync listview there is a bug: http://opendn.org/listview.png)

by dchapyshev＠svn.reactos.org

Author: dchapyshev Date: Sat May 23 14:39:30 2009 New Revision: 41068 URL: http://svn.reactos.org/svn/reactos?rev=41068&view=rev Log: - Sync comctl32 with Wine 1.1.22 (without listview.c. Somebody help to sync listview! Now after sync listview there is a bug: http://opendn.org/listview.png) Modified: trunk/reactos/dll/win32/comctl32/comboex.c trunk/reactos/dll/win32/comctl32/header.c trunk/reactos/dll/win32/comctl32/ipaddress.c trunk/reactos/dll/win32/comctl32/monthcal.c trunk/reactos/dll/win32/comctl32/rebar.c trunk/reactos/dll/win32/comctl32/status.c trunk/reactos/dll/win32/comctl32/syslink.c trunk/reactos/dll/win32/comctl32/tab.c trunk/reactos/dll/win32/comctl32/toolbar.c trunk/reactos/dll/win32/comctl32/tooltips.c trunk/reactos/dll/win32/comctl32/treeview.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/dll/win32/comctl32/comboex.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/comboex… Modified: trunk/reactos/dll/win32/comctl32/header.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/header.… Modified: trunk/reactos/dll/win32/comctl32/ipaddress.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/ipaddre… Modified: trunk/reactos/dll/win32/comctl32/monthcal.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/monthca… Modified: trunk/reactos/dll/win32/comctl32/rebar.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/rebar.c… Modified: trunk/reactos/dll/win32/comctl32/status.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/status.… Modified: trunk/reactos/dll/win32/comctl32/syslink.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/syslink… Modified: trunk/reactos/dll/win32/comctl32/tab.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/tab.c?r… Modified: trunk/reactos/dll/win32/comctl32/toolbar.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/toolbar… Modified: trunk/reactos/dll/win32/comctl32/tooltips.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/tooltip… Modified: trunk/reactos/dll/win32/comctl32/treeview.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/comctl32/treevie…

15 years, 7 months

← Newer
1
...
14
15
16
17
18
19
20
...
51
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs May 2009