ReactOS.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2025
January
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
List overview
Download
Ros-diffs
May 2009
----- 2025 -----
January 2025
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
ros-diffs@reactos.org
27 participants
504 discussions
Start a n
N
ew thread
[cgutman] 40944: - Fix NDIS 3.0 miniport characteristics based on MSDN documentation - Add NDIS 5.1 miniport characteristics also based on MSDN documentation
by cgutman@svn.reactos.org
Author: cgutman Date: Sun May 17 02:43:25 2009 New Revision: 40944 URL:
http://svn.reactos.org/svn/reactos?rev=40944&view=rev
Log: - Fix NDIS 3.0 miniport characteristics based on MSDN documentation - Add NDIS 5.1 miniport characteristics also based on MSDN documentation Modified: trunk/reactos/include/ddk/ndis.h Modified: trunk/reactos/include/ddk/ndis.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ndis.h?rev=409…
============================================================================== --- trunk/reactos/include/ddk/ndis.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/ndis.h [iso-8859-1] Sun May 17 02:43:25 2009 @@ -3708,7 +3708,6 @@ #define NDIS30_MINIPORT_CHARACTERISTICS_S \ UCHAR MajorNdisVersion; \ UCHAR MinorNdisVersion; \ - USHORT Filler; \ UINT Reserved; \ W_CHECK_FOR_HANG_HANDLER CheckForHangHandler; \ W_DISABLE_INTERRUPT_HANDLER DisableInterruptHandler; \ @@ -3720,15 +3719,9 @@ W_QUERY_INFORMATION_HANDLER QueryInformationHandler; \ W_RECONFIGURE_HANDLER ReconfigureHandler; \ W_RESET_HANDLER ResetHandler; \ - _ANONYMOUS_UNION union { \ - W_SEND_HANDLER SendHandler; \ - WM_SEND_HANDLER WanSendHandler; \ - } _UNION_NAME(u1); \ + W_SEND_HANDLER SendHandler; \ W_SET_INFORMATION_HANDLER SetInformationHandler; \ - _ANONYMOUS_UNION union { \ - W_TRANSFER_DATA_HANDLER TransferDataHandler; \ - WM_TRANSFER_DATA_HANDLER WanTransferDataHandler; \ - } _UNION_NAME(u2); + W_TRANSFER_DATA_HANDLER TransferDataHandler; typedef struct _NDIS30_MINIPORT_CHARACTERISTICS { NDIS30_MINIPORT_CHARACTERISTICS_S @@ -3848,10 +3841,42 @@ IN NDIS_HANDLE MiniportAdapterContext, IN PVOID CancelId); +typedef VOID DDKAPI +(*W_PNP_EVENT_NOTIFY_HANDLER)( + IN NDIS_HANDLE MiniportAdapterContext, + IN NDIS_DEVICE_PNP_EVENT PnPEvent, + IN PVOID InformationBuffer, + IN ULONG InformationBufferLength); + +typedef VOID DDKAPI +(*W_MINIPORT_SHUTDOWN_HANDLER)( + IN PVOID ShutdownContext); + +#ifdef __cplusplus + +#define NDIS51_MINIPORT_CHARACTERISTICS_S \ + NDIS50_MINIPORT_CHARACTERISTICS Ndis50Chars; \ + W_CANCEL_SEND_PACKETS_HANDLER CancelSendPacketsHandler; \ + W_PNP_EVENT_NOTIFY_HANDLER PnPEventNotifyHandler; \ + W_MINIPORT_SHUTDOWN_HANDLER AdapterShutdownHandler; + +#else + +#define NDIS51_MINIPORT_CHARACTERISTICS_S \ + NDIS50_MINIPORT_CHARACTERISTICS_S \ + W_CANCEL_SEND_PACKETS_HANDLER CancelSendPacketsHandler; \ + W_PNP_EVENT_NOTIFY_HANDLER PnPEventNotifyHandler; \ + W_MINIPORT_SHUTDOWN_HANDLER AdapterShutdownHandler; + +#endif + +typedef struct _NDIS51_MINIPORT_CHARACTERISTICS { + NDIS51_MINIPORT_CHARACTERISTICS_S +} NDIS51_MINIPORT_CHARACTERISTICS, *PSNDIS51_MINIPORT_CHARACTERISTICS; #if defined(NDIS51_MINIPORT) typedef struct _NDIS_MINIPORT_CHARACTERISTICS { - NDIS50_MINIPORT_CHARACTERISTICS_S + NDIS51_MINIPORT_CHARACTERISTICS_S } NDIS_MINIPORT_CHARACTERISTICS, *PNDIS_MINIPORT_CHARACTERISTICS; #elif defined(NDIS50_MINIPORT) typedef struct _NDIS_MINIPORT_CHARACTERISTICS {
15 years, 7 months
1
0
0
0
[cgutman] 40943: - Add definition of NDIS_DEVICE_PNP_EVENT
by cgutman@svn.reactos.org
Author: cgutman Date: Sun May 17 02:28:33 2009 New Revision: 40943 URL:
http://svn.reactos.org/svn/reactos?rev=40943&view=rev
Log: - Add definition of NDIS_DEVICE_PNP_EVENT Modified: trunk/reactos/include/ddk/netpnp.h Modified: trunk/reactos/include/ddk/netpnp.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/netpnp.h?rev=4…
============================================================================== --- trunk/reactos/include/ddk/netpnp.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/netpnp.h [iso-8859-1] Sun May 17 02:28:33 2009 @@ -35,5 +35,12 @@ ULONG_PTR TdiClientReserved[4]; } NET_PNP_EVENT, *PNET_PNP_EVENT; +typedef enum _NDIS_DEVICE_PNP_EVENT +{ + NdisDevicePnPEventSurpriseRemoved, + NdisDevicePnPEventPowerProfileChanged, + NdisDevicePnPEventMaximum +} NDIS_DEVICE_PNP_EVENT, *PNDIS_DEVICE_PNP_EVENT; + #endif
15 years, 7 months
1
0
0
0
[mjmartin] 40942: - Remove skipping kernel32 virtual tests as r40833 fixed the problem.
by mjmartin@svn.reactos.org
Author: mjmartin Date: Sat May 16 23:07:54 2009 New Revision: 40942 URL:
http://svn.reactos.org/svn/reactos?rev=40942&view=rev
Log: - Remove skipping kernel32 virtual tests as r40833 fixed the problem. Modified: trunk/rostests/winetests/kernel32/virtual.c Modified: trunk/rostests/winetests/kernel32/virtual.c URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/kernel32/virtua…
============================================================================== --- trunk/rostests/winetests/kernel32/virtual.c [iso-8859-1] (original) +++ trunk/rostests/winetests/kernel32/virtual.c [iso-8859-1] Sat May 16 23:07:54 2009 @@ -304,9 +304,6 @@ MEMORY_BASIC_INFORMATION info; BOOL ret; - skip("ROS-HACK: Skipping MapViewOfFile tests\n"); - return; - SetLastError(0xdeadbeef); file = CreateFileA( testfile, GENERIC_READ|GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, 0, 0 ); ok( file != INVALID_HANDLE_VALUE, "CreateFile error %u\n", GetLastError() ); @@ -780,9 +777,6 @@ win_skip( "GetWriteWatch not supported\n" ); return; } - - skip("ROS-HACK: Skipping WriteWatch tests\n"); - return; size = 0x10000; base = VirtualAlloc( 0, size, MEM_RESERVE | MEM_COMMIT | MEM_WRITE_WATCH, PAGE_READWRITE );
15 years, 7 months
1
0
0
0
[janderwald] 40941: - Output type when module is a program
by janderwald@svn.reactos.org
Author: janderwald Date: Sat May 16 21:34:52 2009 New Revision: 40941 URL:
http://svn.reactos.org/svn/reactos?rev=40941&view=rev
Log: - Output type when module is a program Modified: trunk/reactos/tools/rbuild/backend/msbuild/msbuild.cpp Modified: trunk/reactos/tools/rbuild/backend/msbuild/msbuild.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rbuild/backend/msbui…
============================================================================== --- trunk/reactos/tools/rbuild/backend/msbuild/msbuild.cpp [iso-8859-1] (original) +++ trunk/reactos/tools/rbuild/backend/msbuild/msbuild.cpp [iso-8859-1] Sat May 16 21:34:52 2009 @@ -141,8 +141,13 @@ if (module_type == ".sys") fprintf ( OUT, "TARGETTYPE=DRIVER\r\n" ); - if (module_type == ".dll") + else if (module_type == ".dll") + { fprintf ( OUT, "TARGETTYPE=LIBRARY\r\n" ); + + } + else if (module_type == ".exe") + fprintf ( OUT, "TARGETTYPE=PROGRAM\r\n" ); fprintf ( OUT, "\r\nMSC_WARNING_LEVEL=/W3 /WX\r\n\r\n" );
15 years, 7 months
1
0
0
0
[spetreolle] 40940: first attempt at fixing log2lines build
by spetreolle@svn.reactos.org
Author: spetreolle Date: Sat May 16 21:32:11 2009 New Revision: 40940 URL:
http://svn.reactos.org/svn/reactos?rev=40940&view=rev
Log: first attempt at fixing log2lines build Modified: trunk/reactos/tools/rsym/log2lines.mak Modified: trunk/reactos/tools/rsym/log2lines.mak URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/tools/rsym/log2lines.mak?r…
============================================================================== --- trunk/reactos/tools/rsym/log2lines.mak [iso-8859-1] (original) +++ trunk/reactos/tools/rsym/log2lines.mak [iso-8859-1] Sat May 16 21:32:11 2009 @@ -1,4 +1,4 @@ -LOG2LINES_BASE = $(TOOLS_BASE) +LOG2LINES_BASE = $(TOOLS_BASE)$(SEP)rsym LOG2LINES_BASE_ = $(LOG2LINES_BASE)$(SEP) LOG2LINES_INT = $(INTERMEDIATE_)$(LOG2LINES_BASE)
15 years, 7 months
1
0
0
0
[cgutman] 40939: - Fix a bad typo
by cgutman@svn.reactos.org
Author: cgutman Date: Sat May 16 18:12:09 2009 New Revision: 40939 URL:
http://svn.reactos.org/svn/reactos?rev=40939&view=rev
Log: - Fix a bad typo Modified: trunk/reactos/dll/win32/msafd/misc/dllmain.c Modified: trunk/reactos/dll/win32/msafd/misc/dllmain.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msafd/misc/dllma…
============================================================================== --- trunk/reactos/dll/win32/msafd/misc/dllmain.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msafd/misc/dllmain.c [iso-8859-1] Sat May 16 18:12:09 2009 @@ -1980,7 +1980,7 @@ NULL, NULL, &IOSB, - IOCTL_AFD_GET_INFO, + IOCTL_AFD_SET_INFO, &InfoData, sizeof(InfoData), NULL,
15 years, 7 months
1
0
0
0
[khornicek] 40938: - correct number of parameters for IDirect3DTexture methods
by khornicek@svn.reactos.org
Author: khornicek Date: Sat May 16 14:20:22 2009 New Revision: 40938 URL:
http://svn.reactos.org/svn/reactos?rev=40938&view=rev
Log: - correct number of parameters for IDirect3DTexture methods Modified: trunk/reactos/include/psdk/d3d.h Modified: trunk/reactos/include/psdk/d3d.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/d3d.h?rev=409…
============================================================================== --- trunk/reactos/include/psdk/d3d.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/d3d.h [iso-8859-1] Sat May 16 14:20:22 2009 @@ -585,22 +585,22 @@ #define IDirect3DTexture_AddRef(p) (p)->lpVtbl->AddRef(p) #define IDirect3DTexture_Release(p) (p)->lpVtbl->Release(p) /*** IDirect3DTexture methods ***/ -#define IDirect3DTexture_Initialize(p,a,b,c) (p)->lpVtbl->Initialize(p,a,b,c) -#define IDirect3DTexture_GetHandle(p,a,b,c) (p)->lpVtbl->GetHandle(p,a,b,c) -#define IDirect3DTexture_PaletteChanged(p,a,b,c) (p)->lpVtbl->PaletteChanged(p,a,b,c) -#define IDirect3DTexture_Load(p,a,b,c) (p)->lpVtbl->Load(p,a,b,c) -#define IDirect3DTexture_Unload(p,a,b,c) (p)->lpVtbl->Unload(p,a,b,c) +#define IDirect3DTexture_Initialize(p,a,b) (p)->lpVtbl->Initialize(p,a,b) +#define IDirect3DTexture_GetHandle(p,a,b) (p)->lpVtbl->GetHandle(p,a,b) +#define IDirect3DTexture_PaletteChanged(p,a,b) (p)->lpVtbl->PaletteChanged(p,a,b) +#define IDirect3DTexture_Load(p,a) (p)->lpVtbl->Load(p,a) +#define IDirect3DTexture_Unload(p) (p)->lpVtbl->Unload(p) #else /*** IUnknown methods ***/ #define IDirect3DTexture_QueryInterface(p,a,b) (p)->QueryInterface(a,b) #define IDirect3DTexture_AddRef(p) (p)->AddRef() #define IDirect3DTexture_Release(p) (p)->Release() /*** IDirect3DTexture methods ***/ -#define IDirect3DTexture_Initialize(p,a,b,c) (p)->Initialize(a,b,c) -#define IDirect3DTexture_GetHandle(p,a,b,c) (p)->GetHandle(a,b,c) -#define IDirect3DTexture_PaletteChanged(p,a,b,c) (p)->PaletteChanged(a,b,c) -#define IDirect3DTexture_Load(p,a,b,c) (p)->Load(a,b,c) -#define IDirect3DTexture_Unload(p,a,b,c) (p)->Unload(a,b,c) +#define IDirect3DTexture_Initialize(p,a,b) (p)->Initialize(a,b) +#define IDirect3DTexture_GetHandle(p,a,b) (p)->GetHandle(a,b) +#define IDirect3DTexture_PaletteChanged(p,a,b) (p)->PaletteChanged(a,b) +#define IDirect3DTexture_Load(p,a) (p)->Load(a) +#define IDirect3DTexture_Unload(p) (p)->Unload() #endif @@ -840,8 +840,8 @@ #define IDirect3DViewport3_DeleteLight(p,a) (p)->lpVtbl->DeleteLight(p,a) #define IDirect3DViewport3_NextLight(p,a,b,c) (p)->lpVtbl->NextLight(p,a,b,c) /*** IDirect3DViewport2 methods ***/ -#define IDirect3DViewport3_GetViewport3(p,a) (p)->lpVtbl->GetViewport2(p,a) -#define IDirect3DViewport3_SetViewport3(p,a) (p)->lpVtbl->SetViewport2(p,a) +#define IDirect3DViewport3_GetViewport2(p,a) (p)->lpVtbl->GetViewport2(p,a) +#define IDirect3DViewport3_SetViewport2(p,a) (p)->lpVtbl->SetViewport2(p,a) /*** IDirect3DViewport3 methods ***/ #define IDirect3DViewport3_SetBackgroundDepth2(p,a) (p)->lpVtbl->SetBackgroundDepth2(p,a) #define IDirect3DViewport3_GetBackgroundDepth2(p,a,b) (p)->lpVtbl->GetBackgroundDepth2(p,a,b) @@ -866,8 +866,8 @@ #define IDirect3DViewport3_DeleteLight(p,a) (p)->DeleteLight(a) #define IDirect3DViewport3_NextLight(p,a,b,c) (p)->NextLight(a,b,c) /*** IDirect3DViewport2 methods ***/ -#define IDirect3DViewport3_GetViewport3(p,a) (p)->GetViewport2(a) -#define IDirect3DViewport3_SetViewport3(p,a) (p)->SetViewport2(a) +#define IDirect3DViewport3_GetViewport2(p,a) (p)->GetViewport2(a) +#define IDirect3DViewport3_SetViewport2(p,a) (p)->SetViewport2(a) /*** IDirect3DViewport3 methods ***/ #define IDirect3DViewport3_SetBackgroundDepth2(p,a) (p)->SetBackgroundDepth2(a) #define IDirect3DViewport3_GetBackgroundDepth2(p,a,b) (p)->GetBackgroundDepth2(a,b)
15 years, 7 months
1
0
0
0
[fireball] 40937: - Fix handle / memory leak in failure branch, spotted by Dmitry Chapyshev.
by fireball@svn.reactos.org
Author: fireball Date: Sat May 16 12:49:34 2009 New Revision: 40937 URL:
http://svn.reactos.org/svn/reactos?rev=40937&view=rev
Log: - Fix handle / memory leak in failure branch, spotted by Dmitry Chapyshev. Modified: trunk/reactos/dll/ntdll/ldr/utils.c Modified: trunk/reactos/dll/ntdll/ldr/utils.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/utils.c?rev=…
============================================================================== --- trunk/reactos/dll/ntdll/ldr/utils.c [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/ldr/utils.c [iso-8859-1] Sat May 16 12:49:34 2009 @@ -239,7 +239,11 @@ &ResultSize); if (!NT_SUCCESS(Status)) + { + NtClose(KeyHandle); + RtlFreeHeap(RtlGetProcessHeap(), 0, KeyInfo); return NULL; + } RtlCopyMemory(SearchPathBuffer, &KeyInfo->Data,
15 years, 7 months
1
0
0
0
[fireball] 40936: - Fix obvious bugs in the code (e.g. freeing a stack-allocated pointer). - Rewrite the code to be more readable. - Enlarge static buffer for SearchPathBuffer to be at least 5*MAX_PATH to prevent possible overflowing for now. In the meanwhile, Dmitry is rewriting this part of code to dynamically allocate the memory without the need for a temporary static storage.
by fireball@svn.reactos.org
Author: fireball Date: Sat May 16 12:41:26 2009 New Revision: 40936 URL:
http://svn.reactos.org/svn/reactos?rev=40936&view=rev
Log: - Fix obvious bugs in the code (e.g. freeing a stack-allocated pointer). - Rewrite the code to be more readable. - Enlarge static buffer for SearchPathBuffer to be at least 5*MAX_PATH to prevent possible overflowing for now. In the meanwhile, Dmitry is rewriting this part of code to dynamically allocate the memory without the need for a temporary static storage. Modified: trunk/reactos/dll/ntdll/ldr/utils.c Modified: trunk/reactos/dll/ntdll/ldr/utils.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/ldr/utils.c?rev=…
============================================================================== --- trunk/reactos/dll/ntdll/ldr/utils.c [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/ldr/utils.c [iso-8859-1] Sat May 16 12:41:26 2009 @@ -185,19 +185,21 @@ { PKEY_VALUE_PARTIAL_INFORMATION KeyInfo; OBJECT_ATTRIBUTES ObjectAttributes; - WCHAR SearchPathBuffer[MAX_PATH]; + WCHAR SearchPathBuffer[5*MAX_PATH]; UNICODE_STRING ValueNameString; UNICODE_STRING KeyName; - WCHAR NameBuffer[256]; + WCHAR NameBuffer[MAX_PATH]; ULONG KeyInfoSize; ULONG ResultSize; - ULONG len; + PWCHAR Backslash; HANDLE KeyHandle; NTSTATUS Status; PWSTR Path = NULL; - swprintf(NameBuffer, - L"\\Registry\\Machine\\Software\\Microsoft\\Windows\\CurrentVersion\\App Paths\\%s", ImageName); + _snwprintf(NameBuffer, + sizeof(NameBuffer) / sizeof(WCHAR), + L"\\Registry\\Machine\\Software\\Microsoft\\Windows\\CurrentVersion\\App Paths\\%s", + ImageName); RtlInitUnicodeString(&KeyName, NameBuffer); @@ -236,48 +238,46 @@ KeyInfoSize, &ResultSize); - if (NT_SUCCESS(Status)) - { - RtlCopyMemory(SearchPathBuffer, - &KeyInfo->Data, - KeyInfo->DataLength); - - /* get application running path */ - wcscat(SearchPathBuffer, L";"); - wcscat (SearchPathBuffer, NtCurrentPeb()->ProcessParameters->ImagePathName.Buffer); - - len = wcslen (SearchPathBuffer); - - while (len && SearchPathBuffer[len - 1] != L'\\') - len--; - - if (len) SearchPathBuffer[len-1] = L'\0'; - - wcscat (SearchPathBuffer, L";"); - - wcscat (SearchPathBuffer, SharedUserData->NtSystemRoot); - wcscat (SearchPathBuffer, L"\\system32;"); - wcscat (SearchPathBuffer, SharedUserData->NtSystemRoot); - wcscat (SearchPathBuffer, L";."); - - Path = RtlAllocateHeap(RtlGetProcessHeap(), - 0, - wcslen(SearchPathBuffer) * sizeof(WCHAR)); - - if (Path == NULL) - { - DPRINT("RtlAllocateHeap() failed\n"); - RtlFreeHeap(RtlGetProcessHeap(), 0, KeyInfo); - NtClose(KeyHandle); - return NULL; - } - - Path = SearchPathBuffer; - } - + if (!NT_SUCCESS(Status)) + return NULL; + + RtlCopyMemory(SearchPathBuffer, + &KeyInfo->Data, + KeyInfo->DataLength); + + /* Free KeyInfo memory, we won't need it anymore */ RtlFreeHeap(RtlGetProcessHeap(), 0, KeyInfo); + /* Close the key handle */ NtClose(KeyHandle); + + /* get application running path */ + wcscat(SearchPathBuffer, L";"); + wcscat(SearchPathBuffer, NtCurrentPeb()->ProcessParameters->ImagePathName.Buffer); // FIXME: Don't rely on it being NULL-terminated!!! + + /* Remove trailing backslash */ + Backslash = wcsrchr(SearchPathBuffer, L'\\'); + if (Backslash) Backslash = L'\0'; + + wcscat(SearchPathBuffer, L";"); + + wcscat(SearchPathBuffer, SharedUserData->NtSystemRoot); + wcscat(SearchPathBuffer, L"\\system32;"); + wcscat(SearchPathBuffer, SharedUserData->NtSystemRoot); + wcscat(SearchPathBuffer, L";."); + + /* Copy it to the heap allocd memory */ + Path = RtlAllocateHeap(RtlGetProcessHeap(), + 0, + wcslen(SearchPathBuffer) * sizeof(WCHAR)); + + if (!Path) + { + DPRINT1("RtlAllocateHeap() failed\n"); + return NULL; + } + + wcscpy(Path, SearchPathBuffer); return Path; }
15 years, 7 months
1
0
0
0
[tkreuzer] 40935: Implement ceilf, floorf and sqrtf for x64 in assembly. Based on public domain code from netbsd.
by tkreuzer@svn.reactos.org
Author: tkreuzer Date: Sat May 16 06:10:16 2009 New Revision: 40935 URL:
http://svn.reactos.org/svn/reactos?rev=40935&view=rev
Log: Implement ceilf, floorf and sqrtf for x64 in assembly. Based on public domain code from netbsd. Added: branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/ceilf.S (with props) branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/floorf.S (with props) branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/sqrtf.S (with props) Modified: branches/ros-amd64-bringup/reactos/lib/sdk/crt/crt.rbuild Modified: branches/ros-amd64-bringup/reactos/lib/sdk/crt/crt.rbuild URL:
http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/lib/s…
============================================================================== --- branches/ros-amd64-bringup/reactos/lib/sdk/crt/crt.rbuild [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/lib/sdk/crt/crt.rbuild [iso-8859-1] Sat May 16 06:10:16 2009 @@ -166,10 +166,12 @@ <file>atan.S</file> <file>atan2.S</file> <file>ceil.S</file> + <file>ceilf.S</file> <file>cos.S</file> <file>exp.S</file> <file>fabs.S</file> <file>floor.S</file> + <file>floorf.S</file> <file>fmod.S</file> <file>ldexp.S</file> <file>log.S</file> @@ -177,6 +179,7 @@ <file>pow.S</file> <file>sin.S</file> <file>sqrt.S</file> + <file>sqrtf.S</file> <file>tan.S</file> </directory> </if> Added: branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/ceilf.S URL:
http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/lib/s…
============================================================================== --- branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/ceilf.S (added) +++ branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/ceilf.S [iso-8859-1] Sat May 16 06:10:16 2009 @@ -1,0 +1,40 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS system libraries + * PURPOSE: Implementation of tan + * FILE: lib/sdk/crt/math/amd64/ceilf.S + * PROGRAMMER: Timo Kreuzer (timo.kreuzer(a)reactos.org) + */ + +/* INCLUDES ******************************************************************/ + +#include <ndk/amd64/asm.h> +#include <ndk/amd64/asmmacro.S> + +.intel_syntax noprefix + + +.proc ceilf + /* Put parameter on the stack */ + movss [rsp - 0x10], xmm0 + fld dword ptr [rsp] + + /* Change fpu control word to round up */ + fstcw [rsp - 0x10] + mov eax, [rsp - 0x10] + or eax, 0x00800 + and eax, 0x0fbff + mov [rsp - 0x08], eax + fldcw [rsp - 0x08] + + /* Round to integer */ + frndint + + /* Restore fpu control word */ + fldcw [rsp - 0x10] + + fstp dword ptr [rsp - 0x10] + movss xmm0, [rsp - 0x10] + ret + +.endproc Propchange: branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/ceilf.S ------------------------------------------------------------------------------ svn:eol-style = native Added: branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/floorf.S URL:
http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/lib/s…
============================================================================== --- branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/floorf.S (added) +++ branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/floorf.S [iso-8859-1] Sat May 16 06:10:16 2009 @@ -1,0 +1,40 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS system libraries + * PURPOSE: Implementation of tan + * FILE: lib/sdk/crt/math/amd64/floorf.S + * PROGRAMMER: Timo Kreuzer (timo.kreuzer(a)reactos.org) + */ + +/* INCLUDES ******************************************************************/ + +#include <ndk/amd64/asm.h> +#include <ndk/amd64/asmmacro.S> + +.intel_syntax noprefix + + +.proc floorf + /* Put parameter on the stack */ + movss [rsp - 0x10], xmm0 + fld dword ptr [rsp] + + /* Change fpu control word to round down */ + fstcw [rsp - 0x10] + mov eax, [rsp - 0x10] + or eax, 0x00400 + and eax, 0x0f7ff + mov [rsp - 0x08], eax + fldcw [rsp - 0x08] + + /* Round to integer */ + frndint + + /* Restore fpu control word */ + fldcw [rsp - 0x10] + + fstp dword ptr [rsp - 0x10] + movss xmm0, [rsp - 0x10] + ret + +.endproc Propchange: branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/floorf.S ------------------------------------------------------------------------------ svn:eol-style = native Added: branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/sqrtf.S URL:
http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/lib/s…
============================================================================== --- branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/sqrtf.S (added) +++ branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/sqrtf.S [iso-8859-1] Sat May 16 06:10:16 2009 @@ -1,0 +1,20 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS system libraries + * PURPOSE: Implementation of tan + * FILE: lib/sdk/crt/math/amd64/sqrtf.S + * PROGRAMMER: Timo Kreuzer (timo.kreuzer(a)reactos.org) + */ + +/* INCLUDES ******************************************************************/ + +#include <ndk/amd64/asm.h> +#include <ndk/amd64/asmmacro.S> + +.intel_syntax noprefix + + +.proc sqrtf + sqrtss xmm0, xmm0 + ret +.endproc Propchange: branches/ros-amd64-bringup/reactos/lib/sdk/crt/math/amd64/sqrtf.S ------------------------------------------------------------------------------ svn:eol-style = native
15 years, 7 months
1
0
0
0
← Newer
1
...
28
29
30
31
32
33
34
...
51
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
Results per page:
10
25
50
100
200