Ros-diffs June 2009

ros-diffs@reactos.org

21 participants
496 discussions

[tkreuzer] 41478: Fix "no newline at end of file"
by tkreuzer＠svn.reactos.org 20 Jun '09

20 Jun '09

Author: tkreuzer Date: Sat Jun 20 15:45:31 2009 New Revision: 41478 URL: http://svn.reactos.org/svn/reactos?rev=41478&view=rev Log: Fix "no newline at end of file" Modified: branches/ros-amd64-bringup/reactos/base/applications/mplay32/mplay32.c Modified: branches/ros-amd64-bringup/reactos/base/applications/mplay32/mplay32.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/base/… ============================================================================== --- branches/ros-amd64-bringup/reactos/base/applications/mplay32/mplay32.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/base/applications/mplay32/mplay32.c [iso-8859-1] Sat Jun 20 15:45:31 2009 @@ -709,4 +709,4 @@ } return 0; -} +}

1 0

[dreimer] 41477: Oops, small remnant of a prerelease test...
by dreimer＠svn.reactos.org 20 Jun '09

20 Jun '09

Author: dreimer Date: Sat Jun 20 15:39:43 2009 New Revision: 41477 URL: http://svn.reactos.org/svn/reactos?rev=41477&view=rev Log: Oops, small remnant of a prerelease test... Modified: trunk/tools/RosBE/RosBE-Windows/Root/update.cmd Modified: trunk/tools/RosBE/RosBE-Windows/Root/update.cmd URL: http://svn.reactos.org/svn/reactos/trunk/tools/RosBE/RosBE-Windows/Root/upd… ============================================================================== --- trunk/tools/RosBE/RosBE-Windows/Root/update.cmd [iso-8859-1] (original) +++ trunk/tools/RosBE/RosBE-Windows/Root/update.cmd [iso-8859-1] Sat Jun 20 15:39:43 2009 @@ -32,7 +32,7 @@ :: First check for a new Updater for %%F in (update.cmd) do set _ROSBE_UPDDATE=%%~tF -rem "Tools\wget.exe" -N --ignore-length --no-verbose %_ROSBE_URL%/update.cmd 1> NUL 2> NUL +"Tools\wget.exe" -N --ignore-length --no-verbose %_ROSBE_URL%/update.cmd 1> NUL 2> NUL for %%F in (update.cmd) do set _ROSBE_UPDDATE2=%%~tF if !_ROSBE_UPDDATE! NEQ !_ROSBE_UPDDATE2! ( cls

1 0

[tkreuzer] 41476: fix x86 compilation
by tkreuzer＠svn.reactos.org 20 Jun '09

20 Jun '09

Author: tkreuzer Date: Sat Jun 20 15:21:33 2009 New Revision: 41476 URL: http://svn.reactos.org/svn/reactos?rev=41476&view=rev Log: fix x86 compilation Modified: branches/ros-amd64-bringup/reactos/lib/sdk/crt/time_new/mktime.c Modified: branches/ros-amd64-bringup/reactos/lib/sdk/crt/time_new/mktime.c URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/lib/s… ============================================================================== --- branches/ros-amd64-bringup/reactos/lib/sdk/crt/time_new/mktime.c [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/lib/sdk/crt/time_new/mktime.c [iso-8859-1] Sat Jun 20 15:21:33 2009 @@ -76,7 +76,7 @@ } /* Finally get normalized tm struct */ - ptm2 = gmtime(&time); + ptm2 = _gmtime64(&time); if (!ptm2) { return -1;

1 0

[tkreuzer] 41475: Fix outdated rbuild flags
by tkreuzer＠svn.reactos.org 20 Jun '09

20 Jun '09

Author: tkreuzer Date: Sat Jun 20 15:05:46 2009 New Revision: 41475 URL: http://svn.reactos.org/svn/reactos?rev=41475&view=rev Log: Fix outdated rbuild flags Modified: branches/ros-amd64-bringup/reactos/ReactOS-amd64.rbuild Modified: branches/ros-amd64-bringup/reactos/ReactOS-amd64.rbuild URL: http://svn.reactos.org/svn/reactos/branches/ros-amd64-bringup/reactos/React… ============================================================================== --- branches/ros-amd64-bringup/reactos/ReactOS-amd64.rbuild [iso-8859-1] (original) +++ branches/ros-amd64-bringup/reactos/ReactOS-amd64.rbuild [iso-8859-1] Sat Jun 20 15:05:46 2009 @@ -70,41 +70,41 @@ <property name="VERSION_TARGET" value="NT52" /> <if property="VERSION_TARGET" value="NT4"> - <define name="WINVER" overridable="true">0x400</define> - <define name="_WIN32_IE">0x600</define> - <define name="_WIN32_WINNT" overridable="true">0x400</define> + <define name="WINVER">0x400</define> + <define name="_WIN32_IE">0x600</define> + <define name="_WIN32_WINNT">0x400</define> <define name="_WIN32_WINDOWS">0x400</define> <define name="_SETUPAPI_VER">0x400</define> </if> <if property="VERSION_TARGET" value="NT5"> - <define name="WINVER" overridable="true">0x500</define> - <define name="_WIN32_IE">0x600</define> - <define name="_WIN32_WINNT" overridable="true">0x500</define> + <define name="WINVER">0x500</define> + <define name="_WIN32_IE">0x600</define> + <define name="_WIN32_WINNT">0x500</define> <define name="_WIN32_WINDOWS">0x500</define> <define name="_SETUPAPI_VER">0x500</define> </if> <if property="VERSION_TARGET" value="NT51"> - <define name="WINVER" overridable="true">0x501</define> - <define name="_WIN32_IE">0x600</define> - <define name="_WIN32_WINNT" overridable="true">0x501</define> + <define name="WINVER">0x501</define> + <define name="_WIN32_IE">0x600</define> + <define name="_WIN32_WINNT">0x501</define> <define name="_WIN32_WINDOWS">0x501</define> <define name="_SETUPAPI_VER">0x501</define> </if> <if property="VERSION_TARGET" value="NT52"> - <define name="WINVER" overridable="true">0x502</define> - <define name="_WIN32_IE">0x600</define> - <define name="_WIN32_WINNT" overridable="true">0x502</define> + <define name="WINVER">0x502</define> + <define name="_WIN32_IE">0x600</define> + <define name="_WIN32_WINNT">0x502</define> <define name="_WIN32_WINDOWS">0x502</define> <define name="_SETUPAPI_VER">0x502</define> </if> <if property="VERSION_TARGET" value="NT6"> - <define name="WINVER" overridable="true">0x600</define> - <define name="_WIN32_IE">0x600</define> - <define name="_WIN32_WINNT" overridable="true">0x600</define> + <define name="WINVER">0x600</define> + <define name="_WIN32_IE">0x600</define> + <define name="_WIN32_WINNT">0x600</define> <define name="_WIN32_WINDOWS">0x600</define> <define name="_SETUPAPI_VER">0x600</define> </if>

1 0

[cwittich] 41474: partial dbghelp wine sync
by cwittich＠svn.reactos.org 19 Jun '09

19 Jun '09

Author: cwittich Date: Sat Jun 20 02:14:54 2009 New Revision: 41474 URL: http://svn.reactos.org/svn/reactos?rev=41474&view=rev Log: partial dbghelp wine sync Modified: trunk/reactos/dll/win32/dbghelp/dbghelp_private.h trunk/reactos/dll/win32/dbghelp/storage.c Modified: trunk/reactos/dll/win32/dbghelp/dbghelp_private.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/dbghelp_… ============================================================================== --- trunk/reactos/dll/win32/dbghelp/dbghelp_private.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/dbghelp/dbghelp_private.h [iso-8859-1] Sat Jun 20 02:14:54 2009 @@ -78,11 +78,17 @@ struct hash_table_elt* next; }; +struct hash_table_bucket +{ + struct hash_table_elt* first; + struct hash_table_elt* last; +}; + struct hash_table { unsigned num_elts; unsigned num_buckets; - struct hash_table_elt** buckets; + struct hash_table_bucket* buckets; struct pool* pool; }; @@ -90,7 +96,6 @@ unsigned num_buckets); void hash_table_destroy(struct hash_table* ht); void hash_table_add(struct hash_table* ht, struct hash_table_elt* elt); -void* hash_table_find(const struct hash_table* ht, const char* name); unsigned hash_table_hash(const char* name, unsigned num_buckets); struct hash_table_iter Modified: trunk/reactos/dll/win32/dbghelp/storage.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/dbghelp/storage.… ============================================================================== --- trunk/reactos/dll/win32/dbghelp/storage.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/dbghelp/storage.c [iso-8859-1] Sat Jun 20 02:14:54 2009 @@ -361,36 +361,30 @@ void hash_table_add(struct hash_table* ht, struct hash_table_elt* elt) { unsigned hash = hash_table_hash(elt->name, ht->num_buckets); - struct hash_table_elt** p; if (!ht->buckets) { - ht->buckets = pool_alloc(ht->pool, ht->num_buckets * sizeof(struct hash_table_elt*)); + ht->buckets = pool_alloc(ht->pool, ht->num_buckets * sizeof(struct hash_table_bucket)); assert(ht->buckets); - memset(ht->buckets, 0, ht->num_buckets * sizeof(struct hash_table_elt*)); + memset(ht->buckets, 0, ht->num_buckets * sizeof(struct hash_table_bucket)); } /* in some cases, we need to get back the symbols of same name in the order * in which they've been inserted. So insert new elements at the end of the list. */ - for (p = &ht->buckets[hash]; *p; p = &((*p)->next)); - *p = elt; + if (!ht->buckets[hash].first) + { + ht->buckets[hash].first = elt; + } + else + { + ht->buckets[hash].last->next = elt; + } + ht->buckets[hash].last = elt; elt->next = NULL; ht->num_elts++; } -void* hash_table_find(const struct hash_table* ht, const char* name) -{ - unsigned hash = hash_table_hash(name, ht->num_buckets); - struct hash_table_elt* elt; - - if(!ht->buckets) return NULL; - - for (elt = ht->buckets[hash]; elt; elt = elt->next) - if (!strcmp(name, elt->name)) return elt; - return NULL; -} - void hash_table_iter_init(const struct hash_table* ht, struct hash_table_iter* hti, const char* name) { @@ -410,10 +404,10 @@ void* hash_table_iter_up(struct hash_table_iter* hti) { - if(!hti->ht->buckets) return NULL; + if (!hti->ht->buckets) return NULL; if (hti->element) hti->element = hti->element->next; while (!hti->element && hti->index < hti->last) - hti->element = hti->ht->buckets[++hti->index]; + hti->element = hti->ht->buckets[++hti->index].first; return hti->element; }

1 0

[cwittich] 41473: improve some more Lsa stubs
by cwittich＠svn.reactos.org 19 Jun '09

19 Jun '09

Author: cwittich Date: Sat Jun 20 02:08:02 2009 New Revision: 41473 URL: http://svn.reactos.org/svn/reactos?rev=41473&view=rev Log: improve some more Lsa stubs Modified: trunk/reactos/dll/win32/advapi32/sec/lsa.c Modified: trunk/reactos/dll/win32/advapi32/sec/lsa.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/sec/lsa… ============================================================================== --- trunk/reactos/dll/win32/advapi32/sec/lsa.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/sec/lsa.c [iso-8859-1] Sat Jun 20 02:08:02 2009 @@ -183,7 +183,7 @@ ULONG CountOfRights) { FIXME("(%p,%p,%p,0x%08x) stub\n", PolicyHandle, AccountSid, UserRights, CountOfRights); - return STATUS_NOT_IMPLEMENTED; + return STATUS_OBJECT_NAME_NOT_FOUND; } /* @@ -213,7 +213,7 @@ PSID TrustedDomainSid) { FIXME("(%p,%p) stub\n", PolicyHandle, TrustedDomainSid); - return STATUS_NOT_IMPLEMENTED; + return STATUS_SUCCESS; } /* @@ -245,7 +245,7 @@ PULONG CountReturned) { FIXME("(%p,%p,%p,%p) stub\n", PolicyHandle, UserRights, EnumerationBuffer, CountReturned); - return STATUS_NOT_IMPLEMENTED; + return STATUS_NO_MORE_ENTRIES; } /* @@ -262,7 +262,9 @@ { FIXME("(%p,%p,%p,0x%08x,%p) stub\n", PolicyHandle, EnumerationContext, Buffer, PreferedMaximumLength, CountReturned); - return STATUS_NOT_IMPLEMENTED; + + if (CountReturned) *CountReturned = 0; + return STATUS_SUCCESS; } /* @@ -279,7 +281,8 @@ { FIXME("(%p,%p,%p,0x%08x,%p) stub\n", PolicyHandle, EnumerationContext, Buffer, PreferedMaximumLength, CountReturned); - return STATUS_NOT_IMPLEMENTED; + if (CountReturned) *CountReturned = 0; + return STATUS_SUCCESS; } /* @@ -477,7 +480,7 @@ PLSA_HANDLE TrustedDomainHandle) { FIXME("(%p,%p,0x%08x,%p) stub\n", PolicyHandle, TrustedDomainName, DesiredAccess, TrustedDomainHandle); - return STATUS_NOT_IMPLEMENTED; + return STATUS_OBJECT_NAME_NOT_FOUND; } /* @@ -615,7 +618,7 @@ PVOID *Buffer) { FIXME("(%p,%p,%d,%p) stub\n", PolicyHandle, TrustedDomainName, InformationClass, Buffer); - return STATUS_NOT_IMPLEMENTED; + return STATUS_OBJECT_NAME_NOT_FOUND; } /* @@ -630,7 +633,7 @@ PVOID *Buffer) { FIXME("(%p,%p,%d,%p) stub\n", PolicyHandle, TrustedDomainSid, InformationClass, Buffer); - return STATUS_NOT_IMPLEMENTED; + return STATUS_OBJECT_NAME_NOT_FOUND; } /* @@ -646,7 +649,7 @@ ULONG CountOfRights) { FIXME("(%p,%p,%d,%p,0x%08x) stub\n", PolicyHandle, AccountSid, AllRights, UserRights, CountOfRights); - return STATUS_NOT_IMPLEMENTED; + return STATUS_SUCCESS; } /* @@ -688,7 +691,7 @@ PVOID Buffer) { FIXME("(%p,0x%08x,%p) stub\n", PolicyHandle, InformationClass, Buffer); - return STATUS_NOT_IMPLEMENTED; + return STATUS_UNSUCCESSFUL; } /* @@ -719,7 +722,7 @@ PVOID Buffer) { FIXME("(%p,%p,%d,%p) stub\n", PolicyHandle, TrustedDomainName, InformationClass, Buffer); - return STATUS_NOT_IMPLEMENTED; + return STATUS_SUCCESS; } /* @@ -734,7 +737,7 @@ PVOID Buffer) { FIXME("(%p,%p,%d,%p) stub\n", PolicyHandle, TrustedDomainSid, InformationClass, Buffer); - return STATUS_NOT_IMPLEMENTED; + return STATUS_SUCCESS; } /* @@ -748,7 +751,7 @@ PLSA_UNICODE_STRING PrivateData) { FIXME("(%p,%p,%p) stub\n", PolicyHandle, KeyName, PrivateData); - return STATUS_NOT_IMPLEMENTED; + return STATUS_OBJECT_NAME_NOT_FOUND; } /*

1 0

[cwittich] 41472: better stub for LsaEnumerateAccountRights
by cwittich＠svn.reactos.org 19 Jun '09

19 Jun '09

Author: cwittich Date: Sat Jun 20 01:54:19 2009 New Revision: 41472 URL: http://svn.reactos.org/svn/reactos?rev=41472&view=rev Log: better stub for LsaEnumerateAccountRights Modified: trunk/reactos/dll/win32/advapi32/sec/lsa.c Modified: trunk/reactos/dll/win32/advapi32/sec/lsa.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/sec/lsa… ============================================================================== --- trunk/reactos/dll/win32/advapi32/sec/lsa.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/sec/lsa.c [iso-8859-1] Sat Jun 20 01:54:19 2009 @@ -228,7 +228,9 @@ PULONG CountOfRights) { FIXME("(%p,%p,%p,%p) stub\n", PolicyHandle, AccountSid, UserRights, CountOfRights); - return STATUS_NOT_IMPLEMENTED; + *UserRights = 0; + *CountOfRights = 0; + return STATUS_OBJECT_NAME_NOT_FOUND; } /*

1 0

[sginsberg] 41471: - Define noreturn attribute for KeBugCheck/Ex in a msvc-compatible way
by sginsberg＠svn.reactos.org 19 Jun '09

19 Jun '09

Author: sginsberg Date: Fri Jun 19 23:43:41 2009 New Revision: 41471 URL: http://svn.reactos.org/svn/reactos?rev=41471&view=rev Log: - Define noreturn attribute for KeBugCheck/Ex in a msvc-compatible way Modified: trunk/reactos/include/ddk/winddk.h Modified: trunk/reactos/include/ddk/winddk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/winddk.h?rev=4… ============================================================================== --- trunk/reactos/include/ddk/winddk.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/winddk.h [iso-8859-1] Fri Jun 19 23:43:41 2009 @@ -8165,16 +8165,16 @@ VOID); NTKERNELAPI -VOID -NTAPI -__declspec(noreturn) +DECLSPEC_NORETURN +VOID +NTAPI KeBugCheck( IN ULONG BugCheckCode); NTKERNELAPI -VOID -NTAPI -__declspec(noreturn) +DECLSPEC_NORETURN +VOID +NTAPI KeBugCheckEx( IN ULONG BugCheckCode, IN ULONG_PTR BugCheckParameter1,

1 0

[sginsberg] 41470: - Define UNREFERENCED_PARAMETER for cmlib when built as host and reapply 41455.
by sginsberg＠svn.reactos.org 19 Jun '09

19 Jun '09

Author: sginsberg Date: Fri Jun 19 20:05:16 2009 New Revision: 41470 URL: http://svn.reactos.org/svn/reactos?rev=41470&view=rev Log: - Define UNREFERENCED_PARAMETER for cmlib when built as host and reapply 41455. Modified: trunk/reactos/lib/cmlib/cmlib.h trunk/reactos/lib/cmlib/hivecell.c trunk/reactos/lib/cmlib/hiveinit.c Modified: trunk/reactos/lib/cmlib/cmlib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmlib.h?rev=4147… ============================================================================== --- trunk/reactos/lib/cmlib/cmlib.h [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/cmlib.h [iso-8859-1] Fri Jun 19 20:05:16 2009 @@ -59,6 +59,7 @@ IN PRTL_BITMAP BitMapHeader); #define RtlCheckBit(BMH,BP) (((((PLONG)(BMH)->Buffer)[(BP) / 32]) >> ((BP) % 32)) & 0x1) + #define UNREFERENCED_PARAMETER(P) {(P)=(P);} #define PKTHREAD PVOID #define PKGUARDED_MUTEX PVOID Modified: trunk/reactos/lib/cmlib/hivecell.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/hivecell.c?rev=4… ============================================================================== --- trunk/reactos/lib/cmlib/hivecell.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/hivecell.c [iso-8859-1] Fri Jun 19 20:05:16 2009 @@ -79,6 +79,7 @@ PHHIVE RegistryHive, PVOID Cell) { + UNREFERENCED_PARAMETER(RegistryHive); return ((PHCELL)Cell - 1)->Size; } @@ -88,6 +89,8 @@ { PHCELL CellHeader; LONG Size; + + UNREFERENCED_PARAMETER(Hive); CellHeader = (PHCELL)Address - 1; Size = CellHeader->Size * -1; Modified: trunk/reactos/lib/cmlib/hiveinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/hiveinit.c?rev=4… ============================================================================== --- trunk/reactos/lib/cmlib/hiveinit.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/hiveinit.c [iso-8859-1] Fri Jun 19 20:05:16 2009 @@ -445,6 +445,9 @@ NTSTATUS Status; PHHIVE Hive = RegistryHive; + UNREFERENCED_PARAMETER(HiveType); + UNREFERENCED_PARAMETER(FileName); + /* * Create a new hive structure that will hold all the maintenance data. */

1 0

[janderwald] 41469: - Fix build
by janderwald＠svn.reactos.org 19 Jun '09

19 Jun '09

Author: janderwald Date: Fri Jun 19 17:59:27 2009 New Revision: 41469 URL: http://svn.reactos.org/svn/reactos?rev=41469&view=rev Log: - Fix build Modified: trunk/reactos/include/psdk/ks.h Modified: trunk/reactos/include/psdk/ks.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ks.h?rev=4146… ============================================================================== --- trunk/reactos/include/psdk/ks.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ks.h [iso-8859-1] Fri Jun 19 17:59:27 2009 @@ -2471,12 +2471,13 @@ /* =============================================================== XP / DX8 */ - +#if defined(_NTDDK_) struct _KSMAPPING { PHYSICAL_ADDRESS PhysicalAddress; ULONG ByteCount; ULONG Alignment; }; +#endif struct _KSSTREAM_POINTER_OFFSET {

1 0

← Newer
1
...
22
23
24
25
26
27
28
...
50
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs June 2009