Ros-diffs June 2009

ros-diffs@reactos.org

21 participants
496 discussions

[dchapyshev] 41391: - Add job limit flags (based on MSDN info)
by dchapyshev＠svn.reactos.org 12 Jun '09

12 Jun '09

Author: dchapyshev Date: Fri Jun 12 19:49:16 2009 New Revision: 41391 URL: http://svn.reactos.org/svn/reactos?rev=41391&view=rev Log: - Add job limit flags (based on MSDN info) Modified: trunk/reactos/include/ndk/pstypes.h Modified: trunk/reactos/include/ndk/pstypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/pstypes.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/pstypes.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/pstypes.h [iso-8859-1] Fri Jun 12 19:49:16 2009 @@ -170,6 +170,25 @@ #define JOB_OBJECT_ALL_ACCESS (STANDARD_RIGHTS_REQUIRED | \ SYNCHRONIZE | \ 31) + +// +// Job Limit Flags +// +#define JOB_OBJECT_LIMIT_WORKINGSET 0x1 +#define JOB_OBJECT_LIMIT_PROCESS_TIME 0x2 +#define JOB_OBJECT_LIMIT_JOB_TIME 0x4 +#define JOB_OBJECT_LIMIT_ACTIVE_PROCESS 0x8 +#define JOB_OBJECT_LIMIT_AFFINITY 0x10 +#define JOB_OBJECT_LIMIT_PRIORITY_CLASS 0x20 +#define JOB_OBJECT_LIMIT_PRESERVE_JOB_TIME 0x40 +#define JOB_OBJECT_LIMIT_SCHEDULING_CLASS 0x80 +#define JOB_OBJECT_LIMIT_PROCESS_MEMORY 0x100 +#define JOB_OBJECT_LIMIT_JOB_MEMORY 0x200 +#define JOB_OBJECT_LIMIT_DIE_ON_UNHANDLED_EXCEPTION 0x400 +#define JOB_OBJECT_LIMIT_BREAKAWAY_OK 0x800 +#define JOB_OBJECT_LIMIT_SILENT_BREAKAWAY_OK 0x1000 +#define JOB_OBJECT_LIMIT_KILL_ON_JOB_CLOSE 0x2000 + // // Cross Thread Flags

1 0

[dchapyshev] 41390: - Set high priority class for winlogon.exe
by dchapyshev＠svn.reactos.org 12 Jun '09

12 Jun '09

Author: dchapyshev Date: Fri Jun 12 19:44:21 2009 New Revision: 41390 URL: http://svn.reactos.org/svn/reactos?rev=41390&view=rev Log: - Set high priority class for winlogon.exe Modified: trunk/reactos/subsystems/win32/csrss/init.c Modified: trunk/reactos/subsystems/win32/csrss/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/csrss/ini… ============================================================================== --- trunk/reactos/subsystems/win32/csrss/init.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/csrss/init.c [iso-8859-1] Fri Jun 12 19:44:21 2009 @@ -639,6 +639,7 @@ UNICODE_STRING CommandLine; PRTL_USER_PROCESS_PARAMETERS ProcessParameters = NULL; RTL_USER_PROCESS_INFORMATION ProcessInfo; + PROCESS_PRIORITY_CLASS PriorityClass; DPRINT("CSR: %s called\n", __FUNCTION__); @@ -674,6 +675,19 @@ DPRINT1("SM: %s: loading winlogon.exe failed (Status=%08lx)\n", __FUNCTION__, Status); } + + PriorityClass.PriorityClass = PROCESS_PRIORITY_CLASS_HIGH; + PriorityClass.Foreground = FALSE; + + /* Set priority for process */ + if (!NT_SUCCESS(NtSetInformationProcess(ProcessInfo.ProcessHandle, + ProcessPriorityClass, + &PriorityClass, + sizeof(PROCESS_PRIORITY_CLASS)))) + { + DPRINT1("Unable to set process priority for winlogon.exe\n"); + } + ZwResumeThread(ProcessInfo.ThreadHandle, NULL); return Status; }

1 0

[dchapyshev] 41389: - Start services.exe and lsass.exe with above normal priority class
by dchapyshev＠svn.reactos.org 12 Jun '09

12 Jun '09

Author: dchapyshev Date: Fri Jun 12 19:41:26 2009 New Revision: 41389 URL: http://svn.reactos.org/svn/reactos?rev=41389&view=rev Log: - Start services.exe and lsass.exe with above normal priority class Modified: trunk/reactos/base/system/winlogon/winlogon.c Modified: trunk/reactos/base/system/winlogon/winlogon.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/winlogon/winlo… ============================================================================== --- trunk/reactos/base/system/winlogon/winlogon.c [iso-8859-1] (original) +++ trunk/reactos/base/system/winlogon/winlogon.c [iso-8859-1] Fri Jun 12 19:41:26 2009 @@ -49,7 +49,7 @@ NULL, NULL, FALSE, - DETACHED_PROCESS, + DETACHED_PROCESS | ABOVE_NORMAL_PRIORITY_CLASS, NULL, NULL, &StartupInfo, @@ -97,7 +97,7 @@ NULL, NULL, FALSE, - DETACHED_PROCESS, + DETACHED_PROCESS | ABOVE_NORMAL_PRIORITY_CLASS, NULL, NULL, &StartupInfo,

1 0

[cgutman] 41388: - Implement NdisCancelSendPackets
by cgutman＠svn.reactos.org 11 Jun '09

11 Jun '09

Author: cgutman Date: Fri Jun 12 03:53:23 2009 New Revision: 41388 URL: http://svn.reactos.org/svn/reactos?rev=41388&view=rev Log: - Implement NdisCancelSendPackets Modified: trunk/reactos/drivers/network/ndis/ndis/50stubs.c trunk/reactos/drivers/network/ndis/ndis/miniport.c Modified: trunk/reactos/drivers/network/ndis/ndis/50stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… ============================================================================== --- trunk/reactos/drivers/network/ndis/ndis/50stubs.c [iso-8859-1] (original) +++ trunk/reactos/drivers/network/ndis/ndis/50stubs.c [iso-8859-1] Fri Jun 12 03:53:23 2009 @@ -142,18 +142,6 @@ UNIMPLEMENTED return NULL; -} - -/* - * @unimplemented - */ -VOID -EXPORT -NdisCancelSendPackets( - IN NDIS_HANDLE NdisBindingHandle, - IN PVOID CancelId) -{ - UNIMPLEMENTED } /* Modified: trunk/reactos/drivers/network/ndis/ndis/miniport.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… ============================================================================== --- trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] (original) +++ trunk/reactos/drivers/network/ndis/ndis/miniport.c [iso-8859-1] Fri Jun 12 03:53:23 2009 @@ -3009,5 +3009,27 @@ IoCompleteRequest(Irp, IO_NO_INCREMENT); } +/* + * @implemented + */ +VOID +EXPORT +NdisCancelSendPackets( + IN NDIS_HANDLE NdisBindingHandle, + IN PVOID CancelId) +{ + PADAPTER_BINDING AdapterBinding = NdisBindingHandle; + PLOGICAL_ADAPTER Adapter = AdapterBinding->Adapter; + + NDIS_DbgPrint(MAX_TRACE, ("Called for ID %x.\n", CancelId)); + + if (Adapter->NdisMiniportBlock.DriverHandle->MiniportCharacteristics.CancelSendPacketsHandler) + { + (*Adapter->NdisMiniportBlock.DriverHandle->MiniportCharacteristics.CancelSendPacketsHandler)( + Adapter->NdisMiniportBlock.MiniportAdapterContext, + CancelId); + } +} + /* EOF */

1 0

[sginsberg] 41387: - MINIPORT_CONFIGURATION_CONTEXT must be allocated from nonpaged pool as it contains a spinlock
by sginsberg＠svn.reactos.org 11 Jun '09

11 Jun '09

Author: sginsberg Date: Fri Jun 12 03:45:59 2009 New Revision: 41387 URL: http://svn.reactos.org/svn/reactos?rev=41387&view=rev Log: - MINIPORT_CONFIGURATION_CONTEXT must be allocated from nonpaged pool as it contains a spinlock Modified: trunk/reactos/drivers/network/ndis/ndis/config.c Modified: trunk/reactos/drivers/network/ndis/ndis/config.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… ============================================================================== --- trunk/reactos/drivers/network/ndis/ndis/config.c [iso-8859-1] (original) +++ trunk/reactos/drivers/network/ndis/ndis/config.c [iso-8859-1] Fri Jun 12 03:45:59 2009 @@ -194,7 +194,7 @@ return; } - ConfigurationContext = ExAllocatePool(PagedPool, sizeof(MINIPORT_CONFIGURATION_CONTEXT)); + ConfigurationContext = ExAllocatePool(NonPagedPool, sizeof(MINIPORT_CONFIGURATION_CONTEXT)); if(!ConfigurationContext) { NDIS_DbgPrint(MIN_TRACE,("Insufficient resources.\n")); @@ -268,7 +268,7 @@ return; } - ConfigurationContext = ExAllocatePool(PagedPool, sizeof(MINIPORT_CONFIGURATION_CONTEXT)); + ConfigurationContext = ExAllocatePool(NonPagedPool, sizeof(MINIPORT_CONFIGURATION_CONTEXT)); if(!ConfigurationContext) { NDIS_DbgPrint(MIN_TRACE,("Insufficient resources.\n")); @@ -846,7 +846,7 @@ return; } - ConfigurationContext = ExAllocatePool(PagedPool, sizeof(MINIPORT_CONFIGURATION_CONTEXT)); + ConfigurationContext = ExAllocatePool(NonPagedPool, sizeof(MINIPORT_CONFIGURATION_CONTEXT)); if(!ConfigurationContext) { NDIS_DbgPrint(MIN_TRACE,("Insufficient resources.\n")); @@ -905,7 +905,7 @@ return; } - ConfigurationContext = ExAllocatePool(PagedPool, sizeof(MINIPORT_CONFIGURATION_CONTEXT)); + ConfigurationContext = ExAllocatePool(NonPagedPool, sizeof(MINIPORT_CONFIGURATION_CONTEXT)); if(!ConfigurationContext) { NDIS_DbgPrint(MIN_TRACE,("Insufficient resources.\n"));

1 0

[sginsberg] 41386: - PnpInit: Allocate IopBusTypeGuidList from nonpaged pool as it contains a fast mutex. - MsqCreateMessageQueue: Allocate the message queue from nonpaged pool as it contains a mutex.
by sginsberg＠svn.reactos.org 11 Jun '09

11 Jun '09

Author: sginsberg Date: Fri Jun 12 03:36:51 2009 New Revision: 41386 URL: http://svn.reactos.org/svn/reactos?rev=41386&view=rev Log: - PnpInit: Allocate IopBusTypeGuidList from nonpaged pool as it contains a fast mutex. - MsqCreateMessageQueue: Allocate the message queue from nonpaged pool as it contains a mutex. Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.… ============================================================================== --- trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c [iso-8859-1] Fri Jun 12 03:36:51 2009 @@ -2852,7 +2852,7 @@ ExInitializeFastMutex(&IopBusTypeGuidListLock); /* Initialize the Bus Type GUID List */ - IopBusTypeGuidList = ExAllocatePool(PagedPool, sizeof(IO_BUS_TYPE_GUID_LIST)); + IopBusTypeGuidList = ExAllocatePool(NonPagedPool, sizeof(IO_BUS_TYPE_GUID_LIST)); if (!IopBusTypeGuidList) { DPRINT1("ExAllocatePool() failed\n"); KeBugCheckEx(PHASE1_INITIALIZATION_FAILED, STATUS_NO_MEMORY, 0, 0, 0); Modified: trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/nt… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/ntuser/msgqueue.c [iso-8859-1] Fri Jun 12 03:36:51 2009 @@ -1561,7 +1561,7 @@ { PUSER_MESSAGE_QUEUE MessageQueue; - MessageQueue = (PUSER_MESSAGE_QUEUE)ExAllocatePoolWithTag(PagedPool, + MessageQueue = (PUSER_MESSAGE_QUEUE)ExAllocatePoolWithTag(NonPagedPool, sizeof(USER_MESSAGE_QUEUE) + sizeof(THRDCARETINFO), TAG_MSGQ);

1 0

[dchapyshev] 41385: 2 == MEMORY_PRIORITY_FOREGROUND 0 == MEMORY_PRIORITY_BACKGROUND
by dchapyshev＠svn.reactos.org 11 Jun '09

11 Jun '09

Author: dchapyshev Date: Thu Jun 11 19:37:43 2009 New Revision: 41385 URL: http://svn.reactos.org/svn/reactos?rev=41385&view=rev Log: 2 == MEMORY_PRIORITY_FOREGROUND 0 == MEMORY_PRIORITY_BACKGROUND Modified: trunk/reactos/ntoskrnl/ps/process.c Modified: trunk/reactos/ntoskrnl/ps/process.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/process.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ps/process.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ps/process.c [iso-8859-1] Thu Jun 11 19:37:43 2009 @@ -201,13 +201,13 @@ if (Mode == PsProcessPriorityForeground) { /* Set the memory priority and use priority separation */ - MemoryPriority = 2; + MemoryPriority = MEMORY_PRIORITY_FOREGROUND; i = PsPrioritySeparation; } else { /* Set the background memory priority and no separation */ - MemoryPriority = 0; + MemoryPriority = MEMORY_PRIORITY_BACKGROUND; i = 0; }

1 0

[dchapyshev] 41384: - Add debug messages for unimplemented cases in NtQueryInformationProcess
by dchapyshev＠svn.reactos.org 11 Jun '09

11 Jun '09

Author: dchapyshev Date: Thu Jun 11 19:29:30 2009 New Revision: 41384 URL: http://svn.reactos.org/svn/reactos?rev=41384&view=rev Log: - Add debug messages for unimplemented cases in NtQueryInformationProcess Modified: trunk/reactos/ntoskrnl/ps/query.c Modified: trunk/reactos/ntoskrnl/ps/query.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/query.c?rev=41… ============================================================================== --- trunk/reactos/ntoskrnl/ps/query.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ps/query.c [iso-8859-1] Thu Jun 11 19:29:30 2009 @@ -171,6 +171,7 @@ if (!NT_SUCCESS(Status)) break; /* TODO: Implement this case */ + DPRINT1("Query ProcessQuotaLimits unimplemented\n"); Status = STATUS_NOT_IMPLEMENTED; /* Dereference the process */ @@ -303,6 +304,7 @@ case ProcessLdtInformation: case ProcessWorkingSetWatch: case ProcessWx86Information: + DPRINT1("Not implemented: %lx\n", ProcessInformationClass); Status = STATUS_NOT_IMPLEMENTED; break; @@ -703,6 +705,7 @@ case ProcessAffinityMask: case ProcessForegroundInformation: default: + DPRINT1("Unsupported or unimplemented: %lx\n", ProcessInformationClass); Status = STATUS_INVALID_INFO_CLASS; }

1 0

[dchapyshev] 41383: - Add missed checks of the buffer length
by dchapyshev＠svn.reactos.org 11 Jun '09

11 Jun '09

Author: dchapyshev Date: Thu Jun 11 19:21:58 2009 New Revision: 41383 URL: http://svn.reactos.org/svn/reactos?rev=41383&view=rev Log: - Add missed checks of the buffer length Modified: trunk/reactos/ntoskrnl/ps/query.c Modified: trunk/reactos/ntoskrnl/ps/query.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/query.c?rev=41… ============================================================================== --- trunk/reactos/ntoskrnl/ps/query.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ps/query.c [iso-8859-1] Thu Jun 11 19:21:58 2009 @@ -782,6 +782,13 @@ /* Error/Exception Port */ case ProcessExceptionPort: + /* Check buffer length */ + if (ProcessInformationLength != sizeof(HANDLE)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } + /* Use SEH for capture */ _SEH2_TRY { @@ -819,6 +826,13 @@ /* Security Token */ case ProcessAccessToken: + /* Check buffer length */ + if (ProcessInformationLength != sizeof(PROCESS_ACCESS_TOKEN)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } + /* Use SEH for capture */ _SEH2_TRY { @@ -841,6 +855,13 @@ /* Hard error processing */ case ProcessDefaultHardErrorMode: + /* Check buffer length */ + if (ProcessInformationLength != sizeof(ULONG)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } + /* Enter SEH for direct buffer read */ _SEH2_TRY { @@ -858,6 +879,13 @@ /* Session ID */ case ProcessSessionInformation: + + /* Check buffer length */ + if (ProcessInformationLength != sizeof(PROCESS_SESSION_INFORMATION)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } /* Enter SEH for capture */ _SEH2_TRY @@ -1062,6 +1090,13 @@ /* Thread priority */ case ThreadPriority: + /* Check buffer length */ + if (ThreadInformationLength != sizeof(KPRIORITY)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } + /* Use SEH for capture */ _SEH2_TRY { @@ -1090,6 +1125,13 @@ break; case ThreadBasePriority: + + /* Check buffer length */ + if (ThreadInformationLength != sizeof(LONG)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } /* Use SEH for capture */ _SEH2_TRY @@ -1130,6 +1172,13 @@ case ThreadAffinityMask: + /* Check buffer length */ + if (ThreadInformationLength != sizeof(ULONG_PTR)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } + /* Use SEH for capture */ _SEH2_TRY { @@ -1191,6 +1240,13 @@ case ThreadImpersonationToken: + /* Check buffer length */ + if (ThreadInformationLength != sizeof(HANDLE)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } + /* Use SEH for capture */ _SEH2_TRY { @@ -1211,6 +1267,13 @@ case ThreadQuerySetWin32StartAddress: + /* Check buffer length */ + if (ThreadInformationLength != sizeof(ULONG_PTR)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } + /* Use SEH for capture */ _SEH2_TRY { @@ -1230,6 +1293,13 @@ break; case ThreadIdealProcessor: + + /* Check buffer length */ + if (ThreadInformationLength != sizeof(ULONG_PTR)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } /* Use SEH for capture */ _SEH2_TRY @@ -1272,6 +1342,13 @@ case ThreadPriorityBoost: + /* Check buffer length */ + if (ThreadInformationLength != sizeof(ULONG_PTR)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } + /* Use SEH for capture */ _SEH2_TRY { @@ -1291,6 +1368,13 @@ break; case ThreadZeroTlsCell: + + /* Check buffer length */ + if (ThreadInformationLength != sizeof(ULONG_PTR)) + { + Status = STATUS_INFO_LENGTH_MISMATCH; + break; + } /* Use SEH for capture */ _SEH2_TRY

1 0

[dchapyshev] 41382: - Add debug messages for unimplemented cases
by dchapyshev＠svn.reactos.org 11 Jun '09

11 Jun '09

Author: dchapyshev Date: Thu Jun 11 19:04:20 2009 New Revision: 41382 URL: http://svn.reactos.org/svn/reactos?rev=41382&view=rev Log: - Add debug messages for unimplemented cases Modified: trunk/reactos/ntoskrnl/ps/query.c Modified: trunk/reactos/ntoskrnl/ps/query.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ps/query.c?rev=41… ============================================================================== --- trunk/reactos/ntoskrnl/ps/query.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ps/query.c [iso-8859-1] Thu Jun 11 19:04:20 2009 @@ -779,13 +779,6 @@ /* Check what kind of information class this is */ switch (ProcessInformationClass) { - /* Quotas and priorities: not implemented */ - case ProcessQuotaLimits: - case ProcessBasePriority: - case ProcessRaisePriority: - Status = STATUS_NOT_IMPLEMENTED; - break; - /* Error/Exception Port */ case ProcessExceptionPort: @@ -975,6 +968,9 @@ break; /* We currently don't implement any of these */ + case ProcessQuotaLimits: + case ProcessBasePriority: + case ProcessRaisePriority: case ProcessLdtInformation: case ProcessLdtSize: case ProcessIoPortHandlers: @@ -982,6 +978,7 @@ case ProcessUserModeIOPL: case ProcessEnableAlignmentFaultFixup: case ProcessAffinityMask: + DPRINT1("Not implemented: %lx\n", ProcessInformationClass); Status = STATUS_NOT_IMPLEMENTED; break; @@ -995,6 +992,7 @@ case ProcessWow64Information: case ProcessDebugPort: default: + DPRINT1("Unsupported or unimplemented: %lx\n", ProcessInformationClass); Status = STATUS_INVALID_INFO_CLASS; }

1 0

← Newer
1
...
31
32
33
34
35
36
37
...
50
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs June 2009