Ros-diffs August 2009

ros-diffs@reactos.org

21 participants
654 discussions

[gschneider] 42616: Fix memory allocation for small number of digits

by gschneider＠svn.reactos.org

Author: gschneider Date: Tue Aug 11 16:01:44 2009 New Revision: 42616 URL: http://svn.reactos.org/svn/reactos?rev=42616&view=rev Log: Fix memory allocation for small number of digits Modified: trunk/reactos/lib/sdk/crt/stdlib/ecvt.c Modified: trunk/reactos/lib/sdk/crt/stdlib/ecvt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/stdlib/ecvt.c?… ============================================================================== --- trunk/reactos/lib/sdk/crt/stdlib/ecvt.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/stdlib/ecvt.c [iso-8859-1] Tue Aug 11 16:01:44 2009 @@ -7,6 +7,7 @@ */ #include <precomp.h> +#define NUMBER_EFMT 18 /* sign, dot, null, 15 for alignment */ /* * @implemented @@ -17,7 +18,7 @@ static char ecvtbuf[DBL_MAX_10_EXP + 10]; char *cvtbuf, *s, *d; - s = cvtbuf = (char*)malloc(ndigits + 18); /* sign, dot, null, 15 for alignment */ + s = cvtbuf = (char*)malloc(ndigits + NUMBER_EFMT); d = ecvtbuf; *sign = 0; @@ -90,7 +91,7 @@ if (ndigits < 1) { /* Need enhanced precision*/ - char* tbuf = (char*)malloc(ndigits + 18); + char* tbuf = (char*)malloc(NUMBER_EFMT); if (tbuf == NULL) { free(cvtbuf);

15 years, 1 month

[gschneider] 42615: Don't access the pattern GetPixel function pointer if it hasn't been set

by gschneider＠svn.reactos.org

Author: gschneider Date: Tue Aug 11 15:39:40 2009 New Revision: 42615 URL: http://svn.reactos.org/svn/reactos?rev=42615&view=rev Log: Don't access the pattern GetPixel function pointer if it hasn't been set Modified: trunk/reactos/subsystems/win32/win32k/dib/stretchblt.c Modified: trunk/reactos/subsystems/win32/win32k/dib/stretchblt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/di… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/dib/stretchblt.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/dib/stretchblt.c [iso-8859-1] Tue Aug 11 15:39:40 2009 @@ -144,7 +144,7 @@ } } - if (CanDraw) + if (UsesPattern && CanDraw) { if (PatternSurface) {

15 years, 1 month

[fireball] 42614: - Don't try to lock DC twice in BitBlt if it's a same DC. - Implement GetPixel operation (lacks color conversion!). - Implement SetPixel using the idea from trunk's win32k: create a solid brush and PatBlt it to the needed place. Return value needs to be checked though, what gdi32 expects from it.

by fireball＠svn.reactos.org

Author: fireball Date: Tue Aug 11 15:26:06 2009 New Revision: 42614 URL: http://svn.reactos.org/svn/reactos?rev=42614&view=rev Log: - Don't try to lock DC twice in BitBlt if it's a same DC. - Implement GetPixel operation (lacks color conversion!). - Implement SetPixel using the idea from trunk's win32k: create a solid brush and PatBlt it to the needed place. Return value needs to be checked though, what gdi32 expects from it. Modified: branches/arwinss/reactos/subsystems/win32/win32k/gdi/bitmap.c branches/arwinss/reactos/subsystems/win32/win32k/gdi/dc.c branches/arwinss/reactos/subsystems/win32/win32k/gre/surfobj.c branches/arwinss/reactos/subsystems/win32/win32k/include/gre.h branches/arwinss/reactos/subsystems/win32/win32k/include/palobj.h Modified: branches/arwinss/reactos/subsystems/win32/win32k/gdi/bitmap.c URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/subsystems/win3… ============================================================================== --- branches/arwinss/reactos/subsystems/win32/win32k/gdi/bitmap.c [iso-8859-1] (original) +++ branches/arwinss/reactos/subsystems/win32/win32k/gdi/bitmap.c [iso-8859-1] Tue Aug 11 15:26:06 2009 @@ -36,13 +36,16 @@ /* Get a pointer to the DCs */ pSrc = DC_Lock(physDevSrc); - pDst = DC_Lock(physDevDst); + if (physDevSrc != physDevDst) + pDst = DC_Lock(physDevDst); + else + pDst = pSrc; /* Call the internal helper */ bRes = GreBitBlt(pDst, xDst, yDst, width, height, pSrc, xSrc, ySrc, rop); /* Release DC objects */ - DC_Unlock(pDst); + if (physDevSrc != physDevDst) DC_Unlock(pDst); DC_Unlock(pSrc); /* Return status */ @@ -227,8 +230,33 @@ COLORREF APIENTRY RosGdiGetPixel( HDC physDev, INT x, INT y ) { - UNIMPLEMENTED; - return 0; + PDC pDC; + COLORREF crPixel; + + /* Get a pointer to the DC */ + pDC = DC_Lock(physDev); + + crPixel = GreGetPixel(pDC, x, y); + + /* Release DC */ + DC_Unlock(pDC); + + return crPixel; +} + +COLORREF APIENTRY RosGdiSetPixel( HDC physDev, INT x, INT y, COLORREF color ) +{ + PDC pDC; + + /* Get a pointer to the DC */ + pDC = DC_Lock(physDev); + + GreSetPixel(pDC, x, y, color); + + /* Release DC */ + DC_Unlock(pDC); + + return color; } BOOL APIENTRY RosGdiPatBlt( HDC physDev, INT left, INT top, INT width, INT height, DWORD rop ) Modified: branches/arwinss/reactos/subsystems/win32/win32k/gdi/dc.c URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/subsystems/win3… ============================================================================== --- branches/arwinss/reactos/subsystems/win32/win32k/gdi/dc.c [iso-8859-1] (original) +++ branches/arwinss/reactos/subsystems/win32/win32k/gdi/dc.c [iso-8859-1] Tue Aug 11 15:26:06 2009 @@ -484,12 +484,6 @@ return FALSE; } -COLORREF APIENTRY RosGdiSetPixel( HDC physDev, INT x, INT y, COLORREF color ) -{ - UNIMPLEMENTED; - return 0; -} - BOOL APIENTRY RosGdiSetPixelFormat(HDC physDev, int iPixelFormat, const PIXELFORMATDESCRIPTOR *ppfd) Modified: branches/arwinss/reactos/subsystems/win32/win32k/gre/surfobj.c URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/subsystems/win3… ============================================================================== --- branches/arwinss/reactos/subsystems/win32/win32k/gre/surfobj.c [iso-8859-1] (original) +++ branches/arwinss/reactos/subsystems/win32/win32k/gre/surfobj.c [iso-8859-1] Tue Aug 11 15:26:06 2009 @@ -238,3 +238,65 @@ /* Return amount copied */ return ulBytes; } + +COLORREF +NTAPI +GreGetPixel( + PDC pDC, + UINT x, + UINT y) +{ + COLORREF crPixel = (COLORREF)CLR_INVALID; + PSURFACE psurf; + SURFOBJ *pso; + + /* Offset coordinate by DC origin */ + x += pDC->rcVport.left + pDC->rcDcRect.left; + y += pDC->rcVport.top + pDC->rcDcRect.top; + + /* If points is outside combined clipping region - return error */ + if (!RECTL_bPointInRect(&pDC->CombinedClip->rclBounds, x, y)) + return CLR_INVALID; + + /* Get DC's surface */ + psurf = pDC->pBitmap; + + if (!psurf) return CLR_INVALID; + + pso = &psurf->SurfObj; + + /* Actually get the pixel */ + if (pso->pvScan0) + { + ASSERT(pso->lDelta); + + // FIXME: Translate the color? + crPixel = DibFunctionsForBitmapFormat[pso->iBitmapFormat].DIB_GetPixel(pso, x, y); + } + + /* Return found pixel color */ + return crPixel; +} + +VOID +NTAPI +GreSetPixel( + PDC pDC, + UINT x, + UINT y, + COLORREF crColor) +{ + PBRUSHGDI pOldBrush = pDC->pFillBrush; + + /* Create a solid brush with this color */ + pDC->pFillBrush = GreCreateSolidBrush(crColor); + + /* Put pixel */ + GrePatBlt(pDC, x, y, 1, 1, PATCOPY, pDC->pFillBrush); + + /* Free the created brush */ + GreFreeBrush(pDC->pFillBrush); + + /* Restore the old brush */ + pDC->pFillBrush = pOldBrush; +} Modified: branches/arwinss/reactos/subsystems/win32/win32k/include/gre.h URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/subsystems/win3… ============================================================================== --- branches/arwinss/reactos/subsystems/win32/win32k/include/gre.h [iso-8859-1] (original) +++ branches/arwinss/reactos/subsystems/win32/win32k/include/gre.h [iso-8859-1] Tue Aug 11 15:26:06 2009 @@ -172,6 +172,23 @@ y >= prcl->top && y <= prcl->bottom); } +/* surfobj.c */ +COLORREF +NTAPI +GreGetPixel( + PDC pDC, + UINT x, + UINT y); + +VOID +NTAPI +GreSetPixel( + PDC pDC, + UINT x, + UINT y, + COLORREF crColor); + + /* Private Eng functions */ BOOL APIENTRY EngpStretchBlt(SURFOBJ *psoDest, Modified: branches/arwinss/reactos/subsystems/win32/win32k/include/palobj.h URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/subsystems/win3… ============================================================================== --- branches/arwinss/reactos/subsystems/win32/win32k/include/palobj.h [iso-8859-1] (original) +++ branches/arwinss/reactos/subsystems/win32/win32k/include/palobj.h [iso-8859-1] Tue Aug 11 15:26:06 2009 @@ -44,5 +44,7 @@ #define PALETTE_LockPalette(hPalette) ((PPALETTE)GDIOBJ_LockObj((HGDIOBJ)hPalette, GDI_OBJECT_TYPE_PALETTE)) #define PALETTE_UnlockPalette(pPalette) GDIOBJ_UnlockObjByPtr((PBASEOBJECT)pPalette) +#define PALETTE_ShareLock(hpal) ((PPALETTE)GDIOBJ_ShareLockObj((HGDIOBJ)hpal, GDI_OBJECT_TYPE_PALETTE)) +#define PALETTE_ShareUnlock(ppal) GDIOBJ_ShareUnlockObjByPtr(&ppal->BaseObject) #endif

15 years, 1 month

[fireball] 42613: - Implement usermode part of Get/SetPixel. - Add RosDrv_UpdateZOrder declaration to winent.h

by fireball＠svn.reactos.org

Author: fireball Date: Tue Aug 11 15:20:32 2009 New Revision: 42613 URL: http://svn.reactos.org/svn/reactos?rev=42613&view=rev Log: - Implement usermode part of Get/SetPixel. - Add RosDrv_UpdateZOrder declaration to winent.h Modified: branches/arwinss/reactos/dll/win32/winent.drv/gdidrv.c branches/arwinss/reactos/dll/win32/winent.drv/winent.h Modified: branches/arwinss/reactos/dll/win32/winent.drv/gdidrv.c URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/dll/win32/winen… ============================================================================== --- branches/arwinss/reactos/dll/win32/winent.drv/gdidrv.c [iso-8859-1] (original) +++ branches/arwinss/reactos/dll/win32/winent.drv/gdidrv.c [iso-8859-1] Tue Aug 11 15:20:32 2009 @@ -343,8 +343,13 @@ COLORREF CDECL RosDrv_GetPixel( NTDRV_PDEVICE *physDev, INT x, INT y ) { - UNIMPLEMENTED; - return 0; + POINT ptPixel; + + /* Transform to device coordinates */ + ptPixel.x = x; ptPixel.y = y; + LPtoDP(physDev->hUserDC, &ptPixel, 1); + + return RosGdiGetPixel(physDev->hKernelDC, ptPixel.x, ptPixel.y); } int CDECL RosDrv_GetPixelFormat(NTDRV_PDEVICE *physDev) @@ -699,8 +704,13 @@ COLORREF CDECL RosDrv_SetPixel( NTDRV_PDEVICE *physDev, INT x, INT y, COLORREF color ) { - UNIMPLEMENTED; - return 0; + POINT ptPixel; + + /* Transform to device coordinates */ + ptPixel.x = x; ptPixel.y = y; + LPtoDP(physDev->hUserDC, &ptPixel, 1); + + return RosGdiSetPixel(physDev->hKernelDC, ptPixel.x, ptPixel.y, color); } BOOL CDECL RosDrv_SetPixelFormat(NTDRV_PDEVICE *physDev, Modified: branches/arwinss/reactos/dll/win32/winent.drv/winent.h URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/dll/win32/winen… ============================================================================== --- branches/arwinss/reactos/dll/win32/winent.drv/winent.h [iso-8859-1] (original) +++ branches/arwinss/reactos/dll/win32/winent.drv/winent.h [iso-8859-1] Tue Aug 11 15:20:32 2009 @@ -63,3 +63,4 @@ struct ntdrv_win_data *NTDRV_get_win_data( HWND hwnd ); struct ntdrv_win_data *NTDRV_create_win_data( HWND hwnd ); void NTDRV_destroy_win_data( HWND hwnd ); +VOID CDECL RosDrv_UpdateZOrder(HWND hwnd, RECT *rect);

15 years, 1 month

[fireball] 42612: - Get NtUnloadKey2 back to old behavior until its caller learns to properly handle various error codes. See issue #4787 for more details.

by fireball＠svn.reactos.org

Author: fireball Date: Tue Aug 11 15:01:42 2009 New Revision: 42612 URL: http://svn.reactos.org/svn/reactos?rev=42612&view=rev Log: - Get NtUnloadKey2 back to old behavior until its caller learns to properly handle various error codes. See issue #4787 for more details. Modified: trunk/reactos/ntoskrnl/config/ntapi.c Modified: trunk/reactos/ntoskrnl/config/ntapi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/ntapi.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/config/ntapi.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/ntapi.c [iso-8859-1] Tue Aug 11 15:01:42 2009 @@ -1130,6 +1130,7 @@ NtUnloadKey2(IN POBJECT_ATTRIBUTES TargetKey, IN ULONG Flags) { +#if 0 NTSTATUS Status = STATUS_SUCCESS; OBJECT_ATTRIBUTES ObjectAttributes; UNICODE_STRING ObjectName; @@ -1290,6 +1291,10 @@ /* Return status */ return Status; +#else + UNIMPLEMENTED; + return STATUS_NOT_IMPLEMENTED; +#endif } NTSTATUS

15 years, 1 month

[janderwald] 42611: - Check if allocation succeeded - Wait untill each audio service has been started - May now fix randomly playing logon sound

by janderwald＠svn.reactos.org

Author: janderwald Date: Tue Aug 11 12:37:40 2009 New Revision: 42611 URL: http://svn.reactos.org/svn/reactos?rev=42611&view=rev Log: - Check if allocation succeeded - Wait untill each audio service has been started - May now fix randomly playing logon sound Modified: trunk/reactos/base/services/audiosrv/pnp.c trunk/reactos/base/services/audiosrv/services.c Modified: trunk/reactos/base/services/audiosrv/pnp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/audiosrv/pnp… ============================================================================== --- trunk/reactos/base/services/audiosrv/pnp.c [iso-8859-1] (original) +++ trunk/reactos/base/services/audiosrv/pnp.c [iso-8859-1] Tue Aug 11 12:37:40 2009 @@ -60,6 +60,12 @@ (PSP_DEVICE_INTERFACE_DETAIL_DATA_W)HeapAlloc(GetProcessHeap(), 0, length); + + if ( ! detail_data ) + { + logmsg("ProcessExistingDevices() failed to allocate detail_data\n"); + return TRUE; + } while ( SetupDiEnumDeviceInterfaces(dev_info, Modified: trunk/reactos/base/services/audiosrv/services.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/audiosrv/ser… ============================================================================== --- trunk/reactos/base/services/audiosrv/services.c [iso-8859-1] (original) +++ trunk/reactos/base/services/audiosrv/services.c [iso-8859-1] Tue Aug 11 12:37:40 2009 @@ -17,51 +17,86 @@ #include <audiosrv/audiosrv.h> #include "audiosrv.h" +BOOL +WaitForService( + SC_HANDLE hService, + ULONG RetryCount) +{ + ULONG Index = 0; + DWORD dwSize; + SERVICE_STATUS_PROCESS Info; + + do + { + if (!QueryServiceStatusEx(hService, SC_STATUS_PROCESS_INFO, (LPBYTE)&Info, sizeof(SERVICE_STATUS_PROCESS), &dwSize)) + { + logmsg("QueryServiceStatusEx failed %x\n", GetLastError()); + break; + } + + if (Info.dwCurrentState == SERVICE_RUNNING) + return TRUE; + + Sleep(1000); + + }while(Index++ < RetryCount); + + logmsg("Timeout while waiting for service to become ready %p\n", hService); + + return FALSE; +} + +BOOL +StartAudioService( + SC_HANDLE hSCManager, + LPWSTR ServiceName, + ULONG RetryCount) +{ + SC_HANDLE hService; + BOOL ret; + + hService = OpenService(hSCManager, ServiceName, SERVICE_ALL_ACCESS); + + if (!hService) + { + logmsg("Failed to open service %S %x\n", ServiceName, GetLastError()); + return FALSE; + } + + if (!StartService(hService, 0, NULL)) + { + logmsg("Failed to start service %S %x\n", ServiceName, GetLastError()); + CloseServiceHandle(hService); + return FALSE; + } + + ret = WaitForService(hService, RetryCount); + + CloseServiceHandle(hService); + return ret; +} + + + BOOL StartSystemAudioServices() { - SC_HANDLE hSCManager, hService; + SC_HANDLE hSCManager; logmsg("Starting system audio services\n"); hSCManager = OpenSCManager(NULL, NULL, SC_MANAGER_CONNECT); if (!hSCManager) { - logmsg("Failed to open service manager\n"); + logmsg("Failed to open service manager %x\n", GetLastError()); return FALSE; } - hService = OpenService(hSCManager, L"sysaudio", SERVICE_ALL_ACCESS); - if (hService) - { - if (!StartService(hService, 0, NULL)) - { - logmsg("Failed to start sysaudio service\n"); - CloseServiceHandle(hService); - CloseServiceHandle(hSCManager); - return FALSE; - } - CloseServiceHandle(hService); - logmsg("Sysaudio service started\n"); - // FIXME - // wait untill service is started - } - - hService = OpenService(hSCManager, L"wdmaud", SERVICE_ALL_ACCESS); - if (hService) - { - if (!StartService(hService, 0, NULL)) - { - logmsg("Failed to start sysaudio service\n"); - CloseServiceHandle(hService); - CloseServiceHandle(hSCManager); - return FALSE; - } - CloseServiceHandle(hService); - logmsg("Wdmaud service started\n"); - } - + logmsg("Starting sysaudio service\n"); + StartAudioService(hSCManager, L"sysaudio", 20); + logmsg("Starting wdmaud service\n"); + StartAudioService(hSCManager, L"wdmaud", 20); CloseServiceHandle(hSCManager); return TRUE;

15 years, 1 month

[janderwald] 42610: - Audiosrv first starts sysaudio and then wdmaud. It is more clever to wait untill the latter is started

by janderwald＠svn.reactos.org

Author: janderwald Date: Tue Aug 11 12:36:25 2009 New Revision: 42610 URL: http://svn.reactos.org/svn/reactos?rev=42610&view=rev Log: - Audiosrv first starts sysaudio and then wdmaud. It is more clever to wait untill the latter is started Modified: trunk/reactos/base/system/winlogon/winlogon.c Modified: trunk/reactos/base/system/winlogon/winlogon.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/winlogon/winlo… ============================================================================== --- trunk/reactos/base/system/winlogon/winlogon.c [iso-8859-1] (original) +++ trunk/reactos/base/system/winlogon/winlogon.c [iso-8859-1] Tue Aug 11 12:36:25 2009 @@ -65,7 +65,7 @@ if (!hSCManager) ExitThread(0);; - hService = OpenServiceW(hSCManager, L"sysaudio", GENERIC_READ); + hService = OpenServiceW(hSCManager, L"wdmaud", GENERIC_READ); if (!hService) { CloseServiceHandle(hSCManager);

15 years, 1 month

[janderwald] 42609: - Add sanity checks

by janderwald＠svn.reactos.org

Author: janderwald Date: Tue Aug 11 11:41:33 2009 New Revision: 42609 URL: http://svn.reactos.org/svn/reactos?rev=42609&view=rev Log: - Add sanity checks Modified: trunk/reactos/drivers/wdm/audio/legacy/stream/pnp.c Modified: trunk/reactos/drivers/wdm/audio/legacy/stream/pnp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/s… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/stream/pnp.c [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/legacy/stream/pnp.c [iso-8859-1] Tue Aug 11 11:41:33 2009 @@ -156,6 +156,10 @@ /* Get driver object extension */ DriverObjectExtension = IoGetDriverObjectExtension(DeviceObject->DriverObject, (PVOID)StreamClassAddDevice); + + /* sanity checks */ + ASSERT(DeviceExtension); + ASSERT(DriverObjectExtension); /* Zero request block */ RtlZeroMemory(RequestBlock, ResultLength);

15 years, 1 month

[janderwald] 42608: - Fix allocation check - Found by Amine Khaldi

by janderwald＠svn.reactos.org

Author: janderwald Date: Tue Aug 11 11:36:41 2009 New Revision: 42608 URL: http://svn.reactos.org/svn/reactos?rev=42608&view=rev Log: - Fix allocation check - Found by Amine Khaldi Modified: trunk/reactos/drivers/wdm/audio/filters/kmixer/pin.c Modified: trunk/reactos/drivers/wdm/audio/filters/kmixer/pin.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/filters/… ============================================================================== --- trunk/reactos/drivers/wdm/audio/filters/kmixer/pin.c [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/filters/kmixer/pin.c [iso-8859-1] Tue Aug 11 11:36:41 2009 @@ -65,7 +65,7 @@ } ResultOut = ExAllocatePool(NonPagedPool, NewSamples * NumChannels * BytesPerSample); - if (!FloatOut) + if (!ResultOut) { ExFreePool(FloatIn); ExFreePool(FloatOut);

15 years, 1 month

[janderwald] 42607: [KS] - Fix uninitialized return value when the list is empty - Fix a horrible bug where the end of the list wasnt checked by the source list but the destination list - Found by Amine Khaldi

by janderwald＠svn.reactos.org

Author: janderwald Date: Tue Aug 11 11:20:15 2009 New Revision: 42607 URL: http://svn.reactos.org/svn/reactos?rev=42607&view=rev Log: [KS] - Fix uninitialized return value when the list is empty - Fix a horrible bug where the end of the list wasnt checked by the source list but the destination list - Found by Amine Khaldi Modified: trunk/reactos/drivers/ksfilter/ks/irp.c Modified: trunk/reactos/drivers/ksfilter/ks/irp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/ksfilter/ks/irp.c?… ============================================================================== --- trunk/reactos/drivers/ksfilter/ks/irp.c [iso-8859-1] (original) +++ trunk/reactos/drivers/ksfilter/ks/irp.c [iso-8859-1] Tue Aug 11 11:20:15 2009 @@ -1075,7 +1075,7 @@ KIRQL OldLevel; PLIST_ENTRY SrcEntry; PIRP Irp; - NTSTATUS Status; + NTSTATUS Status = STATUS_SUCCESS; if (!DestinationLock) { @@ -1111,7 +1111,7 @@ SrcEntry = SrcEntry->Blink; } - if (SrcEntry == DestinationList) + if (SrcEntry == SourceList) { /* eof list reached */ break;

15 years, 1 month

← Newer
1
...
34
35
36
37
38
39
40
...
66
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2009