Ros-diffs August 2009

ros-diffs@reactos.org

21 participants
654 discussions

[sginsberg] 42435: - Fix the last mingw msvc build issues -- just use function forwarders for msvc instead of using gcc alias symbols. Also add msvc assembly to the "fp10" implementation.
by sginsberg＠svn.reactos.org 06 Aug '09

06 Aug '09

Author: sginsberg Date: Thu Aug 6 21:23:44 2009 New Revision: 42435 URL: http://svn.reactos.org/svn/reactos?rev=42435&view=rev Log: - Fix the last mingw msvc build issues -- just use function forwarders for msvc instead of using gcc alias symbols. Also add msvc assembly to the "fp10" implementation. Modified: trunk/reactos/lib/3rdparty/mingw/CRT_fp10.c trunk/reactos/lib/3rdparty/mingw/CRT_fp8.c Modified: trunk/reactos/lib/3rdparty/mingw/CRT_fp10.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/mingw/CRT_fp1… ============================================================================== --- trunk/reactos/lib/3rdparty/mingw/CRT_fp10.c [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/mingw/CRT_fp10.c [iso-8859-1] Thu Aug 6 21:23:44 2009 @@ -5,6 +5,16 @@ */ void _fpreset (void) - { __asm__ ("fninit" ) ;} +{ +#ifdef __GNUC__ + __asm__ ("fninit" ); +#else + __asm fninit; +#endif +} +#ifdef __GNUC__ void __attribute__ ((alias ("_fpreset"))) fpreset(void); +#else +void fpreset(void) { _fpreset(); } +#endif Modified: trunk/reactos/lib/3rdparty/mingw/CRT_fp8.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/mingw/CRT_fp8… ============================================================================== --- trunk/reactos/lib/3rdparty/mingw/CRT_fp8.c [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/mingw/CRT_fp8.c [iso-8859-1] Thu Aug 6 21:23:44 2009 @@ -8,4 +8,8 @@ void _fpreset (void) { (*_imp___fpreset)(); } +#ifdef __GNUC__ void __attribute__ ((alias ("_fpreset"))) fpreset(void); +#else +void fpreset(void) { _fpreset(); } +#endif

1 0

[fireball] 42434: - Implement GetDCOrgEx.
by fireball＠svn.reactos.org 06 Aug '09

06 Aug '09

Author: fireball Date: Thu Aug 6 19:47:08 2009 New Revision: 42434 URL: http://svn.reactos.org/svn/reactos?rev=42434&view=rev Log: - Implement GetDCOrgEx. Modified: branches/arwinss/reactos/dll/win32/winent.drv/gdidrv.c Modified: branches/arwinss/reactos/dll/win32/winent.drv/gdidrv.c URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/dll/win32/winen… ============================================================================== --- branches/arwinss/reactos/dll/win32/winent.drv/gdidrv.c [iso-8859-1] (original) +++ branches/arwinss/reactos/dll/win32/winent.drv/gdidrv.c [iso-8859-1] Thu Aug 6 19:47:08 2009 @@ -258,8 +258,17 @@ BOOL CDECL RosDrv_GetDCOrgEx( NTDRV_PDEVICE *physDev, LPPOINT lpp ) { - UNIMPLEMENTED; - return FALSE; + RECT dc_rect, drawable_rect; + + /* Get DC rectangles */ + RosGdiGetDcRects(physDev->hKernelDC, &dc_rect, &drawable_rect); + + /* Calculate origin */ + lpp->x = dc_rect.left + drawable_rect.left; + lpp->y = dc_rect.top + drawable_rect.top; + + /* Report success */ + return TRUE; } INT CDECL RosDrv_GetDIBits( NTDRV_PDEVICE *physDev, HBITMAP hbitmap, UINT startscan, UINT lines,

1 0

[gschneider] 42433: [Temp] Revert checkpoints, comment out first two tests to check possible memory corruptions from those functions, trace mktime tests in more detail
by gschneider＠svn.reactos.org 06 Aug '09

06 Aug '09

Author: gschneider Date: Thu Aug 6 19:32:36 2009 New Revision: 42433 URL: http://svn.reactos.org/svn/reactos?rev=42433&view=rev Log: [Temp] Revert checkpoints, comment out first two tests to check possible memory corruptions from those functions, trace mktime tests in more detail Modified: trunk/rostests/winetests/msvcrt/time.c Modified: trunk/rostests/winetests/msvcrt/time.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/msvcrt/time.c?r… ============================================================================== --- trunk/rostests/winetests/msvcrt/time.c [iso-8859-1] (original) +++ trunk/rostests/winetests/msvcrt/time.c [iso-8859-1] Thu Aug 6 19:32:36 2009 @@ -83,15 +83,15 @@ char buffer[64]; int year; time_t ref, secs; - +DPRINT1("Entered test_mktime, getting test year\n"); year = get_test_year( &ref ); ref += SECSPERDAY; - +DPRINT1("Checking return value, testyear=%d, ref=%ld\n", year, ref); ok (res != TIME_ZONE_ID_INVALID, "GetTimeZoneInformation failed\n"); +DPRINT1("Converting StdName, tzi=%p, res=%ld\n", (char*)&tzinfo, res); WideCharToMultiByte( CP_ACP, 0, tzinfo.StandardName, -1, buffer, sizeof(buffer), NULL, NULL ); trace( "bias %d std %d dst %d zone %s\n", tzinfo.Bias, tzinfo.StandardBias, tzinfo.DaylightBias, buffer ); -DPRINT1("Finshed 1st\n"); /* Bias may be positive or negative, to use offset of one day */ my_tm = *localtime(&ref); /* retrieve current dst flag */ secs = SECSPERDAY - tzinfo.Bias * SECSPERMIN; @@ -112,7 +112,6 @@ local_time = mktime(&my_tm); ok(local_time == ref, "mktime returned %u, expected %u\n", (DWORD)local_time, (DWORD)ref); -DPRINT1("Finshed 2nd\n"); /* now test some unnormalized struct tm's */ my_tm = sav_tm; my_tm.tm_sec += 60; @@ -128,7 +127,6 @@ my_tm.tm_hour,my_tm.tm_sec, sav_tm.tm_year,sav_tm.tm_mon,sav_tm.tm_mday, sav_tm.tm_hour,sav_tm.tm_sec); -DPRINT1("Finshed 3rd\n"); my_tm = sav_tm; my_tm.tm_min -= 60; my_tm.tm_hour += 1; @@ -143,7 +141,6 @@ my_tm.tm_hour,my_tm.tm_sec, sav_tm.tm_year,sav_tm.tm_mon,sav_tm.tm_mday, sav_tm.tm_hour,sav_tm.tm_sec); -DPRINT1("Finshed 4th\n"); my_tm = sav_tm; my_tm.tm_mon -= 12; my_tm.tm_year += 1; @@ -158,7 +155,6 @@ my_tm.tm_hour,my_tm.tm_sec, sav_tm.tm_year,sav_tm.tm_mon,sav_tm.tm_mday, sav_tm.tm_hour,sav_tm.tm_sec); -DPRINT1("Finshed 5th\n"); my_tm = sav_tm; my_tm.tm_mon += 12; my_tm.tm_year -= 1; @@ -173,13 +169,12 @@ my_tm.tm_hour,my_tm.tm_sec, sav_tm.tm_year,sav_tm.tm_mon,sav_tm.tm_mday, sav_tm.tm_hour,sav_tm.tm_sec); -DPRINT1("Finshed 6th\n"); /* now a bad time example */ my_tm = sav_tm; my_tm.tm_year = 69; local_time = mktime(&my_tm); ok((local_time == -1), "(bad time) mktime returned %d, expected -1\n", (int)local_time); -DPRINT1("Finshed 7th\n"); + my_tm = sav_tm; /* TEST that we are independent from the TZ variable */ /*Argh, msvcrt doesn't have setenv() */ @@ -187,7 +182,6 @@ putenv("TZ=GMT"); nulltime = mktime(&my_tm); ok(nulltime == ref,"mktime returned 0x%08x\n",(DWORD)nulltime); -DPRINT1("Finshed 8th\n"); putenv(TZ_env); } @@ -294,20 +288,14 @@ START_TEST(time) { +#if 0 test_ctime(); -DPRINT1("test_ctime finished\n"); test_gmtime(); -DPRINT1("test_gmtime finished\n"); +#endif test_mktime(); -DPRINT1("test_mktime finished\n"); test_localtime(); -DPRINT1("test_localtime finished\n"); test_strdate(); -DPRINT1("test_strdate finished\n"); test_strtime(); -DPRINT1("test_strtime finished\n"); test_wstrdate(); -DPRINT1("test_wstrdate finished\n"); test_wstrtime(); -DPRINT1("test_wstrtime finished\n"); -} +}

1 0

[sginsberg] 42432: - Don't define ssize_t -- it is already done in rosdhcp.h
by sginsberg＠svn.reactos.org 06 Aug '09

06 Aug '09

Author: sginsberg Date: Thu Aug 6 18:57:56 2009 New Revision: 42432 URL: http://svn.reactos.org/svn/reactos?rev=42432&view=rev Log: - Don't define ssize_t -- it is already done in rosdhcp.h Modified: trunk/reactos/base/services/dhcp/include/dhcpd.h Modified: trunk/reactos/base/services/dhcp/include/dhcpd.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/dhcp/include… ============================================================================== --- trunk/reactos/base/services/dhcp/include/dhcpd.h [iso-8859-1] (original) +++ trunk/reactos/base/services/dhcp/include/dhcpd.h [iso-8859-1] Thu Aug 6 18:57:56 2009 @@ -279,9 +279,6 @@ #define MAX_TIME 0x7fffffff #define MIN_TIME 0 -#ifdef _MSC_VER -typedef SIZE_T ssize_t; -#endif /* External definitions... */

1 0

[fireball] 42431: - Fix a typo (missing braces), spotted in bug 4764. - Wrap returns from SEH into _SEH2_YIELD. Probably exceptions need to just be fully converted to ReactOS PSEH2 syntax.
by fireball＠svn.reactos.org 06 Aug '09

06 Aug '09

Author: fireball Date: Thu Aug 6 18:37:12 2009 New Revision: 42431 URL: http://svn.reactos.org/svn/reactos?rev=42431&view=rev Log: - Fix a typo (missing braces), spotted in bug 4764. - Wrap returns from SEH into _SEH2_YIELD. Probably exceptions need to just be fully converted to ReactOS PSEH2 syntax. Modified: branches/arwinss/reactos/dll/win32/user32/defwnd.c branches/arwinss/reactos/dll/win32/user32/listbox.c branches/arwinss/reactos/dll/win32/user32/lstr.c Modified: branches/arwinss/reactos/dll/win32/user32/defwnd.c URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/dll/win32/user3… ============================================================================== --- branches/arwinss/reactos/dll/win32/user32/defwnd.c [iso-8859-1] (original) +++ branches/arwinss/reactos/dll/win32/user32/defwnd.c [iso-8859-1] Thu Aug 6 18:37:12 2009 @@ -791,7 +791,7 @@ } __EXCEPT_PAGE_FAULT { - return 0; + _SEH2_YIELD(return 0;) } __ENDTRY return result; @@ -930,7 +930,7 @@ } __EXCEPT_PAGE_FAULT { - return 0; + _SEH2_YIELD(return 0;) } __ENDTRY Modified: branches/arwinss/reactos/dll/win32/user32/listbox.c URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/dll/win32/user3… ============================================================================== --- branches/arwinss/reactos/dll/win32/user32/listbox.c [iso-8859-1] (original) +++ branches/arwinss/reactos/dll/win32/user32/listbox.c [iso-8859-1] Thu Aug 6 18:37:12 2009 @@ -837,7 +837,7 @@ { WARN( "got an invalid buffer (Delphi bug?)\n" ); SetLastError( ERROR_INVALID_PARAMETER ); - return LB_ERR; + _SEH2_YIELD(return LB_ERR;) } __ENDTRY } else { @@ -1027,7 +1027,7 @@ return count; } - +#if 0 /*********************************************************************** * LISTBOX_GetSelItems16 */ @@ -1041,7 +1041,7 @@ if (item->selected) array[count++] = (INT16)i; return count; } - +#endif /*********************************************************************** * LISTBOX_GetSelItems Modified: branches/arwinss/reactos/dll/win32/user32/lstr.c URL: http://svn.reactos.org/svn/reactos/branches/arwinss/reactos/dll/win32/user3… ============================================================================== --- branches/arwinss/reactos/dll/win32/user32/lstr.c [iso-8859-1] (original) +++ branches/arwinss/reactos/dll/win32/user32/lstr.c [iso-8859-1] Thu Aug 6 18:37:12 2009 @@ -244,7 +244,7 @@ __EXCEPT_PAGE_FAULT { SetLastError( ERROR_INVALID_PARAMETER ); - return NULL; + _SEH2_YIELD(return NULL;) } __ENDTRY return str; @@ -270,7 +270,7 @@ __EXCEPT_PAGE_FAULT { SetLastError( ERROR_INVALID_PARAMETER ); - return NULL; + _SEH2_YIELD(return NULL;) } __ENDTRY return str; @@ -455,5 +455,5 @@ BOOL WINAPI IsCharAlphaW(WCHAR x) { //return (get_char_typeW(x) & C1_ALPHA) != 0; - return iswalpha; -} + return iswalpha(x); +}

1 0

[gschneider] 42430: [Temp] add some checkpoints to narrow the mysterious buildserver msvcrt test crash position #2
by gschneider＠svn.reactos.org 06 Aug '09

06 Aug '09

Author: gschneider Date: Thu Aug 6 18:08:49 2009 New Revision: 42430 URL: http://svn.reactos.org/svn/reactos?rev=42430&view=rev Log: [Temp] add some checkpoints to narrow the mysterious buildserver msvcrt test crash position #2 Modified: trunk/rostests/winetests/msvcrt/time.c Modified: trunk/rostests/winetests/msvcrt/time.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/msvcrt/time.c?r… ============================================================================== --- trunk/rostests/winetests/msvcrt/time.c [iso-8859-1] (original) +++ trunk/rostests/winetests/msvcrt/time.c [iso-8859-1] Thu Aug 6 18:08:49 2009 @@ -91,6 +91,7 @@ WideCharToMultiByte( CP_ACP, 0, tzinfo.StandardName, -1, buffer, sizeof(buffer), NULL, NULL ); trace( "bias %d std %d dst %d zone %s\n", tzinfo.Bias, tzinfo.StandardBias, tzinfo.DaylightBias, buffer ); +DPRINT1("Finshed 1st\n"); /* Bias may be positive or negative, to use offset of one day */ my_tm = *localtime(&ref); /* retrieve current dst flag */ secs = SECSPERDAY - tzinfo.Bias * SECSPERMIN; @@ -111,6 +112,7 @@ local_time = mktime(&my_tm); ok(local_time == ref, "mktime returned %u, expected %u\n", (DWORD)local_time, (DWORD)ref); +DPRINT1("Finshed 2nd\n"); /* now test some unnormalized struct tm's */ my_tm = sav_tm; my_tm.tm_sec += 60; @@ -126,6 +128,7 @@ my_tm.tm_hour,my_tm.tm_sec, sav_tm.tm_year,sav_tm.tm_mon,sav_tm.tm_mday, sav_tm.tm_hour,sav_tm.tm_sec); +DPRINT1("Finshed 3rd\n"); my_tm = sav_tm; my_tm.tm_min -= 60; my_tm.tm_hour += 1; @@ -140,6 +143,7 @@ my_tm.tm_hour,my_tm.tm_sec, sav_tm.tm_year,sav_tm.tm_mon,sav_tm.tm_mday, sav_tm.tm_hour,sav_tm.tm_sec); +DPRINT1("Finshed 4th\n"); my_tm = sav_tm; my_tm.tm_mon -= 12; my_tm.tm_year += 1; @@ -154,6 +158,7 @@ my_tm.tm_hour,my_tm.tm_sec, sav_tm.tm_year,sav_tm.tm_mon,sav_tm.tm_mday, sav_tm.tm_hour,sav_tm.tm_sec); +DPRINT1("Finshed 5th\n"); my_tm = sav_tm; my_tm.tm_mon += 12; my_tm.tm_year -= 1; @@ -168,12 +173,13 @@ my_tm.tm_hour,my_tm.tm_sec, sav_tm.tm_year,sav_tm.tm_mon,sav_tm.tm_mday, sav_tm.tm_hour,sav_tm.tm_sec); +DPRINT1("Finshed 6th\n"); /* now a bad time example */ my_tm = sav_tm; my_tm.tm_year = 69; local_time = mktime(&my_tm); ok((local_time == -1), "(bad time) mktime returned %d, expected -1\n", (int)local_time); - +DPRINT1("Finshed 7th\n"); my_tm = sav_tm; /* TEST that we are independent from the TZ variable */ /*Argh, msvcrt doesn't have setenv() */ @@ -181,6 +187,7 @@ putenv("TZ=GMT"); nulltime = mktime(&my_tm); ok(nulltime == ref,"mktime returned 0x%08x\n",(DWORD)nulltime); +DPRINT1("Finshed 8th\n"); putenv(TZ_env); }

1 0

[sginsberg] 42429: - Don't rely on the default calling convention being cdecl for function pointers
by sginsberg＠svn.reactos.org 06 Aug '09

06 Aug '09

Author: sginsberg Date: Thu Aug 6 17:27:23 2009 New Revision: 42429 URL: http://svn.reactos.org/svn/reactos?rev=42429&view=rev Log: - Don't rely on the default calling convention being cdecl for function pointers Modified: trunk/reactos/lib/sdk/crt/search/bsearch.c trunk/reactos/lib/sdk/crt/search/lfind.c trunk/reactos/lib/sdk/crt/search/lsearch.c trunk/reactos/lib/sdk/crt/stdlib/qsort.c Modified: trunk/reactos/lib/sdk/crt/search/bsearch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/search/bsearch… ============================================================================== --- trunk/reactos/lib/sdk/crt/search/bsearch.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/search/bsearch.c [iso-8859-1] Thu Aug 6 17:27:23 2009 @@ -6,7 +6,7 @@ */ void * bsearch(const void *key, const void *base0, size_t nelem, - size_t size, int (*cmp)(const void *ck, const void *ce)) + size_t size, int (__cdecl *cmp)(const void *ck, const void *ce)) { char *base = (char *)base0; int lim, cmpval; Modified: trunk/reactos/lib/sdk/crt/search/lfind.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/search/lfind.c… ============================================================================== --- trunk/reactos/lib/sdk/crt/search/lfind.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/search/lfind.c [iso-8859-1] Thu Aug 6 17:27:23 2009 @@ -5,7 +5,7 @@ * @implemented */ void *_lfind(const void *key, const void *base, unsigned int *nelp, - unsigned int width, int (*compar)(const void *, const void *)) + unsigned int width, int (__cdecl *compar)(const void *, const void *)) { char* char_base = (char*)base; unsigned int i; Modified: trunk/reactos/lib/sdk/crt/search/lsearch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/search/lsearch… ============================================================================== --- trunk/reactos/lib/sdk/crt/search/lsearch.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/search/lsearch.c [iso-8859-1] Thu Aug 6 17:27:23 2009 @@ -6,7 +6,7 @@ * @implemented */ void *_lsearch(const void *key, void *base, unsigned int *nelp, unsigned int width, - int (*compar)(const void *, const void *)) + int (__cdecl *compar)(const void *, const void *)) { void *ret_find = _lfind(key,base,nelp,width,compar); Modified: trunk/reactos/lib/sdk/crt/stdlib/qsort.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/stdlib/qsort.c… ============================================================================== --- trunk/reactos/lib/sdk/crt/stdlib/qsort.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/stdlib/qsort.c [iso-8859-1] Thu Aug 6 17:27:23 2009 @@ -50,7 +50,7 @@ */ static void -qst(size_t size, int (*compar)(const void*, const void*), char *base, char *max) +qst(size_t size, int (__cdecl *compar)(const void*, const void*), char *base, char *max) { char c, *i, *j, *jj; int ii; @@ -176,7 +176,7 @@ * @implemented */ void -qsort(void *base0, size_t n, size_t size, int (*compar)(const void*, const void*)) +qsort(void *base0, size_t n, size_t size, int (__cdecl *compar)(const void*, const void*)) { char *base = (char *)base0; char c, *i, *j, *lo, *hi;

1 0

[gschneider] 42428: Retrieve the timezone bias in mktime via GetTimeZoneInformation
by gschneider＠svn.reactos.org 06 Aug '09

06 Aug '09

Author: gschneider Date: Thu Aug 6 17:18:24 2009 New Revision: 42428 URL: http://svn.reactos.org/svn/reactos?rev=42428&view=rev Log: Retrieve the timezone bias in mktime via GetTimeZoneInformation Modified: trunk/reactos/lib/sdk/crt/time/mktime.c Modified: trunk/reactos/lib/sdk/crt/time/mktime.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/time/mktime.c?… ============================================================================== --- trunk/reactos/lib/sdk/crt/time/mktime.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/time/mktime.c [iso-8859-1] Thu Aug 6 17:18:24 2009 @@ -18,6 +18,8 @@ struct tm *ptm2; __time64_t time; int mons, years, leapyears; + TIME_ZONE_INFORMATION tzi; + DWORD ret; /* Normalize year and month */ if (ptm->tm_mon < 0) @@ -84,7 +86,11 @@ *ptm = *ptm2; /* Finally adjust by the difference to GMT in seconds */ - time += _timezone; + ret = GetTimeZoneInformation(&tzi); + if (ret != TIME_ZONE_ID_INVALID) + { + time += tzi.Bias * 60; + } return time; }

1 0

[gschneider] 42427: [Temp] add some checkpoints to narrow the mysterious buildserver msvcrt test crash position
by gschneider＠svn.reactos.org 06 Aug '09

06 Aug '09

Author: gschneider Date: Thu Aug 6 16:23:40 2009 New Revision: 42427 URL: http://svn.reactos.org/svn/reactos?rev=42427&view=rev Log: [Temp] add some checkpoints to narrow the mysterious buildserver msvcrt test crash position Modified: trunk/rostests/winetests/msvcrt/time.c Modified: trunk/rostests/winetests/msvcrt/time.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/msvcrt/time.c?r… ============================================================================== --- trunk/rostests/winetests/msvcrt/time.c [iso-8859-1] (original) +++ trunk/rostests/winetests/msvcrt/time.c [iso-8859-1] Thu Aug 6 16:23:40 2009 @@ -32,6 +32,9 @@ #define MINSPERHOUR 60 #define HOURSPERDAY 24 +#define NDEBUG +#include <debug.h> + static int get_test_year(time_t *start) { time_t now = time(NULL); @@ -285,11 +288,19 @@ START_TEST(time) { test_ctime(); +DPRINT1("test_ctime finished\n"); test_gmtime(); +DPRINT1("test_gmtime finished\n"); test_mktime(); +DPRINT1("test_mktime finished\n"); test_localtime(); +DPRINT1("test_localtime finished\n"); test_strdate(); +DPRINT1("test_strdate finished\n"); test_strtime(); +DPRINT1("test_strtime finished\n"); test_wstrdate(); +DPRINT1("test_wstrdate finished\n"); test_wstrtime(); -} +DPRINT1("test_wstrtime finished\n"); +}

1 0

[gschneider] 42426: -Increase array size to allow proper string termination (MSVC warning #C4045) -The code correctly copies only the first TCHAR4 value being the string itself
by gschneider＠svn.reactos.org 06 Aug '09

06 Aug '09

Author: gschneider Date: Thu Aug 6 14:45:11 2009 New Revision: 42426 URL: http://svn.reactos.org/svn/reactos?rev=42426&view=rev Log: -Increase array size to allow proper string termination (MSVC warning #C4045) -The code correctly copies only the first TCHAR4 value being the string itself Modified: trunk/reactos/lib/sdk/crt/time/asctime.c Modified: trunk/reactos/lib/sdk/crt/time/asctime.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/time/asctime.c… ============================================================================== --- trunk/reactos/lib/sdk/crt/time/asctime.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/time/asctime.c [iso-8859-1] Thu Aug 6 14:45:11 2009 @@ -14,13 +14,13 @@ #define MONSPERYEAR 12 #define HUNDREDYEAROFFSET 19 -static const _TCHAR wday_name[DAYSPERWEEK][4] = +static const _TCHAR wday_name[DAYSPERWEEK][5] = { _T("Sun "), _T("Mon "), _T("Tue "), _T("Wed "), _T("Thu "), _T("Fri "), _T("Sat ") }; -static const _TCHAR mon_name[MONSPERYEAR][4] = +static const _TCHAR mon_name[MONSPERYEAR][5] = { _T("Jan "), _T("Feb "), _T("Mar "), _T("Apr "), _T("May "), _T("Jun "), _T("Jul "), _T("Aug "), _T("Sep "), _T("Oct "), _T("Nov "), _T("Dec ")

1 0

← Newer
1
...
52
53
54
55
56
57
58
...
66
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2009