Ros-diffs September 2009

ros-diffs@reactos.org

16 participants
270 discussions

by janderwald＠svn.reactos.org

Author: janderwald Date: Thu Oct 1 01:58:04 2009 New Revision: 43246 URL: http://svn.reactos.org/svn/reactos?rev=43246&view=rev Log: - Add usbdlib.h Added: trunk/reactos/include/ddk/usbdlib.h (with props) Added: trunk/reactos/include/ddk/usbdlib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/usbdlib.h?rev=… ============================================================================== --- trunk/reactos/include/ddk/usbdlib.h (added) +++ trunk/reactos/include/ddk/usbdlib.h [iso-8859-1] Thu Oct 1 01:58:04 2009 @@ -1,0 +1,239 @@ +#ifndef USBDLIB_H__ +#define USBDLIB_H__ + + +typedef struct _USBD_INTERFACE_LIST_ENTRY +{ + PUSB_INTERFACE_DESCRIPTOR InterfaceDescriptor; + PUSBD_INTERFACE_INFORMATION Interface; +}USBD_INTERFACE_LIST_ENTRY, *PUSBD_INTERFACE_LIST_ENTRY; + +#define UsbBuildInterruptOrBulkTransferRequest(urb,length, pipeHandle, transferBuffer, transferBufferMDL, transferBufferLength, transferFlags, link) \ +{ \ + (urb)->UrbHeader.Function = URB_FUNCTION_BULK_OR_INTERRUPT_TRANSFER; \ + (urb)->UrbHeader.Length = (length); \ + (urb)->UrbBulkOrInterruptTransfer.PipeHandle = (pipeHandle); \ + (urb)->UrbBulkOrInterruptTransfer.TransferBufferLength = (transferBufferLength); \ + (urb)->UrbBulkOrInterruptTransfer.TransferBufferMDL = (transferBufferMDL); \ + (urb)->UrbBulkOrInterruptTransfer.TransferBuffer = (transferBuffer); \ + (urb)->UrbBulkOrInterruptTransfer.TransferFlags = (transferFlags); \ + (urb)->UrbBulkOrInterruptTransfer.UrbLink = (link); \ +} + +#define UsbBuildGetDescriptorRequest(urb, length, descriptorType, descriptorIndex, languageId, transferBuffer, transferBufferMDL, transferBufferLength, link) \ +{ \ + (urb)->UrbHeader.Function = URB_FUNCTION_GET_DESCRIPTOR_FROM_DEVICE; \ + (urb)->UrbHeader.Length = (length); \ + (urb)->UrbControlDescriptorRequest.TransferBufferLength = (transferBufferLength); \ + (urb)->UrbControlDescriptorRequest.TransferBufferMDL = (transferBufferMDL); \ + (urb)->UrbControlDescriptorRequest.TransferBuffer = (transferBuffer); \ + (urb)->UrbControlDescriptorRequest.DescriptorType = (descriptorType); \ + (urb)->UrbControlDescriptorRequest.Index = (descriptorIndex); \ + (urb)->UrbControlDescriptorRequest.LanguageId = (languageId); \ + (urb)->UrbControlDescriptorRequest.UrbLink = (link); \ +} + +#define UsbBuildGetStatusRequest(urb, op, index, transferBuffer, transferBufferMDL, link) \ +{ \ + (urb)->UrbHeader.Function = (op); \ + (urb)->UrbHeader.Length = sizeof(struct _URB_CONTROL_GET_STATUS_REQUEST); \ + (urb)->UrbControlGetStatusRequest.TransferBufferLength = sizeof(USHORT); \ + (urb)->UrbControlGetStatusRequest.TransferBufferMDL = (transferBufferMDL); \ + (urb)->UrbControlGetStatusRequest.TransferBuffer = (transferBuffer); \ + (urb)->UrbControlGetStatusRequest.Index = (index); \ + (urb)->UrbControlGetStatusRequest.UrbLink = (link); \ +} + + +#define UsbBuildFeatureRequest(urb, op, featureSelector, index, link) \ +{ \ + (urb)->UrbHeader.Function = (op); \ + (urb)->UrbHeader.Length = sizeof(struct _URB_CONTROL_FEATURE_REQUEST); \ + (urb)->UrbControlFeatureRequest.FeatureSelector = (featureSelector); \ + (urb)->UrbControlFeatureRequest.Index = (index); \ + (urb)->UrbControlFeatureRequest.UrbLink = (link); \ +} + +#define UsbBuildSelectConfigurationRequest(urb, length, configurationDescriptor) \ +{ \ + (urb)->UrbHeader.Function = URB_FUNCTION_SELECT_CONFIGURATION; \ + (urb)->UrbHeader.Length = (length); \ + (urb)->UrbSelectConfiguration.ConfigurationDescriptor = (configurationDescriptor); \ +} + +#define UsbBuildSelectInterfaceRequest(urb, length, configurationHandle, interfaceNumber, alternateSetting) \ +{ \ + (urb)->UrbHeader.Function = URB_FUNCTION_SELECT_INTERFACE; \ + (urb)->UrbHeader.Length = (length); \ + (urb)->UrbSelectInterface.Interface.AlternateSetting = (alternateSetting); \ + (urb)->UrbSelectInterface.Interface.InterfaceNumber = (interfaceNumber); \ + (urb)->UrbSelectInterface.Interface.Length = (length - sizeof(struct _URB_HEADER) - sizeof(USBD_CONFIGURATION_HANDLE)); \ + (urb)->UrbSelectInterface.ConfigurationHandle = (configurationHandle); \ +} + +#define UsbBuildVendorRequest(urb, cmd, length, transferFlags, reservedbits, request, value, index, transferBuffer, transferBufferMDL, transferBufferLength, link) \ +{ \ + (urb)->UrbHeader.Function = cmd; \ + (urb)->UrbHeader.Length = (length); \ + (urb)->UrbControlVendorClassRequest.TransferBufferLength = (transferBufferLength); \ + (urb)->UrbControlVendorClassRequest.TransferBufferMDL = (transferBufferMDL); \ + (urb)->UrbControlVendorClassRequest.TransferBuffer = (transferBuffer); \ + (urb)->UrbControlVendorClassRequest.RequestTypeReservedBits = (reservedbits); \ + (urb)->UrbControlVendorClassRequest.Request = (request); \ + (urb)->UrbControlVendorClassRequest.Value = (value); \ + (urb)->UrbControlVendorClassRequest.Index = (index); \ + (urb)->UrbControlVendorClassRequest.TransferFlags = (transferFlags); \ + (urb)->UrbControlVendorClassRequest.UrbLink = (link); \ +} + +#if (NTDDI_VERSION >= NTDDI_WINXP) + +#define UsbBuildOsFeatureDescriptorRequest(urb, length, interface, index, transferBuffer, transferBufferMDL, transferBufferLength, link) \ +{ \ + (urb)->UrbHeader.Function = URB_FUNCTION_GET_MS_FEATURE_DESCRIPTOR; \ + (urb)->UrbHeader.Length = (length); \ + (urb)->UrbOSFeatureDescriptorRequest.TransferBufferLength = (transferBufferLength); \ + (urb)->UrbOSFeatureDescriptorRequest.TransferBufferMDL = (transferBufferMDL); \ + (urb)->UrbOSFeatureDescriptorRequest.TransferBuffer = (transferBuffer); \ + (urb)->UrbOSFeatureDescriptorRequest.InterfaceNumber = (interface); \ + (urb)->UrbOSFeatureDescriptorRequest.MS_FeatureDescriptorIndex = (index); \ + (urb)->UrbOSFeatureDescriptorRequest.UrbLink = (link); \ +} + +#endif + +#define URB_STATUS(urb) ((urb)->UrbHeader.Status) + +#define GET_SELECT_CONFIGURATION_REQUEST_SIZE(totalInterfaces, totalPipes) \ + (sizeof(struct _URB_SELECT_CONFIGURATION) + \ + ((totalInterfaces-1) * sizeof(USBD_INTERFACE_INFORMATION)) + \ + ((totalPipes-totalInterfaces)*sizeof(USBD_PIPE_INFORMATION))) + +#define GET_SELECT_INTERFACE_REQUEST_SIZE(totalPipes) \ + (sizeof(struct _URB_SELECT_INTERFACE) + \ + ((totalPipes-1)*sizeof(USBD_PIPE_INFORMATION))) + +#define GET_USBD_INTERFACE_SIZE(numEndpoints) (sizeof(USBD_INTERFACE_INFORMATION) + \ + (sizeof(USBD_PIPE_INFORMATION)*(numEndpoints)) \ + - sizeof(USBD_PIPE_INFORMATION)) + +#define GET_ISO_URB_SIZE(n) (sizeof(struct _URB_ISOCH_TRANSFER)+ \ + sizeof(USBD_ISO_PACKET_DESCRIPTOR)*n) + + +#ifndef _USBD_ + +DECLSPEC_IMPORT +VOID +USBD_GetUSBDIVersion( + OUT PUSBD_VERSION_INFORMATION VersionInformation +); + + +DECLSPEC_IMPORT +PUSB_INTERFACE_DESCRIPTOR +USBD_ParseConfigurationDescriptor( + IN PUSB_CONFIGURATION_DESCRIPTOR ConfigurationDescriptor, + IN UCHAR InterfaceNumber, + IN UCHAR AlternateSetting +); + +DECLSPEC_IMPORT +PURB +USBD_CreateConfigurationRequest( + IN PUSB_CONFIGURATION_DESCRIPTOR ConfigurationDescriptor, + OUT PUSHORT Siz +); + +DECLSPEC_IMPORT +PUSB_COMMON_DESCRIPTOR +USBD_ParseDescriptors( + IN PVOID DescriptorBuffer, + IN ULONG TotalLength, + IN PVOID StartPosition, + IN LONG DescriptorType +); + +DECLSPEC_IMPORT +PUSB_INTERFACE_DESCRIPTOR +USBD_ParseConfigurationDescriptorEx( + IN PUSB_CONFIGURATION_DESCRIPTOR ConfigurationDescriptor, + IN PVOID StartPosition, + IN LONG InterfaceNumber, + IN LONG AlternateSetting, + IN LONG InterfaceClass, + IN LONG InterfaceSubClass, + IN LONG InterfaceProtocol +); + +DECLSPEC_IMPORT +PURB +USBD_CreateConfigurationRequestEx( + IN PUSB_CONFIGURATION_DESCRIPTOR ConfigurationDescriptor, + IN PUSBD_INTERFACE_LIST_ENTRY InterfaceList +); + + +DECLSPEC_IMPORT +ULONG +USBD_GetInterfaceLength( + IN PUSB_INTERFACE_DESCRIPTOR InterfaceDescriptor, + IN PUCHAR BufferEnd +); + +DECLSPEC_IMPORT +VOID +USBD_RegisterHcFilter( + IN PDEVICE_OBJECT DeviceObject, + IN PDEVICE_OBJECT FilterDeviceObject +); + + + +DECLSPEC_IMPORT +NTSTATUS +USBD_GetPdoRegistryParameter( + IN PDEVICE_OBJECT PhysicalDeviceObject, + IN PVOID Parameter, + IN ULONG ParameterLength, + IN PWSTR KeyName, + IN ULONG KeyNameLength +); + +DECLSPEC_IMPORT +NTSTATUS +USBD_QueryBusTime( + IN PDEVICE_OBJECT RootHubPdo, + OUT PULONG CurrentFrame +); + +#if (NTDDI_VERSION >= NTDDI_WINXP) + +DECLSPEC_IMPORT +ULONG +USBD_CalculateUsbBandwidth( + IN ULONG MaxPacketSize, + IN UCHAR EndpointType, + IN BOOLEAN LowSpeed +); + +#endif + +#if (NTDDI_VERSION >= NTDDI_VISTA) + +DECLSPEC_IMPORT +USBD_STATUS +USBD_ValidateConfigurationDescriptor( + IN PUSB_CONFIGURATION_DESCRIPTOR ConfigDesc, + IN ULONG BufferLength, + IN USHORT Level, + OUT PUCHAR *Offset, + IN ULONG Tag +); + + +#endif + +#endif + +#endif Propchange: trunk/reactos/include/ddk/usbdlib.h ------------------------------------------------------------------------------ svn:eol-style = native

15 years, 2 months

[dgorbachev] 43245: Patch by Viliam Lejcik (lejcik =at= gmail com). Fixes bug #4858. With the blessing of Ged Murphy.

by dgorbachev＠svn.reactos.org

Author: dgorbachev Date: Wed Sep 30 22:59:21 2009 New Revision: 43245 URL: http://svn.reactos.org/svn/reactos?rev=43245&view=rev Log: Patch by Viliam Lejcik (lejcik =at= gmail com). Fixes bug #4858. With the blessing of Ged Murphy. Modified: trunk/reactos/base/applications/mscutils/servman/dependencies.c trunk/reactos/base/applications/mscutils/servman/lang/bg-BG.rc trunk/reactos/base/applications/mscutils/servman/lang/de-DE.rc trunk/reactos/base/applications/mscutils/servman/lang/el-GR.rc trunk/reactos/base/applications/mscutils/servman/lang/es-ES.rc trunk/reactos/base/applications/mscutils/servman/lang/fr-FR.rc trunk/reactos/base/applications/mscutils/servman/lang/id-ID.rc trunk/reactos/base/applications/mscutils/servman/lang/ko-KR.rc trunk/reactos/base/applications/mscutils/servman/lang/no-NO.rc trunk/reactos/base/applications/mscutils/servman/lang/pl-PL.rc trunk/reactos/base/applications/mscutils/servman/lang/ru-RU.rc trunk/reactos/base/applications/mscutils/servman/lang/sk-SK.rc trunk/reactos/base/applications/mscutils/servman/lang/th-TH.rc trunk/reactos/base/applications/mscutils/servman/lang/uk-UA.rc trunk/reactos/base/applications/mscutils/servman/mainwnd.c Modified: trunk/reactos/base/applications/mscutils/servman/dependencies.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/dependencies.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/dependencies.c [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -88,7 +88,7 @@ DWORD dwCount; if (EnumDependentServices(hService, - SERVICE_ACTIVE, + SERVICE_STATE_ALL, NULL, 0, &dwBytesNeeded, @@ -108,7 +108,7 @@ if (lpDependencies) { if (EnumDependentServices(hService, - SERVICE_ACTIVE, + SERVICE_STATE_ALL, lpDependencies, dwBytesNeeded, &dwBytesNeeded, @@ -141,7 +141,7 @@ if (hService) { if (!EnumDependentServices(hService, - SERVICE_ACTIVE, + SERVICE_STATE_ALL, NULL, 0, &dwBytesNeeded, Modified: trunk/reactos/base/applications/mscutils/servman/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/bg-BG.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/bg-BG.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -194,6 +194,8 @@ BEGIN /* IDS_NUM_SERVICES "Num Services: %d" */ IDS_NUM_SERVICES "Áðîé óñëóãè: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/de-DE.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -191,6 +191,8 @@ STRINGTABLE DISCARDABLE BEGIN IDS_NUM_SERVICES "Anzahl der Dienste: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "Dieses Programm ist kostenlos; Sie können es frei verteilen mit od. ohne Änderungen unter der GNU Lesser General Public License wie es von der Free Software Foundation veröffentlicht wurde; entweder Version 2.1 der Lizenz, oder eine spätere Version (ihrer Wahl).\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/el-GR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/el-GR.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -191,6 +191,8 @@ STRINGTABLE DISCARDABLE BEGIN IDS_NUM_SERVICES "Num Services: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/es-ES.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/es-ES.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -191,6 +191,8 @@ STRINGTABLE DISCARDABLE BEGIN IDS_NUM_SERVICES "Núm Servicios: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/fr-FR.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -195,6 +195,8 @@ STRINGTABLE DISCARDABLE BEGIN IDS_NUM_SERVICES "Services: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "Ce programme est un logiciel libre ; vous pouvez le redistribuer et/ou le modifier tout en respectant les termes de la ""GNU General Public License"" publiée par la Free Software Foundation; dans sa version 2 (ou selon votre préférence) toute version ultérieure.\r\n\r\nCe programme est distribué dans l'espoir qu'il sera utile, cependant SANS GARANTIE D'AUCUNE SORTE; sans même une garantie implicite de COMMERCIABILITÉ ou DE CONFORMITÉ A UNE UTILISATION PARTICULIÈRE. \r\n\r\nVoir la Licence Publique Générale GNU pour plus de détails. Vous devriez avoir reçu un exemplaire de la Licence Publique Générale GNU avec ce programme ; si ce n'est pas le cas, écrivez à la Free Software Foundation Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/id-ID.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/id-ID.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/id-ID.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -191,6 +191,8 @@ STRINGTABLE DISCARDABLE BEGIN IDS_NUM_SERVICES "Jumlah Layanan: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "Program ini adalah software bebas; anda dapat mendistribusikan dan/atau mengubahnya di bawah term GNU General Public License seperti dipublikasikan oleh Free Software Foundation; baik Lisensi versi 2, atau (menurut opini anda) setiap versi berikutnya.\r\n\r\nProgram ini didistribusikan dengan harapan ia akan berguna, tetapi TANPA JAMINAN APAPUN; bahkan tanpa jaminan berarti dari MERCANTABILITAS atau KECUKUPAN UNTUK KEPERLUAN TERTENTU. Lihat GNU General Public License untuk lebih jelasnya.\r\n\r\nAnda seharusnya menerima duplikat GNU General Public License bersamaan dengan program ini; jika tidak, tulis ke Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/ko-KR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/ko-KR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/ko-KR.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -194,6 +194,8 @@ STRINGTABLE DISCARDABLE BEGIN IDS_NUM_SERVICES "¸ðµç ¼ºñ½º: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/no-NO.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/no-NO.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -191,6 +191,8 @@ STRINGTABLE DISCARDABLE BEGIN IDS_NUM_SERVICES "Num tjeneste: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "Dette programmet er gratis programvare; du kan distribuere det og/eller endre det under betingelsene av GNU General Public License som er utgitt av Free Software Foundation; version 2 av lisensen, eller (etter din mening) alle senere versjoner.\r\n\r\nDette programmet er utgitt i håp for at det skal kunne brukes, men DET ER INGEN GARANTIER; uten heller forutsatt garantier av SALGBARHET eller SIKKETHET FOR EN ENKELTHET FORMÅL. Se på GNU General Public Lisensen for mere detaljer.\r\n\r\nDu skal ha motatt en kopi av GNU General Public Lisensen sammen med denne programmet; hvis du ikke har motatt det, skriv til Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/pl-PL.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/pl-PL.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -198,6 +198,8 @@ STRINGTABLE DISCARDABLE BEGIN IDS_NUM_SERVICES "Numer us³ugi: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "Niniejszy program jest wolnym oprogramowaniem; mo¿esz go rozprowadzaæ dalej i/lub modyfikowaæ na warunkach Powszechnej Licencji Publicznej GNU, wydanej przez Fundacjê Wolnego Oprogramowania - wed³ug wersji 2 tej Licencji lub (wed³ug Twojego wyboru) której z póniejszych wersji.\r\n\r\nNiniejszy program rozpowszechniany jest z nadziej¹, i¿ bêdzie on u¿yteczny - jednak BEZ JAKIEJKOLWIEK GWARANCJI, nawet domylnej gwarancji PRZYDATNOCI HANDLOWEJ albo PRZYDATNOCI DO OKRELONYCH ZASTOSOWAÑ. W celu uzyskania bli¿szych informacji siêgnij do Powszechnej Licencji Publicznej GNU.\r\n\r\nZ pewnoci¹ wraz z niniejszym programem otrzyma³e te¿ egzemplarz Powszechnej Licencji Publicznej GNU (GNU General Public License); jeli nie - napisz do Free Software Foundation, Inc., 59 Temple Place, Fifth Floor, Boston, MA 02110-1301 USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/ru-RU.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/ru-RU.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -190,6 +190,8 @@ STRINGTABLE DISCARDABLE BEGIN IDS_NUM_SERVICES "Íîìåð ñëóæáû: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "Ýòà ïðîãðàììà ÿâëÿåòñÿ ñâîáîäíûì ïðîãðàììíûì îáåñïå÷åíèåì; Âû ìîæåòå ðàñïðîñòðàíÿòü è/èëè èçìåíÿòü åå â ñîîòâåòñòâèè ñ ëèöåíçèåé GNU General Public License âåðñèè 2 èëè áîëåå ïîçäíåé, îïóáëèêîâàííîé Free Software Foundation.\r\n\r\nÝòà ïðîãðàììà ðàñïðîñòðàíÿåòñÿ ñ íàäåæäîé, ÷òî îíà ìîæåò áûòü ïîëåçíà, íî ÁÅÇ ÂÑßÊÎÉ ÃÀÐÀÍÒÈÈ; íå ïîäðàçóìåâàåòñÿ äàæå ÐÀÁÎÒÎÑÏÎÑÎÁÍÎÑÒÜ èëè ÏÐÈÃÎÄÍÎÑÒÜ ÄËß ÂÛÏÎËÍÅÍÈß ÍÅÎÁÕÎÄÈÌÛÕ ÇÀÄÀ×. Ñì. GNU General Public License äëÿ ïîëó÷åíèÿ äîïîëíèòåëüíûõ ñâåäåíèé.\r\n\r\nÂû äîëæíû ïîëó÷èòü êîïèþ ëèöåíçèè GNU âìåñòå ñ ýòîé ïðîãðàììîé, â ïðîòèâíîì ñëó÷àå îáðàùàéòåñü â Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/sk-SK.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/sk-SK.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -210,6 +210,7 @@ BEGIN IDS_NUM_SERVICES "Poèet sluieb: %d" IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<iadne závislosti>" IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/th-TH.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/th-TH.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/th-TH.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -200,6 +200,8 @@ STRINGTABLE DISCARDABLE BEGIN IDS_NUM_SERVICES "Num Services: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/lang/uk-UA.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/lang/uk-UA.rc [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -199,6 +199,8 @@ STRINGTABLE DISCARDABLE BEGIN IDS_NUM_SERVICES "Íîìåð ñëóæáè: %d" + IDS_STOP_DEPENDS "When %s stops, these other services will also stop" + IDS_NO_DEPENDS "<No Dependencies>" IDS_LICENSE "This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation; either version 2 of the License, or (at your option) any later version.\r\n\r\nThis program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details.\r\n\r\nYou should have received a copy of the GNU General Public License along with this program; if not, write to the Free Software Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA." END Modified: trunk/reactos/base/applications/mscutils/servman/mainwnd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/mainwnd.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/mainwnd.c [iso-8859-1] Wed Sep 30 22:59:21 2009 @@ -643,11 +643,14 @@ if (!InitMainWnd(Info)) return -1; + /* Fill the list-view before showing the main window */ + RefreshServiceList(Info); + /* Show the window */ ShowWindow(hwnd, Info->nCmdShow); - RefreshServiceList(Info); + SetFocus(Info->hListView); } break; @@ -683,6 +686,16 @@ } //OpenPropSheet(Info); + } + break; + + case NM_RETURN: + { + SendMessage(hwnd, + WM_COMMAND, + //ID_PROP, + MAKEWPARAM((WORD)ID_PROP, (WORD)0), + 0); } break;

15 years, 2 months

[sginsberg] 43244: ReactOS SMP Bringup Lite: - Add simple and hacky spinlock implementation to HAL and kernel. It treats queued spinlocks as normal spinlocks and does not support debug timeout, but works well enough to expose bugs in spinlock usage. - Implement KiProcessDeferredReadyList, a simple wrapper around KiDeferredReadyThread. - Add missing PRCB locking in KiDeferredReadyThread. - Implement SMP handling in KiRetireDpcList. - Acquire the spinlock in KeSynchronizeExecution for SMP. - Stub

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Wed Sep 30 22:30:57 2009 New Revision: 43244 URL: http://svn.reactos.org/svn/reactos?rev=43244&view=rev Log: ReactOS SMP Bringup Lite: - Add simple and hacky spinlock implementation to HAL and kernel. It treats queued spinlocks as normal spinlocks and does not support debug timeout, but works well enough to expose bugs in spinlock usage. - Implement KiProcessDeferredReadyList, a simple wrapper around KiDeferredReadyThread. - Add missing PRCB locking in KiDeferredReadyThread. - Implement SMP handling in KiRetireDpcList. - Acquire the spinlock in KeSynchronizeExecution for SMP. - Stub and export Kii386SpinOnSpinLock -- not used yet. - Fix locking in KiAcquire/ReleaseDispatcherLockAtDpcLevel -- KeAcquireQueuedSpinLockAtDpcLevel takes the lock queue pointer, not the index. - "Implement" KiRundownThread for SMP. - Fix some sanity checks in the SMP context switch code and implement a stubbed SMP case. - Define SYNCH_LEVEL in asm.h and use it in HAL's KeRaiseIrqlToSynchLevel. To try the MP kernel on UP (it does not work on multiple processors yet) compile ntkrnlmp, rename it to ntoskrnl and add it to your installation. This requires a HAL with CONFIG_SMP enabled in HAL's spinlock.c and irq.S. Booting with the MP kernel does not work because of a weird regression introduced sometime in the last few months -- it appears MmProbeAndLockPages fails for a user mode stack pointer (no, I have no idea why). Modified: trunk/reactos/hal/halx86/generic/irq.S trunk/reactos/hal/halx86/generic/spinlock.c trunk/reactos/include/ndk/asm.h trunk/reactos/ntoskrnl/include/internal/ke.h trunk/reactos/ntoskrnl/include/internal/ke_x.h trunk/reactos/ntoskrnl/ke/dpc.c trunk/reactos/ntoskrnl/ke/i386/ctxswitch.S trunk/reactos/ntoskrnl/ke/i386/trap.s trunk/reactos/ntoskrnl/ke/spinlock.c trunk/reactos/ntoskrnl/ke/thrdschd.c trunk/reactos/ntoskrnl/ntoskrnl.pspec Modified: trunk/reactos/hal/halx86/generic/irq.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/irq.S?r… ============================================================================== --- trunk/reactos/hal/halx86/generic/irq.S [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/generic/irq.S [iso-8859-1] Wed Sep 30 22:30:57 2009 @@ -6,6 +6,9 @@ */ /* INCLUDES ******************************************************************/ + +/* Enable this (and the define in spinlock.c) to make UP HAL work for MP Kernel */ +/* #define CONFIG_SMP */ #include <asm.h> #include <internal/i386/asmmacro.S> @@ -600,20 +603,20 @@ cli /* Mask out interrupts */ - mov eax, KiI8259MaskTable[DISPATCH_LEVEL*4] + mov eax, KiI8259MaskTable[SYNCH_LEVEL*4] or eax, PCR[KPCR_IDR] out 0x21, al shr eax, 8 out 0xA1, al - /* Return the old IRQL, enable interrupts and set to DISPATCH */ + /* Return the old IRQL, enable interrupts and set to SYNCH */ mov eax, PCR[KPCR_IRQL] - mov dword ptr PCR[KPCR_IRQL], DISPATCH_LEVEL + mov dword ptr PCR[KPCR_IRQL], SYNCH_LEVEL popf #if DBG /* Validate raise */ - cmp eax, DISPATCH_LEVEL + cmp eax, SYNCH_LEVEL ja InvalidSyRaise #endif @@ -625,7 +628,7 @@ /* Bugcheck the system */ push 2 push 0 - push DISPATCH_LEVEL + push SYNCH_LEVEL push eax push IRQL_NOT_GREATER_OR_EQUAL call _KeBugCheckEx@20 Modified: trunk/reactos/hal/halx86/generic/spinlock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/spinloc… ============================================================================== --- trunk/reactos/hal/halx86/generic/spinlock.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/generic/spinlock.c [iso-8859-1] Wed Sep 30 22:30:57 2009 @@ -8,28 +8,322 @@ /* INCLUDES ******************************************************************/ +/* Enable this (and the define in irq.S) to make UP HAL work for MP Kernel */ +/* #define CONFIG_SMP */ + #include <hal.h> #define NDEBUG #include <debug.h> #undef KeAcquireSpinLock #undef KeReleaseSpinLock -#undef KeLowerIrql + +// +// This is duplicated from ke_x.h +// +#ifdef CONFIG_SMP +// +// Spinlock Acquisition at IRQL >= DISPATCH_LEVEL +// +FORCEINLINE +VOID +KxAcquireSpinLock(IN PKSPIN_LOCK SpinLock) +{ + /* Make sure that we don't own the lock already */ + if (((KSPIN_LOCK)KeGetCurrentThread() | 1) == *SpinLock) + { + /* We do, bugcheck! */ + KeBugCheckEx(SPIN_LOCK_ALREADY_OWNED, (ULONG_PTR)SpinLock, 0, 0, 0); + } + + for (;;) + { + /* Try to acquire it */ + if (InterlockedBitTestAndSet((PLONG)SpinLock, 0)) + { + /* Value changed... wait until it's locked */ + while (*(volatile KSPIN_LOCK *)SpinLock == 1) + { +#ifdef DBG + /* On debug builds, we use a much slower but useful routine */ + //Kii386SpinOnSpinLock(SpinLock, 5); + + /* FIXME: Do normal yield for now */ + YieldProcessor(); +#else + /* Otherwise, just yield and keep looping */ + YieldProcessor(); +#endif + } + } + else + { +#ifdef DBG + /* On debug builds, we OR in the KTHREAD */ + *SpinLock = (KSPIN_LOCK)KeGetCurrentThread() | 1; +#endif + /* All is well, break out */ + break; + } + } +} + +// +// Spinlock Release at IRQL >= DISPATCH_LEVEL +// +FORCEINLINE +VOID +KxReleaseSpinLock(IN PKSPIN_LOCK SpinLock) +{ +#ifdef DBG + /* Make sure that the threads match */ + if (((KSPIN_LOCK)KeGetCurrentThread() | 1) != *SpinLock) + { + /* They don't, bugcheck */ + KeBugCheckEx(SPIN_LOCK_NOT_OWNED, (ULONG_PTR)SpinLock, 0, 0, 0); + } +#endif + /* Clear the lock */ + InterlockedAnd((PLONG)SpinLock, 0); +} + +#else + +// +// Spinlock Acquire at IRQL >= DISPATCH_LEVEL +// +FORCEINLINE +VOID +KxAcquireSpinLock(IN PKSPIN_LOCK SpinLock) +{ + /* On UP builds, spinlocks don't exist at IRQL >= DISPATCH */ + UNREFERENCED_PARAMETER(SpinLock); +} + +// +// Spinlock Release at IRQL >= DISPATCH_LEVEL +// +FORCEINLINE +VOID +KxReleaseSpinLock(IN PKSPIN_LOCK SpinLock) +{ + /* On UP builds, spinlocks don't exist at IRQL >= DISPATCH */ + UNREFERENCED_PARAMETER(SpinLock); +} + +#endif + +/* FUNCTIONS *****************************************************************/ + +/* + * @implemented + */ +VOID +NTAPI +KeAcquireSpinLock(PKSPIN_LOCK SpinLock, + PKIRQL OldIrql) +{ + /* Call the fastcall function */ + *OldIrql = KfAcquireSpinLock(SpinLock); +} + +/* + * @implemented + */ +KIRQL +FASTCALL +KeAcquireSpinLockRaiseToSynch(PKSPIN_LOCK SpinLock) +{ + KIRQL OldIrql; + + /* Raise to sync */ + KeRaiseIrql(SYNCH_LEVEL, &OldIrql); + + /* Acquire the lock and return */ + KxAcquireSpinLock(SpinLock); + return OldIrql; +} + +/* + * @implemented + */ +VOID +NTAPI +KeReleaseSpinLock(PKSPIN_LOCK SpinLock, + KIRQL NewIrql) +{ + /* Call the fastcall function */ + KfReleaseSpinLock(SpinLock, NewIrql); +} + +/* + * @implemented + */ +KIRQL +FASTCALL +KfAcquireSpinLock(PKSPIN_LOCK SpinLock) +{ + KIRQL OldIrql; + + /* Raise to dispatch and acquire the lock */ + KeRaiseIrql(DISPATCH_LEVEL, &OldIrql); + KxAcquireSpinLock(SpinLock); + return OldIrql; +} + +/* + * @implemented + */ +VOID +FASTCALL +KfReleaseSpinLock(PKSPIN_LOCK SpinLock, + KIRQL OldIrql) +{ + /* Release the lock and lower IRQL back */ + KxReleaseSpinLock(SpinLock); + KeLowerIrql(OldIrql); +} + +/* + * @implemented + */ +KIRQL +FASTCALL +KeAcquireQueuedSpinLock(IN KSPIN_LOCK_QUEUE_NUMBER LockNumber) +{ + KIRQL OldIrql; + + /* Raise to dispatch */ + KeRaiseIrql(DISPATCH_LEVEL, &OldIrql); + + /* Acquire the lock */ + KxAcquireSpinLock(KeGetCurrentPrcb()->LockQueue[LockNumber].Lock); // HACK + return OldIrql; +} + +/* + * @implemented + */ +KIRQL +FASTCALL +KeAcquireQueuedSpinLockRaiseToSynch(IN KSPIN_LOCK_QUEUE_NUMBER LockNumber) +{ + KIRQL OldIrql; + + /* Raise to synch */ + KeRaiseIrql(SYNCH_LEVEL, &OldIrql); + + /* Acquire the lock */ + KxAcquireSpinLock(KeGetCurrentPrcb()->LockQueue[LockNumber].Lock); // HACK + return OldIrql; +} + +/* + * @implemented + */ +VOID +FASTCALL +KeAcquireInStackQueuedSpinLock(IN PKSPIN_LOCK SpinLock, + IN PKLOCK_QUEUE_HANDLE LockHandle) +{ + /* Set up the lock */ + LockHandle->LockQueue.Next = NULL; + LockHandle->LockQueue.Lock = SpinLock; + + /* Raise to dispatch */ + KeRaiseIrql(DISPATCH_LEVEL, &LockHandle->OldIrql); + + /* Acquire the lock */ + KxAcquireSpinLock(LockHandle->LockQueue.Lock); // HACK +} + +/* + * @implemented + */ +VOID +FASTCALL +KeAcquireInStackQueuedSpinLockRaiseToSynch(IN PKSPIN_LOCK SpinLock, + IN PKLOCK_QUEUE_HANDLE LockHandle) +{ + /* Set up the lock */ + LockHandle->LockQueue.Next = NULL; + LockHandle->LockQueue.Lock = SpinLock; + + /* Raise to synch */ + KeRaiseIrql(SYNCH_LEVEL, &LockHandle->OldIrql); + + /* Acquire the lock */ + KxAcquireSpinLock(LockHandle->LockQueue.Lock); // HACK +} + +/* + * @implemented + */ +VOID +FASTCALL +KeReleaseQueuedSpinLock(IN KSPIN_LOCK_QUEUE_NUMBER LockNumber, + IN KIRQL OldIrql) +{ + /* Release the lock */ + KxReleaseSpinLock(KeGetCurrentPrcb()->LockQueue[LockNumber].Lock); // HACK + + /* Lower IRQL back */ + KeLowerIrql(OldIrql); +} + +/* + * @implemented + */ +VOID +FASTCALL +KeReleaseInStackQueuedSpinLock(IN PKLOCK_QUEUE_HANDLE LockHandle) +{ + /* Simply lower IRQL back */ + KxReleaseSpinLock(LockHandle->LockQueue.Lock); // HACK + KeLowerIrql(LockHandle->OldIrql); +} + +/* + * @implemented + */ +BOOLEAN +FASTCALL +KeTryToAcquireQueuedSpinLockRaiseToSynch(IN KSPIN_LOCK_QUEUE_NUMBER LockNumber, + IN PKIRQL OldIrql) +{ +#ifdef CONFIG_SMP + ASSERT(FALSE); // FIXME: Unused + while (TRUE); +#endif + + /* Simply raise to synch */ + KeRaiseIrql(SYNCH_LEVEL, OldIrql); + + /* Always return true on UP Machines */ + return TRUE; +} + +/* + * @implemented + */ +LOGICAL +FASTCALL +KeTryToAcquireQueuedSpinLock(IN KSPIN_LOCK_QUEUE_NUMBER LockNumber, + OUT PKIRQL OldIrql) +{ +#ifdef CONFIG_SMP + ASSERT(FALSE); // FIXME: Unused + while (TRUE); +#endif + + /* Simply raise to dispatch */ + KeRaiseIrql(DISPATCH_LEVEL, OldIrql); + + /* Always return true on UP Machines */ + return TRUE; +} + #undef KeRaiseIrql - -/* FUNCTIONS *****************************************************************/ - -/* - * @implemented - */ -VOID -NTAPI -KeLowerIrql(KIRQL NewIrql) -{ - /* Call the fastcall function */ - KfLowerIrql(NewIrql); -} - /* * @implemented */ @@ -42,161 +336,14 @@ *OldIrql = KfRaiseIrql(NewIrql); } +#undef KeLowerIrql /* * @implemented */ VOID NTAPI -KeAcquireSpinLock(PKSPIN_LOCK SpinLock, - PKIRQL OldIrql) +KeLowerIrql(KIRQL NewIrql) { /* Call the fastcall function */ - *OldIrql = KfAcquireSpinLock(SpinLock); -} - -/* - * @implemented - */ -KIRQL -FASTCALL -KeAcquireSpinLockRaiseToSynch(PKSPIN_LOCK SpinLock) -{ - /* Simply raise to dispatch */ - return KfRaiseIrql(DISPATCH_LEVEL); -} - -/* - * @implemented - */ -VOID -NTAPI -KeReleaseSpinLock(PKSPIN_LOCK SpinLock, - KIRQL NewIrql) -{ - /* Call the fastcall function */ - KfReleaseSpinLock(SpinLock, NewIrql); -} - -/* - * @implemented - */ -KIRQL -FASTCALL -KfAcquireSpinLock(PKSPIN_LOCK SpinLock) -{ - /* Simply raise to dispatch */ - return KfRaiseIrql(DISPATCH_LEVEL); -} - -/* - * @implemented - */ -VOID -FASTCALL -KfReleaseSpinLock(PKSPIN_LOCK SpinLock, - KIRQL OldIrql) -{ - /* Simply lower IRQL back */ - KfLowerIrql(OldIrql); -} - -/* - * @implemented - */ -KIRQL -FASTCALL -KeAcquireQueuedSpinLock(IN KSPIN_LOCK_QUEUE_NUMBER LockNumber) -{ - /* Simply raise to dispatch */ - return KfRaiseIrql(DISPATCH_LEVEL); -} - -/* - * @implemented - */ -KIRQL -FASTCALL -KeAcquireQueuedSpinLockRaiseToSynch(IN KSPIN_LOCK_QUEUE_NUMBER LockNumber) -{ - /* Simply raise to dispatch */ - return KfRaiseIrql(DISPATCH_LEVEL); -} - -/* - * @implemented - */ -VOID -FASTCALL -KeAcquireInStackQueuedSpinLock(IN PKSPIN_LOCK SpinLock, - IN PKLOCK_QUEUE_HANDLE LockHandle) -{ - /* Simply raise to dispatch */ - LockHandle->OldIrql = KfRaiseIrql(DISPATCH_LEVEL); -} - -/* - * @implemented - */ -VOID -FASTCALL -KeAcquireInStackQueuedSpinLockRaiseToSynch(IN PKSPIN_LOCK SpinLock, - IN PKLOCK_QUEUE_HANDLE LockHandle) -{ - /* Simply raise to synch */ - LockHandle->OldIrql = KfRaiseIrql(SYNCH_LEVEL); -} - -/* - * @implemented - */ -VOID -FASTCALL -KeReleaseQueuedSpinLock(IN KSPIN_LOCK_QUEUE_NUMBER LockNumber, - IN KIRQL OldIrql) -{ - /* Simply lower IRQL back */ - KfLowerIrql(OldIrql); -} - -/* - * @implemented - */ -VOID -FASTCALL -KeReleaseInStackQueuedSpinLock(IN PKLOCK_QUEUE_HANDLE LockHandle) -{ - /* Simply lower IRQL back */ - KfLowerIrql(LockHandle->OldIrql); -} - -/* - * @implemented - */ -BOOLEAN -FASTCALL -KeTryToAcquireQueuedSpinLockRaiseToSynch(IN KSPIN_LOCK_QUEUE_NUMBER LockNumber, - IN PKIRQL OldIrql) -{ - /* Simply raise to dispatch */ - *OldIrql = KfRaiseIrql(DISPATCH_LEVEL); - - /* Always return true on UP Machines */ - return TRUE; -} - -/* - * @implemented - */ -LOGICAL -FASTCALL -KeTryToAcquireQueuedSpinLock(IN KSPIN_LOCK_QUEUE_NUMBER LockNumber, - OUT PKIRQL OldIrql) -{ - /* Simply raise to dispatch */ - *OldIrql = KfRaiseIrql(DISPATCH_LEVEL); - - /* Always return true on UP Machines */ - return TRUE; -} - -/* EOF */ + KfLowerIrql(NewIrql); +} Modified: trunk/reactos/include/ndk/asm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/asm.h?rev=4324… ============================================================================== --- trunk/reactos/include/ndk/asm.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/asm.h [iso-8859-1] Wed Sep 30 22:30:57 2009 @@ -568,7 +568,21 @@ #define APC_LEVEL 0x1 #define DISPATCH_LEVEL 0x2 #define CLOCK2_LEVEL 0x1C +#define IPI_LEVEL 0x1D #define HIGH_LEVEL 0x1F + +// +// Synchronization-level IRQL +// +#ifndef CONFIG_SMP +#define SYNCH_LEVEL DISPATCH_LEVEL +#else +#if (NTDDI_VERSION < NTDDI_WS03) +#define SYNCH_LEVEL (IPI_LEVEL - 0x1) +#else +#define SYNCH_LEVEL (IPI_LEVEL - 0x2) +#endif +#endif // // Quantum Decrements Modified: trunk/reactos/ntoskrnl/include/internal/ke.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/ke.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/ke.h [iso-8859-1] Wed Sep 30 22:30:57 2009 @@ -245,7 +245,7 @@ KiExitDispatcher(KIRQL OldIrql); VOID -NTAPI +FASTCALL KiDeferredReadyThread(IN PKTHREAD Thread); PKTHREAD Modified: trunk/reactos/ntoskrnl/include/internal/ke_x.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/ke_x.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/ke_x.h [iso-8859-1] Wed Sep 30 22:30:57 2009 @@ -437,12 +437,20 @@ VOID KxAcquireSpinLock(IN PKSPIN_LOCK SpinLock) { + /* Make sure that we don't own the lock already */ + if (((KSPIN_LOCK)KeGetCurrentThread() | 1) == *SpinLock) + { + /* We do, bugcheck! */ + KeBugCheckEx(SPIN_LOCK_ALREADY_OWNED, (ULONG_PTR)SpinLock, 0, 0, 0); + } + + /* Start acquire loop */ for (;;) { /* Try to acquire it */ if (InterlockedBitTestAndSet((PLONG)SpinLock, 0)) { - /* Value changed... wait until it's locked */ + /* Value changed... wait until it's unlocked */ while (*(volatile KSPIN_LOCK *)SpinLock == 1) { #if DBG @@ -553,7 +561,8 @@ KiAcquireDispatcherLockAtDpcLevel(VOID) { /* Acquire the dispatcher lock */ - KeAcquireQueuedSpinLockAtDpcLevel(LockQueueDispatcherLock); + KeAcquireQueuedSpinLockAtDpcLevel(&KeGetCurrentPrcb()-> + LockQueue[LockQueueDispatcherLock]); } FORCEINLINE @@ -561,11 +570,12 @@ KiReleaseDispatcherLockFromDpcLevel(VOID) { /* Release the dispatcher lock */ - KeReleaseQueuedSpinLockFromDpcLevel(LockQueueDispatcherLock); -} - -// -// This routine inserts a thread into the deferred ready list of the given CPU + KeReleaseQueuedSpinLockFromDpcLevel(&KeGetCurrentPrcb()-> + LockQueue[LockQueueDispatcherLock]); +} + +// +// This routine inserts a thread into the deferred ready list of the current CPU // FORCEINLINE VOID @@ -613,7 +623,7 @@ // This routine acquires the PRCB lock so that only one caller can touch // volatile PRCB data. // -// Since this is a simple optimized spin-lock, it must be be only acquired +// Since this is a simple optimized spin-lock, it must only be acquired // at dispatcher level or higher! // FORCEINLINE @@ -649,7 +659,8 @@ VOID KiReleasePrcbLock(IN PKPRCB Prcb) { - /* Make sure it's acquired! */ + /* Make sure we are above dispatch and the lock is acquired! */ + ASSERT(KeGetCurrentIrql() >= DISPATCH_LEVEL); ASSERT(Prcb->PrcbLock != 0); /* Release it */ @@ -696,6 +707,9 @@ VOID KiReleaseThreadLock(IN PKTHREAD Thread) { + /* Make sure we are still above dispatch */ + ASSERT(KeGetCurrentIrql() >= DISPATCH_LEVEL); + /* Release it */ InterlockedAnd((PLONG)&Thread->ThreadLock, 0); } @@ -729,10 +743,8 @@ VOID KiRundownThread(IN PKTHREAD Thread) { -#if defined(_M_IX86) || defined(_M_AMD64) - /* FIXME: TODO */ - ASSERTMSG("Not yet implemented\n", FALSE); -#endif + /* Nothing to do */ + return; } FORCEINLINE Modified: trunk/reactos/ntoskrnl/ke/dpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/dpc.c?rev=4324… ============================================================================== --- trunk/reactos/ntoskrnl/ke/dpc.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/dpc.c [iso-8859-1] Wed Sep 30 22:30:57 2009 @@ -550,6 +550,9 @@ PKDEFERRED_ROUTINE DeferredRoutine; PVOID DeferredContext, SystemArgument1, SystemArgument2; ULONG_PTR TimerHand; +#ifdef CONFIG_SMP + KIRQL OldIrql; +#endif /* Get data and list variables before starting anything else */ DpcData = &Prcb->DpcData[DPC_NORMAL]; @@ -631,12 +634,23 @@ Prcb->DpcRoutineActive = FALSE; Prcb->DpcInterruptRequested = FALSE; +#ifdef CONFIG_SMP /* Check if we have deferred threads */ if (Prcb->DeferredReadyListHead.Next) { - /* FIXME: 2K3-style scheduling not implemeted */ - ASSERT(FALSE); - } + + /* Re-enable interrupts and raise to synch */ + _enable(); + OldIrql = KeRaiseIrqlToSynchLevel(); + + /* Process deferred threads */ + KiProcessDeferredReadyList(Prcb); + + /* Lower IRQL back and disable interrupts */ + KeLowerIrql(OldIrql); + _disable(); + } +#endif } while (DpcData->DpcQueueDepth != 0); } Modified: trunk/reactos/ntoskrnl/ke/i386/ctxswitch.S URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/ctxswitch… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/ctxswitch.S [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/i386/ctxswitch.S [iso-8859-1] Wed Sep 30 22:30:57 2009 @@ -351,8 +351,8 @@ jz NotBusy pause jmp GetSwapLock -#endif NotBusy: +#endif /* Increase context switches (use ES for lazy load) */ inc dword ptr es:[ebx+KPCR_CONTEXT_SWITCHES] @@ -381,9 +381,9 @@ /* Check NPX State */ cmp byte ptr [edi+KTHREAD_NPX_STATE], NPX_STATE_LOADED jz NpxLoaded -#endif - SetStack: +#endif + /* Set new stack */ mov [edi+KTHREAD_KERNEL_STACK], esp @@ -423,7 +423,7 @@ test [ebp+KPROCESS_ACTIVE_PROCESSORS], ecx jz WrongActiveCpu test [eax+KPROCESS_ACTIVE_PROCESSORS], ecx - jz WrongActiveCpu + jnz WrongActiveCpu #endif #endif @@ -563,8 +563,29 @@ #ifdef CONFIG_SMP NpxLoaded: - /* FIXME: TODO */ - int 3 + /* Mask out FPU flags */ + and edx, ~(CR0_MP + CR0_EM + CR0_TS) + + /* Get the NPX Frame */ + mov ecx, [edi+KTHREAD_INITIAL_STACK] + sub ecx, NPX_FRAME_LENGTH + + /* Check if we have a new CR0 */ + cmp ebp, edx + jz Cr0Equal + + /* We do, update it */ + mov cr0, edx + mov ebp, edx + +Cr0Equal: + + /* Save the NPX State */ + fxsave [ecx] + mov byte ptr [edi+KTHREAD_NPX_STATE], NPX_STATE_NOT_LOADED + + /* Clear the NPX Thread */ + mov dword ptr [ebx+KPCR_NPX_THREAD], 0 /* Jump back */ jmp SetStack @@ -762,7 +783,7 @@ #ifdef CONFIG_SMP SameThread: - /* Clear the next thread, and put the thready as ready after lock release */ + /* Clear the next thread, and put the thread as ready after lock release */ and dword ptr [ebx+KPCR_PRCB_NEXT_THREAD], 0 and dword ptr [ebx+KPCR_PRCB_PRCB_LOCK], 0 and byte ptr [edi+KTHREAD_STATE_], Ready @@ -837,9 +858,9 @@ /* Sanity check */ #if DBG - test dword ptr [edx+KPROCESS_ACTIVE_PROCESSORS], 0 + test [edx+KPROCESS_ACTIVE_PROCESSORS], ecx jz WrongCpu1 - test dword ptr [eax+KPROCESS_ACTIVE_PROCESSORS], 0 + test [eax+KPROCESS_ACTIVE_PROCESSORS], ecx jnz WrongCpu2 #endif #endif Modified: trunk/reactos/ntoskrnl/ke/i386/trap.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/trap.s?re… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/trap.s [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/i386/trap.s [iso-8859-1] Wed Sep 30 22:30:57 2009 @@ -2736,11 +2736,25 @@ /* Go to DIRQL */ mov cl, [ebx+KINTERRUPT_SYNCHRONIZE_IRQL] call @KfRaiseIrql@4 + push eax + +#ifdef CONFIG_SMP + /* Acquire the interrupt spinlock FIXME: Write this in assembly */ + mov ecx, [ebx+KINTERRUPT_ACTUAL_LOCK] + call @KefAcquireSpinLockAtDpcLevel@4 +#endif /* Call the routine */ - push eax push [esp+20] call [esp+20] + +#ifdef CONFIG_SMP + /* Release the interrupt spinlock FIXME: Write this in assembly */ + push eax + mov ecx, [ebx+KINTERRUPT_ACTUAL_LOCK] + call @KefReleaseSpinLockFromDpcLevel@4 + pop eax +#endif /* Lower IRQL */ mov ebx, eax @@ -2752,3 +2766,32 @@ pop ebx ret 12 .endfunc + +/*++ + * Kii386SpinOnSpinLock + * + * FILLMEIN + * + * Params: + * SpinLock - FILLMEIN + * + * Flags - FILLMEIN + * + * Returns: + * None. + * + * Remarks: + * FILLMEIN + * + *--*/ +.globl _Kii386SpinOnSpinLock@8 +.func Kii386SpinOnSpinLock@8 +_Kii386SpinOnSpinLock@8: + +#ifdef CONFIG_SMP + /* FIXME: TODO */ + int 3 +#endif + + ret 8 +.endfunc Modified: trunk/reactos/ntoskrnl/ke/spinlock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/spinlock.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/ke/spinlock.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/spinlock.c [iso-8859-1] Wed Sep 30 22:30:57 2009 @@ -17,6 +17,11 @@ /* PRIVATE FUNCTIONS *********************************************************/ +#if 0 +// +// FIXME: The queued spinlock routines are broken. +// + VOID FASTCALL KeAcquireQueuedSpinLockAtDpcLevel(IN PKSPIN_LOCK_QUEUE LockHandle) @@ -84,6 +89,55 @@ #endif } +#else +// +// HACK: Hacked to work like normal spinlocks +// + +VOID +FASTCALL +KeAcquireQueuedSpinLockAtDpcLevel(IN PKSPIN_LOCK_QUEUE LockHandle) +{ +#ifdef CONFIG_SMP + /* Make sure we are at DPC or above! */ + if (KeGetCurrentIrql() < DISPATCH_LEVEL) + { + /* We aren't -- bugcheck */ + KeBugCheckEx(IRQL_NOT_GREATER_OR_EQUAL, + (ULONG_PTR)LockHandle->Lock, + KeGetCurrentIrql(), + 0, + 0); + } + + /* Do the inlined function */ + KxAcquireSpinLock(LockHandle->Lock); +#endif +} + +VOID +FASTCALL +KeReleaseQueuedSpinLockFromDpcLevel(IN PKSPIN_LOCK_QUEUE LockHandle) +{ +#ifdef CONFIG_SMP + /* Make sure we are at DPC or above! */ + if (KeGetCurrentIrql() < DISPATCH_LEVEL) + { + /* We aren't -- bugcheck */ + KeBugCheckEx(IRQL_NOT_GREATER_OR_EQUAL, + (ULONG_PTR)LockHandle->Lock, + KeGetCurrentIrql(), + 0, + 0); + } + + /* Do the inlined function */ + KxReleaseSpinLock(LockHandle->Lock); +#endif +} + +#endif + /* PUBLIC FUNCTIONS **********************************************************/ /* @@ -137,6 +191,17 @@ NTAPI KeAcquireSpinLockAtDpcLevel(IN PKSPIN_LOCK SpinLock) { + /* Make sure we are at DPC or above! */ + if (KeGetCurrentIrql() < DISPATCH_LEVEL) + { + /* We aren't -- bugcheck */ + KeBugCheckEx(IRQL_NOT_GREATER_OR_EQUAL, + (ULONG_PTR)SpinLock, + KeGetCurrentIrql(), + 0, + 0); + } + /* Do the inlined function */ KxAcquireSpinLock(SpinLock); } @@ -149,7 +214,18 @@ NTAPI KeReleaseSpinLockFromDpcLevel(IN PKSPIN_LOCK SpinLock) { - /* Do the lined function */ + /* Make sure we are at DPC or above! */ + if (KeGetCurrentIrql() < DISPATCH_LEVEL) + { + /* We aren't -- bugcheck */ + KeBugCheckEx(IRQL_NOT_GREATER_OR_EQUAL, + (ULONG_PTR)SpinLock, + KeGetCurrentIrql(), + 0, + 0); + } + + /* Do the inlined function */ KxReleaseSpinLock(SpinLock); } @@ -160,6 +236,17 @@ FASTCALL KefAcquireSpinLockAtDpcLevel(IN PKSPIN_LOCK SpinLock) { + /* Make sure we are at DPC or above! */ + if (KeGetCurrentIrql() < DISPATCH_LEVEL) + { + /* We aren't -- bugcheck */ + KeBugCheckEx(IRQL_NOT_GREATER_OR_EQUAL, + (ULONG_PTR)SpinLock, + KeGetCurrentIrql(), + 0, + 0); + } + /* Do the inlined function */ KxAcquireSpinLock(SpinLock); } @@ -171,7 +258,18 @@ FASTCALL KefReleaseSpinLockFromDpcLevel(IN PKSPIN_LOCK SpinLock) { - /* Do the lined function */ + /* Make sure we are at DPC or above! */ + if (KeGetCurrentIrql() < DISPATCH_LEVEL) + { + /* We aren't -- bugcheck */ + KeBugCheckEx(IRQL_NOT_GREATER_OR_EQUAL, + (ULONG_PTR)SpinLock, + KeGetCurrentIrql(), + 0, + 0); + } + + /* Do the inlined function */ KxReleaseSpinLock(SpinLock); } @@ -243,7 +341,23 @@ /* Set it up properly */ LockHandle->LockQueue.Next = NULL; LockHandle->LockQueue.Lock = SpinLock; +#if 0 KeAcquireQueuedSpinLockAtDpcLevel(LockHandle->LockQueue.Next); +#else + /* Make sure we are at DPC or above! */ + if (KeGetCurrentIrql() < DISPATCH_LEVEL) + { + /* We aren't -- bugcheck */ + KeBugCheckEx(IRQL_NOT_GREATER_OR_EQUAL, + (ULONG_PTR)LockHandle->LockQueue.Lock, + KeGetCurrentIrql(), + 0, + 0); + } + + /* Acquire the lock */ + KxAcquireSpinLock(LockHandle->LockQueue.Lock); // HACK +#endif #endif } @@ -255,8 +369,24 @@ KeReleaseInStackQueuedSpinLockFromDpcLevel(IN PKLOCK_QUEUE_HANDLE LockHandle) { #ifdef CONFIG_SMP +#if 0 /* Call the internal function */ KeReleaseQueuedSpinLockFromDpcLevel(LockHandle->LockQueue.Next); +#else + /* Make sure we are at DPC or above! */ + if (KeGetCurrentIrql() < DISPATCH_LEVEL) + { + /* We aren't -- bugcheck */ + KeBugCheckEx(IRQL_NOT_GREATER_OR_EQUAL, + (ULONG_PTR)LockHandle->LockQueue.Lock, + KeGetCurrentIrql(), + 0, + 0); + } + + /* Release the lock */ + KxReleaseSpinLock(LockHandle->LockQueue.Lock); // HACK +#endif #endif } @@ -324,5 +454,3 @@ /* Spinlock appears to be free */ return TRUE; } - -/* EOF */ Modified: trunk/reactos/ntoskrnl/ke/thrdschd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/thrdschd.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/ke/thrdschd.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/thrdschd.c [iso-8859-1] Wed Sep 30 22:30:57 2009 @@ -24,7 +24,7 @@ KiIdleSchedule(IN PKPRCB Prcb) { /* FIXME: TODO */ - ASSERTMSG("Not yet implemented\n", FALSE); + ASSERTMSG("SMP: Not yet implemented\n", FALSE); return NULL; } @@ -32,8 +32,29 @@ FASTCALL KiProcessDeferredReadyList(IN PKPRCB Prcb) { - /* FIXME: TODO */ - ASSERTMSG("Not yet implemented\n", FALSE); + PSINGLE_LIST_ENTRY ListEntry; + PKTHREAD Thread; + + /* Make sure there is something on the ready list */ + ASSERT(Prcb->DeferredReadyListHead.Next != NULL); + + /* Get the first entry and clear the list */ + ListEntry = Prcb->DeferredReadyListHead.Next; + Prcb->DeferredReadyListHead.Next = NULL; + + /* Start processing loop */ + do + { + /* Get the thread and advance to the next entry */ + Thread = CONTAINING_RECORD(ListEntry, KTHREAD, SwapListEntry); + ListEntry = ListEntry->Next; + + /* Make the thread ready */ + KiDeferredReadyThread(Thread); + } while (ListEntry != NULL); + + /* Make sure the ready list is still empty */ + ASSERT(Prcb->DeferredReadyListHead.Next == NULL); } VOID @@ -46,7 +67,7 @@ } VOID -NTAPI +FASTCALL KiDeferredReadyThread(IN PKTHREAD Thread) { PKPRCB Prcb; @@ -191,9 +212,10 @@ OldPriority = Thread->Priority; Thread->Preempted = FALSE; - /* Queue the thread on CPU 0 and get the PRCB */ + /* Queue the thread on CPU 0 and get the PRCB and lock it */ Thread->NextProcessor = 0; Prcb = KiProcessorBlock[0]; + KiAcquirePrcbLock(Prcb); /* Check if we have an idle summary */ if (KiIdleSummary) @@ -202,6 +224,9 @@ KiIdleSummary = 0; Thread->State = Standby; Prcb->NextThread = Thread; + + /* Unlock the PRCB and return */ + KiReleasePrcbLock(Prcb); return; } @@ -300,6 +325,7 @@ Prcb->IdleSchedule = TRUE; /* FIXME: SMT support */ + ASSERTMSG("SMP: Not yet implemented\n", FALSE); } /* Sanity checks and return the thread */ Modified: trunk/reactos/ntoskrnl/ntoskrnl.pspec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntoskrnl.pspec?re… ============================================================================== --- trunk/reactos/ntoskrnl/ntoskrnl.pspec [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ntoskrnl.pspec [iso-8859-1] Wed Sep 30 22:30:57 2009 @@ -718,7 +718,7 @@ @ fastcall KiReleaseSpinLock(ptr) @ cdecl KiUnexpectedInterrupt() #ifdef _M_IX86 -;Kii386SpinOnSpinLock +@ stdcall Kii386SpinOnSpinLock(ptr long) #endif @ stdcall LdrAccessResource(ptr ptr ptr ptr) @ stdcall LdrEnumResources(ptr ptr long ptr ptr)

15 years, 2 months

[sginsberg] 43243: - ASSERT on NULL-frees

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Wed Sep 30 21:29:08 2009 New Revision: 43243 URL: http://svn.reactos.org/svn/reactos?rev=43243&view=rev Log: - ASSERT on NULL-frees Modified: trunk/reactos/ntoskrnl/mm/pool.c Modified: trunk/reactos/ntoskrnl/mm/pool.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/pool.c?rev=432… ============================================================================== --- trunk/reactos/ntoskrnl/mm/pool.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/pool.c [iso-8859-1] Wed Sep 30 21:29:08 2009 @@ -294,10 +294,11 @@ else if (Block) ExFreeArmPoolWithTag(Block, Tag); else { - /* Warn only for NULL pointers */ + /* Only warn and break for NULL pointers */ if (Block == NULL) { DPRINT1("Warning: Trying to free a NULL pointer!\n"); + ASSERT(FALSE); return; }

15 years, 2 months

[janderwald] 43242: - Several bugfixes for mixer source / destination line detection code - Fix a memory leak

by janderwald＠svn.reactos.org

Author: janderwald Date: Wed Sep 30 20:58:52 2009 New Revision: 43242 URL: http://svn.reactos.org/svn/reactos?rev=43242&view=rev Log: - Several bugfixes for mixer source / destination line detection code - Fix a memory leak Modified: trunk/reactos/drivers/wdm/audio/legacy/wdmaud/mixer.c trunk/reactos/drivers/wdm/audio/legacy/wdmaud/wdmaud.h Modified: trunk/reactos/drivers/wdm/audio/legacy/wdmaud/mixer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/w… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/wdmaud/mixer.c [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/legacy/wdmaud/mixer.c [iso-8859-1] Wed Sep 30 20:58:52 2009 @@ -166,6 +166,41 @@ return Status; } +ULONG +GetDeviceIndexFromPnpName( + IN PDEVICE_OBJECT DeviceObject, + LPWSTR Device) +{ + ULONG Count, Index; + LPWSTR DeviceName; + NTSTATUS Status; + + /* get device count */ + Count = GetSysAudioDeviceCount(DeviceObject); + + if (!Count) + return MAXULONG; + + for(Index = 0; Index < Count; Index++) + { + /* get device name */ + Status = GetSysAudioDevicePnpName(DeviceObject, Index, &DeviceName); + if (NT_SUCCESS(Status)) + { + if (!wcsicmp(Device, DeviceName)) + { + /* found device index */ + ExFreePool(DeviceName); + return Index; + } + ExFreePool(DeviceName); + } + } + + return MAXULONG; +} + + NTSTATUS OpenDevice( IN LPWSTR Device, @@ -453,7 +488,7 @@ /* first count all referenced nodes */ for(Index = 0; Index < MultipleItem->Count; Index++) { - //DPRINT1("FromPin %u FromNode %u ToPin %u ToNode %u\n", Connection->FromNodePin, Connection->FromNode, Connection->ToNodePin, Connection->ToNode); + //DbgPrint("FromPin %u FromNode %u ToPin %u ToNode %u\n", Connection->FromNodePin, Connection->FromNode, Connection->ToNodePin, Connection->ToNode); if (bNode) { if (bFrom) @@ -477,7 +512,7 @@ { if (bFrom) { - if (Connection->FromNodePin == NodeIndex) + if (Connection->FromNodePin == NodeIndex && Connection->FromNode == KSFILTER_NODE) { /* node id has a connection */ Count++; @@ -485,7 +520,7 @@ } else { - if (Connection->ToNodePin == NodeIndex) + if (Connection->ToNodePin == NodeIndex && Connection->ToNode == KSFILTER_NODE) { /* node id has a connection */ Count++; @@ -507,6 +542,9 @@ /* not enough memory */ return STATUS_INSUFFICIENT_RESOURCES; } + + /* clear node index array */ + RtlZeroMemory(Refs, Count * sizeof(ULONG)); Count = 0; Connection = (PKSTOPOLOGY_CONNECTION)(MultipleItem + 1); @@ -537,7 +575,7 @@ { if (bFrom) { - if (Connection->FromNodePin == NodeIndex) + if (Connection->FromNodePin == NodeIndex && Connection->FromNode == KSFILTER_NODE) { /* node id has a connection */ Refs[Count] = Index; @@ -546,7 +584,7 @@ } else { - if (Connection->ToNodePin == NodeIndex) + if (Connection->ToNodePin == NodeIndex && Connection->ToNode == KSFILTER_NODE) { /* node id has a connection */ Refs[Count] = Index; @@ -685,6 +723,7 @@ AddMixerSourceLine( IN OUT LPMIXER_INFO MixerInfo, IN PFILE_OBJECT FileObject, + IN ULONG DeviceIndex, IN ULONG PinId) { LPMIXERLINE_EXT SrcLine, DstLine; @@ -703,7 +742,7 @@ RtlZeroMemory(SrcLine, sizeof(MIXERLINE_EXT)); /* initialize mixer src line */ - SrcLine->FileObject = FileObject; + SrcLine->DeviceIndex = DeviceIndex; SrcLine->PinId = PinId; SrcLine->Line.cbStruct = sizeof(MIXERLINEW); @@ -812,6 +851,7 @@ AddMixerSourceLines( IN OUT LPMIXER_INFO MixerInfo, IN PFILE_OBJECT FileObject, + IN ULONG DeviceIndex, IN ULONG PinsCount, IN PULONG Pins) { @@ -822,7 +862,7 @@ { if (Pins[Index-1]) { - AddMixerSourceLine(MixerInfo, FileObject, Index-1); + AddMixerSourceLine(MixerInfo, FileObject, DeviceIndex, Index-1); } } return Status; @@ -833,11 +873,12 @@ NTSTATUS HandlePhysicalConnection( IN OUT LPMIXER_INFO MixerInfo, + IN PDEVICE_OBJECT DeviceObject, IN ULONG bInput, IN PKSPIN_PHYSICALCONNECTION OutConnection) { PULONG PinsRef = NULL, PinConnectionIndex = NULL, PinsSrcRef; - ULONG PinsRefCount, Index, PinConnectionIndexCount; + ULONG PinsRefCount, Index, PinConnectionIndexCount, DeviceIndex; NTSTATUS Status; HANDLE hDevice = NULL; PFILE_OBJECT FileObject = NULL; @@ -855,6 +896,9 @@ return Status; } + /* get device index */ + DeviceIndex = GetDeviceIndexFromPnpName(DeviceObject, OutConnection->SymbolicLinkName); + /* get connected filter pin count */ PinsRefCount = GetPinCount(FileObject); ASSERT(PinsRefCount); @@ -943,7 +987,7 @@ PinsSrcRef[OutConnection->Pin] = TRUE; } - Status = AddMixerSourceLines(MixerInfo, FileObject, PinsRefCount, PinsSrcRef); + Status = AddMixerSourceLines(MixerInfo, FileObject, DeviceIndex, PinsRefCount, PinsSrcRef); ExFreePool(MixerControls); ExFreePool(PinsSrcRef); @@ -1075,7 +1119,8 @@ Status = GetPhysicalConnection(FileObject, Index, &OutConnection); if (NT_SUCCESS(Status)) { - Status = HandlePhysicalConnection(MixerInfo, bInput, OutConnection); + Status = HandlePhysicalConnection(MixerInfo, DeviceObject, bInput, OutConnection); + ExFreePool(OutConnection); } } } @@ -1093,7 +1138,6 @@ HANDLE hDevice; PFILE_OBJECT FileObject; PKSMULTIPLE_ITEM NodeTypes, NodeConnections; - BOOL bCloseHandle; PWDMAUD_DEVICE_EXTENSION DeviceExtension; /* get device extension */ @@ -1151,7 +1195,6 @@ /* get num of pins */ PinCount = GetPinCount(FileObject); - bCloseHandle = TRUE; /* get the first available dac node index */ NodeIndex = GetNodeTypeIndex(NodeTypes, (LPGUID)&KSNODETYPE_DAC); if (NodeIndex != (ULONG)-1) @@ -1161,7 +1204,6 @@ { /* increment mixer offset */ Count++; - bCloseHandle = FALSE; } } @@ -1174,7 +1216,6 @@ { /* increment mixer offset */ Count++; - bCloseHandle = FALSE; } } @@ -1182,12 +1223,10 @@ ExFreePool(NodeTypes); ExFreePool(NodeConnections); - if (bCloseHandle) - { - /* close virtual audio device */ - ObDereferenceObject(FileObject); - ZwClose(hDevice); - } + /* close virtual audio device */ + ObDereferenceObject(FileObject); + ZwClose(hDevice); + } /* increment virtual audio device index */ Index++; Modified: trunk/reactos/drivers/wdm/audio/legacy/wdmaud/wdmaud.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/legacy/w… ============================================================================== --- trunk/reactos/drivers/wdm/audio/legacy/wdmaud/wdmaud.h [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/legacy/wdmaud/wdmaud.h [iso-8859-1] Wed Sep 30 20:58:52 2009 @@ -37,7 +37,7 @@ { LIST_ENTRY Entry; ULONG PinId; - PFILE_OBJECT FileObject; + ULONG DeviceIndex; MIXERLINEW Line; LPMIXERCONTROLW LineControls; }MIXERLINE_EXT, *LPMIXERLINE_EXT;

15 years, 2 months

[sginsberg] 43241: - KeBugCheckEx expects BugCheckParameter2 to point to an array when the bug code is FATAL_UNHANDLED_HARD_ERROR -- properly stub out ExpSystemErrorHandler so we don't crash in KeBugCheckEx.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Wed Sep 30 20:31:26 2009 New Revision: 43241 URL: http://svn.reactos.org/svn/reactos?rev=43241&view=rev Log: - KeBugCheckEx expects BugCheckParameter2 to point to an array when the bug code is FATAL_UNHANDLED_HARD_ERROR -- properly stub out ExpSystemErrorHandler so we don't crash in KeBugCheckEx. Modified: trunk/reactos/ntoskrnl/ex/harderr.c Modified: trunk/reactos/ntoskrnl/ex/harderr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/harderr.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ex/harderr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/harderr.c [iso-8859-1] Wed Sep 30 20:31:26 2009 @@ -58,10 +58,12 @@ IN PULONG_PTR Parameters, IN BOOLEAN Shutdown) { + ULONG_PTR Dummy[4] = {0, 0, 0, 0}; + /* FIXME: STUB */ KeBugCheckEx(FATAL_UNHANDLED_HARD_ERROR, ErrorStatus, - 0, + (ULONG_PTR)Dummy, 0, 0); return STATUS_SUCCESS;

15 years, 2 months

[sginsberg] 43240: - Fix recursive spinlock acquisition in Mm caused by locking inconsistency between ARM3 and the old ReactOS Mm. The old Mm calls certain routines to modify PFN entries (lock, unlock, reference, dereference, etc) and acquires/releases the PFN lock inside those functions (which is extremely inefficient as you can't, for example, have to acquire/release the PFN lock twice to reference and lock the same page), while ARM3 synchronizes differently and holds the lock while calling th

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Wed Sep 30 20:24:00 2009 New Revision: 43240 URL: http://svn.reactos.org/svn/reactos?rev=43240&view=rev Log: - Fix recursive spinlock acquisition in Mm caused by locking inconsistency between ARM3 and the old ReactOS Mm. The old Mm calls certain routines to modify PFN entries (lock, unlock, reference, dereference, etc) and acquires/releases the PFN lock inside those functions (which is extremely inefficient as you can't, for example, have to acquire/release the PFN lock twice to reference and lock the same page), while ARM3 synchronizes differently and holds the lock while calling those routines, resulting in a recursive lock attempt on MP (which works on UP because spinlocks are just IRQL raise/lower there). Move out locking from MmAllocPage, MmReference/DereferencePage and MmLock/UnlockPage to the callers to be consistent with ARM3. - Add missing PFN locking to MmFreePagesFromMdl and MiAllocatePoolPages. - Get rid of MmLockPageUnsafe and MmReferencePageUnsafe. The "safe" routines just forwarded to the unsafe versions -- call them directly instead. Remove unused MmAcquirePageListLock/MmReleasePageListLock. Modified: trunk/reactos/ntoskrnl/include/internal/mm.h trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c trunk/reactos/ntoskrnl/mm/ARM3/pool.c trunk/reactos/ntoskrnl/mm/anonmem.c trunk/reactos/ntoskrnl/mm/balance.c trunk/reactos/ntoskrnl/mm/freelist.c trunk/reactos/ntoskrnl/mm/mmfault.c trunk/reactos/ntoskrnl/mm/section.c Modified: trunk/reactos/ntoskrnl/include/internal/mm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/mm.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/mm.h [iso-8859-1] Wed Sep 30 20:24:00 2009 @@ -1095,32 +1095,11 @@ VOID NTAPI -MmLockPageUnsafe(PFN_TYPE Page); - -VOID -NTAPI MmUnlockPage(PFN_TYPE Page); ULONG NTAPI MmGetLockCountPage(PFN_TYPE Page); - -static -__inline -KIRQL -NTAPI -MmAcquirePageListLock() -{ - return KeAcquireQueuedSpinLock(LockQueuePfnLock); -} - -FORCEINLINE -VOID -NTAPI -MmReleasePageListLock(KIRQL oldIrql) -{ - KeReleaseQueuedSpinLock(LockQueuePfnLock, oldIrql); -} VOID NTAPI @@ -1342,10 +1321,6 @@ VOID NTAPI MmReferencePage(PFN_TYPE Page); - -VOID -NTAPI -MmReferencePageUnsafe(PFN_TYPE Page); ULONG NTAPI Modified: trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] Wed Sep 30 20:24:00 2009 @@ -215,6 +215,7 @@ PPFN_NUMBER Pages; LONG NumberOfPages; PMMPFN Pfn1; + KIRQL OldIrql; DPRINT("Freeing MDL: %p\n", Mdl); // @@ -229,7 +230,12 @@ // Base = (PVOID)((ULONG_PTR)Mdl->StartVa + Mdl->ByteOffset); NumberOfPages = ADDRESS_AND_SIZE_TO_SPAN_PAGES(Base, Mdl->ByteCount); - + + // + // Acquire PFN lock + // + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); + // // Loop all the MDL pages // @@ -268,7 +274,12 @@ // *Pages++ = -1; } while (--NumberOfPages != 0); - + + // + // Release the lock + // + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); + // // Remove the pages locked flag // Modified: trunk/reactos/ntoskrnl/mm/ARM3/pool.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/pool.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/pool.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/pool.c [iso-8859-1] Wed Sep 30 20:24:00 2009 @@ -141,6 +141,7 @@ PMMPFN Pfn1; PVOID BaseVa; PMMFREE_POOL_ENTRY FreeEntry; + PKSPIN_LOCK_QUEUE LockQueue; // // Figure out how big the allocation is in pages @@ -285,7 +286,8 @@ // // Lock the PFN database too // - //KeAcquireQueuedSpinLockAtDpcLevel(LockQueuePfnLock); + LockQueue = &KeGetCurrentPrcb()->LockQueue[LockQueuePfnLock]; + KeAcquireQueuedSpinLockAtDpcLevel(LockQueue); // // Loop the pages @@ -326,7 +328,7 @@ // // Release the PFN and nonpaged pool lock // - //KeReleaseQueuedSpinLockFromDpcLevel(LockQueuePfnLock); + KeReleaseQueuedSpinLockFromDpcLevel(LockQueue); KeReleaseQueuedSpinLock(LockQueueMmNonPagedPoolLock, OldIrql); // Modified: trunk/reactos/ntoskrnl/mm/anonmem.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/anonmem.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] Wed Sep 30 20:24:00 2009 @@ -258,6 +258,7 @@ PMM_REGION Region; PMM_PAGEOP PageOp; PEPROCESS Process = MmGetAddressSpaceOwner(AddressSpace); + KIRQL OldIrql; /* * There is a window between taking the page fault and locking the @@ -268,7 +269,9 @@ { if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(MmGetPfnForProcess(NULL, Address)); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } return(STATUS_SUCCESS); } @@ -362,7 +365,9 @@ MmLockAddressSpace(AddressSpace); if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(MmGetPfnForProcess(NULL, Address)); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } KeSetEvent(&PageOp->CompletionEvent, IO_NO_INCREMENT, FALSE); MmReleasePageOp(PageOp); @@ -437,7 +442,9 @@ */ if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(Page); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } PageOp->Status = STATUS_SUCCESS; KeSetEvent(&PageOp->CompletionEvent, IO_NO_INCREMENT, FALSE); Modified: trunk/reactos/ntoskrnl/mm/balance.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/balance.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/balance.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/balance.c [iso-8859-1] Wed Sep 30 20:24:00 2009 @@ -105,7 +105,7 @@ { PMM_ALLOCATION_REQUEST Request; PLIST_ENTRY Entry; - KIRQL oldIrql; + KIRQL OldIrql; if (Page == 0) { @@ -113,20 +113,22 @@ KeBugCheck(MEMORY_MANAGEMENT); } - KeAcquireSpinLock(&AllocationListLock, &oldIrql); + KeAcquireSpinLock(&AllocationListLock, &OldIrql); if (MmGetReferenceCountPage(Page) == 1) { (void)InterlockedDecrementUL(&MiMemoryConsumers[Consumer].PagesUsed); if (IsListEmpty(&AllocationListHead) || MmStats.NrFreePages < MiMinimumAvailablePages) { - KeReleaseSpinLock(&AllocationListLock, oldIrql); + KeReleaseSpinLock(&AllocationListLock, OldIrql); + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmDereferencePage(Page); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } else { Entry = RemoveHeadList(&AllocationListHead); Request = CONTAINING_RECORD(Entry, MM_ALLOCATION_REQUEST, ListEntry); - KeReleaseSpinLock(&AllocationListLock, oldIrql); + KeReleaseSpinLock(&AllocationListLock, OldIrql); if(Consumer == MC_USER) MmRemoveLRUUserPage(Page); MiZeroPage(Page); Request->Page = Page; @@ -135,9 +137,11 @@ } else { - KeReleaseSpinLock(&AllocationListLock, oldIrql); + KeReleaseSpinLock(&AllocationListLock, OldIrql); if(Consumer == MC_USER) MmRemoveLRUUserPage(Page); + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmDereferencePage(Page); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } return(STATUS_SUCCESS); @@ -235,7 +239,7 @@ { ULONG OldUsed; PFN_TYPE Page; - KIRQL oldIrql; + KIRQL OldIrql; /* * Make sure we don't exceed our individual target. @@ -257,7 +261,9 @@ */ if ((Consumer == MC_NPPOOL) || (Consumer == MC_SYSTEM) || MiIsBalancerThread()) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); Page = MmAllocPage(Consumer, 0); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); if (Page == 0) { KeBugCheck(NO_PAGES_AVAILABLE); @@ -290,14 +296,14 @@ KeInitializeEvent(&Request.Event, NotificationEvent, FALSE); (void)InterlockedIncrementUL(&MiPagesRequired); - KeAcquireSpinLock(&AllocationListLock, &oldIrql); + KeAcquireSpinLock(&AllocationListLock, &OldIrql); if (MiBalancerThreadHandle != NULL) { KeSetEvent(&MiBalancerEvent, IO_NO_INCREMENT, FALSE); } InsertTailList(&AllocationListHead, &Request.ListEntry); - KeReleaseSpinLock(&AllocationListLock, oldIrql); + KeReleaseSpinLock(&AllocationListLock, OldIrql); KeWaitForSingleObject(&Request.Event, 0, @@ -321,7 +327,9 @@ /* * Actually allocate the page. */ + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); Page = MmAllocPage(Consumer, 0); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); if (Page == 0) { KeBugCheck(NO_PAGES_AVAILABLE); Modified: trunk/reactos/ntoskrnl/mm/freelist.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/freelist.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/mm/freelist.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/freelist.c [iso-8859-1] Wed Sep 30 20:24:00 2009 @@ -830,19 +830,16 @@ VOID NTAPI -MmReferencePageUnsafe(PFN_TYPE Pfn) -{ - KIRQL oldIrql; +MmReferencePage(PFN_TYPE Pfn) +{ PPHYSICAL_PAGE Page; - DPRINT("MmReferencePageUnsafe(PysicalAddress %x)\n", Pfn << PAGE_SHIFT); + DPRINT("MmReferencePage(PysicalAddress %x)\n", Pfn << PAGE_SHIFT); if (Pfn == 0 || Pfn > MmHighestPhysicalPage) { return; } - - oldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); Page = MiGetPfnEntry(Pfn); ASSERT(Page); @@ -853,16 +850,6 @@ } Page->ReferenceCount++; - KeReleaseQueuedSpinLock(LockQueuePfnLock, oldIrql); -} - -VOID -NTAPI -MmReferencePage(PFN_TYPE Pfn) -{ - DPRINT("MmReferencePage(PysicalAddress %x)\n", Pfn << PAGE_SHIFT); - - MmReferencePageUnsafe(Pfn); } ULONG @@ -904,13 +891,10 @@ NTAPI MmDereferencePage(PFN_TYPE Pfn) { - KIRQL oldIrql; PPHYSICAL_PAGE Page; DPRINT("MmDereferencePage(PhysicalAddress %x)\n", Pfn << PAGE_SHIFT); - oldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); - Page = MiGetPfnEntry(Pfn); ASSERT(Page); @@ -962,7 +946,6 @@ KeSetEvent(&ZeroPageThreadEvent, IO_NO_INCREMENT, FALSE); } } - KeReleaseQueuedSpinLock(LockQueuePfnLock, oldIrql); } ULONG @@ -993,14 +976,11 @@ VOID NTAPI -MmLockPageUnsafe(PFN_TYPE Pfn) -{ - KIRQL oldIrql; +MmLockPage(PFN_TYPE Pfn) +{ PPHYSICAL_PAGE Page; - DPRINT("MmLockPageUnsafe(PhysicalAddress %x)\n", Pfn << PAGE_SHIFT); - - oldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); + DPRINT("MmLockPage(PhysicalAddress %x)\n", Pfn << PAGE_SHIFT); Page = MiGetPfnEntry(Pfn); ASSERT(Page); @@ -1011,28 +991,15 @@ } Page->LockCount++; - KeReleaseQueuedSpinLock(LockQueuePfnLock, oldIrql); } VOID NTAPI -MmLockPage(PFN_TYPE Pfn) -{ - DPRINT("MmLockPage(PhysicalAddress %x)\n", Pfn << PAGE_SHIFT); - - MmLockPageUnsafe(Pfn); -} - -VOID -NTAPI MmUnlockPage(PFN_TYPE Pfn) { - KIRQL oldIrql; PPHYSICAL_PAGE Page; DPRINT("MmUnlockPage(PhysicalAddress %x)\n", Pfn << PAGE_SHIFT); - - oldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); Page = MiGetPfnEntry(Pfn); ASSERT(Page); @@ -1043,7 +1010,6 @@ } Page->LockCount--; - KeReleaseQueuedSpinLock(LockQueuePfnLock, oldIrql); } PFN_TYPE @@ -1053,12 +1019,10 @@ PFN_TYPE PfnOffset; PLIST_ENTRY ListEntry; PPHYSICAL_PAGE PageDescriptor; - KIRQL oldIrql; BOOLEAN NeedClear = FALSE; DPRINT("MmAllocPage()\n"); - oldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); if (IsListEmpty(&FreeZeroedPageListHead)) { if (IsListEmpty(&FreeUnzeroedPageListHead)) @@ -1070,7 +1034,6 @@ } DPRINT1("MmAllocPage(): Out of memory\n"); - KeReleaseQueuedSpinLock(LockQueuePfnLock, oldIrql); return 0; } ListEntry = RemoveTailList(&FreeUnzeroedPageListHead); @@ -1105,8 +1068,6 @@ MmStats.NrSystemPages++; MmStats.NrFreePages--; - - KeReleaseQueuedSpinLock(LockQueuePfnLock, oldIrql); PfnOffset = PageDescriptor - MmPfnDatabase; if ((NeedClear) && (Consumer != MC_SYSTEM)) Modified: trunk/reactos/ntoskrnl/mm/mmfault.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/mmfault.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/mmfault.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/mmfault.c [iso-8859-1] Wed Sep 30 20:24:00 2009 @@ -288,6 +288,8 @@ { NTSTATUS Status; PFN_TYPE AllocatedPage; + KIRQL OldIrql; + Status = MmRequestPageMemoryConsumer(MC_PPOOL, FALSE, &AllocatedPage); if (!NT_SUCCESS(Status)) { @@ -303,7 +305,9 @@ 1); if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(AllocatedPage); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } return(Status); } Modified: trunk/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] Wed Sep 30 20:24:00 2009 @@ -771,6 +771,7 @@ PMM_REGION Region; BOOLEAN HasSwapEntry; PEPROCESS Process = MmGetAddressSpaceOwner(AddressSpace); + KIRQL OldIrql; /* * There is a window between taking the page fault and locking the @@ -781,7 +782,9 @@ { if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(MmGetPfnForProcess(Process, Address)); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } return(STATUS_SUCCESS); } @@ -908,7 +911,9 @@ } if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(Page); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } MmUnlockSectionSegment(Segment); PageOp->Status = STATUS_SUCCESS; @@ -978,7 +983,9 @@ */ if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(Page); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } PageOp->Status = STATUS_SUCCESS; MmspCompleteAndReleasePageOp(PageOp); @@ -1013,7 +1020,9 @@ */ if (Locked) { - MmLockPageUnsafe(Page); + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); + MmLockPage(Page); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } /* @@ -1056,7 +1065,9 @@ MmInsertRmap(Page, Process, (PVOID)PAddress); if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(Page); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } /* @@ -1156,7 +1167,9 @@ if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(Page); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } PageOp->Status = STATUS_SUCCESS; MmspCompleteAndReleasePageOp(PageOp); @@ -1230,7 +1243,9 @@ MmInsertRmap(Page, Process, (PVOID)PAddress); if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(Page); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } PageOp->Status = STATUS_SUCCESS; MmspCompleteAndReleasePageOp(PageOp); @@ -1262,7 +1277,9 @@ MmInsertRmap(Page, Process, (PVOID)PAddress); if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(Page); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } PageOp->Status = STATUS_SUCCESS; MmspCompleteAndReleasePageOp(PageOp); @@ -1289,6 +1306,7 @@ PMM_REGION Region; ULONG Entry; PEPROCESS Process = MmGetAddressSpaceOwner(AddressSpace); + KIRQL OldIrql; DPRINT("MmAccessFaultSectionView(%x, %x, %x, %x)\n", AddressSpace, MemoryArea, Address, Locked); @@ -1429,8 +1447,10 @@ } if (Locked) { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmLockPage(NewPage); MmUnlockPage(OldPage); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } /* @@ -1511,6 +1531,7 @@ BOOLEAN DirectMapped; BOOLEAN IsImageSection; PEPROCESS Process = MmGetAddressSpaceOwner(AddressSpace); + KIRQL OldIrql; Address = (PVOID)PAGE_ROUND_DOWN(Address); @@ -1599,7 +1620,9 @@ } else { + OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); MmReferencePage(Page); + KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); } MmDeleteAllRmaps(Page, (PVOID)&Context, MmPageOutDeleteMapping);

15 years, 2 months

[fireball] 43239: [fastfat_new] - Partially implement a codepath for opening an existing file. - Implement simple FCB and CCB creation. - Correctly set FILE_OBJECT fields. - Allocate space for SECTION_POINTERS. - Implement some misc in FatQueryInformation. - The driver goes up to getting a read request for ntdll.dll.

by fireball＠svn.reactos.org

Author: fireball Date: Wed Sep 30 18:16:18 2009 New Revision: 43239 URL: http://svn.reactos.org/svn/reactos?rev=43239&view=rev Log: [fastfat_new] - Partially implement a codepath for opening an existing file. - Implement simple FCB and CCB creation. - Correctly set FILE_OBJECT fields. - Allocate space for SECTION_POINTERS. - Implement some misc in FatQueryInformation. - The driver goes up to getting a read request for ntdll.dll. Modified: trunk/reactos/drivers/filesystems/fastfat_new/create.c trunk/reactos/drivers/filesystems/fastfat_new/fastfat.c trunk/reactos/drivers/filesystems/fastfat_new/fastfat.h trunk/reactos/drivers/filesystems/fastfat_new/fatstruc.h trunk/reactos/drivers/filesystems/fastfat_new/fcb.c trunk/reactos/drivers/filesystems/fastfat_new/finfo.c trunk/reactos/drivers/filesystems/fastfat_new/rw.c Modified: trunk/reactos/drivers/filesystems/fastfat_new/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/create.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/create.c [iso-8859-1] Wed Sep 30 18:16:18 2009 @@ -37,6 +37,54 @@ DPRINT1("Opening root directory\n"); Iosb.Status = STATUS_NOT_IMPLEMENTED; + + return Iosb; +} + +IO_STATUS_BLOCK +NTAPI +FatiOpenExistingFile(IN PFAT_IRP_CONTEXT IrpContext, + IN PFILE_OBJECT FileObject, + IN PVCB Vcb, + IN PFCB ParentDcb, + IN PACCESS_MASK DesiredAccess, + IN USHORT ShareAccess, + IN ULONG AllocationSize, + IN PFILE_FULL_EA_INFORMATION EaBuffer, + IN ULONG EaLength, + IN UCHAR FileAttributes, + IN ULONG CreateDisposition, + IN BOOLEAN IsPagingFile, + IN BOOLEAN DeleteOnClose, + IN BOOLEAN IsDosName) +{ + IO_STATUS_BLOCK Iosb = {{0}}; + PFCB Fcb; + + /* Check for create file option and fail */ + if (CreateDisposition == FILE_CREATE) + { + Iosb.Status = STATUS_OBJECT_NAME_COLLISION; + return Iosb; + } + + // TODO: Check more params + + /* Create a new FCB for this file */ + Fcb = FatCreateFcb(IrpContext, Vcb, ParentDcb); + + // TODO: Check if overwrite is needed + + // This is usual file open branch, without overwriting! + /* Set context and section object pointers */ + FatSetFileObject(FileObject, + UserFileOpen, + Fcb, + FatCreateCcb()); + FileObject->SectionObjectPointer = &Fcb->SectionObjectPointers; + + Iosb.Status = STATUS_SUCCESS; + Iosb.Information = FILE_OPENED; return Iosb; } @@ -443,10 +491,35 @@ // TODO: Create a DCB for this entry } - // Simulate that we opened the file - //Iosb.Information = FILE_OPENED; - Irp->IoStatus.Information = FILE_OPENED; - FileObject->SectionObjectPointer = (PSECTION_OBJECT_POINTERS)0x1; + // TODO: Try to open directory + + /* If end backslash here, then it's definately not permitted, + since we're opening files here */ + if (EndBackslash) + { + /* Complete the request */ + Iosb.Status = STATUS_OBJECT_NAME_INVALID; + FatCompleteRequest(IrpContext, Irp, Iosb.Status); + return Iosb.Status; + } + + /* Try to open the file */ + Iosb = FatiOpenExistingFile(IrpContext, + FileObject, + Vcb, + ParentDcb, + DesiredAccess, + ShareAccess, + AllocationSize, + EaBuffer, + EaLength, + FileAttributes, + CreateDisposition, + FALSE, + DeleteOnClose, + OpenedAsDos); + + Irp->IoStatus.Information = Iosb.Information; } /* Complete the request */ Modified: trunk/reactos/drivers/filesystems/fastfat_new/fastfat.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/fastfat.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/fastfat.c [iso-8859-1] Wed Sep 30 18:16:18 2009 @@ -137,6 +137,7 @@ /* Save IRP, MJ and MN */ IrpContext->Irp = Irp; + IrpContext->Stack = IrpSp; IrpContext->MajorFunction = IrpSp->MajorFunction; IrpContext->MinorFunction = IrpSp->MinorFunction; @@ -338,6 +339,34 @@ return TypeOfOpen; } +VOID +NTAPI +FatSetFileObject(PFILE_OBJECT FileObject, + TYPE_OF_OPEN TypeOfOpen, + PVOID Fcb, + PCCB Ccb) +{ + if (Fcb) + { + /* Check Fcb's type */ + if (FatNodeType(Fcb) == FAT_NTC_VCB) + { + FileObject->Vpb = ((PVCB)Fcb)->Vpb; + } + else + { + FileObject->Vpb = ((PFCB)Fcb)->Vcb->Vpb; + } + } + + /* Set FsContext */ + if (FileObject) + { + FileObject->FsContext = Fcb; + FileObject->FsContext2 = Ccb; + } +} + BOOLEAN NTAPI Modified: trunk/reactos/drivers/filesystems/fastfat_new/fastfat.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/fastfat.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/fastfat.h [iso-8859-1] Wed Sep 30 18:16:18 2009 @@ -153,13 +153,11 @@ OUT PFCB *FcbOrDcb, OUT PCCB *Ccb); -/* --------------------------------------------------------- fcb.c */ - -PFCB NTAPI -FatFindFcb(PFAT_IRP_CONTEXT IrpContext, - PRTL_SPLAY_LINKS *RootNode, - PSTRING AnsiName, - PBOOLEAN IsDosName); +VOID NTAPI +FatSetFileObject(PFILE_OBJECT FileObject, + TYPE_OF_OPEN TypeOfOpen, + PVOID Fcb, + PCCB Ccb); /* --------------------------------------------------------- fullfat.c */ @@ -263,14 +261,11 @@ IN PFCB ParentFcb, IN PFCB Fcb); -NTSTATUS +PFCB NTAPI FatCreateFcb( - OUT PFCB* CreatedFcb, - IN PFAT_IRP_CONTEXT IrpContext, - IN PFCB ParentFcb, - IN PDIR_ENTRY Dirent, - IN PUNICODE_STRING FileName, - IN PUNICODE_STRING LongFileName OPTIONAL); + IN PFAT_IRP_CONTEXT IrpContext, + IN PVCB Vcb, + IN PFCB ParentDcb); NTSTATUS FatOpenFcb( @@ -279,6 +274,15 @@ IN PFCB ParentFcb, IN PUNICODE_STRING FileName); +PFCB NTAPI +FatFindFcb(PFAT_IRP_CONTEXT IrpContext, + PRTL_SPLAY_LINKS *RootNode, + PSTRING AnsiName, + PBOOLEAN IsDosName); + +PCCB NTAPI +FatCreateCcb(); + /* ------------------------------------------------------------ rw.c */ NTSTATUS NTAPI Modified: trunk/reactos/drivers/filesystems/fastfat_new/fatstruc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/fatstruc.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/fatstruc.h [iso-8859-1] Wed Sep 30 18:16:18 2009 @@ -19,6 +19,7 @@ #define FAT_NTC_FCB (CSHORT) 'CF' #define FAT_NTC_DCB (CSHORT) 'DF' #define FAT_NTC_ROOT_DCB (CSHORT) 'RFD' +#define FAT_NTC_CCB (CSHORT) 'BCC' typedef struct _FAT_GLOBAL_DATA { @@ -334,6 +335,9 @@ typedef struct _CCB { + CSHORT NodeTypeCode; + CSHORT NodeByteSize; + LARGE_INTEGER CurrentByteOffset; ULONG Entry; UNICODE_STRING SearchPattern; Modified: trunk/reactos/drivers/filesystems/fastfat_new/fcb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/fcb.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/fcb.c [iso-8859-1] Wed Sep 30 18:16:18 2009 @@ -105,5 +105,60 @@ return NULL; } +PFCB +NTAPI +FatCreateFcb(IN PFAT_IRP_CONTEXT IrpContext, + IN PVCB Vcb, + IN PFCB ParentDcb) +{ + PFCB Fcb; + + /* Allocate it and zero it */ + Fcb = ExAllocatePoolWithTag(NonPagedPool, sizeof(FCB), TAG_FCB); + RtlZeroMemory(Fcb, sizeof(FCB)); + + /* Set node types */ + Fcb->Header.NodeTypeCode = FAT_NTC_FCB; + Fcb->Header.NodeByteSize = sizeof(FCB); + Fcb->Condition = FcbGood; + + /* Initialize resources */ + Fcb->Header.Resource = &Fcb->Resource; + ExInitializeResourceLite(Fcb->Header.Resource); + + Fcb->Header.PagingIoResource = &Fcb->PagingIoResource; + ExInitializeResourceLite(Fcb->Header.PagingIoResource); + + /* Initialize mutexes */ + Fcb->Header.FastMutex = &Fcb->HeaderMutex; + ExInitializeFastMutex(&Fcb->HeaderMutex); + FsRtlSetupAdvancedHeader(&Fcb->Header, &Fcb->HeaderMutex); + + /* Insert into parent's DCB list */ + InsertTailList(&ParentDcb->Dcb.ParentDcbList, &Fcb->ParentDcbLinks); + + /* Set backlinks */ + Fcb->ParentFcb = ParentDcb; + Fcb->Vcb = Vcb; + + return Fcb; +} + +PCCB +NTAPI +FatCreateCcb() +{ + PCCB Ccb; + + /* Allocate the CCB and zero it */ + Ccb = ExAllocatePoolWithTag(NonPagedPool, sizeof(CCB), TAG_CCB); + RtlZeroMemory(Ccb, sizeof(CCB)); + + /* Set mandatory header */ + Ccb->NodeTypeCode = FAT_NTC_FCB; + Ccb->NodeByteSize = sizeof(CCB); + + return Ccb; +} /* EOF */ Modified: trunk/reactos/drivers/filesystems/fastfat_new/finfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/finfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/finfo.c [iso-8859-1] Wed Sep 30 18:16:18 2009 @@ -15,10 +15,77 @@ NTSTATUS NTAPI +FatiQueryInformation(IN PFAT_IRP_CONTEXT IrpContext, + IN PIRP Irp) +{ + PFILE_OBJECT FileObject; + PIO_STACK_LOCATION IrpSp; + FILE_INFORMATION_CLASS InfoClass; + TYPE_OF_OPEN FileType; + PVCB Vcb; + PFCB Fcb; + PCCB Ccb; + + /* Get IRP stack location */ + IrpSp = IoGetCurrentIrpStackLocation(Irp); + + /* Get the file object */ + FileObject = IrpSp->FileObject; + + InfoClass = IrpSp->Parameters.QueryFile.FileInformationClass; + + DPRINT1("FatCommonQueryInformation\n", 0); + DPRINT1("\tIrp = %08lx\n", Irp); + DPRINT1("\tLength = %08lx\n", IrpSp->Parameters.QueryFile.Length); + DPRINT1("\tFileInformationClass = %08lx\n", InfoClass); + DPRINT1("\tBuffer = %08lx\n", Irp->AssociatedIrp.SystemBuffer); + + FileType = FatDecodeFileObject(FileObject, &Vcb, &Fcb, &Ccb); + + DPRINT1("Vcb %p, Fcb %p, Ccb %p, open type %d\n", Vcb, Fcb, Ccb, FileType); + + return STATUS_SUCCESS; +} + +NTSTATUS +NTAPI FatQueryInformation(PDEVICE_OBJECT DeviceObject, PIRP Irp) { - DPRINT1("FatQueryInformation()\n"); - return STATUS_NOT_IMPLEMENTED; + NTSTATUS Status; + BOOLEAN TopLevel, CanWait; + PFAT_IRP_CONTEXT IrpContext; + + CanWait = TRUE; + TopLevel = FALSE; + Status = STATUS_INVALID_DEVICE_REQUEST; + + /* Get CanWait flag */ + if (IoGetCurrentIrpStackLocation(Irp)->FileObject != NULL) + CanWait = IoIsOperationSynchronous(Irp); + + /* Enter FsRtl critical region */ + FsRtlEnterFileSystem(); + + /* Set Top Level IRP if not set */ + if (IoGetTopLevelIrp() == NULL) + { + IoSetTopLevelIrp(Irp); + TopLevel = TRUE; + } + + /* Build an irp context */ + IrpContext = FatBuildIrpContext(Irp, CanWait); + + /* Perform the actual read */ + Status = FatiQueryInformation(IrpContext, Irp); + + /* Restore top level Irp */ + if (TopLevel) IoSetTopLevelIrp(NULL); + + /* Leave FsRtl critical region */ + FsRtlExitFileSystem(); + + return Status; } NTSTATUS Modified: trunk/reactos/drivers/filesystems/fastfat_new/rw.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/rw.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/rw.c [iso-8859-1] Wed Sep 30 18:16:18 2009 @@ -18,19 +18,28 @@ NTAPI FatiRead(PFAT_IRP_CONTEXT IrpContext) { - CSHORT FcbType; ULONG NumberOfBytes; + LARGE_INTEGER ByteOffset; + PFILE_OBJECT FileObject; + TYPE_OF_OPEN OpenType; + PIO_STACK_LOCATION IrpSp = IrpContext->Stack; + PFCB Fcb; + PVCB Vcb; + PCCB Ccb; - FcbType = *((PCSHORT) IrpContext->FileObject->FsContext); - NumberOfBytes = IrpContext->Stack->Parameters.Read.Length; + FileObject = IrpSp->FileObject; + NumberOfBytes = IrpSp->Parameters.Read.Length; + ByteOffset = IrpSp->Parameters.Read.ByteOffset; if (NumberOfBytes == 0) { FatCompleteRequest(IrpContext, IrpContext->Irp, STATUS_SUCCESS); return STATUS_SUCCESS; } - //if (FcbType == FAT_NTC_VCB) + + OpenType = FatDecodeFileObject(FileObject, &Vcb, &Fcb, &Ccb); - DPRINT1("FatiRead()\n"); + DPRINT1("FatiRead() Fcb %p, Name %wZ, Offset %d, Length %d\n", + Fcb, &FileObject->FileName, ByteOffset.LowPart, NumberOfBytes); return STATUS_NOT_IMPLEMENTED; }

15 years, 2 months

[sginsberg] 43238: - ...and this one.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Wed Sep 30 15:43:55 2009 New Revision: 43238 URL: http://svn.reactos.org/svn/reactos?rev=43238&view=rev Log: - ...and this one. Modified: trunk/reactos/lib/inflib/inflib.rbuild Modified: trunk/reactos/lib/inflib/inflib.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/inflib/inflib.rbuild?r… ============================================================================== --- trunk/reactos/lib/inflib/inflib.rbuild [iso-8859-1] (original) +++ trunk/reactos/lib/inflib/inflib.rbuild [iso-8859-1] Wed Sep 30 15:43:55 2009 @@ -3,7 +3,6 @@ <group> <module name="inflib" type="staticlibrary"> <include base="inflib">.</include> - <define name="__NO_CTYPE_INLINES" /> <file>infcore.c</file> <file>infget.c</file> <file>infput.c</file>

15 years, 2 months

[sginsberg] 43237: - Missed this one

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Wed Sep 30 15:33:48 2009 New Revision: 43237 URL: http://svn.reactos.org/svn/reactos?rev=43237&view=rev Log: - Missed this one Modified: trunk/reactos/dll/win32/crtdll/crtdll.rbuild Modified: trunk/reactos/dll/win32/crtdll/crtdll.rbuild URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/crtdll/crtdll.rb… ============================================================================== --- trunk/reactos/dll/win32/crtdll/crtdll.rbuild [iso-8859-1] (original) +++ trunk/reactos/dll/win32/crtdll/crtdll.rbuild [iso-8859-1] Wed Sep 30 15:33:48 2009 @@ -5,7 +5,6 @@ <define name="USE_MSVCRT_PREFIX" /> <define name="_MSVCRT_LIB_" /> <define name="_MSVCRT_" /> - <define name="__NO_CTYPE_INLINES" /> <define name="_CTYPE_DISABLE_MACROS" /> <define name="_NO_INLINING" />

15 years, 2 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2009