Ros-diffs August 2010

ros-diffs@reactos.org

14 participants
282 discussions

[cgutman] 48521: [MSWSOCK] - Add another parameter check inside the FIONBIO code - Implement FIONREAD - Pass any unhandled I/O control codes to our helper DLL - This commit should be backported to msafd

by cgutman＠svn.reactos.org

Author: cgutman Date: Thu Aug 12 04:42:54 2010 New Revision: 48521 URL: http://svn.reactos.org/svn/reactos?rev=48521&view=rev Log: [MSWSOCK] - Add another parameter check inside the FIONBIO code - Implement FIONREAD - Pass any unhandled I/O control codes to our helper DLL - This commit should be backported to msafd Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/sockopt.c Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/sockopt.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-branch/dll/win32/… ============================================================================== --- branches/aicom-network-branch/dll/win32/mswsock/msafd/sockopt.c [iso-8859-1] (original) +++ branches/aicom-network-branch/dll/win32/mswsock/msafd/sockopt.c [iso-8859-1] Thu Aug 12 04:42:54 2010 @@ -213,7 +213,7 @@ PSOCKET_INFORMATION Socket; INT ErrorCode; PWINSOCK_TEB_DATA ThreadData; - BOOLEAN Blocking; + BOOLEAN Blocking, NeedsCompletion; /* Enter prolog */ ErrorCode = SockEnterApiFast(&ThreadData); @@ -240,7 +240,7 @@ case FIONBIO: /* Check if the Buffer is OK */ - if(cbInBuffer < sizeof(ULONG)) + if(cbInBuffer < sizeof(ULONG) || IS_INTRESOURCE(lpvInBuffer)) { /* Fail */ ErrorCode = WSAEFAULT; @@ -258,10 +258,43 @@ NULL); break; + case FIONREAD: + if(cbOutBuffer < sizeof(ULONG) || IS_INTRESOURCE(lpvOutBuffer)) + { + *lpErrno = WSAEFAULT; + return SOCKET_ERROR; + } + + ErrorCode = SockGetInformation(Socket, + AFD_INFO_RECEIVE_CONTENT_SIZE, + NULL, + 0, + NULL, + (PULONG)lpvOutBuffer, + NULL); + + if (ErrorCode == NO_ERROR) *lpcbBytesReturned = sizeof(ULONG); + break; + default: - - /* Unsupported for now */ - ErrorCode = WSAEINVAL; + /* Unsupported by us, give it to the helper */ + ErrorCode = SockGetTdiHandles(Socket); + if (ErrorCode != NO_ERROR) goto error; + + /* Call the helper */ + ErrorCode = Socket->HelperData->WSHIoctl(Socket->HelperContext, + Handle, + Socket->TdiAddressHandle, + Socket->TdiConnectionHandle, + dwIoControlCode, + lpvInBuffer, + cbInBuffer, + lpvOutBuffer, + cbOutBuffer, + lpcbBytesReturned, + lpOverlapped, + lpCompletionRoutine, + (LPBOOL)&NeedsCompletion); break; }

14 years, 3 months

[cgutman] 48520: [MSWSOCK] - Check for STATUS_SUCCESS explicitly instead of using the NT_SUCCESS macro because somebody at MS thought it was a great idea to make STATUS_TIMEOUT a success status thus causing endless hours of bug hunting for the poor developers that make this same mistake - STATUS_TIMEOUT isn't an error status so checking for it with NT_ERROR won't work either instead just add a special case in the if for STATUS_TIMEOUT

by cgutman＠svn.reactos.org

Author: cgutman Date: Thu Aug 12 04:22:52 2010 New Revision: 48520 URL: http://svn.reactos.org/svn/reactos?rev=48520&view=rev Log: [MSWSOCK] - Check for STATUS_SUCCESS explicitly instead of using the NT_SUCCESS macro because somebody at MS thought it was a great idea to make STATUS_TIMEOUT a success status thus causing endless hours of bug hunting for the poor developers that make this same mistake - STATUS_TIMEOUT isn't an error status so checking for it with NT_ERROR won't work either instead just add a special case in the if for STATUS_TIMEOUT Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-branch/dll/win32/… ============================================================================== --- branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c [iso-8859-1] (original) +++ branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c [iso-8859-1] Thu Aug 12 04:22:52 2010 @@ -163,7 +163,7 @@ &IoStatusBlock, &Timeout); /* Check for success */ - if (NT_SUCCESS(Status)) + if (Status == STATUS_SUCCESS) { /* Check if this isn't the termination command */ if (AsyncCompletionRoutine != (PVOID)-1) @@ -180,7 +180,7 @@ InterlockedDecrement(&SockAsyncThreadReferenceCount); } } - else if ((SockAsyncThreadReferenceCount > 1) && (NT_ERROR(Status))) + else if ((SockAsyncThreadReferenceCount > 1) && (NT_ERROR(Status) || Status == STATUS_TIMEOUT)) { /* It Failed, sleep for a second */ Sleep(1000);

14 years, 3 months

[cgutman] 48519: [MSWSOCK] - Implement FIONBIO and fix the error case to not cause a deadlock later

by cgutman＠svn.reactos.org

Author: cgutman Date: Thu Aug 12 03:51:12 2010 New Revision: 48519 URL: http://svn.reactos.org/svn/reactos?rev=48519&view=rev Log: [MSWSOCK] - Implement FIONBIO and fix the error case to not cause a deadlock later Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/sockopt.c Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/sockopt.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-branch/dll/win32/… ============================================================================== --- branches/aicom-network-branch/dll/win32/mswsock/msafd/sockopt.c [iso-8859-1] (original) +++ branches/aicom-network-branch/dll/win32/mswsock/msafd/sockopt.c [iso-8859-1] Thu Aug 12 03:51:12 2010 @@ -213,7 +213,8 @@ PSOCKET_INFORMATION Socket; INT ErrorCode; PWINSOCK_TEB_DATA ThreadData; - + BOOLEAN Blocking; + /* Enter prolog */ ErrorCode = SockEnterApiFast(&ThreadData); if (ErrorCode != NO_ERROR) @@ -222,7 +223,7 @@ *lpErrno = ErrorCode; return SOCKET_ERROR; } - + /* Get the socket structure */ Socket = SockFindAndReferenceSocket(Handle, TRUE); if (!Socket) @@ -231,14 +232,13 @@ ErrorCode = WSAENOTSOCK; goto error; } - + /* Lock the socket */ EnterCriticalSection(&Socket->Lock); - + switch(dwIoControlCode) { - - case FIONBIO: - + + case FIONBIO: /* Check if the Buffer is OK */ if(cbInBuffer < sizeof(ULONG)) { @@ -246,16 +246,25 @@ ErrorCode = WSAEFAULT; goto error; } - - return 0; - + + Blocking = (*(PULONG)lpvInBuffer) ? TRUE : FALSE; + + Socket->SharedData.NonBlocking = Blocking; + + ErrorCode = SockSetInformation(Socket, + AFD_INFO_BLOCKING_MODE, + &Blocking, + NULL, + NULL); + break; + default: - + /* Unsupported for now */ - *lpErrno = WSAEINVAL; - return SOCKET_ERROR; - } - + ErrorCode = WSAEINVAL; + break; + } + error: /* Check if we had a socket */ if (Socket) @@ -264,7 +273,7 @@ LeaveCriticalSection(&Socket->Lock); SockDereferenceSocket(Socket); } - + /* Check for error */ if (ErrorCode != NO_ERROR) { @@ -272,7 +281,7 @@ *lpErrno = ErrorCode; return SOCKET_ERROR; } - + /* Return to caller */ return NO_ERROR; }

14 years, 3 months

[fireball] 48518: [FASTFAT_NEW] - Plug in a commented out notification call in case of cleanup. - Implement a case of device info query. - Implement lock control.

by fireball＠svn.reactos.org

Author: fireball Date: Wed Aug 11 12:18:24 2010 New Revision: 48518 URL: http://svn.reactos.org/svn/reactos?rev=48518&view=rev Log: [FASTFAT_NEW] - Plug in a commented out notification call in case of cleanup. - Implement a case of device info query. - Implement lock control. Modified: trunk/reactos/drivers/filesystems/fastfat_new/cleanup.c trunk/reactos/drivers/filesystems/fastfat_new/lock.c trunk/reactos/drivers/filesystems/fastfat_new/volume.c Modified: trunk/reactos/drivers/filesystems/fastfat_new/cleanup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/cleanup.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/cleanup.c [iso-8859-1] Wed Aug 11 12:18:24 2010 @@ -303,12 +303,11 @@ if (FlagOn(Fcb->State, FCB_STATE_DELETE_ON_CLOSE) && Fcb->Header.AllocationSize.LowPart == 0) { - UNIMPLEMENTED; - /*FatNotifyReportChange(IrpContext, + FatNotifyReportChange(IrpContext, Vcb, Fcb, FILE_NOTIFY_CHANGE_FILE_NAME, - FILE_ACTION_REMOVED );*/ + FILE_ACTION_REMOVED); } /* Remove the entry from the splay table if the file was deleted */ Modified: trunk/reactos/drivers/filesystems/fastfat_new/lock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/lock.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/lock.c [iso-8859-1] Wed Aug 11 12:18:24 2010 @@ -15,10 +15,96 @@ NTSTATUS NTAPI +FatiLockControl(PFAT_IRP_CONTEXT IrpContext, PIRP Irp) +{ + PIO_STACK_LOCATION IrpSp; + TYPE_OF_OPEN TypeOfOpen; + PVCB Vcb; + PFCB Fcb; + PCCB Ccb; + NTSTATUS Status; + + /* Get IRP stack location */ + IrpSp = IoGetCurrentIrpStackLocation(Irp); + + /* Determine type of open */ + TypeOfOpen = FatDecodeFileObject(IrpSp->FileObject, &Vcb, &Fcb, &Ccb); + + /* Only user file open is allowed */ + if (TypeOfOpen != UserFileOpen) + { + FatCompleteRequest(IrpContext, Irp, STATUS_INVALID_PARAMETER); + return STATUS_INVALID_PARAMETER; + } + + /* Acquire shared FCB lock */ + if (!FatAcquireSharedFcb(IrpContext, Fcb)) + { + UNIMPLEMENTED; + //Status = FatFsdPostRequest(IrpContext, Irp); + Status = STATUS_NOT_IMPLEMENTED; + return Status; + } + + /* Check oplock state */ + Status = FsRtlCheckOplock(&Fcb->Fcb.Oplock, + Irp, + IrpContext, + FatOplockComplete, + NULL); + + if (Status != STATUS_SUCCESS) + { + /* Release FCB lock */ + FatReleaseFcb(IrpContext, Fcb); + + return Status; + } + + /* Process the lock */ + Status = FsRtlProcessFileLock(&Fcb->Fcb.Lock, Irp, NULL); + + /* Update Fast I/O state */ + Fcb->Header.IsFastIoPossible = FatIsFastIoPossible(Fcb); + + /* Complete the request */ + FatCompleteRequest(IrpContext, NULL, 0); + + /* Release FCB lock */ + FatReleaseFcb(IrpContext, Fcb); + + return Status; +} + +NTSTATUS +NTAPI FatLockControl(PDEVICE_OBJECT DeviceObject, PIRP Irp) { + PFAT_IRP_CONTEXT IrpContext; + NTSTATUS Status; + BOOLEAN TopLevel; + DPRINT1("FatLockControl()\n"); - return STATUS_NOT_IMPLEMENTED; + + /* Enter FsRtl critical region */ + FsRtlEnterFileSystem(); + + /* Set Top Level IRP if not set */ + TopLevel = FatIsTopLevelIrp(Irp); + + /* Build an irp context */ + IrpContext = FatBuildIrpContext(Irp, IoIsOperationSynchronous(Irp)); + + /* Call internal function */ + Status = FatiLockControl(IrpContext, Irp); + + /* Reset Top Level IRP */ + if (TopLevel) IoSetTopLevelIrp(NULL); + + /* Leave FsRtl critical region */ + FsRtlExitFileSystem(); + + return Status; } VOID Modified: trunk/reactos/drivers/filesystems/fastfat_new/volume.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat_new/volume.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat_new/volume.c [iso-8859-1] Wed Aug 11 12:18:24 2010 @@ -81,6 +81,25 @@ Partition->FreeClusterCount, Vcb->Bpb.SectorsPerCluster, Vcb->Bpb.BytesPerSector); return Status; +} + +NTSTATUS +NTAPI +FatiQueryFsDeviceInfo(PVCB Vcb, + PFILE_FS_DEVICE_INFORMATION Buffer, + PLONG Length) +{ + /* Deduct the minimum written length */ + *Length -= sizeof(FILE_FS_DEVICE_INFORMATION); + + /* Zero it */ + RtlZeroMemory(Buffer, sizeof(FILE_FS_DEVICE_INFORMATION)); + + /* Set values */ + Buffer->DeviceType = FILE_DEVICE_DISK; + Buffer->Characteristics = Vcb->TargetDeviceObject->Characteristics; + + return STATUS_SUCCESS; } NTSTATUS @@ -142,8 +161,7 @@ break; case FileFsDeviceInformation: - UNIMPLEMENTED - //Status = FatiQueryFsDeviceInfo(IrpContext, Vcb, Buffer, &Length); + Status = FatiQueryFsDeviceInfo(Vcb, Buffer, &Length); break; case FileFsAttributeInformation:

14 years, 3 months

[tkreuzer] 48517: [NTOSKRNL] Stop using the new paged pool code, before ExpLoadInitialProcess is called. For so far unknown reasons, it causes evil things to happen. Fixes "Assertion NewSize < pool->UserSize failed" See issue #5551 for more details.

by tkreuzer＠svn.reactos.org

Author: tkreuzer Date: Wed Aug 11 01:22:06 2010 New Revision: 48517 URL: http://svn.reactos.org/svn/reactos?rev=48517&view=rev Log: [NTOSKRNL] Stop using the new paged pool code, before ExpLoadInitialProcess is called. For so far unknown reasons, it causes evil things to happen. Fixes "Assertion NewSize < pool->UserSize failed" See issue #5551 for more details. Modified: trunk/reactos/ntoskrnl/ex/init.c Modified: trunk/reactos/ntoskrnl/ex/init.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/init.c?rev=485… ============================================================================== --- trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/init.c [iso-8859-1] Wed Aug 11 01:22:06 2010 @@ -1851,6 +1851,9 @@ /* Update progress bar */ InbvUpdateProgressBar(90); + /* Enough fun for now */ + AllowPagedPool = FALSE; + /* Launch initial process */ ProcessInfo = &InitBuffer->ProcessInfo; ExpLoadInitialProcess(InitBuffer, &ProcessParameters, &Environment); @@ -1860,9 +1863,6 @@ /* Allow strings to be displayed */ InbvEnableDisplayString(TRUE); - - /* Enough fun for now */ - AllowPagedPool = FALSE; /* Wait 5 seconds for it to initialize */ Timeout.QuadPart = Int32x32To64(5, -10000000);

14 years, 3 months

[cgutman] 48516: [MSWSOCK] - Fix another typo that broke async select (we passed the thread context to the completion function instead of the completion context)

by cgutman＠svn.reactos.org

Author: cgutman Date: Tue Aug 10 22:23:51 2010 New Revision: 48516 URL: http://svn.reactos.org/svn/reactos?rev=48516&view=rev Log: [MSWSOCK] - Fix another typo that broke async select (we passed the thread context to the completion function instead of the completion context) Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-branch/dll/win32/… ============================================================================== --- branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c [iso-8859-1] (original) +++ branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c [iso-8859-1] Tue Aug 10 22:23:51 2010 @@ -170,7 +170,7 @@ { /* Call the routine */ SockHandleAsyncIndication(AsyncCompletionRoutine, - Context, + AsyncContext, &IoStatusBlock); } else

14 years, 3 months

[cgutman] 48515: [MSWSOCK] - Pass the correct NumberOfConcurrentThreads parameter to NtCreateIoCompletion

by cgutman＠svn.reactos.org

Author: cgutman Date: Tue Aug 10 21:42:12 2010 New Revision: 48515 URL: http://svn.reactos.org/svn/reactos?rev=48515&view=rev Log: [MSWSOCK] - Pass the correct NumberOfConcurrentThreads parameter to NtCreateIoCompletion Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-branch/dll/win32/… ============================================================================== --- branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c [iso-8859-1] (original) +++ branches/aicom-network-branch/dll/win32/mswsock/msafd/async.c [iso-8859-1] Tue Aug 10 21:42:12 2010 @@ -26,7 +26,7 @@ Status = NtCreateIoCompletion(&SockAsyncQueuePort, IO_COMPLETION_ALL_ACCESS, NULL, - -1); + 0); /* Protect Handle */ HandleFlags.ProtectFromClose = TRUE;

14 years, 3 months

[akhaldi] 48514: [DDK] - De-duplicate __GNU_EXTENSION. - Apply a consistent formatting.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Tue Aug 10 20:50:55 2010 New Revision: 48514 URL: http://svn.reactos.org/svn/reactos?rev=48514&view=rev Log: [DDK] - De-duplicate __GNU_EXTENSION. - Apply a consistent formatting. Modified: trunk/reactos/include/ddk/d3dhal.h trunk/reactos/include/ddk/dmusicks.h trunk/reactos/include/ddk/drivinit.h trunk/reactos/include/ddk/drmk.h trunk/reactos/include/ddk/hubbusif.h trunk/reactos/include/ddk/ide.h trunk/reactos/include/ddk/mcd.h trunk/reactos/include/ddk/miniport.h trunk/reactos/include/ddk/minitape.h trunk/reactos/include/ddk/mountmgr.h trunk/reactos/include/ddk/ndis.h trunk/reactos/include/ddk/ndistapi.h trunk/reactos/include/ddk/ntddsnd.h trunk/reactos/include/ddk/ntimage.h trunk/reactos/include/ddk/ntnls.h trunk/reactos/include/ddk/ntpoapi.h trunk/reactos/include/ddk/ntstrsafe.h trunk/reactos/include/ddk/portcls.h trunk/reactos/include/ddk/punknown.h trunk/reactos/include/ddk/smbus.h trunk/reactos/include/ddk/stdunk.h trunk/reactos/include/ddk/storport.h trunk/reactos/include/ddk/strmini.h trunk/reactos/include/ddk/swenum.h trunk/reactos/include/ddk/tdikrnl.h trunk/reactos/include/ddk/tdistat.h trunk/reactos/include/ddk/upssvc.h trunk/reactos/include/ddk/usbbusif.h trunk/reactos/include/ddk/usbdlib.h trunk/reactos/include/ddk/usbprotocoldefs.h trunk/reactos/include/ddk/wmilib.h [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/include/ddk/d3dhal.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/d3dhal.h?rev=4… Modified: trunk/reactos/include/ddk/dmusicks.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/dmusicks.h?rev… Modified: trunk/reactos/include/ddk/drivinit.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/drivinit.h?rev… Modified: trunk/reactos/include/ddk/drmk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/drmk.h?rev=485… Modified: trunk/reactos/include/ddk/hubbusif.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/hubbusif.h?rev… Modified: trunk/reactos/include/ddk/ide.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ide.h?rev=4851… Modified: trunk/reactos/include/ddk/mcd.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/mcd.h?rev=4851… Modified: trunk/reactos/include/ddk/miniport.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/miniport.h?rev… Modified: trunk/reactos/include/ddk/minitape.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/minitape.h?rev… Modified: trunk/reactos/include/ddk/mountmgr.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/mountmgr.h?rev… Modified: trunk/reactos/include/ddk/ndis.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ndis.h?rev=485… Modified: trunk/reactos/include/ddk/ndistapi.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ndistapi.h?rev… Modified: trunk/reactos/include/ddk/ntddsnd.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntddsnd.h?rev=… Modified: trunk/reactos/include/ddk/ntimage.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntimage.h?rev=… Modified: trunk/reactos/include/ddk/ntnls.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntnls.h?rev=48… Modified: trunk/reactos/include/ddk/ntpoapi.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntpoapi.h?rev=… Modified: trunk/reactos/include/ddk/ntstrsafe.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntstrsafe.h?re… Modified: trunk/reactos/include/ddk/portcls.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/portcls.h?rev=… Modified: trunk/reactos/include/ddk/punknown.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/punknown.h?rev… Modified: trunk/reactos/include/ddk/smbus.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/smbus.h?rev=48… Modified: trunk/reactos/include/ddk/stdunk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/stdunk.h?rev=4… Modified: trunk/reactos/include/ddk/storport.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/storport.h?rev… Modified: trunk/reactos/include/ddk/strmini.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/strmini.h?rev=… Modified: trunk/reactos/include/ddk/swenum.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/swenum.h?rev=4… Modified: trunk/reactos/include/ddk/tdikrnl.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/tdikrnl.h?rev=… Modified: trunk/reactos/include/ddk/tdistat.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/tdistat.h?rev=… Modified: trunk/reactos/include/ddk/upssvc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/upssvc.h?rev=4… Modified: trunk/reactos/include/ddk/usbbusif.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/usbbusif.h?rev… Modified: trunk/reactos/include/ddk/usbdlib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/usbdlib.h?rev=… Modified: trunk/reactos/include/ddk/usbprotocoldefs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/usbprotocoldef… Modified: trunk/reactos/include/ddk/wmilib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/wmilib.h?rev=4…

14 years, 3 months

[fireball] 48513: [FASTFAT] Pierre Schweitzer - Fix volume opening on FAT volume. Commented out a directory check as it doesn't match realized tests, in spite of what's in WDK.

by fireball＠svn.reactos.org

Author: fireball Date: Tue Aug 10 20:08:31 2010 New Revision: 48513 URL: http://svn.reactos.org/svn/reactos?rev=48513&view=rev Log: [FASTFAT] Pierre Schweitzer - Fix volume opening on FAT volume. Commented out a directory check as it doesn't match realized tests, in spite of what's in WDK. Modified: trunk/reactos/drivers/filesystems/fastfat/create.c Modified: trunk/reactos/drivers/filesystems/fastfat/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/create.c [iso-8859-1] Tue Aug 10 20:08:31 2010 @@ -466,7 +466,7 @@ /* This a open operation for the volume itself */ if (FileObject->FileName.Length == 0 && - FileObject->RelatedFileObject == NULL) + (FileObject->RelatedFileObject == NULL || FileObject->RelatedFileObject->FsContext2 != NULL)) { if (RequestedDisposition == FILE_CREATE || RequestedDisposition == FILE_OVERWRITE_IF || @@ -474,10 +474,13 @@ { return(STATUS_ACCESS_DENIED); } +#if 0 + /* In spite of what is shown in WDK, it seems that Windows FAT driver doesn't perform that test */ if (RequestedOptions & FILE_DIRECTORY_FILE) { return(STATUS_NOT_A_DIRECTORY); } +#endif pFcb = DeviceExt->VolumeFcb; pCcb = ExAllocateFromNPagedLookasideList(&VfatGlobalData->CcbLookasideList); if (pCcb == NULL)

14 years, 3 months

[cgutman] 48512: [MSWSOCK] - Fix completion port initialization

by cgutman＠svn.reactos.org

Author: cgutman Date: Tue Aug 10 15:59:33 2010 New Revision: 48512 URL: http://svn.reactos.org/svn/reactos?rev=48512&view=rev Log: [MSWSOCK] - Fix completion port initialization Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/select.c Modified: branches/aicom-network-branch/dll/win32/mswsock/msafd/select.c URL: http://svn.reactos.org/svn/reactos/branches/aicom-network-branch/dll/win32/… ============================================================================== --- branches/aicom-network-branch/dll/win32/mswsock/msafd/select.c [iso-8859-1] (original) +++ branches/aicom-network-branch/dll/win32/mswsock/msafd/select.c [iso-8859-1] Tue Aug 10 15:59:33 2010 @@ -75,7 +75,7 @@ } /* Check if the port exists, and if not, create it */ - if (SockAsyncQueuePort) SockCreateAsyncQueuePort(); + if (!SockAsyncQueuePort) SockCreateAsyncQueuePort(); /* * Now Set up the Completion Port Information

14 years, 3 months

← Newer
1
...
13
14
15
16
17
18
19
...
29
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2010