Ros-diffs November 2011

ros-diffs@reactos.org

16 participants
274 discussions

[jgardou] 54444: [NTOSKRNL] - add some debug prints
by jgardou＠svn.reactos.org 19 Nov '11

19 Nov '11

Author: jgardou Date: Sat Nov 19 17:20:39 2011 New Revision: 54444 URL: http://svn.reactos.org/svn/reactos?rev=54444&view=rev Log: [NTOSKRNL] - add some debug prints Modified: trunk/reactos/ntoskrnl/config/cmapi.c trunk/reactos/ntoskrnl/config/cminit.c Modified: trunk/reactos/ntoskrnl/config/cmapi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmapi.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmapi.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cmapi.c [iso-8859-1] Sat Nov 19 17:20:39 2011 @@ -1787,6 +1787,7 @@ } else { + DPRINT1("CmpLinkHiveToMaster failed, Status %lx\n", Status); /* FIXME: TODO */ ASSERT(FALSE); } Modified: trunk/reactos/ntoskrnl/config/cminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cminit.c?r… ============================================================================== --- trunk/reactos/ntoskrnl/config/cminit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cminit.c [iso-8859-1] Sat Nov 19 17:20:39 2011 @@ -343,7 +343,19 @@ FILE_SYNCHRONOUS_IO_NONALERT | IoFlags, NULL, 0); - if ((NT_SUCCESS(Status)) && (MarkAsSystemHive)) + /* Check if anything failed until now */ + if (!NT_SUCCESS(Status)) + { + /* Close handles and free buffers */ + if (NameBuffer) ExFreePool(NameBuffer); + ObDereferenceObject(Event); + ZwClose(EventHandle); + DPRINT1("ZwCreateFile failed : %lx.\n", Status); + *Primary = NULL; + return Status; + } + + if (MarkAsSystemHive) { /* We opened it, mark it as a system hive */ Status = ZwFsControlFile(*Primary, @@ -370,18 +382,16 @@ /* If we don't support it, ignore the failure */ if (Status == STATUS_INVALID_DEVICE_REQUEST) Status = STATUS_SUCCESS; - /* If we failed, close the handle */ - if (!NT_SUCCESS(Status)) ZwClose(*Primary); - } - - /* Check if anything failed until now */ - if (!NT_SUCCESS(Status)) - { - /* Close handles and free buffers */ - if (NameBuffer) ExFreePool(NameBuffer); - ObDereferenceObject(Event); - ZwClose(EventHandle); - return Status; + if (!NT_SUCCESS(Status)) + { + /* Close handles and free buffers */ + if (NameBuffer) ExFreePool(NameBuffer); + ObDereferenceObject(Event); + ZwClose(EventHandle); + ZwClose(*Primary); + *Primary = NULL; + return Status; + } } /* Disable compression */

1 0

[rharabien] 54443: [INF] - Don't place Polish translation in German section
by rharabien＠svn.reactos.org 19 Nov '11

19 Nov '11

Author: rharabien Date: Sat Nov 19 17:03:00 2011 New Revision: 54443 URL: http://svn.reactos.org/svn/reactos?rev=54443&view=rev Log: [INF] - Don't place Polish translation in German section Modified: trunk/reactos/media/inf/hdc.inf Modified: trunk/reactos/media/inf/hdc.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/media/inf/hdc.inf?rev=5444… ============================================================================== Binary files - no diff available.

1 0

[jgardou] 54442: [WINDEF.H] - you never use enough brackets
by jgardou＠svn.reactos.org 19 Nov '11

19 Nov '11

Author: jgardou Date: Sat Nov 19 16:13:31 2011 New Revision: 54442 URL: http://svn.reactos.org/svn/reactos?rev=54442&view=rev Log: [WINDEF.H] - you never use enough brackets Modified: trunk/reactos/include/psdk/windef.h Modified: trunk/reactos/include/psdk/windef.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/windef.h?rev=… ============================================================================== --- trunk/reactos/include/psdk/windef.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/windef.h [iso-8859-1] Sat Nov 19 16:13:31 2011 @@ -246,8 +246,8 @@ #endif #endif -#define MAKEWORD(a,b) ((WORD)(((BYTE)((DWORD_PTR)(a) & 0xff)) | ((WORD)((BYTE)((DWORD_PTR)(b) & 0xff))) << 8)) -#define MAKELONG(a,b) ((LONG)(((WORD)((DWORD_PTR)(a) & 0xffff)) | ((DWORD)((WORD)((DWORD_PTR)(b) & 0xffff))) << 16)) +#define MAKEWORD(a,b) ((WORD)(((BYTE)((DWORD_PTR)(a) & 0xff)) | (((WORD)((BYTE)((DWORD_PTR)(b) & 0xff))) << 8))) +#define MAKELONG(a,b) ((LONG)(((WORD)((DWORD_PTR)(a) & 0xffff)) | (((DWORD)((WORD)((DWORD_PTR)(b) & 0xffff))) << 16))) #define LOWORD(l) ((WORD)((DWORD_PTR)(l) & 0xffff)) #define HIWORD(l) ((WORD)((DWORD_PTR)(l) >> 16)) #define LOBYTE(w) ((BYTE)((DWORD_PTR)(w) & 0xff))

1 0

[jgardou] 54441: [NTOSKRNL] - add (yet another) sanity ASSERT
by jgardou＠svn.reactos.org 19 Nov '11

19 Nov '11

Author: jgardou Date: Sat Nov 19 16:08:26 2011 New Revision: 54441 URL: http://svn.reactos.org/svn/reactos?rev=54441&view=rev Log: [NTOSKRNL] - add (yet another) sanity ASSERT Modified: trunk/reactos/ntoskrnl/mm/section.c Modified: trunk/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] Sat Nov 19 16:08:26 2011 @@ -2554,6 +2554,7 @@ PEPROCESS Process = MmGetAddressSpaceOwner(AddressSpace); MemoryArea = MmLocateMemoryAreaByAddress(AddressSpace, BaseAddress); + ASSERT(MemoryArea); Segment = MemoryArea->Data.SectionData.Segment; if ((Segment->WriteCopy) &&

1 0

[pschweitzer] 54440: [CRT] Reimplemented _scalb properly. This fixes 19 tests.
by pschweitzer＠svn.reactos.org 19 Nov '11

19 Nov '11

Author: pschweitzer Date: Sat Nov 19 15:51:45 2011 New Revision: 54440 URL: http://svn.reactos.org/svn/reactos?rev=54440&view=rev Log: [CRT] Reimplemented _scalb properly. This fixes 19 tests. Modified: trunk/reactos/lib/sdk/crt/float/scalb.c Modified: trunk/reactos/lib/sdk/crt/float/scalb.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/float/scalb.c?… ============================================================================== --- trunk/reactos/lib/sdk/crt/float/scalb.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/float/scalb.c [iso-8859-1] Sat Nov 19 15:51:45 2011 @@ -1,30 +1,17 @@ /* * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS system libraries - * FILE: lib/crt/?????? - * PURPOSE: Unknown - * PROGRAMER: Unknown - * UPDATE HISTORY: - * 25/11/05: Added license header + * FILE: lib/sdk/crt/float/scalb.c + * PURPOSE: Floating-point number scaling + * PROGRAMER: Pierre Schweitzer (pierre(a)reactos.org) */ #include <precomp.h> -#include <internal/ieee.h> /* * @implemented */ -double _scalb( double __x, long e ) +double _scalb(double x, long exp) { - union - { - double* __x; - double_s* x; - } x; - - x.__x = &__x; - - x.x->exponent += e; - - return __x; + return ldexp(x, exp); }

1 0

[jgardou] 54439: |NTOSKRNL] - fix operands precedence
by jgardou＠svn.reactos.org 19 Nov '11

19 Nov '11

Author: jgardou Date: Sat Nov 19 15:50:53 2011 New Revision: 54439 URL: http://svn.reactos.org/svn/reactos?rev=54439&view=rev Log: |NTOSKRNL] - fix operands precedence Modified: trunk/reactos/ntoskrnl/config/cminit.c Modified: trunk/reactos/ntoskrnl/config/cminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cminit.c?r… ============================================================================== --- trunk/reactos/ntoskrnl/config/cminit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cminit.c [iso-8859-1] Sat Nov 19 15:50:53 2011 @@ -312,7 +312,7 @@ IoFlags = FILE_OPEN_FOR_BACKUP_INTENT | FILE_NO_COMPRESSION | FILE_RANDOM_ACCESS | - (NoBuffering) ? FILE_NO_INTERMEDIATE_BUFFERING : 0; + (NoBuffering ? FILE_NO_INTERMEDIATE_BUFFERING : 0); /* Set share and access modes */ if ((CmpMiniNTBoot) && (CmpShareSystemHives))

1 0

[jgardou] 54438: [NTOSKRNL] - do not compare (x & y) with TRUE
by jgardou＠svn.reactos.org 19 Nov '11

19 Nov '11

Author: jgardou Date: Sat Nov 19 15:45:20 2011 New Revision: 54438 URL: http://svn.reactos.org/svn/reactos?rev=54438&view=rev Log: [NTOSKRNL] - do not compare (x & y) with TRUE Modified: trunk/reactos/ntoskrnl/fsrtl/fastio.c Modified: trunk/reactos/ntoskrnl/fsrtl/fastio.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/fastio.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/fsrtl/fastio.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/fsrtl/fastio.c [iso-8859-1] Sat Nov 19 15:45:20 2011 @@ -308,7 +308,7 @@ */ if ((CcCanIWrite(FileObject, Length, Wait, FALSE) == FALSE) || (CcCopyWriteWontFlush(FileObject, FileOffset, Length) == FALSE) || - ((FileObject->Flags & FO_WRITE_THROUGH) == TRUE)) + ((FileObject->Flags & FO_WRITE_THROUGH))) { return FALSE; }

1 0

[pschweitzer] 54437: [MSVCRT_APITEST] Add more tests
by pschweitzer＠svn.reactos.org 19 Nov '11

19 Nov '11

Author: pschweitzer Date: Sat Nov 19 15:05:26 2011 New Revision: 54437 URL: http://svn.reactos.org/svn/reactos?rev=54437&view=rev Log: [MSVCRT_APITEST] Add more tests Modified: trunk/rostests/apitests/msvcrt/ieee.c Modified: trunk/rostests/apitests/msvcrt/ieee.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/msvcrt/ieee.c?re… ============================================================================== --- trunk/rostests/apitests/msvcrt/ieee.c [iso-8859-1] (original) +++ trunk/rostests/apitests/msvcrt/ieee.c [iso-8859-1] Sat Nov 19 15:05:26 2011 @@ -199,9 +199,146 @@ ok(_isnan(tested.d) == TRUE, "_isnan = FALSE\n"); } +void test_scalb(void) +{ + ieee_double tested; + ieee_double expected; + ieee_double result; + + expected.l = 0; + + errno = 0xDEADBEEF; + tested.l = 0xFFFFFFFFFFFFFFFFLL; + expected.l = 0xFFFFFFFFFFFFFFFFLL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == EDOM, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0xFFF8000000000001LL; + expected.l = 0xFFF8000000000001LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == EDOM, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0xFFF8000000000000LL; + expected.l = 0xFFF8000000000000LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == EDOM, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0xFFF7FFFFFFFFFFFFLL; + expected.l = 0xFFFFFFFFFFFFFFFFLL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == EDOM, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0xFFF0000000000001LL; + expected.l = 0xFFF8000000000001LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == EDOM, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0xFFF0000000000000LL; + expected.l = 0xFFF0000000000000LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == 0xDEADBEEF, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0xFFEFFFFFFFFFFFFFLL; + expected.l = 0xFFF0000000000000LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == ERANGE, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x8010000000000000LL; + expected.l = 0x8040000000000000LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == 0xDEADBEEF, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x800FFFFFFFFFFFFFLL; + expected.l = 0x803FFFFFFFFFFFFELL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == 0xDEADBEEF, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x8000000000000001LL; + expected.l = 0x8000000000000008LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == 0xDEADBEEF, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x8000000000000000LL; + expected.l = 0x8000000000000000LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == 0xDEADBEEF, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x0000000000000000LL; + expected.l = 0x0000000000000000LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == 0xDEADBEEF, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x0000000000000001LL; + expected.l = 0x0000000000000008LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == 0xDEADBEEF, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x000FFFFFFFFFFFFFLL; + expected.l = 0x003FFFFFFFFFFFFELL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == 0xDEADBEEF, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x0010000000000000LL; + expected.l = 0x0040000000000000LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == 0xDEADBEEF, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x7FEFFFFFFFFFFFFFLL; + expected.l = 0x7FF0000000000000LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == ERANGE, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x7FF0000000000000LL; + expected.l = 0x7FF0000000000000LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == 0xDEADBEEF, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x7FF0000000000001LL; + expected.l = 0x7FF8000000000001LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == EDOM, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x7FF7FFFFFFFFFFFFLL; + expected.l = 0x7FFFFFFFFFFFFFFFLL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == EDOM, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x7FF8000000000000LL; + expected.l = 0x7FF8000000000000LL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == EDOM, "errno: %d\n", errno); + errno = 0xDEADBEEF; + tested.l = 0x7FFFFFFFFFFFFFFFLL; + expected.l = 0x7FFFFFFFFFFFFFFFLL; + result.d = _scalb(tested.d, 3); + ok(result.l == expected.l, "_scalb returned: %I64x\n", result.l); + ok(errno == EDOM, "errno: %d\n", errno); +} + START_TEST(ieee) { test_finite(); test_fpclass(); test_isnan(); -} + test_scalb(); +}

1 0

[akhaldi] 54436: [NTOSKRNL] * Fix a typo.
by akhaldi＠svn.reactos.org 19 Nov '11

19 Nov '11

Author: akhaldi Date: Sat Nov 19 14:18:23 2011 New Revision: 54436 URL: http://svn.reactos.org/svn/reactos?rev=54436&view=rev Log: [NTOSKRNL] * Fix a typo. Modified: trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c Modified: trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c [iso-8859-1] Sat Nov 19 14:18:23 2011 @@ -1208,7 +1208,7 @@ Loaded = TRUE; /* Sanity check */ - ASSERT(DllBase = DllEntry->DllBase); + ASSERT(DllBase == DllEntry->DllBase); /* Call the initialization routines */ Status = MmCallDllInitialize(DllEntry, &PsLoadedModuleList);

1 0

[pschweitzer] 54435: [CRT] Reimplemented _fpclass properly. This fixes all failing _fpclass tests. See: http://babbage.cs.qc.cuny.edu/IEEE-754/References.xhtml Based on OpenAD implementation
by pschweitzer＠svn.reactos.org 19 Nov '11

19 Nov '11

Author: pschweitzer Date: Sat Nov 19 13:03:17 2011 New Revision: 54435 URL: http://svn.reactos.org/svn/reactos?rev=54435&view=rev Log: [CRT] Reimplemented _fpclass properly. This fixes all failing _fpclass tests. See: http://babbage.cs.qc.cuny.edu/IEEE-754/References.xhtml Based on OpenAD implementation Modified: trunk/reactos/lib/sdk/crt/float/fpclass.c Modified: trunk/reactos/lib/sdk/crt/float/fpclass.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/float/fpclass.… ============================================================================== --- trunk/reactos/lib/sdk/crt/float/fpclass.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/float/fpclass.c [iso-8859-1] Sat Nov 19 13:03:17 2011 @@ -3,9 +3,8 @@ * PROJECT: ReactOS system libraries * FILE: lib/sdk/crt/float/fpclass.c * PURPOSE: Floating-point classes - * PROGRAMER: Unknown - * UPDATE HISTORY: - * 25/11/05: Added license header + * PROGRAMER: Pierre Schweitzer (pierre(a)reactos.org) + * REFERENCE: http://babbage.cs.qc.cuny.edu/IEEE-754/References.xhtml */ #include <precomp.h> @@ -24,29 +23,36 @@ } d; d.__d = &__d; - if ( d.d->exponent == 0 ) { - if ( d.d->mantissah == 0 && d.d->mantissal == 0 ) { - if ( d.d->sign == 0 ) - return _FPCLASS_PZ; - else - return _FPCLASS_NZ; - } else { - if ( d.d->sign == 0 ) - return _FPCLASS_PD; - else - return _FPCLASS_ND; - } - } - else if (d.d->exponent == 0x7ff ) { - if ( d.d->mantissah == 0 && d.d->mantissal == 0 ) { - if ( d.d->sign == 0 ) - return _FPCLASS_PINF; - else - return _FPCLASS_NINF; - } - else if ( (d.d->mantissah & 0x80000) != 0 ) { - return _FPCLASS_QNAN; - } - } - return _FPCLASS_QNAN; + + /* With 0x7ff, it can only be infinity or NaN */ + if (d.d->exponent == 0x7ff) + { + if (d.d->mantissah == 0 && d.d->mantissal == 0) + { + return (d.d->sign == 0) ? _FPCLASS_PINF : _FPCLASS_NINF; + } + /* Windows will never return Signaling NaN */ + else + { + return _FPCLASS_QNAN; + } + } + + /* With 0, it can only be zero or denormalized number */ + if (d.d->exponent == 0) + { + if (d.d->mantissah == 0 && d.d->mantissal == 0) + { + return (d.d->sign == 0) ? _FPCLASS_PZ : _FPCLASS_NZ; + } + else + { + return (d.d->sign == 0) ? _FPCLASS_PD : _FPCLASS_ND; + } + } + /* Only remain normalized numbers */ + else + { + return (d.d->sign == 0) ? _FPCLASS_PN : _FPCLASS_NN; + } }

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs November 2011