Ros-diffs November 2011

ros-diffs@reactos.org

16 participants
274 discussions

[cgutman] 54394: [NTOSKRNL] - Fix another case where we fail to detach from a process before failing
by cgutman＠svn.reactos.org 16 Nov '11

16 Nov '11

Author: cgutman Date: Wed Nov 16 00:11:10 2011 New Revision: 54394 URL: http://svn.reactos.org/svn/reactos?rev=54394&view=rev Log: [NTOSKRNL] - Fix another case where we fail to detach from a process before failing Modified: trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c Modified: trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c [iso-8859-1] Wed Nov 16 00:11:10 2011 @@ -158,7 +158,12 @@ /* Reserve system PTEs needed */ PteCount = ROUND_TO_PAGES(Section->ImageSection->ImageSize) >> PAGE_SHIFT; PointerPte = MiReserveSystemPtes(PteCount, SystemPteSpace); - if (!PointerPte) return STATUS_INSUFFICIENT_RESOURCES; + if (!PointerPte) + { + DPRINT1("MiReserveSystemPtes failed\n"); + KeUnstackDetachProcess(&ApcState); + return STATUS_INSUFFICIENT_RESOURCES; + } /* New driver base */ LastPte = PointerPte + PteCount;

1 0

[jgardou] 54393: [NTOSKRNL/MM] - Fix bad comparison
by jgardou＠svn.reactos.org 15 Nov '11

15 Nov '11

Author: jgardou Date: Tue Nov 15 23:55:38 2011 New Revision: 54393 URL: http://svn.reactos.org/svn/reactos?rev=54393&view=rev Log: [NTOSKRNL/MM] - Fix bad comparison Modified: trunk/reactos/ntoskrnl/mm/i386/page.c Modified: trunk/reactos/ntoskrnl/mm/i386/page.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/i386/page.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] Tue Nov 15 23:55:38 2011 @@ -803,7 +803,7 @@ /* flush if currently mapped, just continue editing if hyperspace * NOTE : Do not call MiFlushTlb, as it will unmap the page table, * and we might need it afterwards */ - if (Address > MmSystemRangeStart || + if (Address >= MmSystemRangeStart || (Pt >= (PULONG)PAGETABLE_MAP && Pt < (PULONG)PAGETABLE_MAP + 1024*1024)) { KeInvalidateTlbEntry(Addr);

1 0

[jgardou] 54392: [NTOSKRNL/MM] - Some more cleanup. - Work with page rounded down addresses in SectionView page faults. - You should not create a virtual mapping on a non page-aligned address range...
by jgardou＠svn.reactos.org 15 Nov '11

15 Nov '11

Author: jgardou Date: Tue Nov 15 23:50:04 2011 New Revision: 54392 URL: http://svn.reactos.org/svn/reactos?rev=54392&view=rev Log: [NTOSKRNL/MM] - Some more cleanup. - Work with page rounded down addresses in SectionView page faults. - You should not create a virtual mapping on a non page-aligned address range : ASSERT about that. - Flush Tlb each time we change it - Fix logic I broke in MmCreateVirtualMapping (thanks to Thomas Faber) Modified: trunk/reactos/ntoskrnl/mm/i386/page.c trunk/reactos/ntoskrnl/mm/section.c Modified: trunk/reactos/ntoskrnl/mm/i386/page.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/i386/page.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] Tue Nov 15 23:50:04 2011 @@ -284,37 +284,34 @@ PageDir = (PULONG)MiAddressToPde(Address); if (0 == InterlockedCompareExchangePte(PageDir, 0, 0)) { - if (Address >= MmSystemRangeStart) - { - if (0 == InterlockedCompareExchangePte(&MmGlobalKernelPageDirectory[PdeOffset], 0, 0)) - { - if (Create == FALSE) - { - return NULL; - } - MI_SET_USAGE(MI_USAGE_LEGACY_PAGE_DIRECTORY); - if (Process) MI_SET_PROCESS2(Process->ImageFileName); - if (!Process) MI_SET_PROCESS2("Kernel Legacy"); - Status = MmRequestPageMemoryConsumer(MC_SYSTEM, FALSE, &Pfn); - if (!NT_SUCCESS(Status) || Pfn == 0) - { - KeBugCheck(MEMORY_MANAGEMENT); - } - Entry = PFN_TO_PTE(Pfn) | PA_PRESENT | PA_READWRITE; - if(0 != InterlockedCompareExchangePte(&MmGlobalKernelPageDirectory[PdeOffset], Entry, 0)) - { - MmReleasePageMemoryConsumer(MC_SYSTEM, Pfn); - } - InterlockedExchangePte(PageDir, MmGlobalKernelPageDirectory[PdeOffset]); - RtlZeroMemory(MiPteToAddress(PageDir), PAGE_SIZE); - return (PULONG)MiAddressToPte(Address); + if (0 == InterlockedCompareExchangePte(&MmGlobalKernelPageDirectory[PdeOffset], 0, 0)) + { + if (Create == FALSE) + { + return NULL; + } + MI_SET_USAGE(MI_USAGE_LEGACY_PAGE_DIRECTORY); + if (Process) MI_SET_PROCESS2(Process->ImageFileName); + if (!Process) MI_SET_PROCESS2("Kernel Legacy"); + Status = MmRequestPageMemoryConsumer(MC_SYSTEM, FALSE, &Pfn); + if (!NT_SUCCESS(Status) || Pfn == 0) + { + KeBugCheck(MEMORY_MANAGEMENT); + } + Entry = PFN_TO_PTE(Pfn) | PA_PRESENT | PA_READWRITE; + if(0 != InterlockedCompareExchangePte(&MmGlobalKernelPageDirectory[PdeOffset], Entry, 0)) + { + MmReleasePageMemoryConsumer(MC_SYSTEM, Pfn); } InterlockedExchangePte(PageDir, MmGlobalKernelPageDirectory[PdeOffset]); - } - else - { - - } + /* Flush it before accessing it */ + KeInvalidateTlbEntry(MiPteToAddress(PageDir)); + RtlZeroMemory(MiPteToAddress(PageDir), PAGE_SIZE); + return (PULONG)MiAddressToPte(Address); + } + InterlockedExchangePte(PageDir, MmGlobalKernelPageDirectory[PdeOffset]); + /* Flush it before accessing it */ + KeInvalidateTlbEntry(MiPteToAddress(PageDir)); } return (PULONG)MiAddressToPte(Address); } @@ -700,15 +697,8 @@ } Pte = *Pt; InterlockedExchangePte(Pt, SwapEntry << 1); - if (Pte != 0) - { - MiFlushTlb(Pt, Address); - } - else - { - MmUnmapPageTable(Pt); - } - + MiFlushTlb(Pt, Address); + return(STATUS_SUCCESS); } @@ -729,6 +719,8 @@ ULONG Pte; DPRINT("MmCreateVirtualMappingUnsafe(%x, %x, %x, %x (%x), %d)\n", Process, Address, flProtect, Pages, *Pages, PageCount); + + ASSERT(((ULONG_PTR)Address % PAGE_SIZE) == 0); if (Process == NULL) { @@ -772,6 +764,8 @@ } Addr = Address; + /* MmGetPageTableForProcess should be called on the first run, so + * let this trigger it */ oldPdeOffset = ADDR_TO_PDE_OFFSET(Addr) + 1; for (i = 0; i < PageCount; i++, Addr = (PVOID)((ULONG_PTR)Addr + PAGE_SIZE)) { @@ -785,6 +779,7 @@ PdeOffset = ADDR_TO_PDE_OFFSET(Addr); if (oldPdeOffset != PdeOffset) { + if(Pt) MmUnmapPageTable(Pt); Pt = MmGetPageTableForProcess(Process, Addr, TRUE); if (Pt == NULL) { @@ -805,8 +800,18 @@ KeBugCheck(MEMORY_MANAGEMENT); } InterlockedExchangePte(Pt, PFN_TO_PTE(Pages[i]) | Attributes); - MiFlushTlb(Pt, Addr); - } + /* flush if currently mapped, just continue editing if hyperspace + * NOTE : Do not call MiFlushTlb, as it will unmap the page table, + * and we might need it afterwards */ + if (Address > MmSystemRangeStart || + (Pt >= (PULONG)PAGETABLE_MAP && Pt < (PULONG)PAGETABLE_MAP + 1024*1024)) + { + KeInvalidateTlbEntry(Addr); + } + } + + ASSERT(Addr > Address); + MmUnmapPageTable(Pt); return(STATUS_SUCCESS); } Modified: trunk/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] Tue Nov 15 23:50:04 2011 @@ -1314,7 +1314,6 @@ ULONG Offset; PFN_NUMBER Page; NTSTATUS Status; - PVOID PAddress; PROS_SECTION_OBJECT Section; PMM_SECTION_SEGMENT Segment; ULONG_PTR Entry; @@ -1343,8 +1342,8 @@ return(STATUS_UNSUCCESSFUL); } - PAddress = MM_ROUND_DOWN(Address, PAGE_SIZE); - Offset = (ULONG)((ULONG_PTR)PAddress - (ULONG_PTR)MemoryArea->StartingAddress + Address = MM_ROUND_DOWN(Address, PAGE_SIZE); + Offset = (ULONG)((ULONG_PTR)Address - (ULONG_PTR)MemoryArea->StartingAddress + MemoryArea->Data.SectionData.ViewOffset); Segment = MemoryArea->Data.SectionData.Segment; @@ -1432,7 +1431,7 @@ if (!MmIsPagePresent(Process, Address)) { Entry = MmGetPageEntrySectionSegment(Segment, Offset); - HasSwapEntry = MmIsPageSwapEntry(Process, (PVOID)PAddress); + HasSwapEntry = MmIsPageSwapEntry(Process, (PVOID)Address); if (PAGE_FROM_SSE(Entry) == 0 || HasSwapEntry) { @@ -1461,7 +1460,7 @@ DPRINT1("Unable to create virtual mapping\n"); KeBugCheck(MEMORY_MANAGEMENT); } - MmInsertRmap(Page, Process, (PVOID)PAddress); + MmInsertRmap(Page, Process, Address); } MmUnlockSectionSegment(Segment); PageOp->Status = STATUS_SUCCESS; @@ -1470,7 +1469,7 @@ return(STATUS_SUCCESS); } - HasSwapEntry = MmIsPageSwapEntry(Process, (PVOID)PAddress); + HasSwapEntry = MmIsPageSwapEntry(Process, Address); if (HasSwapEntry) { /* @@ -1488,7 +1487,7 @@ } MmUnlockSectionSegment(Segment); - MmDeletePageFileMapping(Process, (PVOID)PAddress, &SwapEntry); + MmDeletePageFileMapping(Process, Address, &SwapEntry); MmUnlockAddressSpace(AddressSpace); MI_SET_USAGE(MI_USAGE_SECTION); @@ -1527,8 +1526,7 @@ /* * Add the page to the process's working set */ - MmInsertRmap(Page, Process, (PVOID)PAddress); - + MmInsertRmap(Page, Process, Address); /* * Finish the operation */ @@ -1600,7 +1598,7 @@ KeBugCheck(MEMORY_MANAGEMENT); return(Status); } - MmInsertRmap(Page, Process, (PVOID)PAddress); + MmInsertRmap(Page, Process, Address); /* * Cleanup and release locks @@ -1699,7 +1697,7 @@ DPRINT1("Unable to create virtual mapping\n"); KeBugCheck(MEMORY_MANAGEMENT); } - MmInsertRmap(Page, Process, (PVOID)PAddress); + MmInsertRmap(Page, Process, Address); PageOp->Status = STATUS_SUCCESS; MmspCompleteAndReleasePageOp(PageOp); @@ -1772,7 +1770,7 @@ DPRINT1("Unable to create virtual mapping\n"); KeBugCheck(MEMORY_MANAGEMENT); } - MmInsertRmap(Page, Process, (PVOID)PAddress); + MmInsertRmap(Page, Process, Address); PageOp->Status = STATUS_SUCCESS; MmspCompleteAndReleasePageOp(PageOp); DPRINT("Address 0x%.8X\n", Address); @@ -1800,7 +1798,7 @@ DPRINT1("Unable to create virtual mapping\n"); KeBugCheck(MEMORY_MANAGEMENT); } - MmInsertRmap(Page, Process, (PVOID)PAddress); + MmInsertRmap(Page, Process, Address); PageOp->Status = STATUS_SUCCESS; MmspCompleteAndReleasePageOp(PageOp); DPRINT("Address 0x%.8X\n", Address); @@ -1819,7 +1817,6 @@ PFN_NUMBER OldPage; PFN_NUMBER NewPage; NTSTATUS Status; - PVOID PAddress; ULONG Offset; PMM_PAGEOP PageOp; PMM_REGION Region; @@ -1840,8 +1837,8 @@ /* * Find the offset of the page */ - PAddress = MM_ROUND_DOWN(Address, PAGE_SIZE); - Offset = (ULONG)((ULONG_PTR)PAddress - (ULONG_PTR)MemoryArea->StartingAddress + Address = MM_ROUND_DOWN(Address, PAGE_SIZE); + Offset = (ULONG)((ULONG_PTR)Address - (ULONG_PTR)MemoryArea->StartingAddress + MemoryArea->Data.SectionData.ViewOffset); Segment = MemoryArea->Data.SectionData.Segment; @@ -1874,7 +1871,7 @@ PFN_FROM_SSE(Entry) != OldPage) { /* This is a private page. We must only change the page protection. */ - MmSetPageProtect(Process, PAddress, Region->Protect); + MmSetPageProtect(Process, Address, Region->Protect); return(STATUS_SUCCESS); } @@ -1938,7 +1935,7 @@ /* * Copy the old page */ - MiCopyFromUserPage(NewPage, PAddress); + MiCopyFromUserPage(NewPage, Address); MmLockAddressSpace(AddressSpace); /* @@ -1969,8 +1966,8 @@ /* * Unshare the old page. */ - MmDeleteRmap(OldPage, Process, PAddress); - MmInsertRmap(NewPage, Process, PAddress); + MmDeleteRmap(OldPage, Process, Address); + MmInsertRmap(NewPage, Process, Address); MmLockSectionSegment(Segment); MmUnsharePageEntrySectionSegment(Section, Segment, Offset, FALSE, FALSE); MmUnlockSectionSegment(Segment);

1 0

[jgardou] 54391: [NTOSKRNL] - Cleanup a bit, sorry.
by jgardou＠svn.reactos.org 15 Nov '11

15 Nov '11

Author: jgardou Date: Tue Nov 15 22:40:20 2011 New Revision: 54391 URL: http://svn.reactos.org/svn/reactos?rev=54391&view=rev Log: [NTOSKRNL] - Cleanup a bit, sorry. Modified: trunk/reactos/ntoskrnl/mm/i386/page.c Modified: trunk/reactos/ntoskrnl/mm/i386/page.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/i386/page.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] Tue Nov 15 22:40:20 2011 @@ -253,7 +253,6 @@ { KeBugCheck(MEMORY_MANAGEMENT); } - DPRINT1("Pt : %p, *pt %x, ret %p, *ret %x\n", Pt, *Pt, (char*)Pt + ADDR_TO_PTE_OFFSET(Address), *((char*)Pt + ADDR_TO_PTE_OFFSET(Address))); return Pt + MiAddressToPteOffset(Address); } /* This is for our process */ @@ -386,8 +385,6 @@ { Pte = *Pt; } while (Pte != InterlockedCompareExchangePte(Pt, Pte & ~PA_PRESENT, Pte)); - Pte = *Pt; - Pte = InterlockedExchangePte(Pt, Pte & ~((ULONG)PA_PRESENT)); MiFlushTlb(Pt, Address); @@ -788,7 +785,6 @@ PdeOffset = ADDR_TO_PDE_OFFSET(Addr); if (oldPdeOffset != PdeOffset) { - //MmUnmapPageTable(Pt); Pt = MmGetPageTableForProcess(Process, Addr, TRUE); if (Pt == NULL) {

1 0

[jgardou] 54390: [NTOSKRNL/MM] - ensure that all callers of MM providing an user land address also provide a process. - ASSERT about that - Fix broken check
by jgardou＠svn.reactos.org 15 Nov '11

15 Nov '11

Author: jgardou Date: Tue Nov 15 22:34:04 2011 New Revision: 54390 URL: http://svn.reactos.org/svn/reactos?rev=54390&view=rev Log: [NTOSKRNL/MM] - ensure that all callers of MM providing an user land address also provide a process. - ASSERT about that - Fix broken check Modified: trunk/reactos/ntoskrnl/mm/i386/page.c trunk/reactos/ntoskrnl/mm/section.c Modified: trunk/reactos/ntoskrnl/mm/i386/page.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/i386/page.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/i386/page.c [iso-8859-1] Tue Nov 15 22:34:04 2011 @@ -209,18 +209,59 @@ ULONG Entry; PULONG Pt, PageDir; - if (Address < MmSystemRangeStart && Process && Process != PsGetCurrentProcess()) - { - PageDir = MmCreateHyperspaceMapping(PTE_TO_PFN(Process->Pcb.DirectoryTableBase[0])); - if (PageDir == NULL) - { - KeBugCheck(MEMORY_MANAGEMENT); - } - if (0 == InterlockedCompareExchangePte(&PageDir[PdeOffset], 0, 0)) + if (Address < MmSystemRangeStart) + { + /* We should have a process for user land addresses */ + ASSERT(Process != NULL); + + if(Process != PsGetCurrentProcess()) + { + PageDir = MmCreateHyperspaceMapping(PTE_TO_PFN(Process->Pcb.DirectoryTableBase[0])); + if (PageDir == NULL) + { + KeBugCheck(MEMORY_MANAGEMENT); + } + if (0 == InterlockedCompareExchangePte(&PageDir[PdeOffset], 0, 0)) + { + if (Create == FALSE) + { + MmDeleteHyperspaceMapping(PageDir); + return NULL; + } + MI_SET_USAGE(MI_USAGE_LEGACY_PAGE_DIRECTORY); + if (Process) MI_SET_PROCESS2(Process->ImageFileName); + if (!Process) MI_SET_PROCESS2("Kernel Legacy"); + Status = MmRequestPageMemoryConsumer(MC_SYSTEM, FALSE, &Pfn); + if (!NT_SUCCESS(Status) || Pfn == 0) + { + KeBugCheck(MEMORY_MANAGEMENT); + } + Entry = InterlockedCompareExchangePte(&PageDir[PdeOffset], PFN_TO_PTE(Pfn) | PA_PRESENT | PA_READWRITE | PA_USER, 0); + if (Entry != 0) + { + MmReleasePageMemoryConsumer(MC_SYSTEM, Pfn); + Pfn = PTE_TO_PFN(Entry); + } + } + else + { + Pfn = PTE_TO_PFN(PageDir[PdeOffset]); + } + MmDeleteHyperspaceMapping(PageDir); + Pt = MmCreateHyperspaceMapping(Pfn); + if (Pt == NULL) + { + KeBugCheck(MEMORY_MANAGEMENT); + } + DPRINT1("Pt : %p, *pt %x, ret %p, *ret %x\n", Pt, *Pt, (char*)Pt + ADDR_TO_PTE_OFFSET(Address), *((char*)Pt + ADDR_TO_PTE_OFFSET(Address))); + return Pt + MiAddressToPteOffset(Address); + } + /* This is for our process */ + PageDir = (PULONG)MiAddressToPde(Address); + if (0 == InterlockedCompareExchangePte(PageDir, 0, 0)) { if (Create == FALSE) { - MmDeleteHyperspaceMapping(PageDir); return NULL; } MI_SET_USAGE(MI_USAGE_LEGACY_PAGE_DIRECTORY); @@ -231,25 +272,16 @@ { KeBugCheck(MEMORY_MANAGEMENT); } - Entry = InterlockedCompareExchangePte(&PageDir[PdeOffset], PFN_TO_PTE(Pfn) | PA_PRESENT | PA_READWRITE | PA_USER, 0); + Entry = InterlockedCompareExchangePte(PageDir, PFN_TO_PTE(Pfn) | PA_PRESENT | PA_READWRITE | PA_USER, 0); if (Entry != 0) { MmReleasePageMemoryConsumer(MC_SYSTEM, Pfn); - Pfn = PTE_TO_PFN(Entry); } } - else - { - Pfn = PTE_TO_PFN(PageDir[PdeOffset]); - } - MmDeleteHyperspaceMapping(PageDir); - Pt = MmCreateHyperspaceMapping(Pfn); - if (Pt == NULL) - { - KeBugCheck(MEMORY_MANAGEMENT); - } - return Pt + ADDR_TO_PTE_OFFSET(Address); - } + return (PULONG)MiAddressToPte(Address); + } + + /* This is for kernel land address */ PageDir = (PULONG)MiAddressToPde(Address); if (0 == InterlockedCompareExchangePte(PageDir, 0, 0)) { @@ -282,23 +314,7 @@ } else { - if (Create == FALSE) - { - return NULL; - } - MI_SET_USAGE(MI_USAGE_LEGACY_PAGE_DIRECTORY); - if (Process) MI_SET_PROCESS2(Process->ImageFileName); - if (!Process) MI_SET_PROCESS2("Kernel Legacy"); - Status = MmRequestPageMemoryConsumer(MC_SYSTEM, FALSE, &Pfn); - if (!NT_SUCCESS(Status) || Pfn == 0) - { - KeBugCheck(MEMORY_MANAGEMENT); - } - Entry = InterlockedCompareExchangePte(PageDir, PFN_TO_PTE(Pfn) | PA_PRESENT | PA_READWRITE | PA_USER, 0); - if (Entry != 0) - { - MmReleasePageMemoryConsumer(MC_SYSTEM, Pfn); - } + } } return (PULONG)MiAddressToPte(Address); @@ -370,8 +386,11 @@ { Pte = *Pt; } while (Pte != InterlockedCompareExchangePte(Pt, Pte & ~PA_PRESENT, Pte)); + Pte = *Pt; + Pte = InterlockedExchangePte(Pt, Pte & ~((ULONG)PA_PRESENT)); MiFlushTlb(Pt, Address); + WasValid = (PAGE_MASK(Pte) != 0); if (!WasValid) { @@ -769,7 +788,7 @@ PdeOffset = ADDR_TO_PDE_OFFSET(Addr); if (oldPdeOffset != PdeOffset) { - MmUnmapPageTable(Pt); + //MmUnmapPageTable(Pt); Pt = MmGetPageTableForProcess(Process, Addr, TRUE); if (Pt == NULL) { @@ -783,24 +802,14 @@ oldPdeOffset = PdeOffset; Pte = *Pt; - if (PAGE_MASK(Pte) != 0 && !(Pte & PA_PRESENT) && (Pte & 0x800)) + /* There should not be anything valid here */ + if ((Pte & PA_PRESENT) || (Pte & 0x800)) { DPRINT1("Bad PTE %lx\n", Pte); KeBugCheck(MEMORY_MANAGEMENT); } InterlockedExchangePte(Pt, PFN_TO_PTE(Pages[i]) | Attributes); - if (Pte != 0) - { - if (Address > MmSystemRangeStart || - (Pt >= (PULONG)PAGETABLE_MAP && Pt < (PULONG)PAGETABLE_MAP + 1024*1024)) - { - MiFlushTlb(Pt, Address); - } - } - } - if (Addr > Address) - { - MmUnmapPageTable(Pt); + MiFlushTlb(Pt, Addr); } return(STATUS_SUCCESS); Modified: trunk/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] Tue Nov 15 22:34:04 2011 @@ -1829,10 +1829,9 @@ DPRINT("MmAccessFaultSectionView(%x, %x, %x, %x)\n", AddressSpace, MemoryArea, Address); /* - * Check if the page has been paged out or has already been set readwrite - */ - if (!MmIsPagePresent(Process, Address) || - MmGetPageProtect(Process, Address) & PAGE_READWRITE) + * Check if the page has already been set readwrite + */ + if (MmGetPageProtect(Process, Address) & PAGE_READWRITE) { DPRINT("Address 0x%.8X\n", Address); return(STATUS_SUCCESS); @@ -1855,7 +1854,7 @@ */ MmLockSectionSegment(Segment); - OldPage = MmGetPfnForProcess(NULL, Address); + OldPage = MmGetPfnForProcess(Process, Address); Entry = MmGetPageEntrySectionSegment(Segment, Offset); MmUnlockSectionSegment(Segment);

1 0

[cgutman] 54389: [NTOSKRNL] - Fix 2 broken failure cases (forgot to detach from process and/or forgot to dereference process)
by cgutman＠svn.reactos.org 15 Nov '11

15 Nov '11

Author: cgutman Date: Tue Nov 15 22:16:57 2011 New Revision: 54389 URL: http://svn.reactos.org/svn/reactos?rev=54389&view=rev Log: [NTOSKRNL] - Fix 2 broken failure cases (forgot to detach from process and/or forgot to dereference process) Modified: trunk/reactos/ntoskrnl/mm/anonmem.c Modified: trunk/reactos/ntoskrnl/mm/anonmem.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/anonmem.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] Tue Nov 15 22:16:57 2011 @@ -683,6 +683,7 @@ { /* Fail without it */ DPRINT1("Privilege not held for MEM_LARGE_PAGES\n"); + if (Attached) KeUnstackDetachProcess(&ApcState); if (ProcessHandle != NtCurrentProcess()) ObDereferenceObject(Process); return STATUS_PRIVILEGE_NOT_HELD; } @@ -701,6 +702,8 @@ (Protect & (PAGE_WRITECOPY | PAGE_EXECUTE_WRITECOPY))) { DPRINT1("Copy on write is not supported by VirtualAlloc\n"); + if (Attached) KeUnstackDetachProcess(&ApcState); + if (ProcessHandle != NtCurrentProcess()) ObDereferenceObject(Process); return STATUS_INVALID_PAGE_PROTECTION; }

1 0

[pschweitzer] 54388: Create branch for students of the Clermont IUT, to work on netsh
by pschweitzer＠svn.reactos.org 15 Nov '11

15 Nov '11

Author: pschweitzer Date: Tue Nov 15 20:56:13 2011 New Revision: 54388 URL: http://svn.reactos.org/svn/reactos?rev=54388&view=rev Log: Create branch for students of the Clermont IUT, to work on netsh Added: branches/iut-netsh/ (props changed) - copied from r54387, trunk/reactos/ Propchange: branches/iut-netsh/ ------------------------------------------------------------------------------ --- bugtraq:logregex (added) +++ bugtraq:logregex Tue Nov 15 20:56:13 2011 @@ -1,0 +1,2 @@ +([Ii]ssue|[Bb]ug)s? #?(\d+)(,? ?#?(\d+))*(,? ?(and |or )?#?(\d+))? +(\d+) Propchange: branches/iut-netsh/ ------------------------------------------------------------------------------ bugtraq:message = See issue #%BUGID% for more details. Propchange: branches/iut-netsh/ ------------------------------------------------------------------------------ bugtraq:url = http://www.reactos.org/bugzilla/show_bug.cgi?id=%BUGID% Propchange: branches/iut-netsh/ ------------------------------------------------------------------------------ --- svn:ignore (added) +++ svn:ignore Tue Nov 15 20:56:13 2011 @@ -1,0 +1,14 @@ +*.iso +makefile.auto +makefile-*.auto +config-*.rbuild +obj-* +output-* +reactos +reactos.* +RosBE-Logs +*.sln +*.ncb +*.suo +versionreport.xml +config.rbuild Propchange: branches/iut-netsh/ ------------------------------------------------------------------------------ --- svn:mergeinfo (added) +++ svn:mergeinfo Tue Nov 15 20:56:13 2011 @@ -1,0 +1,12 @@ +/branches/GSoC_2011/GSoC_Network:51548 +/branches/GSoC_2011/GSoC_TcpIpDriver:51550 +/branches/GSoC_2011/TcpIpDriver:51551-53074,53076-53119 +/branches/GSoC_Network:51545-51546 +/branches/cmake-bringup:50484,50693,50719,51544-52564 +/branches/header-work:45691-47721 +/branches/reactos-yarotows:45219-46371,46373-48025,48027-49273 +/branches/reactx/reactos:49994-49995 +/branches/ros-amd64-bringup:36852 +/branches/ros-amd64-bringup/reactos:34711-34712,34741,34743,34770,34780-34782,34803,34812,34839,34842,34864,34870,34874,34877,34908-34909,34917,34965,35323-35324,35347-35348,35361,35436,35509,35515,35588,35655,35683,35739,35746,35762,35771,35777,35781,35789,35805,35823,35827,35902,35904-35906,35942,35947-35949,35952-35953,35966,36011-36013,36172,36360,36380,36388-36389,36393,36397,36443,36445,36475,36502-36503,36505,36570,36614,36852,36898-36899,36930,36936,36949,36951,36958,36961,36964,36969,36972,36987-36988,36990,36992,37019,37322-37323,37333-37334,37434,37472,37475,37536,37820-37821,37868-37869,37873,37990-37991,38013-38014,38092,38100,38148-38151,38264-38265,38268,38355,39151,39333,39335,39345,39639,40120,40122-40123,40125,40127-40128,40155,40247,40324,40608,40753,40926-40928,40986-40987,40989,40991,40993,40995-40996,41000-41001,41027-41030,41044-41045,41047-41050,41052,41070,41082-41086,41097-41098,41101,41449,41479-41480,41483-41485,41499-41500,41502,41531,41536,41540,41546-41547,41549,43080,43426,43451,43454,43506,43566,43574,43598,43600-43602,43604-43605,43677,43682,43757,43775,43836,43838-43840,43852,43857-43858,43860,43905-43907,43952,43954,43965,43969,43979,43981,43992,44002,44036-44037,44039-44040,44044-44045,44053,44065,44095,44123,44143-44144,44205,44238,44257,44259,44294,44338-44339,44385,44389,44391,44426,44460,44467-44468,44470-44471,44499,44501,44503-44504,44506,44510-44512,44521,44523-44526,44530,44540,44601,44634,44639,44772,44818,45124,45126-45127,45430,46394,46404,46478,46511,46523-46524,46526,46534-46535,46537-46539,46589,46805,46868,47472,47846-47847,47878,47882 +/branches/shell32_new-bringup:51893-53652,53661,53700 +/branches/tcp-rewrite-branch:48720,48840-48841,49424-49426,49454 Propchange: branches/iut-netsh/ ------------------------------------------------------------------------------ tsvn:logminsize = 10

1 0

[cgutman] 54387: [NDIS] - Implement NdisPciAssignResources
by cgutman＠svn.reactos.org 15 Nov '11

15 Nov '11

Author: cgutman Date: Tue Nov 15 18:41:34 2011 New Revision: 54387 URL: http://svn.reactos.org/svn/reactos?rev=54387&view=rev Log: [NDIS] - Implement NdisPciAssignResources Modified: trunk/reactos/drivers/network/ndis/ndis/30stubs.c trunk/reactos/drivers/network/ndis/ndis/hardware.c Modified: trunk/reactos/drivers/network/ndis/ndis/30stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… ============================================================================== --- trunk/reactos/drivers/network/ndis/ndis/30stubs.c [iso-8859-1] (original) +++ trunk/reactos/drivers/network/ndis/ndis/30stubs.c [iso-8859-1] Tue Nov 15 18:41:34 2011 @@ -73,24 +73,6 @@ /* * @unimplemented */ -NDIS_STATUS -EXPORT -NdisPciAssignResources( - IN NDIS_HANDLE NdisMacHandle, - IN NDIS_HANDLE NdisWrapperHandle, - IN NDIS_HANDLE WrapperConfigurationContext, - IN ULONG SlotNumber, - OUT PNDIS_RESOURCE_LIST *AssignedResources) -{ - UNIMPLEMENTED - - return NDIS_STATUS_FAILURE; -} - - -/* - * @unimplemented - */ VOID EXPORT NdisReadBindingInformation ( Modified: trunk/reactos/drivers/network/ndis/ndis/hardware.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/ndis/ndis/… ============================================================================== --- trunk/reactos/drivers/network/ndis/ndis/hardware.c [iso-8859-1] (original) +++ trunk/reactos/drivers/network/ndis/ndis/hardware.c [iso-8859-1] Tue Nov 15 18:41:34 2011 @@ -78,7 +78,25 @@ return NDIS_STATUS_SUCCESS; } - +/* + * @implemented + */ +NDIS_STATUS +EXPORT +NdisPciAssignResources( + IN NDIS_HANDLE NdisMacHandle, + IN NDIS_HANDLE NdisWrapperHandle, + IN NDIS_HANDLE WrapperConfigurationContext, + IN ULONG SlotNumber, + OUT PNDIS_RESOURCE_LIST *AssignedResources) +{ + PNDIS_WRAPPER_CONTEXT WrapperContext = (PNDIS_WRAPPER_CONTEXT)WrapperConfigurationContext; + PLOGICAL_ADAPTER Adapter = WrapperContext->DeviceObject->DeviceExtension; + + return NdisMPciAssignResources(Adapter, + SlotNumber, + AssignedResources); +} /* * @implemented */

1 0

[jgardou] 54386: [NTOSKRNL/MM] - call mm functions with a process, when we have one. - Fix potential rounding issues - Add some sanity ASSERTs - You never use enough brackets ; -)
by jgardou＠svn.reactos.org 15 Nov '11

15 Nov '11

Author: jgardou Date: Tue Nov 15 18:36:26 2011 New Revision: 54386 URL: http://svn.reactos.org/svn/reactos?rev=54386&view=rev Log: [NTOSKRNL/MM] - call mm functions with a process, when we have one. - Fix potential rounding issues - Add some sanity ASSERTs - You never use enough brackets ;-) Modified: trunk/reactos/ntoskrnl/mm/anonmem.c trunk/reactos/ntoskrnl/mm/freelist.c trunk/reactos/ntoskrnl/mm/marea.c trunk/reactos/ntoskrnl/mm/pagefile.c Modified: trunk/reactos/ntoskrnl/mm/anonmem.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/anonmem.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/anonmem.c [iso-8859-1] Tue Nov 15 18:36:26 2011 @@ -183,7 +183,7 @@ * address space when another thread could load the page so we check * that. */ - if (MmIsPagePresent(NULL, Address)) + if (MmIsPagePresent(Process, Address)) { return(STATUS_SUCCESS); } @@ -301,7 +301,7 @@ /* * Handle swapped out pages. */ - if (MmIsPageSwapEntry(NULL, Address)) + if (MmIsPageSwapEntry(Process, Address)) { SWAPENTRY SwapEntry; @@ -327,7 +327,7 @@ { MmUnlockAddressSpace(AddressSpace); Status = MmCreateVirtualMapping(Process, - Address, + (PVOID)PAGE_ROUND_DOWN(Address), Region->Protect, &Page, 1); Modified: trunk/reactos/ntoskrnl/mm/freelist.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/freelist.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/mm/freelist.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/freelist.c [iso-8859-1] Tue Nov 15 18:36:26 2011 @@ -92,6 +92,7 @@ /* Set the page as a user page */ ASSERT(Pfn != 0); ASSERT_IS_ROS_PFN(MiGetPfnEntry(Pfn)); + ASSERT(!RtlCheckBit(&MiUserPfnBitMap, (ULONG)Pfn)); OldIrql = KeAcquireQueuedSpinLock(LockQueuePfnLock); RtlSetBit(&MiUserPfnBitMap, (ULONG)Pfn); KeReleaseQueuedSpinLock(LockQueuePfnLock, OldIrql); @@ -123,6 +124,7 @@ /* Unset the page as a user page */ ASSERT(Page != 0); ASSERT_IS_ROS_PFN(MiGetPfnEntry(Page)); + ASSERT(RtlCheckBit(&MiUserPfnBitMap, (ULONG)Page)); RtlClearBit(&MiUserPfnBitMap, (ULONG)Page); } Modified: trunk/reactos/ntoskrnl/mm/marea.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/marea.c?rev=54… ============================================================================== --- trunk/reactos/ntoskrnl/mm/marea.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/marea.c [iso-8859-1] Tue Nov 15 18:36:26 2011 @@ -893,7 +893,7 @@ Granularity = (MEMORY_AREA_VIRTUAL_MEMORY == Type ? MM_VIRTMEM_GRANULARITY : PAGE_SIZE); if ((*BaseAddress) == 0 && !FixedAddress) { - tmpLength = PAGE_ROUND_UP(Length); + tmpLength = (ULONG_PTR)MM_ROUND_UP(Length, Granularity); *BaseAddress = MmFindGap(AddressSpace, tmpLength, Granularity, @@ -908,6 +908,7 @@ { tmpLength = Length + ((ULONG_PTR) *BaseAddress - (ULONG_PTR) MM_ROUND_DOWN(*BaseAddress, Granularity)); + tmpLength = (ULONG_PTR)MM_ROUND_UP(tmpLength, Granularity); *BaseAddress = MM_ROUND_DOWN(*BaseAddress, Granularity); if (!MmGetAddressSpaceOwner(AddressSpace) && *BaseAddress < MmSystemRangeStart) @@ -986,6 +987,8 @@ { ULONG i; NTSTATUS Status; + + ASSERT(((ULONG_PTR)BaseAddress % PAGE_SIZE) == 0); for (i = 0; i < PAGE_ROUND_UP(Length) / PAGE_SIZE; i++) { Modified: trunk/reactos/ntoskrnl/mm/pagefile.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/pagefile.c?rev… ============================================================================== --- trunk/reactos/ntoskrnl/mm/pagefile.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/pagefile.c [iso-8859-1] Tue Nov 15 18:36:26 2011 @@ -113,7 +113,7 @@ */ #define FILE_FROM_ENTRY(i) ((i) & 0x0f) #define OFFSET_FROM_ENTRY(i) ((i) >> 11) -#define ENTRY_FROM_FILE_OFFSET(i, j) ((i) | (j) << 11 | 0x400) +#define ENTRY_FROM_FILE_OFFSET(i, j) ((i) | ((j) << 11) | 0x400) static BOOLEAN MmSwapSpaceMessage = FALSE;

1 0

[rharabien] 54385: [KBDTOOL] - Fix build under MSVC
by rharabien＠svn.reactos.org 15 Nov '11

15 Nov '11

Author: rharabien Date: Tue Nov 15 11:07:31 2011 New Revision: 54385 URL: http://svn.reactos.org/svn/reactos?rev=54385&view=rev Log: [KBDTOOL] - Fix build under MSVC Modified: trunk/reactos/tools/kbdtool/kbdtool.h trunk/reactos/tools/kbdtool/main.c Modified: trunk/reactos/tools/kbdtool/kbdtool.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/kbdtool/kbdtool.h?re… ============================================================================== --- trunk/reactos/tools/kbdtool/kbdtool.h [iso-8859-1] (original) +++ trunk/reactos/tools/kbdtool/kbdtool.h [iso-8859-1] Tue Nov 15 11:07:31 2011 @@ -12,7 +12,6 @@ #include <stdarg.h> #include <stdio.h> #include <stdlib.h> -#include <getopt.h> #include <time.h> #include <typedefs.h> Modified: trunk/reactos/tools/kbdtool/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/kbdtool/main.c?rev=5… ============================================================================== --- trunk/reactos/tools/kbdtool/main.c [iso-8859-1] (original) +++ trunk/reactos/tools/kbdtool/main.c [iso-8859-1] Tue Nov 15 11:07:31 2011 @@ -61,98 +61,100 @@ main(INT argc, PCHAR* argv) { - ULONG ErrorCode, FailureCode; + ULONG i, ErrorCode, FailureCode; CHAR Option; PCHAR OpenFlags; CHAR BuildOptions[16] = {0}; /* Loop for parameter */ - while (TRUE) - { - /* Get the options */ - Option = getopt(argc, argv, "aAeEiIkKmMnNOosSuUvVwWxX?"); - if (Option != -1) + for (i = 1; i < argc; ++i) + { + if (argv[i][0] != '/' && argv[i][0] != '-') + break; + + if (argv[i][1] && !argv[i][2]) + Option = argv[i][1]; + else + Option = 0; + + /* Check supported options */ + switch (Option) { - /* Check supported options */ - switch (Option) - { - /* ASCII File */ - case 'A': - case 'a': - UnicodeFile = 0; - continue; - - /* UNICODE File */ - case 'U': - case 'u': - UnicodeFile = 1; - continue; - - /* Verbose */ - case 'V': - case 'v': - Verbose = 1; - continue; - - /* No logo */ - case 'N': - case 'n': - NoLogo = 1; - continue; - - /* Fallback driver */ - case 'K': - case 'k': - FallbackDriver = 1; - continue; - - /* Sanity Check */ - case 'W': - case 'w': - SanityCheck = 1; - continue; - - /* Itanium */ - case 'I': - case 'i': - BuildType = 1; - continue; - - /* X86 */ - case 'X': - case 'x': - BuildType = 0; - continue; - - /* AMD64 */ - case 'M': - case 'm': - BuildType = 2; - continue; - - /* WOW64 */ - case 'O': - case 'o': - BuildType = 3; - continue; - - /* Source only */ - case 'S': - case 's': - SourceOnly = 1; - continue; - default: - break; - } - - /* If you got here, the options are invalid or missing */ - PrintUsage(); + /* ASCII File */ + case 'A': + case 'a': + UnicodeFile = 0; + break; + + /* UNICODE File */ + case 'U': + case 'u': + UnicodeFile = 1; + break; + + /* Verbose */ + case 'V': + case 'v': + Verbose = 1; + break; + + /* No logo */ + case 'N': + case 'n': + NoLogo = 1; + break; + + /* Fallback driver */ + case 'K': + case 'k': + FallbackDriver = 1; + break; + + /* Sanity Check */ + case 'W': + case 'w': + SanityCheck = 1; + break; + + /* Itanium */ + case 'I': + case 'i': + BuildType = 1; + break; + + /* X86 */ + case 'X': + case 'x': + BuildType = 0; + break; + + /* AMD64 */ + case 'M': + case 'm': + BuildType = 2; + break; + + /* WOW64 */ + case 'O': + case 'o': + BuildType = 3; + break; + + /* Source only */ + case 'S': + case 's': + SourceOnly = 1; + break; + + default: + /* If you got here, the options are invalid or missing */ + PrintUsage(); + break; } - break; } /* Do we have no options? */ - if (optind == argc) PrintUsage(); + if (i == argc) PrintUsage(); /* Should we announce ourselves? */ if (!NoLogo) @@ -161,9 +163,9 @@ printf("\nKbdTool v%d.%02d - convert keyboard text file to C file or a keyboard layout DLL\n\n", gVersion, gSubVersion); } - + /* Save the file name */ - gpszFileName = argv[optind]; + gpszFileName = argv[i]; /* Open either as binary or text */ OpenFlags = "rb";

1 0

← Newer
1
...
14
15
16
17
18
19
20
...
28
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs November 2011