Ros-diffs February 2011

ros-diffs@reactos.org

18 participants
352 discussions

[akhaldi] 50786: [CMAKE] - Fix LINK (msvc) warnings.
by akhaldi＠svn.reactos.org 18 Feb '11

18 Feb '11

Author: akhaldi Date: Fri Feb 18 10:23:44 2011 New Revision: 50786 URL: http://svn.reactos.org/svn/reactos?rev=50786&view=rev Log: [CMAKE] - Fix LINK (msvc) warnings. Modified: branches/cmake-bringup/dll/win32/shell32/shell32.spec Modified: branches/cmake-bringup/dll/win32/shell32/shell32.spec URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/dll/win32/shell32… ============================================================================== --- branches/cmake-bringup/dll/win32/shell32/shell32.spec [iso-8859-1] (original) +++ branches/cmake-bringup/dll/win32/shell32/shell32.spec [iso-8859-1] Fri Feb 18 10:23:44 2011 @@ -113,16 +113,16 @@ 113 stdcall Control_RunDLLA(ptr ptr str long) 114 stdcall Control_RunDLLAsUserW(ptr ptr wstr long) 115 stdcall Control_RunDLLW(ptr ptr wstr long) -116 stdcall DllCanUnloadNow() -117 stdcall DllGetClassObject(ptr ptr ptr) +@ stdcall -private DllCanUnloadNow() +@ stdcall -private DllGetClassObject(ptr ptr ptr) 118 stdcall DllGetVersion(ptr) 119 stdcall IsLFNDrive(ptr) IsLFNDriveAW -120 stdcall DllInstall(long wstr) +@ stdcall -private DllInstall(long wstr) 121 stdcall SHFlushClipboard() 122 stdcall -noname RunDLL_CallEntry16(long long long str long) # Fixme #name wrong? 123 stdcall -noname SHFreeUnusedLibraries() -124 stdcall DllRegisterServer() -125 stdcall DllUnregisterServer() +@ stdcall -private DllRegisterServer() +@ stdcall -private DllUnregisterServer() 126 stdcall -noname SHOutOfMemoryMessageBox(long long long) # Fixme 127 stdcall -noname SHWinHelp(long long long long) 128 stdcall -noname SHDllGetClassObject(ptr ptr ptr) DllGetClassObject

1 0

[akhaldi] 50785: [CMAKE] - Fix msdmo build. Really.
by akhaldi＠svn.reactos.org 18 Feb '11

18 Feb '11

Author: akhaldi Date: Fri Feb 18 10:12:42 2011 New Revision: 50785 URL: http://svn.reactos.org/svn/reactos?rev=50785&view=rev Log: [CMAKE] - Fix msdmo build. Really. Modified: branches/cmake-bringup/dll/directx/msdmo/CMakeLists.txt branches/cmake-bringup/include/dxsdk/CMakeLists.txt Modified: branches/cmake-bringup/dll/directx/msdmo/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/dll/directx/msdmo… ============================================================================== --- branches/cmake-bringup/dll/directx/msdmo/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/dll/directx/msdmo/CMakeLists.txt [iso-8859-1] Fri Feb 18 10:12:42 2011 @@ -11,14 +11,11 @@ dmort.c stubs.c rsrc.rc - #${REACTOS_BINARY_DIR}/include/dxsdk/mediaobj_i.c ${CMAKE_CURRENT_BINARY_DIR}/msdmo.def) set_entrypoint(msdmo 0) -target_link_libraries(msdmo - uuid - wine) +target_link_libraries(msdmo uuid wine mediaobj_guid) add_importlibs(msdmo user32 Modified: branches/cmake-bringup/include/dxsdk/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/include/dxsdk/CMa… ============================================================================== --- branches/cmake-bringup/include/dxsdk/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/include/dxsdk/CMakeLists.txt [iso-8859-1] Fri Feb 18 10:12:42 2011 @@ -25,3 +25,5 @@ ) add_idl_headers(dxsdk ${SOURCE}) + +add_iid_library(mediaobj_guid mediaobj.idl)

1 0

[fireball] 50784: [RTL/AVL] - Fix an inverted condition which resulted in incorrect assignment of NewElement var in RtlInsertElementGenericTableAvl().
by fireball＠svn.reactos.org 18 Feb '11

18 Feb '11

Author: fireball Date: Fri Feb 18 09:48:13 2011 New Revision: 50784 URL: http://svn.reactos.org/svn/reactos?rev=50784&view=rev Log: [RTL/AVL] - Fix an inverted condition which resulted in incorrect assignment of NewElement var in RtlInsertElementGenericTableAvl(). Modified: trunk/reactos/lib/rtl/avltable.c Modified: trunk/reactos/lib/rtl/avltable.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/avltable.c?rev=507… ============================================================================== --- trunk/reactos/lib/rtl/avltable.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/avltable.c [iso-8859-1] Fri Feb 18 09:48:13 2011 @@ -88,7 +88,7 @@ } /* Return status */ - if (NewElement) *NewElement = (SearchResult == TableFoundNode); + if (NewElement) *NewElement = (SearchResult != TableFoundNode); /* Return pointer to user data */ return UserData;

1 0

[akhaldi] 50783: [CMAKE] - Fix wuapi build. Really.
by akhaldi＠svn.reactos.org 18 Feb '11

18 Feb '11

Author: akhaldi Date: Fri Feb 18 09:47:14 2011 New Revision: 50783 URL: http://svn.reactos.org/svn/reactos?rev=50783&view=rev Log: [CMAKE] - Fix wuapi build. Really. Modified: branches/cmake-bringup/cmake/idl-support.cmake branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt branches/cmake-bringup/include/psdk/CMakeLists.txt Modified: branches/cmake-bringup/cmake/idl-support.cmake URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/cmake/idl-support… ============================================================================== --- branches/cmake-bringup/cmake/idl-support.cmake [iso-8859-1] (original) +++ branches/cmake-bringup/cmake/idl-support.cmake [iso-8859-1] Fri Feb 18 09:47:14 2011 @@ -165,4 +165,5 @@ list(APPEND IID_SOURCES ${NAME}_i.c) endforeach() add_library(${TARGET} ${IID_SOURCES}) + add_dependencies(${TARGET} psdk) endmacro() Modified: branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/dll/win32/wuapi/C… ============================================================================== --- branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt [iso-8859-1] Fri Feb 18 09:47:14 2011 @@ -23,6 +23,6 @@ add_library(wuapi SHARED ${SOURCE}) set_module_type(wuapi win32dll) -target_link_libraries(wuapi uuid wine) +target_link_libraries(wuapi uuid wine wuguid) add_importlibs(wuapi ole32 advapi32 msvcrt kernel32 ntdll) add_cab_target(wuapi 1) Modified: branches/cmake-bringup/include/psdk/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/include/psdk/CMak… ============================================================================== --- branches/cmake-bringup/include/psdk/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/include/psdk/CMakeLists.txt [iso-8859-1] Fri Feb 18 09:47:14 2011 @@ -111,3 +111,5 @@ add_idl_headers(psdk ${SOURCE}) add_typelib(stdole2 stdole2.idl) + +add_iid_library(wuguid wuapi.idl)

1 0

[janderwald] 50782: - Revert all changes made to wuapi. This doesnt work properly with gcc
by janderwald＠svn.reactos.org 18 Feb '11

18 Feb '11

Author: janderwald Date: Fri Feb 18 02:27:40 2011 New Revision: 50782 URL: http://svn.reactos.org/svn/reactos?rev=50782&view=rev Log: - Revert all changes made to wuapi. This doesnt work properly with gcc Modified: branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt branches/cmake-bringup/include/psdk/CMakeLists.txt Modified: branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/dll/win32/wuapi/C… ============================================================================== --- branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt [iso-8859-1] Fri Feb 18 02:27:40 2011 @@ -23,7 +23,6 @@ add_library(wuapi SHARED ${SOURCE}) set_module_type(wuapi win32dll) -target_link_libraries(wuapi uuid wine wuapi_idl_header) +target_link_libraries(wuapi uuid wine) add_importlibs(wuapi ole32 advapi32 msvcrt kernel32 ntdll) add_cab_target(wuapi 1) -add_dependencies(wuapi wuapi_idl_header) Modified: branches/cmake-bringup/include/psdk/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/include/psdk/CMak… ============================================================================== --- branches/cmake-bringup/include/psdk/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/include/psdk/CMakeLists.txt [iso-8859-1] Fri Feb 18 02:27:40 2011 @@ -97,6 +97,7 @@ wincodec.idl winsxs.idl wtypes.idl + wuapi.idl xmldom.idl xmldso.idl ctfutb.idl @@ -109,6 +110,4 @@ add_idl_headers(psdk ${SOURCE}) -add_iid_library(wuapi_idl_header wuapi.idl) - add_typelib(stdole2 stdole2.idl)

1 0

[janderwald] 50781: try fix build
by janderwald＠svn.reactos.org 18 Feb '11

18 Feb '11

Author: janderwald Date: Fri Feb 18 02:16:29 2011 New Revision: 50781 URL: http://svn.reactos.org/svn/reactos?rev=50781&view=rev Log: try fix build Modified: branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt Modified: branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/dll/win32/wuapi/C… ============================================================================== --- branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/dll/win32/wuapi/CMakeLists.txt [iso-8859-1] Fri Feb 18 02:16:29 2011 @@ -26,4 +26,4 @@ target_link_libraries(wuapi uuid wine wuapi_idl_header) add_importlibs(wuapi ole32 advapi32 msvcrt kernel32 ntdll) add_cab_target(wuapi 1) - +add_dependencies(wuapi wuapi_idl_header)

1 0

[janderwald] 50780: - Fix batt msvc build
by janderwald＠svn.reactos.org 18 Feb '11

18 Feb '11

Author: janderwald Date: Fri Feb 18 01:22:32 2011 New Revision: 50780 URL: http://svn.reactos.org/svn/reactos?rev=50780&view=rev Log: - Fix batt msvc build Modified: branches/cmake-bringup/dll/win32/batt/CMakeLists.txt Modified: branches/cmake-bringup/dll/win32/batt/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/dll/win32/batt/CM… ============================================================================== --- branches/cmake-bringup/dll/win32/batt/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/dll/win32/batt/CMakeLists.txt [iso-8859-1] Fri Feb 18 01:22:32 2011 @@ -12,6 +12,6 @@ add_importlib_target(batt.spec) -add_importlibs(batt msvcrt kernel32) +add_importlibs(batt msvcrt kernel32 ntdll) add_cab_target(batt 1)

1 0

[janderwald] 50779: - Fix pcix msvc build
by janderwald＠svn.reactos.org 18 Feb '11

18 Feb '11

Author: janderwald Date: Fri Feb 18 01:09:42 2011 New Revision: 50779 URL: http://svn.reactos.org/svn/reactos?rev=50779&view=rev Log: - Fix pcix msvc build Modified: branches/cmake-bringup/drivers/bus/pcix/pci/busno.c Modified: branches/cmake-bringup/drivers/bus/pcix/pci/busno.c URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/drivers/bus/pcix/… ============================================================================== --- branches/cmake-bringup/drivers/bus/pcix/pci/busno.c [iso-8859-1] (original) +++ branches/cmake-bringup/drivers/bus/pcix/pci/busno.c [iso-8859-1] Fri Feb 18 01:09:42 2011 @@ -20,8 +20,9 @@ NTAPI PciAreBusNumbersConfigured(IN PPCI_PDO_EXTENSION PdoExtension) { + UCHAR PrimaryBus, BaseBus, SecondaryBus, SubordinateBus; + PAGED_CODE(); - UCHAR PrimaryBus, BaseBus, SecondaryBus, SubordinateBus; /* Get all relevant bus number details */ PrimaryBus = PdoExtension->Dependent.type1.PrimaryBus;

1 0

[janderwald] 50778: - Fix linking error
by janderwald＠svn.reactos.org 18 Feb '11

18 Feb '11

Author: janderwald Date: Fri Feb 18 01:06:17 2011 New Revision: 50778 URL: http://svn.reactos.org/svn/reactos?rev=50778&view=rev Log: - Fix linking error Modified: branches/cmake-bringup/drivers/bus/acpi/power.c Modified: branches/cmake-bringup/drivers/bus/acpi/power.c URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/drivers/bus/acpi/… ============================================================================== --- branches/cmake-bringup/drivers/bus/acpi/power.c [iso-8859-1] (original) +++ branches/cmake-bringup/drivers/bus/acpi/power.c [iso-8859-1] Fri Feb 18 01:06:17 2011 @@ -224,7 +224,7 @@ return status; } -#ifndef NDEBUG +#if !defined(NDEBUG) && !defined(_MSC_VER) PCHAR PowerMinorFunctionString (

1 0

[janderwald] 50777: - Fix xinput msvc build - Powered by Amine
by janderwald＠svn.reactos.org 18 Feb '11

18 Feb '11

Author: janderwald Date: Fri Feb 18 00:39:31 2011 New Revision: 50777 URL: http://svn.reactos.org/svn/reactos?rev=50777&view=rev Log: - Fix xinput msvc build - Powered by Amine Modified: branches/cmake-bringup/dll/win32/xinput1_1/CMakeLists.txt branches/cmake-bringup/dll/win32/xinput1_2/CMakeLists.txt branches/cmake-bringup/dll/win32/xinput1_3/CMakeLists.txt branches/cmake-bringup/dll/win32/xinput9_1_0/CMakeLists.txt Modified: branches/cmake-bringup/dll/win32/xinput1_1/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/dll/win32/xinput1… ============================================================================== --- branches/cmake-bringup/dll/win32/xinput1_1/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/dll/win32/xinput1_1/CMakeLists.txt [iso-8859-1] Fri Feb 18 00:39:31 2011 @@ -12,5 +12,5 @@ add_library(xinput1_1 SHARED ${SOURCE}) set_module_type(xinput1_1 win32dll) -add_importlibs(xinput1_1 msvcrt kernel32) +add_importlibs(xinput1_1 msvcrt kernel32 xinput1_3) add_cab_target(xinput1_1 1) Modified: branches/cmake-bringup/dll/win32/xinput1_2/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/dll/win32/xinput1… ============================================================================== --- branches/cmake-bringup/dll/win32/xinput1_2/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/dll/win32/xinput1_2/CMakeLists.txt [iso-8859-1] Fri Feb 18 00:39:31 2011 @@ -12,5 +12,5 @@ add_library(xinput1_2 SHARED ${SOURCE}) set_module_type(xinput1_2 win32dll) -add_importlibs(xinput1_2 msvcrt kernel32) +add_importlibs(xinput1_2 msvcrt kernel32 xinput1_3) add_cab_target(xinput1_2 1) Modified: branches/cmake-bringup/dll/win32/xinput1_3/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/dll/win32/xinput1… ============================================================================== --- branches/cmake-bringup/dll/win32/xinput1_3/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/dll/win32/xinput1_3/CMakeLists.txt [iso-8859-1] Fri Feb 18 00:39:31 2011 @@ -11,6 +11,7 @@ add_library(xinput1_3 SHARED ${SOURCE}) +add_importlib_target(xinput1_3.spec) set_module_type(xinput1_3 win32dll) target_link_libraries(xinput1_3 wine) add_importlibs(xinput1_3 msvcrt kernel32 ntdll) Modified: branches/cmake-bringup/dll/win32/xinput9_1_0/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/branches/cmake-bringup/dll/win32/xinput9… ============================================================================== --- branches/cmake-bringup/dll/win32/xinput9_1_0/CMakeLists.txt [iso-8859-1] (original) +++ branches/cmake-bringup/dll/win32/xinput9_1_0/CMakeLists.txt [iso-8859-1] Fri Feb 18 00:39:31 2011 @@ -12,5 +12,5 @@ add_library(xinput9_1_0 SHARED ${SOURCE}) set_module_type(xinput9_1_0 win32dll) -add_importlibs(xinput9_1_0 msvcrt kernel32) +add_importlibs(xinput9_1_0 msvcrt kernel32 xinput1_3) add_cab_target(xinput9_1_0 1)

1 0

← Newer
1
...
13
14
15
16
17
18
19
...
36
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs February 2011