Ros-diffs June 2011

ros-diffs@reactos.org

25 participants
460 discussions

[akhaldi] 52102: [CMAKE] * Use our oldnames library instead of libcoldname.
by akhaldi＠svn.reactos.org 05 Jun '11

05 Jun '11

Author: akhaldi Date: Sun Jun 5 21:24:00 2011 New Revision: 52102 URL: http://svn.reactos.org/svn/reactos?rev=52102&view=rev Log: [CMAKE] * Use our oldnames library instead of libcoldname. Modified: trunk/reactos/dll/directx/ksproxy/CMakeLists.txt trunk/reactos/dll/win32/glu32/CMakeLists.txt Modified: trunk/reactos/dll/directx/ksproxy/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/ksproxy/CMakeL… ============================================================================== --- trunk/reactos/dll/directx/ksproxy/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/directx/ksproxy/CMakeLists.txt [iso-8859-1] Sun Jun 5 21:24:00 2011 @@ -36,7 +36,7 @@ else() #FIXME : can't build if this is enabled, check if this is needed #set_target_properties(ksproxy PROPERTIES COMPILE_FLAGS "-fno-exceptions -fno-rtti") - target_link_libraries(ksproxy -lsupc++ -lgcc -lmingw32 -lcoldname) + target_link_libraries(ksproxy -lsupc++ -lgcc -lmingw32 oldnames) endif(MSVC) target_link_libraries(ksproxy stlport strmiids) Modified: trunk/reactos/dll/win32/glu32/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/glu32/CMakeLists… ============================================================================== --- trunk/reactos/dll/win32/glu32/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/glu32/CMakeLists.txt [iso-8859-1] Sun Jun 5 21:24:00 2011 @@ -111,7 +111,7 @@ set_entrypoint(glu32 0) -target_link_libraries(glu32 stlport -lsupc++ -lgcc -lmingw32 -lcoldname) +target_link_libraries(glu32 stlport -lsupc++ -lgcc -lmingw32 oldnames) add_importlibs(glu32 opengl32

1 0

[akhaldi] 52101: [CMAKE] * Temporarily add libcoldname.a
by akhaldi＠svn.reactos.org 05 Jun '11

05 Jun '11

Author: akhaldi Date: Sun Jun 5 21:04:31 2011 New Revision: 52101 URL: http://svn.reactos.org/svn/reactos?rev=52101&view=rev Log: [CMAKE] * Temporarily add libcoldname.a Added: trunk/reactos/importlibs/libcoldname.a (with props) Added: trunk/reactos/importlibs/libcoldname.a URL: http://svn.reactos.org/svn/reactos/trunk/reactos/importlibs/libcoldname.a?r… ============================================================================== Binary file - no diff available. Propchange: trunk/reactos/importlibs/libcoldname.a ------------------------------------------------------------------------------ svn:mime-type = application/octet-stream

1 0

[akhaldi] 52100: [CRT/INTRINSICS] Timo Kreuzer: * Change inline assembly constraint from "r" to "q". "r" means any kind of register, including *si and *di, these cannot be used for 8bit operations ...
by akhaldi＠svn.reactos.org 05 Jun '11

05 Jun '11

Author: akhaldi Date: Sun Jun 5 20:59:09 2011 New Revision: 52100 URL: http://svn.reactos.org/svn/reactos?rev=52100&view=rev Log: [CRT/INTRINSICS] Timo Kreuzer: * Change inline assembly constraint from "r" to "q". "r" means any kind of register, including *si and *di, these cannot be used for 8bit operations on x86, only x64 has sil, dil registers. But gcc is stupid and doesn't get that if we don't tell it explicitly, by using "q", which will only allow a, b, c, d registers. Fixes an assembler error messages that can occur under certain circumstances. Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/mingw32/intrin… ============================================================================== --- trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] (original) +++ trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] Sun Jun 5 20:59:09 2011 @@ -911,7 +911,7 @@ __INTRIN_INLINE unsigned char _rotr8(unsigned char value, unsigned char shift) { unsigned char retval; - __asm__("rorb %b[shift], %b[retval]" : [retval] "=rm" (retval) : "[retval]" (value), [shift] "Nc" (shift)); + __asm__("rorb %b[shift], %b[retval]" : [retval] "=qm" (retval) : "[retval]" (value), [shift] "Nc" (shift)); return retval; }

1 0

[akhaldi] 52099: [CMAKE] * chkstk is already part of msvcrtex. Just update it.
by akhaldi＠svn.reactos.org 05 Jun '11

05 Jun '11

Author: akhaldi Date: Sun Jun 5 20:57:13 2011 New Revision: 52099 URL: http://svn.reactos.org/svn/reactos?rev=52099&view=rev Log: [CMAKE] * chkstk is already part of msvcrtex. Just update it. Modified: trunk/reactos/lib/sdk/crt/msvcrtex.cmake Modified: trunk/reactos/lib/sdk/crt/msvcrtex.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/msvcrtex.cmake… ============================================================================== --- trunk/reactos/lib/sdk/crt/msvcrtex.cmake [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/msvcrtex.cmake [iso-8859-1] Sun Jun 5 20:57:13 2011 @@ -38,6 +38,7 @@ if(ARCH MATCHES i386) list(APPEND MSVCRTEX_SOURCE except/i386/chkstk_asm.s + except/i386/chkstk_ms.s math/i386/ci.c math/i386/ftol2_asm.s math/i386/alldiv_asm.s @@ -55,7 +56,7 @@ set_source_files_properties(startup/crtdll.c PROPERTIES COMPILE_DEFINITIONS CRTDLL) if(NOT MSVC) - target_link_libraries(msvcrtex chkstk oldnames) + target_link_libraries(msvcrtex oldnames) endif() add_dependencies(msvcrtex psdk)

1 0

[sir_richard] 52098: [FREELDR]: Some ARM architectures do not necessarily have CS0_BASE at 0x00000000, for example, most Ti OMAP Platforms have DDR at 0x80000000. The current FreeLDR algorithms wou...
by sir_richard＠svn.reactos.org 05 Jun '11

05 Jun '11

Author: sir_richard Date: Sun Jun 5 20:48:34 2011 New Revision: 52098 URL: http://svn.reactos.org/svn/reactos?rev=52098&view=rev Log: [FREELDR]: Some ARM architectures do not necessarily have CS0_BASE at 0x00000000, for example, most Ti OMAP Platforms have DDR at 0x80000000. The current FreeLDR algorithms would build FreeLDR "page entries" for every page from 0 to 0x7FFF0000 and mark it as unusable, then build the actual valid entries from 0x80000000 -> end of RAM, thus resulting in large memory consumption (and in the bloat of the PFN database later once NTOS loads) and boot time. Therefore, the algorithm is changed to start the PFN database at the lowest valid RAM page described by the Firemware descriptors, and entries therefore will be offset. This means a 128MB embedded system no longer appears to have 2048+128MB of RAM worth of PFN entries. NOTE: Windows does not do this, opting instead to force manufacturers/use pull-up resistors/reconfigure the ARM Bus to map RAM at 0x00000000. For wider portability, I believe it makes more sense to simply do this "trick" in the boot loader. Modified: trunk/reactos/boot/freeldr/freeldr/arcemul/mm.c trunk/reactos/boot/freeldr/freeldr/mm/meminit.c Modified: trunk/reactos/boot/freeldr/freeldr/arcemul/mm.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arcem… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arcemul/mm.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/arcemul/mm.c [iso-8859-1] Sun Jun 5 20:48:34 2011 @@ -30,7 +30,6 @@ { { MemoryFirmwareTemporary, 0x80, 0x10 }, 4, }, // File system read buffer. FILESYSBUFFER { { MemoryFirmwareTemporary, 0x90, 0x10 }, 5, }, // Disk read buffer for int 13h. DISKREADBUFFER { { MemoryFirmwarePermanent, 0xA0, 0x60 }, 6, }, // ROM / Video - { { MemorySpecialMemory, 0xFFF, 1 }, 7, }, // unusable memory #elif __arm__ // This needs to be done per-platform specific way #endif @@ -55,7 +54,8 @@ // RtlZeroMemory(BiosMemoryMap, sizeof(BIOS_MEMORY_MAP) * 32); BiosMemoryMapEntryCount = MachVtbl.GetMemoryMap(BiosMemoryMap, - sizeof(BiosMemoryMap) / sizeof(BIOS_MEMORY_MAP)); + sizeof(BiosMemoryMap) / + sizeof(BIOS_MEMORY_MAP)); // // Copy the entries to our structure Modified: trunk/reactos/boot/freeldr/freeldr/mm/meminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/mm/me… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/mm/meminit.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/mm/meminit.c [iso-8859-1] Sun Jun 5 20:48:34 2011 @@ -48,6 +48,8 @@ ULONG TotalPagesInLookupTable = 0; ULONG FreePagesInLookupTable = 0; ULONG LastFreePageHint = 0; +ULONG MmLowestPhysicalPage = 0xFFFFFFFF; +ULONG MmHighestPhysicalPage = 0; extern ULONG_PTR MmHeapPointer; extern ULONG_PTR MmHeapStart; @@ -75,7 +77,7 @@ // Find address for the page lookup table TotalPagesInLookupTable = MmGetAddressablePageCountIncludingHoles(); PageLookupTableAddress = MmFindLocationForPageLookupTable(TotalPagesInLookupTable); - LastFreePageHint = TotalPagesInLookupTable; + LastFreePageHint = MmHighestPhysicalPage; if (PageLookupTableAddress == 0) { @@ -102,20 +104,21 @@ { ULONG PagesNeeded; ULONG HeapStart; +#ifndef _M_ARM MEMORY_TYPE Type; PPAGE_LOOKUP_TABLE_ITEM RealPageLookupTable = (PPAGE_LOOKUP_TABLE_ITEM)PageLookupTable; // HACK: Make it so it doesn't overlap kernel space Type = RealPageLookupTable[0x100].PageAllocated; MmMarkPagesInLookupTable(PageLookupTableAddress, 0x100, 0xFF, LoaderSystemCode); - +#endif // Find contigious memory block for HEAP:STACK PagesNeeded = HEAP_PAGES + STACK_PAGES; HeapStart = MmFindAvailablePages(PageLookupTable, TotalPagesInLookupTable, PagesNeeded, FALSE); - +#ifndef _M_ARM // Unapply the hack MmMarkPagesInLookupTable(PageLookupTableAddress, 0x100, 0xFF, Type); - +#endif if (HeapStart == 0) { UiMessageBox("Critical error: Can't allocate heap!"); @@ -156,7 +159,7 @@ ULONG MmGetAddressablePageCountIncludingHoles(VOID) { MEMORY_DESCRIPTOR* MemoryDescriptor = NULL; - ULONG EndPage = 0; + ULONG PageCount; // // Go through the whole memory map to get max address @@ -166,18 +169,30 @@ // // Check if we got a higher end page address // - if (MemoryDescriptor->BasePage + MemoryDescriptor->PageCount > EndPage) + if (MemoryDescriptor->BasePage + MemoryDescriptor->PageCount > MmHighestPhysicalPage) { // - // Yes, remember it - // - EndPage = MemoryDescriptor->BasePage + MemoryDescriptor->PageCount; + // Yes, remember it if this is real memory + // + if (MemoryDescriptor->MemoryType == MemoryFree) MmHighestPhysicalPage = MemoryDescriptor->BasePage + MemoryDescriptor->PageCount; + } + + // + // Check if we got a higher (usable) start page address + // + if (MemoryDescriptor->BasePage < MmLowestPhysicalPage) + { + // + // Yes, remember it if this is real memory + // + if (MemoryDescriptor->MemoryType == MemoryFree) MmLowestPhysicalPage = MemoryDescriptor->BasePage; } } - - DPRINTM(DPRINT_MEMORY, "MmGetAddressablePageCountIncludingHoles() returning 0x%x\n", EndPage); - - return EndPage; + + DPRINTM(DPRINT_MEMORY, "lo/hi %lx %lxn", MmLowestPhysicalPage, MmHighestPhysicalPage); + PageCount = MmHighestPhysicalPage - MmLowestPhysicalPage; + DPRINTM(DPRINT_MEMORY, "MmGetAddressablePageCountIncludingHoles() returning 0x%x\n", PageCount); + return PageCount; } PVOID MmFindLocationForPageLookupTable(ULONG TotalPageCount) @@ -260,7 +275,7 @@ // We will go through and mark pages again according to the memory map // But this will mark any holes not described in the map as allocated // - MmMarkPagesInLookupTable(PageLookupTable, 0, TotalPageCount, LoaderFirmwarePermanent); + MmMarkPagesInLookupTable(PageLookupTable, MmLowestPhysicalPage, TotalPageCount, LoaderFirmwarePermanent); // // Parse the whole memory map @@ -307,9 +322,9 @@ case MemorySpecialMemory: { // - // Special reserved memory - // - MemoryMapPageAllocated = LoaderSpecialMemory; + // OS Loader Stack + // + MemoryMapPageAllocated = LoaderOsloaderStack; break; } default: @@ -343,6 +358,7 @@ PPAGE_LOOKUP_TABLE_ITEM RealPageLookupTable = (PPAGE_LOOKUP_TABLE_ITEM)PageLookupTable; ULONG Index; + StartPage -= MmLowestPhysicalPage; for (Index=StartPage; Index<(StartPage+PageCount); Index++) { #if 0 @@ -362,6 +378,7 @@ PPAGE_LOOKUP_TABLE_ITEM RealPageLookupTable = (PPAGE_LOOKUP_TABLE_ITEM)PageLookupTable; ULONG Index; + StartPage -= MmLowestPhysicalPage; for (Index=StartPage; Index<(StartPage+PageCount); Index++) { RealPageLookupTable[Index].PageAllocated = MemoryType; @@ -416,7 +433,7 @@ if (AvailablePagesSoFar >= PagesNeeded) { - return Index; + return Index + MmLowestPhysicalPage; } } } @@ -438,7 +455,7 @@ if (AvailablePagesSoFar >= PagesNeeded) { - return Index - AvailablePagesSoFar + 1; + return Index - AvailablePagesSoFar + 1 + MmLowestPhysicalPage; } } } @@ -472,7 +489,7 @@ if (AvailablePagesSoFar >= PagesNeeded) { - return Index; + return Index + MmLowestPhysicalPage; } } @@ -488,7 +505,7 @@ { if (RealPageLookupTable[Index].PageAllocated == LoaderFree) { - LastFreePageHint = Index + 1; + LastFreePageHint = Index + 1 + MmLowestPhysicalPage; break; } } @@ -501,6 +518,7 @@ ULONG Index; StartPage = MmGetPageNumberFromAddress(PageAddress); + StartPage -= MmLowestPhysicalPage; // Make sure they aren't trying to go past the // end of availabe memory

1 0

[cgutman] 52097: [WSOCK32] - Fix the spec file - Fixes FF regression
by cgutman＠svn.reactos.org 05 Jun '11

05 Jun '11

Author: cgutman Date: Sun Jun 5 20:40:57 2011 New Revision: 52097 URL: http://svn.reactos.org/svn/reactos?rev=52097&view=rev Log: [WSOCK32] - Fix the spec file - Fixes FF regression Modified: trunk/reactos/dll/win32/wsock32/wsock32.spec Modified: trunk/reactos/dll/win32/wsock32/wsock32.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wsock32/wsock32.… ============================================================================== --- trunk/reactos/dll/win32/wsock32/wsock32.spec [iso-8859-1] (original) +++ trunk/reactos/dll/win32/wsock32/wsock32.spec [iso-8859-1] Sun Jun 5 20:40:57 2011 @@ -7,9 +7,9 @@ 7 stdcall getsockopt(long long long ptr ptr) ws2_32.getsockopt 8 stdcall htonl(long) ws2_32.htonl 9 stdcall htons(long) ws2_32.htons -10 stdcall ioctlsocket(long long ptr) ws2_32.ioctlsocket -11 stdcall inet_addr(str) ws2_32.inet_addr -12 stdcall inet_ntoa(ptr) ws2_32.inet_ntoa +10 stdcall inet_addr(str) ws2_32.inet_addr +11 stdcall inet_ntoa(ptr) ws2_32.inet_ntoa +12 stdcall ioctlsocket(long long ptr) ws2_32.ioctlsocket 13 stdcall listen(long long) ws2_32.listen 14 stdcall ntohl(long) ws2_32.ntohl 15 stdcall ntohs(long) ws2_32.ntohs

1 0

[akhaldi] 52096: [CMAKE] * Fix msvcrtex unix build.
by akhaldi＠svn.reactos.org 05 Jun '11

05 Jun '11

Author: akhaldi Date: Sun Jun 5 19:44:33 2011 New Revision: 52096 URL: http://svn.reactos.org/svn/reactos?rev=52096&view=rev Log: [CMAKE] * Fix msvcrtex unix build. Modified: trunk/reactos/lib/sdk/crt/msvcrtex.cmake Modified: trunk/reactos/lib/sdk/crt/msvcrtex.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/msvcrtex.cmake… ============================================================================== --- trunk/reactos/lib/sdk/crt/msvcrtex.cmake [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/msvcrtex.cmake [iso-8859-1] Sun Jun 5 19:44:33 2011 @@ -39,7 +39,7 @@ list(APPEND MSVCRTEX_SOURCE except/i386/chkstk_asm.s math/i386/ci.c - math/i386/ftol2_asm.S + math/i386/ftol2_asm.s math/i386/alldiv_asm.s ) endif()

1 0

[akhaldi] 52095: [CMAKE] * Link msvcrtex to chkstk.
by akhaldi＠svn.reactos.org 05 Jun '11

05 Jun '11

Author: akhaldi Date: Sun Jun 5 18:56:29 2011 New Revision: 52095 URL: http://svn.reactos.org/svn/reactos?rev=52095&view=rev Log: [CMAKE] * Link msvcrtex to chkstk. Modified: trunk/reactos/lib/sdk/crt/msvcrtex.cmake Modified: trunk/reactos/lib/sdk/crt/msvcrtex.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/msvcrtex.cmake… ============================================================================== --- trunk/reactos/lib/sdk/crt/msvcrtex.cmake [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/msvcrtex.cmake [iso-8859-1] Sun Jun 5 18:56:29 2011 @@ -55,7 +55,7 @@ set_source_files_properties(startup/crtdll.c PROPERTIES COMPILE_DEFINITIONS CRTDLL) if(NOT MSVC) - target_link_libraries(msvcrtex oldnames) + target_link_libraries(msvcrtex chkstk oldnames) endif() add_dependencies(msvcrtex psdk)

1 0

[akhaldi] 52094: [CMAKE] * Add chkstk library and link crt against it. * Add chkstk_ms.s to libcntpr source files.
by akhaldi＠svn.reactos.org 05 Jun '11

05 Jun '11

Author: akhaldi Date: Sun Jun 5 18:42:09 2011 New Revision: 52094 URL: http://svn.reactos.org/svn/reactos?rev=52094&view=rev Log: [CMAKE] * Add chkstk library and link crt against it. * Add chkstk_ms.s to libcntpr source files. Modified: trunk/reactos/lib/sdk/crt/CMakeLists.txt trunk/reactos/lib/sdk/crt/crt.cmake trunk/reactos/lib/sdk/crt/libcntpr.cmake Modified: trunk/reactos/lib/sdk/crt/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/CMakeLists.txt… ============================================================================== --- trunk/reactos/lib/sdk/crt/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/CMakeLists.txt [iso-8859-1] Sun Jun 5 18:42:09 2011 @@ -2,6 +2,17 @@ include_directories(include) add_definitions(-D_CRTBLD) + +if(ARCH MATCHES i386) + list(APPEND CHKSTK_SOURCE + except/i386/chkstk_asm.s + except/i386/chkstk_ms.s) +elseif(ARCH MATCHES powerpc) + list(APPEND CHKSTK_SOURCE + except/powerpc/chkstk_asm.s) +endif() + +add_library(chkstk ${CHKSTK_SOURCE}) include(crt.cmake) include(libcntpr.cmake) Modified: trunk/reactos/lib/sdk/crt/crt.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/crt.cmake?rev=… ============================================================================== --- trunk/reactos/lib/sdk/crt/crt.cmake [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/crt.cmake [iso-8859-1] Sun Jun 5 18:42:09 2011 @@ -298,7 +298,6 @@ if(ARCH MATCHES i386) list(APPEND CRT_SOURCE - except/i386/chkstk_asm.s except/i386/prolog.s except/i386/seh.s except/i386/seh_prolog.s @@ -311,7 +310,6 @@ setjmp/i386/setjmp.s) elseif(ARCH MATCHES amd64) list(APPEND CRT_SOURCE - except/amd64/chkstk_asm.s except/amd64/seh.s float/i386/clearfp.c float/i386/cntrlfp.c @@ -432,7 +430,7 @@ endif() add_library(crt ${CRT_SOURCE}) - +target_link_libraries(crt chkstk) set_property(TARGET crt PROPERTY COMPILE_DEFINITIONS __MINGW_IMPORT=extern USE_MSVCRT_PREFIX _MSVCRT_LIB_ _MSVCRT_ _MT) add_pch(crt precomp.h) add_dependencies(crt psdk asm) Modified: trunk/reactos/lib/sdk/crt/libcntpr.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/libcntpr.cmake… ============================================================================== --- trunk/reactos/lib/sdk/crt/libcntpr.cmake [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/libcntpr.cmake [iso-8859-1] Sun Jun 5 18:42:09 2011 @@ -65,6 +65,7 @@ if(ARCH MATCHES i386) list(APPEND LIBCNTPR_SOURCE except/i386/chkstk_asm.s + except/i386/chkstk_ms.s except/i386/seh.s except/i386/seh_prolog.s setjmp/i386/setjmp.s

1 0

[akhaldi] 52093: [CMAKE] * Fix cab creation on unix.
by akhaldi＠svn.reactos.org 05 Jun '11

05 Jun '11

Author: akhaldi Date: Sun Jun 5 18:00:09 2011 New Revision: 52093 URL: http://svn.reactos.org/svn/reactos?rev=52093&view=rev Log: [CMAKE] * Fix cab creation on unix. Modified: trunk/reactos/CMakeMacros.cmake Modified: trunk/reactos/CMakeMacros.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/CMakeMacros.cmake?rev=5209… ============================================================================== --- trunk/reactos/CMakeMacros.cmake [iso-8859-1] (original) +++ trunk/reactos/CMakeMacros.cmake [iso-8859-1] Sun Jun 5 18:00:09 2011 @@ -150,7 +150,11 @@ else() #add it in reactos.cab dir_to_num(${_CD_DESTINATION} _num) - file(APPEND ${REACTOS_BINARY_DIR}/boot/bootdata/packages/reactos.dff.dyn "${_CD_FILE} ${_num}\n") + if(CMAKE_HOST_SYSTEM_NAME MATCHES Windows) + file(APPEND ${REACTOS_BINARY_DIR}/boot/bootdata/packages/reactos.dff.dyn "${_CD_FILE} ${_num}\n") + else() + file(APPEND ${REACTOS_BINARY_DIR}/boot/bootdata/packages/reactos.dff.dyn "\"${_CD_FILE}\" ${_num}\n") + endif() if(_CD_TARGET) #manage dependency add_dependencies(reactos_cab ${_CD_TARGET})

1 0

← Newer
1
...
37
38
39
40
41
42
43
...
46
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs June 2011