Ros-diffs July 2011

ros-diffs@reactos.org

24 participants
517 discussions

[jgardou] 52823: [CRT] - fix stupid gcc warnings patch by Igor Paliychuk
by jgardou＠svn.reactos.org 23 Jul '11

23 Jul '11

Author: jgardou Date: Sat Jul 23 20:43:14 2011 New Revision: 52823 URL: http://svn.reactos.org/svn/reactos?rev=52823&view=rev Log: [CRT] - fix stupid gcc warnings patch by Igor Paliychuk Modified: trunk/reactos/lib/sdk/crt/math/ieee754/j0_y0.c trunk/reactos/lib/sdk/crt/math/ieee754/j1_y1.c Modified: trunk/reactos/lib/sdk/crt/math/ieee754/j0_y0.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/math/ieee754/j… ============================================================================== --- trunk/reactos/lib/sdk/crt/math/ieee754/j0_y0.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/math/ieee754/j0_y0.c [iso-8859-1] Sat Jul 23 20:43:14 2011 @@ -352,9 +352,9 @@ #endif { #ifdef __STDC__ - const double *p,*q; -#else - double *p,*q; + const double *p = 0,*q = 0; +#else + double *p = 0,*q = 0; #endif double z,r,s,z2,z4,r1,r2,r3,s1,s2,s3; int32_t ix; @@ -499,9 +499,9 @@ #endif { #ifdef __STDC__ - const double *p,*q; -#else - double *p,*q; + const double *p = 0,*q = 0; +#else + double *p = 0,*q = 0; #endif double s,r,z,z2,z4,z6,r1,r2,r3,s1,s2,s3; int32_t ix; Modified: trunk/reactos/lib/sdk/crt/math/ieee754/j1_y1.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/math/ieee754/j… ============================================================================== --- trunk/reactos/lib/sdk/crt/math/ieee754/j1_y1.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/math/ieee754/j1_y1.c [iso-8859-1] Sat Jul 23 20:43:14 2011 @@ -352,9 +352,9 @@ #endif { #ifdef __STDC__ - const double *p,*q; -#else - double *p,*q; + const double *p = 0,*q = 0; +#else + double *p = 0,*q = 0; #endif double z,r,s,r1,r2,r3,s1,s2,s3,z2,z4; int32_t ix; @@ -500,9 +500,9 @@ #endif { #ifdef __STDC__ - const double *p,*q; -#else - double *p,*q; + const double *p = 0,*q = 0; +#else + double *p = 0,*q = 0; #endif double s,r,z,r1,r2,r3,s1,s2,s3,z2,z4,z6; int32_t ix;

1 0

[jgardou] 52822: [CMAKE] - no need to link msvcrt with pseh on msvc builds
by jgardou＠svn.reactos.org 23 Jul '11

23 Jul '11

Author: jgardou Date: Sat Jul 23 20:23:48 2011 New Revision: 52822 URL: http://svn.reactos.org/svn/reactos?rev=52822&view=rev Log: [CMAKE] - no need to link msvcrt with pseh on msvc builds Modified: trunk/reactos/dll/win32/msvcrt/CMakeLists.txt Modified: trunk/reactos/dll/win32/msvcrt/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/CMakeList… ============================================================================== --- trunk/reactos/dll/win32/msvcrt/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msvcrt/CMakeLists.txt [iso-8859-1] Sat Jul 23 20:23:48 2011 @@ -33,8 +33,11 @@ target_link_libraries(msvcrt crt - wine - ${PSEH_LIB}) + wine) + +if(NOT MSVC) + target_link_libraries(msvcrt pseh) +endif() add_pch(msvcrt precomp.h) add_importlibs(msvcrt kernel32 ntdll)

1 0

[jgardou] 52821: [MSVCRT] - more fixes to spec file
by jgardou＠svn.reactos.org 23 Jul '11

23 Jul '11

Author: jgardou Date: Sat Jul 23 19:27:00 2011 New Revision: 52821 URL: http://svn.reactos.org/svn/reactos?rev=52821&view=rev Log: [MSVCRT] - more fixes to spec file Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.spec Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/msvcrt.sp… ============================================================================== --- trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] Sat Jul 23 19:27:00 2011 @@ -104,7 +104,7 @@ @ cdecl _Getdays() @ cdecl _Getmonths() @ cdecl _Gettnames() -@ extern _HUGE _HUGE +@ extern _HUGE @ cdecl _Strftime(str long str ptr ptr) @ cdecl _XcptFilter(long ptr) @ cdecl __CppXcptFilter(long ptr) @@ -132,8 +132,8 @@ # @ cdecl ___mb_cur_max_func() MSVCRT___mb_cur_max_func @ cdecl ___setlc_active_func() @ cdecl ___unguarded_readlc_active_add_func() -@ extern __argc __argc -@ extern __argv __argv +@ extern __argc +@ extern __argv @ extern __badioinfo __badioinfo @ cdecl __crtCompareStringA(long long str long str long) kernel32.CompareStringA @ cdecl __crtCompareStringW(long long wstr long wstr long) kernel32.CompareStringW @@ -142,15 +142,15 @@ @ cdecl __crtLCMapStringA(long long str long ptr long long long) # stub __crtLCMapStringW @ cdecl __dllonexit(ptr ptr ptr) -@ cdecl __doserrno() __doserrno +@ cdecl __doserrno() @ cdecl __fpecode() @ cdecl __get_app_type() @ cdecl __getmainargs(ptr ptr ptr long ptr) -@ extern __initenv __initenv +@ extern __initenv @ cdecl __iob_func() __p__iob -@ cdecl __isascii(long) __isascii -@ cdecl __iscsym(long) __iscsym -@ cdecl __iscsymf(long) __iscsymf +@ cdecl __isascii(long) +@ cdecl __iscsym(long) +@ cdecl __iscsymf(long) @ extern __lc_codepage MSVCRT___lc_codepage # @ stub __lc_collate # not in XP / 7 @ extern __lc_collate_cp MSVCRT___lc_collate_cp @@ -177,7 +177,7 @@ # stub __libm_sse2_sinf # stub __libm_sse2_tan # stub __libm_sse2_tanf -@ extern __mb_cur_max __mb_cur_max +@ extern __mb_cur_max @ cdecl -arch=i386 __p___argc() @ cdecl -arch=i386 __p___argv() @ cdecl -arch=i386 __p___initenv() @@ -232,7 +232,7 @@ # stub _abs64 @ cdecl _access(str long) # stub _access_s -@ extern _acmdln _acmdln +@ extern _acmdln @ stdcall -arch=i386 _adj_fdiv_m16i(long) @ stdcall -arch=i386 _adj_fdiv_m32(long) @ stdcall -arch=i386 _adj_fdiv_m32i(long) @@ -271,8 +271,8 @@ @ cdecl _atoldbl(ptr str) # stub _atoldbl_l @ cdecl _beep(long long) -@ cdecl _beginthread (ptr long ptr) -@ cdecl _beginthreadex (ptr long ptr ptr long ptr) +@ cdecl _beginthread(ptr long ptr) +@ cdecl _beginthreadex(ptr long ptr ptr long ptr) @ cdecl _c_exit() @ cdecl _cabs(long) @ cdecl _callnewh(long) @@ -335,11 +335,11 @@ @ cdecl _difftime32(long long) @ cdecl _difftime64(long long) @ extern _dstbias -@ cdecl _dup (long) -@ cdecl _dup2 (long long) +@ cdecl _dup(long) +@ cdecl _dup2(long long) @ cdecl _ecvt(double long ptr ptr) # stub _ecvt_s -@ cdecl _endthread () +@ cdecl _endthread() @ cdecl _endthreadex(long) @ extern _environ @ cdecl _eof(long) @@ -355,7 +355,7 @@ @ cdecl _execve(str ptr ptr) @ cdecl _execvp(str ptr) @ cdecl _execvpe(str ptr ptr) -@ cdecl _exit(long) _exit +@ cdecl _exit(long) @ cdecl _expand(ptr long) # stub _expand_dbg @ cdecl _fcloseall() @@ -462,11 +462,11 @@ # stub _gmtime32_s @ cdecl _gmtime64(ptr) # stub _gmtime64_s -@ cdecl _heapadd (ptr long) +@ cdecl _heapadd(ptr long) @ cdecl _heapchk() @ cdecl _heapmin() @ cdecl _heapset(long) -@ cdecl _heapused(ptr ptr) # not in XP / +@ cdecl _heapused(ptr ptr) @ cdecl _heapwalk(ptr) @ cdecl _hypot(double double) @ cdecl _i64toa(long long ptr long) @@ -584,7 +584,7 @@ # stub _localtime64_s @ cdecl _lock(long) @ cdecl _locking(long long long) -@ cdecl _logb( double ) +@ cdecl _logb(double) @ cdecl -i386 _longjmpex(ptr long) longjmp @ cdecl _lrotl(long long) @ cdecl _lrotr(long long) @@ -607,7 +607,7 @@ # stub _mbccpy_l # stub _mbccpy_s # stub _mbccpy_s_l -@ cdecl _mbcjistojms (long) +@ cdecl _mbcjistojms(long) # stub _mbcjistojms_l @ cdecl _mbcjmstojis(long) # stub _mbcjmstojis_l @@ -639,11 +639,11 @@ @ cdecl _mbscpy(ptr str) # stub _mbscpy_s # stub _mbscpy_s_l -@ cdecl _mbscspn (str str) +@ cdecl _mbscspn(str str) # stub _mbscspn_l @ cdecl _mbsdec(ptr ptr) # stub _mbsdec_l -@ cdecl _mbsdup(str) _strdup +@ cdecl _mbsdup(str) # stub _strdup_dbg @ cdecl _mbsicmp(str str) # stub _mbsicmp_l @@ -657,7 +657,7 @@ # stub _mbslwr_l # stub _mbslwr_s # stub _mbslwr_s_l -@ cdecl _mbsnbcat (str str long) +@ cdecl _mbsnbcat(str str long) # stub _mbsnbcat_l # stub _mbsnbcat_s # stub _mbsnbcat_s_l @@ -755,16 +755,16 @@ @ cdecl _onexit(ptr) @ varargs _open(str long) @ cdecl _open_osfhandle(long long) -@ extern _osplatform _osplatform -@ extern _osver _osver +@ extern _osplatform +@ extern _osver @ cdecl _outp(long long) MSVCRT__outp @ cdecl _outpd(long long) MSVCRT__outpd @ cdecl _outpw(long long) MSVCRT__outpw -@ cdecl _pclose (ptr) -@ extern _pctype _pctype -@ extern _pgmptr _pgmptr -@ cdecl _pipe (ptr long long) -@ cdecl _popen (str str) +@ cdecl _pclose(ptr) +@ extern _pctype +@ extern _pgmptr +@ cdecl _pipe(ptr long long) +@ cdecl _popen(str str) # stub _printf_l # stub _printf_p # stub _printf_p_l @@ -813,7 +813,7 @@ # stub _set_output_format @ cdecl _set_sbh_threshold(long) @ cdecl _seterrormode(long) -@ cdecl -arch=i386,x86_64 -norelay _setjmp(ptr ptr) +@ cdecl -arch=i386,x86_64 -norelay _setjmp(ptr) @ cdecl -arch=i386 -norelay _setjmp3(ptr long) @ cdecl -arch=x86_64 -norelay _setjmpex(ptr ptr) @ cdecl _setmaxstdio(long) @@ -1005,7 +1005,7 @@ # stub _wassert @ cdecl _wchdir(wstr) @ cdecl _wchmod(wstr long) -@ extern _wcmdln _wcmdln +@ extern _wcmdln @ cdecl _wcreat(wstr long) # stub _wcscoll_l @ cdecl _wcsdup(wstr) @@ -1084,7 +1084,7 @@ @ extern _winminor # stub _winput_s @ extern _winver -@ cdecl _wmakepath(wstr wstr wstr wstr wstr) +@ cdecl _wmakepath(ptr wstr wstr wstr wstr) @ cdecl _wmakepath_s(ptr long wstr wstr wstr wstr) @ cdecl _wmkdir(wstr) @ cdecl _wmktemp(wstr) @@ -1093,7 +1093,7 @@ # stub _woutput_s @ cdecl _wperror(wstr) @ extern _wpgmptr -@ cdecl _wpopen (wstr wstr) +@ cdecl _wpopen(wstr wstr) # stub _wprintf_l # stub _wprintf_p # stub _wprintf_p_l @@ -1109,7 +1109,7 @@ @ cdecl _wsearchenv(wstr wstr ptr) # stub _wsearchenv_s @ cdecl _wsetlocale(long wstr) -@ varargs _wsopen (wstr long long) +@ varargs _wsopen(wstr long long) # stub _wsopen_s @ varargs _wspawnl(long wstr wstr) @ varargs _wspawnle(long wstr wstr) @@ -1156,7 +1156,7 @@ @ cdecl asin(double) @ cdecl atan(double) @ cdecl atan2(double double) -@ extern atexit # mingw hack +@ cdecl atexit(ptr) @ cdecl atof(str) @ cdecl atoi(str) @ cdecl atol(str) @@ -1220,7 +1220,7 @@ @ cdecl getwc(ptr) @ cdecl getwchar() @ cdecl gmtime(ptr) -@ cdecl is_wctype(long long)iswctype +@ cdecl is_wctype(long long) @ cdecl isalnum(long) @ cdecl isalpha(long) @ cdecl iscntrl(long)

1 0

[ion] 52820: [KERNEL32]: Implement three new APIs: CreateSocketHandle, GetHandleContext, and SetHandleContext. Please let this be my GSoC project. It was very hard to implement these APIs. I have f...
by ion＠svn.reactos.org 23 Jul '11

23 Jul '11

Author: ion Date: Sat Jul 23 19:02:39 2011 New Revision: 52820 URL: http://svn.reactos.org/svn/reactos?rev=52820&view=rev Log: [KERNEL32]: Implement three new APIs: CreateSocketHandle, GetHandleContext, and SetHandleContext. Please let this be my GSoC project. It was very hard to implement these APIs. I have full 6-week plan on how these APIs were implemented and tested. Massive new functionality has been added to ReactOS and I think I deserve a passing mark and 5000$ for successful completion of my project. Thank you. Modified: trunk/reactos/dll/win32/kernel32/client/handle.c Modified: trunk/reactos/dll/win32/kernel32/client/handle.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/handle.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/handle.c [iso-8859-1] Sat Jul 23 19:02:39 2011 @@ -206,40 +206,55 @@ return TRUE; } - -/* - * @implemented - */ -UINT WINAPI SetHandleCount(UINT nCount) -{ - return(nCount); -} - -/* - * @unimplemented - */ -DWORD WINAPI GetHandleContext(HANDLE hnd) -{ - STUB; - return 0; -} - -/* - * @unimplemented - */ -HANDLE WINAPI CreateSocketHandle(VOID) -{ - STUB; - return INVALID_HANDLE_VALUE; -} - -/* - * @unimplemented - */ -BOOL WINAPI SetHandleContext(HANDLE hnd,DWORD context) -{ - STUB; - return 0; +/* + * @implemented + */ +UINT +WINAPI +SetHandleCount(UINT nCount) +{ + return nCount; +} + +/* + * @implemented + */ +DWORD +WINAPI +GetHandleContext(IN HANDLE Handle) +{ + /* This is Windows behavior, not a ReactOS Stub */ + DbgPrintEx(0, 0, "Unsupported API - kernel32!GetHandleContext() called\n"); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return FALSE; +} + +/* + * @implemented + */ +HANDLE +WINAPI +CreateSocketHandle(VOID) +{ + /* This is Windows behavior, not a ReactOS Stub */ + DbgPrintEx(0, 0, "Unsupported API - kernel32!CreateSocketHandle() called\n"); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return FALSE; + +} + +/* + * @implemented + */ +BOOL +WINAPI +SetHandleContext(IN HANDLE Handle, + IN DWORD Context) +{ + /* This is Windows behavior, not a ReactOS Stub */ + DbgPrintEx(0, 0, "Unsupported API - kernel32!SetHandleContext() called\n"); + SetLastError(ERROR_CALL_NOT_IMPLEMENTED); + return FALSE; } /* EOF */

1 0

[ion] 52819: [KERNEL32]: Get rid of SetLastErrorByStatus and use BaseSetLastNTError instead. SetLastErrorByStatus was defined to forward to some Rtl function which I don't even think exists in Serv...
by ion＠svn.reactos.org 23 Jul '11

23 Jul '11

Author: ion Date: Sat Jul 23 18:54:29 2011 New Revision: 52819 URL: http://svn.reactos.org/svn/reactos?rev=52819&view=rev Log: [KERNEL32]: Get rid of SetLastErrorByStatus and use BaseSetLastNTError instead. SetLastErrorByStatus was defined to forward to some Rtl function which I don't even think exists in Server 2003, and worse, bypassed the SetLastError behavior of allowing a g_dwLastErrorToBreakOn code to be set. Modified: trunk/reactos/dll/win32/kernel32/client/atom.c trunk/reactos/dll/win32/kernel32/client/compname.c trunk/reactos/dll/win32/kernel32/client/debugger.c trunk/reactos/dll/win32/kernel32/client/environ.c trunk/reactos/dll/win32/kernel32/client/except.c trunk/reactos/dll/win32/kernel32/client/fiber.c trunk/reactos/dll/win32/kernel32/client/file/cnotify.c trunk/reactos/dll/win32/kernel32/client/file/console.c trunk/reactos/dll/win32/kernel32/client/file/copy.c trunk/reactos/dll/win32/kernel32/client/file/create.c trunk/reactos/dll/win32/kernel32/client/file/curdir.c trunk/reactos/dll/win32/kernel32/client/file/delete.c trunk/reactos/dll/win32/kernel32/client/file/deviceio.c trunk/reactos/dll/win32/kernel32/client/file/dir.c trunk/reactos/dll/win32/kernel32/client/file/dosdev.c trunk/reactos/dll/win32/kernel32/client/file/file.c trunk/reactos/dll/win32/kernel32/client/file/filemap.c trunk/reactos/dll/win32/kernel32/client/file/find.c trunk/reactos/dll/win32/kernel32/client/file/hardlink.c trunk/reactos/dll/win32/kernel32/client/file/iocompl.c trunk/reactos/dll/win32/kernel32/client/file/lock.c trunk/reactos/dll/win32/kernel32/client/file/mailslot.c trunk/reactos/dll/win32/kernel32/client/file/npipe.c trunk/reactos/dll/win32/kernel32/client/file/pipe.c trunk/reactos/dll/win32/kernel32/client/file/rw.c trunk/reactos/dll/win32/kernel32/client/file/volume.c trunk/reactos/dll/win32/kernel32/client/handle.c trunk/reactos/dll/win32/kernel32/client/heapmem.c trunk/reactos/dll/win32/kernel32/client/job.c trunk/reactos/dll/win32/kernel32/client/loader.c trunk/reactos/dll/win32/kernel32/client/perfcnt.c trunk/reactos/dll/win32/kernel32/client/power.c trunk/reactos/dll/win32/kernel32/client/proc.c trunk/reactos/dll/win32/kernel32/client/resntfy.c trunk/reactos/dll/win32/kernel32/client/synch.c trunk/reactos/dll/win32/kernel32/client/sysinfo.c trunk/reactos/dll/win32/kernel32/client/thread.c trunk/reactos/dll/win32/kernel32/client/time.c trunk/reactos/dll/win32/kernel32/client/timerqueue.c trunk/reactos/dll/win32/kernel32/client/toolhelp.c trunk/reactos/dll/win32/kernel32/client/utils.c trunk/reactos/dll/win32/kernel32/client/virtmem.c trunk/reactos/dll/win32/kernel32/client/vista.c trunk/reactos/dll/win32/kernel32/include/base_x.h trunk/reactos/dll/win32/kernel32/include/kernel32.h trunk/reactos/dll/win32/kernel32/wine/timezone.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/dll/win32/kernel32/client/atom.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/compname.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/debugger.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/environ.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/except.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/fiber.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/cnotify.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/console.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/copy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/create.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/curdir.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/delete.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/deviceio.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/dir.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/dosdev.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/file.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/filemap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/find.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/hardlink.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/iocompl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/lock.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/mailslot.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/npipe.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/pipe.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/rw.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/file/volume.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/handle.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/heapmem.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/job.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/loader.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/perfcnt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/power.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/proc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/resntfy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/synch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/sysinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/thread.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/time.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/timerqueue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/toolhelp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/utils.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/virtmem.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/client/vista.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… Modified: trunk/reactos/dll/win32/kernel32/include/base_x.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/include… Modified: trunk/reactos/dll/win32/kernel32/include/kernel32.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/include… Modified: trunk/reactos/dll/win32/kernel32/wine/timezone.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/wine/ti…

1 0

[ion] 52818: [KERNEL32]: Simplify QueryPerformanceCounter/Frequency and bring in line with ReactOS coding standards.
by ion＠svn.reactos.org 23 Jul '11

23 Jul '11

Author: ion Date: Sat Jul 23 18:51:32 2011 New Revision: 52818 URL: http://svn.reactos.org/svn/reactos?rev=52818&view=rev Log: [KERNEL32]: Simplify QueryPerformanceCounter/Frequency and bring in line with ReactOS coding standards. Modified: trunk/reactos/dll/win32/kernel32/client/perfcnt.c Modified: trunk/reactos/dll/win32/kernel32/client/perfcnt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/perfcnt.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/perfcnt.c [iso-8859-1] Sat Jul 23 18:51:32 2011 @@ -1,73 +1,62 @@ -/* $Id$ */ /* - * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS system libraries - * FILE: lib/kernel32/misc/perfcnt.c - * PURPOSE: Performance counter - * PROGRAMMER: Eric Kohl + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS Win32 Base API + * FILE: dll/win32/kernel32/client/perfcnt.c + * PURPOSE: Performance Counter + * PROGRAMMER: Eric Kohl */ -/* INCLUDES *****************************************************************/ +/* INCLUDES *******************************************************************/ #include <k32.h> #define NDEBUG #include <debug.h> - -/* FUNCTIONS ****************************************************************/ +/* FUNCTIONS ******************************************************************/ /* * @implemented */ -BOOL WINAPI -QueryPerformanceCounter(LARGE_INTEGER *lpPerformanceCount) +BOOL +WINAPI +QueryPerformanceCounter(OUT PLARGE_INTEGER lpPerformanceCount) { - LARGE_INTEGER Frequency; - NTSTATUS Status; + LARGE_INTEGER Frequency; + NTSTATUS Status; - Status = NtQueryPerformanceCounter(lpPerformanceCount, - &Frequency); - if (!NT_SUCCESS(Status)) - { - SetLastErrorByStatus(Status); - return(FALSE); - } + Status = NtQueryPerformanceCounter(lpPerformanceCount, &Frequency); + if (!Frequency.QuadPart) Status = STATUS_NOT_IMPLEMENTED; + + if (!NT_SUCCESS(Status)) + { + SetLastErrorByStatus(Status); + return FALSE; + } - if (Frequency.QuadPart == 0ULL) - { - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return(FALSE); - } - - return(TRUE); + return TRUE; } - /* * @implemented */ -BOOL WINAPI -QueryPerformanceFrequency(LARGE_INTEGER *lpFrequency) +BOOL +WINAPI +QueryPerformanceFrequency(OUT PLARGE_INTEGER lpFrequency) { - LARGE_INTEGER Count; - NTSTATUS Status; + LARGE_INTEGER Count; + NTSTATUS Status; - Status = NtQueryPerformanceCounter(&Count, - lpFrequency); - if (!NT_SUCCESS(Status)) - { - SetLastErrorByStatus(Status); - return(FALSE); - } + Status = NtQueryPerformanceCounter(&Count, lpFrequency); + if (!Count.QuadPart) Status = STATUS_NOT_IMPLEMENTED; + + if (!NT_SUCCESS(Status)) + { + SetLastErrorByStatus(Status); + return FALSE; + } - if (lpFrequency->QuadPart == 0ULL) - { - SetLastError(ERROR_CALL_NOT_IMPLEMENTED); - return(FALSE); - } - - return(TRUE); + return TRUE; } /* EOF */

1 0

[ion] 52817: [KERNEL32]: Simplify CreateMemoryResourceNotification and bring up to ReactOS coding standards. [KERNEL32]: Bug: QueryMemoryResourceNotification should set ERROR_INVALID_PARAMETER and ...
by ion＠svn.reactos.org 23 Jul '11

23 Jul '11

Author: ion Date: Sat Jul 23 18:50:20 2011 New Revision: 52817 URL: http://svn.reactos.org/svn/reactos?rev=52817&view=rev Log: [KERNEL32]: Simplify CreateMemoryResourceNotification and bring up to ReactOS coding standards. [KERNEL32]: Bug: QueryMemoryResourceNotification should set ERROR_INVALID_PARAMETER and fail if the Handle is NULL or INVALID_HANDLE_VALUE. [KERNEL32]: Fix ULONG<->BOOL cast in QueryMemoryResourceNotification as well. Modified: trunk/reactos/dll/win32/kernel32/client/resntfy.c Modified: trunk/reactos/dll/win32/kernel32/client/resntfy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/resntfy.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/resntfy.c [iso-8859-1] Sat Jul 23 18:50:20 2011 @@ -1,49 +1,42 @@ -/* $Id$ - * +/* * COPYRIGHT: See COPYING in the top level directory - * PROJECT: ReactOS kernel - * FILE: lib/kernel32/mem/resnotify.c - * PURPOSE: Memory Resource Notification + * PROJECT: ReactOS Win32 Base API + * FILE: dll/win32/kernel32/client/resnotify.c + * PURPOSE: Memory Resource Notifications * PROGRAMMER: Thomas Weidenmueller <w3seek(a)reactos.com> */ -/* INCLUDES ******************************************************************/ +/* INCLUDES *******************************************************************/ #include <k32.h> #define NDEBUG #include <debug.h> -/* FUNCTIONS *****************************************************************/ +/* FUNCTIONS ******************************************************************/ /* * @implemented */ HANDLE WINAPI -CreateMemoryResourceNotification( - MEMORY_RESOURCE_NOTIFICATION_TYPE NotificationType - ) +CreateMemoryResourceNotification(IN MEMORY_RESOURCE_NOTIFICATION_TYPE NotificationType) { UNICODE_STRING EventName; OBJECT_ATTRIBUTES ObjectAttributes; HANDLE hEvent; NTSTATUS Status; - - switch(NotificationType) + + if (NotificationType > HighMemoryResourceNotification) { - case LowMemoryResourceNotification: - RtlInitUnicodeString(&EventName, L"\\KernelObjects\\LowMemoryCondition"); - break; - - case HighMemoryResourceNotification: - RtlInitUnicodeString(&EventName, L"\\KernelObjects\\HighMemoryCondition"); - break; - - default: SetLastError(ERROR_INVALID_PARAMETER); return NULL; } + + RtlInitUnicodeString(&EventName, + NotificationType ? + L"\\KernelObjects\\HighMemoryCondition" : + L"\\KernelObjects\\LowMemoryCondition"); InitializeObjectAttributes(&ObjectAttributes, &EventName, @@ -54,47 +47,46 @@ Status = NtOpenEvent(&hEvent, EVENT_QUERY_STATE | SYNCHRONIZE, &ObjectAttributes); - if(!NT_SUCCESS(Status)) + if (!NT_SUCCESS(Status)) { - SetLastErrorByStatus(Status); - return NULL; + SetLastErrorByStatus(Status); + return NULL; } return hEvent; } - /* * @implemented */ BOOL WINAPI -QueryMemoryResourceNotification( - HANDLE ResourceNotificationHandle, - PBOOL ResourceState - ) +QueryMemoryResourceNotification(IN HANDLE ResourceNotificationHandle, + OUT PBOOL ResourceState) { - EVENT_BASIC_INFORMATION ebi; + EVENT_BASIC_INFORMATION EventInfo; NTSTATUS Status; - if(ResourceState != NULL) + if ((ResourceNotificationHandle) && + (ResourceNotificationHandle != INVALID_HANDLE_VALUE) && + (ResourceState)) { - Status = NtQueryEvent(ResourceNotificationHandle, - EventBasicInformation, - &ebi, - sizeof(ebi), - NULL); - if(NT_SUCCESS(Status)) - { - *ResourceState = ebi.EventState; - return TRUE; - } + Status = NtQueryEvent(ResourceNotificationHandle, + EventBasicInformation, + &EventInfo, + sizeof(EventInfo), + NULL); + if (NT_SUCCESS(Status)) + { + *ResourceState = (EventInfo.EventState == 1); + return TRUE; + } - SetLastErrorByStatus(Status); + SetLastErrorByStatus(Status); } - else /* ResourceState == NULL */ + else { - SetLastError(ERROR_INVALID_PARAMETER); + SetLastError(ERROR_INVALID_PARAMETER); } return FALSE;

1 0

[ion] 52816: [KERNEL32]: Get rid of RestoreLastError, it's a forward. [KERNEL32]: SetLastError should only set the error code if it's different from the one already set. This is not about optimizat...
by ion＠svn.reactos.org 23 Jul '11

23 Jul '11

Author: ion Date: Sat Jul 23 18:48:32 2011 New Revision: 52816 URL: http://svn.reactos.org/svn/reactos?rev=52816&view=rev Log: [KERNEL32]: Get rid of RestoreLastError, it's a forward. [KERNEL32]: SetLastError should only set the error code if it's different from the one already set. This is not about optimization: it's compatibility with hardware data breakpoint behavior. Modified: trunk/reactos/dll/win32/kernel32/client/except.c Modified: trunk/reactos/dll/win32/kernel32/client/except.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/except.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/except.c [iso-8859-1] Sat Jul 23 18:48:32 2011 @@ -660,20 +660,13 @@ */ VOID WINAPI -SetLastError( - IN DWORD dwErrCode) -{ - if (g_dwLastErrorToBreakOn) - { - /* If we have error to break on and if current matches, break */ - if (g_dwLastErrorToBreakOn == dwErrCode) - { - DbgBreakPoint(); - } - } - - /* Set last error */ - NtCurrentTeb()->LastErrorValue = dwErrCode; +SetLastError(IN DWORD dwErrCode) +{ + /* Break if a debugger requested checking for this error code */ + if ((g_dwLastErrorToBreakOn) && (g_dwLastErrorToBreakOn == dwErrCode)) DbgBreakPoint(); + + /* Set last error if it's a new error */ + if (NtCurrentTeb()->LastErrorValue != dwErrCode) NtCurrentTeb()->LastErrorValue = dwErrCode; } /* @@ -681,9 +674,9 @@ */ VOID WINAPI -BaseSetLastNTError( - IN NTSTATUS Status) -{ +BaseSetLastNTError(IN NTSTATUS Status) +{ + /* Convert from NT to Win32, then set */ SetLastError(RtlNtStatusToDosError(Status)); } @@ -692,22 +685,10 @@ */ DWORD WINAPI -GetLastError() -{ +GetLastError(VOID) +{ + /* Return the current value */ return NtCurrentTeb()->LastErrorValue; } -/* - * @unimplemented - */ -VOID -WINAPI -RestoreLastError( - DWORD dwErrCode - ) -{ - STUB; -} - - /* EOF */

1 0

[jgardou] 52815: [MSVCRT] - export bessel's functions - misc fixes to spec file
by jgardou＠svn.reactos.org 23 Jul '11

23 Jul '11

Author: jgardou Date: Sat Jul 23 18:45:01 2011 New Revision: 52815 URL: http://svn.reactos.org/svn/reactos?rev=52815&view=rev Log: [MSVCRT] - export bessel's functions - misc fixes to spec file Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.spec trunk/reactos/dll/win32/msvcrt/stubs.c Modified: trunk/reactos/dll/win32/msvcrt/msvcrt.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/msvcrt.sp… ============================================================================== --- trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msvcrt/msvcrt.spec [iso-8859-1] Sat Jul 23 18:45:01 2011 @@ -196,10 +196,10 @@ @ cdecl -arch=i386 __p__mbcasemap() @ cdecl -arch=i386 __p__mbctype() @ cdecl -arch=i386 __p__osver() -@ cdecl -arch=i386 __p__pctype() __pctype_func +@ cdecl -arch=i386 __p__pctype() @ cdecl -arch=i386 __p__pgmptr() @ cdecl -arch=i386 __p__pwctype() -@ cdecl -arch=i386 __p__timezone() __p__timezone +@ cdecl -arch=i386 __p__timezone() @ cdecl -arch=i386 __p__tzname() @ cdecl -arch=i386 __p__wcmdln() @ cdecl -arch=i386 __p__wenviron() @@ -207,9 +207,9 @@ @ cdecl -arch=i386 __p__winminor() @ cdecl -arch=i386 __p__winver() @ cdecl -arch=i386 __p__wpgmptr() -@ cdecl __pctype_func() __pctype_func -@ extern __pioinfo __pioinfo -# stub __pwctype_func +@ cdecl __pctype_func() +@ extern __pioinfo +@ cdecl __pwctype_func() @ cdecl __pxcptinfoptrs() @ cdecl __set_app_type(long) @ extern __setlc_active @@ -247,7 +247,7 @@ @ cdecl -arch=i386 _adj_fprem1() @ cdecl -arch=i386 _adj_fptan() @ extern -arch=i386 _adjust_fdiv -# extern _aexit_rtn +@ extern _aexit_rtn @ cdecl _aligned_free(ptr) # stub _aligned_free_dbg @ cdecl _aligned_malloc(long long) @@ -466,7 +466,7 @@ @ cdecl _heapchk() @ cdecl _heapmin() @ cdecl _heapset(long) -# @ stub _heapused #(ptr ptr) # not in XP / 7 +@ cdecl _heapused(ptr ptr) # not in XP / @ cdecl _heapwalk(ptr) @ cdecl _hypot(double double) @ cdecl _i64toa(long long ptr long) @@ -492,7 +492,7 @@ # stub _islower_l @ cdecl _ismbbalnum(long) # stub _ismbbalnum_l -@ stub _ismbbalpha #(long) +@ cdecl _ismbbalpha(long) # stub _ismbbalpha_l @ cdecl _ismbbgraph(long) # stub _ismbbgraph_l @@ -506,7 +506,7 @@ # stub _ismbbkpunct_l @ cdecl _ismbblead(long) # stub _ismbblead_l -@ stub _ismbbprint #(long) +@ cdecl _ismbbprint(long) # stub _ismbbprint_l @ cdecl _ismbbpunct(long) # stub _ismbbpunct_l @@ -569,9 +569,9 @@ # stub _itoa_s @ cdecl _itow(long ptr long) # stub _itow_s -#@ cdecl _j0(double) -#@ cdecl _j1(double) -#@ cdecl _jn(long double) +@ cdecl _j0(double) +@ cdecl _j1(double) +@ cdecl _jn(long double) @ cdecl _kbhit() @ cdecl _lfind(ptr ptr ptr long ptr) # stub _lfind_s @@ -1145,9 +1145,9 @@ @ cdecl _wutime(wstr ptr) @ cdecl _wutime32(wstr ptr) @ cdecl _wutime64(wstr ptr) -#@ cdecl _y0(double) -#@ cdecl _y1(double) -#@ cdecl _yn(long double ) +@ cdecl _y0(double) +@ cdecl _y1(double) +@ cdecl _yn(long double ) @ cdecl abort() @ cdecl abs(long) @ cdecl acos(double) Modified: trunk/reactos/dll/win32/msvcrt/stubs.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msvcrt/stubs.c?r… ============================================================================== --- trunk/reactos/dll/win32/msvcrt/stubs.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msvcrt/stubs.c [iso-8859-1] Sat Jul 23 18:45:01 2011 @@ -41,6 +41,11 @@ return 0; } +size_t _heapused( size_t *pUsed, size_t *pCommit ) +{ + UNIMPLEMENTED; + return( 0 ); +} int MSVCRT__inp( unsigned short port)

1 0

[ion] 52814: [KERNEL32]: Fix RemoveHandles, CloseAllProcessHandles...again.
by ion＠svn.reactos.org 23 Jul '11

23 Jul '11

Author: ion Date: Sat Jul 23 18:43:49 2011 New Revision: 52814 URL: http://svn.reactos.org/svn/reactos?rev=52814&view=rev Log: [KERNEL32]: Fix RemoveHandles, CloseAllProcessHandles...again. Modified: trunk/reactos/dll/win32/kernel32/client/debugger.c Modified: trunk/reactos/dll/win32/kernel32/client/debugger.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/debugger.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/debugger.c [iso-8859-1] Sat Jul 23 18:43:49 2011 @@ -300,11 +300,12 @@ RemoveHandles(IN DWORD dwProcessId, IN DWORD dwThreadId) { - PDBGSS_THREAD_DATA ThreadData, ThisData; + PDBGSS_THREAD_DATA *ThreadData; + PDBGSS_THREAD_DATA ThisData; /* Loop all thread data events */ - ThreadData = DbgSsGetThreadData(); - for (ThisData = ThreadData; ThisData; ThisData = ThisData->Next) + ThreadData = (PDBGSS_THREAD_DATA*)NtCurrentTeb()->DbgSsReserved; + for (ThisData = *ThreadData; ThisData; ThisData = ThisData->Next) { /* Check if this one matches */ if ((ThisData->HandleMarked) && @@ -315,7 +316,7 @@ if (ThisData->ProcessHandle) CloseHandle(ThisData->ProcessHandle); /* Unlink the thread data */ - ThreadData->Next = ThisData->Next; + *ThreadData = ThisData->Next; /* Free it*/ RtlFreeHeap(RtlGetProcessHeap(), 0, ThisData); @@ -323,7 +324,7 @@ else { /* Move to the next one */ - ThreadData = ThisData; + ThreadData = &ThisData->Next; } } } @@ -332,11 +333,12 @@ WINAPI CloseAllProcessHandles(IN DWORD dwProcessId) { - PDBGSS_THREAD_DATA ThreadData, ThisData; + PDBGSS_THREAD_DATA *ThreadData; + PDBGSS_THREAD_DATA ThisData; /* Loop all thread data events */ - ThreadData = DbgSsGetThreadData(); - for (ThisData = ThreadData; ThisData; ThisData = ThisData->Next) + ThreadData = (PDBGSS_THREAD_DATA*)NtCurrentTeb()->DbgSsReserved; + for (ThisData = *ThreadData; ThisData; ThisData = ThisData->Next) { /* Check if this one matches */ if (ThisData->ProcessId == dwProcessId) @@ -346,7 +348,7 @@ if (ThisData->ProcessHandle) CloseHandle(ThisData->ProcessHandle); /* Unlink the thread data */ - ThreadData->Next = ThisData->Next; + *ThreadData = ThisData->Next; /* Free it*/ RtlFreeHeap(RtlGetProcessHeap(), 0, ThisData); @@ -354,7 +356,7 @@ else { /* Move to the next one */ - ThreadData = ThisData; + ThreadData = &ThisData->Next; } } }

1 0

← Newer
1
...
17
18
19
20
21
22
23
...
52
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs July 2011