Ros-diffs September 2011

ros-diffs@reactos.org

20 participants
399 discussions

[dchapyshev] 53520: - Partly revert r53519

by dchapyshev＠svn.reactos.org

Author: dchapyshev Date: Thu Sep 1 16:02:16 2011 New Revision: 53520 URL: http://svn.reactos.org/svn/reactos?rev=53520&view=rev Log: - Partly revert r53519 Modified: trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc Modified: trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/glu32/libnurbs/i… ============================================================================== --- trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc [iso-8859-1] Thu Sep 1 16:02:16 2011 @@ -90,7 +90,7 @@ } void -Mapdesc::identify( REAL (&dest)[MAXCOORDS][MAXCOORDS] ) +Mapdesc::identify( REAL dest[MAXCOORDS][MAXCOORDS] ) { memset( dest, 0, sizeof( dest ) ); for( int i=0; i != hcoords; i++ )

13 years, 3 months

[dchapyshev] 53519: - Fix multiple typos and bugs, found by PVS-Studio

by dchapyshev＠svn.reactos.org

Author: dchapyshev Date: Thu Sep 1 15:30:19 2011 New Revision: 53519 URL: http://svn.reactos.org/svn/reactos?rev=53519&view=rev Log: - Fix multiple typos and bugs, found by PVS-Studio Modified: trunk/reactos/base/applications/sndrec32/sndrec32.cpp trunk/reactos/base/system/smss/client.c trunk/reactos/dll/cpl/desk/screensaver.c trunk/reactos/dll/win32/browseui/bandsite.cpp trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc trunk/reactos/dll/win32/oleaut32/typelib2.c trunk/reactos/dll/win32/rsaenh/sha2.c trunk/reactos/dll/win32/shell32/pidl.c trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp trunk/reactos/ntoskrnl/config/cmcontrl.c trunk/reactos/subsystems/win32/win32k/eng/gradient.c trunk/reactos/subsystems/win32/win32k/objects/bitblt.c Modified: trunk/reactos/base/applications/sndrec32/sndrec32.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/sndrec32… ============================================================================== --- trunk/reactos/base/applications/sndrec32/sndrec32.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/sndrec32/sndrec32.cpp [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -766,7 +766,7 @@ isnew = TRUE; display_dur = TRUE; - ZeroMemory( file_path, MAX_PATH ); + ZeroMemory( file_path, MAX_PATH * sizeof(TCHAR) ); EnableWindow( slider, FALSE ); Modified: trunk/reactos/base/system/smss/client.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/smss/client.c?… ============================================================================== --- trunk/reactos/base/system/smss/client.c [iso-8859-1] (original) +++ trunk/reactos/base/system/smss/client.c [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -441,7 +441,7 @@ */ RtlCopyMemory (SmpClientDirectory.CandidateClient->ProgramName, ProgramName, - SM_SB_NAME_MAX_LENGTH); + SM_SB_NAME_MAX_LENGTH * sizeof(WCHAR)); } } else { DPRINT1("SM: %s: CandidateClient %p pending!\n", __FUNCTION__, Modified: trunk/reactos/dll/cpl/desk/screensaver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/screensaver.c… ============================================================================== --- trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -450,7 +450,7 @@ lpBackSlash = _tcsrchr(szSearchPath, _T('\\')); if (lpBackSlash != NULL) { - lpBackSlash = '\0'; + *lpBackSlash = '\0'; SearchScreenSavers(hwndScreenSavers, szSearchPath, pData); } } Modified: trunk/reactos/dll/win32/browseui/bandsite.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/bandsit… ============================================================================== --- trunk/reactos/dll/win32/browseui/bandsite.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/browseui/bandsite.cpp [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -719,7 +719,7 @@ if (fRebarWindow == NULL) return E_FAIL; - if (IsEqualIID(pguidCmdGroup, IID_IDeskBand)) + if (IsEqualIID(*pguidCmdGroup, IID_IDeskBand)) { switch (nCmdID) { Modified: trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/glu32/libnurbs/i… ============================================================================== --- trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc [iso-8859-1] (original) +++ trunk/reactos/dll/win32/glu32/libnurbs/internals/mapdesc.cc [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -90,7 +90,7 @@ } void -Mapdesc::identify( REAL dest[MAXCOORDS][MAXCOORDS] ) +Mapdesc::identify( REAL (&dest)[MAXCOORDS][MAXCOORDS] ) { memset( dest, 0, sizeof( dest ) ); for( int i=0; i != hcoords; i++ ) Modified: trunk/reactos/dll/win32/oleaut32/typelib2.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/oleaut32/typelib… ============================================================================== --- trunk/reactos/dll/win32/oleaut32/typelib2.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/oleaut32/typelib2.c [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -317,7 +317,7 @@ while (offset != -1) { guidentry = (MSFT_GuidEntry *)&This->typelib_segment_data[MSFT_SEG_GUID][offset]; - if (IsEqualGUID(guidentry, guid)) return offset; + if (IsEqualGUID(*guidentry, guid)) return offset; offset = guidentry->next_hash; } Modified: trunk/reactos/dll/win32/rsaenh/sha2.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/rsaenh/sha2.c?re… ============================================================================== --- trunk/reactos/dll/win32/rsaenh/sha2.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/rsaenh/sha2.c [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -563,7 +563,7 @@ } /* Clean up state data: */ - MEMSET_BZERO(context, sizeof(context)); + MEMSET_BZERO(context, sizeof(*context)); usedspace = 0; } @@ -584,7 +584,7 @@ } *buffer = 0; } else { - MEMSET_BZERO(context, sizeof(context)); + MEMSET_BZERO(context, sizeof(*context)); } MEMSET_BZERO(digest, SHA256_DIGEST_LENGTH); return buffer; @@ -893,7 +893,7 @@ } /* Zero out state data */ - MEMSET_BZERO(context, sizeof(context)); + MEMSET_BZERO(context, sizeof(*context)); } char *SHA512_End(SHA512_CTX* context, char buffer[]) { @@ -913,7 +913,7 @@ } *buffer = 0; } else { - MEMSET_BZERO(context, sizeof(context)); + MEMSET_BZERO(context, sizeof(*context)); } MEMSET_BZERO(digest, SHA512_DIGEST_LENGTH); return buffer; @@ -968,7 +968,7 @@ } /* Zero out state data */ - MEMSET_BZERO(context, sizeof(context)); + MEMSET_BZERO(context, sizeof(*context)); } char *SHA384_End(SHA384_CTX* context, char buffer[]) { @@ -988,7 +988,7 @@ } *buffer = 0; } else { - MEMSET_BZERO(context, sizeof(context)); + MEMSET_BZERO(context, sizeof(*context)); } MEMSET_BZERO(digest, SHA384_DIGEST_LENGTH); return buffer; Modified: trunk/reactos/dll/win32/shell32/pidl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/pidl.c?r… ============================================================================== --- trunk/reactos/dll/win32/shell32/pidl.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/pidl.c [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -1157,7 +1157,7 @@ if (len < sizeof(WIN32_FIND_DATAW)) return E_INVALIDARG; - ZeroMemory(pfd, sizeof (WIN32_FIND_DATAA)); + ZeroMemory(pfd, sizeof (WIN32_FIND_DATAW)); _ILGetFileDateTime( pidl, &(pfd->ftLastWriteTime)); pfd->dwFileAttributes = _ILGetFileAttributes(pidl, NULL, 0); pfd->nFileSizeLow = _ILGetFileSize ( pidl, NULL, 0); Modified: trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/ide/uniata… ============================================================================== --- trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/ide/uniata/id_dma.cpp [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -1607,7 +1607,7 @@ { 0xc2, 0x82, 0x042, 0x8a, 0x4a, 0x0a } }; static const UCHAR cmd_wdma_modes[] = { 0x87, 0x32, 0x3f }; static const UCHAR cmd_pio_modes[] = { 0xa9, 0x57, 0x44, 0x32, 0x3f }; - ULONG treg = 0x54 + (dev < 3) ? (dev << 1) : 7; + ULONG treg = 0x54 + ((dev < 3) ? (dev << 1) : 7); udmamode = min(udmamode, 5); /* enable UDMA mode */ Modified: trunk/reactos/ntoskrnl/config/cmcontrl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmcontrl.c… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmcontrl.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cmcontrl.c [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -118,7 +118,7 @@ if (!SystemHiveData) return; /* Initialize the Hive View List and the security cache */ - RtlZeroMemory(SystemHive, sizeof(SystemHive)); + RtlZeroMemory(SystemHive, sizeof(*SystemHive)); CmpInitHiveViewList((PCMHIVE)SystemHive); CmpInitSecurityCache((PCMHIVE)SystemHive); Modified: trunk/reactos/subsystems/win32/win32k/eng/gradient.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/en… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/eng/gradient.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/eng/gradient.c [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -298,7 +298,7 @@ #define SMALLER(a,b) (a->y < b->y) || (a->y == b->y && a->x < b->x) #define SWAP(a,b,c) c = a;\ a = b;\ - a = c + b = c #define NLINES 3 BOOL FASTCALL IntEngGradientFillTriangle( Modified: trunk/reactos/subsystems/win32/win32k/objects/bitblt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/win32/win32k/ob… ============================================================================== --- trunk/reactos/subsystems/win32/win32k/objects/bitblt.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/win32/win32k/objects/bitblt.c [iso-8859-1] Thu Sep 1 15:30:19 2011 @@ -667,7 +667,7 @@ MaskPoint.y = YOriginMask; IntLPtoDP(DCMask, &MaskPoint, 1); MaskPoint.x += DCMask->ptlDCOrig.x; - MaskPoint.y += DCMask->ptlDCOrig.x; + MaskPoint.y += DCMask->ptlDCOrig.y; } /* Perform the bitblt operation */

13 years, 3 months

[dchapyshev] 53518: - Fix build - Fix wrong memory copying, found by PVS-Studio

by dchapyshev＠svn.reactos.org

Author: dchapyshev Date: Thu Sep 1 15:13:59 2011 New Revision: 53518 URL: http://svn.reactos.org/svn/reactos?rev=53518&view=rev Log: - Fix build - Fix wrong memory copying, found by PVS-Studio Modified: trunk/reactos/dll/win32/user32/misc/dllmain.c trunk/reactos/dll/win32/user32/windows/menu.c Modified: trunk/reactos/dll/win32/user32/misc/dllmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/misc/dllm… ============================================================================== --- trunk/reactos/dll/win32/user32/misc/dllmain.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/misc/dllmain.c [iso-8859-1] Thu Sep 1 15:13:59 2011 @@ -159,7 +159,7 @@ LPWSTR ptr; size_t i; - RtlCopyMemory(buffer, szAppInit, KEY_LENGTH); + RtlCopyMemory(buffer, szAppInit, KEY_LENGTH * sizeof(WCHAR)); for (i = 0; i < KEY_LENGTH; ++ i) { Modified: trunk/reactos/dll/win32/user32/windows/menu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/menu.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/windows/menu.c [iso-8859-1] Thu Sep 1 15:13:59 2011 @@ -4344,7 +4344,7 @@ { AnsiBuffer[miiW.cch] = 0; } - mii->cch = miiW->cch; + mii->cch = miiW.cch; } } else

13 years, 3 months

[dchapyshev] 53517: - Try to fix build

by dchapyshev＠svn.reactos.org

Author: dchapyshev Date: Thu Sep 1 14:57:21 2011 New Revision: 53517 URL: http://svn.reactos.org/svn/reactos?rev=53517&view=rev Log: - Try to fix build Modified: trunk/reactos/dll/win32/netshell/lanstatusui.c Modified: trunk/reactos/dll/win32/netshell/lanstatusui.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netshell/lanstat… ============================================================================== --- trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] Thu Sep 1 14:57:21 2011 @@ -179,7 +179,7 @@ pContext->Status = 3; } } - else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE | MIB_IF_OPER_STATUS_DISCONNECTED) + else if (IfEntry.dwOperStatus == (MIB_IF_OPER_STATUS_UNREACHABLE | MIB_IF_OPER_STATUS_DISCONNECTED)) { if (pContext->Status != 4) {

13 years, 3 months

[dchapyshev] 53516: - Fix typos, found by PVS-Studio

by dchapyshev＠svn.reactos.org

Author: dchapyshev Date: Thu Sep 1 13:18:22 2011 New Revision: 53516 URL: http://svn.reactos.org/svn/reactos?rev=53516&view=rev Log: - Fix typos, found by PVS-Studio Modified: trunk/reactos/dll/win32/netshell/lanstatusui.c trunk/reactos/dll/win32/opengl32/font.c trunk/reactos/dll/win32/shell32/autocomplete.c trunk/reactos/dll/win32/syssetup/wizard.c trunk/reactos/drivers/network/tdi/cte/events.c trunk/reactos/lib/3rdparty/adns/src/transmit.c trunk/reactos/lib/3rdparty/stlport/src/locale.cpp trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c Modified: trunk/reactos/dll/win32/netshell/lanstatusui.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netshell/lanstat… ============================================================================== --- trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/netshell/lanstatusui.c [iso-8859-1] Thu Sep 1 13:18:22 2011 @@ -179,7 +179,7 @@ pContext->Status = 3; } } - else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE || MIB_IF_OPER_STATUS_DISCONNECTED) + else if (IfEntry.dwOperStatus == MIB_IF_OPER_STATUS_UNREACHABLE | MIB_IF_OPER_STATUS_DISCONNECTED) { if (pContext->Status != 4) { Modified: trunk/reactos/dll/win32/opengl32/font.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/opengl32/font.c?… ============================================================================== --- trunk/reactos/dll/win32/opengl32/font.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/opengl32/font.c [iso-8859-1] Thu Sep 1 13:18:22 2011 @@ -1081,7 +1081,7 @@ glyphSize = GetGlyphOutline(hDC, glyphIndex, GGO_NATIVE, &glyphMetrics, 0, NULL, &matrix); - if (glyphSize < 0) + if (glyphSize == GDI_ERROR) return FALSE; /*WGL_STATUS_FAILURE*/ if (glyphSize > glyphBufSize) @@ -1096,7 +1096,7 @@ /* * Get the glyph's outlines. */ - if (GetGlyphOutline(hDC, glyphIndex, GGO_NATIVE, &glyphMetrics, glyphBufSize, glyphBuf, &matrix) < 0) + if (GetGlyphOutline(hDC, glyphIndex, GGO_NATIVE, &glyphMetrics, glyphBufSize, glyphBuf, &matrix) == GDI_ERROR) { HeapFree(GetProcessHeap(), 0, glyphBuf); return FALSE; /*WGL_STATUS_FAILURE*/ Modified: trunk/reactos/dll/win32/shell32/autocomplete.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/autocomp… ============================================================================== --- trunk/reactos/dll/win32/shell32/autocomplete.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/autocomplete.c [iso-8859-1] Thu Sep 1 13:18:22 2011 @@ -448,7 +448,7 @@ ShowWindow(This->hwndListBox, SW_HIDE); break; case WM_KILLFOCUS: - if ((This->options && ACO_AUTOSUGGEST) && + if ((This->options & ACO_AUTOSUGGEST) && ((HWND)wParam != This->hwndListBox)) { ShowWindow(This->hwndListBox, SW_HIDE); Modified: trunk/reactos/dll/win32/syssetup/wizard.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/syssetup/wizard.… ============================================================================== --- trunk/reactos/dll/win32/syssetup/wizard.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/syssetup/wizard.c [iso-8859-1] Thu Sep 1 13:18:22 2011 @@ -1693,8 +1693,8 @@ { if (0 == LoadStringW(hDllInstance, IDS_UNKNOWN_ERROR, UnknownError, - sizeof(UnknownError) / sizeof(UnknownError[0] - - 20))) + sizeof(UnknownError) / sizeof(UnknownError[0]) - + 20)) { wcscpy(UnknownError, L"Unknown error"); } Modified: trunk/reactos/drivers/network/tdi/cte/events.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/network/tdi/cte/ev… ============================================================================== --- trunk/reactos/drivers/network/tdi/cte/events.c [iso-8859-1] (original) +++ trunk/reactos/drivers/network/tdi/cte/events.c [iso-8859-1] Thu Sep 1 13:18:22 2011 @@ -123,7 +123,7 @@ KeAcquireSpinLock(&Event->Lock, &OldIrql); /* Make sure it is queued */ - if (!Event->Queued); + if (!Event->Queued) { /* Mark it as queued and set optional context pointer */ Event->Queued = TRUE; Modified: trunk/reactos/lib/3rdparty/adns/src/transmit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/adns/src/tran… ============================================================================== --- trunk/reactos/lib/3rdparty/adns/src/transmit.c [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/adns/src/transmit.c [iso-8859-1] Thu Sep 1 13:18:22 2011 @@ -200,7 +200,7 @@ ADNS_CAPTURE_ERRNO; adns__sigpipe_unprotect(qu->ads); if (wr < 0) { - if (!(errno == EAGAIN || EWOULDBLOCK || errno == EINTR || errno == ENOSPC || + if (!(errno == EAGAIN || errno == EWOULDBLOCK || errno == EINTR || errno == ENOSPC || errno == ENOBUFS || errno == ENOMEM)) { adns__tcp_broken(ads,"write",strerror(errno)); return; Modified: trunk/reactos/lib/3rdparty/stlport/src/locale.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/stlport/src/l… ============================================================================== --- trunk/reactos/lib/3rdparty/stlport/src/locale.cpp [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/stlport/src/locale.cpp [iso-8859-1] Thu Sep 1 13:18:22 2011 @@ -208,7 +208,7 @@ static void _Stl_loc_combine_names(_Locale_impl* L, const char* name1, const char* name2, locale::category c) { - if ((c & locale::all) == 0 || strcmp(name1, name1) == 0) + if ((c & locale::all) == 0 || strcmp(name1, name2) == 0) L->name = name1; else if ((c & locale::all) == locale::all) L->name = name2; Modified: trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/mdlsup.c [iso-8859-1] Thu Sep 1 13:18:22 2011 @@ -1174,7 +1174,7 @@ // Check if this page is in the PFN database // Pfn1 = MiGetPfnEntry(*MdlPages); - if (Pfn1); + if (Pfn1) { /* Get the current entry and reference count */ OldRefCount = Pfn1->u3.e2.ReferenceCount;

13 years, 3 months

[dchapyshev] 53515: - Fix typo, found by PVS-Studio

by dchapyshev＠svn.reactos.org

Author: dchapyshev Date: Thu Sep 1 12:41:50 2011 New Revision: 53515 URL: http://svn.reactos.org/svn/reactos?rev=53515&view=rev Log: - Fix typo, found by PVS-Studio Modified: trunk/reactos/dll/win32/user32/windows/menu.c Modified: trunk/reactos/dll/win32/user32/windows/menu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/user32/windows/m… ============================================================================== --- trunk/reactos/dll/win32/user32/windows/menu.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/user32/windows/menu.c [iso-8859-1] Thu Sep 1 12:41:50 2011 @@ -4344,7 +4344,7 @@ { AnsiBuffer[miiW.cch] = 0; } - mii->cch = mii->cch; + mii->cch = miiW->cch; } } else

13 years, 3 months

[dchapyshev] 53514: - Fix wrong macros usage, found by PVS-Studio

by dchapyshev＠svn.reactos.org

Author: dchapyshev Date: Thu Sep 1 12:38:56 2011 New Revision: 53514 URL: http://svn.reactos.org/svn/reactos?rev=53514&view=rev Log: - Fix wrong macros usage, found by PVS-Studio Modified: trunk/reactos/hal/halx86/generic/bios.c Modified: trunk/reactos/hal/halx86/generic/bios.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/hal/halx86/generic/bios.c?… ============================================================================== --- trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] (original) +++ trunk/reactos/hal/halx86/generic/bios.c [iso-8859-1] Thu Sep 1 12:38:56 2011 @@ -424,7 +424,7 @@ // // Set default state // - RtlFillMemory(HalpSavedIoMap, 0xFF, IOPM_FULL_SIZE); + RtlFillMemory(HalpSavedIoMap, IOPM_FULL_SIZE, 0xFF); // // Restore the backed up copy, and initialize it

13 years, 3 months

[dchapyshev] 53513: - Fix wrong macros usage, found by PVS-Studio

by dchapyshev＠svn.reactos.org

Author: dchapyshev Date: Thu Sep 1 12:34:51 2011 New Revision: 53513 URL: http://svn.reactos.org/svn/reactos?rev=53513&view=rev Log: - Fix wrong macros usage, found by PVS-Studio Modified: trunk/reactos/lib/rtl/bitmap.c Modified: trunk/reactos/lib/rtl/bitmap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/bitmap.c?rev=53513… ============================================================================== --- trunk/reactos/lib/rtl/bitmap.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/bitmap.c [iso-8859-1] Thu Sep 1 12:34:51 2011 @@ -339,7 +339,7 @@ } /* Set all full ULONGs */ - RtlFillMemoryUlong(Buffer, NumberToSet >> 3, MAXULONG); + RtlFillMemoryUlong(Buffer, MAXULONG, NumberToSet >> 3); Buffer += NumberToSet >> 5; /* Set what's left */

13 years, 3 months

[dchapyshev] 53512: - Fix a bug, found by PVS-Studio

by dchapyshev＠svn.reactos.org

Author: dchapyshev Date: Thu Sep 1 12:25:52 2011 New Revision: 53512 URL: http://svn.reactos.org/svn/reactos?rev=53512&view=rev Log: - Fix a bug, found by PVS-Studio Modified: trunk/reactos/lib/3rdparty/cardlib/cardwindow.cpp Modified: trunk/reactos/lib/3rdparty/cardlib/cardwindow.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/cardlib/cardw… ============================================================================== --- trunk/reactos/lib/3rdparty/cardlib/cardwindow.cpp [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/cardlib/cardwindow.cpp [iso-8859-1] Thu Sep 1 12:25:52 2011 @@ -716,7 +716,7 @@ cols[1] = RGB(255, 255, 255); //include the base background colour - cols[1] = crBackgnd; + cols[2] = crBackgnd; //include the standard button colours... cols[3] = CardButton::GetHighlight(crBackgnd);

13 years, 3 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2011