Ros-diffs October 2012

ros-diffs@reactos.org

14 participants
211 discussions

[ekohl] 57480: [LSASRV] LsapLookupNames: If a name was found, add its domain SID to the domains list and set the domain index accordingly.

by ekohl＠svn.reactos.org

Author: ekohl Date: Thu Oct 4 18:22:55 2012 New Revision: 57480 URL: http://svn.reactos.org/svn/reactos?rev=57480&view=rev Log: [LSASRV] LsapLookupNames: If a name was found, add its domain SID to the domains list and set the domain index accordingly. Modified: trunk/reactos/dll/win32/lsasrv/sids.c Modified: trunk/reactos/dll/win32/lsasrv/sids.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/sids.c?re… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/sids.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lsasrv/sids.c [iso-8859-1] Thu Oct 4 18:22:55 2012 @@ -830,6 +830,54 @@ } +static NTSTATUS +LsapAddDomainToDomainsList(PLSAPR_REFERENCED_DOMAIN_LIST ReferencedDomains, + PUNICODE_STRING Name, + PSID Sid, + PULONG Index) +{ + ULONG i; + + i = 0; + while (i < ReferencedDomains->Entries && + ReferencedDomains->Domains[i].Sid != NULL) + { + if (RtlEqualSid(Sid, ReferencedDomains->Domains[i].Sid)) + { + *Index = i; + return STATUS_SUCCESS; + } + + i++; + } + + ReferencedDomains->Domains[i].Sid = MIDL_user_allocate(RtlLengthSid(Sid)); + if (ReferencedDomains->Domains[i].Sid == NULL) + return STATUS_INSUFFICIENT_RESOURCES; + + RtlCopySid(RtlLengthSid(Sid), ReferencedDomains->Domains[i].Sid, Sid); + + ReferencedDomains->Domains[i].Name.Length = Name->Length; + ReferencedDomains->Domains[i].Name.MaximumLength = Name->MaximumLength; + ReferencedDomains->Domains[i].Name.Buffer = MIDL_user_allocate(Name->MaximumLength); + if (ReferencedDomains->Domains[i].Sid == NULL) + { + MIDL_user_free(ReferencedDomains->Domains[i].Sid); + ReferencedDomains->Domains[i].Sid = NULL; + return STATUS_INSUFFICIENT_RESOURCES; + } + + RtlCopyMemory(ReferencedDomains->Domains[i].Name.Buffer, + Name->Buffer, + Name->MaximumLength); + + ReferencedDomains->Entries++; + *Index = i; + + return STATUS_SUCCESS; +} + + NTSTATUS LsapLookupNames(DWORD Count, PRPC_UNICODE_STRING Names, @@ -845,6 +893,7 @@ PRPC_UNICODE_STRING DomainNames = NULL; PRPC_UNICODE_STRING AccountNames = NULL; ULONG SidsBufferLength; + ULONG DomainIndex; // ULONG DomainSidLength; // ULONG AccountSidLength; // PSID DomainSid; @@ -853,7 +902,7 @@ ULONG Mapped = 0; NTSTATUS Status = STATUS_SUCCESS; - PWELL_KNOWN_SID ptr; + PWELL_KNOWN_SID ptr, ptr2; //TRACE("()\n"); @@ -878,7 +927,6 @@ goto done; } - DomainsBuffer->Entries = 0; //Count; DomainsBuffer->Domains = MIDL_user_allocate(Count * sizeof(LSA_TRUST_INFORMATION)); if (DomainsBuffer->Domains == NULL) { @@ -886,6 +934,8 @@ Status = STATUS_INSUFFICIENT_RESOURCES; goto done; } + DomainsBuffer->Entries = 0; + DomainsBuffer->MaxEntries = Count; for (i = 0; i < Count; i++) { @@ -911,7 +961,7 @@ //TRACE("Domain name: %wZ\n", &DomainNames[i]); //TRACE("Account name: %wZ\n", &AccountNames[i]); - + ptr2 = NULL; ptr = LsapLookupWellKnownName((PUNICODE_STRING)&AccountNames[i]); if (ptr != NULL) { @@ -922,24 +972,33 @@ SidsBuffer[i].DomainIndex = -1; SidsBuffer[i].Flags = 0; -#if 0 - if (DomainNames[i].Buffer != NULL) + if (DomainNames[i].Length != 0) { - ptr2= LsapLookupWellKnownName((PUNICODE_STRING)&DomainNames[i].Buffer); + ptr2= LsapLookupWellKnownName((PUNICODE_STRING)&DomainNames[i]); if (ptr2 != NULL) { - + Status = LsapAddDomainToDomainsList(DomainsBuffer, + &ptr2->Name, + ptr2->Sid, + &DomainIndex); + if (NT_SUCCESS(Status)) + SidsBuffer[i].DomainIndex = DomainIndex; } } - else if (ptr->Domain.Length != 0) + + if (ptr2 == NULL && ptr->Domain.Length != 0) { - + ptr2= LsapLookupWellKnownName(&ptr->Domain); + if (ptr2 != NULL) + { + Status = LsapAddDomainToDomainsList(DomainsBuffer, + &ptr2->Name, + ptr2->Sid, + &DomainIndex); + if (NT_SUCCESS(Status)) + SidsBuffer[i].DomainIndex = DomainIndex; + } } - else - { - - } -#endif Mapped++; continue;

12 years, 2 months

[ion] 57479: [NDK]: forgot this ,sorry.

by ion＠svn.reactos.org

Author: ion Date: Thu Oct 4 17:08:51 2012 New Revision: 57479 URL: http://svn.reactos.org/svn/reactos?rev=57479&view=rev Log: [NDK]: forgot this ,sorry. Modified: trunk/reactos/include/ndk/rtlfuncs.h Modified: trunk/reactos/include/ndk/rtlfuncs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/rtlfuncs.h?rev… ============================================================================== --- trunk/reactos/include/ndk/rtlfuncs.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/rtlfuncs.h [iso-8859-1] Thu Oct 4 17:08:51 2012 @@ -2013,6 +2013,9 @@ IN SIZE_T Length, IN ULONG Pattern ); + +#define RtlEqualMemory(Destination, Source, Length) \ + (!memcmp(Destination, Source, Length)) #define RtlCopyBytes RtlCopyMemory #define RtlFillBytes RtlFillMemory

12 years, 2 months

[ion] 57478: [RTL]: Cleanup, comment, and fix SID functions. For example, RtlEqualPrefixSid actually checks only the prefix, not the entire SID.

by ion＠svn.reactos.org

Author: ion Date: Thu Oct 4 16:55:53 2012 New Revision: 57478 URL: http://svn.reactos.org/svn/reactos?rev=57478&view=rev Log: [RTL]: Cleanup, comment, and fix SID functions. For example, RtlEqualPrefixSid actually checks only the prefix, not the entire SID. Modified: trunk/reactos/lib/rtl/access.c trunk/reactos/lib/rtl/sid.c Modified: trunk/reactos/lib/rtl/access.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/access.c?rev=57478… ============================================================================== --- trunk/reactos/lib/rtl/access.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/access.c [iso-8859-1] Thu Oct 4 16:55:53 2012 @@ -8,7 +8,6 @@ /* INCLUDES *****************************************************************/ #include <rtl.h> - #define NDEBUG #include <debug.h> @@ -19,11 +18,13 @@ */ BOOLEAN NTAPI -RtlAreAllAccessesGranted(ACCESS_MASK GrantedAccess, - ACCESS_MASK DesiredAccess) +RtlAreAllAccessesGranted(IN ACCESS_MASK GrantedAccess, + IN ACCESS_MASK DesiredAccess) { - PAGED_CODE_RTL(); - return ((GrantedAccess & DesiredAccess) == DesiredAccess); + PAGED_CODE_RTL(); + + /* Return if there's no leftover bits after granting all of them */ + return !(~GrantedAccess & DesiredAccess); } /* @@ -31,11 +32,13 @@ */ BOOLEAN NTAPI -RtlAreAnyAccessesGranted(ACCESS_MASK GrantedAccess, - ACCESS_MASK DesiredAccess) +RtlAreAnyAccessesGranted(IN ACCESS_MASK GrantedAccess, + IN ACCESS_MASK DesiredAccess) { PAGED_CODE_RTL(); - return ((GrantedAccess & DesiredAccess) != 0); + + /* Return if there's any leftover bits after granting all of them */ + return (GrantedAccess & DesiredAccess); } /* @@ -43,19 +46,18 @@ */ VOID NTAPI -RtlMapGenericMask(PACCESS_MASK AccessMask, - PGENERIC_MAPPING GenericMapping) +RtlMapGenericMask(IN OUT PACCESS_MASK AccessMask, + IN PGENERIC_MAPPING GenericMapping) { PAGED_CODE_RTL(); + /* Convert mappings */ if (*AccessMask & GENERIC_READ) *AccessMask |= GenericMapping->GenericRead; - if (*AccessMask & GENERIC_WRITE) *AccessMask |= GenericMapping->GenericWrite; - if (*AccessMask & GENERIC_EXECUTE) *AccessMask |= GenericMapping->GenericExecute; - if (*AccessMask & GENERIC_ALL) *AccessMask |= GenericMapping->GenericAll; + /* Clear generic flags */ *AccessMask &= ~(GENERIC_READ | GENERIC_WRITE | GENERIC_EXECUTE | GENERIC_ALL); } Modified: trunk/reactos/lib/rtl/sid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/sid.c?rev=57478&r1… ============================================================================== --- trunk/reactos/lib/rtl/sid.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/sid.c [iso-8859-1] Thu Oct 4 16:55:53 2012 @@ -9,7 +9,6 @@ /* INCLUDES *****************************************************************/ #include <rtl.h> - #define NDEBUG #include <debug.h> @@ -22,19 +21,31 @@ RtlValidSid(IN PSID Sid_) { PISID Sid = Sid_; - - PAGED_CODE_RTL(); - - if ((Sid->Revision != SID_REVISION) || - (Sid->SubAuthorityCount > SID_MAX_SUB_AUTHORITIES)) - { + PAGED_CODE_RTL(); + + /* Use SEH in case any pointer is invalid */ + _SEH2_TRY + { + /* Validate the revision and subauthority count */ + if ((Sid) && + (((Sid->Revision & 0xF) != SID_REVISION) || + (Sid->SubAuthorityCount > SID_MAX_SUB_AUTHORITIES))) + { + /* It's not, fail */ + return FALSE; + } + } + _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) + { + /* Access violation, SID is not valid */ return FALSE; } - + _SEH2_END; + + /* All good */ return TRUE; } - /* * @implemented */ @@ -44,10 +55,10 @@ { PAGED_CODE_RTL(); + /* Return the required length */ return (ULONG)FIELD_OFFSET(SID, SubAuthority[SubAuthorityCount]); } - /* * @implemented @@ -59,18 +70,16 @@ IN UCHAR SubAuthorityCount) { PISID Sid = Sid_; - - PAGED_CODE_RTL(); - + PAGED_CODE_RTL(); + + /* Fill out the header */ Sid->Revision = SID_REVISION; Sid->SubAuthorityCount = SubAuthorityCount; - memcpy(&Sid->IdentifierAuthority, - IdentifierAuthority, - sizeof(SID_IDENTIFIER_AUTHORITY)); - + Sid->IdentifierAuthority = *IdentifierAuthority; + + /* All good */ return STATUS_SUCCESS; } - /* * @implemented @@ -81,13 +90,12 @@ IN ULONG SubAuthority) { PISID Sid = Sid_; - - PAGED_CODE_RTL(); - + PAGED_CODE_RTL(); + + /* Return the offset */ return (PULONG)&Sid->SubAuthority[SubAuthority]; } - /* * @implemented */ @@ -96,12 +104,25 @@ RtlSubAuthorityCountSid(IN PSID Sid_) { PISID Sid = Sid_; - - PAGED_CODE_RTL(); - + PAGED_CODE_RTL(); + + /* Return the offset to the count */ return &Sid->SubAuthorityCount; } +/* + * @implemented + */ +PSID_IDENTIFIER_AUTHORITY +NTAPI +RtlIdentifierAuthoritySid(IN PSID Sid_) +{ + PISID Sid = Sid_; + PAGED_CODE_RTL(); + + /* Return the offset to the identifier authority */ + return &Sid->IdentifierAuthority; +} /* * @implemented @@ -111,22 +132,15 @@ RtlEqualSid(IN PSID Sid1_, IN PSID Sid2_) { - PISID Sid1 = Sid1_; - PISID Sid2 = Sid2_; - SIZE_T SidLen; - - PAGED_CODE_RTL(); - - if (Sid1->Revision != Sid2->Revision || - (*RtlSubAuthorityCountSid(Sid1)) != (*RtlSubAuthorityCountSid(Sid2))) - { - return FALSE; - } - - SidLen = RtlLengthSid(Sid1); - return RtlCompareMemory(Sid1, Sid2, SidLen) == SidLen; -} - + PISID Sid1 = Sid1_, Sid2 = Sid2_; + PAGED_CODE_RTL(); + + /* Quick compare of the revision and the count */ + if (*(PUSHORT)&Sid1->Revision != *(PUSHORT)&Sid2->Revision) return FALSE; + + /* Get the length and compare it the long way */ + return RtlEqualMemory(Sid1, Sid2, RtlLengthSid(Sid1)); +} /* * @implemented @@ -136,233 +150,213 @@ RtlLengthSid(IN PSID Sid_) { PISID Sid = Sid_; - - PAGED_CODE_RTL(); - + PAGED_CODE_RTL(); + + /* The offset to the last index + 1 (since it's a count) is the length */ return (ULONG)FIELD_OFFSET(SID, SubAuthority[Sid->SubAuthorityCount]); } - /* * @implemented */ NTSTATUS NTAPI -RtlCopySid(ULONG BufferLength, - PSID Dest, - PSID Src) -{ - PAGED_CODE_RTL(); - - if (BufferLength < RtlLengthSid(Src)) - { - return STATUS_UNSUCCESSFUL; - } - - memmove(Dest, - Src, - RtlLengthSid(Src)); - +RtlCopySid(IN ULONG BufferLength, + IN PSID Dest, + IN PSID Src) +{ + ULONG SidLength; + PAGED_CODE_RTL(); + + /* Make sure the buffer is large enough*/ + SidLength = RtlLengthSid(Src); + if (SidLength > BufferLength) return STATUS_BUFFER_TOO_SMALL; + + /* And then copy the SID */ + RtlMoveMemory(Dest, Src, SidLength); return STATUS_SUCCESS; } +/* + * @implemented + */ +PVOID +NTAPI +RtlFreeSid(IN PSID Sid) +{ + PAGED_CODE_RTL(); + + /* Free the SID and always return NULL */ + RtlpFreeMemory(Sid, TAG_SID); + return NULL; +} + +/* + * @implemented + */ +BOOLEAN +NTAPI +RtlEqualPrefixSid(IN PSID Sid1_, + IN PSID Sid2_) +{ + PISID Sid1 = Sid1_, Sid2 = Sid2_; + ULONG i; + PAGED_CODE_RTL(); + + /* Revisions have to match */ + if (Sid1->Revision != Sid2->Revision) return FALSE; + + /* The identifier authorities have to match */ + if ((Sid1->IdentifierAuthority.Value[0] == Sid2->IdentifierAuthority.Value[0]) && + (Sid1->IdentifierAuthority.Value[1] == Sid2->IdentifierAuthority.Value[1]) && + (Sid1->IdentifierAuthority.Value[2] == Sid2->IdentifierAuthority.Value[2]) && + (Sid1->IdentifierAuthority.Value[3] == Sid2->IdentifierAuthority.Value[3]) && + (Sid1->IdentifierAuthority.Value[4] == Sid2->IdentifierAuthority.Value[4]) && + (Sid1->IdentifierAuthority.Value[5] == Sid2->IdentifierAuthority.Value[5])) + { + /* The subauthority counts have to match */ + if (Sid1->SubAuthorityCount == Sid2->SubAuthorityCount) + { + /* If there aren't any in SID1, means none in SID2 either, so equal */ + if (!Sid1->SubAuthorityCount) return TRUE; + + /* Now compare all the subauthority values BUT the last one */ + for (i = 0; i < (Sid1->SubAuthorityCount - 1); i++) + { + /* Does any mismatch? */ + if (Sid1->SubAuthority[i] != Sid2->SubAuthority[i]) + { + /* Prefix doesn't match, fail */ + return FALSE; + } + } + + /* Everything that should matches, does, return success */ + return TRUE; + } + } + + /* Identifiers don't match, fail */ + return FALSE; +} /* * @implemented */ NTSTATUS NTAPI -RtlCopySidAndAttributesArray(ULONG Count, - PSID_AND_ATTRIBUTES Src, - ULONG SidAreaSize, - PSID_AND_ATTRIBUTES Dest, - PVOID SidArea, - PVOID* RemainingSidArea, - PULONG RemainingSidAreaSize) -{ - ULONG SidLength; - ULONG Length; - ULONG i; - - PAGED_CODE_RTL(); - - Length = SidAreaSize; - +RtlCopySidAndAttributesArray(IN ULONG Count, + IN PSID_AND_ATTRIBUTES Src, + IN ULONG SidAreaSize, + IN PSID_AND_ATTRIBUTES Dest, + IN PVOID SidArea, + OUT PVOID* RemainingSidArea, + OUT PULONG RemainingSidAreaSize) +{ + ULONG SidLength, i; + PAGED_CODE_RTL(); + + /* Loop all the attributes */ for (i = 0; i < Count; i++) { - if (RtlLengthSid(Src[i].Sid) > Length) - { - return STATUS_BUFFER_TOO_SMALL; - } - + /* Make sure this SID can fit in the buffer */ SidLength = RtlLengthSid(Src[i].Sid); - Length = Length - SidLength; + if (SidLength > SidAreaSize) return STATUS_BUFFER_TOO_SMALL; + + /* Consume remaining buffer space for this SID */ + SidAreaSize -= SidLength; + + /* Copy the SID and attributes */ Dest[i].Sid = SidArea; Dest[i].Attributes = Src[i].Attributes; - RtlCopySid(SidLength, - SidArea, - Src[i].Sid); + RtlCopySid(SidLength, SidArea, Src[i].Sid); + + /* Push the buffer area where the SID will reset */ SidArea = (PVOID)((ULONG_PTR)SidArea + SidLength); } + /* Return how much space is left, and where the buffer is at now */ *RemainingSidArea = SidArea; - *RemainingSidAreaSize = Length; - + *RemainingSidAreaSize = SidAreaSize; return STATUS_SUCCESS; } - -/* - * @implemented - */ -PSID_IDENTIFIER_AUTHORITY -NTAPI -RtlIdentifierAuthoritySid(IN PSID Sid_) -{ - PISID Sid = Sid_; - - PAGED_CODE_RTL(); - - return &Sid->IdentifierAuthority; -} - - /* * @implemented */ NTSTATUS NTAPI -RtlAllocateAndInitializeSid(PSID_IDENTIFIER_AUTHORITY IdentifierAuthority, - UCHAR SubAuthorityCount, - ULONG SubAuthority0, - ULONG SubAuthority1, - ULONG SubAuthority2, - ULONG SubAuthority3, - ULONG SubAuthority4, - ULONG SubAuthority5, - ULONG SubAuthority6, - ULONG SubAuthority7, - PSID *Sid) +RtlAllocateAndInitializeSid(IN PSID_IDENTIFIER_AUTHORITY IdentifierAuthority, + IN UCHAR SubAuthorityCount, + IN ULONG SubAuthority0, + IN ULONG SubAuthority1, + IN ULONG SubAuthority2, + IN ULONG SubAuthority3, + IN ULONG SubAuthority4, + IN ULONG SubAuthority5, + IN ULONG SubAuthority6, + IN ULONG SubAuthority7, + OUT PSID *Sid) { PISID pSid; - - PAGED_CODE_RTL(); - - if (SubAuthorityCount > 8) - return STATUS_INVALID_SID; - - if (Sid == NULL) - return STATUS_INVALID_PARAMETER; - - pSid = RtlpAllocateMemory(RtlLengthRequiredSid(SubAuthorityCount), - TAG_SID); - if (pSid == NULL) - return STATUS_NO_MEMORY; - + PAGED_CODE_RTL(); + + /* SIDs can only have up to 8 subauthorities */ + if (SubAuthorityCount > 8) return STATUS_INVALID_SID; + + /* Allocate memory to hold the SID */ + pSid = RtlpAllocateMemory(RtlLengthRequiredSid(SubAuthorityCount), TAG_SID); + if (!pSid) return STATUS_NO_MEMORY; + + /* Fill out the header */ pSid->Revision = SID_REVISION; pSid->SubAuthorityCount = SubAuthorityCount; - memcpy(&pSid->IdentifierAuthority, - IdentifierAuthority, - sizeof(SID_IDENTIFIER_AUTHORITY)); - + pSid->IdentifierAuthority = *IdentifierAuthority; + + /* Iteraratively drop into each successive lower count */ switch (SubAuthorityCount) { - case 8: - pSid->SubAuthority[7] = SubAuthority7; - case 7: - pSid->SubAuthority[6] = SubAuthority6; - case 6: - pSid->SubAuthority[5] = SubAuthority5; - case 5: - pSid->SubAuthority[4] = SubAuthority4; - case 4: - pSid->SubAuthority[3] = SubAuthority3; - case 3: - pSid->SubAuthority[2] = SubAuthority2; - case 2: - pSid->SubAuthority[1] = SubAuthority1; - case 1: - pSid->SubAuthority[0] = SubAuthority0; - break; - } - + /* And copy the needed subahority */ + case 8: pSid->SubAuthority[7] = SubAuthority7; + case 7: pSid->SubAuthority[6] = SubAuthority6; + case 6: pSid->SubAuthority[5] = SubAuthority5; + case 5: pSid->SubAuthority[4] = SubAuthority4; + case 4: pSid->SubAuthority[3] = SubAuthority3; + case 3: pSid->SubAuthority[2] = SubAuthority2; + case 2: pSid->SubAuthority[1] = SubAuthority1; + case 1: pSid->SubAuthority[0] = SubAuthority0; + default: break; + } + + /* Return the allocated SID */ *Sid = pSid; - return STATUS_SUCCESS; } - -/* - * @implemented - * - * RETURNS - * Docs says FreeSid does NOT return a value - * even thou it's defined to return a PVOID... - */ -PVOID -NTAPI -RtlFreeSid(IN PSID Sid) -{ - PAGED_CODE_RTL(); - - RtlpFreeMemory(Sid, TAG_SID); - return NULL; -} - - -/* - * @implemented - */ -BOOLEAN -NTAPI -RtlEqualPrefixSid(IN PSID Sid1_, - IN PSID Sid2_) -{ - PISID Sid1 = Sid1_; - PISID Sid2 = Sid2_; - SIZE_T SidLen; - - PAGED_CODE_RTL(); - - if (Sid1->SubAuthorityCount == Sid2->SubAuthorityCount) - { - SidLen = FIELD_OFFSET(SID, - SubAuthority[Sid1->SubAuthorityCount]); - return RtlCompareMemory(Sid1, - Sid2, - SidLen) == SidLen; - } - - return FALSE; -} - - /* * @implemented */ NTSTATUS NTAPI -RtlConvertSidToUnicodeString(PUNICODE_STRING String, - PSID Sid_, - BOOLEAN AllocateBuffer) +RtlConvertSidToUnicodeString(IN PUNICODE_STRING String, + IN PSID Sid_, + IN BOOLEAN AllocateBuffer) { WCHAR Buffer[256]; PWSTR wcs; SIZE_T Length; ULONG i; PISID Sid = Sid_; - - PAGED_CODE_RTL(); - - if (RtlValidSid (Sid) == FALSE) - return STATUS_INVALID_SID; + PAGED_CODE_RTL(); + + if (!RtlValidSid(Sid)) return STATUS_INVALID_SID; wcs = Buffer; - wcs += swprintf(wcs, L"S-%u-", Sid->Revision); - - if (Sid->IdentifierAuthority.Value[0] == 0 && - Sid->IdentifierAuthority.Value[1] == 0) + wcs += swprintf(wcs, L"S-1-"); + + if ((Sid->IdentifierAuthority.Value[0] == 0) && + (Sid->IdentifierAuthority.Value[1] == 0)) { wcs += swprintf(wcs, L"%lu", @@ -385,33 +379,27 @@ for (i = 0; i < Sid->SubAuthorityCount; i++) { - wcs += swprintf(wcs, - L"-%u", - Sid->SubAuthority[i]); + wcs += swprintf(wcs, L"-%u", Sid->SubAuthority[i]); } if (AllocateBuffer) { - if (!RtlCreateUnicodeString(String, - Buffer)) + if (!RtlCreateUnicodeString(String, Buffer)) return STATUS_NO_MEMORY; + } + else + { + Length = (wcs - Buffer) * sizeof(WCHAR); + + if (Length > String->MaximumLength) return STATUS_BUFFER_TOO_SMALL; + + String->Length = (USHORT)Length; + RtlCopyMemory(String->Buffer, Buffer, Length); + + if (Length < String->MaximumLength) { - return STATUS_NO_MEMORY; + String->Buffer[Length / sizeof(WCHAR)] = UNICODE_NULL; } } - else - { - Length = (wcs - Buffer) * sizeof(WCHAR); - - if (Length > String->MaximumLength) - return STATUS_BUFFER_TOO_SMALL; - - String->Length = (USHORT)Length; - RtlCopyMemory(String->Buffer, - Buffer, - Length); - if (Length < String->MaximumLength) - String->Buffer[Length / sizeof(WCHAR)] = 0; - } return STATUS_SUCCESS; }

12 years, 2 months

[jgardou] 57477: [APITESTS/USER32] Improve GetIconInfo tests: -Stop leaking each handle we create -Show Icons sensitivity to screen bit depth

by jgardou＠svn.reactos.org

Author: jgardou Date: Thu Oct 4 13:38:26 2012 New Revision: 57477 URL: http://svn.reactos.org/svn/reactos?rev=57477&view=rev Log: [APITESTS/USER32] Improve GetIconInfo tests: -Stop leaking each handle we create -Show Icons sensitivity to screen bit depth Modified: trunk/rostests/apitests/user32/GetIconInfo.c Modified: trunk/rostests/apitests/user32/GetIconInfo.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/user32/GetIconIn… ============================================================================== --- trunk/rostests/apitests/user32/GetIconInfo.c [iso-8859-1] (original) +++ trunk/rostests/apitests/user32/GetIconInfo.c [iso-8859-1] Thu Oct 4 13:38:26 2012 @@ -7,7 +7,7 @@ // FIXME user32 void -Test_GetIconInfo(BOOL fIcon) +Test_GetIconInfo(BOOL fIcon, DWORD screen_bpp) { HICON hicon; ICONINFO iconinfo, iconinfo2; @@ -41,6 +41,7 @@ ok(iconinfo2.hbmMask != NULL, "\n"); ok(iconinfo2.hbmMask != iconinfo.hbmMask, "\n"); ok(iconinfo2.hbmColor == NULL, "\n"); + DeleteObject(iconinfo2.hbmMask); ok(GetIconInfo(hicon, &iconinfo2), "\n"); ok(iconinfo2.fIcon == iconinfo.fIcon, "\n"); @@ -57,6 +58,8 @@ ok(iconinfo2.hbmMask != NULL, "\n"); ok(iconinfo2.hbmMask != iconinfo.hbmMask, "\n"); ok(iconinfo2.hbmColor == NULL, "\n"); + DeleteObject(iconinfo2.hbmMask); + ok(DestroyIcon(hicon), "\n"); iconinfo.hbmColor = CreateBitmap(2, 2, 1, 1, NULL); hicon = CreateIconIndirect(&iconinfo); @@ -77,7 +80,7 @@ ok(iconinfo2.hbmMask != NULL, "\n"); ok(iconinfo2.hbmMask != iconinfo.hbmMask, "\n"); ok(iconinfo2.hbmColor != NULL, "\n"); - ok(iconinfo2.hbmMask != iconinfo.hbmColor, "\n"); + ok(iconinfo2.hbmColor != iconinfo.hbmColor, "\n"); ok(GetObject(iconinfo2.hbmMask, sizeof(bitmap), &bitmap), "GetObject failed\n"); ok(bitmap.bmType == 0, "\n"); @@ -94,8 +97,11 @@ ok(bitmap.bmHeight == 16, "\n"); ok(bitmap.bmWidthBytes == 8 * bitmap.bmBitsPixel / 8, "\n"); ok(bitmap.bmPlanes == 1, "\n"); - ok(bitmap.bmBitsPixel == 32, "\n"); - ok(bitmap.bmBits == NULL, "\n"); + ok(bitmap.bmBitsPixel == screen_bpp, "\n"); + ok(bitmap.bmBits == NULL, "\n"); + DeleteObject(iconinfo2.hbmMask); + DeleteObject(iconinfo2.hbmColor); + ok(DestroyIcon(hicon), "\n"); DeleteObject(iconinfo.hbmMask); iconinfo.hbmMask = NULL; @@ -126,11 +132,13 @@ ok(bitmap.bmType == 0, "\n"); ok(bitmap.bmWidth == 8, "%ld\n", bitmap.bmWidth); ok(bitmap.bmHeight == 16, "%ld\n", bitmap.bmHeight); - ok(bitmap.bmWidthBytes == 32, "%ld\n", bitmap.bmWidthBytes); + ok(bitmap.bmWidthBytes == screen_bpp, "%ld\n", bitmap.bmWidthBytes); ok(bitmap.bmPlanes == 1, "%d\n", bitmap.bmPlanes); - ok(bitmap.bmBitsPixel == 32, "%d\n", bitmap.bmBitsPixel); - ok(bitmap.bmBits == NULL, "\n"); - + ok(bitmap.bmBitsPixel == screen_bpp, "%d\n", bitmap.bmBitsPixel); + ok(bitmap.bmBits == NULL, "\n"); + DeleteObject(iconinfo2.hbmMask); + DeleteObject(iconinfo2.hbmColor); + ok(DestroyIcon(hicon), "\n"); } @@ -140,9 +148,15 @@ ICONINFO iconinfo2; BITMAP bitmap; DWORD data[] = {0, 0, 0, 0, 0, 0}; - - Test_GetIconInfo(0); - Test_GetIconInfo(1); + DWORD bpp, screenbpp, creationbpp; + DEVMODEW dm; + + /* Test icons behaviour regarding display settings */ + EnumDisplaySettingsW(NULL, ENUM_CURRENT_SETTINGS, &dm); + screenbpp = dm.dmBitsPerPel; + + Test_GetIconInfo(0, screenbpp); + Test_GetIconInfo(1, screenbpp); hcursor = LoadCursor(GetModuleHandle(NULL), "TESTCURSOR"); ok(hcursor != 0, "should not fail, error %ld\n", GetLastError()); @@ -152,33 +166,82 @@ ok(iconinfo2.yHotspot == 29, "%ld\n", iconinfo2.yHotspot); ok(iconinfo2.hbmMask != NULL, "\n"); ok(iconinfo2.hbmColor != NULL, "\n"); - - hcursor = LoadIcon(GetModuleHandle(NULL), MAKEINTRESOURCE(IDI_TEST)); - ok(hcursor != 0, "should not fail\n"); - ok(GetIconInfo(hcursor, &iconinfo2), "\n"); - ok(iconinfo2.fIcon == 1, "\n"); - ok(iconinfo2.xHotspot == 16, "%ld\n", iconinfo2.xHotspot); - ok(iconinfo2.yHotspot == 16, "%ld\n", iconinfo2.yHotspot); - ok(iconinfo2.hbmMask != NULL, "\n"); - ok(iconinfo2.hbmColor != NULL, "\n"); - - ok(GetObject(iconinfo2.hbmMask, sizeof(bitmap), &bitmap), "GetObject failed\n"); - ok(bitmap.bmType == 0, "\n"); - ok(bitmap.bmWidth == 32, "%ld\n", bitmap.bmWidth); - ok(bitmap.bmHeight == 32, "\n"); - ok(bitmap.bmWidthBytes == 4, "\n"); - ok(bitmap.bmPlanes == 1, "\n"); - ok(bitmap.bmBitsPixel == 1, "\n"); - ok(bitmap.bmBits == NULL, "\n"); - - ok(GetObject(iconinfo2.hbmColor, sizeof(bitmap), &bitmap), "GetObject failed\n"); - ok(bitmap.bmType == 0, "\n"); - ok(bitmap.bmWidth == 32, "\n"); - ok(bitmap.bmHeight == 32, "\n"); - ok(bitmap.bmWidthBytes == 32 * bitmap.bmBitsPixel / 8, "\n"); - ok(bitmap.bmPlanes == 1, "\n"); - ok(bitmap.bmBitsPixel == 32, "\n"); - ok(bitmap.bmBits == NULL, "\n"); + /* Delete objects */ + DeleteObject(iconinfo2.hbmColor); + DeleteObject(iconinfo2.hbmMask); + /* Delete cursor */ + DestroyCursor(hcursor); + + /* To sum it up: + * There are two criteria when using icons: performance and aesthetics (=alpha channel). + * Performance asks for bit parity with the screen display. + * Aesthetics needs a 32bpp bitmap. + * The behaviour is basically : aesthetics first if already loaded. + * ie: if the 32bpp bitmap were already loaded because of previous display settings, always use it. + * Otherwise, use the bitmap matching the screen bit depth. + */ + + /* if we use LR_SHARED here, and reverse the loop (32->16), then hbmColor.bmBitsPixel is always 32. */ + for(creationbpp = 16; creationbpp <=32; creationbpp += 8) + { + dm.dmBitsPerPel = creationbpp; + if(ChangeDisplaySettingsExW(NULL, &dm, NULL, 0, NULL) != DISP_CHANGE_SUCCESSFUL) + { + skip("Unable to change bpp to %lu.\n", creationbpp); + continue; + } + hcursor = LoadImage(GetModuleHandle(NULL), + MAKEINTRESOURCE(IDI_TEST), + IMAGE_ICON, + 0, + 0, + LR_DEFAULTCOLOR); + ok(hcursor != 0, "should not fail\n"); + + /* If we reverse the loop here (32->16 bpp), then hbmColor.bmBitsPixel is always 32 */ + for(bpp = 16; bpp <=32; bpp += 8) + { + dm.dmBitsPerPel = bpp; + if(ChangeDisplaySettingsExW(NULL, &dm, NULL, 0, NULL) != DISP_CHANGE_SUCCESSFUL) + { + skip("Unable to change bpp to %lu.\n", bpp); + continue; + } + ok(GetIconInfo(hcursor, &iconinfo2), "\n"); + ok(iconinfo2.fIcon == 1, "\n"); + ok(iconinfo2.xHotspot == 24, "%ld\n", iconinfo2.xHotspot); + ok(iconinfo2.yHotspot == 24, "%ld\n", iconinfo2.yHotspot); + ok(iconinfo2.hbmMask != NULL, "\n"); + ok(iconinfo2.hbmColor != NULL, "\n"); + + ok(GetObject(iconinfo2.hbmMask, sizeof(bitmap), &bitmap), "GetObject failed\n"); + ok(bitmap.bmType == 0, "\n"); + ok(bitmap.bmWidth == 48, "%ld\n", bitmap.bmWidth); + ok(bitmap.bmHeight == 48, "\n"); + ok(bitmap.bmWidthBytes == 6, "\n"); + ok(bitmap.bmPlanes == 1, "\n"); + ok(bitmap.bmBitsPixel == 1, "\n"); + ok(bitmap.bmBits == NULL, "\n"); + + ok(GetObject(iconinfo2.hbmColor, sizeof(bitmap), &bitmap), "GetObject failed\n"); + ok(bitmap.bmType == 0, "\n"); + ok(bitmap.bmWidth == 48, "\n"); + ok(bitmap.bmHeight == 48, "\n"); + ok(bitmap.bmWidthBytes == 48 * bitmap.bmBitsPixel / 8, "\n"); + ok(bitmap.bmPlanes == 1, "\n"); + ok(bitmap.bmBitsPixel == (creationbpp == 32 ? 32 : bpp), "creationbpp: %lu, bpp: %lu:\n", creationbpp, bpp); + ok(bitmap.bmBits == NULL, "\n"); + + /* Delete objects */ + DeleteObject(iconinfo2.hbmColor); + DeleteObject(iconinfo2.hbmMask); + } + ok(DestroyIcon(hcursor), "\n"); + } + /* Restore display settings */ + dm.dmBitsPerPel = screenbpp; + if(ChangeDisplaySettingsExW(NULL, &dm, NULL, 0, NULL) != DISP_CHANGE_SUCCESSFUL) + trace("Unable to go back to previous display settings. Sorry.\n"); hcursor = CreateCursor(NULL, 1, 2, 4, 4, data, data); ok(hcursor != 0, "should not fail\n"); @@ -197,7 +260,12 @@ ok(bitmap.bmPlanes == 1, "\n"); ok(bitmap.bmBitsPixel == 1, "\n"); ok(bitmap.bmBits == NULL, "\n"); - + + /* Delete objects */ + DeleteObject(iconinfo2.hbmColor); + DeleteObject(iconinfo2.hbmMask); + /* Delete cursor */ + DestroyCursor(hcursor); }

12 years, 2 months

[ion] 57476: [RTL]: CORE-6713 #resolve #time 10m #comment Use explicit checks when checking for present and default flags, just like Windows. Fixes winetest regressions.

by ion＠svn.reactos.org

Author: ion Date: Thu Oct 4 06:28:58 2012 New Revision: 57476 URL: http://svn.reactos.org/svn/reactos?rev=57476&view=rev Log: [RTL]: CORE-6713 #resolve #time 10m #comment Use explicit checks when checking for present and default flags, just like Windows. Fixes winetest regressions. Modified: trunk/reactos/lib/rtl/sd.c Modified: trunk/reactos/lib/rtl/sd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/sd.c?rev=57476&r1=… ============================================================================== --- trunk/reactos/lib/rtl/sd.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/sd.c [iso-8859-1] Thu Oct 4 06:28:58 2012 @@ -208,12 +208,12 @@ if (Sd->Revision != SECURITY_DESCRIPTOR_REVISION) return STATUS_UNKNOWN_REVISION; /* Is there a DACL? */ - *DaclPresent = Sd->Control & SE_DACL_PRESENT; + *DaclPresent = (Sd->Control & SE_DACL_PRESENT) == SE_DACL_PRESENT; if (*DaclPresent) { /* Yes, return it, and check if defaulted */ *Dacl = SepGetDaclFromDescriptor(Sd); - *DaclDefaulted = Sd->Control & SE_DACL_DEFAULTED; + *DaclDefaulted = (Sd->Control & SE_DACL_DEFAULTED) == SE_DACL_DEFAULTED; } /* All good */ @@ -237,12 +237,12 @@ if (Sd->Revision != SECURITY_DESCRIPTOR_REVISION) return STATUS_UNKNOWN_REVISION; /* Is there a SACL? */ - *SaclPresent = Sd->Control & SE_SACL_PRESENT; + *SaclPresent = (Sd->Control & SE_SACL_PRESENT) == SE_SACL_PRESENT; if (*SaclPresent) { /* Yes, return it, and check if defaulted */ *Sacl = SepGetSaclFromDescriptor(Sd); - *SaclDefaulted = Sd->Control & SE_SACL_DEFAULTED; + *SaclDefaulted = (Sd->Control & SE_SACL_DEFAULTED) == SE_SACL_DEFAULTED; } /* All good */ @@ -266,7 +266,7 @@ /* Get the owner and if defaulted */ *Owner = SepGetOwnerFromDescriptor(Sd); - *OwnerDefaulted = Sd->Control & SE_OWNER_DEFAULTED; + *OwnerDefaulted = (Sd->Control & SE_OWNER_DEFAULTED) == SE_OWNER_DEFAULTED; /* All good */ return STATUS_SUCCESS; @@ -289,7 +289,7 @@ /* Get the group and if defaulted */ *Group = SepGetGroupFromDescriptor(Sd); - *GroupDefaulted = Sd->Control & SE_GROUP_DEFAULTED; + *GroupDefaulted = (Sd->Control & SE_GROUP_DEFAULTED) == SE_GROUP_DEFAULTED; /* All good */ return STATUS_SUCCESS; @@ -1164,7 +1164,7 @@ } /* Is there a DACL? */ - if (Sd->Control & SE_DACL_PRESENT) + if ((Sd->Control & SE_DACL_PRESENT) == SE_DACL_PRESENT) { /* Try to access it */ if (!RtlpValidateSDOffsetAndSize(Sd->Dacl, @@ -1182,7 +1182,7 @@ } /* Is there a SACL? */ - if (Sd->Control & SE_SACL_PRESENT) + if ((Sd->Control & SE_SACL_PRESENT) == SE_SACL_PRESENT) { /* Try to access it */ if (!RtlpValidateSDOffsetAndSize(Sd->Sacl,

12 years, 2 months

[ion] 57475: [NTOSKRNL]: CORE-6698 #resolve #time 5m #comment Add correct error handling during session space view mapping.

by ion＠svn.reactos.org

Author: ion Date: Thu Oct 4 06:19:42 2012 New Revision: 57475 URL: http://svn.reactos.org/svn/reactos?rev=57475&view=rev Log: [NTOSKRNL]: CORE-6698 #resolve #time 5m #comment Add correct error handling during session space view mapping. Modified: trunk/reactos/ntoskrnl/mm/ARM3/section.c Modified: trunk/reactos/ntoskrnl/mm/ARM3/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/section.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/section.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/section.c [iso-8859-1] Thu Oct 4 06:19:42 2012 @@ -1021,8 +1021,10 @@ /* Check if the caller wanted a larger section than the view */ if (*ViewSize > SectionSize) { - /* We should probably fail. FIXME TODO */ - ASSERT(FALSE); + /* Fail */ + DPRINT1("View is too large\n"); + MiDereferenceControlArea(ControlArea); + return STATUS_INVALID_VIEW_SIZE; } /* Get the number of 64K buckets required for this mapping */ @@ -1032,14 +1034,22 @@ /* Check if the view is more than 4GB large */ if (Buckets >= MI_SYSTEM_VIEW_BUCKET_SIZE) { - /* We should probably fail */ - ASSERT(FALSE); + /* Fail */ + DPRINT1("View is too large\n"); + MiDereferenceControlArea(ControlArea); + return STATUS_INVALID_VIEW_SIZE; } /* Insert this view into system space and get a base address for it */ Base = MiInsertInSystemSpace(Session, Buckets, ControlArea); - ASSERT(Base); - + if (!Base) + { + /* Fail */ + DPRINT1("Out of system space\n"); + MiDereferenceControlArea(ControlArea); + return STATUS_NO_MEMORY; + } + /* What's the underlying session? */ if (Session == &MmSession) {

12 years, 2 months

[ion] 57474: [NTOS]: CORE-6204 #resolve #time 10m #comment Do not touch NextEntry after removing it, instead restart the scan at the head of the list (checked against w2k3sp1).

by ion＠svn.reactos.org

Author: ion Date: Thu Oct 4 06:16:53 2012 New Revision: 57474 URL: http://svn.reactos.org/svn/reactos?rev=57474&view=rev Log: [NTOS]: CORE-6204 #resolve #time 10m #comment Do not touch NextEntry after removing it, instead restart the scan at the head of the list (checked against w2k3sp1). Modified: trunk/reactos/ntoskrnl/ke/thrdobj.c Modified: trunk/reactos/ntoskrnl/ke/thrdobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/thrdobj.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ke/thrdobj.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/thrdobj.c [iso-8859-1] Thu Oct 4 06:16:53 2012 @@ -470,9 +470,6 @@ 0); } - /* Move on, but save NextEntry before we remove */ - NextEntry = NextEntry->Flink; - /* Now we can remove it */ RemoveEntryList(&Mutant->MutantListEntry); @@ -487,6 +484,9 @@ /* Wake the Mutant */ KiWaitTest(&Mutant->Header, MUTANT_INCREMENT); } + + /* Move on */ + NextEntry = Thread->MutantListHead.Flink; } /* Release the Lock */

12 years, 2 months

[hbelusca] 57473: [REGEDIT] ... and this line of code (I'm sorry for the generated noise :-( )

by hbelusca＠svn.reactos.org

Author: hbelusca Date: Wed Oct 3 22:51:53 2012 New Revision: 57473 URL: http://svn.reactos.org/svn/reactos?rev=57473&view=rev Log: [REGEDIT] ... and this line of code (I'm sorry for the generated noise :-( ) Modified: trunk/reactos/base/applications/regedit/main.c Modified: trunk/reactos/base/applications/regedit/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/main.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/main.c [iso-8859-1] Wed Oct 3 22:51:53 2012 @@ -197,7 +197,6 @@ UNREFERENCED_PARAMETER(hPrevInstance); - InfoMessageBox(NULL, MB_OK | MB_ICONERROR, L"Main", L"Main '%1'", lpCmdLine); if (ProcessCmdLine(lpCmdLine)) { return 0;

12 years, 2 months

[hbelusca] 57472: [REGEDIT] - Forgot to remove a comment

by hbelusca＠svn.reactos.org

Author: hbelusca Date: Wed Oct 3 22:50:06 2012 New Revision: 57472 URL: http://svn.reactos.org/svn/reactos?rev=57472&view=rev Log: [REGEDIT] - Forgot to remove a comment Modified: trunk/reactos/base/applications/regedit/regedit.h Modified: trunk/reactos/base/applications/regedit/regedit.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… ============================================================================== --- trunk/reactos/base/applications/regedit/regedit.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/regedit/regedit.h [iso-8859-1] Wed Oct 3 22:50:06 2012 @@ -12,7 +12,6 @@ #include <shellapi.h> #include <shlwapi.h> #include <stdlib.h> -//#include <tchar.h> #include <process.h> #include <stdio.h> #include <limits.h>

12 years, 2 months

[hbelusca] 57471: [REGEDIT] - Convert the application's code to UNICODE - But the regproc.c's code is untouched (apart from the pseudo-error messages issued with fprintf)

by hbelusca＠svn.reactos.org

Author: hbelusca Date: Wed Oct 3 22:42:34 2012 New Revision: 57471 URL: http://svn.reactos.org/svn/reactos?rev=57471&view=rev Log: [REGEDIT] - Convert the application's code to UNICODE - But the regproc.c's code is untouched (apart from the pseudo-error messages issued with fprintf) Modified: trunk/reactos/base/applications/regedit/about.c trunk/reactos/base/applications/regedit/childwnd.c trunk/reactos/base/applications/regedit/edit.c trunk/reactos/base/applications/regedit/error.c trunk/reactos/base/applications/regedit/find.c trunk/reactos/base/applications/regedit/framewnd.c trunk/reactos/base/applications/regedit/hexedit.c trunk/reactos/base/applications/regedit/hexedit.h trunk/reactos/base/applications/regedit/listview.c trunk/reactos/base/applications/regedit/main.c trunk/reactos/base/applications/regedit/main.h trunk/reactos/base/applications/regedit/regedit.c trunk/reactos/base/applications/regedit/regedit.h trunk/reactos/base/applications/regedit/regproc.c trunk/reactos/base/applications/regedit/regproc.h trunk/reactos/base/applications/regedit/resource.h trunk/reactos/base/applications/regedit/security.c trunk/reactos/base/applications/regedit/security.h trunk/reactos/base/applications/regedit/settings.c trunk/reactos/base/applications/regedit/treeview.c [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/base/applications/regedit/about.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/childwnd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/edit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/error.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/find.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/framewnd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/hexedit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/hexedit.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/listview.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/main.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/regedit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/regedit.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/regproc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/regproc.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/resource.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/security.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/security.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/settings.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/… Modified: trunk/reactos/base/applications/regedit/treeview.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/regedit/…

12 years, 2 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs October 2012