Ros-diffs April 2012

ros-diffs@reactos.org

11 participants
156 discussions

[akhaldi] 56343: [NTKRNLMP] * Properly set the exports to refer to ntkrnlmp.exe instead of ntoskrnl.exe.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Fri Apr 13 21:35:00 2012 New Revision: 56343 URL: http://svn.reactos.org/svn/reactos?rev=56343&view=rev Log: [NTKRNLMP] * Properly set the exports to refer to ntkrnlmp.exe instead of ntoskrnl.exe. Modified: trunk/reactos/ntoskrnl/CMakeLists.txt Modified: trunk/reactos/ntoskrnl/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/CMakeLists.txt?re… ============================================================================== --- trunk/reactos/ntoskrnl/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/CMakeLists.txt [iso-8859-1] Fri Apr 13 21:35:00 2012 @@ -273,8 +273,7 @@ se/token.c vf/driver.c wmi/wmi.c - ntoskrnl.rc - ${CMAKE_CURRENT_BINARY_DIR}/ntoskrnl.def) + ntoskrnl.rc) if(ARCH MATCHES i386) list(APPEND SOURCE @@ -423,7 +422,9 @@ endif() -add_executable(ntoskrnl ${SOURCE}) +add_executable(ntoskrnl + ${SOURCE} + ${CMAKE_CURRENT_BINARY_DIR}/ntoskrnl.def) if (ARCH MATCHES i386) set_entrypoint(ntoskrnl KiSystemStartup 4) @@ -462,7 +463,12 @@ add_cd_file(TARGET ntoskrnl DESTINATION reactos/system32 NO_CAB FOR all) if(BUILD_MP) - add_executable(ntkrnlmp ${SOURCE}) + spec2def(ntkrnlmp.exe ntoskrnl.spec) + + add_executable(ntkrnlmp + ${SOURCE} + ${CMAKE_CURRENT_BINARY_DIR}/ntkrnlmp.def) + add_target_compile_definitions(ntkrnlmp CONFIG_SMP) if(ARCH MATCHES i386)

12 years, 8 months

[tkreuzer] 56342: [WIN32K] Fix path reference leaks in PATH_add_outline Should fix failed assertion when closing google earth. thanks to r3ddr4g0n for providing the neccessary debug info.

by tkreuzer＠svn.reactos.org

Author: tkreuzer Date: Fri Apr 13 18:33:56 2012 New Revision: 56342 URL: http://svn.reactos.org/svn/reactos?rev=56342&view=rev Log: [WIN32K] Fix path reference leaks in PATH_add_outline Should fix failed assertion when closing google earth. thanks to r3ddr4g0n for providing the neccessary debug info. Modified: trunk/reactos/win32ss/gdi/ntgdi/path.c Modified: trunk/reactos/win32ss/gdi/ntgdi/path.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/path.c?r… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/path.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/path.c [iso-8859-1] Fri Apr 13 18:33:56 2012 @@ -2005,10 +2005,12 @@ PPATH pPath; TTPOLYGONHEADER *start; POINT pt; + BOOL bResult = FALSE; start = header; pPath = PATH_LockPath(dc->dclevel.hPath); + if (!pPath) { return FALSE; } @@ -2020,7 +2022,7 @@ if (header->dwType != TT_POLYGON_TYPE) { DPRINT1("Unknown header type %d\n", header->dwType); - return FALSE; + goto cleanup; } pt.x = x + int_from_fixed(header->pfxStart.x); @@ -2055,7 +2057,7 @@ POINTFX ptfx; POINT *pts = ExAllocatePoolWithTag(PagedPool, (curve->cpfx + 1) * sizeof(POINT), TAG_PATH); - if (!pts) return FALSE; + if (!pts) goto cleanup; ptfx = *(POINTFX *)((char *)curve - sizeof(POINTFX)); @@ -2076,7 +2078,7 @@ default: DPRINT1("Unknown curve type %04x\n", curve->wType); - return FALSE; + goto cleanup; } curve = (TTPOLYCURVE *)&curve->apfx[curve->cpfx]; @@ -2084,9 +2086,12 @@ header = (TTPOLYGONHEADER *)((char *)header + header->cb); } + bResult = TRUE; + +cleanup: IntGdiCloseFigure( pPath ); PATH_UnlockPath( pPath ); - return TRUE; + return bResult; } /**********************************************************************

12 years, 8 months

[tkreuzer] 56341: [WIN32K] Fix indentation and the name of the programmer who dared to use GNU style indentation.

by tkreuzer＠svn.reactos.org

Author: tkreuzer Date: Fri Apr 13 16:27:14 2012 New Revision: 56341 URL: http://svn.reactos.org/svn/reactos?rev=56341&view=rev Log: [WIN32K] Fix indentation and the name of the programmer who dared to use GNU style indentation. Modified: trunk/reactos/win32ss/gdi/eng/float.c Modified: trunk/reactos/win32ss/gdi/eng/float.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/eng/float.c?re… ============================================================================== --- trunk/reactos/win32ss/gdi/eng/float.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/eng/float.c [iso-8859-1] Fri Apr 13 16:27:14 2012 @@ -1,9 +1,9 @@ -/* +/* * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS kernel * PURPOSE: Engine floating point functions * FILE: subsys/win32k/eng/float.c - * PROGRAMER: Jason Filby + * PROGRAMER: David Welch */ /* INCLUDES *****************************************************************/ @@ -17,43 +17,53 @@ BOOL APIENTRY -EngRestoreFloatingPointState ( IN VOID *Buffer ) +EngRestoreFloatingPointState( + IN VOID *Buffer) { - NTSTATUS Status; - Status = KeRestoreFloatingPointState((PKFLOATING_SAVE)Buffer); - if (!NT_SUCCESS(Status)) + NTSTATUS Status; + + Status = KeRestoreFloatingPointState((PKFLOATING_SAVE)Buffer); + if (!NT_SUCCESS(Status)) { - return FALSE; + return FALSE; } - return TRUE; + + return TRUE; } ULONG APIENTRY -EngSaveFloatingPointState(OUT VOID *Buffer, - IN ULONG BufferSize) +EngSaveFloatingPointState( + OUT VOID *Buffer, + IN ULONG BufferSize) { - KFLOATING_SAVE TempBuffer; - NTSTATUS Status; - if (Buffer == NULL || BufferSize == 0) + KFLOATING_SAVE TempBuffer; + NTSTATUS Status; + + if ((Buffer == NULL) || (BufferSize == 0)) { - /* Check for floating point support. */ - Status = KeSaveFloatingPointState(&TempBuffer); - if (Status != STATUS_SUCCESS) - { - return(0); - } - KeRestoreFloatingPointState(&TempBuffer); - return(sizeof(KFLOATING_SAVE)); + /* Check for floating point support. */ + Status = KeSaveFloatingPointState(&TempBuffer); + if (Status != STATUS_SUCCESS) + { + return(0); + } + + KeRestoreFloatingPointState(&TempBuffer); + return(sizeof(KFLOATING_SAVE)); } - if (BufferSize < sizeof(KFLOATING_SAVE)) + + if (BufferSize < sizeof(KFLOATING_SAVE)) { - return(0); + return(0); } - Status = KeSaveFloatingPointState((PKFLOATING_SAVE)Buffer); - if (!NT_SUCCESS(Status)) + + Status = KeSaveFloatingPointState((PKFLOATING_SAVE)Buffer); + if (!NT_SUCCESS(Status)) { - return FALSE; + return FALSE; } - return TRUE; + + return TRUE; } +

12 years, 8 months

[akhaldi] 56340: [NTKRNLMP] * Add to build. Dedicated to Stefan.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Fri Apr 13 16:16:39 2012 New Revision: 56340 URL: http://svn.reactos.org/svn/reactos?rev=56340&view=rev Log: [NTKRNLMP] * Add to build. Dedicated to Stefan. Modified: trunk/reactos/ntoskrnl/CMakeLists.txt Modified: trunk/reactos/ntoskrnl/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/CMakeLists.txt?re… ============================================================================== --- trunk/reactos/ntoskrnl/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/CMakeLists.txt [iso-8859-1] Fri Apr 13 16:16:39 2012 @@ -461,5 +461,32 @@ add_cd_file(TARGET ntoskrnl DESTINATION reactos/system32 NO_CAB FOR all) +if(BUILD_MP) + add_executable(ntkrnlmp ${SOURCE}) + add_target_compile_definitions(ntkrnlmp CONFIG_SMP) + + if(ARCH MATCHES i386) + set_entrypoint(ntkrnlmp KiSystemStartup 4) + else() + set_entrypoint(ntkrnlmp KiSystemStartup) + endif() + set_subsystem(ntkrnlmp native) + + if(MSVC) + set_image_base(ntkrnlmp 0x00400000) + else() + set_image_base(ntkrnlmp 0x80800000) + endif() + + # Linker bug + if(NOT MSVC AND LTCG) + add_target_link_flags(ntkrnlmp "-shared") + endif() + + target_link_libraries(ntkrnlmp cportlib csq ${PSEH_LIB} cmlib rtl rossym libcntpr wdmguid ioevent) + add_importlibs(ntkrnlmp hal kdcom bootvid) + add_dependencies(ntkrnlmp psdk bugcodes asm) + add_cd_file(TARGET ntkrnlmp DESTINATION reactos/system32 NO_CAB FOR all) +endif() add_library(ntdllsys ntdll.S)

12 years, 8 months

[spetreolle] 56339: [MSI] Workaround crash for installers that require image binding. Suggested by Amine.

by spetreolle＠svn.reactos.org

Author: spetreolle Date: Thu Apr 12 17:08:38 2012 New Revision: 56339 URL: http://svn.reactos.org/svn/reactos?rev=56339&view=rev Log: [MSI] Workaround crash for installers that require image binding. Suggested by Amine. Modified: trunk/reactos/dll/win32/msi/CMakeLists.txt Modified: trunk/reactos/dll/win32/msi/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msi/CMakeLists.t… ============================================================================== --- trunk/reactos/dll/win32/msi/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msi/CMakeLists.txt [iso-8859-1] Thu Apr 12 17:08:38 2012 @@ -74,8 +74,7 @@ set_module_type(msi win32dll) target_link_libraries(msi uuid ${PSEH_LIB} wine) add_dependencies(msi msi_idlheader) -add_delay_importlibs(msi odbccp32 crypt32 imagehlp wintrust) - +add_delay_importlibs(msi odbccp32 crypt32 wintrust) add_importlibs(msi advapi32 cabinet @@ -89,6 +88,8 @@ user32 version wininet +#fixme : should be in delayed imports + imagehlp msvcrt kernel32 ntdll)

12 years, 8 months

[ekohl] 56338: [SERVICES] Log failed service starts and stops.

by ekohl＠svn.reactos.org

Author: ekohl Date: Sun Apr 8 22:27:44 2012 New Revision: 56338 URL: http://svn.reactos.org/svn/reactos?rev=56338&view=rev Log: [SERVICES] Log failed service starts and stops. Modified: trunk/reactos/base/system/services/database.c trunk/reactos/base/system/services/rpcserver.c Modified: trunk/reactos/base/system/services/database.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/datab… ============================================================================== --- trunk/reactos/base/system/services/database.c [iso-8859-1] (original) +++ trunk/reactos/base/system/services/database.c [iso-8859-1] Sun Apr 8 22:27:44 2012 @@ -1617,6 +1617,7 @@ PSERVICE_GROUP Group = Service->lpGroup; DWORD dwError = ERROR_SUCCESS; LPCWSTR ErrorLogStrings[2]; + WCHAR szErrorBuffer[32]; DPRINT("ScmStartService() called\n"); @@ -1681,8 +1682,10 @@ { if (Service->dwErrorControl != SERVICE_ERROR_IGNORE) { + /* Log a failed service start */ + swprintf(szErrorBuffer, L"%lu", dwError); ErrorLogStrings[0] = Service->lpServiceName; - ErrorLogStrings[1] = L"Test"; + ErrorLogStrings[1] = szErrorBuffer; ScmLogError(EVENT_SERVICE_START_FAILED, 2, ErrorLogStrings); Modified: trunk/reactos/base/system/services/rpcserver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/rpcse… ============================================================================== --- trunk/reactos/base/system/services/rpcserver.c [iso-8859-1] (original) +++ trunk/reactos/base/system/services/rpcserver.c [iso-8859-1] Sun Apr 8 22:27:44 2012 @@ -1619,6 +1619,9 @@ LPSERVICE_STATUS lpServiceStatus) { PSERVICE lpService; + DWORD dwPreviousState; + LPCWSTR lpErrorStrings[2]; + WCHAR szErrorBuffer[32]; DPRINT("RSetServiceStatus() called\n"); DPRINT("hServiceStatus = %p\n", hServiceStatus); @@ -1668,12 +1671,31 @@ /* Lock the service database exclusively */ ScmLockDatabaseExclusive(); + /* Save the current service state */ + dwPreviousState = lpService->Status.dwCurrentState; + RtlCopyMemory(&lpService->Status, lpServiceStatus, sizeof(SERVICE_STATUS)); /* Unlock the service database */ ScmUnlockDatabase(); + + /* Log a failed service stop */ + if ((lpServiceStatus->dwCurrentState == SERVICE_STOPPED) && + (dwPreviousState != SERVICE_STOPPED)) + { + if (lpServiceStatus->dwWin32ExitCode != ERROR_SUCCESS) + { + swprintf(szErrorBuffer, L"%lu", lpServiceStatus->dwWin32ExitCode); + lpErrorStrings[0] = lpService->lpDisplayName; + lpErrorStrings[1] = szErrorBuffer; + + ScmLogError(EVENT_SERVICE_EXIT_FAILED, + 2, + lpErrorStrings); + } + } DPRINT("Set %S to %lu\n", lpService->lpDisplayName, lpService->Status.dwCurrentState); DPRINT("RSetServiceStatus() done\n");

12 years, 8 months

[ekohl] 56337: [SERVICES] - Make the handle to the shutdown event a global handle and set it when the service manager is being shut down. - Close the start event properly.

by ekohl＠svn.reactos.org

Author: ekohl Date: Sun Apr 8 21:06:32 2012 New Revision: 56337 URL: http://svn.reactos.org/svn/reactos?rev=56337&view=rev Log: [SERVICES] - Make the handle to the shutdown event a global handle and set it when the service manager is being shut down. - Close the start event properly. Modified: trunk/reactos/base/system/services/services.c Modified: trunk/reactos/base/system/services/services.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/services/servi… ============================================================================== --- trunk/reactos/base/system/services/services.c [iso-8859-1] (original) +++ trunk/reactos/base/system/services/services.c [iso-8859-1] Sun Apr 8 21:06:32 2012 @@ -27,6 +27,7 @@ #define PIPE_TIMEOUT 1000 BOOL ScmShutdown = FALSE; +static HANDLE hScmShutdownEvent = NULL; /* FUNCTIONS *****************************************************************/ @@ -358,6 +359,9 @@ ScmAutoShutdownServices(); ScmShutdownServiceDatabase(); + + /* Set the shutdwon event */ + SetEvent(hScmShutdownEvent); } return TRUE; @@ -371,7 +375,6 @@ int nShowCmd) { HANDLE hScmStartEvent; - HANDLE hEvent; DWORD dwError; DPRINT("SERVICES: Service Control Manager\n"); @@ -395,6 +398,7 @@ if (dwError != ERROR_SUCCESS) { DPRINT1("SERVICES: failed to create SCM database (Error %lu)\n", dwError); + CloseHandle(hScmStartEvent); ExitThread(0); } @@ -431,19 +435,17 @@ DPRINT("SERVICES: Running.\n"); -#if 1 - hEvent = CreateEvent(NULL, TRUE, FALSE, NULL); - if (hEvent) - WaitForSingleObject(hEvent, INFINITE); -#else - for (;;) - { - NtYieldExecution(); - } -#endif + /* Create the shutdown event and wait until it gets set */ + hScmShutdownEvent = CreateEvent(NULL, TRUE, FALSE, NULL); + if (hScmShutdownEvent) + WaitForSingleObject(hScmShutdownEvent, INFINITE); ScmDeleteNamedPipeCriticalSection(); + /* Close the shutdown event */ + CloseHandle(hScmShutdownEvent); + + /* Close the start event */ CloseHandle(hScmStartEvent); DPRINT("SERVICES: Finished.\n");

12 years, 8 months

[sginsberg] 56336: - There is no need for the i8042 driver to use a hacked KdSystemDebugControl call to breakpoint or crash on TAB+k/TAB+b. Just call DbgBreakPoint or KeBugCheck directly.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Sun Apr 8 15:57:04 2012 New Revision: 56336 URL: http://svn.reactos.org/svn/reactos?rev=56336&view=rev Log: - There is no need for the i8042 driver to use a hacked KdSystemDebugControl call to breakpoint or crash on TAB+k/TAB+b. Just call DbgBreakPoint or KeBugCheck directly. Modified: trunk/reactos/drivers/input/i8042prt/keyboard.c trunk/reactos/ntoskrnl/kd/kdmain.c trunk/reactos/ntoskrnl/kd64/kdapi.c Modified: trunk/reactos/drivers/input/i8042prt/keyboard.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/input/i8042prt/key… ============================================================================== --- trunk/reactos/drivers/input/i8042prt/keyboard.c [iso-8859-1] (original) +++ trunk/reactos/drivers/input/i8042prt/keyboard.c [iso-8859-1] Sun Apr 8 15:57:04 2012 @@ -812,16 +812,30 @@ else if (DeviceExtension->TabPressed) { DeviceExtension->TabPressed = FALSE; - - /* Send request to the kernel debugger. - * Unknown requests will be ignored. */ - KdSystemDebugControl(' soR', - (PVOID)(ULONG_PTR)InputData->MakeCode, - 0, - NULL, - 0, - NULL, - KernelMode); + + /* Check which action to do */ + if (InputData->MakeCode == 0x25) + { + /* k - Breakpoint */ + DbgBreakPoint(); + } + else if (InputData->MakeCode == 0x30) + { + /* b - Bugcheck */ + KeBugCheck(MANUALLY_INITIATED_CRASH); + } + else + { + /* Send request to the kernel debugger. + * Unknown requests will be ignored. */ + KdSystemDebugControl(' soR', + (PVOID)(ULONG_PTR)InputData->MakeCode, + 0, + NULL, + 0, + NULL, + KernelMode); + } } } Modified: trunk/reactos/ntoskrnl/kd/kdmain.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd/kdmain.c?rev=5… ============================================================================== --- trunk/reactos/ntoskrnl/kd/kdmain.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd/kdmain.c [iso-8859-1] Sun Apr 8 15:57:04 2012 @@ -56,20 +56,12 @@ { switch ((ULONG_PTR)Buffer1) { - case ManualBugCheck: - KeBugCheck(MANUALLY_INITIATED_CRASH); - break; - case DumpAllThreads: PspDumpThreads(TRUE); break; case DumpUserThreads: PspDumpThreads(FALSE); - break; - - case EnterDebugger: - DbgBreakPoint(); break; case KdSpare3: Modified: trunk/reactos/ntoskrnl/kd64/kdapi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/kd64/kdapi.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/kd64/kdapi.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/kd64/kdapi.c [iso-8859-1] Sun Apr 8 15:57:04 2012 @@ -1953,14 +1953,6 @@ { switch ((ULONG_PTR)InputBuffer) { - case 0x30: // ManualBugCheck: - KeBugCheck(MANUALLY_INITIATED_CRASH); - break; - - case 0x25: // EnterDebugger: - DbgBreakPoint(); - break; - case 0x24: MmDumpArmPfnDatabase(FALSE); break;

12 years, 8 months

[sginsberg] 56335: - It seems the remaining page fault issue was fixed as well in 56333, so it should now be safe to enable this check. Finally, it is now illegal to page fault in ReactOS with inte...

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Sat Apr 7 01:18:36 2012 New Revision: 56335 URL: http://svn.reactos.org/svn/reactos?rev=56335&view=rev Log: - It seems the remaining page fault issue was fixed as well in 56333, so it should now be safe to enable this check. Finally, it is now illegal to page fault in ReactOS with interrupts disabled, as it should be. Previous attempts to fix this were likely hindered by the old memory manager, but ARM3 seems to do its job and doesn't fault on non-paged memory that I believe the old Mm was doing. - Hacks--; Modified: trunk/reactos/ntoskrnl/ke/i386/traphdlr.c Modified: trunk/reactos/ntoskrnl/ke/i386/traphdlr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/i386/traphdlr.… ============================================================================== --- trunk/reactos/ntoskrnl/ke/i386/traphdlr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/i386/traphdlr.c [iso-8859-1] Sat Apr 7 01:18:36 2012 @@ -1190,8 +1190,7 @@ /* Enable interupts */ _enable(); -#if 0 - /* Check if we faulted with interrupts disabled */ + /* Check if we came in with interrupts disabled */ if (!(TrapFrame->EFlags & EFLAGS_INTERRUPT_MASK)) { /* This is completely illegal, bugcheck the system */ @@ -1202,14 +1201,6 @@ TrapFrame->Eip, TrapFrame); } -#else - if (!(TrapFrame->EFlags & EFLAGS_INTERRUPT_MASK)) - { - /* Warn and dump stack */ - DPRINT1("Page fault with interrupts disabled!\n"); - KeRosDumpStackFrames(NULL, 0); - } -#endif /* Check for S-LIST fault in kernel mode */ if (TrapFrame->Eip == (ULONG_PTR)ExpInterlockedPopEntrySListFault)

12 years, 8 months

[sginsberg] 56334: - Add missing newline to debug print.

by sginsberg＠svn.reactos.org

Author: sginsberg Date: Fri Apr 6 21:01:17 2012 New Revision: 56334 URL: http://svn.reactos.org/svn/reactos?rev=56334&view=rev Log: - Add missing newline to debug print. Modified: trunk/reactos/ntoskrnl/mm/ARM3/expool.c Modified: trunk/reactos/ntoskrnl/mm/ARM3/expool.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/expool.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/expool.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/expool.c [iso-8859-1] Fri Apr 6 21:01:17 2012 @@ -1256,7 +1256,7 @@ // This means there's no free hash buckets whatsoever, so we would now have // to attempt expanding the table // - DPRINT1("Big pool expansion needed, not implemented!"); + DPRINT1("Big pool expansion needed, not implemented!\n"); KeReleaseSpinLock(&ExpLargePoolTableLock, OldIrql); return FALSE; }

12 years, 8 months

← Newer
1
...
9
10
11
12
13
14
15
16
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs April 2012