Ros-diffs September 2012

ros-diffs@reactos.org

17 participants
236 discussions

[ekohl] 57417: [LSASRV] Update LsarQueryDomainInformationPolicy and LsarSetDomainInformationPolicy according to the changes in the IDL file.
by ekohl＠svn.reactos.org 28 Sep '12

28 Sep '12

Author: ekohl Date: Fri Sep 28 22:18:59 2012 New Revision: 57417 URL: http://svn.reactos.org/svn/reactos?rev=57417&view=rev Log: [LSASRV] Update LsarQueryDomainInformationPolicy and LsarSetDomainInformationPolicy according to the changes in the IDL file. Modified: trunk/reactos/dll/win32/lsasrv/lsarpc.c Modified: trunk/reactos/dll/win32/lsasrv/lsarpc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/lsasrv/lsarpc.c?… ============================================================================== --- trunk/reactos/dll/win32/lsasrv/lsarpc.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/lsasrv/lsarpc.c [iso-8859-1] Fri Sep 28 22:18:59 2012 @@ -1869,7 +1869,7 @@ NTSTATUS WINAPI LsarQueryDomainInformationPolicy( LSAPR_HANDLE PolicyHandle, POLICY_INFORMATION_CLASS InformationClass, - unsigned long *PolicyInformation) + PLSAPR_POLICY_DOMAIN_INFORMATION *PolicyInformation) { UNIMPLEMENTED; return STATUS_NOT_IMPLEMENTED; @@ -1880,7 +1880,7 @@ NTSTATUS WINAPI LsarSetDomainInformationPolicy( LSAPR_HANDLE PolicyHandle, POLICY_INFORMATION_CLASS InformationClass, - unsigned long PolicyInformation) + PLSAPR_POLICY_DOMAIN_INFORMATION PolicyInformation) { UNIMPLEMENTED; return STATUS_NOT_IMPLEMENTED;

1 0

[ekohl] 57416: [ADVAPI32] Implement LsaGetRemoteUserName, LsaQueryDomainInformationPolicy and LsaSetDomainInformationPolicy.
by ekohl＠svn.reactos.org 28 Sep '12

28 Sep '12

Author: ekohl Date: Fri Sep 28 22:11:18 2012 New Revision: 57416 URL: http://svn.reactos.org/svn/reactos?rev=57416&view=rev Log: [ADVAPI32] Implement LsaGetRemoteUserName, LsaQueryDomainInformationPolicy and LsaSetDomainInformationPolicy. Modified: trunk/reactos/dll/win32/advapi32/sec/lsa.c trunk/reactos/include/reactos/idl/lsa.idl Modified: trunk/reactos/dll/win32/advapi32/sec/lsa.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/sec/lsa… ============================================================================== --- trunk/reactos/dll/win32/advapi32/sec/lsa.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/sec/lsa.c [iso-8859-1] Fri Sep 28 22:11:18 2012 @@ -688,9 +688,38 @@ OUT PLSA_UNICODE_STRING *UserName, OUT PLSA_UNICODE_STRING *DomainName OPTIONAL) { - FIXME("LsaGetUserName(%p %p %p)\n", - SystemName, UserName, DomainName); - return STATUS_NOT_IMPLEMENTED; + PRPC_UNICODE_STRING UserNameString = NULL; + PRPC_UNICODE_STRING DomainNameString = NULL; + NTSTATUS Status; + + TRACE("LsaGetRemoteUserName(%s %p %p)\n", + SystemName ? debugstr_w(SystemName->Buffer) : "(null)", + UserName, DomainName); + + RpcTryExcept + { + Status = LsarGetUserName((PLSAPR_SERVER_NAME)SystemName, + &UserNameString, + (DomainName != NULL) ? &DomainNameString : NULL); + + *UserName = (PLSA_UNICODE_STRING)UserNameString; + + if (DomainName != NULL) + *DomainName = (PLSA_UNICODE_STRING)DomainNameString; + } + RpcExcept(EXCEPTION_EXECUTE_HANDLER) + { + if (UserNameString != NULL) + MIDL_user_free(UserNameString); + + if (DomainNameString != NULL) + MIDL_user_free(DomainNameString); + + Status = I_RpcMapWin32Status(RpcExceptionCode()); + } + RpcEndExcept; + + return Status; } @@ -1227,7 +1256,7 @@ /* - * @unimplemented + * @implemented */ NTSTATUS WINAPI @@ -1235,9 +1264,30 @@ IN POLICY_DOMAIN_INFORMATION_CLASS InformationClass, OUT PVOID *Buffer) { - FIXME("LsaQueryDomainInformationPolicy(%p %lu %p) stub\n", + PLSAPR_POLICY_DOMAIN_INFORMATION PolicyInformation = NULL; + NTSTATUS Status; + + TRACE("LsaQueryDomainInformationPolicy(%p %lu %p)\n", PolicyHandle, InformationClass, Buffer); - return STATUS_NOT_IMPLEMENTED; + + RpcTryExcept + { + Status = LsarQueryDomainInformationPolicy((LSAPR_HANDLE)PolicyHandle, + InformationClass, + &PolicyInformation); + + *Buffer = PolicyInformation; + } + RpcExcept(EXCEPTION_EXECUTE_HANDLER) + { + if (PolicyInformation != NULL) + MIDL_user_free(PolicyInformation); + + Status = I_RpcMapWin32Status(RpcExceptionCode()); + } + RpcEndExcept; + + return Status; } @@ -1621,7 +1671,7 @@ /* - * @unimplemented + * @implemented */ NTSTATUS WINAPI @@ -1629,9 +1679,24 @@ IN POLICY_DOMAIN_INFORMATION_CLASS InformationClass, IN PVOID Buffer OPTIONAL) { - FIXME("LsaSetDomainInformationPolicy(%p %d %p) stub\n", + NTSTATUS Status; + + TRACE("LsaSetDomainInformationPolicy(%p %d %p)\n", PolicyHandle, InformationClass, Buffer); - return STATUS_UNSUCCESSFUL; + + RpcTryExcept + { + Status = LsarSetDomainInformationPolicy((LSAPR_HANDLE)PolicyHandle, + InformationClass, + (PLSAPR_POLICY_DOMAIN_INFORMATION)Buffer); + } + RpcExcept(EXCEPTION_EXECUTE_HANDLER) + { + Status = I_RpcMapWin32Status(RpcExceptionCode()); + } + RpcEndExcept; + + return Status; } Modified: trunk/reactos/include/reactos/idl/lsa.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/idl/lsa.id… ============================================================================== --- trunk/reactos/include/reactos/idl/lsa.idl [iso-8859-1] (original) +++ trunk/reactos/include/reactos/idl/lsa.idl [iso-8859-1] Fri Sep 28 22:11:18 2012 @@ -936,15 +936,13 @@ NTSTATUS __stdcall LsarQueryDomainInformationPolicy( [in] LSAPR_HANDLE PolicyHandle, [in] POLICY_INFORMATION_CLASS InformationClass, - [out] unsigned long *PolicyInformation); - /* FIXME: should be [out, switch_is(InformationClass)] PLSAPR_POLICY_INFORMATION *PolicyInformation); */ + [out, switch_is(InformationClass)] PLSAPR_POLICY_DOMAIN_INFORMATION *PolicyInformation); /* Function 54 */ NTSTATUS __stdcall LsarSetDomainInformationPolicy( [in] LSAPR_HANDLE PolicyHandle, [in] POLICY_INFORMATION_CLASS InformationClass, - [in] unsigned long PolicyInformation); - /* FIXME: should be [in, switch_is(InformationClass)] PLSAPR_POLICY_INFORMATION PolicyInformation); */ + [in, switch_is(InformationClass)] PLSAPR_POLICY_DOMAIN_INFORMATION PolicyInformation); /* Function 55 */ NTSTATUS __stdcall LsarOpenTrustedDomainByName(

1 0

[hbelusca] 57415: [CMD] - Clarify the code, no functional changes.
by hbelusca＠svn.reactos.org 28 Sep '12

28 Sep '12

Author: hbelusca Date: Fri Sep 28 19:36:49 2012 New Revision: 57415 URL: http://svn.reactos.org/svn/reactos?rev=57415&view=rev Log: [CMD] - Clarify the code, no functional changes. Modified: trunk/reactos/base/shell/cmd/cmd.h trunk/reactos/base/shell/cmd/parser.c trunk/reactos/base/shell/cmd/readme2.txt trunk/reactos/base/shell/cmd/redir.c Modified: trunk/reactos/base/shell/cmd/cmd.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/cmd.h?rev=5… ============================================================================== --- trunk/reactos/base/shell/cmd/cmd.h [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/cmd.h [iso-8859-1] Fri Sep 28 19:36:49 2012 @@ -409,13 +409,18 @@ /* Prototypes for REDIR.C */ -enum { REDIR_READ, REDIR_WRITE, REDIR_APPEND }; +typedef enum _REDIR_MODE +{ + REDIR_READ = 0, + REDIR_WRITE = 1, + REDIR_APPEND = 2 +} REDIR_MODE; typedef struct _REDIRECTION { struct _REDIRECTION *Next; HANDLE OldHandle; BYTE Number; - BYTE Type; + REDIR_MODE Mode; TCHAR Filename[]; } REDIRECTION; BOOL PerformRedirection(REDIRECTION *); Modified: trunk/reactos/base/shell/cmd/parser.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/parser.c?re… ============================================================================== --- trunk/reactos/base/shell/cmd/parser.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/parser.c [iso-8859-1] Fri Sep 28 19:36:49 2012 @@ -214,7 +214,7 @@ { TCHAR *Tok = CurrentToken; BYTE Number; - BYTE RedirType; + REDIR_MODE RedirMode; REDIRECTION *Redir; if (*Tok >= _T('0') && *Tok <= _T('9')) @@ -224,16 +224,16 @@ if (*Tok++ == _T('<')) { - RedirType = REDIR_READ; + RedirMode = REDIR_READ; if (*Tok == _T('<')) goto fail; } else { - RedirType = REDIR_WRITE; + RedirMode = REDIR_WRITE; if (*Tok == _T('>')) { - RedirType = REDIR_APPEND; + RedirMode = REDIR_APPEND; Tok++; } } @@ -262,7 +262,7 @@ Redir->Next = NULL; Redir->OldHandle = INVALID_HANDLE_VALUE; Redir->Number = Number; - Redir->Type = RedirType; + Redir->Mode = RedirMode; _tcscpy(Redir->Filename, Tok); *List = Redir; return TRUE; @@ -815,7 +815,7 @@ { if (SubstituteForVars(Redir->Filename, Buf)) ConOutPrintf(_T(" %c%s%s"), _T('0') + Redir->Number, - RedirString[Redir->Type], Buf); + RedirString[Redir->Mode], Buf); } } @@ -916,7 +916,7 @@ { if (!SubstituteForVars(Redir->Filename, Buf)) return NULL; PRINTF(_T(" %c%s%s"), _T('0') + Redir->Number, - RedirString[Redir->Type], Buf) + RedirString[Redir->Mode], Buf) } return Out; } Modified: trunk/reactos/base/shell/cmd/readme2.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/readme2.txt… ============================================================================== --- trunk/reactos/base/shell/cmd/readme2.txt [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/readme2.txt [iso-8859-1] Fri Sep 28 19:36:49 2012 @@ -15,7 +15,7 @@ Once there is input taken in from the command line it is sent into ParseCommandLine(). In here we fist check for aliases and convert if need be. -THen we look for redirections using GetRedirection() which will remove any redirection symbols. +Then we look for redirections using GetRedirection() which will remove any redirection symbols. and pass back info about where to redirect. from this info it will do some switching around with the handles for where things go and send them as need be. personally i dont like this code and i tried to chnage it before but failed. Modified: trunk/reactos/base/shell/cmd/redir.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/redir.c?rev… ============================================================================== --- trunk/reactos/base/shell/cmd/redir.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/redir.c [iso-8859-1] Fri Sep 28 19:36:49 2012 @@ -57,23 +57,21 @@ LPTSTR Filename; HANDLE hNew; UINT DupNumber; + static SECURITY_ATTRIBUTES SecAttr = { sizeof(SECURITY_ATTRIBUTES), NULL, TRUE }; /* Some parameters used for read, write, and append, respectively */ - static const DWORD dwAccess[] = { - GENERIC_READ, - GENERIC_WRITE, - GENERIC_WRITE - }; - static const DWORD dwShareMode[] = { - FILE_SHARE_READ | FILE_SHARE_WRITE, - FILE_SHARE_READ, - FILE_SHARE_READ - }; - static const DWORD dwCreationDisposition[] = { - OPEN_EXISTING, - CREATE_ALWAYS, - OPEN_ALWAYS + static + struct REDIR_PARAMS + { + DWORD dwDesiredAccess; + DWORD dwShareMode; + DWORD dwCreationDisposition; + } RedirParams[] = + { + {GENERIC_READ , FILE_SHARE_READ | FILE_SHARE_WRITE, OPEN_EXISTING}, // REDIR_READ + {GENERIC_WRITE, FILE_SHARE_READ , CREATE_ALWAYS}, // REDIR_WRITE + {GENERIC_WRITE, FILE_SHARE_READ , OPEN_ALWAYS } // REDIR_APPEND }; for (Redir = RedirList; Redir; Redir = Redir->Next) @@ -101,17 +99,18 @@ else { hNew = CreateFile(Filename, - dwAccess[Redir->Type], - dwShareMode[Redir->Type], + RedirParams[Redir->Mode].dwDesiredAccess, + RedirParams[Redir->Mode].dwShareMode, &SecAttr, - dwCreationDisposition[Redir->Type], + RedirParams[Redir->Mode].dwCreationDisposition, 0, NULL); } if (hNew == INVALID_HANDLE_VALUE) { - ConErrResPrintf(Redir->Type == REDIR_READ ? STRING_CMD_ERROR1 : STRING_CMD_ERROR3, + /* TODO: Print a more detailed message */ + ConErrResPrintf(Redir->Mode == REDIR_READ ? STRING_CMD_ERROR1 : STRING_CMD_ERROR3, Filename); cmd_free(Filename); redir_error: @@ -120,7 +119,7 @@ return FALSE; } - if (Redir->Type == REDIR_APPEND) + if (Redir->Mode == REDIR_APPEND) SetFilePointer(hNew, 0, NULL, FILE_END); Redir->OldHandle = GetHandle(Redir->Number); SetHandle(Redir->Number, hNew);

1 0

[hbelusca] 57414: [BOOTDATA] - Revert rev.57413. Indeed, when one boots ReactOS without debugging (selecting the first entry in the boot menu), the COM1 symbolic link (corresponding to \Device\Seri...
by hbelusca＠svn.reactos.org 28 Sep '12

28 Sep '12

Author: hbelusca Date: Fri Sep 28 19:04:37 2012 New Revision: 57414 URL: http://svn.reactos.org/svn/reactos?rev=57414&view=rev Log: [BOOTDATA] - Revert rev.57413. Indeed, when one boots ReactOS without debugging (selecting the first entry in the boot menu), the COM1 symbolic link (corresponding to \Device\Serial0) is created automatically by the serial driver. However, when one boots in debugging mode (selecting the second entry -- ReactOS (Debug) --), then for some reason the COM1 link isn't created (albeit \Device\Serial0 is). Therefore the real problem is elsewhere. Seems that it has something to share with http://jira.reactos.org/browse/CORE-4263 Modified: trunk/reactos/boot/bootdata/hivesys_amd64.inf trunk/reactos/boot/bootdata/hivesys_arm.inf trunk/reactos/boot/bootdata/hivesys_i386.inf Modified: trunk/reactos/boot/bootdata/hivesys_amd64.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_amd6… ============================================================================== --- trunk/reactos/boot/bootdata/hivesys_amd64.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys_amd64.inf [iso-8859-1] Fri Sep 28 19:04:37 2012 @@ -1192,10 +1192,6 @@ ; DOS devices HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","AUX",0x00000000,"\DosDevices\COM1" -;; ReactOS specific - add a symbolic link to the first COM port, because it happens for whatever -;; reason that the serial.sys driver doesn't create it when it creates the Serial0 device. -;; When this functionality is repaired, the following line shall disappear. -HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","COM1",0x00000000,"\Device\Serial0" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","MAILSLOT",0x00000000,"\Device\MailSlot" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","NUL",0x00000000,"\Device\Null" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","PIPE",0x00000000,"\Device\NamedPipe" Modified: trunk/reactos/boot/bootdata/hivesys_arm.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_arm.… ============================================================================== --- trunk/reactos/boot/bootdata/hivesys_arm.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys_arm.inf [iso-8859-1] Fri Sep 28 19:04:37 2012 @@ -747,10 +747,6 @@ ; DOS devices HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","AUX",0x00000000,"\DosDevices\COM1" -;; ReactOS specific - add a symbolic link to the first COM port, because it happens for whatever -;; reason that the serial.sys driver doesn't create it when it creates the Serial0 device. -;; When this functionality is repaired, the following line shall disappear. -HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","COM1",0x00000000,"\Device\Serial0" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","MAILSLOT",0x00000000,"\Device\MailSlot" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","NUL",0x00000000,"\Device\Null" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","PIPE",0x00000000,"\Device\NamedPipe" Modified: trunk/reactos/boot/bootdata/hivesys_i386.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_i386… ============================================================================== --- trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] Fri Sep 28 19:04:37 2012 @@ -1192,10 +1192,6 @@ ; DOS devices HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","AUX",0x00000000,"\DosDevices\COM1" -;; ReactOS specific - add a symbolic link to the first COM port, because it happens for whatever -;; reason that the serial.sys driver doesn't create it when it creates the Serial0 device. -;; When this functionality is repaired, the following line shall disappear. -HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","COM1",0x00000000,"\Device\Serial0" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","MAILSLOT",0x00000000,"\Device\MailSlot" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","NUL",0x00000000,"\Device\Null" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","PIPE",0x00000000,"\Device\NamedPipe"

1 0

[hbelusca] 57413: [BOOTDATA] - HACK: Add artificially a symbolic link to the first COM port, because it happens for whatever reason that the serial.sys driver doesn't create it when it creates the ...
by hbelusca＠svn.reactos.org 28 Sep '12

28 Sep '12

Author: hbelusca Date: Fri Sep 28 18:46:46 2012 New Revision: 57413 URL: http://svn.reactos.org/svn/reactos?rev=57413&view=rev Log: [BOOTDATA] - HACK: Add artificially a symbolic link to the first COM port, because it happens for whatever reason that the serial.sys driver doesn't create it when it creates the Serial0 device. When this functionality is repaired, the HACK shall disappear. Modified: trunk/reactos/boot/bootdata/hivesys_amd64.inf trunk/reactos/boot/bootdata/hivesys_arm.inf trunk/reactos/boot/bootdata/hivesys_i386.inf Modified: trunk/reactos/boot/bootdata/hivesys_amd64.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_amd6… ============================================================================== --- trunk/reactos/boot/bootdata/hivesys_amd64.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys_amd64.inf [iso-8859-1] Fri Sep 28 18:46:46 2012 @@ -1192,6 +1192,10 @@ ; DOS devices HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","AUX",0x00000000,"\DosDevices\COM1" +;; ReactOS specific - add a symbolic link to the first COM port, because it happens for whatever +;; reason that the serial.sys driver doesn't create it when it creates the Serial0 device. +;; When this functionality is repaired, the following line shall disappear. +HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","COM1",0x00000000,"\Device\Serial0" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","MAILSLOT",0x00000000,"\Device\MailSlot" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","NUL",0x00000000,"\Device\Null" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","PIPE",0x00000000,"\Device\NamedPipe" Modified: trunk/reactos/boot/bootdata/hivesys_arm.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_arm.… ============================================================================== --- trunk/reactos/boot/bootdata/hivesys_arm.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys_arm.inf [iso-8859-1] Fri Sep 28 18:46:46 2012 @@ -747,6 +747,10 @@ ; DOS devices HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","AUX",0x00000000,"\DosDevices\COM1" +;; ReactOS specific - add a symbolic link to the first COM port, because it happens for whatever +;; reason that the serial.sys driver doesn't create it when it creates the Serial0 device. +;; When this functionality is repaired, the following line shall disappear. +HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","COM1",0x00000000,"\Device\Serial0" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","MAILSLOT",0x00000000,"\Device\MailSlot" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","NUL",0x00000000,"\Device\Null" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","PIPE",0x00000000,"\Device\NamedPipe" Modified: trunk/reactos/boot/bootdata/hivesys_i386.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivesys_i386… ============================================================================== --- trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivesys_i386.inf [iso-8859-1] Fri Sep 28 18:46:46 2012 @@ -1192,6 +1192,10 @@ ; DOS devices HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","AUX",0x00000000,"\DosDevices\COM1" +;; ReactOS specific - add a symbolic link to the first COM port, because it happens for whatever +;; reason that the serial.sys driver doesn't create it when it creates the Serial0 device. +;; When this functionality is repaired, the following line shall disappear. +HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","COM1",0x00000000,"\Device\Serial0" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","MAILSLOT",0x00000000,"\Device\MailSlot" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","NUL",0x00000000,"\Device\Null" HKLM,"SYSTEM\CurrentControlSet\Control\Session Manager\DOS Devices","PIPE",0x00000000,"\Device\NamedPipe"

1 0

[hbelusca] 57412: [NTOSKRNL] - ExFreePool --> ExFreePoolWithTag in some places. - Remove dead code (section.c) - Free resource (sysldr.c)
by hbelusca＠svn.reactos.org 28 Sep '12

28 Sep '12

Author: hbelusca Date: Fri Sep 28 12:17:23 2012 New Revision: 57412 URL: http://svn.reactos.org/svn/reactos?rev=57412&view=rev Log: [NTOSKRNL] - ExFreePool --> ExFreePoolWithTag in some places. - Remove dead code (section.c) - Free resource (sysldr.c) Modified: trunk/reactos/ntoskrnl/cache/section/data.c trunk/reactos/ntoskrnl/io/iomgr/iofunc.c trunk/reactos/ntoskrnl/io/iomgr/irq.c trunk/reactos/ntoskrnl/mm/ARM3/drvmgmt.c trunk/reactos/ntoskrnl/mm/ARM3/expool.c trunk/reactos/ntoskrnl/mm/ARM3/mminit.c trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c trunk/reactos/ntoskrnl/mm/ARM3/procsup.c trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c trunk/reactos/ntoskrnl/mm/ARM3/virtual.c trunk/reactos/ntoskrnl/mm/section.c Modified: trunk/reactos/ntoskrnl/cache/section/data.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cache/section/dat… ============================================================================== --- trunk/reactos/ntoskrnl/cache/section/data.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/cache/section/data.c [iso-8859-1] Fri Sep 28 12:17:23 2012 @@ -555,7 +555,7 @@ { KeReleaseSpinLock(&FileObject->IrpListLock, OldIrql); DPRINTC("Free Segment %x\n", Segment); - ExFreePool(Segment); + ExFreePoolWithTag(Segment, TAG_MM_SECTION_SEGMENT); DPRINT("Filling out Segment info (previous data section)\n"); Modified: trunk/reactos/ntoskrnl/io/iomgr/iofunc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/iofunc.c… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/iofunc.c [iso-8859-1] Fri Sep 28 12:17:23 2012 @@ -1347,7 +1347,7 @@ { /* Allocating failed, clean up and return the exception code */ IopCleanupAfterException(FileObject, Irp, Event, NULL); - if (LocalLength) ExFreePool(LocalLength); + if (LocalLength) ExFreePoolWithTag(LocalLength, TAG_LOCK); /* Return the exception code */ _SEH2_YIELD(return _SEH2_GetExceptionCode()); @@ -1450,7 +1450,7 @@ _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) { /* Free buffer and return the exception code */ - if (AuxBuffer) ExFreePool(AuxBuffer); + if (AuxBuffer) ExFreePoolWithTag(AuxBuffer, TAG_SYSB); _SEH2_YIELD(return _SEH2_GetExceptionCode()); } _SEH2_END; @@ -1466,7 +1466,7 @@ if (!NT_SUCCESS(Status)) { /* Fail */ - if (AuxBuffer) ExFreePool(AuxBuffer); + if (AuxBuffer) ExFreePoolWithTag(AuxBuffer, TAG_SYSB); return Status; } @@ -1539,7 +1539,7 @@ { /* Allocating failed, clean up and return the exception code */ IopCleanupAfterException(FileObject, Irp, Event, NULL); - if (AuxBuffer) ExFreePool(AuxBuffer); + if (AuxBuffer) ExFreePoolWithTag(AuxBuffer, TAG_SYSB); /* Return the exception code */ _SEH2_YIELD(return _SEH2_GetExceptionCode()); @@ -1863,7 +1863,7 @@ _SEH2_END; /* Free the event */ - ExFreePool(Event); + ExFreePoolWithTag(Event, TAG_IO); } else { @@ -2465,7 +2465,7 @@ * Someone else set the completion port in the * meanwhile, so dereference the port and fail. */ - ExFreePool(Context); + ExFreePoolWithTag(Context, IOC_TAG); ObDereferenceObject(Queue); Status = STATUS_INVALID_PARAMETER; } @@ -2524,7 +2524,7 @@ _SEH2_END; /* Free the event */ - ExFreePool(Event); + ExFreePoolWithTag(Event, TAG_IO); } else { @@ -2555,7 +2555,7 @@ { /* Clear it in the IRP for completion */ Irp->UserEvent = NULL; - ExFreePool(Event); + ExFreePoolWithTag(Event, TAG_IO); } /* Set the caller IOSB */ @@ -2722,7 +2722,7 @@ /* Allocate a buffer */ LocalLength = ExAllocatePoolWithTag(NonPagedPool, sizeof(LARGE_INTEGER), - TAG_LOCK); + TAG_LOCK); /* Set the length */ *LocalLength = CapturedLength; @@ -2733,7 +2733,7 @@ { /* Allocating failed, clean up and return the exception code */ IopCleanupAfterException(FileObject, Irp, NULL, Event); - if (LocalLength) ExFreePool(LocalLength); + if (LocalLength) ExFreePoolWithTag(LocalLength, TAG_LOCK); /* Return the exception code */ _SEH2_YIELD(return _SEH2_GetExceptionCode()); Modified: trunk/reactos/ntoskrnl/io/iomgr/irq.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/irq.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/irq.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/irq.c [iso-8859-1] Fri Sep 28 12:17:23 2012 @@ -103,7 +103,7 @@ if (FirstRun) { /* We failed early so just free this */ - ExFreePool(IoInterrupt); + ExFreePoolWithTag(IoInterrupt, TAG_KINTERRUPT); } else { @@ -163,7 +163,7 @@ } /* Free the I/O Interrupt */ - ExFreePool(IoInterrupt); + ExFreePool(IoInterrupt); // ExFreePoolWithTag(IoInterrupt, TAG_KINTERRUPT); } /* EOF */ Modified: trunk/reactos/ntoskrnl/mm/ARM3/drvmgmt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/drvmgmt.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/drvmgmt.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/drvmgmt.c [iso-8859-1] Fri Sep 28 12:17:23 2012 @@ -200,7 +200,7 @@ // // Free the table if we failed and return status // - if (DriverThunks) ExFreePool(DriverThunks); + if (DriverThunks) ExFreePoolWithTag(DriverThunks, 'tVmM'); return Status; } Modified: trunk/reactos/ntoskrnl/mm/ARM3/expool.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/expool.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/expool.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/expool.c [iso-8859-1] Fri Sep 28 12:17:23 2012 @@ -358,7 +358,7 @@ // Finally, AND with the bucket mask to generate a valid index/bucket into // the table // - ULONGLONG Result = 40543 * Tag; + ULONGLONG Result = (ULONGLONG)40543 * Tag; return (ULONG)BucketMask & ((ULONG)Result ^ (Result >> 32)); } @@ -1185,7 +1185,7 @@ // // Free the "Generic DPC" temporary buffer, return the buffer length and status // - ExFreePool(Buffer); + ExFreePoolWithTag(Buffer, 'ofnI'); if (ReturnLength) *ReturnLength = CurrentLength; return Status; } Modified: trunk/reactos/ntoskrnl/mm/ARM3/mminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/mminit.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/mminit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/mminit.c [iso-8859-1] Fri Sep 28 12:17:23 2012 @@ -1172,7 +1172,7 @@ KeFlushCurrentTb(); /* Free our run structure */ - ExFreePool(Buffer); + ExFreePoolWithTag(Buffer, 'lMmM'); } VOID Modified: trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/pagfault.… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/pagfault.c [iso-8859-1] Fri Sep 28 12:17:23 2012 @@ -663,7 +663,7 @@ ASSERT(Pfn1->u3.e1.ReadInProgress == 0); /* Windows checks there's some free pages and this isn't an in-page error */ - ASSERT(MmAvailablePages >= 0); + ASSERT(MmAvailablePages > 0); ASSERT(Pfn1->u4.InPageError == 0); /* ReactOS checks for this */ Modified: trunk/reactos/ntoskrnl/mm/ARM3/procsup.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/procsup.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/procsup.c [iso-8859-1] Fri Sep 28 12:17:23 2012 @@ -118,7 +118,11 @@ Base, &Parent); /* Bail out, if still nothing free was found */ - if (Result == TableFoundNode) return STATUS_NO_MEMORY; + if (Result == TableFoundNode) + { + ExFreePoolWithTag(Vad, 'ldaV'); + return STATUS_NO_MEMORY; + } } /* Validate that it came from the VAD ranges */ @@ -1857,6 +1861,7 @@ { /* We ran out of session IDs, we should expand */ DPRINT1("Too many sessions created. Expansion not yet supported\n"); + ExFreePoolWithTag(PageTables, 'tHmM'); return STATUS_NO_MEMORY; } Modified: trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c?… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/sysldr.c [iso-8859-1] Fri Sep 28 12:17:23 2012 @@ -1,11 +1,11 @@ /* -* PROJECT: ReactOS Kernel -* LICENSE: BSD - See COPYING.ARM in the top level directory -* FILE: ntoskrnl/mm/ARM3/sysldr.c -* PURPOSE: Contains the Kernel Loader (SYSLDR) for loading PE files. -* PROGRAMMERS: Alex Ionescu (alex.ionescu(a)reactos.org) -* ReactOS Portable Systems Group -*/ + * PROJECT: ReactOS Kernel + * LICENSE: BSD - See COPYING.ARM in the top level directory + * FILE: ntoskrnl/mm/ARM3/sysldr.c + * PURPOSE: Contains the Kernel Loader (SYSLDR) for loading PE files. + * PROGRAMMERS: Alex Ionescu (alex.ionescu(a)reactos.org) + * ReactOS Portable Systems Group + */ /* INCLUDES *******************************************************************/ @@ -2179,9 +2179,13 @@ NewEntry->FullDllName.Buffer = ExAllocatePoolWithTag(PagedPool, LdrEntry->FullDllName.MaximumLength + - sizeof(UNICODE_NULL), + sizeof(UNICODE_NULL), TAG_LDR_WSTR); - if (!NewEntry->FullDllName.Buffer) return FALSE; + if (!NewEntry->FullDllName.Buffer) + { + ExFreePoolWithTag(NewEntry, TAG_MODULE_OBJECT); + return FALSE; + } /* Set the base name */ NewEntry->BaseDllName.Buffer = (PVOID)(NewEntry + 1); @@ -3436,3 +3440,4 @@ return ProcAddress; } +/* EOF */ Modified: trunk/reactos/ntoskrnl/mm/ARM3/virtual.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/virtual.c… ============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] Fri Sep 28 12:17:23 2012 @@ -1099,7 +1099,7 @@ // // Check if we had allocated pool // - if (HavePoolAddress) ExFreePool(PoolAddress); + if (HavePoolAddress) ExFreePoolWithTag(PoolAddress, 'VmRw'); // // Check if we failed during the probe @@ -1160,7 +1160,7 @@ // // Check if we had allocated pool // - if (HavePoolAddress) ExFreePool(PoolAddress); + if (HavePoolAddress) ExFreePoolWithTag(PoolAddress, 'VmRw'); // // All bytes read Modified: trunk/reactos/ntoskrnl/mm/section.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/section.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/section.c [iso-8859-1] Fri Sep 28 12:17:23 2012 @@ -1761,17 +1761,12 @@ Region->Protect, &NewPage, 1); - if (!NT_SUCCESS(Status)) - { - DPRINT("MmCreateVirtualMapping failed, not out of memory\n"); - KeBugCheck(MEMORY_MANAGEMENT); - return(Status); - } - if (!NT_SUCCESS(Status)) - { - DPRINT1("Unable to create virtual mapping\n"); - KeBugCheck(MEMORY_MANAGEMENT); - } + if (!NT_SUCCESS(Status)) + { + DPRINT1("MmCreateVirtualMapping failed, unable to create virtual mapping, not out of memory\n"); + KeBugCheck(MEMORY_MANAGEMENT); + return(Status); + } /* * Unshare the old page. @@ -3786,7 +3781,7 @@ if(ImageSectionObject->Segments != NULL) ExFreePool(ImageSectionObject->Segments); - ExFreePool(ImageSectionObject); + ExFreePoolWithTag(ImageSectionObject, TAG_MM_SECTION_SEGMENT); ObDereferenceObject(Section); ObDereferenceObject(FileObject); return(StatusExeFmt);

1 0

[hbelusca] 57411: [NTOSKRNL] - Revert rev.57400 only for this file since CID 701342 was a false-positive from Coverity (because Coverity doesn't know what the aim of the POOL_RAISE_IF_ALLOCATION_FA...
by hbelusca＠svn.reactos.org 28 Sep '12

28 Sep '12

Author: hbelusca Date: Fri Sep 28 10:01:00 2012 New Revision: 57411 URL: http://svn.reactos.org/svn/reactos?rev=57411&view=rev Log: [NTOSKRNL] - Revert rev.57400 only for this file since CID 701342 was a false-positive from Coverity (because Coverity doesn't know what the aim of the POOL_RAISE_IF_ALLOCATION_FAILURE is). Modified: trunk/reactos/ntoskrnl/fsrtl/notify.c Modified: trunk/reactos/ntoskrnl/fsrtl/notify.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fsrtl/notify.c?re… ============================================================================== --- trunk/reactos/ntoskrnl/fsrtl/notify.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/fsrtl/notify.c [iso-8859-1] Fri Sep 28 10:01:00 2012 @@ -586,13 +586,6 @@ /* Allocate new notification */ NotifyChange = ExAllocatePoolWithTag(PagedPool | POOL_RAISE_IF_ALLOCATION_FAILURE, sizeof(NOTIFY_CHANGE), 'FSrN'); - - /* - * If NotifyChange == NULL then an - * exception was already raised. - */ - ASSERT(NotifyChange != NULL); - RtlZeroMemory(NotifyChange, sizeof(NOTIFY_CHANGE)); /* Set basic information */

1 0

[ekohl] 57410: [ADVAPI32] - Implement LsaRemovePrivilegesFromAccount. - Add stubs for LsaGetRemoteUserName, LsaLookupPrivilegeDisplayName, LsaOpenPolicySce and LsaSetInformationTrustedDomain. - Fix...
by ekohl＠svn.reactos.org 28 Sep '12

28 Sep '12

Author: ekohl Date: Fri Sep 28 09:19:37 2012 New Revision: 57410 URL: http://svn.reactos.org/svn/reactos?rev=57410&view=rev Log: [ADVAPI32] - Implement LsaRemovePrivilegesFromAccount. - Add stubs for LsaGetRemoteUserName, LsaLookupPrivilegeDisplayName, LsaOpenPolicySce and LsaSetInformationTrustedDomain. - Fix some issues in the spec file. Modified: trunk/reactos/dll/win32/advapi32/advapi32.spec trunk/reactos/dll/win32/advapi32/sec/lsa.c trunk/reactos/include/psdk/ntsecapi.h Modified: trunk/reactos/dll/win32/advapi32/advapi32.spec URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/advapi3… ============================================================================== --- trunk/reactos/dll/win32/advapi32/advapi32.spec [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/advapi32.spec [iso-8859-1] Fri Sep 28 09:19:37 2012 @@ -363,29 +363,29 @@ @ stdcall LsaEnumerateTrustedDomainsEx(ptr ptr ptr long ptr) @ stdcall LsaFreeMemory(ptr) @ stdcall LsaGetQuotasForAccount(ptr ptr) -@ stub LsaGetRemoteUserName +@ stdcall LsaGetRemoteUserName(ptr ptr ptr) @ stdcall LsaGetSystemAccessAccount(ptr ptr) @ stdcall LsaGetUserName(ptr ptr) @ stub LsaICLookupNames @ stub LsaICLookupNamesWithCreds @ stub LsaICLookupSids @ stub LsaICLookupSidsWithCreds -@ stdcall LsaLookupNames(long long ptr ptr ptr) +@ stdcall LsaLookupNames(ptr long ptr ptr ptr) @ stdcall LsaLookupNames2(ptr long long ptr ptr ptr) -@ stub LsaLookupPrivilegeDisplayName +@ stdcall LsaLookupPrivilegeDisplayName(ptr ptr ptr ptr) @ stdcall LsaLookupPrivilegeName(ptr ptr ptr) @ stdcall LsaLookupPrivilegeValue(ptr ptr ptr) @ stdcall LsaLookupSids(ptr long ptr ptr ptr) @ stdcall LsaNtStatusToWinError(long) @ stdcall LsaOpenAccount(ptr ptr long ptr) @ stdcall LsaOpenPolicy(ptr ptr long ptr) -@ stub LsaOpenPolicySce +@ stdcall LsaOpenPolicySce(ptr ptr long ptr) @ stdcall LsaOpenSecret(ptr ptr long ptr) @ stdcall LsaOpenTrustedDomain(ptr ptr long ptr) @ stdcall LsaOpenTrustedDomainByName(ptr ptr long ptr) @ stdcall LsaQueryDomainInformationPolicy(ptr long ptr) @ stdcall LsaQueryForestTrustInformation(ptr ptr ptr) -@ stdcall LsaQueryInfoTrustedDomain(long long long) +@ stdcall LsaQueryInfoTrustedDomain(ptr long ptr) @ stdcall LsaQueryInformationPolicy(ptr long ptr) @ stdcall LsaQuerySecret(ptr ptr ptr ptr ptr) @ stdcall LsaQuerySecurityObject(ptr long ptr) @@ -393,12 +393,12 @@ @ stdcall LsaQueryTrustedDomainInfoByName(ptr ptr long ptr) @ stdcall LsaRegisterPolicyChangeNotification(long long) @ stdcall LsaRemoveAccountRights(ptr ptr long ptr long) -@ stub LsaRemovePrivilegesFromAccount +@ stdcall LsaRemovePrivilegesFromAccount(ptr long ptr) @ stdcall LsaRetrievePrivateData(ptr ptr ptr) @ stdcall LsaSetDomainInformationPolicy(ptr long ptr) @ stdcall LsaSetForestTrustInformation(ptr ptr ptr long ptr) -@ stdcall LsaSetInformationPolicy(long long ptr) -@ stub LsaSetInformationTrustedDomain +@ stdcall LsaSetInformationPolicy(ptr long ptr) +@ stdcall LsaSetInformationTrustedDomain(ptr long ptr) @ stdcall LsaSetQuotasForAccount(ptr ptr) @ stdcall LsaSetSecret(ptr ptr ptr) @ stdcall LsaSetSecurityObject(ptr long ptr) Modified: trunk/reactos/dll/win32/advapi32/sec/lsa.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/sec/lsa… ============================================================================== --- trunk/reactos/dll/win32/advapi32/sec/lsa.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/sec/lsa.c [iso-8859-1] Fri Sep 28 09:19:37 2012 @@ -163,7 +163,7 @@ * @implemented */ NTSTATUS -NTAPI +WINAPI LsaClearAuditLog(IN LSA_HANDLE PolicyHandle) { NTSTATUS Status; @@ -676,6 +676,21 @@ RpcEndExcept; return Status; +} + + +/* + * @unimplemented + */ +NTSTATUS +WINAPI +LsaGetRemoteUserName(IN PLSA_UNICODE_STRING SystemName OPTIONAL, + OUT PLSA_UNICODE_STRING *UserName, + OUT PLSA_UNICODE_STRING *DomainName OPTIONAL) +{ + FIXME("LsaGetUserName(%p %p %p)\n", + SystemName, UserName, DomainName); + return STATUS_NOT_IMPLEMENTED; } @@ -855,6 +870,22 @@ /* + * @unimplemented + */ +NTSTATUS +WINAPI +LsaLookupPrivilegeDisplayName(IN LSA_HANDLE PolicyHandle, + IN PLSA_UNICODE_STRING Name, + OUT PLSA_UNICODE_STRING *DisplayName, + OUT PSHORT LanguageReturned) +{ + FIXME("LsaLookupPrivilegeDisplayName(%p %p %p %p)\n", + PolicyHandle, Name, DisplayName, LanguageReturned); + return STATUS_NOT_IMPLEMENTED; +} + + +/* * @implemented */ NTSTATUS @@ -1078,6 +1109,26 @@ } +/* + * @unimplemented + */ +NTSTATUS +WINAPI +LsaOpenPolicySce(IN PLSA_UNICODE_STRING SystemName OPTIONAL, + IN PLSA_OBJECT_ATTRIBUTES ObjectAttributes, + IN ACCESS_MASK DesiredAccess, + OUT PLSA_HANDLE PolicyHandle) +{ + FIXME("LsaOpenPolicySce(%s %p 0x%08lx %p)\n", + SystemName ? debugstr_w(SystemName->Buffer) : "(null)", + ObjectAttributes, DesiredAccess, PolicyHandle); + return STATUS_NOT_IMPLEMENTED; +} + + +/* + * @implemented + */ NTSTATUS WINAPI LsaOpenSecret(IN LSA_HANDLE PolicyHandle, @@ -1528,6 +1579,33 @@ /* + * @implemented + */ +NTSTATUS +WINAPI +LsaRemovePrivilegesFromAccount(IN LSA_HANDLE AccountHandle, + IN BOOLEAN AllPrivileges, + IN PPRIVILEGE_SET Privileges OPTIONAL) +{ + NTSTATUS Status; + + RpcTryExcept + { + Status = LsarRemovePrivilegesFromAccount((LSAPR_HANDLE)AccountHandle, + AllPrivileges, + (PLSAPR_PRIVILEGE_SET)Privileges); + } + RpcExcept(EXCEPTION_EXECUTE_HANDLER) + { + Status = I_RpcMapWin32Status(RpcExceptionCode()); + } + RpcEndExcept; + + return Status; +} + + +/* * @unimplemented */ NTSTATUS @@ -1601,6 +1679,21 @@ RpcEndExcept; return Status; +} + + +/* + * @unimplemented + */ +NTSTATUS +WINAPI +LsaSetInformationTrustedDomain(IN LSA_HANDLE TrustedDomainHandle, + IN TRUSTED_INFORMATION_CLASS InformationClass, + IN PVOID Buffer) +{ + FIXME("LsaSetInformationTrustedDomain(%p %d %p)\n", + TrustedDomainHandle, InformationClass, Buffer); + return STATUS_NOT_IMPLEMENTED; } Modified: trunk/reactos/include/psdk/ntsecapi.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/ntsecapi.h?re… ============================================================================== --- trunk/reactos/include/psdk/ntsecapi.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/ntsecapi.h [iso-8859-1] Fri Sep 28 09:19:37 2012 @@ -70,6 +70,7 @@ #define POLICY_AUDIT_LOG_ADMIN 512 #define POLICY_SERVER_ADMIN 1024 #define POLICY_LOOKUP_NAMES 2048 +#define POLICY_NOTIFICATION 4096 #define POLICY_READ (STANDARD_RIGHTS_READ|6) #define POLICY_WRITE (STANDARD_RIGHTS_WRITE|2040) #define POLICY_EXECUTE (STANDARD_RIGHTS_EXECUTE|2049) @@ -690,6 +691,8 @@ NTSTATUS NTAPI LsaFreeMemory(PVOID); NTSTATUS NTAPI LsaFreeReturnBuffer(PVOID); NTSTATUS NTAPI LsaGetQuotasForAccount(LSA_HANDLE,PQUOTA_LIMITS); +NTSTATUS NTAPI LsaGetRemoteUserName(PLSA_UNICODE_STRING, PLSA_UNICODE_STRING*, + PLSA_UNICODE_STRING*); NTSTATUS NTAPI LsaGetSystemAccessAccount(LSA_HANDLE, PULONG); NTSTATUS NTAPI LsaGetUserName(PUNICODE_STRING*,PUNICODE_STRING*); NTSTATUS NTAPI LsaLogonUser(HANDLE,PLSA_STRING,SECURITY_LOGON_TYPE,ULONG,PVOID, @@ -700,6 +703,8 @@ PLSA_REFERENCED_DOMAIN_LIST*,PLSA_TRANSLATED_SID*); NTSTATUS NTAPI LsaLookupNames2(LSA_HANDLE,ULONG,ULONG,PLSA_UNICODE_STRING, PLSA_REFERENCED_DOMAIN_LIST*,PLSA_TRANSLATED_SID2*); +NTSTATUS NTAPI LsaLookupPrivilegeDisplayName(LSA_HANDLE,PLSA_UNICODE_STRING, + PLSA_UNICODE_STRING*,PSHORT); NTSTATUS NTAPI LsaLookupPrivilegeName(LSA_HANDLE,PLUID,PLSA_UNICODE_STRING*); NTSTATUS NTAPI LsaLookupPrivilegeValue(LSA_HANDLE,PLSA_UNICODE_STRING,PLUID); NTSTATUS NTAPI LsaLookupSids(LSA_HANDLE,ULONG,PSID*, @@ -707,6 +712,8 @@ ULONG NTAPI LsaNtStatusToWinError(NTSTATUS); NTSTATUS NTAPI LsaOpenAccount(LSA_HANDLE,PSID,ACCESS_MASK,PLSA_HANDLE); NTSTATUS NTAPI LsaOpenPolicy(PLSA_UNICODE_STRING,PLSA_OBJECT_ATTRIBUTES, + ACCESS_MASK,PLSA_HANDLE); +NTSTATUS NTAPI LsaOpenPolicySce(PLSA_UNICODE_STRING,PLSA_OBJECT_ATTRIBUTES, ACCESS_MASK,PLSA_HANDLE); NTSTATUS NTAPI LsaOpenSecret(LSA_HANDLE, PLSA_UNICODE_STRING, ACCESS_MASK, PLSA_HANDLE); NTSTATUS NTAPI LsaQuerySecurityObject(LSA_HANDLE,SECURITY_INFORMATION,PSECURITY_DESCRIPTOR*); @@ -725,11 +732,14 @@ NTSTATUS NTAPI LsaRegisterLogonProcess(PLSA_STRING,PHANDLE,PLSA_OPERATIONAL_MODE); NTSTATUS NTAPI LsaRemoveAccountRights(LSA_HANDLE,PSID,BOOLEAN, PLSA_UNICODE_STRING,ULONG); +NTSTATUS NTAPI LsaRemovePrivilegesFromAccount(LSA_HANDLE,BOOLEAN,PPRIVILEGE_SET); NTSTATUS NTAPI LsaRetrievePrivateData(LSA_HANDLE,PLSA_UNICODE_STRING, PLSA_UNICODE_STRING*); NTSTATUS NTAPI LsaSetDomainInformationPolicy(LSA_HANDLE, POLICY_DOMAIN_INFORMATION_CLASS,PVOID); NTSTATUS NTAPI LsaSetInformationPolicy(LSA_HANDLE,POLICY_INFORMATION_CLASS,PVOID); +NTSTATUS NTAPI LsaSetInformationTrustedDomain(LSA_HANDLE,TRUSTED_INFORMATION_CLASS, + PVOID); NTSTATUS NTAPI LsaSetQuotasForAccount(LSA_HANDLE,PQUOTA_LIMITS); NTSTATUS NTAPI LsaSetSecret(LSA_HANDLE,PLSA_UNICODE_STRING,PLSA_UNICODE_STRING); NTSTATUS NTAPI LsaSetSecurityObject(LSA_HANDLE,SECURITY_INFORMATION,PSECURITY_DESCRIPTOR);

1 0

[tfaber] 57409: [KMTESTS] - Fix GCC build
by tfaber＠svn.reactos.org 28 Sep '12

28 Sep '12

Author: tfaber Date: Fri Sep 28 07:13:26 2012 New Revision: 57409 URL: http://svn.reactos.org/svn/reactos?rev=57409&view=rev Log: [KMTESTS] - Fix GCC build Modified: trunk/rostests/kmtests/ntos_ke/KeMutex.c Modified: trunk/rostests/kmtests/ntos_ke/KeMutex.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/kmtests/ntos_ke/KeMutex.c… ============================================================================== --- trunk/rostests/kmtests/ntos_ke/KeMutex.c [iso-8859-1] (original) +++ trunk/rostests/kmtests/ntos_ke/KeMutex.c [iso-8859-1] Fri Sep 28 07:13:26 2012 @@ -56,7 +56,6 @@ TestMutant(VOID) { KMUTANT Mutant; - PKTHREAD Thread = KeGetCurrentThread(); LONG State; RtlFillMemory(&Mutant, sizeof(Mutant), 0x55);

1 0

[tfaber] 57408: [KMTESTS:KE] - Add test for KeInitializeMutant vs KeInitializeMutex. Dedicated to Mike.
by tfaber＠svn.reactos.org 28 Sep '12

28 Sep '12

Author: tfaber Date: Fri Sep 28 07:09:08 2012 New Revision: 57408 URL: http://svn.reactos.org/svn/reactos?rev=57408&view=rev Log: [KMTESTS:KE] - Add test for KeInitializeMutant vs KeInitializeMutex. Dedicated to Mike. Added: trunk/rostests/kmtests/ntos_ke/KeMutex.c (with props) Modified: trunk/rostests/kmtests/CMakeLists.txt trunk/rostests/kmtests/kmtest_drv/testlist.c Modified: trunk/rostests/kmtests/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/kmtests/CMakeLists.txt?re… ============================================================================== --- trunk/rostests/kmtests/CMakeLists.txt [iso-8859-1] (original) +++ trunk/rostests/kmtests/CMakeLists.txt [iso-8859-1] Fri Sep 28 07:09:08 2012 @@ -45,6 +45,7 @@ ntos_ke/KeEvent.c ntos_ke/KeGuardedMutex.c ntos_ke/KeIrql.c + ntos_ke/KeMutex.c ntos_ke/KeProcessor.c ntos_ke/KeSpinLock.c ntos_ke/KeTimer.c Modified: trunk/rostests/kmtests/kmtest_drv/testlist.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/kmtests/kmtest_drv/testli… ============================================================================== --- trunk/rostests/kmtests/kmtest_drv/testlist.c [iso-8859-1] (original) +++ trunk/rostests/kmtests/kmtest_drv/testlist.c [iso-8859-1] Fri Sep 28 07:09:08 2012 @@ -30,6 +30,7 @@ KMT_TESTFUNC Test_KeEvent; KMT_TESTFUNC Test_KeGuardedMutex; KMT_TESTFUNC Test_KeIrql; +KMT_TESTFUNC Test_KeMutex; KMT_TESTFUNC Test_KeProcessor; KMT_TESTFUNC Test_KeTimer; KMT_TESTFUNC Test_KernelType; @@ -70,6 +71,7 @@ { "KeEvent", Test_KeEvent }, { "KeGuardedMutex", Test_KeGuardedMutex }, { "KeIrql", Test_KeIrql }, + { "KeMutex", Test_KeMutex }, { "-KeProcessor", Test_KeProcessor }, { "KeTimer", Test_KeTimer }, { "-KernelType", Test_KernelType }, Added: trunk/rostests/kmtests/ntos_ke/KeMutex.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/kmtests/ntos_ke/KeMutex.c… ============================================================================== --- trunk/rostests/kmtests/ntos_ke/KeMutex.c (added) +++ trunk/rostests/kmtests/ntos_ke/KeMutex.c [iso-8859-1] Fri Sep 28 07:09:08 2012 @@ -1,0 +1,98 @@ +/* + * PROJECT: ReactOS kernel-mode tests + * LICENSE: GPLv2+ - See COPYING in the top level directory + * PURPOSE: Kernel-Mode Test Suite Mutant/Mutex test + * PROGRAMMER: Thomas Faber <thfabba(a)gmx.de> + */ + +#include <kmt_test.h> + +#define ULONGS_PER_POINTER (sizeof(PVOID) / sizeof(ULONG)) +#define MUTANT_SIZE (2 + 6 * ULONGS_PER_POINTER) + +C_ASSERT(sizeof(DISPATCHER_HEADER) == 8 + 2 * sizeof(PVOID)); +C_ASSERT(sizeof(KMUTANT) == sizeof(DISPATCHER_HEADER) + 3 * sizeof(PVOID) + sizeof(PVOID)); +C_ASSERT(sizeof(KMUTANT) == MUTANT_SIZE * sizeof(ULONG)); + +#define CheckMutex(Mutex, Held, New, ExpectedApcDisable) do { \ + PKTHREAD Thread = KeGetCurrentThread(); \ + ok_eq_uint((Mutex)->Header.Type, MutantObject); \ + ok_eq_uint((Mutex)->Header.Abandoned, 0x55); \ + ok_eq_uint((Mutex)->Header.Size, MUTANT_SIZE); \ + ok_eq_uint((Mutex)->Header.DpcActive, 0x55); \ + ok_eq_pointer((Mutex)->Header.WaitListHead.Flink, \ + &(Mutex)->Header.WaitListHead); \ + ok_eq_pointer((Mutex)->Header.WaitListHead.Blink, \ + &(Mutex)->Header.WaitListHead); \ + if (Held) \ + { \ + ok_eq_long((Mutex)->Header.SignalState, 0); \ + ok_eq_pointer((Mutex)->MutantListEntry.Flink, &Thread->MutantListHead); \ + ok_eq_pointer((Mutex)->MutantListEntry.Blink, &Thread->MutantListHead); \ + ok_eq_pointer(Thread->MutantListHead.Flink, &(Mutex)->MutantListEntry); \ + ok_eq_pointer(Thread->MutantListHead.Blink, &(Mutex)->MutantListEntry); \ + ok_eq_pointer((Mutex)->OwnerThread, Thread); \ + } \ + else \ + { \ + ok_eq_long((Mutex)->Header.SignalState, 1); \ + if (New) \ + { \ + ok_eq_pointer((Mutex)->MutantListEntry.Flink, \ + (PVOID)0x5555555555555555ULL); \ + ok_eq_pointer((Mutex)->MutantListEntry.Blink, \ + (PVOID)0x5555555555555555ULL); \ + } \ + ok_eq_pointer(Thread->MutantListHead.Flink, &Thread->MutantListHead); \ + ok_eq_pointer(Thread->MutantListHead.Blink, &Thread->MutantListHead); \ + ok_eq_pointer((Mutex)->OwnerThread, NULL); \ + } \ + ok_eq_uint((Mutex)->Abandoned, 0); \ + ok_eq_uint((Mutex)->ApcDisable, ExpectedApcDisable); \ +} while (0) + +static +VOID +TestMutant(VOID) +{ + KMUTANT Mutant; + PKTHREAD Thread = KeGetCurrentThread(); + LONG State; + + RtlFillMemory(&Mutant, sizeof(Mutant), 0x55); + KeInitializeMutant(&Mutant, FALSE); + ok_irql(PASSIVE_LEVEL); + CheckMutex(&Mutant, FALSE, TRUE, 0); + + RtlFillMemory(&Mutant, sizeof(Mutant), 0x55); + KeInitializeMutant(&Mutant, TRUE); + ok_irql(PASSIVE_LEVEL); + CheckMutex(&Mutant, TRUE, TRUE, 0); + State = KeReleaseMutant(&Mutant, 1, FALSE, FALSE); + ok_eq_long(State, 0); + ok_irql(PASSIVE_LEVEL); + CheckMutex(&Mutant, FALSE, FALSE, 0); +} + +static +VOID +TestMutex(VOID) +{ + KMUTEX Mutex; + + RtlFillMemory(&Mutex, sizeof(Mutex), 0x55); + KeInitializeMutex(&Mutex, 0); + ok_irql(PASSIVE_LEVEL); + CheckMutex(&Mutex, FALSE, TRUE, 1); + + RtlFillMemory(&Mutex, sizeof(Mutex), 0x55); + KeInitializeMutex(&Mutex, 123); + ok_irql(PASSIVE_LEVEL); + CheckMutex(&Mutex, FALSE, TRUE, 1); +} + +START_TEST(KeMutex) +{ + TestMutant(); + TestMutex(); +} Propchange: trunk/rostests/kmtests/ntos_ke/KeMutex.c ------------------------------------------------------------------------------ svn:eol-style = native

1 0

← Newer
1
2
3
4
5
6
7
...
24
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2012