Ros-diffs June 2013

ros-diffs@reactos.org

14 participants
274 discussions

[tfaber] 59134: [NTOS:IO] - Do not dereference an unsafe ObjectAttributes pointer in IoCreateFile. Spotted by Aleksandar Andrejevic (I'm removing the OriginalAttributes assignment completely becaus...
by tfaber＠svn.reactos.org 01 Jun '13

01 Jun '13

Author: tfaber Date: Sat Jun 1 20:50:13 2013 New Revision: 59134 URL: http://svn.reactos.org/svn/reactos?rev=59134&view=rev Log: [NTOS:IO] - Do not dereference an unsafe ObjectAttributes pointer in IoCreateFile. Spotted by Aleksandar Andrejevic (I'm removing the OriginalAttributes assignment completely because it's never used, and it generally makes no sense to copy this. ObOpenObjectByName already takes care of everything in attributes) CORE-7167 Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c Modified: trunk/reactos/ntoskrnl/io/iomgr/file.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/iomgr/file.c?r… ============================================================================== --- trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/iomgr/file.c [iso-8859-1] Sat Jun 1 20:50:13 2013 @@ -1761,7 +1761,7 @@ SystemEaBuffer = ExAllocatePoolWithTag(NonPagedPool, EaLength, TAG_EA); - if(!SystemEaBuffer) + if (!SystemEaBuffer) { _SEH2_YIELD(return STATUS_INSUFFICIENT_RESOURCES); } @@ -1840,7 +1840,6 @@ RtlZeroMemory(&OpenPacket, sizeof(OPEN_PACKET)); OpenPacket.Type = IO_TYPE_OPEN_PACKET; OpenPacket.Size = sizeof(OPEN_PACKET); - OpenPacket.OriginalAttributes = *ObjectAttributes; OpenPacket.AllocationSize = SafeAllocationSize; OpenPacket.CreateOptions = CreateOptions; OpenPacket.FileAttributes = (USHORT)FileAttributes;

1 0

[akhaldi] 59133: [NTOSKRNL] * Properly fail when the read pointer is out of the file. Brought to you by Sergey Chernov. CORE-7249 #resolve #comment Committed in r59133. Thanks !
by akhaldi＠svn.reactos.org 01 Jun '13

01 Jun '13

Author: akhaldi Date: Sat Jun 1 18:47:11 2013 New Revision: 59133 URL: http://svn.reactos.org/svn/reactos?rev=59133&view=rev Log: [NTOSKRNL] * Properly fail when the read pointer is out of the file. Brought to you by Sergey Chernov. CORE-7249 #resolve #comment Committed in r59133. Thanks ! Modified: trunk/reactos/ntoskrnl/cache/section/io.c Modified: trunk/reactos/ntoskrnl/cache/section/io.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/cache/section/io.… ============================================================================== --- trunk/reactos/ntoskrnl/cache/section/io.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/cache/section/io.c [iso-8859-1] Sat Jun 1 18:47:11 2013 @@ -187,7 +187,9 @@ } DPRINT("Paging IO Done: %08x\n", ReadStatus->Status); - Status = ReadStatus->Status == STATUS_END_OF_FILE ? STATUS_SUCCESS : ReadStatus->Status; + /* When "ReadStatus->Information > 0" is false and "ReadStatus->Status == STATUS_END_OF_FILE" is true + * it means that read pointer is out of file, so we must fail */ + Status = ReadStatus->Status == STATUS_END_OF_FILE && ReadStatus->Information > 0 ? STATUS_SUCCESS : ReadStatus->Status; return Status; }

1 0

[hbelusca] 59132: [CMD] COLOR builtin command of CMD does not format output color correctly. When changing the color of the foreground of the console with the command "color 3" for instance, the co...
by hbelusca＠svn.reactos.org 01 Jun '13

01 Jun '13

Author: hbelusca Date: Sat Jun 1 18:45:04 2013 New Revision: 59132 URL: http://svn.reactos.org/svn/reactos?rev=59132&view=rev Log: [CMD] COLOR builtin command of CMD does not format output color correctly. When changing the color of the foreground of the console with the command "color 3" for instance, the confirmation message "Color 3" appears whereas it should say "Color 03" as the number is output in 1-byte hexadecimal form. Patch by Radek Liška CORE-7246 #resolve #comment Committed in revision r59132. Thanks :) Modified: trunk/reactos/base/shell/cmd/lang/de-DE.rc trunk/reactos/base/shell/cmd/lang/el-GR.rc trunk/reactos/base/shell/cmd/lang/en-US.rc trunk/reactos/base/shell/cmd/lang/es-ES.rc trunk/reactos/base/shell/cmd/lang/fr-FR.rc trunk/reactos/base/shell/cmd/lang/hu-HU.rc trunk/reactos/base/shell/cmd/lang/id-ID.rc trunk/reactos/base/shell/cmd/lang/it-IT.rc trunk/reactos/base/shell/cmd/lang/ja-JP.rc trunk/reactos/base/shell/cmd/lang/no-NO.rc trunk/reactos/base/shell/cmd/lang/pl-PL.rc trunk/reactos/base/shell/cmd/lang/ro-RO.rc trunk/reactos/base/shell/cmd/lang/ru-RU.rc trunk/reactos/base/shell/cmd/lang/sk-SK.rc trunk/reactos/base/shell/cmd/lang/sv-SE.rc trunk/reactos/base/shell/cmd/lang/uk-UA.rc trunk/reactos/base/shell/cmd/lang/zh-CN.rc Modified: trunk/reactos/base/shell/cmd/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/de-DE.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/de-DE.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -633,7 +633,7 @@ STRING_CMD_ERROR5, "AusfÃ¼hrend cmdexit.bat...\n" STRING_COLOR_ERROR1, "Fehler: Hinter- und Vordergrund kÃ¶nnen nicht die selben Farben haben!" STRING_COLOR_ERROR2, "Fehler in der Farbangabe" -STRING_COLOR_ERROR3, "Farbe %x\n" +STRING_COLOR_ERROR3, "Farbe %02x\n" STRING_CONSOLE_ERROR, "Unbekannter Fehler: %d\n" STRING_COPY_ERROR1, "Fehler: Quelle kann nicht geÃ¶ffnet werden - %s!\n" STRING_COPY_ERROR2, "Fehler: Kann nicht Ã¼ber sich selbst kopiert werden.\n" Modified: trunk/reactos/base/shell/cmd/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/el-GR.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/el-GR.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/el-GR.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -633,7 +633,7 @@ STRING_CMD_ERROR5, "Running cmdexit.bat...\n" STRING_COLOR_ERROR1, "Same colors error! (Background and foreground can't be the same color)" STRING_COLOR_ERROR2, "error in color specification" -STRING_COLOR_ERROR3, "Color %x\n" +STRING_COLOR_ERROR3, "Color %02x\n" STRING_CONSOLE_ERROR, "ÎÎ³Î½ÏÏÏÎ¿ ÏÏÎ¬Î»Î¼Î±: %d\n" STRING_COPY_ERROR1, "Î£ÏÎ¬Î»Î¼Î±: ÎÎµÎ½ Î®ÏÎ±Î½ Î´ÏÎ½Î±ÏÏ ÏÎ¿ Î¬Î½Î¿Î¹Î³Î¼Î± ÏÎ·Ï ÏÎ·Î³Î®Ï - %s!\n" STRING_COPY_ERROR2, "Î£ÏÎ¬Î»Î¼Î±: Can't copy onto itself!\n" Modified: trunk/reactos/base/shell/cmd/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/en-US.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/en-US.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/en-US.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -636,7 +636,7 @@ STRING_CMD_ERROR5, "Running cmdexit.bat...\n" STRING_COLOR_ERROR1, "Same colors error! (Background and foreground can't be the same color)" STRING_COLOR_ERROR2, "error in color specification" -STRING_COLOR_ERROR3, "Color %x\n" +STRING_COLOR_ERROR3, "Color %02x\n" STRING_CONSOLE_ERROR, "Unknown error: %d\n" STRING_COPY_ERROR1, "Error: Cannot open source - %s!\n" STRING_COPY_ERROR2, "Error: Can't copy onto itself!\n" Modified: trunk/reactos/base/shell/cmd/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/es-ES.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/es-ES.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/es-ES.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -636,7 +636,7 @@ STRING_CMD_ERROR5, "Ejecutando cmdexit.bat...\n" STRING_COLOR_ERROR1, "Â¡Mismos colores! (El color de frente y de fondo no pueden ser el mismo)" STRING_COLOR_ERROR2, "Error en la especificaciÃ³n del color" -STRING_COLOR_ERROR3, "Color %x\n" +STRING_COLOR_ERROR3, "Color %02x\n" STRING_CONSOLE_ERROR, "Error desconocido: %d\n" STRING_COPY_ERROR1, "Error: No se puede abrir el origen - %s!\n" STRING_COPY_ERROR2, "Error: Â¡No se puede copiar sobre si mismo!\n" Modified: trunk/reactos/base/shell/cmd/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/fr-FR.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/fr-FR.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -651,7 +651,7 @@ STRING_CMD_ERROR5, "Lance cmdexit.bat...\n" STRING_COLOR_ERROR1, "L'arriÃ¨re plan et l'avant plan ne peuvent Ãªtre de la mÃªme couleur" STRING_COLOR_ERROR2, "Erreur dans la spÃ©cification des couleurs" -STRING_COLOR_ERROR3, "Couleur %x\n" +STRING_COLOR_ERROR3, "Couleur %02x\n" STRING_CONSOLE_ERROR, "Erreur inconnue : %d\n" STRING_COPY_ERROR1, "Erreur : Ne peut ouvrir la source - %s !\n" STRING_COPY_ERROR2, "Erreur : Ne peut copier le fichier sur lui-mÃªme !\n" Modified: trunk/reactos/base/shell/cmd/lang/hu-HU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/hu-HU.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/hu-HU.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/hu-HU.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -615,7 +615,7 @@ STRING_CMD_ERROR5, "cmdexit.bat futtatÃ¡sa...\n" STRING_COLOR_ERROR1, "Ugyanaz a szÃn nem lehet! (Az elÃµ- Ã©s hÃ¡ttÃ©rszÃn nem lehet ugyanolyan)" STRING_COLOR_ERROR2, "HibÃ¡s szÃn megadÃ¡s" -STRING_COLOR_ERROR3, "SzÃn %x\n" +STRING_COLOR_ERROR3, "SzÃn %02x\n" STRING_CONSOLE_ERROR, "Ismeretlen hiba: %d\n" STRING_COPY_ERROR1, "Hiba: a forrÃ¡s nem nyithatÃ³ meg - %s!\n" STRING_COPY_ERROR2, "Hiba: nem mÃ¡solhatod Ã¶nmagÃ¡ra az Ã¡llomÃ¡nyt!\n" Modified: trunk/reactos/base/shell/cmd/lang/id-ID.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/id-ID.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/id-ID.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/id-ID.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -635,7 +635,7 @@ STRING_CMD_ERROR5, "Menjalankan cmdexit.bat...\n" STRING_COLOR_ERROR1, "Warna sama salah! (Latar belakang dan latar depan tidak bisa berwarna sama)" STRING_COLOR_ERROR2, "Kesalahan dalam spesifikasi warna" -STRING_COLOR_ERROR3, "Warna %x\n" +STRING_COLOR_ERROR3, "Warna %02x\n" STRING_CONSOLE_ERROR, "Kesalahan tidak dikenal: %d\n" STRING_COPY_ERROR1, "Salah: Tidak dapat membuka sumber - %s!\n" STRING_COPY_ERROR2, "Salah: Tidak dapat mengcopy ke dirinya sendiri!\n" Modified: trunk/reactos/base/shell/cmd/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/it-IT.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/it-IT.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/it-IT.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -641,7 +641,7 @@ STRING_CMD_ERROR5, "Esecuzione di cmdexit.bat...\n" STRING_COLOR_ERROR1, "Il colore di primo piano e sfondo non possono essere uguali" STRING_COLOR_ERROR2, "errore nella indicazione dei colori" -STRING_COLOR_ERROR3, "Colore %x\n" +STRING_COLOR_ERROR3, "Colore %02x\n" STRING_CONSOLE_ERROR, "errore sconosciuto: %d\n" STRING_COPY_ERROR1, "Errore: Impossibile aprire il file sorgente - %s!\n" STRING_COPY_ERROR2, "Errore: Impossibile copiare un file su se stesso!\n" Modified: trunk/reactos/base/shell/cmd/lang/ja-JP.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/ja-JP.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/ja-JP.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/ja-JP.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -641,7 +641,7 @@ STRING_CMD_ERROR5, "cmdexit.bat ãå®è¡ãã¦ãã¾ã...\n" STRING_COLOR_ERROR1, "ã¨ã©ã¼! åãè²ãæå®ããã¾ããã\n (åæ¯è²ã¨èæ¯è²ãåãè²ã«ãããã¨ã¯ã§ãã¾ãã)" STRING_COLOR_ERROR2, "è²ã®æå®ã«åé¡ãããã¾ãã" -STRING_COLOR_ERROR3, "Color %x\n" +STRING_COLOR_ERROR3, "Color %02x\n" STRING_CONSOLE_ERROR, "ä¸æãªã¨ã©ã¼: %d\n" STRING_COPY_ERROR1, "ã¨ã©ã¼: åã®ãã¡ã¤ã« %s ãéãã¾ãã!\n" STRING_COPY_ERROR2, "ã¨ã©ã¼: ã³ãã¼åã¨ã³ãã¼åãä¸ç·ã§ã!\n" Modified: trunk/reactos/base/shell/cmd/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/no-NO.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/no-NO.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/no-NO.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -628,7 +628,7 @@ STRING_CMD_ERROR5, "KjÃ¸rer cmdexit.bat...\n" STRING_COLOR_ERROR1, "Samme farge feil! (Bakgrunn og forgrunn kan ikke ha samme farge)" STRING_COLOR_ERROR2, "feil i farge spesifikasjon" -STRING_COLOR_ERROR3, "Farge %x\n" +STRING_COLOR_ERROR3, "Farge %02x\n" STRING_CONSOLE_ERROR, "Ukjent feil: %d\n" STRING_COPY_ERROR1, "Feil: kan ikke Ã¥pne kilden - %s!\n" STRING_COPY_ERROR2, "Feil: kan ikke kopiere til seg selv!\n" Modified: trunk/reactos/base/shell/cmd/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/pl-PL.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/pl-PL.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/pl-PL.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -636,7 +636,7 @@ STRING_CMD_ERROR5, "Wykonywanie cmdexit.bat...\n" STRING_COLOR_ERROR1, "BÅÄd! Kolor tÅa i tekstu nie moÅ¼e byÄ taki sam" STRING_COLOR_ERROR2, "BÅÄd w oznaczeniu kolorÃ³w." -STRING_COLOR_ERROR3, "Kolor %x\n" +STRING_COLOR_ERROR3, "Kolor %02x\n" STRING_CONSOLE_ERROR, "Nieznany bÅÄd: %d\n" STRING_COPY_ERROR1, "BÅÄd: Nie moÅ¼na otworzyÄ ÅºrÃ³dÅa - %s!\n" STRING_COPY_ERROR2, "BÅÄd: Nie moÅ¼na przekopiowaÄ pliku na niego samego!\n" Modified: trunk/reactos/base/shell/cmd/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/ro-RO.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/ro-RO.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/ro-RO.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -680,7 +680,7 @@ STRING_CMD_ERROR5, "Executare Â«cmdexit.batÂ»...\n" STRING_COLOR_ERROR1, "Eroare de culoare identicÄ! (Culorile nu trebuie sÄ fie identice)" STRING_COLOR_ERROR2, "Eroare la specificarea culorii" -STRING_COLOR_ERROR3, "Culoare %x\n" +STRING_COLOR_ERROR3, "Culoare %02x\n" STRING_CONSOLE_ERROR, "Eroare necunoscutÄ: %d\n" STRING_COPY_ERROR1, "Eroare: Nu se poate deschide fiÈierul - Â«%sÂ»!\n" STRING_COPY_ERROR2, "Eroare: Nu se poate copia peste el Ã®nsuÈi!\n" Modified: trunk/reactos/base/shell/cmd/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/ru-RU.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/ru-RU.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/ru-RU.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -640,7 +640,7 @@ STRING_CMD_ERROR5, "ÐÐ°Ð¿ÑÑÐº cmdexit.bat...\n" STRING_COLOR_ERROR1, "ÐÐ´Ð¸Ð½Ð°ÐºÐ¾Ð²ÑÐµ ÑÐ²ÐµÑÐ°! (Ð¦Ð²ÐµÑÐ° ÑÐ¾Ð½Ð° Ð¸ ÑÐµÐºÑÑÐ° Ð½Ðµ Ð¼Ð¾Ð³ÑÑ Ð±ÑÑÑ Ð¾Ð´Ð¸Ð½Ð°ÐºÐ¾Ð²ÑÐ¼Ð¸)" STRING_COLOR_ERROR2, "Ð¾ÑÐ¸Ð±ÐºÐ° Ð² ÑÐºÐ°Ð·Ð°Ð½Ð¸Ð¸ ÑÐ²ÐµÑÐ°" -STRING_COLOR_ERROR3, "Ð¦Ð²ÐµÑ %x\n" +STRING_COLOR_ERROR3, "Ð¦Ð²ÐµÑ %02x\n" STRING_CONSOLE_ERROR, "ÐÐµÐ¸Ð·Ð²ÐµÑÑÐ½Ð°Ñ Ð¾ÑÐ¸Ð±ÐºÐ°: %d\n" STRING_COPY_ERROR1, "ÐÑÐ¸Ð±ÐºÐ°: ÐÐµÐ²Ð¾Ð·Ð¼Ð¾Ð¶Ð½Ð¾ Ð¾ÑÐºÑÑÑÑ Ð¸ÑÑÐ¾ÑÐ½Ð¸Ðº - %s!\n" STRING_COPY_ERROR2, "ÐÑÐ¸Ð±ÐºÐ°: ÐÐµÐ²Ð¾Ð·Ð¼Ð¾Ð¶Ð½Ð¾ ÐºÐ¾Ð¿Ð¸ÑÐ¾Ð²Ð°ÑÑ Ð² ÑÐµÐ±Ñ!\n" Modified: trunk/reactos/base/shell/cmd/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/sk-SK.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/sk-SK.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/sk-SK.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -640,7 +640,7 @@ STRING_CMD_ERROR5, "Running cmdexit.bat...\n" STRING_COLOR_ERROR1, "Same colors error! (Background and foreground can't be the same color)" STRING_COLOR_ERROR2, "error in color specification" -STRING_COLOR_ERROR3, "Color %x\n" +STRING_COLOR_ERROR3, "Color %02x\n" STRING_CONSOLE_ERROR, "NeznÃ¡ma chyba: %d\n" STRING_COPY_ERROR1, "Chyba: Cannot open source - %s!\n" STRING_COPY_ERROR2, "Chyba: Can't copy onto itself!\n" Modified: trunk/reactos/base/shell/cmd/lang/sv-SE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/sv-SE.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/sv-SE.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/sv-SE.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -628,7 +628,7 @@ STRING_CMD_ERROR5, "KÃ¶r cmdexit.bat...\n" STRING_COLOR_ERROR1, "Samme farge feil! (Bakgrunn och forgrunn kan inte ha samme farge)" STRING_COLOR_ERROR2, "feil i farge spesifikasjon" -STRING_COLOR_ERROR3, "Farge %x\n" +STRING_COLOR_ERROR3, "Farge %02x\n" STRING_CONSOLE_ERROR, "Ukjent feil: %d\n" STRING_COPY_ERROR1, "Feil: kan inte Ã¥pne kilden - %s!\n" STRING_COPY_ERROR2, "Feil: kan inte kopiere til seg selv!\n" Modified: trunk/reactos/base/shell/cmd/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/uk-UA.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/uk-UA.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/uk-UA.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -642,7 +642,7 @@ STRING_CMD_ERROR5, "ÐÐ°Ð¿ÑÑÐº cmdexit.bat...\n" STRING_COLOR_ERROR1, "Ð¿Ð¾Ð¼Ð¸Ð»ÐºÐ° - Ð¾Ð´Ð½Ð°ÐºÐ¾Ð²i ÐºÐ¾Ð»ÑÐ¾ÑÐ¸! (ÑÐ»Ð¾ ÑÐ° ÑÐµÐºÑÑ Ð½Ðµ Ð¼Ð¾Ð¶ÑÑÑ Ð±ÑÑÐ¸ Ð¾Ð´Ð½Ð°ÐºÐ¾Ð²Ð¾Ð³Ð¾ ÐºÐ¾Ð»ÑÐ¾ÑÑ)" STRING_COLOR_ERROR2, "Ð¿Ð¾Ð¼Ð¸Ð»ÐºÐ° Ð¿ÑÐ¸ Ð²ÐºÐ°Ð·Ð°Ð½Ð½i ÐºÐ¾Ð»ÑÐ¾ÑÑ" -STRING_COLOR_ERROR3, "ÐÐ¾Ð»iÑ %x\n" +STRING_COLOR_ERROR3, "ÐÐ¾Ð»iÑ %02x\n" STRING_CONSOLE_ERROR, "ÐÐµÐ²iÐ´Ð¾Ð¼Ð° Ð¿Ð¾Ð¼Ð¸Ð»ÐºÐ°: %d\n" STRING_COPY_ERROR1, "ÐÐ¾Ð¼Ð¸Ð»ÐºÐ°: ÐÐµÐ¼Ð¾Ð¶Ð»Ð¸Ð²Ð¾ Ð²iÐ´ÐºÑÐ¸ÑÐ¸ Ð´Ð¶ÐµÑÐµÐ»Ð¾ - %s!\n" STRING_COPY_ERROR2, "ÐÐ¾Ð¼Ð¸Ð»ÐºÐ°: ÐÐµÐ¼Ð¾Ð¶Ð»Ð¸Ð²Ð¾ ÐºÐ¾Ð¿iÑÐ²Ð°ÑÐ¸ Ð² ÑÐµÐ±Ðµ!\n" Modified: trunk/reactos/base/shell/cmd/lang/zh-CN.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/lang/zh-CN.… ============================================================================== --- trunk/reactos/base/shell/cmd/lang/zh-CN.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/lang/zh-CN.rc [iso-8859-1] Sat Jun 1 18:45:04 2013 @@ -600,7 +600,7 @@ STRING_CMD_ERROR5, "æ£å¨è¿è¡ cmdexit.bat...\n" STRING_COLOR_ERROR1, "åæ ·é¢è²éè¯¯ï¼ (èæ¯ååæ¯ä¸è½åè²)" STRING_COLOR_ERROR2, "é¢è²æå®éè¯¯" -STRING_COLOR_ERROR3, "é¢è² %x\n" +STRING_COLOR_ERROR3, "é¢è² %02x\n" STRING_CONSOLE_ERROR, "æªç¥éè¯¯ï¼%d\n" STRING_COPY_ERROR1, "éè¯¯ï¼æ æ³æå¼æº - %sï¼\n" STRING_COPY_ERROR2, "éè¯¯ï¼æ æ³å¤å¶å°èªèº«ï¼\n"

1 0

[tfaber] 59131: [CMAKE] - Don't check for unsupported gcc 4.6 - Disable -Wmaybe-uninitialized. It's just not useful.
by tfaber＠svn.reactos.org 01 Jun '13

01 Jun '13

Author: tfaber Date: Sat Jun 1 16:24:07 2013 New Revision: 59131 URL: http://svn.reactos.org/svn/reactos?rev=59131&view=rev Log: [CMAKE] - Don't check for unsupported gcc 4.6 - Disable -Wmaybe-uninitialized. It's just not useful. Modified: trunk/reactos/cmake/gcc.cmake Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=59131&… ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Sat Jun 1 16:24:07 2013 @@ -46,12 +46,10 @@ # Warnings add_compile_flags("-Werror -Wall -Wno-char-subscripts -Wpointer-arith -Wno-multichar -Wno-unused-value") -if(GCC_VERSION VERSION_LESS 4.6) +if(GCC_VERSION VERSION_LESS 4.7) add_compile_flags("-Wno-error=uninitialized") -elseif((GCC_VERSION VERSION_GREATER 4.6 OR GCC_VERSION VERSION_EQUAL 4.6) AND GCC_VERSION VERSION_LESS 4.7) - add_compile_flags("-Wno-error=unused-but-set-variable -Wno-error=uninitialized") elseif(GCC_VERSION VERSION_EQUAL 4.7 OR GCC_VERSION VERSION_GREATER 4.7) - add_compile_flags("-Wno-error=unused-but-set-variable -Wno-error=maybe-uninitialized -Wno-error=delete-non-virtual-dtor -Wno-error=narrowing") + add_compile_flags("-Wno-error=unused-but-set-variable -Wno-maybe-uninitialized -Wno-error=delete-non-virtual-dtor -Wno-error=narrowing") endif() if(ARCH STREQUAL "amd64")

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs June 2013