Author: hbelusca
Date: Thu Jul 4 01:08:28 2013
New Revision: 59423
URL: http://svn.reactos.org/svn/reactos?rev=59423&view=rev
Log:
Fix some comments
Modified:
trunk/reactos/base/shell/cmd/prompt.c
Modified: trunk/reactos/base/shell/cmd/prompt.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/prompt.c?re…
==============================================================================
--- trunk/reactos/base/shell/cmd/prompt.c [iso-8859-1] (original)
+++ trunk/reactos/base/shell/cmd/prompt.c [iso-8859-1] Thu Jul 4 01:08:28 2013
@@ -64,7 +64,7 @@
/*
* Set the PROMPT environment variable if it doesn't exist already.
- * You can change the PROMPT environment variable before cmd start.
+ * You can change the PROMPT environment variable before cmd starts.
*/
if (GetEnvironmentVariable(_T("PROMPT"), Buffer, sizeof(Buffer) / sizeof(Buffer[0])) == 0)
SetEnvironmentVariable(_T("PROMPT"), DefaultPrompt);
@@ -261,8 +261,8 @@
* So even if 'param' is null you _must_ still set prompt
* to the default. There seems to be some kind of difference
* between winxp and 2k in this matter and this way will
- * cover both. Do not use fixed size of szParam for param the buffer
- * are 8192 bytes and will later change to dynamic buffer.
+ * cover both. Do not use fixed size of 'szParam' for 'param';
+ * the buffers are 8192 bytes and will later change to dynamic buffer.
*/
/* Set the PROMPT environment variable */
Author: cgutman
Date: Wed Jul 3 10:22:11 2013
New Revision: 59414
URL: http://svn.reactos.org/svn/reactos?rev=59414&view=rev
Log:
[LWIP]
- Don't leak PCBs for connections that were not accepted
Modified:
trunk/reactos/lib/drivers/lwip/src/rostcp.c
Modified: trunk/reactos/lib/drivers/lwip/src/rostcp.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/drivers/lwip/src/rostc…
==============================================================================
--- trunk/reactos/lib/drivers/lwip/src/rostcp.c [iso-8859-1] (original)
+++ trunk/reactos/lib/drivers/lwip/src/rostcp.c [iso-8859-1] Wed Jul 3 10:22:11 2013
@@ -248,13 +248,15 @@
return ERR_OK;
}
+/* This function MUST return an error value that is not ERR_ABRT or ERR_OK if the connection
+ * is not accepted to avoid leaking the new PCB */
static
err_t
InternalAcceptEventHandler(void *arg, PTCP_PCB newpcb, const err_t err)
{
/* Make sure the socket didn't get closed */
if (!arg)
- return ERR_ABRT;
+ return ERR_CLSD;
TCPAcceptEventHandler(arg, newpcb);
@@ -262,7 +264,7 @@
if (newpcb->callback_arg)
return ERR_OK;
else
- return ERR_ABRT;
+ return ERR_CLSD;
}
static