Ros-diffs August 2013

ros-diffs@reactos.org

10 participants
327 discussions

[akhaldi] 59612: [CMD] * Plug a memory leak. Based on a patch by Samuel Serapion. CORE-7297 #resolve #comment Fixed in r59611. Thanks.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Thu Aug 1 15:40:34 2013 New Revision: 59612 URL: http://svn.reactos.org/svn/reactos?rev=59612&view=rev Log: [CMD] * Plug a memory leak. Based on a patch by Samuel Serapion. CORE-7297 #resolve #comment Fixed in r59611. Thanks. Modified: trunk/reactos/base/shell/cmd/misc.c Modified: trunk/reactos/base/shell/cmd/misc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/misc.c?rev=… ============================================================================== --- trunk/reactos/base/shell/cmd/misc.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/misc.c [iso-8859-1] Thu Aug 1 15:40:34 2013 @@ -194,6 +194,7 @@ *arg = cmd_realloc (oldarg, (*ac + 2) * sizeof (LPTSTR)); if (NULL == *arg) { + cmd_free (q); *arg = oldarg; return FALSE; }

11 years, 4 months

[akhaldi] 59611: [FULLFAT] * Silence some warnings.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Thu Aug 1 15:28:54 2013 New Revision: 59611 URL: http://svn.reactos.org/svn/reactos?rev=59611&view=rev Log: [FULLFAT] * Silence some warnings. Modified: trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt Modified: trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/3rdparty/fullfat/CMake… ============================================================================== --- trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/3rdparty/fullfat/CMakeLists.txt [iso-8859-1] Thu Aug 1 15:28:54 2013 @@ -1,6 +1,5 @@ include_directories(${REACTOS_SOURCE_DIR}/include/reactos/libs/fullfat) - add_definitions(-D__NTDRIVER__) list(APPEND SOURCE @@ -20,3 +19,7 @@ add_library(fullfat ${SOURCE}) allow_warnings(fullfat) add_dependencies(fullfat bugcodes) + +if(NOT MSVC) + add_target_compile_flags(fullfat "-Wno-unused-but-set-variable") +endif()

11 years, 4 months

[akhaldi] 59610: [DDK] * Fix annotations for INSTANCE_BASIC_INFORMATION, INSTANCE_PARTIAL_INFORMATION and INSTANCE_FULL_INFORMATION.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Thu Aug 1 14:35:54 2013 New Revision: 59610 URL: http://svn.reactos.org/svn/reactos?rev=59610&view=rev Log: [DDK] * Fix annotations for INSTANCE_BASIC_INFORMATION, INSTANCE_PARTIAL_INFORMATION and INSTANCE_FULL_INFORMATION. Modified: trunk/reactos/include/ddk/fltuserstructures.h Modified: trunk/reactos/include/ddk/fltuserstructures.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/fltuserstructu… ============================================================================== --- trunk/reactos/include/ddk/fltuserstructures.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/fltuserstructures.h [iso-8859-1] Thu Aug 1 14:35:54 2013 @@ -195,15 +195,17 @@ WCHAR FilterVolumeName[1]; } FILTER_VOLUME_BASIC_INFORMATION, *PFILTER_VOLUME_BASIC_INFORMATION; +typedef _Struct_size_bytes_(sizeof(INSTANCE_BASIC_INFORMATION) * InstanceNameLength) -typedef struct _INSTANCE_BASIC_INFORMATION { +struct _INSTANCE_BASIC_INFORMATION { ULONG NextEntryOffset; USHORT InstanceNameLength; USHORT InstanceNameBufferOffset; } INSTANCE_BASIC_INFORMATION, *PINSTANCE_BASIC_INFORMATION; +typedef _Struct_size_bytes_(sizeof(INSTANCE_PARTIAL_INFORMATION) + InstanceNameLength + AltitudeLength) -typedef struct _INSTANCE_PARTIAL_INFORMATION { +struct _INSTANCE_PARTIAL_INFORMATION { ULONG NextEntryOffset; USHORT InstanceNameLength; USHORT InstanceNameBufferOffset; @@ -211,8 +213,9 @@ USHORT AltitudeBufferOffset; } INSTANCE_PARTIAL_INFORMATION, *PINSTANCE_PARTIAL_INFORMATION; +typedef _Struct_size_bytes_(sizeof(INSTANCE_FULL_INFORMATION) + InstanceNameLength + AltitudeLength + VolumeNameLength + FilterNameLength) -typedef struct _INSTANCE_FULL_INFORMATION { +struct _INSTANCE_FULL_INFORMATION { ULONG NextEntryOffset; USHORT InstanceNameLength; USHORT InstanceNameBufferOffset;

11 years, 4 months

[akhaldi] 59609: [MOUNTMGR] * Properly mark some unreferenced parameters as such.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Thu Aug 1 14:29:03 2013 New Revision: 59609 URL: http://svn.reactos.org/svn/reactos?rev=59609&view=rev Log: [MOUNTMGR] * Properly mark some unreferenced parameters as such. Modified: trunk/reactos/drivers/filters/mountmgr/database.c trunk/reactos/drivers/filters/mountmgr/device.c trunk/reactos/drivers/filters/mountmgr/mountmgr.c trunk/reactos/drivers/filters/mountmgr/notify.c trunk/reactos/drivers/filters/mountmgr/symlink.c Modified: trunk/reactos/drivers/filters/mountmgr/database.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/d… ============================================================================== --- trunk/reactos/drivers/filters/mountmgr/database.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filters/mountmgr/database.c [iso-8859-1] Thu Aug 1 14:29:03 2013 @@ -298,6 +298,9 @@ { PMOUNTDEV_UNIQUE_ID UniqueId = Context; + UNREFERENCED_PARAMETER(ValueType); + UNREFERENCED_PARAMETER(EntryContext); + /* Ensure it matches, and delete */ if ((UniqueId->UniqueIdLength == ValueLength) && (RtlCompareMemory(UniqueId->UniqueId, ValueData, ValueLength) == @@ -364,6 +367,7 @@ NTAPI ReconcileThisDatabaseWithMasterWorker(IN PVOID Parameter) { + UNREFERENCED_PARAMETER(Parameter); return; } @@ -386,6 +390,8 @@ PDEVICE_EXTENSION DeviceExtension; OBJECT_ATTRIBUTES ObjectAttributes; + UNREFERENCED_PARAMETER(DeviceObject); + InitializeObjectAttributes(&ObjectAttributes, &SafeVolumes, OBJ_CASE_INSENSITIVE | OBJ_KERNEL_HANDLE, @@ -508,6 +514,8 @@ OBJECT_ATTRIBUTES ObjectAttributes; PFILE_NAME_INFORMATION FileNameInfo; PREPARSE_DATA_BUFFER ReparseDataBuffer; + + UNREFERENCED_PARAMETER(ReparsePointInformation); if (!FileName) { @@ -902,6 +910,8 @@ OBJECT_ATTRIBUTES ObjectAttributes, MigrateAttributes; #define TEMP_BUFFER_SIZE 0x200 + UNREFERENCED_PARAMETER(DeviceObject); + /* Extract context */ WorkItem = Context; DeviceInformation = WorkItem->DeviceInformation; @@ -1220,6 +1230,10 @@ PMOUNTDEV_UNIQUE_ID IntUniqueId; PMOUNTDEV_UNIQUE_ID * UniqueId; + UNREFERENCED_PARAMETER(ValueName); + UNREFERENCED_PARAMETER(ValueType); + UNREFERENCED_PARAMETER(EntryContext); + /* Sanity check */ if (ValueLength >= 0x10000) { @@ -1464,6 +1478,8 @@ PMOUNTDEV_UNIQUE_ID UniqueId; UNICODE_STRING RegistryEntry; + UNREFERENCED_PARAMETER(EntryContext); + if (ValueType != REG_BINARY) { return STATUS_SUCCESS; @@ -1527,6 +1543,8 @@ { PMOUNTDEV_UNIQUE_ID UniqueId = Context; + UNREFERENCED_PARAMETER(EntryContext); + /* Ensure we have correct input */ if (ValueName[0] != L'#' || ValueType != REG_BINARY || UniqueId->UniqueIdLength != ValueLength) Modified: trunk/reactos/drivers/filters/mountmgr/device.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/d… ============================================================================== --- trunk/reactos/drivers/filters/mountmgr/device.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filters/mountmgr/device.c [iso-8859-1] Thu Aug 1 14:29:03 2013 @@ -292,6 +292,8 @@ PDEVICE_INFORMATION DeviceInformation; NTSTATUS ArrivalStatus, Status = STATUS_SUCCESS; + UNREFERENCED_PARAMETER(Irp); + /* No offline volumes, nothing more to do */ if (IsListEmpty(&(DeviceExtension->OfflineDeviceListHead))) { @@ -690,6 +692,10 @@ UNICODE_STRING ValueString; PUNICODE_STRING SystemVolumeName; + UNREFERENCED_PARAMETER(ValueName); + UNREFERENCED_PARAMETER(ValueLength); + UNREFERENCED_PARAMETER(EntryContext); + if (ValueType != REG_SZ) { return STATUS_SUCCESS; @@ -819,6 +825,8 @@ MountMgrQueryDosVolumePath(IN PDEVICE_EXTENSION DeviceExtension, IN PIRP Irp) { + UNREFERENCED_PARAMETER(DeviceExtension); + UNREFERENCED_PARAMETER(Irp); return STATUS_NOT_IMPLEMENTED; } @@ -826,6 +834,8 @@ MountMgrQueryDosVolumePaths(IN PDEVICE_EXTENSION DeviceExtension, IN PIRP Irp) { + UNREFERENCED_PARAMETER(DeviceExtension); + UNREFERENCED_PARAMETER(Irp); return STATUS_NOT_IMPLEMENTED; } @@ -1460,6 +1470,9 @@ IN PIRP Irp, IN NTSTATUS LockStatus) { + UNREFERENCED_PARAMETER(DeviceExtension); + UNREFERENCED_PARAMETER(Irp); + UNREFERENCED_PARAMETER(LockStatus); return STATUS_NOT_IMPLEMENTED; } @@ -1468,6 +1481,9 @@ IN PIRP Irp, IN NTSTATUS LockStatus) { + UNREFERENCED_PARAMETER(DeviceExtension); + UNREFERENCED_PARAMETER(Irp); + UNREFERENCED_PARAMETER(LockStatus); return STATUS_NOT_IMPLEMENTED; } Modified: trunk/reactos/drivers/filters/mountmgr/mountmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/m… ============================================================================== --- trunk/reactos/drivers/filters/mountmgr/mountmgr.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filters/mountmgr/mountmgr.c [iso-8859-1] Thu Aug 1 14:29:03 2013 @@ -816,6 +816,8 @@ PDEVICE_INFORMATION DeviceInformation; PSAVED_LINK_INFORMATION SavedLinkInformation; + UNREFERENCED_PARAMETER(DriverObject); + /* Don't get notification any longer */ IoUnregisterShutdownNotification(gdeviceObject); @@ -1663,6 +1665,8 @@ PIO_STACK_LOCATION Stack; NTSTATUS Status = STATUS_SUCCESS; + UNREFERENCED_PARAMETER(DeviceObject); + Stack = IoGetCurrentIrpStackLocation(Irp); /* Allow driver opening for communication @@ -1688,6 +1692,8 @@ MountMgrCancel(IN PDEVICE_OBJECT DeviceObject, IN PIRP Irp) { + UNREFERENCED_PARAMETER(DeviceObject); + RemoveEntryList(&(Irp->Tail.Overlay.ListEntry)); IoReleaseCancelSpinLock(Irp->CancelIrql); Modified: trunk/reactos/drivers/filters/mountmgr/notify.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/n… ============================================================================== --- trunk/reactos/drivers/filters/mountmgr/notify.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filters/mountmgr/notify.c [iso-8859-1] Thu Aug 1 14:29:03 2013 @@ -511,6 +511,8 @@ PMOUNTDEV_UNIQUE_ID OldUniqueId, NewUniqueId; PMOUNTDEV_UNIQUE_ID_CHANGE_NOTIFY_OUTPUT UniqueIdChange; + UNREFERENCED_PARAMETER(DeviceObject); + /* Validate worker */ if (!NT_SUCCESS(WorkItem->Irp->IoStatus.Status)) { @@ -566,6 +568,9 @@ IN PVOID Context) { PUNIQUE_ID_WORK_ITEM WorkItem = Context; + + UNREFERENCED_PARAMETER(DeviceObject); + UNREFERENCED_PARAMETER(Irp); /* Simply queue the work item */ IoQueueWorkItem(WorkItem->WorkItem, Modified: trunk/reactos/drivers/filters/mountmgr/symlink.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filters/mountmgr/s… ============================================================================== --- trunk/reactos/drivers/filters/mountmgr/symlink.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filters/mountmgr/symlink.c [iso-8859-1] Thu Aug 1 14:29:03 2013 @@ -119,6 +119,8 @@ NTSTATUS Status; UNICODE_STRING GlobalName; + UNREFERENCED_PARAMETER(DeviceName); + /* First create the global string */ Status = CreateStringWithGlobal(DosName, &GlobalName); if (!NT_SUCCESS(Status)) @@ -529,6 +531,8 @@ BOOLEAN WriteNew; RTL_QUERY_REGISTRY_TABLE QueryTable[2]; + UNREFERENCED_PARAMETER(DeviceExtension); + /* First of all, count links */ RtlZeroMemory(QueryTable, sizeof(QueryTable)); QueryTable[0].QueryRoutine = SymbolicLinkNamesFromUniqueIdCount;

11 years, 4 months

[akhaldi] 59608: [SAL] * Add __inner_callback annotation.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Thu Aug 1 14:18:15 2013 New Revision: 59608 URL: http://svn.reactos.org/svn/reactos?rev=59608&view=rev Log: [SAL] * Add __inner_callback annotation. Modified: trunk/reactos/include/psdk/sal.h Modified: trunk/reactos/include/psdk/sal.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/sal.h?rev=596… ============================================================================== --- trunk/reactos/include/psdk/sal.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/sal.h [iso-8859-1] Thu Aug 1 14:18:15 2013 @@ -984,7 +984,7 @@ #define _Reserved_ _SAL2_NAME(_Reserved_) _Group_([SA_Pre(Null=SA_Yes)]) //#define _Result_nullonfailure_ //#define _Result_zeroonfailure_ -//#define __inner_callback +#define __inner_callback [SAL_annotes(Name="__callback")] //#define _Ret_ //#define _Ret_bound_ //#define _Ret_bytecap_(size)

11 years, 4 months

[akhaldi] 59607: [CMIDRIVER] * Improve header inclusions for cmicontrol and cmicpl.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Thu Aug 1 14:15:22 2013 New Revision: 59607 URL: http://svn.reactos.org/svn/reactos?rev=59607&view=rev Log: [CMIDRIVER] * Improve header inclusions for cmicontrol and cmicpl. Modified: trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/cmicontrol/main.h trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/cpl/cmicpl.cpp Modified: trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/cmicontrol/main.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/drivers/… ============================================================================== --- trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/cmicontrol/main.h [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/cmicontrol/main.h [iso-8859-1] Thu Aug 1 14:15:22 2013 @@ -29,6 +29,7 @@ #include <math.h> +#define WIN32_LEAN_AND_MEAN #include <windows.h> #include <devioctl.h> #include <commctrl.h> @@ -37,9 +38,10 @@ #include <cpl.h> #include <ks.h> +#include <mmreg.h> #include <ksmedia.h> #include <mmsystem.h> -#include <mmreg.h> + #define INITGUID #define DIRECTSOUND_VERSION 0x800 Modified: trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/cpl/cmicpl.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/drivers/… ============================================================================== --- trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/cpl/cmicpl.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/cpl/cmicpl.cpp [iso-8859-1] Thu Aug 1 14:15:22 2013 @@ -25,6 +25,7 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. */ +#define WIN32_LEAN_AND_MEAN #include <windows.h> #include <shellapi.h> #include <tchar.h>

11 years, 4 months

[akhaldi] 59606: [COMSUPP] * Improve the header inclusions.

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Thu Aug 1 14:11:58 2013 New Revision: 59606 URL: http://svn.reactos.org/svn/reactos?rev=59606&view=rev Log: [COMSUPP] * Improve the header inclusions. Modified: trunk/reactos/lib/sdk/comsupp/comsupp.cpp Modified: trunk/reactos/lib/sdk/comsupp/comsupp.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/comsupp/comsupp.cp… ============================================================================== --- trunk/reactos/lib/sdk/comsupp/comsupp.cpp [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/comsupp/comsupp.cpp [iso-8859-1] Thu Aug 1 14:11:58 2013 @@ -5,8 +5,14 @@ * PROGRAMMER: Thomas Faber */ +#include <stdarg.h> + +#define WIN32_NO_STATUS +#define _INC_WINDOWS + +#include <windef.h> +#include <winbase.h> #include <comdef.h> -#include <comutil.h> /* comdef.h */ typedef void WINAPI COM_ERROR_HANDLER(HRESULT, IErrorInfo *);

11 years, 4 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2013