Ros-diffs January 2014

ros-diffs@reactos.org

14 participants
426 discussions

[akhaldi] 61715: [D3DXOF] * Move some inclusions to the main header. * Remove inclusions and definitions that already exist in the main header. * Improve header inclusions. CORE-7716

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Mon Jan 20 11:18:23 2014 New Revision: 61715 URL: http://svn.reactos.org/svn/reactos?rev=61715&view=rev Log: [D3DXOF] * Move some inclusions to the main header. * Remove inclusions and definitions that already exist in the main header. * Improve header inclusions. CORE-7716 Modified: trunk/reactos/dll/directx/wine/d3dxof/d3dxof.c trunk/reactos/dll/directx/wine/d3dxof/d3dxof_private.h trunk/reactos/dll/directx/wine/d3dxof/main.c trunk/reactos/dll/directx/wine/d3dxof/mszip.c trunk/reactos/dll/directx/wine/d3dxof/parsing.c Modified: trunk/reactos/dll/directx/wine/d3dxof/d3dxof.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3dxof/d3… ============================================================================== --- trunk/reactos/dll/directx/wine/d3dxof/d3dxof.c [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/d3dxof/d3dxof.c [iso-8859-1] Mon Jan 20 11:18:23 2014 @@ -18,18 +18,7 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#include "config.h" -#include "wine/debug.h" - -#define COBJMACROS - -#include "winbase.h" -#include "wingdi.h" - #include "d3dxof_private.h" -#include "dxfile.h" - -#include <stdio.h> WINE_DEFAULT_DEBUG_CHANNEL(d3dxof); WINE_DECLARE_DEBUG_CHANNEL(d3dxof_dump); Modified: trunk/reactos/dll/directx/wine/d3dxof/d3dxof_private.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3dxof/d3… ============================================================================== --- trunk/reactos/dll/directx/wine/d3dxof/d3dxof_private.h [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/d3dxof/d3dxof_private.h [iso-8859-1] Mon Jan 20 11:18:23 2014 @@ -21,14 +21,21 @@ #ifndef __D3DXOF_PRIVATE_INCLUDED__ #define __D3DXOF_PRIVATE_INCLUDED__ -#include <stdarg.h> +#include <config.h> -#include "windef.h" -#include "winbase.h" -#include "wtypes.h" -#include "wingdi.h" -#include "winuser.h" -#include "dxfile.h" +#include <stdio.h> + +#define WIN32_NO_STATUS +#define _INC_WINDOWS +#define COM_NO_WINDOWS_H + +#define COBJMACROS + +#include <windef.h> +#include <winbase.h> +#include <dxfile.h> + +#include <wine/debug.h> #define MAX_NAME_LEN 40 #define MAX_ARRAY_DIM 4 Modified: trunk/reactos/dll/directx/wine/d3dxof/main.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3dxof/ma… ============================================================================== --- trunk/reactos/dll/directx/wine/d3dxof/main.c [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/d3dxof/main.c [iso-8859-1] Mon Jan 20 11:18:23 2014 @@ -18,25 +18,9 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#include <stdarg.h> -#include <string.h> - -#define COBJMACROS - -#include "windef.h" -#include "winbase.h" -#include "winuser.h" -#include "winreg.h" -#include "winerror.h" - -#include "ole2.h" -#include "rpcproxy.h" -#include "uuids.h" - #include "d3dxof_private.h" -#include "dxfile.h" - -#include "wine/debug.h" + +#include <rpcproxy.h> WINE_DEFAULT_DEBUG_CHANNEL(d3dxof); Modified: trunk/reactos/dll/directx/wine/d3dxof/mszip.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3dxof/ms… ============================================================================== --- trunk/reactos/dll/directx/wine/d3dxof/mszip.c [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/d3dxof/mszip.c [iso-8859-1] Mon Jan 20 11:18:23 2014 @@ -23,12 +23,12 @@ #include <stdarg.h> -#include "windef.h" -#include "winbase.h" - -#include "wine/debug.h" +#include <windef.h> +#include <winbase.h> #include "mszip.h" + +#include <wine/debug.h> WINE_DEFAULT_DEBUG_CHANNEL(d3dxof); Modified: trunk/reactos/dll/directx/wine/d3dxof/parsing.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3dxof/pa… ============================================================================== --- trunk/reactos/dll/directx/wine/d3dxof/parsing.c [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/d3dxof/parsing.c [iso-8859-1] Mon Jan 20 11:18:23 2014 @@ -18,18 +18,7 @@ * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA */ -#include "config.h" -#include "wine/debug.h" - -#define COBJMACROS - -#include "winbase.h" -#include "wingdi.h" - #include "d3dxof_private.h" -#include "dxfile.h" - -#include <stdio.h> WINE_DEFAULT_DEBUG_CHANNEL(d3dxof_parsing);

10 years, 8 months

[akhaldi] 61714: [D3DX9_36] * Improve the GUIDs situation. * Improve the main header. CORE-7716

by akhaldi＠svn.reactos.org

Author: akhaldi Date: Mon Jan 20 11:15:56 2014 New Revision: 61714 URL: http://svn.reactos.org/svn/reactos?rev=61714&view=rev Log: [D3DX9_36] * Improve the GUIDs situation. * Improve the main header. CORE-7716 Added: trunk/reactos/dll/directx/wine/d3dx9_36/guid.c (with props) Modified: trunk/reactos/dll/directx/wine/d3dx9_36/CMakeLists.txt trunk/reactos/dll/directx/wine/d3dx9_36/d3dx9_36_private.h trunk/reactos/dll/directx/wine/d3dx9_36/surface.c Modified: trunk/reactos/dll/directx/wine/d3dx9_36/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3dx9_36/… ============================================================================== --- trunk/reactos/dll/directx/wine/d3dx9_36/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/d3dx9_36/CMakeLists.txt [iso-8859-1] Mon Jan 20 11:15:56 2014 @@ -21,6 +21,7 @@ util.c volume.c xfile.c + guid.c ${CMAKE_CURRENT_BINARY_DIR}/d3dx9_36_stubs.c ${CMAKE_CURRENT_BINARY_DIR}/d3dx9_36.def) Modified: trunk/reactos/dll/directx/wine/d3dx9_36/d3dx9_36_private.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3dx9_36/… ============================================================================== --- trunk/reactos/dll/directx/wine/d3dx9_36/d3dx9_36_private.h [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/d3dx9_36/d3dx9_36_private.h [iso-8859-1] Mon Jan 20 11:15:56 2014 @@ -25,21 +25,19 @@ #include <config.h> #include <wine/port.h> +#include <stdarg.h> + #define WIN32_NO_STATUS #define _INC_WINDOWS #define COM_NO_WINDOWS_H -#include <stdarg.h> - -#include <initguid.h> - #define COBJMACROS #define NONAMELESSUNION #define NONAMELESSSTRUCT + #include <windef.h> #include <winbase.h> #include <wingdi.h> -#include <winnls.h> #include <winuser.h> #include <d3dx9.h> Added: trunk/reactos/dll/directx/wine/d3dx9_36/guid.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3dx9_36/… ============================================================================== --- trunk/reactos/dll/directx/wine/d3dx9_36/guid.c (added) +++ trunk/reactos/dll/directx/wine/d3dx9_36/guid.c [iso-8859-1] Mon Jan 20 11:15:56 2014 @@ -0,0 +1,15 @@ +/* DO NOT USE THE PRECOMPILED HEADER FOR THIS FILE! */ + +#include <stdarg.h> + +#define WIN32_NO_STATUS +#define _INC_WINDOWS +#define COM_NO_WINDOWS_H + +#include <windef.h> +#include <winbase.h> +#include <wingdi.h> +#include <initguid.h> +#include <d3dx9.h> + +/* NO CODE HERE, THIS IS JUST REQUIRED FOR THE GUID DEFINITIONS */ Propchange: trunk/reactos/dll/directx/wine/d3dx9_36/guid.c ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/reactos/dll/directx/wine/d3dx9_36/surface.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/directx/wine/d3dx9_36/… ============================================================================== --- trunk/reactos/dll/directx/wine/d3dx9_36/surface.c [iso-8859-1] (original) +++ trunk/reactos/dll/directx/wine/d3dx9_36/surface.c [iso-8859-1] Mon Jan 20 11:15:56 2014 @@ -21,6 +21,8 @@ #include "d3dx9_36_private.h" #include <ole2.h> + +#include <initguid.h> #include <wincodec.h> /* Wine-specific WIC GUIDs */

10 years, 8 months

[jimtabor] 61713: [User32] - Sync port MDI with wine. - Add patch from wine bug 9435. - Commented out wine code.

by jimtabor＠svn.reactos.org

Author: jimtabor Date: Mon Jan 20 06:42:39 2014 New Revision: 61713 URL: http://svn.reactos.org/svn/reactos?rev=61713&view=rev Log: [User32] - Sync port MDI with wine. - Add patch from wine bug 9435. - Commented out wine code. Modified: trunk/reactos/win32ss/user/user32/windows/mdi.c Modified: trunk/reactos/win32ss/user/user32/windows/mdi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/window… ============================================================================== --- trunk/reactos/win32ss/user/user32/windows/mdi.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/windows/mdi.c [iso-8859-1] Mon Jan 20 06:42:39 2014 @@ -123,6 +123,7 @@ UINT nTotalCreated; UINT mdiFlags; UINT sbRecalc; /* SB_xxx flags for scrollbar fixup */ + DWORD initialStyle; /* Style when window was created */ // See http://bugs.winehq.org/show_bug.cgi?id=9435 HBITMAP hBmpClose; /* ReactOS modification */ } MDICLIENTINFO; @@ -914,12 +915,18 @@ (LPCWSTR)HBMMENU_MBAR_CLOSE : (LPCWSTR)HBMMENU_MBAR_CLOSE_D ); /* The system menu is replaced by the child icon */ - hIcon = (HICON)GetClassLongPtrW(hChild, GCLP_HICONSM); +/* hIcon = (HICON)GetClassLongPtrW(hChild, GCLP_HICONSM); if (!hIcon) hIcon = (HICON)GetClassLongPtrW(hChild, GCLP_HICON); if (!hIcon) hIcon = LoadIconW(NULL, IDI_APPLICATION); +*/ //// End + hIcon = (HICON)SendMessageW(hChild, WM_GETICON, ICON_SMALL, 0); + if (!hIcon) + hIcon = (HICON)SendMessageW(hChild, WM_GETICON, ICON_BIG, 0); + if (!hIcon) + hIcon = LoadImageW(0, MAKEINTRESOURCEW(IDI_WINLOGO), IMAGE_ICON, GetSystemMetrics(SM_CXSMICON), GetSystemMetrics(SM_CYSMICON), LR_DEFAULTCOLOR); if (hIcon) { HDC hMemDC; @@ -1140,7 +1147,8 @@ ci->nTotalCreated = 0; ci->frameTitle = NULL; ci->mdiFlags = 0; - ci->hFrameMenu = GetMenu(cs->hwndParent); + ci->initialStyle = cs->style; + ci->hFrameMenu = GetMenu(cs->hwndParent); if (!ci->hBmpClose) ci->hBmpClose = CreateMDIMenuBitmap(); @@ -1231,8 +1239,11 @@ case WM_MDINEXT: /* lParam != 0 means previous window */ { - HWND next = MDI_GetWindow( ci, (HWND)wParam, !lParam, 0 ); + HWND hwnd = wParam ? WIN_GetFullHandle((HWND)wParam) : ci->hwndActiveChild; + HWND next = MDI_GetWindow( ci, hwnd, !lParam, 0 ); MDI_SwitchActiveChild( ci, next, TRUE ); + if(!lParam) + SetWindowPos(hwnd, HWND_BOTTOM, 0, 0, 0, 0, SWP_NOSIZE | SWP_NOMOVE | SWP_NOACTIVATE); break; } @@ -1431,7 +1442,7 @@ case SC_NEXTWINDOW: case SC_PREVWINDOW: case SC_RESTORE: - return SendMessageW( ci->hwndActiveChild, WM_SYSCOMMAND, + return SendMessageW( ci->hwndChildMaximized, WM_SYSCOMMAND, wParam, lParam); } } @@ -1563,7 +1574,7 @@ return 0; case WM_MENUCHAR: - return 0x00010000; /* MDI children don't have menu bars */ + return MAKELRESULT( 0, MNC_CLOSE ); /* MDI children don't have menu bars */ case WM_CLOSE: SendMessageW( client, WM_MDIDESTROY, (WPARAM)hwnd, 0 ); @@ -1593,10 +1604,10 @@ return SendMessageW( GetParent(client), message, wParam, lParam); break; case SC_NEXTWINDOW: - SendMessageW( client, WM_MDINEXT, 0, 0); + SendMessageW( client, WM_MDINEXT, (WPARAM)ci->hwndActiveChild, 0); return 0; case SC_PREVWINDOW: - SendMessageW( client, WM_MDINEXT, 0, 1); + SendMessageW( client, WM_MDINEXT, (WPARAM)ci->hwndActiveChild, 1); return 0; } break; @@ -1604,7 +1615,7 @@ case WM_SHOWWINDOW: #ifndef __REACTOS__ case WM_SETVISIBLE: -#endif +#endif //// Commented out r57663 /*if (ci->hwndChildMaximized) ci->mdiFlags &= ~MDIF_NEEDUPDATE; else*/ MDI_PostUpdate(client, ci, SB_BOTH+1); break; @@ -1802,8 +1813,10 @@ SCROLLINFO info; RECT childRect, clientRect; HWND *list; + MDICLIENTINFO *ci; WINDOWINFO WindowInfo; + ci = get_client_info(hwnd); GetClientRect( hwnd, &clientRect ); SetRectEmpty( &childRect ); @@ -1821,6 +1834,7 @@ return; } + ERR("CalcChildScroll 1\n"); if ((list = WIN_ListChildren( hwnd ))) { int i; @@ -1831,6 +1845,7 @@ { HeapFree( GetProcessHeap(), 0, list ); ShowScrollBar( hwnd, SB_BOTH, FALSE ); + ERR("CalcChildScroll 2\n"); return; } if (style & WS_VISIBLE) @@ -1839,13 +1854,15 @@ GetWindowRect( list[i], &rect ); OffsetRect(&rect, -WindowInfo.rcClient.left, -WindowInfo.rcClient.top); + //WIN_GetRectangles( list[i], COORDS_PARENT, &rect, NULL ); + ERR("CalcChildScroll L\n"); UnionRect( &childRect, &rect, &childRect ); } } HeapFree( GetProcessHeap(), 0, list ); } UnionRect( &childRect, &clientRect, &childRect ); - + ERR("CalcChildScroll 3\n"); /* set common info values */ info.cbSize = sizeof(info); info.fMask = SIF_POS | SIF_RANGE | SIF_PAGE; @@ -1864,15 +1881,30 @@ info.nMax = childRect.right; info.nPos = 0; info.nPage = 1 + clientRect.right - clientRect.left; - SetScrollInfo(hwnd, SB_HORZ, &info, TRUE); - if (scroll == SB_HORZ) break; + //info.nMax = childRect.right - clientRect.right; + //info.nPos = clientRect.left - childRect.left; + if (ci->initialStyle & WS_HSCROLL) + SetScrollInfo(hwnd, SB_HORZ, &info, TRUE); + if (scroll == SB_HORZ) + { + ERR("CalcChildScroll H\n"); + break; + } + else + { + ERR("CalcChildScroll B\n"); + } /* fall through */ case SB_VERT: info.nMin = childRect.top; info.nMax = childRect.bottom; info.nPos = 0; info.nPage = 1 + clientRect.bottom - clientRect.top; - SetScrollInfo(hwnd, SB_VERT, &info, TRUE); + //info.nMax = childRect.bottom - clientRect.bottom; + //info.nPos = clientRect.top - childRect.top; + ERR("CalcChildScroll V\n"); + if (ci->initialStyle & WS_VSCROLL) + SetScrollInfo(hwnd, SB_VERT, &info, TRUE); break; } }

10 years, 8 months

[cwittich] 61712: [explorer_new] use strsafe functions

by cwittich＠svn.reactos.org

Author: cwittich Date: Sun Jan 19 19:49:12 2014 New Revision: 61712 URL: http://svn.reactos.org/svn/reactos?rev=61712&view=rev Log: [explorer_new] use strsafe functions Modified: trunk/reactos/base/shell/explorer-new/explorer.c trunk/reactos/base/shell/explorer-new/precomp.h trunk/reactos/base/shell/explorer-new/traywnd.c Modified: trunk/reactos/base/shell/explorer-new/explorer.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer-new/ex… ============================================================================== --- trunk/reactos/base/shell/explorer-new/explorer.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/explorer-new/explorer.c [iso-8859-1] Sun Jan 19 19:49:12 2014 @@ -220,12 +220,14 @@ DWORD dwType, dwSize; BOOL Ret = FALSE; - _tcscpy(szBuffer, + StringCbCopy(szBuffer, sizeof(szBuffer), TEXT("Software\\Microsoft\\Windows\\CurrentVersion\\Explorer")); - _tcscat(szBuffer, - _T("\\")); - _tcscat(szBuffer, - lpSubKey); + if (FAILED(StringCbCat(szBuffer, sizeof(szBuffer), + _T("\\")))) + return FALSE; + if (FAILED(StringCbCat(szBuffer, sizeof(szBuffer), + lpSubKey))) + return FALSE; dwSize = sizeof(szBuffer); if (RegOpenKeyEx(hKey, Modified: trunk/reactos/base/shell/explorer-new/precomp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer-new/pr… ============================================================================== --- trunk/reactos/base/shell/explorer-new/precomp.h [iso-8859-1] (original) +++ trunk/reactos/base/shell/explorer-new/precomp.h [iso-8859-1] Sun Jan 19 19:49:12 2014 @@ -22,6 +22,7 @@ #include <shlwapi.h> #include <shlguid_undoc.h> #include <uxtheme.h> +#include <strsafe.h> #include "tmschema.h" #include "resource.h" Modified: trunk/reactos/base/shell/explorer-new/traywnd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer-new/tr… ============================================================================== --- trunk/reactos/base/shell/explorer-new/traywnd.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/explorer-new/traywnd.c [iso-8859-1] Sun Jan 19 19:49:12 2014 @@ -99,8 +99,13 @@ BOOL LaunchCPanel(HWND hwnd, LPCTSTR applet) { TCHAR szParams[MAX_PATH]; - _tcscpy(szParams, TEXT("shell32.dll,Control_RunDLL ")); - _tcscat(szParams, applet); + + StringCbCopy(szParams, sizeof(szParams), + TEXT("shell32.dll,Control_RunDLL ")); + if (FAILED(StringCbCat(szParams, sizeof(szParams), + applet))) + return FALSE; + return (ShellExecute(hwnd, TEXT("open"), TEXT("rundll32.exe"), szParams, NULL, SW_SHOWDEFAULT) > (HINSTANCE)32); }

10 years, 8 months

[cwittich] 61711: [devcpux] use strsafe functions

by cwittich＠svn.reactos.org

Author: cwittich Date: Sun Jan 19 19:27:10 2014 New Revision: 61711 URL: http://svn.reactos.org/svn/reactos?rev=61711&view=rev Log: [devcpux] use strsafe functions Modified: trunk/reactos/dll/shellext/devcpux/processor.c Modified: trunk/reactos/dll/shellext/devcpux/processor.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/devcpux/proce… ============================================================================== --- trunk/reactos/dll/shellext/devcpux/processor.c [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/devcpux/processor.c [iso-8859-1] Sun Jan 19 19:27:10 2014 @@ -17,6 +17,7 @@ #include <winuser.h> #include <setupapi.h> #include <powrprof.h> +#include <strsafe.h> #include "resource.h" @@ -73,12 +74,12 @@ } void -AddFeature(WCHAR* szFeatures, WCHAR* Feature, BOOL* bFirst) +AddFeature(WCHAR* szFeatures, size_t cbDest, WCHAR* Feature, BOOL* bFirst) { if (!*bFirst) - wcscat(szFeatures, L", "); + StringCbCatW(szFeatures, cbDest, L", "); *bFirst = FALSE; - wcscat(szFeatures, Feature); + StringCbCatW(szFeatures, cbDest, Feature); } INT_PTR @@ -97,28 +98,28 @@ PROCESSOR_POWER_INFORMATION PowerInfo; if (IsProcessorFeaturePresent(PF_MMX_INSTRUCTIONS_AVAILABLE)) - AddFeature(szFeatures, L"MMX", &bFirst); + AddFeature(szFeatures, sizeof(szFeatures), L"MMX", &bFirst); if (IsProcessorFeaturePresent(PF_XMMI_INSTRUCTIONS_AVAILABLE)) - AddFeature(szFeatures, L"SSE", &bFirst); + AddFeature(szFeatures, sizeof(szFeatures), L"SSE", &bFirst); if (IsProcessorFeaturePresent(PF_XMMI64_INSTRUCTIONS_AVAILABLE)) - AddFeature(szFeatures, L"SSE2", &bFirst); + AddFeature(szFeatures, sizeof(szFeatures), L"SSE2", &bFirst); /*if (IsProcessorFeaturePresent(PF_SSE3_INSTRUCTIONS_AVAILABLE)) - AddFeature(szFeatures, L"SSE3", &bFirst); */ + AddFeature(szFeatures, sizeof(szFeatures), L"SSE3", &bFirst); */ if (IsProcessorFeaturePresent(PF_3DNOW_INSTRUCTIONS_AVAILABLE)) - AddFeature(szFeatures, L"3DNOW", &bFirst); + AddFeature(szFeatures, sizeof(szFeatures), L"3DNOW", &bFirst); SetDlgItemTextW(hDlg, IDC_FEATURES, szFeatures); GetSystemInfo(&SystemInfo); - wsprintf(szModel, L"%x", HIBYTE(SystemInfo.wProcessorRevision)); - wsprintf(szStepping, L"%d", LOBYTE(SystemInfo.wProcessorRevision)); + StringCbPrintfW(szModel, sizeof(szModel), L"%x", HIBYTE(SystemInfo.wProcessorRevision)); + StringCbPrintfW(szStepping, sizeof(szStepping), L"%d", LOBYTE(SystemInfo.wProcessorRevision)); SetDlgItemTextW(hDlg, IDC_MODEL, szModel); SetDlgItemTextW(hDlg, IDC_STEPPING, szStepping); CallNtPowerInformation(11, NULL, 0, &PowerInfo, sizeof(PowerInfo)); - wsprintf(szCurrentMhz, L"%ld %s", PowerInfo.CurrentMhz, L"MHz"); + StringCbPrintfW(szCurrentMhz, sizeof(szCurrentMhz), L"%ld %s", PowerInfo.CurrentMhz, L"MHz"); SetDlgItemTextW(hDlg, IDC_CORESPEED, szCurrentMhz); return TRUE;

10 years, 8 months

[cwittich] 61710: [devcpux] tabs to spaces

by cwittich＠svn.reactos.org

Author: cwittich Date: Sun Jan 19 19:18:45 2014 New Revision: 61710 URL: http://svn.reactos.org/svn/reactos?rev=61710&view=rev Log: [devcpux] tabs to spaces Modified: trunk/reactos/dll/shellext/devcpux/processor.c Modified: trunk/reactos/dll/shellext/devcpux/processor.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/devcpux/proce… ============================================================================== --- trunk/reactos/dll/shellext/devcpux/processor.c [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/devcpux/processor.c [iso-8859-1] Sun Jan 19 19:18:45 2014 @@ -27,17 +27,17 @@ APIENTRY DllMain (HANDLE hInstance, DWORD dwReason, LPVOID lpReserved) { - switch (dwReason) - { - case DLL_THREAD_ATTACH: - case DLL_THREAD_DETACH: - case DLL_PROCESS_ATTACH: - case DLL_PROCESS_DETACH: - break; - } + switch (dwReason) + { + case DLL_THREAD_ATTACH: + case DLL_THREAD_DETACH: + case DLL_PROCESS_ATTACH: + case DLL_PROCESS_DETACH: + break; + } - g_hInstance = (HINSTANCE) hInstance; - return TRUE; + g_hInstance = (HINSTANCE) hInstance; + return TRUE; } @@ -45,84 +45,84 @@ APIENTRY PropSheetExtProc(PSP_PROPSHEETPAGE_REQUEST PropPageRequest, LPFNADDPROPSHEETPAGE fAddFunc, LPARAM lParam) { - PROPSHEETPAGE PropSheetPage; - HPROPSHEETPAGE hPropSheetPage; + PROPSHEETPAGE PropSheetPage; + HPROPSHEETPAGE hPropSheetPage; - if(PropPageRequest->PageRequested != SPPSR_ENUM_ADV_DEVICE_PROPERTIES) - return FALSE; + if(PropPageRequest->PageRequested != SPPSR_ENUM_ADV_DEVICE_PROPERTIES) + return FALSE; - if ((!PropPageRequest->DeviceInfoSet) || (!PropPageRequest->DeviceInfoData)) - return FALSE; + if ((!PropPageRequest->DeviceInfoSet) || (!PropPageRequest->DeviceInfoData)) + return FALSE; - ZeroMemory(&PropSheetPage, sizeof(PROPSHEETPAGE)); - PropSheetPage.dwSize = sizeof(PROPSHEETPAGE); - PropSheetPage.hInstance = g_hInstance; - PropSheetPage.pszTemplate = MAKEINTRESOURCE(DLG_PROCESSORINFO); - PropSheetPage.pfnDlgProc = ProcessorDlgProc; + ZeroMemory(&PropSheetPage, sizeof(PROPSHEETPAGE)); + PropSheetPage.dwSize = sizeof(PROPSHEETPAGE); + PropSheetPage.hInstance = g_hInstance; + PropSheetPage.pszTemplate = MAKEINTRESOURCE(DLG_PROCESSORINFO); + PropSheetPage.pfnDlgProc = ProcessorDlgProc; - hPropSheetPage = CreatePropertySheetPage(&PropSheetPage); - if(!hPropSheetPage) - return FALSE; + hPropSheetPage = CreatePropertySheetPage(&PropSheetPage); + if(!hPropSheetPage) + return FALSE; - if(!(fAddFunc)(hPropSheetPage, lParam)) { - DestroyPropertySheetPage (hPropSheetPage); - return FALSE; - } + if(!(fAddFunc)(hPropSheetPage, lParam)) { + DestroyPropertySheetPage (hPropSheetPage); + return FALSE; + } - return TRUE; + return TRUE; } void AddFeature(WCHAR* szFeatures, WCHAR* Feature, BOOL* bFirst) { - if (!*bFirst) - wcscat(szFeatures, L", "); - *bFirst = FALSE; - wcscat(szFeatures, Feature); + if (!*bFirst) + wcscat(szFeatures, L", "); + *bFirst = FALSE; + wcscat(szFeatures, Feature); } INT_PTR CALLBACK ProcessorDlgProc (HWND hDlg, UINT uMessage, WPARAM wParam, LPARAM lParam) { - switch (uMessage) { - case WM_INITDIALOG: - { - WCHAR szFeatures[MAX_PATH] = L""; - WCHAR szModel[3]; - WCHAR szStepping[3]; - WCHAR szCurrentMhz[10]; - BOOL bFirst = TRUE; - SYSTEM_INFO SystemInfo; - PROCESSOR_POWER_INFORMATION PowerInfo; + switch (uMessage) { + case WM_INITDIALOG: + { + WCHAR szFeatures[MAX_PATH] = L""; + WCHAR szModel[3]; + WCHAR szStepping[3]; + WCHAR szCurrentMhz[10]; + BOOL bFirst = TRUE; + SYSTEM_INFO SystemInfo; + PROCESSOR_POWER_INFORMATION PowerInfo; - if (IsProcessorFeaturePresent(PF_MMX_INSTRUCTIONS_AVAILABLE)) - AddFeature(szFeatures, L"MMX", &bFirst); - if (IsProcessorFeaturePresent(PF_XMMI_INSTRUCTIONS_AVAILABLE)) - AddFeature(szFeatures, L"SSE", &bFirst); - if (IsProcessorFeaturePresent(PF_XMMI64_INSTRUCTIONS_AVAILABLE)) - AddFeature(szFeatures, L"SSE2", &bFirst); - /*if (IsProcessorFeaturePresent(PF_SSE3_INSTRUCTIONS_AVAILABLE)) - AddFeature(szFeatures, L"SSE3", &bFirst); */ - if (IsProcessorFeaturePresent(PF_3DNOW_INSTRUCTIONS_AVAILABLE)) - AddFeature(szFeatures, L"3DNOW", &bFirst); + if (IsProcessorFeaturePresent(PF_MMX_INSTRUCTIONS_AVAILABLE)) + AddFeature(szFeatures, L"MMX", &bFirst); + if (IsProcessorFeaturePresent(PF_XMMI_INSTRUCTIONS_AVAILABLE)) + AddFeature(szFeatures, L"SSE", &bFirst); + if (IsProcessorFeaturePresent(PF_XMMI64_INSTRUCTIONS_AVAILABLE)) + AddFeature(szFeatures, L"SSE2", &bFirst); + /*if (IsProcessorFeaturePresent(PF_SSE3_INSTRUCTIONS_AVAILABLE)) + AddFeature(szFeatures, L"SSE3", &bFirst); */ + if (IsProcessorFeaturePresent(PF_3DNOW_INSTRUCTIONS_AVAILABLE)) + AddFeature(szFeatures, L"3DNOW", &bFirst); - SetDlgItemTextW(hDlg, IDC_FEATURES, szFeatures); + SetDlgItemTextW(hDlg, IDC_FEATURES, szFeatures); - GetSystemInfo(&SystemInfo); + GetSystemInfo(&SystemInfo); - wsprintf(szModel, L"%x", HIBYTE(SystemInfo.wProcessorRevision)); - wsprintf(szStepping, L"%d", LOBYTE(SystemInfo.wProcessorRevision)); + wsprintf(szModel, L"%x", HIBYTE(SystemInfo.wProcessorRevision)); + wsprintf(szStepping, L"%d", LOBYTE(SystemInfo.wProcessorRevision)); - SetDlgItemTextW(hDlg, IDC_MODEL, szModel); - SetDlgItemTextW(hDlg, IDC_STEPPING, szStepping); + SetDlgItemTextW(hDlg, IDC_MODEL, szModel); + SetDlgItemTextW(hDlg, IDC_STEPPING, szStepping); - CallNtPowerInformation(11, NULL, 0, &PowerInfo, sizeof(PowerInfo)); - wsprintf(szCurrentMhz, L"%ld %s", PowerInfo.CurrentMhz, L"MHz"); - SetDlgItemTextW(hDlg, IDC_CORESPEED, szCurrentMhz); + CallNtPowerInformation(11, NULL, 0, &PowerInfo, sizeof(PowerInfo)); + wsprintf(szCurrentMhz, L"%ld %s", PowerInfo.CurrentMhz, L"MHz"); + SetDlgItemTextW(hDlg, IDC_CORESPEED, szCurrentMhz); - return TRUE; - } - } - return FALSE; + return TRUE; + } + } + return FALSE; }

10 years, 8 months

[cwittich] 61709: [desk.cpl] strsafe++

by cwittich＠svn.reactos.org

Author: cwittich Date: Sun Jan 19 19:15:08 2014 New Revision: 61709 URL: http://svn.reactos.org/svn/reactos?rev=61709&view=rev Log: [desk.cpl] strsafe++ Modified: trunk/reactos/dll/cpl/desk/advappdlg.c trunk/reactos/dll/cpl/desk/background.c trunk/reactos/dll/cpl/desk/classinst.c trunk/reactos/dll/cpl/desk/desk.h trunk/reactos/dll/cpl/desk/devsett.c trunk/reactos/dll/cpl/desk/screensaver.c Modified: trunk/reactos/dll/cpl/desk/advappdlg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/advappdlg.c?r… ============================================================================== --- trunk/reactos/dll/cpl/desk/advappdlg.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/advappdlg.c [iso-8859-1] Sun Jan 19 19:15:08 2014 @@ -425,7 +425,7 @@ /* Fill font size combo */ for (i = 6; i <= 24; i++) { - wsprintf(Size, TEXT("%d"), i); + StringCbPrintf(Size, sizeof(Size), TEXT("%d"), i); SendDlgItemMessage(hwndDlg, IDC_ADVAPPEARANCE_FONTSIZE_E, CB_ADDSTRING, 0, (LPARAM)&Size); } Modified: trunk/reactos/dll/cpl/desk/background.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/background.c?… ============================================================================== --- trunk/reactos/dll/cpl/desk/background.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/background.c [iso-8859-1] Sun Jan 19 19:15:08 2014 @@ -88,6 +88,7 @@ TCHAR *token; HWND hwndBackgroundList; TCHAR *p; + HRESULT hr; hwndBackgroundList = GetDlgItem(hwndDlg, IDC_BACKGROUND_LIST); @@ -134,7 +135,12 @@ /* Allow environment variables in file name */ if (ExpandEnvironmentStrings(wallpaperFilename, buffer, MAX_PATH)) { - _tcscpy(wallpaperFilename, buffer); + hr = StringCbCopy(wallpaperFilename, sizeof(wallpaperFilename), buffer); + if (FAILED(hr)) + { + RegCloseKey(regKey); + return; + } } himl = (HIMAGELIST)SHGetFileInfo(wallpaperFilename, @@ -155,11 +161,23 @@ backgroundItem->bWallpaper = TRUE; - _tcscpy(backgroundItem->szDisplayName, sfi.szDisplayName); + hr = StringCbCopy(backgroundItem->szDisplayName, sizeof(backgroundItem->szDisplayName), sfi.szDisplayName); + if (FAILED(hr)) + { + RegCloseKey(regKey); + return; + } + p = _tcsrchr(backgroundItem->szDisplayName, _T('.')); if (p) *p = (TCHAR)0; - _tcscpy(backgroundItem->szFilename, wallpaperFilename); + + hr = StringCbCopy(backgroundItem->szFilename, sizeof(backgroundItem->szFilename), wallpaperFilename); + if (FAILED(hr)) + { + RegCloseKey(regKey); + return; + } ZeroMemory(&listItem, sizeof(LV_ITEM)); listItem.mask = LVIF_TEXT | LVIF_PARAM | LVIF_STATE | LVIF_IMAGE; @@ -190,8 +208,13 @@ while (token != NULL) { GetWindowsDirectory(szSearchPath, MAX_PATH); - _tcscat(szSearchPath, TEXT("\\")); - _tcscat(szSearchPath, token); + + hr = StringCbCat(szSearchPath, sizeof(szSearchPath), TEXT("\\")); + if (FAILED(hr)) + return; + hr = StringCbCat(szSearchPath, sizeof(szSearchPath), token); + if (FAILED(hr)) + return; hFind = FindFirstFile(szSearchPath, &fd); while (hFind != INVALID_HANDLE_VALUE) @@ -200,8 +223,18 @@ GetWindowsDirectory(filename, MAX_PATH); - _tcscat(filename, TEXT("\\")); - _tcscat(filename, fd.cFileName); + hr = StringCbCat(filename, sizeof(filename), TEXT("\\")); + if (FAILED(hr)) + { + FindClose(hFind); + return; + } + hr = StringCbCat(filename, sizeof(filename), fd.cFileName); + if (FAILED(hr)) + { + FindClose(hFind); + return; + } /* Don't add any hidden bitmaps. Also don't add current wallpaper once more. */ if (((fd.dwFileAttributes & FILE_ATTRIBUTE_HIDDEN) == 0) && (_tcscmp(wallpaperFilename, filename) != 0)) @@ -225,11 +258,21 @@ backgroundItem->bWallpaper = TRUE; - _tcscpy(backgroundItem->szDisplayName, sfi.szDisplayName); + hr = StringCbCopy(backgroundItem->szDisplayName, sizeof(backgroundItem->szDisplayName), sfi.szDisplayName); + if (FAILED(hr)) + { + FindClose(hFind); + return; + } p = _tcsrchr(backgroundItem->szDisplayName, _T('.')); if (p) *p = (TCHAR)0; - _tcscpy(backgroundItem->szFilename, filename); + hr = StringCbCopy(backgroundItem->szFilename, sizeof(backgroundItem->szFilename), filename); + if (FAILED(hr)) + { + FindClose(hFind); + return; + } ZeroMemory(&listItem, sizeof(LV_ITEM)); listItem.mask = LVIF_TEXT | LVIF_PARAM | LVIF_STATE | LVIF_IMAGE; @@ -249,6 +292,7 @@ } token = _tcstok(NULL, separators); + FindClose(hFind); } } @@ -428,6 +472,7 @@ LV_ITEM listItem; HWND hwndBackgroundList; TCHAR *p; + HRESULT hr; hwndBackgroundList = GetDlgItem(hwndDlg, IDC_BACKGROUND_LIST); @@ -469,11 +514,15 @@ backgroundItem->bWallpaper = TRUE; - _tcscpy(backgroundItem->szDisplayName, sfi.szDisplayName); + hr = StringCbCopy(backgroundItem->szDisplayName, sizeof(backgroundItem->szDisplayName), sfi.szDisplayName); + if (FAILED(hr)) + return; p = _tcsrchr(backgroundItem->szDisplayName, _T('.')); if (p) *p = (TCHAR)0; - _tcscpy(backgroundItem->szFilename, filename); + hr = StringCbCopy(backgroundItem->szFilename, sizeof(backgroundItem->szFilename), filename); + if (FAILED(hr)) + return; ZeroMemory(&listItem, sizeof(LV_ITEM)); listItem.mask = LVIF_TEXT | LVIF_PARAM | LVIF_STATE | LVIF_IMAGE; @@ -736,7 +785,7 @@ green = GetGValue(g_GlobalData.desktop_color); blue = GetBValue(g_GlobalData.desktop_color); /* Format string to be set to registry */ - wsprintf(clText, TEXT("%d %d %d"), red, green, blue); + StringCbPrintf(clText, sizeof(clText), TEXT("%d %d %d"), red, green, blue); RegSetValueEx(hKey, TEXT("Background"), 0, REG_SZ, (BYTE *)clText, (lstrlen(clText) + 1) * sizeof(TCHAR)); RegCloseKey(hKey); Modified: trunk/reactos/dll/cpl/desk/classinst.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/classinst.c?r… ============================================================================== --- trunk/reactos/dll/cpl/desk/classinst.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/classinst.c [iso-8859-1] Sun Jan 19 19:15:08 2014 @@ -32,6 +32,7 @@ DWORD disposition; BOOL result; LONG rc; + HRESULT hr; if (InstallFunction != DIF_INSTALLDEVICE) return ERROR_DI_DO_DEFAULT; @@ -104,7 +105,12 @@ DPRINT("SetupDiGetActualSectionToInstall() failed with error 0x%lx\n", rc); goto cleanup; } - _tcscat(SectionName, _T(".SoftwareSettings")); + hr = StringCbCat(SectionName, sizeof(SectionName), _T(".SoftwareSettings")); + if (FAILED(hr)) + { + rc = ERROR_INSUFFICIENT_BUFFER; + goto cleanup; + } /* Open driver registry key and create Settings subkey */ hDriverKey = SetupDiOpenDevRegKey( Modified: trunk/reactos/dll/cpl/desk/desk.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/desk.h?rev=61… ============================================================================== --- trunk/reactos/dll/cpl/desk/desk.h [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/desk.h [iso-8859-1] Sun Jan 19 19:15:08 2014 @@ -19,6 +19,7 @@ #include <shlobj.h> #include <regstr.h> #include <dll/desk/deskcplx.h> +#include <strsafe.h> #include "appearance.h" #include "preview.h" Modified: trunk/reactos/dll/cpl/desk/devsett.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/devsett.c?rev… ============================================================================== --- trunk/reactos/dll/cpl/desk/devsett.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/devsett.c [iso-8859-1] Sun Jan 19 19:15:08 2014 @@ -83,7 +83,7 @@ if (str != NULL) { #ifdef UNICODE - wcscpy(str, + StringCbCopyW(str, c * sizeof(WCHAR), pszSrc); #else MultiByteToWideChar(CP_ACP, @@ -556,7 +556,7 @@ PCWSTR pszRet = NULL; PWSTR pszBuf; PCDevSettings This = impl_from_IDataObject(iface); - + ZeroMemory(pmedium, sizeof(STGMEDIUM)); @@ -662,11 +662,12 @@ pszRet = szEmpty; pszBuf = GlobalAlloc(GPTR, - (_tcslen(pszRet) + 1) * sizeof(WCHAR)); + (wcslen(pszRet) + 1) * sizeof(WCHAR)); if (pszBuf != NULL) { - _tcscpy(pszBuf, - pszRet); + hr = StringCbCopy(pszBuf, (wcslen(pszRet) + 1) * sizeof(WCHAR), pszRet); + if (FAILED(hr)) + return hr; pmedium->tymed = TYMED_HGLOBAL; pmedium->hGlobal = pszBuf; Modified: trunk/reactos/dll/cpl/desk/screensaver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/desk/screensaver.c… ============================================================================== --- trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/desk/screensaver.c [iso-8859-1] Sun Jan 19 19:15:08 2014 @@ -333,11 +333,17 @@ ScreenSaverItem *ScreenSaverItem; HANDLE hModule; UINT i, ScreenSaverCount; + HRESULT hr; ScreenSaverCount = pData->ScreenSaverCount; - _tcscpy(szSearchPath, pszSearchPath); - _tcscat(szSearchPath, TEXT("\\*.scr")); + + hr = StringCbCopy(szSearchPath, sizeof(szSearchPath), pszSearchPath); + if (FAILED(hr)) + return; + hr = StringCbCat(szSearchPath, sizeof(szSearchPath), TEXT("\\*.scr")); + if (FAILED(hr)) + return; hFind = FindFirstFile(szSearchPath, &fd); @@ -351,9 +357,24 @@ { TCHAR filename[MAX_PATH]; - _tcscpy(filename, pszSearchPath); - _tcscat(filename, _T("\\")); - _tcscat(filename, fd.cFileName); + hr = StringCbCopy(filename, sizeof(filename), pszSearchPath); + if (FAILED(hr)) + { + FindClose(hFind); + return; + } + hr = StringCbCat(filename, sizeof(filename), _T("\\")); + if (FAILED(hr)) + { + FindClose(hFind); + return; + } + hr = StringCbCat(filename, sizeof(filename), fd.cFileName); + if (FAILED(hr)) + { + FindClose(hFind); + return; + } ScreenSaverItem = pData->ScreenSaverItems + ScreenSaverCount; @@ -370,17 +391,33 @@ sizeof(ScreenSaverItem->szDisplayName) / sizeof(TCHAR))) { // If the string does not exists, copy the name of the file - _tcscpy(ScreenSaverItem->szDisplayName, fd.cFileName); + hr = StringCbCopy(ScreenSaverItem->szDisplayName, sizeof(ScreenSaverItem->szDisplayName), fd.cFileName); + if (FAILED(hr)) + { + FreeLibrary(hModule); + FindClose(hFind); + return; + } ScreenSaverItem->szDisplayName[_tcslen(fd.cFileName)-4] = '\0'; } FreeLibrary(hModule); } else { - _tcscpy(ScreenSaverItem->szDisplayName, _T("Unknown")); - } - - _tcscpy(ScreenSaverItem->szFilename, filename); + hr = StringCbCopy(ScreenSaverItem->szDisplayName, sizeof(ScreenSaverItem->szDisplayName), _T("Unknown")); + if (FAILED(hr)) + { + FindClose(hFind); + return; + } + } + + hr = StringCbCopy(ScreenSaverItem->szFilename, sizeof(ScreenSaverItem->szFilename), filename); + if (FAILED(hr)) + { + FindClose(hFind); + return; + } i = SendMessage(hwndScreenSavers, CB_ADDSTRING,

10 years, 8 months

[tfaber] 61708: [DDK][NDK] - Fix some members of SHARED_CACHE_MAP - Move MBCB to NDK where it belongs

by tfaber＠svn.reactos.org

Author: tfaber Date: Sun Jan 19 15:05:23 2014 New Revision: 61708 URL: http://svn.reactos.org/svn/reactos?rev=61708&view=rev Log: [DDK][NDK] - Fix some members of SHARED_CACHE_MAP - Move MBCB to NDK where it belongs Modified: trunk/reactos/include/ddk/ntifs.h trunk/reactos/include/ndk/cctypes.h trunk/reactos/include/xdk/ntifs.template.h Modified: trunk/reactos/include/ddk/ntifs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntifs.h?rev=61… ============================================================================== --- trunk/reactos/include/ddk/ntifs.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/ntifs.h [iso-8859-1] Sun Jan 19 15:05:23 2014 @@ -11416,19 +11416,6 @@ MAPPING_PAIR Pair[1]; } GET_RETRIEVAL_DESCRIPTOR, *PGET_RETRIEVAL_DESCRIPTOR; -typedef struct _MBCB { - CSHORT NodeTypeCode; - CSHORT NodeIsInZone; - ULONG PagesToWrite; - ULONG DirtyPages; - ULONG Reserved; - LIST_ENTRY BitmapRanges; - LONGLONG ResumeWritePage; - BITMAP_RANGE BitmapRange1; - BITMAP_RANGE BitmapRange2; - BITMAP_RANGE BitmapRange3; -} MBCB, *PMBCB; - typedef struct _MOVEFILE_DESCRIPTOR { HANDLE FileHandle; ULONG Reserved; Modified: trunk/reactos/include/ndk/cctypes.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/cctypes.h?rev=… ============================================================================== --- trunk/reactos/include/ndk/cctypes.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/cctypes.h [iso-8859-1] Sun Jan 19 15:05:23 2014 @@ -81,6 +81,19 @@ LIST_ENTRY PrivateLinks; } PRIVATE_CACHE_MAP, *PPRIVATE_CACHE_MAP; +typedef struct _MBCB { + CSHORT NodeTypeCode; + CSHORT NodeIsInZone; + ULONG PagesToWrite; + ULONG DirtyPages; + ULONG Reserved; + LIST_ENTRY BitmapRanges; + LONGLONG ResumeWritePage; + BITMAP_RANGE BitmapRange1; + BITMAP_RANGE BitmapRange2; + BITMAP_RANGE BitmapRange3; +} MBCB, *PMBCB; + #ifdef _NTIFS_INCLUDED_ // @@ -103,12 +116,12 @@ PVOID NeedToZero; ULONG ActivePage; ULONG NeedToZeroPage; - ULONG ActiveVacbSpinLock; + KSPIN_LOCK ActiveVacbSpinLock; ULONG VacbActiveCount; ULONG DirtyPages; LIST_ENTRY SharedCacheMapLinks; ULONG Flags; - ULONG Status; + LONG Status; PMBCB Mbcb; PVOID Section; PKEVENT CreateEvent; @@ -119,12 +132,12 @@ PVOID LazyWriteContext; LIST_ENTRY PrivateList; PVOID LogHandle; - PVOID FlushToLsnRoutine; + PFLUSH_TO_LSN FlushToLsnRoutine; ULONG DirtyPageThreshold; ULONG LazyWritePassCount; PCACHE_UNINITIALIZE_EVENT UninitializeEvent; PVACB NeedToZeroVacb; - ULONG BcbSpinLock; + KSPIN_LOCK BcbSpinLock; PVOID Reserved; KEVENT Event; EX_PUSH_LOCK VacbPushLock; Modified: trunk/reactos/include/xdk/ntifs.template.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/xdk/ntifs.template… ============================================================================== --- trunk/reactos/include/xdk/ntifs.template.h [iso-8859-1] (original) +++ trunk/reactos/include/xdk/ntifs.template.h [iso-8859-1] Sun Jan 19 15:05:23 2014 @@ -1534,19 +1534,6 @@ ULONGLONG StartVcn; MAPPING_PAIR Pair[1]; } GET_RETRIEVAL_DESCRIPTOR, *PGET_RETRIEVAL_DESCRIPTOR; - -typedef struct _MBCB { - CSHORT NodeTypeCode; - CSHORT NodeIsInZone; - ULONG PagesToWrite; - ULONG DirtyPages; - ULONG Reserved; - LIST_ENTRY BitmapRanges; - LONGLONG ResumeWritePage; - BITMAP_RANGE BitmapRange1; - BITMAP_RANGE BitmapRange2; - BITMAP_RANGE BitmapRange3; -} MBCB, *PMBCB; typedef struct _MOVEFILE_DESCRIPTOR { HANDLE FileHandle;

10 years, 8 months

[tfaber] 61707: [DDK][NDK][RTL][WS2_32_NEW] - Add missing and improve existing declarations of RtlIpv4StringToAddress*

by tfaber＠svn.reactos.org

Author: tfaber Date: Sun Jan 19 14:56:13 2014 New Revision: 61707 URL: http://svn.reactos.org/svn/reactos?rev=61707&view=rev Log: [DDK][NDK][RTL][WS2_32_NEW] - Add missing and improve existing declarations of RtlIpv4StringToAddress* Modified: trunk/reactos/dll/win32/ws2_32_new/src/addrinfo.c trunk/reactos/include/ndk/rtlfuncs.h trunk/reactos/include/psdk/mstcpip.h trunk/reactos/lib/rtl/network.c Modified: trunk/reactos/dll/win32/ws2_32_new/src/addrinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ws2_32_new/src/a… ============================================================================== --- trunk/reactos/dll/win32/ws2_32_new/src/addrinfo.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ws2_32_new/src/addrinfo.c [iso-8859-1] Sun Jan 19 14:56:13 2014 @@ -87,15 +87,18 @@ ParseV4Address(IN PCWSTR AddressString, OUT PDWORD pAddress) { - DWORD Address; - LPWSTR Ip = 0; - - /* Do the conversion, don't accept wildcard */ - RtlIpv4StringToAddressW((LPWSTR)AddressString, 0, &Ip, (IN_ADDR *)&Address); - - /* Return the address and success */ - *pAddress = Address; - return FALSE; + IN_ADDR Address; + PCWSTR Terminator; + NTSTATUS Status; + + *pAddress = 0; + Status = RtlIpv4StringToAddressW(AddressString, FALSE, &Terminator, &Address); + + if (!NT_SUCCESS(Status)) + return FALSE; + + *pAddress = Address.S_un.S_addr; + return TRUE; } static Modified: trunk/reactos/include/ndk/rtlfuncs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ndk/rtlfuncs.h?rev… ============================================================================== --- trunk/reactos/include/ndk/rtlfuncs.h [iso-8859-1] (original) +++ trunk/reactos/include/ndk/rtlfuncs.h [iso-8859-1] Sun Jan 19 14:56:13 2014 @@ -3994,11 +3994,41 @@ NTSYSAPI NTSTATUS NTAPI +RtlIpv4StringToAddressA( + _In_ PCSTR String, + _In_ BOOLEAN Strict, + _Out_ PCSTR *Terminator, + _Out_ struct in_addr *Addr +); + +NTSYSAPI +NTSTATUS +NTAPI RtlIpv4StringToAddressW( _In_ PCWSTR String, _In_ BOOLEAN Strict, - _Out_ LPWSTR *Terminator, + _Out_ PCWSTR *Terminator, _Out_ struct in_addr *Addr +); + +NTSYSAPI +NTSTATUS +NTAPI +RtlIpv4StringToAddressExA( + _In_ PCSTR AddressString, + _In_ BOOLEAN Strict, + _Out_ struct in_addr *Address, + _Out_ PUSHORT Port +); + +NTSYSAPI +NTSTATUS +NTAPI +RtlIpv4StringToAddressExW( + _In_ PCWSTR AddressString, + _In_ BOOLEAN Strict, + _Out_ struct in_addr *Address, + _Out_ PUSHORT Port ); NTSYSAPI Modified: trunk/reactos/include/psdk/mstcpip.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/psdk/mstcpip.h?rev… ============================================================================== --- trunk/reactos/include/psdk/mstcpip.h [iso-8859-1] (original) +++ trunk/reactos/include/psdk/mstcpip.h [iso-8859-1] Sun Jan 19 14:56:13 2014 @@ -1340,7 +1340,7 @@ LONG NTAPI RtlIpv4StringToAddressA( - _In_ PCSTR S, + _In_ PCSTR String, _In_ BOOLEAN Strict, _Out_ PCSTR *Terminator, _Out_ struct in_addr *Addr); @@ -1358,9 +1358,9 @@ LONG NTAPI RtlIpv4StringToAddressW( - _In_ PCWSTR S, + _In_ PCWSTR String, _In_ BOOLEAN Strict, - _Out_ LPCWSTR *Terminator, + _Out_ PCWSTR *Terminator, _Out_ struct in_addr *Addr); NTSYSAPI Modified: trunk/reactos/lib/rtl/network.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/network.c?rev=6170… ============================================================================== --- trunk/reactos/lib/rtl/network.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/network.c [iso-8859-1] Sun Jan 19 14:56:13 2014 @@ -32,7 +32,7 @@ OUT PCHAR S) { INT Length; - + if (!S) return (LPSTR)~0; Length = sprintf(S, "%u.%u.%u.%u", Addr->S_un.S_un_b.s_b1, @@ -88,7 +88,7 @@ INT Length; if (!S) return (LPWSTR)~0; - + Length = swprintf(S, L"%u.%u.%u.%u", Addr->S_un.S_un_b.s_b1, Addr->S_un.S_un_b.s_b2, Addr->S_un.S_un_b.s_b3, @@ -135,9 +135,9 @@ */ NTSTATUS NTAPI -RtlIpv4StringToAddressA(IN PCHAR String, +RtlIpv4StringToAddressA(IN PCSTR String, IN BOOLEAN Strict, - OUT PCHAR *Terminator, + OUT PCSTR *Terminator, OUT struct in_addr *Addr) { UNIMPLEMENTED; @@ -149,10 +149,10 @@ */ NTSTATUS NTAPI -RtlIpv4StringToAddressExA(IN PCHAR AddressString, +RtlIpv4StringToAddressExA(IN PCSTR AddressString, IN BOOLEAN Strict, OUT struct in_addr *Address, - IN PUSHORT Port) + OUT PUSHORT Port) { UNIMPLEMENTED; return STATUS_NOT_IMPLEMENTED; @@ -165,7 +165,7 @@ NTAPI RtlIpv4StringToAddressW(IN PCWSTR String, IN BOOLEAN Strict, - OUT LPWSTR *Terminator, + OUT PCWSTR *Terminator, OUT struct in_addr *Addr) { UNIMPLEMENTED; @@ -177,7 +177,7 @@ */ NTSTATUS NTAPI -RtlIpv4StringToAddressExW(IN PWCHAR AddressString, +RtlIpv4StringToAddressExW(IN PCWSTR AddressString, IN BOOLEAN Strict, OUT struct in_addr *Address, OUT PUSHORT Port)

10 years, 8 months

[dreimer] 61706: [RAPPS] Add Mpxplay to Application manager by Alex (jedi-to-be) CORE-7290 #resolve #comment Committed and slightly fixed DL link and comment. Thx for help!

by dreimer＠svn.reactos.org

Author: dreimer Date: Sun Jan 19 13:17:09 2014 New Revision: 61706 URL: http://svn.reactos.org/svn/reactos?rev=61706&view=rev Log: [RAPPS] Add Mpxplay to Application manager by Alex (jedi-to-be) CORE-7290 #resolve #comment Committed and slightly fixed DL link and comment. Thx for help! Added: trunk/reactos/base/applications/rapps/rapps/mpxplay.txt (with props) Added: trunk/reactos/base/applications/rapps/rapps/mpxplay.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/ra… ============================================================================== --- trunk/reactos/base/applications/rapps/rapps/mpxplay.txt (added) +++ trunk/reactos/base/applications/rapps/rapps/mpxplay.txt [iso-8859-1] Sun Jan 19 13:17:09 2014 @@ -0,0 +1,18 @@ +ï»¿; UTF-8 + +[Section] +Name = Mpxplay +Version = 1.60b +Licence = GPL +Description = Mpxplay is a 32-bit console audio player for Windows. You need 7-Zip or a similar Utility to extract it. +Size = 520 kB +Category = 1 +URLSite = http://mpxplay.sourceforge.net/ +URLDownload = http://garr.dl.sourceforge.net/project/mpxplay/Mpxplay/Mpxplay%20v1.60%20fi… +CDPath = none + +[Section.0407] +Description = Mpxplay ist ein konsolenbasierter 32-bit Audio Player fÃ¼r Windows. Zum extrahieren wird 7-Zip oder ein Ã¤hnliches Tool benÃ¶tigt. + +[Section.0419] +Description = Mpxplay - 32-ÑÐ°Ð·ÑÑÐ´Ð½ÑÐ¹ ÐºÐ¾Ð½ÑÐ¾Ð»ÑÐ½ÑÐ¹ Ð°ÑÐ´Ð¸Ð¾Ð¿Ð»ÐµÐµÑ Ð´Ð»Ñ Windows. ÐÐ°Ð¼ Ð½ÑÐ¶ÐµÐ½ 7-Zip Ð¸Ð»Ð¸ Ð¿Ð¾Ð´Ð¾Ð±Ð½Ð°Ñ ÑÑÐ¸Ð»Ð¸ÑÐ° Ð´Ð»Ñ ÐµÐ³Ð¾ ÑÐ°ÑÐ¿Ð°ÐºÐ¾Ð²ÐºÐ¸. Propchange: trunk/reactos/base/applications/rapps/rapps/mpxplay.txt ------------------------------------------------------------------------------ svn:eol-style = native

10 years, 8 months

← Newer
1
...
16
17
18
19
20
21
22
...
43
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs January 2014