Ros-diffs October 2014

ros-diffs@reactos.org

19 participants
730 discussions

[akhaldi] 65022: [ADVAPI32] * Update GetAclInformation(). CORE-8540
by akhaldi＠svn.reactos.org 26 Oct '14

26 Oct '14

Author: akhaldi Date: Sun Oct 26 17:51:59 2014 New Revision: 65022 URL: http://svn.reactos.org/svn/reactos?rev=65022&view=rev Log: [ADVAPI32] * Update GetAclInformation(). CORE-8540 Modified: trunk/reactos/dll/win32/advapi32/wine/security.c Modified: trunk/reactos/dll/win32/advapi32/wine/security.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/wine/se… ============================================================================== --- trunk/reactos/dll/win32/advapi32/wine/security.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/wine/security.c [iso-8859-1] Sun Oct 26 17:51:59 2014 @@ -1100,29 +1100,17 @@ return set_ntstatus(RtlGetAce(pAcl, dwAceIndex, pAce)); } -/* - * @implemented - */ -BOOL -WINAPI -GetAclInformation(PACL pAcl, - LPVOID pAclInformation, - DWORD nAclInformationLength, - ACL_INFORMATION_CLASS dwAclInformationClass) -{ - NTSTATUS Status; - - Status = RtlQueryInformationAcl(pAcl, - pAclInformation, - nAclInformationLength, - dwAclInformationClass); - if (!NT_SUCCESS(Status)) - { - SetLastError(RtlNtStatusToDosError(Status)); - return FALSE; - } - - return TRUE; +/****************************************************************************** + * GetAclInformation [ADVAPI32.@] + */ +BOOL WINAPI GetAclInformation( + PACL pAcl, + LPVOID pAclInformation, + DWORD nAclInformationLength, + ACL_INFORMATION_CLASS dwAclInformationClass) +{ + return set_ntstatus(RtlQueryInformationAcl(pAcl, pAclInformation, + nAclInformationLength, dwAclInformationClass)); } /*

1 0

[tfaber] 65021: [CRT] - Fix strlen/wcslen FPO specification. Spotted by Timo. - Also add FPO info for memset, memchr, memmove/memcpy
by tfaber＠svn.reactos.org 26 Oct '14

26 Oct '14

Author: tfaber Date: Sun Oct 26 17:32:00 2014 New Revision: 65021 URL: http://svn.reactos.org/svn/reactos?rev=65021&view=rev Log: [CRT] - Fix strlen/wcslen FPO specification. Spotted by Timo. - Also add FPO info for memset, memchr, memmove/memcpy Modified: trunk/reactos/lib/sdk/crt/mem/i386/memchr_asm.s trunk/reactos/lib/sdk/crt/mem/i386/memmove_asm.s trunk/reactos/lib/sdk/crt/mem/i386/memset_asm.s trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc Modified: trunk/reactos/lib/sdk/crt/mem/i386/memchr_asm.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/mem/i386/memch… ============================================================================== --- trunk/reactos/lib/sdk/crt/mem/i386/memchr_asm.s [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/mem/i386/memchr_asm.s [iso-8859-1] Sun Oct 26 17:32:00 2014 @@ -14,7 +14,8 @@ PUBLIC _memchr .code -_memchr: +FUNC _memchr + FPO 0, 3, 4, 1, 1, FRAME_NONFPO push ebp mov ebp, esp push edi @@ -33,5 +34,6 @@ pop edi leave ret +ENDFUNC END Modified: trunk/reactos/lib/sdk/crt/mem/i386/memmove_asm.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/mem/i386/memmo… ============================================================================== --- trunk/reactos/lib/sdk/crt/mem/i386/memmove_asm.s [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/mem/i386/memmove_asm.s [iso-8859-1] Sun Oct 26 17:32:00 2014 @@ -11,7 +11,8 @@ .code _memcpy: -_memmove: +FUNC _memmove + FPO 0, 3, 5, 2, 1, FRAME_NONFPO push ebp mov ebp, esp @@ -116,5 +117,6 @@ dec esi dec edi jmp .L8 +ENDFUNC END Modified: trunk/reactos/lib/sdk/crt/mem/i386/memset_asm.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/mem/i386/memse… ============================================================================== --- trunk/reactos/lib/sdk/crt/mem/i386/memset_asm.s [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/mem/i386/memset_asm.s [iso-8859-1] Sun Oct 26 17:32:00 2014 @@ -9,7 +9,8 @@ PUBLIC _memset .code -_memset: +FUNC _memset + FPO 0, 3, 4, 1, 1, FRAME_NONFPO push ebp mov ebp, esp push edi @@ -45,5 +46,6 @@ mov eax, [ebp + 8] leave ret +ENDFUNC END Modified: trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/string/i386/tc… ============================================================================== --- trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/string/i386/tcsnlen.inc [iso-8859-1] Sun Oct 26 17:32:00 2014 @@ -6,7 +6,7 @@ .code FUNC _tcsnlen - FPO 0, 1, 1, 1, 0, FRAME_FPO + FPO 0, 2, 1, 1, 0, FRAME_FPO push edi mov edi, [esp + 8] mov ecx, [esp + 12]

1 0

[gadamopoulos] 65020: [browseui] - Improve CBaseBar::TranslateAcceleratorIO stub - Returning always TRUE means that creating a basebar ended up eating all messages - Fixes the hang that happened wh...
by gadamopoulos＠svn.reactos.org 26 Oct '14

26 Oct '14

Author: gadamopoulos Date: Sun Oct 26 17:16:19 2014 New Revision: 65020 URL: http://svn.reactos.org/svn/reactos?rev=65020&view=rev Log: [browseui] - Improve CBaseBar::TranslateAcceleratorIO stub - Returning always TRUE means that creating a basebar ended up eating all messages - Fixes the hang that happened when we clicked on the folders button in the toolbar Modified: branches/shell-experiments/dll/win32/browseui/basebar.cpp Modified: branches/shell-experiments/dll/win32/browseui/basebar.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/bro… ============================================================================== --- branches/shell-experiments/dll/win32/browseui/basebar.cpp [iso-8859-1] (original) +++ branches/shell-experiments/dll/win32/browseui/basebar.cpp [iso-8859-1] Sun Oct 26 17:16:19 2014 @@ -296,7 +296,7 @@ HRESULT STDMETHODCALLTYPE CBaseBar::TranslateAcceleratorIO(LPMSG lpMsg) { // forward to contained bar - return S_OK; + return S_FALSE; } HRESULT STDMETHODCALLTYPE CBaseBar::SetClient(IUnknown *punkClient)

1 0

[dquintana] 65019: [BROWSEUI] * Sidebars are not implemented, but it's ok. No need to force a debug break in there.
by dquintana＠svn.reactos.org 26 Oct '14

26 Oct '14

Author: dquintana Date: Sun Oct 26 17:06:58 2014 New Revision: 65019 URL: http://svn.reactos.org/svn/reactos?rev=65019&view=rev Log: [BROWSEUI] * Sidebars are not implemented, but it's ok. No need to force a debug break in there. Modified: branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp Modified: branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp URL: http://svn.reactos.org/svn/reactos/branches/shell-experiments/dll/win32/bro… ============================================================================== --- branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] (original) +++ branches/shell-experiments/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] Sun Oct 26 17:06:58 2014 @@ -1179,8 +1179,6 @@ VARIANT vaIn; HRESULT hResult; - __debugbreak(); - hResult = GetBaseBar(vertical, (IUnknown **)&theBaseBar); if (FAILED_UNEXPECTEDLY(hResult)) return hResult;

1 0

[hbelusca] 65018: [NTVDM]: Temporarily fix for r65015 before a proper fix.
by hbelusca＠svn.reactos.org 26 Oct '14

26 Oct '14

Author: hbelusca Date: Sun Oct 26 16:56:14 2014 New Revision: 65018 URL: http://svn.reactos.org/svn/reactos?rev=65018&view=rev Log: [NTVDM]: Temporarily fix for r65015 before a proper fix. Modified: trunk/reactos/subsystems/ntvdm/bios/vidbios.c Modified: trunk/reactos/subsystems/ntvdm/bios/vidbios.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/ntvdm/bios/vidb… ============================================================================== --- trunk/reactos/subsystems/ntvdm/bios/vidbios.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/ntvdm/bios/vidbios.c [iso-8859-1] Sun Oct 26 16:56:14 2014 @@ -2296,8 +2296,15 @@ { BYTE Page; COORD Resolution; + PVGA_REGISTERS VgaMode; + + /* + * IBM standard modes do not clear the screen if the + * high bit of AL is set (EGA or higher only). + * See Ralf Brown: http://www.ctyme.com/intr/rb-0069.htm + * for more information. + */ BOOLEAN DoNotClear = !!(ModeNumber & 0x80); - PVGA_REGISTERS VgaMode; /* Retrieve the real mode number and check its validity */ ModeNumber &= 0x7F; @@ -2308,8 +2315,13 @@ return FALSE; } - /* Check if this is the same mode */ - if (ModeNumber == Bda->VideoMode) return TRUE; + /* Check if this is the current mode */ + if (ModeNumber == Bda->VideoMode) + { + /* Just clear the VGA memory if needed */ + if (!DoNotClear) VgaClearMemory(); + return TRUE; + } VgaMode = VideoModes[ModeNumber]; @@ -2320,12 +2332,7 @@ VgaChangePalette(ModeNumber); - /* - * IBM standard modes do not clear the screen if the - * high bit of AL is set (EGA or higher only). - * See Ralf Brown: http://www.ctyme.com/intr/rb-0069.htm - * for more information. - */ + /* Clear the VGA memory if needed */ if (!DoNotClear) VgaClearMemory(); // Bda->CrtModeControl;

1 0

[akhaldi] 65017: [ADVAPI32] * Update GetAce(). CORE-8540
by akhaldi＠svn.reactos.org 26 Oct '14

26 Oct '14

Author: akhaldi Date: Sun Oct 26 16:48:36 2014 New Revision: 65017 URL: http://svn.reactos.org/svn/reactos?rev=65017&view=rev Log: [ADVAPI32] * Update GetAce(). CORE-8540 Modified: trunk/reactos/dll/win32/advapi32/wine/security.c Modified: trunk/reactos/dll/win32/advapi32/wine/security.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/wine/se… ============================================================================== --- trunk/reactos/dll/win32/advapi32/wine/security.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/wine/security.c [iso-8859-1] Sun Oct 26 16:48:36 2014 @@ -1092,28 +1092,12 @@ (PACE*)pAce); } - -/* - * @implemented - */ -BOOL -WINAPI -GetAce(PACL pAcl, - DWORD dwAceIndex, - LPVOID *pAce) -{ - NTSTATUS Status; - - Status = RtlGetAce(pAcl, - dwAceIndex, - pAce); - if (!NT_SUCCESS(Status)) - { - SetLastError(RtlNtStatusToDosError(Status)); - return FALSE; - } - - return TRUE; +/****************************************************************************** + * GetAce [ADVAPI32.@] + */ +BOOL WINAPI GetAce(PACL pAcl,DWORD dwAceIndex,LPVOID *pAce ) +{ + return set_ntstatus(RtlGetAce(pAcl, dwAceIndex, pAce)); } /*

1 0

[akhaldi] 65016: [ADVAPI32] * Update DeleteAce(). CORE-8540
by akhaldi＠svn.reactos.org 26 Oct '14

26 Oct '14

Author: akhaldi Date: Sun Oct 26 15:59:57 2014 New Revision: 65016 URL: http://svn.reactos.org/svn/reactos?rev=65016&view=rev Log: [ADVAPI32] * Update DeleteAce(). CORE-8540 Modified: trunk/reactos/dll/win32/advapi32/wine/security.c Modified: trunk/reactos/dll/win32/advapi32/wine/security.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/wine/se… ============================================================================== --- trunk/reactos/dll/win32/advapi32/wine/security.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/wine/security.c [iso-8859-1] Sun Oct 26 15:59:57 2014 @@ -1072,25 +1072,12 @@ return TRUE; } -/* - * @implemented - */ -BOOL -WINAPI -DeleteAce(PACL pAcl, - DWORD dwAceIndex) -{ - NTSTATUS Status; - - Status = RtlDeleteAce(pAcl, - dwAceIndex); - if (!NT_SUCCESS(Status)) - { - SetLastError(RtlNtStatusToDosError(Status)); - return FALSE; - } - - return TRUE; +/****************************************************************************** + * DeleteAce [ADVAPI32.@] + */ +BOOL WINAPI DeleteAce(PACL pAcl, DWORD dwAceIndex) +{ + return set_ntstatus(RtlDeleteAce(pAcl, dwAceIndex)); } /*

1 0

[hbelusca] 65015: [NTVDM]: No need to re-change to a given video mode when it is already set. Fixes strange changes for e.g. some apps that find intelligent to switch 256 times to mode 13h (for exa...
by hbelusca＠svn.reactos.org 26 Oct '14

26 Oct '14

Author: hbelusca Date: Sun Oct 26 15:57:21 2014 New Revision: 65015 URL: http://svn.reactos.org/svn/reactos?rev=65015&view=rev Log: [NTVDM]: No need to re-change to a given video mode when it is already set. Fixes strange changes for e.g. some apps that find intelligent to switch 256 times to mode 13h (for example) before continuing to run. Modified: trunk/reactos/subsystems/ntvdm/bios/vidbios.c Modified: trunk/reactos/subsystems/ntvdm/bios/vidbios.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/ntvdm/bios/vidb… ============================================================================== --- trunk/reactos/subsystems/ntvdm/bios/vidbios.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/ntvdm/bios/vidbios.c [iso-8859-1] Sun Oct 26 15:57:21 2014 @@ -2308,6 +2308,9 @@ return FALSE; } + /* Check if this is the same mode */ + if (ModeNumber == Bda->VideoMode) return TRUE; + VgaMode = VideoModes[ModeNumber]; DPRINT1("Switching to mode %02Xh %s clearing the screen; VgaMode = 0x%p\n",

1 0

[pschweitzer] 65014: [FASTFAT] Make FATGetNextDirEntry() and vfatFindDirSpace() complain when they are given a cleaned up FCB (which shouldn't happen!). They'll display full path, references count, ...
by pschweitzer＠svn.reactos.org 26 Oct '14

26 Oct '14

Author: pschweitzer Date: Sun Oct 26 15:56:20 2014 New Revision: 65014 URL: http://svn.reactos.org/svn/reactos?rev=65014&view=rev Log: [FASTFAT] Make FATGetNextDirEntry() and vfatFindDirSpace() complain when they are given a cleaned up FCB (which shouldn't happen!). They'll display full path, references count, open handles count. Where are you little reference leak? Modified: trunk/reactos/drivers/filesystems/fastfat/direntry.c trunk/reactos/drivers/filesystems/fastfat/dirwr.c Modified: trunk/reactos/drivers/filesystems/fastfat/direntry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/direntry.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/direntry.c [iso-8859-1] Sun Oct 26 15:56:20 2014 @@ -201,6 +201,12 @@ CcUnpinData(*pContext); } + if (!pDirFcb->FileObject) + { + DPRINT1("Buggy FCB (cleaned up)! %S (%d / %u)\n", pDirFcb->PathNameBuffer, pDirFcb->RefCount, pDirFcb->OpenHandleCount); + return STATUS_NO_MORE_ENTRIES; + } + if (FileOffset.u.LowPart >= pDirFcb->RFCB.FileSize.u.LowPart || !CcMapData(pDirFcb->FileObject, &FileOffset, PAGE_SIZE, TRUE, pContext, pPage)) { Modified: trunk/reactos/drivers/filesystems/fastfat/dirwr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/dirwr.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/dirwr.c [iso-8859-1] Sun Oct 26 15:56:20 2014 @@ -166,6 +166,11 @@ if (Context) { CcUnpinData(Context); + } + if (!pDirFcb->FileObject) + { + DPRINT1("Buggy FCB (cleaned up)! %S (%d / %u)\n", pDirFcb->PathNameBuffer, pDirFcb->RefCount, pDirFcb->OpenHandleCount); + return FALSE; } if (!CcPinRead(pDirFcb->FileObject, &FileOffset, DeviceExt->FatInfo.BytesPerCluster, TRUE, &Context, (PVOID*)&pFatEntry))

1 0

[pschweitzer] 65013: [FASTFAT] Don't leak reference on failure in vfatPrepareTargetForRename().
by pschweitzer＠svn.reactos.org 26 Oct '14

26 Oct '14

Author: pschweitzer Date: Sun Oct 26 15:35:18 2014 New Revision: 65013 URL: http://svn.reactos.org/svn/reactos?rev=65013&view=rev Log: [FASTFAT] Don't leak reference on failure in vfatPrepareTargetForRename(). Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] Sun Oct 26 15:35:18 2014 @@ -400,6 +400,7 @@ /* If that's a directory or a read-only file, we're not allowed */ if (vfatFCBIsDirectory(TargetFcb) || ((*TargetFcb->Attributes & FILE_ATTRIBUTE_READONLY) == FILE_ATTRIBUTE_READONLY)); { + vfatReleaseFCB(DeviceExt, *ParentFCB); *ParentFCB = NULL; vfatReleaseFCB(DeviceExt, TargetFcb); return STATUS_OBJECT_NAME_COLLISION; @@ -408,6 +409,7 @@ /* Attempt to flush (might close the file) */ if (!MmFlushImageSection(TargetFcb->FileObject->SectionObjectPointer, MmFlushForDelete)) { + vfatReleaseFCB(DeviceExt, *ParentFCB); *ParentFCB = NULL; vfatReleaseFCB(DeviceExt, TargetFcb); return STATUS_ACCESS_DENIED; @@ -416,6 +418,7 @@ /* If we are, ensure the file isn't open by anyone! */ if (TargetFcb->OpenHandleCount != 0) { + vfatReleaseFCB(DeviceExt, *ParentFCB); *ParentFCB = NULL; vfatReleaseFCB(DeviceExt, TargetFcb); return STATUS_ACCESS_DENIED; @@ -429,6 +432,7 @@ } else { + vfatReleaseFCB(DeviceExt, *ParentFCB); *ParentFCB = NULL; vfatReleaseFCB(DeviceExt, TargetFcb); return STATUS_OBJECT_NAME_COLLISION;

1 0

← Newer
1
...
12
13
14
15
16
17
18
...
73
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs October 2014