Author: hbelusca
Date: Fri Feb 28 23:55:40 2014
New Revision: 62362
URL: http://svn.reactos.org/svn/reactos?rev=62362&view=rev
Log:
[CMD][HELP]
Fix the IsConsoleHandle helper.
Modified:
trunk/reactos/base/applications/cmdutils/help/help.c
trunk/reactos/base/shell/cmd/console.c
Modified: trunk/reactos/base/applications/cmdutils/help/help.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/cmdutils…
==============================================================================
--- trunk/reactos/base/applications/cmdutils/help/help.c [iso-8859-1] (original)
+++ trunk/reactos/base/applications/cmdutils/help/help.c [iso-8859-1] Fri Feb 28 23:55:40 2014
@@ -25,7 +25,8 @@
DWORD dwMode;
/* Check whether the handle may be that of a console... */
- if ((GetFileType(hHandle) & FILE_TYPE_CHAR) == 0) return FALSE;
+ if ((GetFileType(hHandle) & ~FILE_TYPE_REMOTE) != FILE_TYPE_CHAR)
+ return FALSE;
/*
* It may be. Perform another test... The idea comes from the
Modified: trunk/reactos/base/shell/cmd/console.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/console.c?r…
==============================================================================
--- trunk/reactos/base/shell/cmd/console.c [iso-8859-1] (original)
+++ trunk/reactos/base/shell/cmd/console.c [iso-8859-1] Fri Feb 28 23:55:40 2014
@@ -31,7 +31,8 @@
DWORD dwMode;
/* Check whether the handle may be that of a console... */
- if ((GetFileType(hHandle) & FILE_TYPE_CHAR) == 0) return FALSE;
+ if ((GetFileType(hHandle) & ~FILE_TYPE_REMOTE) != FILE_TYPE_CHAR)
+ return FALSE;
/*
* It may be. Perform another test... The idea comes from the
Author: hbelusca
Date: Fri Feb 28 23:34:32 2014
New Revision: 62361
URL: http://svn.reactos.org/svn/reactos?rev=62361&view=rev
Log:
[CMAKE]
Make MSVC warning C4020 "Too many actual parameters" an error
CORE-7960 #resolve #comment Committed in revision 62361.
Modified:
trunk/reactos/cmake/msvc.cmake
Modified: trunk/reactos/cmake/msvc.cmake
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/msvc.cmake?rev=62361…
==============================================================================
--- trunk/reactos/cmake/msvc.cmake [iso-8859-1] (original)
+++ trunk/reactos/cmake/msvc.cmake [iso-8859-1] Fri Feb 28 23:34:32 2014
@@ -43,6 +43,7 @@
# The following warnings are treated as errors:
# - C4013: implicit function declaration
+# - C4020: too many actual parameters
# - C4022: pointer type mismatch for parameter
# - TODO: C4028: formal parameter different from declaration
# - C4047: different level of indirection
@@ -55,7 +56,7 @@
# - C4229: modifiers on data are ignored
# - C4700: uninitialized variable usage
# - C4603: macro is not defined or definition is different after precompiled header use
-add_compile_flags("/we4013 /we4022 /we4047 /we4098 /we4113 /we4129 /we4229 /we4700 /we4603")
+add_compile_flags("/we4013 /we4020 /we4022 /we4047 /we4098 /we4113 /we4129 /we4229 /we4700 /we4603")
# Enable warnings above the default level, but don't treat them as errors:
# - C4115: named type definition in parentheses