Ros-diffs March 2014

ros-diffs@reactos.org

14 participants
233 discussions

[hbelusca] 62595: Resurrect MSVC 2008 builds. ACHTUNG! ACHTUNG! Even if you can build ROS with MSVC 2008, you cannot boot it (see the below-mentioned JIRA report) ACHTUNG! ACHTUNG! CORE-8023 #comme...

by hbelusca＠svn.reactos.org

Author: hbelusca Date: Mon Mar 31 20:59:32 2014 New Revision: 62595 URL: http://svn.reactos.org/svn/reactos?rev=62595&view=rev Log: Resurrect MSVC 2008 builds. ACHTUNG! ACHTUNG! Even if you can build ROS with MSVC 2008, you cannot boot it (see the below-mentioned JIRA report) ACHTUNG! ACHTUNG! CORE-8023 #comment MSVC 2008 build resurrected in revision 62595. Modified: trunk/reactos/configure.cmd Modified: trunk/reactos/configure.cmd URL: http://svn.reactos.org/svn/reactos/trunk/reactos/configure.cmd?rev=62595&r1… ============================================================================== --- trunk/reactos/configure.cmd [iso-8859-1] (original) +++ trunk/reactos/configure.cmd [iso-8859-1] Mon Mar 31 20:59:32 2014 @@ -49,6 +49,7 @@ cl 2>&1 | find "x86" > NUL && set ARCH=i386 cl 2>&1 | find "x64" > NUL && set ARCH=amd64 cl 2>&1 | find "ARM" > NUL && set ARCH=arm + cl 2>&1 | find "15.00." > NUL && set BUILD_ENVIRONMENT=VS9 cl 2>&1 | find "16.00." > NUL && set BUILD_ENVIRONMENT=VS10 cl 2>&1 | find "17.00." > NUL && set BUILD_ENVIRONMENT=VS11 cl 2>&1 | find "18.00." > NUL && set BUILD_ENVIRONMENT=VS12 @@ -59,7 +60,13 @@ echo Detected Visual Studio Environment !BUILD_ENVIRONMENT!-!ARCH! if /I "%1" == "VSSolution" ( - if "!BUILD_ENVIRONMENT!" == "VS10" ( + if "!BUILD_ENVIRONMENT!" == "VS9" ( + if "!ARCH!" == "amd64" ( + set CMAKE_GENERATOR="Visual Studio 9 2008 Win64" + ) else ( + set CMAKE_GENERATOR="Visual Studio 9 2008" + ) + ) else if "!BUILD_ENVIRONMENT!" == "VS10" ( if "!ARCH!" == "amd64" ( set CMAKE_GENERATOR="Visual Studio 10 Win64" ) else (

10 years, 8 months

[hbelusca] 62594: [HOST-TOOLS] For host-tools, including stdint.h when using MSVC is not reliable, so use a tried-&-tested solution (see mkshelllink & geninf tools): include stdint.h if we don't us...

by hbelusca＠svn.reactos.org

Author: hbelusca Date: Mon Mar 31 20:38:05 2014 New Revision: 62594 URL: http://svn.reactos.org/svn/reactos?rev=62594&view=rev Log: [HOST-TOOLS] For host-tools, including stdint.h when using MSVC is not reliable, so use a tried-&-tested solution (see mkshelllink & geninf tools): include stdint.h if we don't use MSVC, otherwise define just what's needed. Another solution would be to create a include/host/stdint.h which does this same job, and in the host-tools, include this file. CORE-8023 Modified: trunk/reactos/include/host/typedefs.h trunk/reactos/tools/mkshelllink/mkshelllink.c Modified: trunk/reactos/include/host/typedefs.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/host/typedefs.h?re… ============================================================================== --- trunk/reactos/include/host/typedefs.h [iso-8859-1] (original) +++ trunk/reactos/include/host/typedefs.h [iso-8859-1] Mon Mar 31 20:38:05 2014 @@ -13,7 +13,20 @@ #include <assert.h> #include <stdlib.h> #include <limits.h> + +#ifndef _MSC_VER #include <stdint.h> +#else +typedef __int8 int8_t; +typedef __int16 int16_t; +typedef __int32 int32_t; +typedef __int64 int64_t; + +typedef unsigned __int8 uint8_t; +typedef unsigned __int16 uint16_t; +typedef unsigned __int32 uint32_t; +typedef unsigned __int64 uint64_t; +#endif /* Function attributes for GCC */ #if !defined(_MSC_VER) && !defined(__fastcall) Modified: trunk/reactos/tools/mkshelllink/mkshelllink.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkshelllink/mkshelll… ============================================================================== --- trunk/reactos/tools/mkshelllink/mkshelllink.c [iso-8859-1] (original) +++ trunk/reactos/tools/mkshelllink/mkshelllink.c [iso-8859-1] Mon Mar 31 20:38:05 2014 @@ -9,10 +9,11 @@ #include <stdlib.h> #include <string.h> #include <ctype.h> + #ifndef _MSC_VER #include <stdint.h> #else -typedef unsigned __int8 uint8_t; +typedef unsigned __int8 uint8_t; typedef unsigned __int16 uint16_t; typedef unsigned __int32 uint32_t; #endif

10 years, 8 months

[tfaber] 62593: [ADVAPI32] - Fix buffer handling in CredMarshalCredential/CredUnmarshalCredential. Fixes stack corruption during advapi32:cred CORE-7242 #resolve

by tfaber＠svn.reactos.org

Author: tfaber Date: Mon Mar 31 20:11:32 2014 New Revision: 62593 URL: http://svn.reactos.org/svn/reactos?rev=62593&view=rev Log: [ADVAPI32] - Fix buffer handling in CredMarshalCredential/CredUnmarshalCredential. Fixes stack corruption during advapi32:cred CORE-7242 #resolve Modified: trunk/reactos/dll/win32/advapi32/sec/cred.c Modified: trunk/reactos/dll/win32/advapi32/sec/cred.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/advapi32/sec/cre… ============================================================================== --- trunk/reactos/dll/win32/advapi32/sec/cred.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/advapi32/sec/cred.c [iso-8859-1] Mon Mar 31 20:11:32 2014 @@ -2008,18 +2008,13 @@ { case CertCredential: { - char hash[CERT_HASH_LENGTH + 2]; - - memcpy( hash, cert->rgbHashOfCert, sizeof(cert->rgbHashOfCert) ); - memset( hash + sizeof(cert->rgbHashOfCert), 0, sizeof(hash) - sizeof(cert->rgbHashOfCert) ); - - size = sizeof(hash) * 4 / 3; + size = (sizeof(cert->rgbHashOfCert) + 2) * 4 / 3; if (!(p = HeapAlloc( GetProcessHeap(), 0, (size + 4) * sizeof(WCHAR) ))) return FALSE; p[0] = '@'; p[1] = '@'; p[2] = 'A' + type; - len = cred_encode( (const char *)hash, sizeof(hash), p + 3 ); - p[len] = 0; + len = cred_encode( (const char *)cert->rgbHashOfCert, sizeof(cert->rgbHashOfCert), p + 3 ); + p[len + 3] = 0; break; } case UsernameTargetCredential: @@ -2105,7 +2100,6 @@ buf[i + 0] = (c1 << 6) | c0; buf[i + 1] = (c2 << 4) | (c1 >> 2); - buf[i + 2] = c2 >> 4; } else if (len == 2) { @@ -2113,16 +2107,10 @@ if ((c1 = char_decode( p[1] )) > 63) return FALSE; buf[i + 0] = (c1 << 6) | c0; - buf[i + 1] = c1 >> 2; - buf[i + 2] = 0; } else if (len == 1) { - if ((c0 = char_decode( p[0] )) > 63) return FALSE; - - buf[i + 0] = c0; - buf[i + 1] = 0; - buf[i + 2] = 0; + return FALSE; } return TRUE; } @@ -2136,17 +2124,19 @@ TRACE("%s, %p, %p\n", debugstr_w(cred), type, out); - if (!cred || cred[0] != '@' || cred[1] != '@' || !cred[2] || !cred[3]) + if (!cred || cred[0] != '@' || cred[1] != '@' || + char_decode( cred[2] ) > 63) { SetLastError( ERROR_INVALID_PARAMETER ); return FALSE; } len = strlenW( cred + 3 ); - switch (cred[2] - 'A') + *type = char_decode( cred[2] ); + switch (*type) { case CertCredential: { - char hash[CERT_HASH_LENGTH + 2]; + char hash[CERT_HASH_LENGTH]; CERT_CREDENTIAL_INFO *cert; if (len != 27 || !cred_decode( cred + 3, len, hash )) @@ -2157,17 +2147,16 @@ if (!(cert = HeapAlloc( GetProcessHeap(), 0, sizeof(*cert) ))) return FALSE; memcpy( cert->rgbHashOfCert, hash, sizeof(cert->rgbHashOfCert) ); cert->cbSize = sizeof(*cert); - *type = CertCredential; *out = cert; break; } case UsernameTargetCredential: { USERNAME_TARGET_CREDENTIAL_INFO *target; - ULONGLONG size = 0; + DWORD size; if (len < 9 || !cred_decode( cred + 3, 6, (char *)&size ) || - !size || size % sizeof(WCHAR) || size > INT_MAX) + size % sizeof(WCHAR) || len - 6 != (size * 4 + 2) / 3) { SetLastError( ERROR_INVALID_PARAMETER ); return FALSE; @@ -2181,7 +2170,6 @@ } target->UserName = (WCHAR *)(target + 1); target->UserName[size / sizeof(WCHAR)] = 0; - *type = UsernameTargetCredential; *out = target; break; } @@ -2189,7 +2177,8 @@ FIXME("BinaryBlobCredential not implemented\n"); return FALSE; default: - WARN("unhandled type %u\n", cred[2] - 'A'); + WARN("unhandled type %u\n", *type); + SetLastError( ERROR_INVALID_PARAMETER ); return FALSE; } return TRUE; @@ -2213,7 +2202,7 @@ if (name && name[0] == '@' && name[1] == '@' && name[2] > 'A' && name[3]) { - char hash[CERT_HASH_LENGTH + 2]; + char hash[CERT_HASH_LENGTH]; int len = strlenW(name + 3 ); DWORD size;

10 years, 8 months

[hbelusca] 62592: [CMLIB][MKHIVE] Move some defines where they belong (they are used in mkhive because they are employed in cmlib functions, and cmlib itself uses them too).

by hbelusca＠svn.reactos.org

Author: hbelusca Date: Mon Mar 31 20:05:44 2014 New Revision: 62592 URL: http://svn.reactos.org/svn/reactos?rev=62592&view=rev Log: [CMLIB][MKHIVE] Move some defines where they belong (they are used in mkhive because they are employed in cmlib functions, and cmlib itself uses them too). Modified: trunk/reactos/lib/cmlib/cmlib.h trunk/reactos/tools/mkhive/mkhive.h Modified: trunk/reactos/lib/cmlib/cmlib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmlib.h?rev=6259… ============================================================================== --- trunk/reactos/lib/cmlib/cmlib.h [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/cmlib.h [iso-8859-1] Mon Mar 31 20:05:44 2014 @@ -27,11 +27,19 @@ #define _In_ #define _Out_ #define _Inout_ + #define _In_opt_ + #define _In_range_(x, y) #endif + + #define __drv_aliasesMem #ifndef min #define min(a, b) (((a) < (b)) ? (a) : (b)) #endif + + // #ifndef max + // #define max(a, b) (((a) > (b)) ? (a) : (b)) + // #endif // Definitions copied from <ntstatus.h> // We only want to include host headers, so we define them manually Modified: trunk/reactos/tools/mkhive/mkhive.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/mkhive.h?rev=… ============================================================================== --- trunk/reactos/tools/mkhive/mkhive.h [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/mkhive.h [iso-8859-1] Mon Mar 31 20:05:44 2014 @@ -122,21 +122,4 @@ extern LIST_ENTRY CmiHiveListHead; #define ABS_VALUE(V) (((V) < 0) ? -(V) : (V)) -#ifndef max -#define max(a, b) (((a) > (b)) ? (a) : (b)) -#endif - -#ifndef min -#define min(a, b) (((a) < (b)) ? (a) : (b)) -#endif - -#if (!defined(_MSC_VER) || (_MSC_VER < 1500)) -#define _In_ -#define _Out_ -#define _In_opt_ -#define _In_range_(x, y) -#endif - -#define __drv_aliasesMem - /* EOF */

10 years, 8 months

[tfaber] 62591: [RTL] - Fix buffer overrun in RtlNumberOfSetBits

by tfaber＠svn.reactos.org

Author: tfaber Date: Mon Mar 31 19:57:42 2014 New Revision: 62591 URL: http://svn.reactos.org/svn/reactos?rev=62591&view=rev Log: [RTL] - Fix buffer overrun in RtlNumberOfSetBits Modified: trunk/reactos/lib/rtl/bitmap.c Modified: trunk/reactos/lib/rtl/bitmap.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/rtl/bitmap.c?rev=62591… ============================================================================== --- trunk/reactos/lib/rtl/bitmap.c [iso-8859-1] (original) +++ trunk/reactos/lib/rtl/bitmap.c [iso-8859-1] Mon Mar 31 19:57:42 2014 @@ -467,8 +467,11 @@ BitCount += BitCountTable[*Byte++]; } - Shift = 8 - (BitMapHeader->SizeOfBitMap & 7); - BitCount += BitCountTable[((*Byte) << Shift) & 0xFF]; + if (BitMapHeader->SizeOfBitMap & 7) + { + Shift = 8 - (BitMapHeader->SizeOfBitMap & 7); + BitCount += BitCountTable[((*Byte) << Shift) & 0xFF]; + } return BitCount; }

10 years, 8 months

[tfaber] 62590: [NTOS:KE] - Verify valid IRQL in KeDelayExecutionThread, just like in KeWait* - Return from KeDelayExecutionThread after yielding execution

by tfaber＠svn.reactos.org

Author: tfaber Date: Sun Mar 30 21:10:04 2014 New Revision: 62590 URL: http://svn.reactos.org/svn/reactos?rev=62590&view=rev Log: [NTOS:KE] - Verify valid IRQL in KeDelayExecutionThread, just like in KeWait* - Return from KeDelayExecutionThread after yielding execution Modified: trunk/reactos/ntoskrnl/ke/wait.c Modified: trunk/reactos/ntoskrnl/ke/wait.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ke/wait.c?rev=625… ============================================================================== --- trunk/reactos/ntoskrnl/ke/wait.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ke/wait.c [iso-8859-1] Sun Mar 30 21:10:04 2014 @@ -285,6 +285,11 @@ LARGE_INTEGER DueTime, NewDueTime, InterruptTime; ULONG Hand = 0; + if (Thread->WaitNext) + ASSERT(KeGetCurrentIrql() == DISPATCH_LEVEL); + else + ASSERT(KeGetCurrentIrql() <= APC_LEVEL); + /* If this is a user-mode wait of 0 seconds, yield execution */ if (!(Interval->QuadPart) && (WaitMode != KernelMode)) { @@ -292,7 +297,7 @@ if (!(Alertable) && !(Thread->ApcState.UserApcPending)) { /* Yield execution */ - NtYieldExecution(); + return NtYieldExecution(); } }

10 years, 8 months

[pschweitzer] 62589: [TUNNELTEST] Reshuffle the test a bit so that it clearly fails on ReactOS: - Gather creation timestamp right after the first creation and always compare to it. This is to worka...

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sun Mar 30 18:25:13 2014 New Revision: 62589 URL: http://svn.reactos.org/svn/reactos?rev=62589&view=rev Log: [TUNNELTEST] Reshuffle the test a bit so that it clearly fails on ReactOS: - Gather creation timestamp right after the first creation and always compare to it. This is to workaround the move = copy + delete hack from ReactOS which is resetting the timestamps (and thus making the test pass ;-)). - Wait more than 20ms (1s). If Microsoft FastFAT has a creation resolution of 10ms, we don't. So it would hide the thing as well. With such changes, the test still works on Windows, whereas it fails on ReactOS CORE-7272 Modified: trunk/rostests/win32/fs/tunneltest/tunneltest.c Modified: trunk/rostests/win32/fs/tunneltest/tunneltest.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/win32/fs/tunneltest/tunne… ============================================================================== --- trunk/rostests/win32/fs/tunneltest/tunneltest.c [iso-8859-1] (original) +++ trunk/rostests/win32/fs/tunneltest/tunneltest.c [iso-8859-1] Sun Mar 30 18:25:13 2014 @@ -75,10 +75,21 @@ fprintf(stderr, "Failed to create file1\n"); return GetLastError(); } + + /* Get its creation timestamp. It will be our reference */ + /* Get it in FileTime because file1 will renamed to file */ + if (GetFileTime(hFile, &FileTime, NULL, NULL) == FALSE) + { + fprintf(stderr, "Failed to read creation time\n"); + CloseHandle(hFile); + return GetLastError(); + } + CloseHandle(hFile); /* Wait a least 10ms (resolution of FAT) */ - Sleep(10 * 2); + /* XXX: Increased to 1s for ReactOS... */ + Sleep(1000); /* Create second file */ /* Remove old file from buffer */ @@ -114,24 +125,6 @@ return GetLastError(); } - /* Time to compare creation time of both file & file1 */ - CopyPath[wcslen(TempPath) - 1] = 0; - - /* Open file and get its creation time */ - hFile = CreateFileW(CopyPath, GENERIC_READ, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL); - if (hFile == INVALID_HANDLE_VALUE) - { - fprintf(stderr, "Failed to open file\n"); - return GetLastError(); - } - if (GetFileTime(hFile, &FileTime, NULL, NULL) == FALSE) - { - fprintf(stderr, "Failed to read creation time\n"); - CloseHandle(hFile); - return GetLastError(); - } - CloseHandle(hFile); - /* Open file1 and get its creation time */ hFile = CreateFileW(TempPath, GENERIC_READ, 0, NULL, OPEN_EXISTING, FILE_ATTRIBUTE_NORMAL, NULL); if (hFile == INVALID_HANDLE_VALUE) @@ -147,7 +140,8 @@ } CloseHandle(hFile); - /* Delete file */ + /* Delete files */ + CopyPath[wcslen(TempPath) - 1] = 0; DeleteFileW(TempPath); DeleteFileW(CopyPath);

10 years, 8 months

[tkreuzer] 62588: [W32KDLL] Use new macro based syscall mechanism for w32kdll_xpsp2. Fix exports

by tkreuzer＠svn.reactos.org

Author: tkreuzer Date: Sun Mar 30 17:34:56 2014 New Revision: 62588 URL: http://svn.reactos.org/svn/reactos?rev=62588&view=rev Log: [W32KDLL] Use new macro based syscall mechanism for w32kdll_xpsp2. Fix exports Added: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/sys-stubs.S (with props) trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/win32ksvc-xp.h (with props) Removed: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/w32k_xpsp2-x86.db trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/w32kdll_xpsp2.S trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/w32kdll_xpsp2.def Modified: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/CMakeLists.txt trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/w32kdll_xpsp2.spec [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_… Added: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/sys-stubs.S URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_… Removed: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/w32k_xpsp2-x86.db URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_… Removed: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/w32kdll_xpsp2.S URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_… Removed: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/w32kdll_xpsp2.def URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_… Modified: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/w32kdll_xpsp2.spec URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_… Added: trunk/rostests/apitests/w32kdll/w32kdll_xpsp2/win32ksvc-xp.h URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/w32kdll/w32kdll_…

10 years, 8 months

[tfaber] 62587: [CRT] - Use PeekConsoleInput in kbhit because the input buffer should not be affected. Patch by Roy Tam CORE-8030 #resolve

by tfaber＠svn.reactos.org

Author: tfaber Date: Sun Mar 30 15:46:02 2014 New Revision: 62587 URL: http://svn.reactos.org/svn/reactos?rev=62587&view=rev Log: [CRT] - Use PeekConsoleInput in kbhit because the input buffer should not be affected. Patch by Roy Tam CORE-8030 #resolve Modified: trunk/reactos/lib/sdk/crt/conio/kbhit.c Modified: trunk/reactos/lib/sdk/crt/conio/kbhit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/conio/kbhit.c?… ============================================================================== --- trunk/reactos/lib/sdk/crt/conio/kbhit.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/conio/kbhit.c [iso-8859-1] Sun Mar 30 15:46:02 2014 @@ -15,8 +15,6 @@ volatile BOOL CriticalSectionInitialized=FALSE; /* - * FIXME Initial keyboard char not detected on first punch - * * @implemented */ @@ -71,7 +69,7 @@ return 0; } - if (!ReadConsoleInput(StdInputHandle, InputRecord, EventsRead, &NumberRead)) + if (!PeekConsoleInput(StdInputHandle, InputRecord, EventsRead, &NumberRead)) { free(InputRecord); LeaveCriticalSection(&CriticalSection);

10 years, 8 months

[tfaber] 62586: [VIDEOPRT] - Add missing newlines to debug prints

by tfaber＠svn.reactos.org

Author: tfaber Date: Sun Mar 30 09:53:29 2014 New Revision: 62586 URL: http://svn.reactos.org/svn/reactos?rev=62586&view=rev Log: [VIDEOPRT] - Add missing newlines to debug prints Modified: trunk/reactos/win32ss/drivers/videoprt/dispatch.c trunk/reactos/win32ss/drivers/videoprt/registry.c Modified: trunk/reactos/win32ss/drivers/videoprt/dispatch.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/videoprt/d… ============================================================================== --- trunk/reactos/win32ss/drivers/videoprt/dispatch.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/drivers/videoprt/dispatch.c [iso-8859-1] Sun Mar 30 09:53:29 2014 @@ -327,7 +327,7 @@ } else { - ERR_(VIDEOPRT, "Requested to set session, but session is already set to: 0x%lx", + ERR_(VIDEOPRT, "Requested to set session, but session is already set to: 0x%lx\n", DeviceExtension->SessionId); SessionState->bSuccess = FALSE; } Modified: trunk/reactos/win32ss/drivers/videoprt/registry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/videoprt/r… ============================================================================== --- trunk/reactos/win32ss/drivers/videoprt/registry.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/drivers/videoprt/registry.c [iso-8859-1] Sun Mar 30 09:53:29 2014 @@ -309,7 +309,7 @@ &DevInstRegKey); if (Status != STATUS_SUCCESS) { - ERR_(VIDEOPRT, "Failed to open device software key. Status 0x%lx", Status); + ERR_(VIDEOPRT, "Failed to open device software key. Status 0x%lx\n", Status); return Status; } @@ -326,7 +326,7 @@ if (Status != STATUS_SUCCESS) { - ERR_(VIDEOPRT, "Failed to open settings key. Status 0x%lx", Status); + ERR_(VIDEOPRT, "Failed to open settings key. Status 0x%lx\n", Status); return Status; } @@ -339,7 +339,7 @@ Status = ZwOpenKey(&SourceKeyHandle, KEY_WRITE, &ObjectAttributes); if (Status != STATUS_SUCCESS) { - ERR_(VIDEOPRT, "ZwOpenKey failed for settings key: status 0x%lx", Status); + ERR_(VIDEOPRT, "ZwOpenKey failed for settings key: status 0x%lx\n", Status); ObCloseHandle(DestKeyHandle, KernelMode); return Status; } @@ -615,7 +615,7 @@ } else { - WARN_(VIDEOPRT, "Unparsable registry path %wZ", DriverRegistryPath); + WARN_(VIDEOPRT, "Unparsable registry path %wZ\n", DriverRegistryPath); } /* If path doesn't point to *ControlSet*, use DriverRegistryPath directly */

10 years, 8 months

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs March 2014