ReactOS.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
List overview
Download
Ros-diffs
April 2014
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
ros-diffs@reactos.org
15 participants
492 discussions
Start a n
N
ew thread
[khornicek] 62677: [MSCONFIG] - fix possible leaks CID #716286 CID #716287
by khornicek@svn.reactos.org
Author: khornicek Date: Sun Apr 6 21:13:18 2014 New Revision: 62677 URL:
http://svn.reactos.org/svn/reactos?rev=62677&view=rev
Log: [MSCONFIG] - fix possible leaks CID #716286 CID #716287 Modified: trunk/reactos/base/applications/msconfig/srvpage.c trunk/reactos/base/applications/msconfig/startuppage.c Modified: trunk/reactos/base/applications/msconfig/srvpage.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/msconfig…
============================================================================== --- trunk/reactos/base/applications/msconfig/srvpage.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/msconfig/srvpage.c [iso-8859-1] Sun Apr 6 21:13:18 2014 @@ -109,17 +109,22 @@ /* reserve memory for service info array */ pServiceStatus = HeapAlloc(GetProcessHeap(), 0, BytesNeeded); if (!pServiceStatus) + { + CloseServiceHandle(ScHandle); return; + } /* fill array with service info */ if (EnumServicesStatusEx(ScHandle, SC_ENUM_PROCESS_INFO, SERVICE_WIN32, SERVICE_STATE_ALL, (LPBYTE)pServiceStatus, BytesNeeded, &BytesNeeded, &NumServices, &ResumeHandle, 0) == 0) { HeapFree(GetProcessHeap(), 0, pServiceStatus); + CloseServiceHandle(ScHandle); return; } } else /* exit on failure */ { + CloseServiceHandle(ScHandle); return; } } @@ -127,7 +132,11 @@ if (NumServices) { if (!pServiceStatus) + { + CloseServiceHandle(ScHandle); return; + } + for (Index = 0; Index < NumServices; Index++) { memset(&item, 0, sizeof(LV_ITEM)); Modified: trunk/reactos/base/applications/msconfig/startuppage.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/msconfig…
============================================================================== --- trunk/reactos/base/applications/msconfig/startuppage.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/msconfig/startuppage.c [iso-8859-1] Sun Apr 6 21:13:18 2014 @@ -137,7 +137,7 @@ HeapFree(GetProcessHeap(), 0, Data); } } - RegCloseKey(hKey); + RegCloseKey(hKey); } } @@ -199,8 +199,8 @@ item.pszText = Path; item.iSubItem = 2; SendMessage(hStartupListCtrl, LVM_SETITEMTEXT, item.iItem, (LPARAM) &item); - HeapFree(GetProcessHeap(), 0, Data); } + HeapFree(GetProcessHeap(), 0, Data); } } RegCloseKey(hKey);
10 years, 8 months
1
0
0
0
[pschweitzer] 62676: [CDFS] - Fix CdfsWSubString() prototype - Use it in CdfsCreateFCB() for string copy CID #511047
by pschweitzer@svn.reactos.org
Author: pschweitzer Date: Sun Apr 6 21:02:21 2014 New Revision: 62676 URL:
http://svn.reactos.org/svn/reactos?rev=62676&view=rev
Log: [CDFS] - Fix CdfsWSubString() prototype - Use it in CdfsCreateFCB() for string copy CID #511047 Modified: trunk/reactos/drivers/filesystems/cdfs/fcb.c Modified: trunk/reactos/drivers/filesystems/cdfs/fcb.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/cdfs/f…
============================================================================== --- trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/cdfs/fcb.c [iso-8859-1] Sun Apr 6 21:02:21 2014 @@ -57,7 +57,7 @@ static VOID -CdfsWSubString(PWCHAR pTarget, const PWCHAR pSource, size_t pLength) +CdfsWSubString(LPWSTR pTarget, LPCWSTR pSource, size_t pLength) { wcsncpy (pTarget, pSource, pLength); pTarget [pLength] = L'\0'; @@ -76,7 +76,7 @@ if (FileName) { - wcscpy(Fcb->PathName, FileName); + CdfsWSubString(Fcb->PathName, FileName, sizeof(Fcb->PathName) / sizeof(Fcb->PathName[0]) - 1); if (wcsrchr(Fcb->PathName, '\\') != 0) { Fcb->ObjectName = wcsrchr(Fcb->PathName, '\\');
10 years, 8 months
1
0
0
0
[pschweitzer] 62675: [CHARMAP] Use rather wcsncpy(). A bit less safe, but at least, data are copied till possible
by pschweitzer@svn.reactos.org
Author: pschweitzer Date: Sun Apr 6 20:20:39 2014 New Revision: 62675 URL:
http://svn.reactos.org/svn/reactos?rev=62675&view=rev
Log: [CHARMAP] Use rather wcsncpy(). A bit less safe, but at least, data are copied till possible Modified: trunk/reactos/base/applications/charmap/lrgcell.c trunk/reactos/base/applications/charmap/map.c Modified: trunk/reactos/base/applications/charmap/lrgcell.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/…
============================================================================== --- trunk/reactos/base/applications/charmap/lrgcell.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/charmap/lrgcell.c [iso-8859-1] Sun Apr 6 20:20:39 2014 @@ -48,9 +48,9 @@ hdc); lf.lfCharSet = DEFAULT_CHARSET; - wcscpy_s(lf.lfFaceName, - sizeof(lf.lfFaceName) / sizeof(lf.lfFaceName[0]), - lpFontName); + wcsncpy(lf.lfFaceName, + lpFontName, + sizeof(lf.lfFaceName) / sizeof(lf.lfFaceName[0])); hFont = CreateFontIndirectW(&lf); Modified: trunk/reactos/base/applications/charmap/map.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/…
============================================================================== --- trunk/reactos/base/applications/charmap/map.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/charmap/map.c [iso-8859-1] Sun Apr 6 20:20:39 2014 @@ -228,9 +228,9 @@ ReleaseDC(infoPtr->hMapWnd, hdc); infoPtr->CurrentFont.lfCharSet = DEFAULT_CHARSET; - wcscpy_s(infoPtr->CurrentFont.lfFaceName, - sizeof(infoPtr->CurrentFont.lfFaceName) / sizeof(infoPtr->CurrentFont.lfFaceName[0]), - lpFontName); + wcsncpy(infoPtr->CurrentFont.lfFaceName, + lpFontName, + sizeof(infoPtr->CurrentFont.lfFaceName) / sizeof(infoPtr->CurrentFont.lfFaceName[0])); infoPtr->hFont = CreateFontIndirectW(&infoPtr->CurrentFont);
10 years, 8 months
1
0
0
0
[pschweitzer] 62674: [CHARMAP] Fix buffer overruns. Dedicated to Thomas :-). CID #515199 CID #512920
by pschweitzer@svn.reactos.org
Author: pschweitzer Date: Sun Apr 6 20:14:16 2014 New Revision: 62674 URL:
http://svn.reactos.org/svn/reactos?rev=62674&view=rev
Log: [CHARMAP] Fix buffer overruns. Dedicated to Thomas :-). CID #515199 CID #512920 Modified: trunk/reactos/base/applications/charmap/lrgcell.c trunk/reactos/base/applications/charmap/map.c Modified: trunk/reactos/base/applications/charmap/lrgcell.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/…
============================================================================== --- trunk/reactos/base/applications/charmap/lrgcell.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/charmap/lrgcell.c [iso-8859-1] Sun Apr 6 20:14:16 2014 @@ -48,8 +48,9 @@ hdc); lf.lfCharSet = DEFAULT_CHARSET; - wcscpy(lf.lfFaceName, - lpFontName); + wcscpy_s(lf.lfFaceName, + sizeof(lf.lfFaceName) / sizeof(lf.lfFaceName[0]), + lpFontName); hFont = CreateFontIndirectW(&lf); Modified: trunk/reactos/base/applications/charmap/map.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/charmap/…
============================================================================== --- trunk/reactos/base/applications/charmap/map.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/charmap/map.c [iso-8859-1] Sun Apr 6 20:14:16 2014 @@ -228,8 +228,9 @@ ReleaseDC(infoPtr->hMapWnd, hdc); infoPtr->CurrentFont.lfCharSet = DEFAULT_CHARSET; - wcscpy(infoPtr->CurrentFont.lfFaceName, - lpFontName); + wcscpy_s(infoPtr->CurrentFont.lfFaceName, + sizeof(infoPtr->CurrentFont.lfFaceName) / sizeof(infoPtr->CurrentFont.lfFaceName[0]), + lpFontName); infoPtr->hFont = CreateFontIndirectW(&infoPtr->CurrentFont);
10 years, 8 months
1
0
0
0
[khornicek] 62673: [KBSWITCH] - fix possible buffer overrun CID #716051 CID #716052
by khornicek@svn.reactos.org
Author: khornicek Date: Sun Apr 6 20:10:24 2014 New Revision: 62673 URL:
http://svn.reactos.org/svn/reactos?rev=62673&view=rev
Log: [KBSWITCH] - fix possible buffer overrun CID #716051 CID #716052 Modified: trunk/reactos/base/applications/kbswitch/kbswitch.c Modified: trunk/reactos/base/applications/kbswitch/kbswitch.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/kbswitch…
============================================================================== --- trunk/reactos/base/applications/kbswitch/kbswitch.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/kbswitch/kbswitch.c [iso-8859-1] Sun Apr 6 20:10:24 2014 @@ -113,7 +113,7 @@ tnid.uCallbackMessage = WM_NOTIFYICONMSG; tnid.hIcon = CreateTrayIcon(szLCID); - lstrcpyn(tnid.szTip, szName, sizeof(tnid.szTip)); + lstrcpyn(tnid.szTip, szName, sizeof(tnid.szTip) / sizeof(TCHAR)); Shell_NotifyIcon(NIM_ADD, &tnid); } @@ -142,7 +142,7 @@ tnid.uCallbackMessage = WM_NOTIFYICONMSG; tnid.hIcon = CreateTrayIcon(szLCID); - lstrcpyn(tnid.szTip, szName, sizeof(tnid.szTip)); + lstrcpyn(tnid.szTip, szName, sizeof(tnid.szTip) / sizeof(TCHAR)); Shell_NotifyIcon(NIM_MODIFY, &tnid); }
10 years, 8 months
1
0
0
0
[pschweitzer] 62672: [ATACTL] - Fix resource leak - Fix uninit field in struct CID #716281 CID #716748 CID #716749 CID #716751 CID #716752 CID #716753 CID #731454
by pschweitzer@svn.reactos.org
Author: pschweitzer Date: Sun Apr 6 19:48:22 2014 New Revision: 62672 URL:
http://svn.reactos.org/svn/reactos?rev=62672&view=rev
Log: [ATACTL] - Fix resource leak - Fix uninit field in struct CID #716281 CID #716748 CID #716749 CID #716751 CID #716752 CID #716753 CID #731454 Modified: trunk/reactos/base/applications/atactl/atactl.cpp Modified: trunk/reactos/base/applications/atactl/atactl.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/atactl/a…
============================================================================== --- trunk/reactos/base/applications/atactl/atactl.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/atactl/atactl.cpp [iso-8859-1] Sun Apr 6 19:48:22 2014 @@ -727,6 +727,7 @@ } */ + addr.Length = sizeof(addr); addr.PortNumber = -1; addr.PathId = inquiryData->PathId; addr.TargetId = inquiryData->TargetId; @@ -986,12 +987,14 @@ h = ata_open_dev(dev_name); if(!h) return FALSE; + addr.Length = sizeof(addr); addr.PortNumber = bus_id; len = sizeof(ADAPTERINFO)+sizeof(CHANINFO)*AHCI_MAX_PORT; if(!g_AdapterInfo) { AdapterInfo = (PADAPTERINFO)GlobalAlloc(GMEM_FIXED, len); if(!AdapterInfo) { + ata_close_dev(h); return FALSE; } } else { @@ -1111,6 +1114,7 @@ h = ata_open_dev(dev_name); if(!h) return FALSE; + addr.Length = sizeof(addr); addr.PortNumber = bus_id; addr.PathId = (UCHAR)(dev_id >> 16); addr.TargetId = (UCHAR)(dev_id >> 8); @@ -1155,6 +1159,7 @@ h = ata_open_dev(dev_name); if(!h) return FALSE; + addr.Length = sizeof(addr); addr.PortNumber = bus_id; addr.PathId = (UCHAR)(dev_id >> 16); addr.TargetId = (UCHAR)(dev_id >> 8); @@ -1213,6 +1218,7 @@ h = ata_open_dev(dev_name); if(!h) return FALSE; + addr.Length = sizeof(addr); addr.PortNumber = bus_id; addr.PathId = (UCHAR)(dev_id >> 16); addr.TargetId = (UCHAR)(dev_id >> 8); @@ -1268,6 +1274,7 @@ if((UCHAR)(dev_id) != 0xff && (UCHAR)(dev_id >> 8) != 0xff) { + addr.Length = sizeof(addr); addr.PortNumber = bus_id; addr.PathId = (UCHAR)(dev_id >> 16); addr.TargetId = 0;
10 years, 8 months
1
0
0
0
[khornicek] 62671: [FONTVIEW] - add czech translation - fix a leak CID #731443
by khornicek@svn.reactos.org
Author: khornicek Date: Sun Apr 6 18:57:16 2014 New Revision: 62671 URL:
http://svn.reactos.org/svn/reactos?rev=62671&view=rev
Log: [FONTVIEW] - add czech translation - fix a leak CID #731443 Added: trunk/reactos/base/applications/fontview/lang/cs-CZ.rc (with props) Modified: trunk/reactos/base/applications/fontview/fontview.c trunk/reactos/base/applications/fontview/fontview.rc Modified: trunk/reactos/base/applications/fontview/fontview.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/fontview…
============================================================================== --- trunk/reactos/base/applications/fontview/fontview.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/fontview/fontview.c [iso-8859-1] Sun Apr 6 18:57:16 2014 @@ -34,8 +34,8 @@ static const WCHAR g_szFontViewClassName[] = L"FontViewWClass"; -/* Tye definition for the GetFontResourceInfo function */ -typedef BOOL (WINAPI *PGFRI)(LPCWSTR, DWORD *, LPVOID, DWORD); +/* GetFontResourceInfoW is undocumented */ +BOOL WINAPI GetFontResourceInfoW(LPCWSTR lpFileName, DWORD *pdwBufSize, void* lpBuffer, DWORD dwType); DWORD FormatString( @@ -97,8 +97,6 @@ HWND hMainWnd; MSG msg; WNDCLASSEXW wincl; - HINSTANCE hDLL; - PGFRI GetFontResourceInfoW; LPCWSTR fileName; switch (GetUserDefaultUILanguage()) @@ -164,10 +162,6 @@ ErrorMsgBox(0, IDS_ERROR, IDS_ERROR_NOFONT, fileName); return -1; } - - /* Load the GetFontResourceInfo function from gdi32.dll */ - hDLL = LoadLibraryW(L"GDI32.DLL"); - GetFontResourceInfoW = (PGFRI)GetProcAddress(hDLL, "GetFontResourceInfoW"); /* Get the font name */ dwSize = sizeof(g_ExtLogFontW.elfFullName); Modified: trunk/reactos/base/applications/fontview/fontview.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/fontview…
============================================================================== --- trunk/reactos/base/applications/fontview/fontview.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/fontview/fontview.rc [iso-8859-1] Sun Apr 6 18:57:16 2014 @@ -23,6 +23,9 @@ #ifdef LANGUAGE_BG_BG #include "lang/bg-BG.rc" +#endif +#ifdef LANGUAGE_CS_CZ + #include "lang/cs-CZ.rc" #endif #ifdef LANGUAGE_DE_DE #include "lang/de-DE.rc" Added: trunk/reactos/base/applications/fontview/lang/cs-CZ.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/fontview…
============================================================================== --- trunk/reactos/base/applications/fontview/lang/cs-CZ.rc (added) +++ trunk/reactos/base/applications/fontview/lang/cs-CZ.rc [iso-8859-1] Sun Apr 6 18:57:16 2014 @@ -0,0 +1,13 @@ +LANGUAGE LANG_CZECH, SUBLANG_DEFAULT + +STRINGTABLE +BEGIN + IDS_INSTALL "Nainstalovat" + IDS_PRINT "Tisk" + IDS_STRING "PÅÃliÅ¡ žluÅ¥ouÄký kůŠúpÄl Äábelské ódy. 1234567890" + IDS_OPEN "OtevÅÃt soubor pÃsma..." + IDS_ERROR "Chyba" + IDS_ERROR_NOMEM "K dokonÄenà operace nenà dostatek pamÄti." + IDS_ERROR_NOFONT "Soubor %1 nenà platným souborem pÃsma." + IDS_ERROR_NOCLASS "Inicializace okna aplikace selhala." +END Propchange: trunk/reactos/base/applications/fontview/lang/cs-CZ.rc ------------------------------------------------------------------------------ svn:eol-style = native
10 years, 8 months
1
0
0
0
[hbelusca] 62670: [CONSRV] - text.c: Few code formatting, and remove a warning. - guiterm.c: Implement basic word selection.
by hbelusca@svn.reactos.org
Author: hbelusca Date: Sun Apr 6 17:46:49 2014 New Revision: 62670 URL:
http://svn.reactos.org/svn/reactos?rev=62670&view=rev
Log: [CONSRV] - text.c: Few code formatting, and remove a warning. - guiterm.c: Implement basic word selection. Modified: trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/guiterm.c trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/text.c Modified: trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/guiterm.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv…
============================================================================== --- trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/guiterm.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/guiterm.c [iso-8859-1] Sun Apr 6 17:46:49 2014 @@ -1162,7 +1162,42 @@ case WM_LBUTTONDBLCLK: { - DPRINT1("Handle left-double-click for selecting a word\n"); + PCONSOLE_SCREEN_BUFFER Buffer = GuiData->ActiveBuffer; + + if (GetType(Buffer) == TEXTMODE_BUFFER) + { +#define IS_WHITESPACE(c) \ + ((c) == L'\0' || (c) == L' ' || (c) == L'\t' || (c) == L'\r' || (c) == L'\n') + + PTEXTMODE_SCREEN_BUFFER TextBuffer = (PTEXTMODE_SCREEN_BUFFER)Buffer; + COORD cL, cR; + PCHAR_INFO ptrL, ptrR; + + /* Starting point */ + cL = cR = PointToCoord(GuiData, lParam); + ptrL = ptrR = ConioCoordToPointer(TextBuffer, cL.X, cL.Y); + + /* Enlarge the selection by checking for whitespace */ + while ((0 < cL.X) && !IS_WHITESPACE(ptrL->Char.UnicodeChar) + && !IS_WHITESPACE((ptrL-1)->Char.UnicodeChar)) + { + --cL.X; + --ptrL; + } + while ((cR.X < TextBuffer->ScreenBufferSize.X - 1) && + !IS_WHITESPACE(ptrR->Char.UnicodeChar) && + !IS_WHITESPACE((ptrR+1)->Char.UnicodeChar)) + { + ++cR.X; + ++ptrR; + } + + Console->Selection.dwSelectionAnchor = cL; + Console->dwSelectionCursor = cR; + + GuiConsoleUpdateSelection(Console, &Console->dwSelectionCursor); + } + break; } Modified: trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/text.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/winsrv/consrv…
============================================================================== --- trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/text.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/winsrv/consrv/frontends/gui/text.c [iso-8859-1] Sun Apr 6 17:46:49 2014 @@ -89,9 +89,9 @@ for (yPos = 0; yPos < selHeight; yPos++) { - ptr = ConioCoordToPointer(Buffer, + ptr = ConioCoordToPointer(Buffer, Console->Selection.srSelection.Left, - yPos + Console->Selection.srSelection.Top); + Console->Selection.srSelection.Top + yPos); /* Copy only the characters, leave attributes alone */ for (xPos = 0; xPos < selWidth; xPos++) { @@ -139,7 +139,7 @@ LPWSTR str; WCHAR CurChar = 0; - SHORT VkKey; // MAKEWORD(low = vkey_code, high = shift_state); + USHORT VkKey; // MAKEWORD(low = vkey_code, high = shift_state); INPUT_RECORD er; hData = GetClipboardData(CF_UNICODETEXT);
10 years, 8 months
1
0
0
0
[khornicek] 62669: [DXDIAG] - fix a buffer overrun CID #1102308
by khornicek@svn.reactos.org
Author: khornicek Date: Sun Apr 6 17:33:12 2014 New Revision: 62669 URL:
http://svn.reactos.org/svn/reactos?rev=62669&view=rev
Log: [DXDIAG] - fix a buffer overrun CID #1102308 Modified: trunk/reactos/base/applications/dxdiag/network.c Modified: trunk/reactos/base/applications/dxdiag/network.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/dxdiag/n…
============================================================================== --- trunk/reactos/base/applications/dxdiag/network.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/dxdiag/network.c [iso-8859-1] Sun Apr 6 17:33:12 2014 @@ -282,7 +282,7 @@ { RegProviders |= (1 << ProviderIndex); szResult[0] = L'\0'; - LoadStringW(hInst, IDS_REG_SUCCESS, szResult, sizeof(szResult)); + LoadStringW(hInst, IDS_REG_SUCCESS, szResult, sizeof(szResult) / sizeof(WCHAR)); Item.iSubItem = 1; Item.iItem = ProviderIndex + ItemCount;
10 years, 8 months
1
0
0
0
[pschweitzer] 62668: [NTOSKRNL] Fix overflow CID #701303
by pschweitzer@svn.reactos.org
Author: pschweitzer Date: Sun Apr 6 17:18:55 2014 New Revision: 62668 URL:
http://svn.reactos.org/svn/reactos?rev=62668&view=rev
Log: [NTOSKRNL] Fix overflow CID #701303 Modified: trunk/reactos/ntoskrnl/fstub/fstubex.c Modified: trunk/reactos/ntoskrnl/fstub/fstubex.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/fstub/fstubex.c?r…
============================================================================== --- trunk/reactos/ntoskrnl/fstub/fstubex.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/fstub/fstubex.c [iso-8859-1] Sun Apr 6 17:18:55 2014 @@ -2474,7 +2474,7 @@ NumberOfEntries = EfiHeader->NumberOfEntries; RtlCopyMemory(&DiskGuid, &EfiHeader->DiskGUID, sizeof(GUID)); /* Count number of sectors needed to store partitions */ - SectorsForPartitions = (NumberOfEntries * PARTITION_ENTRY_SIZE) / Disk->SectorSize; + SectorsForPartitions = ((ULONGLONG)NumberOfEntries * PARTITION_ENTRY_SIZE) / Disk->SectorSize; /* Set first usable LBA: Legacy MBR + GPT header + Partitions entries */ FirstUsableLBA = SectorsForPartitions + 2; /* Set last usable LBA: Last sector - GPT header - Partitions entries */
10 years, 8 months
1
0
0
0
← Newer
1
...
39
40
41
42
43
44
45
...
50
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
Results per page:
10
25
50
100
200