Ros-diffs May 2014

ros-diffs@reactos.org

14 participants
437 discussions

[tfaber] 63142: [WIN32K:NTGDI] - Release device context semaphores in failure cases of GreExtTextOutW CORE-8169 #resolve
by tfaber＠svn.reactos.org 04 May '14

04 May '14

Author: tfaber Date: Sun May 4 08:38:44 2014 New Revision: 63142 URL: http://svn.reactos.org/svn/reactos?rev=63142&view=rev Log: [WIN32K:NTGDI] - Release device context semaphores in failure cases of GreExtTextOutW CORE-8169 #resolve Modified: trunk/reactos/win32ss/gdi/ntgdi/freetype.c Modified: trunk/reactos/win32ss/gdi/ntgdi/freetype.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/freetype… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/freetype.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/freetype.c [iso-8859-1] Sun May 4 08:38:44 2014 @@ -3533,6 +3533,7 @@ { DPRINT1("Failed to load and render glyph! [index: %d]\n", glyph_index); IntUnLockFreeType; + DC_vFinishBlit(dc, NULL); goto fail2; } glyph = face->glyph; @@ -3546,6 +3547,7 @@ { DPRINT1("Failed to render glyph! [index: %d]\n", glyph_index); IntUnLockFreeType; + DC_vFinishBlit(dc, NULL); goto fail2; } } @@ -3609,6 +3611,7 @@ DPRINT1("WARNING: EngLockSurface() failed!\n"); // FT_Done_Glyph(realglyph); IntUnLockFreeType; + DC_vFinishBlit(dc, NULL); goto fail2; } SourceGlyphSurf = EngLockSurface((HSURF)HSourceGlyph); @@ -3617,6 +3620,7 @@ EngDeleteSurface((HSURF)HSourceGlyph); DPRINT1("WARNING: EngLockSurface() failed!\n"); IntUnLockFreeType; + DC_vFinishBlit(dc, NULL); goto fail2; }

1 0

[hbelusca] 63141: [CONSRV] - Move aliases & history management structures & initialization into the console server part. - Maintain two different console lists, the first one for all the consoles (...
by hbelusca＠svn.reactos.org 04 May '14

04 May '14

Author: hbelusca Date: Sun May 4 00:01:48 2014 New Revision: 63141 URL: http://svn.reactos.org/svn/reactos?rev=63141&view=rev Log: [CONSRV] - Move aliases & history management structures & initialization into the console server part. - Maintain two different console lists, the first one for all the consoles (that are managed by the console driver) and the other for the consoles that are also owned by the console server. - Simplify few function prototypes. Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/condrv/console.c branches/condrv_restructure/win32ss/user/winsrv/consrv/console.c branches/condrv_restructure/win32ss/user/winsrv/consrv/console.h branches/condrv_restructure/win32ss/user/winsrv/consrv/consrv.h branches/condrv_restructure/win32ss/user/winsrv/consrv/handle.c branches/condrv_restructure/win32ss/user/winsrv/consrv/include/conio.h branches/condrv_restructure/win32ss/user/winsrv/consrv/include/conio_winsrv.h branches/condrv_restructure/win32ss/user/winsrv/consrv/include/console.h branches/condrv_restructure/win32ss/user/winsrv/consrv/init.c Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/condrv/console.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user… ============================================================================== --- branches/condrv_restructure/win32ss/user/winsrv/consrv/condrv/console.c [iso-8859-1] (original) +++ branches/condrv_restructure/win32ss/user/winsrv/consrv/condrv/console.c [iso-8859-1] Sun May 4 00:01:48 2014 @@ -12,7 +12,6 @@ #include <consrv.h> -#include <alias.h> #include <coninput.h> #define NDEBUG @@ -21,8 +20,10 @@ /* GLOBALS ********************************************************************/ -static ULONG ConsoleListSize; -static PCONSOLE* ConsoleList; /* The list of all the allocated consoles */ +static ULONG CurrentConsoleID = 0; + +/* Linked list of consoles */ +static LIST_ENTRY ConsoleList; static RTL_RESOURCE ListLock; #define ConDrvLockConsoleListExclusive() \ @@ -33,6 +34,47 @@ #define ConDrvUnlockConsoleList() \ RtlReleaseResource(&ListLock) + + +static NTSTATUS +InsertConsole(IN PCONSOLE Console) +{ + ASSERT(Console); + + /* All went right, so add the console to the list */ + ConDrvLockConsoleListExclusive(); + + DPRINT1("Insert in the list\n"); + InsertTailList(&ConsoleList, &Console->ListEntry); + + // FIXME: Move this code to the caller function!! + /* Get a new console ID */ + _InterlockedExchange((PLONG)&Console->ConsoleID, CurrentConsoleID); + _InterlockedIncrement((PLONG)&CurrentConsoleID); + + /* Unlock the console list and return success */ + ConDrvUnlockConsoleList(); + return STATUS_SUCCESS; +} + +static NTSTATUS +RemoveConsole(IN PCONSOLE Console) +{ + // ASSERT(Console); + if (!Console) return STATUS_INVALID_PARAMETER; + + /* Remove the console from the list */ + ConDrvLockConsoleListExclusive(); + + RemoveEntryList(&Console->ListEntry); + + /* Unlock the console list and return success */ + ConDrvUnlockConsoleList(); + return STATUS_SUCCESS; +} + + +/* PRIVATE FUNCTIONS **********************************************************/ // Adapted from reactos/lib/rtl/unicode.c, RtlCreateUnicodeString line 2180 static BOOLEAN @@ -63,135 +105,6 @@ } } - -static NTSTATUS -InsertConsole(OUT PHANDLE Handle, - IN PCONSOLE Console) -{ -#define CONSOLE_HANDLES_INCREMENT 2 * 3 - - NTSTATUS Status = STATUS_SUCCESS; - ULONG i = 0; - PCONSOLE* Block; - - ASSERT( (ConsoleList == NULL && ConsoleListSize == 0) || - (ConsoleList != NULL && ConsoleListSize != 0) ); - - /* All went right, so add the console to the list */ - ConDrvLockConsoleListExclusive(); - DPRINT1("Insert in the list\n"); - - if (ConsoleList) - { - for (i = 0; i < ConsoleListSize; i++) - { - if (ConsoleList[i] == NULL) break; - } - } - - if (i >= ConsoleListSize) - { - DPRINT1("Creation of a new handles table\n"); - /* Allocate a new handles table */ - Block = ConsoleAllocHeap(HEAP_ZERO_MEMORY, - (ConsoleListSize + - CONSOLE_HANDLES_INCREMENT) * sizeof(PCONSOLE)); - if (Block == NULL) - { - Status = STATUS_UNSUCCESSFUL; - goto Quit; - } - - /* If we previously had a handles table, free it and use the new one */ - if (ConsoleList) - { - /* Copy the handles from the old table to the new one */ - RtlCopyMemory(Block, - ConsoleList, - ConsoleListSize * sizeof(PCONSOLE)); - ConsoleFreeHeap(ConsoleList); - } - ConsoleList = Block; - ConsoleListSize += CONSOLE_HANDLES_INCREMENT; - } - - ConsoleList[i] = Console; - *Handle = ULongToHandle((i << 2) | 0x3); - -Quit: - /* Unlock the console list and return status */ - ConDrvUnlockConsoleList(); - return Status; -} - -/* Unused */ -#if 0 -static NTSTATUS -RemoveConsoleByHandle(IN HANDLE Handle) -{ - NTSTATUS Status = STATUS_SUCCESS; - PCONSOLE Console; - - BOOLEAN ValidHandle = ((HandleToULong(Handle) & 0x3) == 0x3); - ULONG Index = HandleToULong(Handle) >> 2; - - if (!ValidHandle) return STATUS_INVALID_HANDLE; - - ASSERT( (ConsoleList == NULL && ConsoleListSize == 0) || - (ConsoleList != NULL && ConsoleListSize != 0) ); - - /* Remove the console from the list */ - ConDrvLockConsoleListExclusive(); - - if (Index >= ConsoleListSize || - (Console = ConsoleList[Index]) == NULL) - { - Status = STATUS_INVALID_HANDLE; - goto Quit; - } - - ConsoleList[Index] = NULL; - -Quit: - /* Unlock the console list and return status */ - ConDrvUnlockConsoleList(); - return Status; -} -#endif - -static NTSTATUS -RemoveConsoleByPointer(IN PCONSOLE Console) -{ - ULONG i = 0; - - if (!Console) return STATUS_INVALID_PARAMETER; - - ASSERT( (ConsoleList == NULL && ConsoleListSize == 0) || - (ConsoleList != NULL && ConsoleListSize != 0) ); - - /* Remove the console from the list */ - ConDrvLockConsoleListExclusive(); - - if (ConsoleList) - { - for (i = 0; i < ConsoleListSize; i++) - { - if (ConsoleList[i] == Console) ConsoleList[i] = NULL; - } - } - - /* Unlock the console list */ - ConDrvUnlockConsoleList(); - - return STATUS_SUCCESS; -} - - -/* PRIVATE FUNCTIONS **********************************************************/ - -/* For resetting the terminal - defined in dummyterm.c */ -VOID ResetTerminal(IN PCONSOLE Console); - VOID NTAPI ConDrvPause(PCONSOLE Console) { @@ -254,103 +167,6 @@ return TRUE; } -BOOLEAN NTAPI -ConDrvValidateConsole(OUT PCONSOLE* Console, - IN HANDLE ConsoleHandle, - IN CONSOLE_STATE ExpectedState, - IN BOOLEAN LockConsole) -{ - BOOLEAN RetVal = FALSE; - PCONSOLE ValidatedConsole; - - BOOLEAN ValidHandle = ((HandleToULong(ConsoleHandle) & 0x3) == 0x3); - ULONG Index = HandleToULong(ConsoleHandle) >> 2; - - if (!ValidHandle) return FALSE; - - if (!Console) return FALSE; - *Console = NULL; - - /* - * Forbid creation or deletion of consoles when - * checking for the existence of a console. - */ - ConDrvLockConsoleListShared(); - - if (Index >= ConsoleListSize || - (ValidatedConsole = ConsoleList[Index]) == NULL) - { - /* Unlock the console list */ - ConDrvUnlockConsoleList(); - - return FALSE; - } - - ValidatedConsole = ConsoleList[Index]; - - /* Unlock the console list and return */ - ConDrvUnlockConsoleList(); - - RetVal = ConDrvValidateConsoleUnsafe(ValidatedConsole, - ExpectedState, - LockConsole); - if (RetVal) *Console = ValidatedConsole; - - return RetVal; -} - -NTSTATUS NTAPI -ConDrvGetConsole(OUT PCONSOLE* Console, - IN HANDLE ConsoleHandle, - IN BOOLEAN LockConsole) -{ - NTSTATUS Status = STATUS_INVALID_HANDLE; - PCONSOLE GrabConsole; - - if (Console == NULL) return STATUS_INVALID_PARAMETER; - *Console = NULL; - - if (ConDrvValidateConsole(&GrabConsole, - ConsoleHandle, - CONSOLE_RUNNING, - LockConsole)) - { - InterlockedIncrement(&GrabConsole->ReferenceCount); - *Console = GrabConsole; - Status = STATUS_SUCCESS; - } - - return Status; -} - -VOID NTAPI -ConDrvReleaseConsole(IN PCONSOLE Console, - IN BOOLEAN WasConsoleLocked) -{ - LONG RefCount = 0; - - if (!Console) return; - // if (Console->ReferenceCount == 0) return; // This shouldn't happen - ASSERT(Console->ReferenceCount > 0); - - /* The console must be locked */ - // ASSERT(Console_locked); - - /* - * Decrement the reference count. Save the new value too, - * because Console->ReferenceCount might be modified after - * the console gets unlocked but before we check whether we - * can destroy it. - */ - RefCount = _InterlockedDecrement(&Console->ReferenceCount); - - /* Unlock the console if needed */ - if (WasConsoleLocked) LeaveCriticalSection(&Console->Lock); - - /* Delete the console if needed */ - if (RefCount <= 0) ConDrvDeleteConsole(Console); -} - /* CONSOLE INITIALIZATION FUNCTIONS *******************************************/ @@ -360,38 +176,36 @@ DPRINT("CONSRV: ConDrvInitConsoleSupport()\n"); /* Initialize the console list and its lock */ - ConsoleListSize = 0; - ConsoleList = NULL; + InitializeListHead(&ConsoleList); RtlInitializeResource(&ListLock); /* Should call LoadKeyboardLayout */ } -NTSTATUS NTAPI -ConDrvInitConsole(OUT PHANDLE NewConsoleHandle, - OUT PCONSOLE* NewConsole, - IN PCONSOLE_INFO ConsoleInfo, - IN ULONG ConsoleLeaderProcessId) +/* For resetting the terminal - defined in dummyterm.c */ +VOID ResetTerminal(IN PCONSOLE Console); + +NTSTATUS NTAPI +ConDrvInitConsole(OUT PCONSOLE* NewConsole, + IN PCONSOLE_INFO ConsoleInfo) { NTSTATUS Status; SECURITY_ATTRIBUTES SecurityAttributes; // CONSOLE_INFO CapturedConsoleInfo; TEXTMODE_BUFFER_INFO ScreenBufferInfo; - HANDLE ConsoleHandle; PCONSOLE Console; PCONSOLE_SCREEN_BUFFER NewBuffer; #if 0 WCHAR DefaultTitle[128]; #endif - if (NewConsoleHandle == NULL || NewConsole == NULL || ConsoleInfo == NULL) + if (NewConsole == NULL || ConsoleInfo == NULL) return STATUS_INVALID_PARAMETER; - *NewConsoleHandle = NULL; *NewConsole = NULL; /* - * Allocate a console structure + * Allocate a new console */ Console = ConsoleAllocHeap(HEAP_ZERO_MEMORY, sizeof(*Console)); if (NULL == Console) @@ -478,15 +292,6 @@ Console->ActiveBuffer = NewBuffer; Console->UnpauseEvent = NULL; - /* - * Initialize the alias and history buffers - */ - Console->Aliases = NULL; - InitializeListHead(&Console->HistoryBuffers); - Console->HistoryBufferSize = ConsoleInfo->HistoryBufferSize; - Console->NumberOfHistoryBuffers = ConsoleInfo->NumberOfHistoryBuffers; - Console->HistoryNoDup = ConsoleInfo->HistoryNoDup; - /* Initialize the console title */ ConsoleCreateUnicodeString(&Console->OriginalTitle, ConsoleInfo->ConsoleTitle); #if 0 @@ -509,13 +314,10 @@ } #endif - /* Lock the console until its initialization is finished */ - // EnterCriticalSection(&Console->Lock); - DPRINT("Console initialized\n"); /* All went right, so add the console to the list */ - Status = InsertConsole(&ConsoleHandle, Console); + Status = InsertConsole(Console); if (!NT_SUCCESS(Status)) { /* Fail */ @@ -527,12 +329,8 @@ DPRINT("Change state\n"); Console->State = CONSOLE_RUNNING; - /* Unlock the console */ - // LeaveCriticalSection(&Console->Lock); - /* Return the newly created console to the caller and a success code too */ - *NewConsoleHandle = ConsoleHandle; - *NewConsole = Console; + *NewConsole = Console; return STATUS_SUCCESS; } @@ -630,7 +428,7 @@ /* * Allow other threads to finish their job: basically, unlock * all other calls to EnterCriticalSection(&Console->Lock); by - * ConDrvValidateConsole(Unsafe) functions so that they just see + * ConDrvValidateConsoleUnsafe functions so that they just see * that we are not in CONSOLE_RUNNING state anymore, or unlock * other concurrent calls to ConDrvDeleteConsole so that they * can see that we are in fact already deleting the console. @@ -666,16 +464,13 @@ Console->ReferenceCount = 0; /* Remove the console from the list */ - RemoveConsoleByPointer(Console); + RemoveConsole(Console); /* Discard all entries in the input event queue */ PurgeInputBuffer(Console); - if (Console->LineBuffer) ConsoleFreeHeap(Console->LineBuffer); - IntDeleteAllAliases(Console); - HistoryDeleteBuffers(Console); - + /* Delete the last screen buffer */ ConioDeleteScreenBuffer(Console->ActiveBuffer); Console->ActiveBuffer = NULL; if (!IsListEmpty(&Console->BufferList)) Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/console.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user… ============================================================================== --- branches/condrv_restructure/win32ss/user/winsrv/consrv/console.c [iso-8859-1] (original) +++ branches/condrv_restructure/win32ss/user/winsrv/consrv/console.c [iso-8859-1] Sun May 4 00:01:48 2014 @@ -13,6 +13,8 @@ #include "consrv.h" #include <ndk/psfuncs.h> + +#include <alias.h> #include "procinit.h" #define NDEBUG @@ -22,6 +24,188 @@ NTSTATUS NTAPI RtlGetLastNtStatus(VOID); /* GLOBALS ********************************************************************/ + +static ULONG ConsoleListSize; +static PCONSOLE* ConsoleList; /* The list of the ConSrv consoles */ +static RTL_RESOURCE ListLock; + +#define ConSrvLockConsoleListExclusive() \ + RtlAcquireResourceExclusive(&ListLock, TRUE) + +#define ConSrvLockConsoleListShared() \ + RtlAcquireResourceShared(&ListLock, TRUE) + +#define ConSrvUnlockConsoleList() \ + RtlReleaseResource(&ListLock) + + +static NTSTATUS +InsertConsole(OUT PHANDLE Handle, + IN PCONSOLE Console) +{ +#define CONSOLE_HANDLES_INCREMENT 2 * 3 + + NTSTATUS Status = STATUS_SUCCESS; + ULONG i = 0; + PCONSOLE* Block; + + ASSERT( (ConsoleList == NULL && ConsoleListSize == 0) || + (ConsoleList != NULL && ConsoleListSize != 0) ); + + /* All went right, so add the console to the list */ + ConSrvLockConsoleListExclusive(); + DPRINT1("Insert in the list\n"); + + if (ConsoleList) + { + for (i = 0; i < ConsoleListSize; i++) + { + if (ConsoleList[i] == NULL) break; + } + } + + if (i >= ConsoleListSize) + { + DPRINT1("Creation of a new handles table\n"); + /* Allocate a new handles table */ + Block = ConsoleAllocHeap(HEAP_ZERO_MEMORY, + (ConsoleListSize + + CONSOLE_HANDLES_INCREMENT) * sizeof(PCONSOLE)); + if (Block == NULL) + { + Status = STATUS_UNSUCCESSFUL; + goto Quit; + } + + /* If we previously had a handles table, free it and use the new one */ + if (ConsoleList) + { + /* Copy the handles from the old table to the new one */ + RtlCopyMemory(Block, + ConsoleList, + ConsoleListSize * sizeof(PCONSOLE)); + ConsoleFreeHeap(ConsoleList); + } + ConsoleList = Block; + ConsoleListSize += CONSOLE_HANDLES_INCREMENT; + } + + ConsoleList[i] = Console; + *Handle = ULongToHandle((i << 2) | 0x3); + +Quit: + /* Unlock the console list and return status */ + ConSrvUnlockConsoleList(); + return Status; +} + +/* Unused */ +#if 0 +static NTSTATUS +RemoveConsoleByHandle(IN HANDLE Handle) +{ + NTSTATUS Status = STATUS_SUCCESS; + PCONSOLE Console; + + BOOLEAN ValidHandle = ((HandleToULong(Handle) & 0x3) == 0x3); + ULONG Index = HandleToULong(Handle) >> 2; + + if (!ValidHandle) return STATUS_INVALID_HANDLE; + + ASSERT( (ConsoleList == NULL && ConsoleListSize == 0) || + (ConsoleList != NULL && ConsoleListSize != 0) ); + + /* Remove the console from the list */ + ConSrvLockConsoleListExclusive(); + + if (Index >= ConsoleListSize || + (Console = ConsoleList[Index]) == NULL) + { + Status = STATUS_INVALID_HANDLE; + goto Quit; + } + + ConsoleList[Index] = NULL; + +Quit: + /* Unlock the console list and return status */ + ConSrvUnlockConsoleList(); + return Status; +} +#endif + +static NTSTATUS +RemoveConsoleByPointer(IN PCONSOLE Console) +{ + ULONG i = 0; + + if (!Console) return STATUS_INVALID_PARAMETER; + + ASSERT( (ConsoleList == NULL && ConsoleListSize == 0) || + (ConsoleList != NULL && ConsoleListSize != 0) ); + + /* Remove the console from the list */ + ConSrvLockConsoleListExclusive(); + + if (ConsoleList) + { + for (i = 0; i < ConsoleListSize; i++) + { + if (ConsoleList[i] == Console) ConsoleList[i] = NULL; + } + } + + /* Unlock the console list */ + ConSrvUnlockConsoleList(); + + return STATUS_SUCCESS; +} + +BOOLEAN NTAPI +ConSrvValidateConsole(OUT PCONSOLE* Console, + IN HANDLE ConsoleHandle, + IN CONSOLE_STATE ExpectedState, + IN BOOLEAN LockConsole) +{ + BOOLEAN RetVal = FALSE; + PCONSOLE ValidatedConsole; + + BOOLEAN ValidHandle = ((HandleToULong(ConsoleHandle) & 0x3) == 0x3); + ULONG Index = HandleToULong(ConsoleHandle) >> 2; + + if (!ValidHandle) return FALSE; + + if (!Console) return FALSE; + *Console = NULL; + + /* + * Forbid creation or deletion of consoles when + * checking for the existence of a console. + */ + ConSrvLockConsoleListShared(); + + if (Index >= ConsoleListSize || + (ValidatedConsole = ConsoleList[Index]) == NULL) + { + /* Unlock the console list */ + ConSrvUnlockConsoleList(); + + return FALSE; + } + + ValidatedConsole = ConsoleList[Index]; + + /* Unlock the console list and return */ + ConSrvUnlockConsoleList(); + + RetVal = ConDrvValidateConsoleUnsafe(ValidatedConsole, + ExpectedState, + LockConsole); + if (RetVal) *Console = ValidatedConsole; + + return RetVal; +} + /* PRIVATE FUNCTIONS **********************************************************/ @@ -54,33 +238,76 @@ } NTSTATUS -ConSrvGetConsole(PCONSOLE_PROCESS_DATA ProcessData, - PCONSOLE* Console, - BOOL LockConsole) -{ - NTSTATUS Status = STATUS_SUCCESS; - PCONSOLE ProcessConsole; - +ConSrvGetConsole(IN PCONSOLE_PROCESS_DATA ProcessData, + OUT PCONSOLE* Console, + IN BOOLEAN LockConsole) +{ + NTSTATUS Status = STATUS_INVALID_HANDLE; + PCONSOLE GrabConsole; + + // if (Console == NULL) return STATUS_INVALID_PARAMETER; ASSERT(Console); *Console = NULL; // RtlEnterCriticalSection(&ProcessData->HandleTableLock); - Status = ConDrvGetConsole(&ProcessConsole, ProcessData->ConsoleHandle, LockConsole); - if (NT_SUCCESS(Status)) *Console = ProcessConsole; + if (ConSrvValidateConsole(&GrabConsole, + ProcessData->ConsoleHandle, + CONSOLE_RUNNING, + LockConsole)) + { + InterlockedIncrement(&GrabConsole->ReferenceCount); + *Console = GrabConsole; + Status = STATUS_SUCCESS; + } // RtlLeaveCriticalSection(&ProcessData->HandleTableLock); return Status; } VOID -ConSrvReleaseConsole(PCONSOLE Console, - BOOL WasConsoleLocked) -{ - /* Just call the driver */ - ConDrvReleaseConsole(Console, WasConsoleLocked); -} - +ConSrvReleaseConsole(IN PCONSOLE Console, + IN BOOLEAN WasConsoleLocked) +{ + LONG RefCount = 0; + + if (!Console) return; + // if (Console->ReferenceCount == 0) return; // This shouldn't happen + ASSERT(Console->ReferenceCount > 0); + + /* The console must be locked */ + // ASSERT(Console_locked); + + /* + * Decrement the reference count. Save the new value too, + * because Console->ReferenceCount might be modified after + * the console gets unlocked but before we check whether we + * can destroy it. + */ + RefCount = _InterlockedDecrement(&Console->ReferenceCount); + + /* Unlock the console if needed */ + if (WasConsoleLocked) LeaveCriticalSection(&Console->Lock); + + /* Delete the console if needed */ + if (RefCount <= 0) ConSrvDeleteConsole(Console); +} + + +/* CONSOLE INITIALIZATION FUNCTIONS *******************************************/ + +VOID NTAPI +ConSrvInitConsoleSupport(VOID) +{ + DPRINT("CONSRV: ConSrvInitConsoleSupport()\n"); + + /* Initialize the console list and its lock */ + ConsoleListSize = 0; + ConsoleList = NULL; + RtlInitializeResource(&ListLock); + + /* Should call LoadKeyboardLayout */ +} NTSTATUS NTAPI ConSrvInitTerminal(IN OUT PTERMINAL Terminal, @@ -170,10 +397,7 @@ ConsoleInfo.CodePage = GetOEMCP(); /* Initialize a new console via the driver */ - Status = ConDrvInitConsole(&ConsoleHandle, - &Console, - &ConsoleInfo, - ConsoleLeaderProcessId); + Status = ConDrvInitConsole(&Console, &ConsoleInfo); if (!NT_SUCCESS(Status)) { DPRINT1("Creating a new console failed, Status = 0x%08lx\n", Status); @@ -196,6 +420,13 @@ InitializeListHead(&Console->ReadWaitQueue); InitializeListHead(&Console->WriteWaitQueue); + /* Initialize the alias and history buffers */ + Console->Aliases = NULL; + InitializeListHead(&Console->HistoryBuffers); + Console->HistoryBufferSize = ConsoleInfo.HistoryBufferSize; + Console->NumberOfHistoryBuffers = ConsoleInfo.NumberOfHistoryBuffers; + Console->HistoryNoDup = ConsoleInfo.HistoryNoDup; + Console->QuickEdit = ConsoleInfo.QuickEdit; /* Attach the ConSrv terminal to the console */ @@ -209,6 +440,9 @@ } DPRINT("Terminal registered\n"); + /* All went right, so add the console to the list */ + Status = InsertConsole(&ConsoleHandle, Console); + /* Return the newly created console to the caller and a success code too */ *NewConsoleHandle = ConsoleHandle; *NewConsole = Console; @@ -220,7 +454,16 @@ { DPRINT("ConSrvDeleteConsole\n"); - /* Just call the driver. ConDrvDeregisterTerminal is called on-demand. */ + // FIXME: Send a terminate message to all the processes owning this console + + /* Remove the console from the list */ + RemoveConsoleByPointer(Console); + + /* Clean aliases and history */ + IntDeleteAllAliases(Console); + HistoryDeleteBuffers(Console); + + /* Now, call the driver. ConDrvDeregisterTerminal is called on-demand. */ ConDrvDeleteConsole(Console); } @@ -402,7 +645,7 @@ /* Return the console handle and the input wait handle to the caller */ AllocConsoleRequest->ConsoleHandle = ProcessData->ConsoleHandle; - AllocConsoleRequest->InputWaitHandle = ProcessData->ConsoleEvent; + AllocConsoleRequest->InputWaitHandle = ProcessData->InputWaitHandle; /* Set the Property-Dialog and Control-Dispatcher handlers */ ProcessData->PropDispatcher = AllocConsoleRequest->PropDispatcher; @@ -479,7 +722,7 @@ /* Return the console handle and the input wait handle to the caller */ AttachConsoleRequest->ConsoleHandle = TargetProcessData->ConsoleHandle; - AttachConsoleRequest->InputWaitHandle = TargetProcessData->ConsoleEvent; + AttachConsoleRequest->InputWaitHandle = TargetProcessData->InputWaitHandle; /* Set the Property-Dialog and Control-Dispatcher handlers */ TargetProcessData->PropDispatcher = AttachConsoleRequest->PropDispatcher; Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/console.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user… ============================================================================== --- branches/condrv_restructure/win32ss/user/winsrv/consrv/console.h [iso-8859-1] (original) +++ branches/condrv_restructure/win32ss/user/winsrv/consrv/console.h [iso-8859-1] Sun May 4 00:01:48 2014 @@ -8,6 +8,9 @@ #pragma once +VOID NTAPI +ConSrvInitConsoleSupport(VOID); + NTSTATUS NTAPI ConSrvInitConsole(OUT PHANDLE NewConsoleHandle, OUT struct _CONSOLE** /* PCONSOLE* */ NewConsole, @@ -15,8 +18,17 @@ IN ULONG ConsoleLeaderProcessId); VOID NTAPI ConSrvDeleteConsole(struct _CONSOLE* /* PCONSOLE */ Console); -NTSTATUS ConSrvGetConsole(PCONSOLE_PROCESS_DATA ProcessData, - struct _CONSOLE** /* PCONSOLE* */ Console, - BOOL LockConsole); -VOID ConSrvReleaseConsole(struct _CONSOLE* /* PCONSOLE */ Console, - BOOL WasConsoleLocked); +NTSTATUS +ConSrvGetConsole(IN PCONSOLE_PROCESS_DATA ProcessData, + OUT struct _CONSOLE** /* PCONSOLE* */ Console, + IN BOOLEAN LockConsole); +VOID +ConSrvReleaseConsole(IN struct _CONSOLE* /* PCONSOLE */ Console, + IN BOOLEAN WasConsoleLocked); + + +BOOLEAN NTAPI +ConSrvValidateConsole(OUT struct _CONSOLE** /* PCONSOLE* */ Console, + IN HANDLE ConsoleHandle, + IN CONSOLE_STATE ExpectedState, + IN BOOLEAN LockConsole); Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/consrv.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user… ============================================================================== --- branches/condrv_restructure/win32ss/user/winsrv/consrv/consrv.h [iso-8859-1] (original) +++ branches/condrv_restructure/win32ss/user/winsrv/consrv/consrv.h [iso-8859-1] Sun May 4 00:01:48 2014 @@ -51,7 +51,7 @@ { LIST_ENTRY ConsoleLink; PCSR_PROCESS Process; // Process owning this structure. - HANDLE ConsoleEvent; + HANDLE InputWaitHandle; HANDLE ConsoleHandle; HANDLE ParentConsoleHandle; Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/handle.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user… ============================================================================== --- branches/condrv_restructure/win32ss/user/winsrv/consrv/handle.c [iso-8859-1] (original) +++ branches/condrv_restructure/win32ss/user/winsrv/consrv/handle.c [iso-8859-1] Sun May 4 00:01:48 2014 @@ -440,7 +440,7 @@ RtlLeaveCriticalSection(&ProcessData->HandleTableLock); - // Status = ConDrvGetConsole(&ObjectConsole, ProcessData->ConsoleHandle, LockConsole); + // Status = ConSrvGetConsole(ProcessData, &ObjectConsole, LockConsole); // if (NT_SUCCESS(Status)) if (ConDrvValidateConsoleUnsafe(ObjectEntry->Console, CONSOLE_RUNNING, LockConsole)) { @@ -522,7 +522,7 @@ Status = NtDuplicateObject(NtCurrentProcess(), Console->InputBuffer.ActiveEvent, ProcessData->Process->ProcessHandle, - &ProcessData->ConsoleEvent, + &ProcessData->InputWaitHandle, EVENT_ALL_ACCESS, 0, 0); if (!NT_SUCCESS(Status)) { @@ -557,7 +557,7 @@ PCONSOLE Console; /* Validate and lock the console */ - if (!ConDrvValidateConsole(&Console, + if (!ConSrvValidateConsole(&Console, ConsoleHandle, CONSOLE_RUNNING, TRUE)) { @@ -600,7 +600,7 @@ Status = NtDuplicateObject(NtCurrentProcess(), Console->InputBuffer.ActiveEvent, ProcessData->Process->ProcessHandle, - &ProcessData->ConsoleEvent, + &ProcessData->InputWaitHandle, EVENT_ALL_ACCESS, 0, 0); if (!NT_SUCCESS(Status)) { @@ -637,7 +637,7 @@ // RtlEnterCriticalSection(&ProcessData->HandleTableLock); /* Validate and lock the console */ - if (ConDrvValidateConsole(&Console, + if (ConSrvValidateConsole(&Console, ProcessData->ConsoleHandle, CONSOLE_RUNNING, TRUE)) { @@ -689,9 +689,9 @@ /* Release the console */ DPRINT("ConSrvRemoveConsole - Decrement Console->ReferenceCount = %lu\n", Console->ReferenceCount); - ConDrvReleaseConsole(Console, TRUE); - //CloseHandle(ProcessData->ConsoleEvent); - //ProcessData->ConsoleEvent = NULL; + ConSrvReleaseConsole(Console, TRUE); + //CloseHandle(ProcessData->InputWaitHandle); + //ProcessData->InputWaitHandle = NULL; } // RtlLeaveCriticalSection(&ProcessData->HandleTableLock); Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/include/conio.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user… ============================================================================== --- branches/condrv_restructure/win32ss/user/winsrv/consrv/include/conio.h [iso-8859-1] (original) +++ branches/condrv_restructure/win32ss/user/winsrv/consrv/include/conio.h [iso-8859-1] Sun May 4 00:01:48 2014 @@ -274,6 +274,7 @@ TERMINAL TermIFace; /* Frontend-specific interface */ ULONG ConsoleID; /* The ID of the console */ + LIST_ENTRY ListEntry; /* Entry in the list of consoles */ /**************************** Input buffer and data ***************************/ CONSOLE_INPUT_BUFFER InputBuffer; /* Input buffer of the console */ @@ -296,13 +297,6 @@ LIST_ENTRY BufferList; /* List of all screen buffers for this console */ PCONSOLE_SCREEN_BUFFER ActiveBuffer; /* Pointer to currently active screen buffer */ UINT OutputCodePage; - -/**************************** Aliases and Histories ***************************/ - struct _ALIAS_HEADER *Aliases; - LIST_ENTRY HistoryBuffers; - ULONG HistoryBufferSize; /* Size for newly created history buffers */ - ULONG NumberOfHistoryBuffers; /* Maximum number of history buffers allowed */ - BOOLEAN HistoryNoDup; /* Remove old duplicate history entries */ /****************************** Other properties ******************************/ UNICODE_STRING OriginalTitle; /* Original title of console, the one defined when the console leader is launched; it never changes. Always NULL-terminated */ Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/include/conio_winsrv.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user… ============================================================================== --- branches/condrv_restructure/win32ss/user/winsrv/consrv/include/conio_winsrv.h [iso-8859-1] (original) +++ branches/condrv_restructure/win32ss/user/winsrv/consrv/include/conio_winsrv.h [iso-8859-1] Sun May 4 00:01:48 2014 @@ -109,15 +109,24 @@ FRONTEND FrontEndIFace; /* Frontend-specific interface */ +/******************************* Process support ******************************/ LIST_ENTRY ProcessList; /* List of processes owning the console. The first one is the so-called "Console Leader Process" */ PCONSOLE_PROCESS_DATA NotifiedLastCloseProcess; /* Pointer to the unique process that needs to be notified when the console leader process is killed */ BOOLEAN NotifyLastClose; /* TRUE if the console should send a control event when the console leader process is killed */ BOOLEAN QuickEdit; +/******************************* Pausing support ******************************/ BYTE PauseFlags; LIST_ENTRY ReadWaitQueue; /* List head for the queue of unique input buffer read wait blocks */ LIST_ENTRY WriteWaitQueue; /* List head for the queue of current screen-buffer write wait blocks */ + +/**************************** Aliases and Histories ***************************/ + struct _ALIAS_HEADER *Aliases; + LIST_ENTRY HistoryBuffers; + ULONG HistoryBufferSize; /* Size for newly created history buffers */ + ULONG NumberOfHistoryBuffers; /* Maximum number of history buffers allowed */ + BOOLEAN HistoryNoDup; /* Remove old duplicate history entries */ } WINSRV_CONSOLE, *PWINSRV_CONSOLE; Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/include/console.h URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user… ============================================================================== --- branches/condrv_restructure/win32ss/user/winsrv/consrv/include/console.h [iso-8859-1] (original) +++ branches/condrv_restructure/win32ss/user/winsrv/consrv/include/console.h [iso-8859-1] Sun May 4 00:01:48 2014 @@ -12,10 +12,8 @@ ConDrvInitConsoleSupport(VOID); NTSTATUS NTAPI -ConDrvInitConsole(OUT PHANDLE NewConsoleHandle, - OUT PCONSOLE* NewConsole, - IN PCONSOLE_INFO ConsoleInfo, - IN ULONG ConsoleLeaderProcessId); +ConDrvInitConsole(OUT PCONSOLE* NewConsole, + IN PCONSOLE_INFO ConsoleInfo); NTSTATUS NTAPI ConDrvRegisterTerminal(IN PCONSOLE Console, IN PTERMINAL Terminal); @@ -35,20 +33,4 @@ IN CONSOLE_STATE ExpectedState, IN BOOLEAN LockConsole); -BOOLEAN NTAPI -ConDrvValidateConsole(OUT PCONSOLE* Console, - IN HANDLE ConsoleHandle, - IN CONSOLE_STATE ExpectedState, - IN BOOLEAN LockConsole); - - - -NTSTATUS NTAPI -ConDrvGetConsole(OUT PCONSOLE* Console, - IN HANDLE ConsoleHandle, - IN BOOLEAN LockConsole); -VOID NTAPI -ConDrvReleaseConsole(IN PCONSOLE Console, - IN BOOLEAN WasConsoleLocked); - /* EOF */ Modified: branches/condrv_restructure/win32ss/user/winsrv/consrv/init.c URL: http://svn.reactos.org/svn/reactos/branches/condrv_restructure/win32ss/user… ============================================================================== --- branches/condrv_restructure/win32ss/user/winsrv/consrv/init.c [iso-8859-1] (original) +++ branches/condrv_restructure/win32ss/user/winsrv/consrv/init.c [iso-8859-1] Sun May 4 00:01:48 2014 @@ -353,7 +353,7 @@ /* Initialize the new (target) process */ RtlZeroMemory(TargetProcessData, sizeof(*TargetProcessData)); TargetProcessData->Process = TargetProcess; - TargetProcessData->ConsoleEvent = NULL; + TargetProcessData->InputWaitHandle = NULL; TargetProcessData->ConsoleHandle = TargetProcessData->ParentConsoleHandle = NULL; TargetProcessData->ConsoleApp = ((TargetProcess->Flags & CsrProcessIsConsoleApp) ? TRUE : FALSE); @@ -383,7 +383,7 @@ PCONSOLE SourceConsole; /* Validate and lock the parent's console */ - if (ConDrvValidateConsole(&SourceConsole, + if (ConSrvValidateConsole(&SourceConsole, SourceProcessData->ConsoleHandle, CONSOLE_RUNNING, TRUE)) { @@ -484,7 +484,7 @@ /* Return the console handle and the input wait handle to the caller */ ConnectInfo->ConsoleHandle = ProcessData->ConsoleHandle; - ConnectInfo->InputWaitHandle = ProcessData->ConsoleEvent; + ConnectInfo->InputWaitHandle = ProcessData->InputWaitHandle; /* Set the Property-Dialog and Control-Dispatcher handlers */ ProcessData->PropDispatcher = ConnectInfo->ConsoleStartInfo.PropDispatcher; @@ -529,6 +529,7 @@ */ ConDrvInitConsoleSupport(); + ConSrvInitConsoleSupport(); /* Setup the DLL Object */ LoadedServerDll->ApiBase = CONSRV_FIRST_API_NUMBER;

1 0

[hbelusca] 63140: [EXPLORER] Do not hide file extensions by default. A side effect is that it will make zz_word_viewer_2003:2.copy_text test going further.
by hbelusca＠svn.reactos.org 03 May '14

03 May '14

Author: hbelusca Date: Sat May 3 21:16:19 2014 New Revision: 63140 URL: http://svn.reactos.org/svn/reactos?rev=63140&view=rev Log: [EXPLORER] Do not hide file extensions by default. A side effect is that it will make zz_word_viewer_2003:2.copy_text test going further. Modified: trunk/reactos/boot/bootdata/hivedef.inf Modified: trunk/reactos/boot/bootdata/hivedef.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivedef.inf?… ============================================================================== --- trunk/reactos/boot/bootdata/hivedef.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivedef.inf [iso-8859-1] Sat May 3 21:16:19 2014 @@ -1636,7 +1636,8 @@ HKCU,"SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\HideDesktopIcons\ClassicStartMenu",,0x00000012 HKCU,"SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\HideDesktopIcons\ClassicStartMenu","{208D2C60-3AEA-1069-A2D7-08002B30309D}",0x00010001,0x00000000 HKCU,"SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\CLSID\{20D04FE0-3AEA-1069-A2D8-08002B30309D}",,0x00000012 -HKCU,"SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Advanced","ListviewShadow",0x00010001,0x1 +HKCU,"SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Advanced","ListviewShadow",0x00010001,0x00000001 +HKCU,"SOFTWARE\Microsoft\Windows\CurrentVersion\Explorer\Advanced","HideFileExt",0x00010001,0x00000000 ; default shell HKCU,"SOFTWARE\Microsoft\Windows NT\CurrentVersion\Winlogon",,0x00000012

1 0

[pschweitzer] 63139: [PIPEREAD] Prevent null buffer dereference
by pschweitzer＠svn.reactos.org 03 May '14

03 May '14

Author: pschweitzer Date: Sat May 3 18:52:00 2014 New Revision: 63139 URL: http://svn.reactos.org/svn/reactos?rev=63139&view=rev Log: [PIPEREAD] Prevent null buffer dereference Modified: trunk/reactos/tools/pipetools/piperead.cpp Modified: trunk/reactos/tools/pipetools/piperead.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/pipetools/piperead.c… ============================================================================== --- trunk/reactos/tools/pipetools/piperead.cpp [iso-8859-1] (original) +++ trunk/reactos/tools/pipetools/piperead.cpp [iso-8859-1] Sat May 3 18:52:00 2014 @@ -196,8 +196,8 @@ case 3: clientMode = *++argv; if (strcmp(clientMode,"-c") != 0) { + fprintf(stderr,"Invalid option: %s\n", clientMode); clientMode = NULL; - fprintf(stderr,"Invalid option: %s\n", clientMode); res = -6; } //fall through

1 0

[hbelusca] 63138: [CMD] Fix _tcsncat usage. Patch by Victor Martinez. CORE-8149 #resolve
by hbelusca＠svn.reactos.org 03 May '14

03 May '14

Author: hbelusca Date: Sat May 3 18:07:07 2014 New Revision: 63138 URL: http://svn.reactos.org/svn/reactos?rev=63138&view=rev Log: [CMD] Fix _tcsncat usage. Patch by Victor Martinez. CORE-8149 #resolve Modified: trunk/reactos/base/shell/cmd/cmd.c Modified: trunk/reactos/base/shell/cmd/cmd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/cmd.c?rev=6… ============================================================================== --- trunk/reactos/base/shell/cmd/cmd.c [iso-8859-1] (original) +++ trunk/reactos/base/shell/cmd/cmd.c [iso-8859-1] Sat May 3 18:07:07 2014 @@ -397,13 +397,13 @@ /* build command line for CreateProcess(): FullName + " " + rest */ BOOL quoted = !!_tcschr(First, ' '); _tcscpy(szFullCmdLine, quoted ? _T("\"") : _T("")); - _tcsncat(szFullCmdLine, First, CMDLINE_LENGTH - _tcslen(szFullCmdLine)); - _tcsncat(szFullCmdLine, quoted ? _T("\"") : _T(""), CMDLINE_LENGTH - _tcslen(szFullCmdLine)); + _tcsncat(szFullCmdLine, First, CMDLINE_LENGTH - _tcslen(szFullCmdLine) - 1); + _tcsncat(szFullCmdLine, quoted ? _T("\"") : _T(""), CMDLINE_LENGTH - _tcslen(szFullCmdLine) - 1); if (*rest) { - _tcsncat(szFullCmdLine, _T(" "), CMDLINE_LENGTH - _tcslen(szFullCmdLine)); - _tcsncat(szFullCmdLine, rest, CMDLINE_LENGTH - _tcslen(szFullCmdLine)); + _tcsncat(szFullCmdLine, _T(" "), CMDLINE_LENGTH - _tcslen(szFullCmdLine) - 1); + _tcsncat(szFullCmdLine, rest, CMDLINE_LENGTH - _tcslen(szFullCmdLine) - 1); } TRACE ("[EXEC: %s]\n", debugstr_aw(szFullCmdLine));

1 0

[hbelusca] 63137: [IPCONFIG] Fix lines inversion, based on a patch by Victor Martinez. CORE-8146 #resolve
by hbelusca＠svn.reactos.org 03 May '14

03 May '14

Author: hbelusca Date: Sat May 3 17:58:26 2014 New Revision: 63137 URL: http://svn.reactos.org/svn/reactos?rev=63137&view=rev Log: [IPCONFIG] Fix lines inversion, based on a patch by Victor Martinez. CORE-8146 #resolve Modified: trunk/reactos/base/applications/network/ftp/cmds.c trunk/reactos/base/applications/network/ipconfig/ipconfig.c Modified: trunk/reactos/base/applications/network/ftp/cmds.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… ============================================================================== --- trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] Sat May 3 17:58:26 2014 @@ -1309,7 +1309,7 @@ for (i=1; i<argc; i++) { strncat(CmdLine, " ", MAX_PATH - strlen(CmdLine) - 1); - strncat(CmdLine, argv[i], MAX_PATH - strlen(CmdLine) -1); + strncat(CmdLine, argv[i], MAX_PATH - strlen(CmdLine) - 1); } StartupInfo.cb = sizeof( StartupInfo ); Modified: trunk/reactos/base/applications/network/ipconfig/ipconfig.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… ============================================================================== --- trunk/reactos/base/applications/network/ipconfig/ipconfig.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/network/ipconfig/ipconfig.c [iso-8859-1] Sat May 3 17:58:26 2014 @@ -333,8 +333,8 @@ (PBYTE)lpKeyClass, &dwDataSize) != ERROR_SUCCESS) { + HeapFree(ProcessHeap, 0, lpKeyClass); lpKeyClass = NULL; - HeapFree(ProcessHeap, 0, lpKeyClass); continue; } }

1 0

[hbelusca] 63136: ... and also, please open your eyes (upper vs. lowercase letters).
by hbelusca＠svn.reactos.org 03 May '14

03 May '14

Author: hbelusca Date: Sat May 3 17:25:52 2014 New Revision: 63136 URL: http://svn.reactos.org/svn/reactos?rev=63136&view=rev Log: ... and also, please open your eyes (upper vs. lowercase letters). Modified: trunk/reactos/base/applications/network/ftp/cmds.c Modified: trunk/reactos/base/applications/network/ftp/cmds.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… ============================================================================== --- trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] Sat May 3 17:25:52 2014 @@ -1303,13 +1303,13 @@ if (argc > 1) { - strncat(CmdLine, " /C", MAX_PATH - strlen(Cmdline) - 1); + strncat(CmdLine, " /C", MAX_PATH - strlen(CmdLine) - 1); } for (i=1; i<argc; i++) { - strncat(CmdLine, " ", MAX_PATH - strlen(Cmdline) - 1); - strncat(CmdLine, argv[i], MAX_PATH - strlen(Cmdline) -1); + strncat(CmdLine, " ", MAX_PATH - strlen(CmdLine) - 1); + strncat(CmdLine, argv[i], MAX_PATH - strlen(CmdLine) -1); } StartupInfo.cb = sizeof( StartupInfo );

1 0

[hbelusca] 63135: Arch, please do not mix up ANSI vs. UNICODE string functions, do you?
by hbelusca＠svn.reactos.org 03 May '14

03 May '14

Author: hbelusca Date: Sat May 3 17:24:22 2014 New Revision: 63135 URL: http://svn.reactos.org/svn/reactos?rev=63135&view=rev Log: Arch, please do not mix up ANSI vs. UNICODE string functions, do you? Modified: trunk/reactos/base/applications/network/ftp/cmds.c Modified: trunk/reactos/base/applications/network/ftp/cmds.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… ============================================================================== --- trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] Sat May 3 17:24:22 2014 @@ -1303,13 +1303,13 @@ if (argc > 1) { - strncat(CmdLine, " /C", MAX_PATH - wcslen(Cmdline) - 1); + strncat(CmdLine, " /C", MAX_PATH - strlen(Cmdline) - 1); } for (i=1; i<argc; i++) { - strncat(CmdLine, " ", MAX_PATH - wsclen(Cmdline) - 1); - strncat(CmdLine, argv[i], MAX_PATH - wsclen(Cmdline) -1); + strncat(CmdLine, " ", MAX_PATH - strlen(Cmdline) - 1); + strncat(CmdLine, argv[i], MAX_PATH - strlen(Cmdline) -1); } StartupInfo.cb = sizeof( StartupInfo );

1 0

[hbelusca] 63134: [FTP] Fix some strncat usage. Patch by Victor Martinez. CORE-8145 #resolve
by hbelusca＠svn.reactos.org 03 May '14

03 May '14

Author: hbelusca Date: Sat May 3 17:22:35 2014 New Revision: 63134 URL: http://svn.reactos.org/svn/reactos?rev=63134&view=rev Log: [FTP] Fix some strncat usage. Patch by Victor Martinez. CORE-8145 #resolve Modified: trunk/reactos/base/applications/network/ftp/cmds.c Modified: trunk/reactos/base/applications/network/ftp/cmds.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/network/… ============================================================================== --- trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/network/ftp/cmds.c [iso-8859-1] Sat May 3 17:22:35 2014 @@ -1303,13 +1303,13 @@ if (argc > 1) { - strncat(CmdLine, " /C", MAX_PATH); + strncat(CmdLine, " /C", MAX_PATH - wcslen(Cmdline) - 1); } for (i=1; i<argc; i++) { - strncat(CmdLine, " ", MAX_PATH); - strncat(CmdLine, argv[i], MAX_PATH); + strncat(CmdLine, " ", MAX_PATH - wsclen(Cmdline) - 1); + strncat(CmdLine, argv[i], MAX_PATH - wsclen(Cmdline) -1); } StartupInfo.cb = sizeof( StartupInfo );

1 0

[hbelusca] 63133: [APITEST:USER32] Fix problematic for() loops. Patch by Victor Martinez Calvo, thanks :) ROSTESTS-136 #resolve
by hbelusca＠svn.reactos.org 03 May '14

03 May '14

Author: hbelusca Date: Sat May 3 17:08:39 2014 New Revision: 63133 URL: http://svn.reactos.org/svn/reactos?rev=63133&view=rev Log: [APITEST:USER32] Fix problematic for() loops. Patch by Victor Martinez Calvo, thanks :) ROSTESTS-136 #resolve Modified: trunk/rostests/apitests/user32/AttachThreadInput.c Modified: trunk/rostests/apitests/user32/AttachThreadInput.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/user32/AttachThr… ============================================================================== --- trunk/rostests/apitests/user32/AttachThreadInput.c [iso-8859-1] (original) +++ trunk/rostests/apitests/user32/AttachThreadInput.c [iso-8859-1] Sat May 3 17:08:39 2014 @@ -217,9 +217,9 @@ int i,j; BOOL ret; - for(i = 0; i< 4; i++); - { - for(j = 0; j< 4; j++); + for(i = 0; i< 4; i++) + { + for(j = 0; j< 4; j++) { ret = AttachThreadInput(data[i].tid,data[j].tid, FALSE); ok(ret==0, "expected AttachThreadInput to fail\n");

1 0

← Newer
1
...
36
37
38
39
40
41
42
43
44
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs May 2014