Author: tfaber
Date: Sun Jun 29 11:32:49 2014
New Revision: 63664
URL: http://svn.reactos.org/svn/reactos?rev=63664&view=rev
Log:
[SPEC2DEF]
- Do not include an export's ordinal in the .def file for the import lib unless import by ordinal is intended (via -noname or -ordinal). MSVC will always import by ordinal if it finds one in the def file, which would break apps on different versions of Windows if applied to the wrong functions.
Modified:
trunk/reactos/tools/spec2def/spec2def.c
Modified: trunk/reactos/tools/spec2def/spec2def.c
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/spec2def/spec2def.c?…
==============================================================================
--- trunk/reactos/tools/spec2def/spec2def.c [iso-8859-1] (original)
+++ trunk/reactos/tools/spec2def/spec2def.c [iso-8859-1] Sun Jun 29 11:32:49 2014
@@ -569,7 +569,9 @@
else
{
exp.nOrdinal = atol(pc);
- exp.uFlags |= FL_ORDINAL;
+ /* The import lib should contain the ordinal only if -ordinal was specified */
+ if (!gbImportLib)
+ exp.uFlags |= FL_ORDINAL;
}
/* Go to next token (type) */