Ros-diffs September 2014

ros-diffs@reactos.org

16 participants
413 discussions

[akhaldi] 64070: [CRT/MATH] * Use the GCC version if inline assembly in ldexp() as it works with Clang too.
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 18:13:52 2014 New Revision: 64070 URL: http://svn.reactos.org/svn/reactos?rev=64070&view=rev Log: [CRT/MATH] * Use the GCC version if inline assembly in ldexp() as it works with Clang too. Modified: trunk/reactos/lib/sdk/crt/math/i386/ldexp.c Modified: trunk/reactos/lib/sdk/crt/math/i386/ldexp.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/math/i386/ldex… ============================================================================== --- trunk/reactos/lib/sdk/crt/math/i386/ldexp.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/math/i386/ldexp.c [iso-8859-1] Sun Sep 7 18:13:52 2014 @@ -39,18 +39,10 @@ } #ifdef __GNUC__ -#if defined(__clang__) - asm ("fild %[exp]\n" - "fscale\n" - "fstp %%st(1)\n" - : [result] "=t" (result) - : [value] "0" (value), [exp] "m" (exp)); -#else asm ("fscale" : "=t" (result) : "0" (value), "u" ((double)exp) : "1"); -#endif #else /* !__GNUC__ */ __asm {

1 0

[cwittich] 64069: [crt] add null check (for ntdll only) fixes remaining test failure in ntdll:string
by cwittich＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: cwittich Date: Sun Sep 7 18:11:50 2014 New Revision: 64069 URL: http://svn.reactos.org/svn/reactos?rev=64069&view=rev Log: [crt] add null check (for ntdll only) fixes remaining test failure in ntdll:string Modified: trunk/reactos/lib/sdk/crt/printf/streamout.c Modified: trunk/reactos/lib/sdk/crt/printf/streamout.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/printf/streamo… ============================================================================== --- trunk/reactos/lib/sdk/crt/printf/streamout.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/printf/streamout.c [iso-8859-1] Sun Sep 7 18:11:50 2014 @@ -227,6 +227,11 @@ int streamout_char(FILE *stream, int chr) { +#ifdef _LIBCNT_ + if ((stream->_flag & _IOSTRG) && (!stream->_ptr)) + return 1; +#endif + #if defined(_USER32_WSPRINTF) || defined(_LIBCNT_) /* Check if the buffer is full */ if (stream->_cnt < sizeof(TCHAR))

1 0

[cwittich] 64068: [apitests/crt] pass the correct buffer size
by cwittich＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: cwittich Date: Sun Sep 7 18:11:08 2014 New Revision: 64068 URL: http://svn.reactos.org/svn/reactos?rev=64068&view=rev Log: [apitests/crt] pass the correct buffer size Modified: trunk/rostests/apitests/crt/_vsnprintf.c Modified: trunk/rostests/apitests/crt/_vsnprintf.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/crt/_vsnprintf.c… ============================================================================== --- trunk/rostests/apitests/crt/_vsnprintf.c [iso-8859-1] (original) +++ trunk/rostests/apitests/crt/_vsnprintf.c [iso-8859-1] Sun Sep 7 18:11:08 2014 @@ -19,7 +19,7 @@ int ret; /* Test the basic functionality */ va_start(args, formatString); - ret = _vsnprintf(buf, 255, formatString, args); + ret = _vsnprintf(buf, buf_size, formatString, args); ok(expected_ret == ret, "Test failed: expected %i, got %i.\n", expected_ret, ret); }

1 0

[akhaldi] 64067: [CRT] * Use gas to compile except/cpp.c until http://llvm.org/bugs/show_bug.cgi?id=19027 is fixed.
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 17:44:24 2014 New Revision: 64067 URL: http://svn.reactos.org/svn/reactos?rev=64067&view=rev Log: [CRT] * Use gas to compile except/cpp.c until http://llvm.org/bugs/show_bug.cgi?id=19027 is fixed. Modified: trunk/reactos/lib/sdk/crt/crt.cmake Modified: trunk/reactos/lib/sdk/crt/crt.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/crt.cmake?rev=… ============================================================================== --- trunk/reactos/lib/sdk/crt/crt.cmake [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/crt.cmake [iso-8859-1] Sun Sep 7 17:44:24 2014 @@ -510,6 +510,11 @@ set_source_files_properties(${CRT_ASM_SOURCE} PROPERTIES COMPILE_DEFINITIONS "__MINGW_IMPORT=extern;USE_MSVCRT_PREFIX;_MSVCRT_LIB_;_MSVCRT_;_MT;CRTDLL") add_asm_files(crt_asm ${CRT_ASM_SOURCE}) +if(CMAKE_C_COMPILER_ID STREQUAL "Clang") + #FIXME: http://llvm.org/bugs/show_bug.cgi?id=19027 + set_property(SOURCE except/cpp.c APPEND_STRING PROPERTY COMPILE_FLAGS " -no-integrated-as") +endif() + add_library(crt ${CRT_SOURCE} ${crt_asm}) target_link_libraries(crt chkstk) add_target_compile_definitions(crt

1 0

[akhaldi] 64066: [NTSTRSAFE] * Don't mark varags functions as stdcall.
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 17:30:44 2014 New Revision: 64066 URL: http://svn.reactos.org/svn/reactos?rev=64066&view=rev Log: [NTSTRSAFE] * Don't mark varags functions as stdcall. Modified: trunk/reactos/include/ddk/ntstrsafe.h Modified: trunk/reactos/include/ddk/ntstrsafe.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/ddk/ntstrsafe.h?re… ============================================================================== --- trunk/reactos/include/ddk/ntstrsafe.h [iso-8859-1] (original) +++ trunk/reactos/include/ddk/ntstrsafe.h [iso-8859-1] Sun Sep 7 17:30:44 2014 @@ -919,21 +919,21 @@ return RtlStringVPrintfWorkerW(pszDest,cchDest,pszFormat,argList); } -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCchPrintfA( _Out_writes_(cchDest) _Always_(_Post_z_) NTSTRSAFE_PSTR pszDest, _In_ size_t cchDest, _In_ _Printf_format_string_ NTSTRSAFE_PCSTR pszFormat, ...); -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCchPrintfW( _Out_writes_(cchDest) _Always_(_Post_z_) NTSTRSAFE_PWSTR pszDest, _In_ size_t cchDest, _In_ _Printf_format_string_ NTSTRSAFE_PCWSTR pszFormat, ...); -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCchPrintfA( _Out_writes_(cchDest) _Always_(_Post_z_) NTSTRSAFE_PSTR pszDest, _In_ size_t cchDest, @@ -950,7 +950,7 @@ return Status; } -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCchPrintfW( _Out_writes_(cchDest) _Always_(_Post_z_) NTSTRSAFE_PWSTR pszDest, _In_ size_t cchDest, @@ -967,21 +967,21 @@ return Status; } -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCbPrintfA( _Out_writes_bytes_(cbDest) _Always_(_Post_z_) NTSTRSAFE_PSTR pszDest, _In_ size_t cbDest, _In_ _Printf_format_string_ NTSTRSAFE_PCSTR pszFormat, ...); -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCbPrintfW( _Out_writes_bytes_(cbDest) _Always_(_Post_z_) NTSTRSAFE_PWSTR pszDest, _In_ size_t cbDest, _In_ _Printf_format_string_ NTSTRSAFE_PCWSTR pszFormat, ...); -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCbPrintfA( _Out_writes_bytes_(cbDest) _Always_(_Post_z_) NTSTRSAFE_PSTR pszDest, _In_ size_t cbDest, @@ -998,7 +998,7 @@ return Status; } -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCbPrintfW( _Out_writes_bytes_(cbDest) _Always_(_Post_z_) NTSTRSAFE_PWSTR pszDest, _In_ size_t cbDest, @@ -1016,7 +1016,7 @@ return Status; } -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCchPrintfExA( _Out_writes_(cchDest) _Always_(_Post_z_) NTSTRSAFE_PSTR pszDest, _In_ size_t cchDest, @@ -1026,7 +1026,7 @@ _In_ _Printf_format_string_ NTSTRSAFE_PCSTR pszFormat, ...); -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCchPrintfExW( _Out_writes_(cchDest) _Always_(_Post_z_) NTSTRSAFE_PWSTR pszDest, _In_ size_t cchDest, @@ -1036,7 +1036,7 @@ _In_ _Printf_format_string_ NTSTRSAFE_PCWSTR pszFormat, ...); -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCchPrintfExA( _Out_writes_(cchDest) _Always_(_Post_z_) NTSTRSAFE_PSTR pszDest, _In_ size_t cchDest, @@ -1056,7 +1056,7 @@ return Status; } -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCchPrintfExW( _Out_writes_(cchDest) _Always_(_Post_z_) NTSTRSAFE_PWSTR pszDest, _In_ size_t cchDest, @@ -1077,7 +1077,7 @@ return Status; } -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCbPrintfExA( _Out_writes_bytes_(cbDest) _Always_(_Post_z_) NTSTRSAFE_PSTR pszDest, _In_ size_t cbDest, @@ -1087,7 +1087,7 @@ _In_ _Printf_format_string_ NTSTRSAFE_PCSTR pszFormat, ...); -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCbPrintfExW( _Out_writes_bytes_(cbDest) _Always_(_Post_z_) NTSTRSAFE_PWSTR pszDest, _In_ size_t cbDest, @@ -1097,7 +1097,7 @@ _In_ _Printf_format_string_ NTSTRSAFE_PCWSTR pszFormat, ...); -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCbPrintfExA( _Out_writes_bytes_(cbDest) _Always_(_Post_z_) NTSTRSAFE_PSTR pszDest, _In_ size_t cbDest, @@ -1130,7 +1130,7 @@ return Status; } -NTSTRSAFEAPI +static __inline NTSTATUS RtlStringCbPrintfExW( _Out_writes_bytes_(cbDest) _Always_(_Post_z_) NTSTRSAFE_PWSTR pszDest, _In_ size_t cbDest,

1 0

[akhaldi] 64065: [PSEH3] * Enable PSEH for Clang builds.
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 17:24:08 2014 New Revision: 64065 URL: http://svn.reactos.org/svn/reactos?rev=64065&view=rev Log: [PSEH3] * Enable PSEH for Clang builds. Modified: trunk/reactos/include/reactos/libs/pseh/pseh2.h Modified: trunk/reactos/include/reactos/libs/pseh/pseh2.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/reactos/libs/pseh/… ============================================================================== --- trunk/reactos/include/reactos/libs/pseh/pseh2.h [iso-8859-1] (original) +++ trunk/reactos/include/reactos/libs/pseh/pseh2.h [iso-8859-1] Sun Sep 7 17:24:08 2014 @@ -37,7 +37,7 @@ #define _SEH2_LEAVE __leave #define _SEH2_VOLATILE -#elif defined(_USE_DUMMY_PSEH) || defined (__arm__) || defined(__clang__) || defined(_M_AMD64) +#elif defined(_USE_DUMMY_PSEH) || defined (__arm__) || defined(_M_AMD64) extern int _SEH2_Volatile0; extern int _SEH2_VolatileExceptionCode;

1 0

[akhaldi] 64064: [CMAKE/CLANG] * Properly set CMAKE_STATIC_LIBRARY_SUFFIX and CMAKE_LINK_LIBRARY_SUFFIX for Clang builds.
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 17:19:14 2014 New Revision: 64064 URL: http://svn.reactos.org/svn/reactos?rev=64064&view=rev Log: [CMAKE/CLANG] * Properly set CMAKE_STATIC_LIBRARY_SUFFIX and CMAKE_LINK_LIBRARY_SUFFIX for Clang builds. Modified: trunk/reactos/cmake/gcc.cmake Modified: trunk/reactos/cmake/gcc.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/cmake/gcc.cmake?rev=64064&… ============================================================================== --- trunk/reactos/cmake/gcc.cmake [iso-8859-1] (original) +++ trunk/reactos/cmake/gcc.cmake [iso-8859-1] Sun Sep 7 17:19:14 2014 @@ -35,6 +35,8 @@ add_compile_flags_language("-std=gnu89" "C") add_compile_flags("-Wno-microsoft") set(CMAKE_LINK_DEF_FILE_FLAG "") + set(CMAKE_STATIC_LIBRARY_SUFFIX ".a") + set(CMAKE_LINK_LIBRARY_SUFFIX "") endif() if(DBG)

1 0

[akhaldi] 64063: [SAL] * Add some missing _Check_return_ annotations.
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 17:10:44 2014 New Revision: 64063 URL: http://svn.reactos.org/svn/reactos?rev=64063&view=rev Log: [SAL] * Add some missing _Check_return_ annotations. Modified: trunk/reactos/include/crt/stdlib.h Modified: trunk/reactos/include/crt/stdlib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/stdlib.h?rev=6… ============================================================================== --- trunk/reactos/include/crt/stdlib.h [iso-8859-1] (original) +++ trunk/reactos/include/crt/stdlib.h [iso-8859-1] Sun Sep 7 17:10:44 2014 @@ -1202,6 +1202,7 @@ _In_ int _Shift); #if _INTEGRAL_MAX_BITS >= 64 + _Check_return_ __MINGW_EXTENSION unsigned __int64 __cdecl @@ -1217,6 +1218,7 @@ _In_ int _Shift); #if _INTEGRAL_MAX_BITS >= 64 + _Check_return_ __MINGW_EXTENSION unsigned __int64 __cdecl

1 0

[akhaldi] 64062: [CRT/INTRIN_X86] * Skip some intrinsics when compiling with Clang.
by akhaldi＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: akhaldi Date: Sun Sep 7 17:09:34 2014 New Revision: 64062 URL: http://svn.reactos.org/svn/reactos?rev=64062&view=rev Log: [CRT/INTRIN_X86] * Skip some intrinsics when compiling with Clang. Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h Modified: trunk/reactos/include/crt/mingw32/intrin_x86.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/include/crt/mingw32/intrin… ============================================================================== --- trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] (original) +++ trunk/reactos/include/crt/mingw32/intrin_x86.h [iso-8859-1] Sun Sep 7 17:09:34 2014 @@ -190,16 +190,18 @@ } #ifndef __clang__ + __INTRIN_INLINE long _InterlockedCompareExchange(volatile long * const Destination, const long Exchange, const long Comperand) { return __sync_val_compare_and_swap(Destination, Comperand, Exchange); } -#endif __INTRIN_INLINE void * _InterlockedCompareExchangePointer(void * volatile * const Destination, void * const Exchange, void * const Comperand) { return (void *)__sync_val_compare_and_swap(Destination, Comperand, Exchange); } + +#endif __INTRIN_INLINE char _InterlockedExchange8(volatile char * const Target, const char Value) { @@ -215,6 +217,8 @@ return __sync_lock_test_and_set(Target, Value); } +#ifndef __clang__ + __INTRIN_INLINE long _InterlockedExchange(volatile long * const Target, const long Value) { /* NOTE: __sync_lock_test_and_set would be an acquire barrier, so we force a full barrier */ @@ -222,6 +226,15 @@ return __sync_lock_test_and_set(Target, Value); } +__INTRIN_INLINE void * _InterlockedExchangePointer(void * volatile * const Target, void * const Value) +{ + /* NOTE: __sync_lock_test_and_set would be an acquire barrier, so we force a full barrier */ + __sync_synchronize(); + return (void *)__sync_lock_test_and_set(Target, Value); +} + +#endif + #if defined(_M_AMD64) __INTRIN_INLINE long long _InterlockedExchange64(volatile long long * const Target, const long long Value) { @@ -230,13 +243,6 @@ return __sync_lock_test_and_set(Target, Value); } #endif - -__INTRIN_INLINE void * _InterlockedExchangePointer(void * volatile * const Target, void * const Value) -{ - /* NOTE: __sync_lock_test_and_set would be an acquire barrier, so we force a full barrier */ - __sync_synchronize(); - return (void *)__sync_lock_test_and_set(Target, Value); -} __INTRIN_INLINE long _InterlockedExchangeAdd16(volatile short * const Addend, const short Value) {

1 0

[cwittich] 64061: [crt] revert changes to streamout_char
by cwittich＠svn.reactos.org 07 Sep '14

07 Sep '14

Author: cwittich Date: Sun Sep 7 13:55:36 2014 New Revision: 64061 URL: http://svn.reactos.org/svn/reactos?rev=64061&view=rev Log: [crt] revert changes to streamout_char Modified: trunk/reactos/lib/sdk/crt/printf/streamout.c Modified: trunk/reactos/lib/sdk/crt/printf/streamout.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/printf/streamo… ============================================================================== --- trunk/reactos/lib/sdk/crt/printf/streamout.c [iso-8859-1] (original) +++ trunk/reactos/lib/sdk/crt/printf/streamout.c [iso-8859-1] Sun Sep 7 13:55:36 2014 @@ -227,9 +227,6 @@ int streamout_char(FILE *stream, int chr) { - if ((stream->_flag & _IOSTRG) && (!stream->_ptr)) - return 1; - #if defined(_USER32_WSPRINTF) || defined(_LIBCNT_) /* Check if the buffer is full */ if (stream->_cnt < sizeof(TCHAR))

1 0

← Newer
1
...
34
35
36
37
38
39
40
41
42
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2014