Ros-diffs October 2015

ros-diffs@reactos.org

18 participants
347 discussions

[tfaber] 69677: [WIN32K:NTUSER] - In UserAttachThreadInput, copy the CaretInfo structure instead of saving a pointer that may be freed right after CORE-10395 #resolve
by tfaber＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: tfaber Date: Sat Oct 24 15:04:12 2015 New Revision: 69677 URL: http://svn.reactos.org/svn/reactos?rev=69677&view=rev Log: [WIN32K:NTUSER] - In UserAttachThreadInput, copy the CaretInfo structure instead of saving a pointer that may be freed right after CORE-10395 #resolve Modified: trunk/reactos/win32ss/user/ntuser/input.c Modified: trunk/reactos/win32ss/user/ntuser/input.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/input.… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/input.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/input.c [iso-8859-1] Sat Oct 24 15:04:12 2015 @@ -524,7 +524,9 @@ ptiTo->MessageQueue->spwndFocus = ptiFrom->MessageQueue->spwndFocus; ptiTo->MessageQueue->spwndCapture = ptiFrom->MessageQueue->spwndCapture; ptiTo->MessageQueue->QF_flags ^= ((ptiTo->MessageQueue->QF_flags ^ ptiFrom->MessageQueue->QF_flags) & QF_CAPTURELOCKED); - ptiTo->MessageQueue->CaretInfo = ptiFrom->MessageQueue->CaretInfo; + RtlCopyMemory(ptiTo->MessageQueue->CaretInfo, + ptiFrom->MessageQueue->CaretInfo, + sizeof(ptiTo->MessageQueue->CaretInfo)); IntSetFocusMessageQueue(NULL); IntSetFocusMessageQueue(ptiTo->MessageQueue); gptiForeground = ptiTo;

1 0

[tfaber] 69676: [ATL] - Add CComBSTR::operator BSTR. Mark by Mark Jansen. CORE-10394 #resolve
by tfaber＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: tfaber Date: Sat Oct 24 13:26:44 2015 New Revision: 69676 URL: http://svn.reactos.org/svn/reactos?rev=69676&view=rev Log: [ATL] - Add CComBSTR::operator BSTR. Mark by Mark Jansen. CORE-10394 #resolve Modified: trunk/reactos/lib/atl/atlbase.h Modified: trunk/reactos/lib/atl/atlbase.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/atl/atlbase.h?rev=6967… ============================================================================== --- trunk/reactos/lib/atl/atlbase.h [iso-8859-1] (original) +++ trunk/reactos/lib/atl/atlbase.h [iso-8859-1] Sat Oct 24 13:26:44 2015 @@ -941,6 +941,11 @@ ::SysFreeString(m_str); m_str = NULL; } + + operator BSTR () const + { + return m_str; + } }; class CComVariant : public tagVARIANT

1 0

[spetreolle] 69675: [CONFIGURE] NEW_STYLE_BUILD is used for official builds. Enable it.
by spetreolle＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: spetreolle Date: Sat Oct 24 12:30:42 2015 New Revision: 69675 URL: http://svn.reactos.org/svn/reactos?rev=69675&view=rev Log: [CONFIGURE] NEW_STYLE_BUILD is used for official builds. Enable it. Modified: trunk/reactos/configure.cmd Modified: trunk/reactos/configure.cmd URL: http://svn.reactos.org/svn/reactos/trunk/reactos/configure.cmd?rev=69675&r1… ============================================================================== --- trunk/reactos/configure.cmd [iso-8859-1] (original) +++ trunk/reactos/configure.cmd [iso-8859-1] Sat Oct 24 12:30:42 2015 @@ -80,7 +80,7 @@ exit /b ) -set NEW_STYLE_BUILD=0 +set NEW_STYLE_BUILD=1 REM Parse command line parameters :repeat

1 0

[pschweitzer] 69674: [SHELL32] Backport Wine commit: 0efa2331e2f54b81480adeb588972ca16a8dab16 "Fix a cloned pidl leak (Coverity)." by Nikolay Sivov CID 716480
by pschweitzer＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: pschweitzer Date: Sat Oct 24 10:27:40 2015 New Revision: 69674 URL: http://svn.reactos.org/svn/reactos?rev=69674&view=rev Log: [SHELL32] Backport Wine commit: 0efa2331e2f54b81480adeb588972ca16a8dab16 "Fix a cloned pidl leak (Coverity)." by Nikolay Sivov CID 716480 Modified: trunk/reactos/dll/win32/shell32/shlfolder.cpp Modified: trunk/reactos/dll/win32/shell32/shlfolder.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shlfolde… ============================================================================== --- trunk/reactos/dll/win32/shell32/shlfolder.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shlfolder.cpp [iso-8859-1] Sat Oct 24 10:27:40 2015 @@ -664,15 +664,15 @@ if (isEmpty1 && isEmpty2) { - return MAKE_HRESULT(SEVERITY_SUCCESS, 0, 0); + nReturn = MAKE_HRESULT( SEVERITY_SUCCESS, 0, 0 ); } else if (isEmpty1) { - return MAKE_HRESULT(SEVERITY_SUCCESS, 0, (WORD) -1); + nReturn = MAKE_HRESULT( SEVERITY_SUCCESS, 0, (WORD)-1 ); } else if (isEmpty2) { - return MAKE_HRESULT(SEVERITY_SUCCESS, 0, 1); + nReturn = MAKE_HRESULT( SEVERITY_SUCCESS, 0, 1 ); /* optimizing end */ } else if (SUCCEEDED(iface->BindToObject(firstpidl, NULL, IID_PPV_ARG(IShellFolder, &psf)))) {

1 0

[pschweitzer] 69673: [SHELL32] Fix a memory leak CID 1322131
by pschweitzer＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: pschweitzer Date: Sat Oct 24 10:24:37 2015 New Revision: 69673 URL: http://svn.reactos.org/svn/reactos?rev=69673&view=rev Log: [SHELL32] Fix a memory leak CID 1322131 Modified: trunk/reactos/dll/win32/shell32/shellmenu/CMenuToolbars.cpp Modified: trunk/reactos/dll/win32/shell32/shellmenu/CMenuToolbars.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shellmen… ============================================================================== --- trunk/reactos/dll/win32/shell32/shellmenu/CMenuToolbars.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/shellmenu/CMenuToolbars.cpp [iso-8859-1] Sat Oct 24 10:24:37 2015 @@ -1321,6 +1321,7 @@ // If no items were added, show the "empty" placeholder if (DPA_GetPtrCount(dpaSort) == 0) { + DPA_Destroy(dpaSort); return AddPlaceholder(); } @@ -1341,7 +1342,10 @@ hr = m_shellFolder->GetDisplayNameOf(item, SIGDN_NORMALDISPLAY, &sr); if (FAILED_UNEXPECTEDLY(hr)) + { + DPA_Destroy(dpaSort); return hr; + } StrRetToStr(&sr, NULL, &MenuString);

1 0

[pschweitzer] 69672: [SETUPAPI] Partly backport Wine commit: 4d796458d0ed517d45adc57a1aedaf1c3bdde232 "Avoid memory leaks (coverity)." by André Hentschel CID 716469
by pschweitzer＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: pschweitzer Date: Sat Oct 24 10:14:21 2015 New Revision: 69672 URL: http://svn.reactos.org/svn/reactos?rev=69672&view=rev Log: [SETUPAPI] Partly backport Wine commit: 4d796458d0ed517d45adc57a1aedaf1c3bdde232 "Avoid memory leaks (coverity)." by André Hentschel CID 716469 Modified: trunk/reactos/dll/win32/setupapi/queue.c Modified: trunk/reactos/dll/win32/setupapi/queue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/queue.c… ============================================================================== --- trunk/reactos/dll/win32/setupapi/queue.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/setupapi/queue.c [iso-8859-1] Sat Oct 24 10:14:21 2015 @@ -1216,7 +1216,11 @@ SetLastError( ERROR_NOT_ENOUGH_MEMORY ); return FALSE; } - if (!SetupGetStringFieldW( inf_context, 1, inf_source, len, NULL )) return FALSE; + if (!SetupGetStringFieldW( inf_context, 1, inf_source, len, NULL )) + { + HeapFree( GetProcessHeap(), 0, inf_source ); + return FALSE; + } source = inf_source; } else if (!source)

1 0

[pschweitzer] 69671: [SETUPAPI] Fix a memory leak CID 716468
by pschweitzer＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: pschweitzer Date: Sat Oct 24 10:09:44 2015 New Revision: 69671 URL: http://svn.reactos.org/svn/reactos?rev=69671&view=rev Log: [SETUPAPI] Fix a memory leak CID 716468 Modified: trunk/reactos/dll/win32/setupapi/query.c Modified: trunk/reactos/dll/win32/setupapi/query.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/query.c… ============================================================================== --- trunk/reactos/dll/win32/setupapi/query.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/setupapi/query.c [iso-8859-1] Sat Oct 24 10:09:44 2015 @@ -356,7 +356,10 @@ } if (!SetupDiGetActualSectionToInstallW(hinf, source_disks_names, Section, MAX_PATH, NULL, NULL)) + { + HeapFree( GetProcessHeap(), 0, source_id ); return NULL; + } if (!SetupFindFirstLineW( hinf, Section, source_id, context ) && !SetupFindFirstLineW( hinf, source_disks_names, source_id, context ))

1 0

[pschweitzer] 69670: [SETUPAPI] Don't leak memory CID 716460
by pschweitzer＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: pschweitzer Date: Sat Oct 24 10:00:24 2015 New Revision: 69670 URL: http://svn.reactos.org/svn/reactos?rev=69670&view=rev Log: [SETUPAPI] Don't leak memory CID 716460 Modified: trunk/reactos/dll/win32/setupapi/devinst.c Modified: trunk/reactos/dll/win32/setupapi/devinst.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/devinst… ============================================================================== --- trunk/reactos/dll/win32/setupapi/devinst.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/setupapi/devinst.c [iso-8859-1] Sat Oct 24 10:00:24 2015 @@ -5777,6 +5777,8 @@ RegCloseKey(hEnumKey); if (hKey != NULL && hKey != key) RegCloseKey(hKey); + if (DriverKey) + HeapFree(GetProcessHeap(), 0, DriverKey); return key; }

1 0

[pschweitzer] 69669: [SETUPAPI] Fix a memory leak CID 1250296
by pschweitzer＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: pschweitzer Date: Sat Oct 24 09:54:54 2015 New Revision: 69669 URL: http://svn.reactos.org/svn/reactos?rev=69669&view=rev Log: [SETUPAPI] Fix a memory leak CID 1250296 Modified: trunk/reactos/dll/win32/setupapi/devclass.c Modified: trunk/reactos/dll/win32/setupapi/devclass.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/devclas… ============================================================================== --- trunk/reactos/dll/win32/setupapi/devclass.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/setupapi/devclass.c [iso-8859-1] Sat Oct 24 09:54:54 2015 @@ -552,6 +552,9 @@ if (hKey != INVALID_HANDLE_VALUE) RegCloseKey(hKey); + if (Buffer && !ret) + MyFree(Buffer); + return ret; }

1 0

[pschweitzer] 69668: [SETUPAPI] Properly return the machine handle in CM_Connect_MachineW() CID 716459
by pschweitzer＠svn.reactos.org 24 Oct '15

24 Oct '15

Author: pschweitzer Date: Sat Oct 24 09:50:50 2015 New Revision: 69668 URL: http://svn.reactos.org/svn/reactos?rev=69668&view=rev Log: [SETUPAPI] Properly return the machine handle in CM_Connect_MachineW() CID 716459 Modified: trunk/reactos/dll/win32/setupapi/cfgmgr.c Modified: trunk/reactos/dll/win32/setupapi/cfgmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/cfgmgr.… ============================================================================== --- trunk/reactos/dll/win32/setupapi/cfgmgr.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/setupapi/cfgmgr.c [iso-8859-1] Sat Oct 24 09:50:50 2015 @@ -555,7 +555,7 @@ } } - phMachine = (PHMACHINE)pMachine; + *phMachine = (PHMACHINE)pMachine; return CR_SUCCESS; }

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
35
Older →

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs October 2015