Author: tfaber
Date: Sun Nov 22 21:13:14 2015
New Revision: 70040
URL: http://svn.reactos.org/svn/reactos?rev=70040&view=rev
Log:
[SHELL][RAPPS_NEW]
- Don't call placement new on static objects. The constructors work just fine.
CORE-10562 #resolve
Modified:
trunk/reactos/base/applications/rapps_new/winmain.cpp
trunk/reactos/base/shell/explorer/explorer.cpp
trunk/reactos/base/shell/rshell/misc.cpp
trunk/reactos/dll/shellext/ntobjshex/ntobjshex.cpp
trunk/reactos/dll/shellext/stobject/stobject.cpp
trunk/reactos/dll/win32/browseui/browseui.cpp
trunk/reactos/dll/win32/shell32/shell32.cpp
Modified: trunk/reactos/base/applications/rapps_new/winmain.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps_ne…
==============================================================================
--- trunk/reactos/base/applications/rapps_new/winmain.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/applications/rapps_new/winmain.cpp [iso-8859-1] Sun Nov 22 21:13:14 2015
@@ -40,12 +40,6 @@
{
if (bInitialize)
{
- /* HACK - the global constructors don't run, so I placement new them here */
- new (&gModule) CRAppsModule;
- new (&gWinModule) CAtlWinModule;
- new (&_AtlBaseModule) CAtlBaseModule;
- new (&_AtlComModule) CAtlComModule;
-
gModule.Init(ObjectMap, hInstance, NULL);
}
else
Modified: trunk/reactos/base/shell/explorer/explorer.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/explor…
==============================================================================
--- trunk/reactos/base/shell/explorer/explorer.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/shell/explorer/explorer.cpp [iso-8859-1] Sun Nov 22 21:13:14 2015
@@ -45,12 +45,6 @@
{
if (bInitialize)
{
- /* HACK - the global constructors don't run, so I placement new them here */
- new (&gModule) CExplorerModule;
- new (&gWinModule) CAtlWinModule;
- new (&_AtlBaseModule) CAtlBaseModule;
- new (&_AtlComModule) CAtlComModule;
-
gModule.Init(ObjectMap, hInstance, NULL);
}
else
Modified: trunk/reactos/base/shell/rshell/misc.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/rshell/misc.cpp…
==============================================================================
--- trunk/reactos/base/shell/rshell/misc.cpp [iso-8859-1] (original)
+++ trunk/reactos/base/shell/rshell/misc.cpp [iso-8859-1] Sun Nov 22 21:13:14 2015
@@ -118,12 +118,6 @@
if (dwReason == DLL_PROCESS_ATTACH)
{
g_hRShell = hInstance;
-
- /* HACK - the global constructors don't run, so I placement new them here */
- new (&gModule) CRShellModule;
- new (&gWinModule) CAtlWinModule;
- new (&_AtlBaseModule) CAtlBaseModule;
- new (&_AtlComModule) CAtlComModule;
gModule.Init(NULL, hInstance, NULL);
DisableThreadLibraryCalls(hInstance);
Modified: trunk/reactos/dll/shellext/ntobjshex/ntobjshex.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/ntobjshex/nto…
==============================================================================
--- trunk/reactos/dll/shellext/ntobjshex/ntobjshex.cpp [iso-8859-1] (original)
+++ trunk/reactos/dll/shellext/ntobjshex/ntobjshex.cpp [iso-8859-1] Sun Nov 22 21:13:14 2015
@@ -33,12 +33,6 @@
g_hInstance = hinstDLL;
DisableThreadLibraryCalls(g_hInstance);
- /* HACK - the global constructors don't run, so I placement new them here */
- new (&g_Module) CComModule;
- new (&_AtlWinModule) CAtlWinModule;
- new (&_AtlBaseModule) CAtlBaseModule;
- new (&_AtlComModule) CAtlComModule;
-
g_Module.Init(ObjectMap, g_hInstance, NULL);
}
else if (fdwReason == DLL_PROCESS_DETACH)
Modified: trunk/reactos/dll/shellext/stobject/stobject.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/stob…
==============================================================================
--- trunk/reactos/dll/shellext/stobject/stobject.cpp [iso-8859-1] (original)
+++ trunk/reactos/dll/shellext/stobject/stobject.cpp [iso-8859-1] Sun Nov 22 21:13:14 2015
@@ -34,12 +34,6 @@
g_hInstance = hinstDLL;
DisableThreadLibraryCalls(g_hInstance);
- /* HACK - the global constructors don't run, so I placement new them here */
- new (&g_Module) CComModule;
- new (&_AtlWinModule) CAtlWinModule;
- new (&_AtlBaseModule) CAtlBaseModule;
- new (&_AtlComModule) CAtlComModule;
-
g_Module.Init(ObjectMap, g_hInstance, NULL);
}
else if (fdwReason == DLL_PROCESS_DETACH)
Modified: trunk/reactos/dll/win32/browseui/browseui.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/browseu…
==============================================================================
--- trunk/reactos/dll/win32/browseui/browseui.cpp [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/browseui/browseui.cpp [iso-8859-1] Sun Nov 22 21:13:14 2015
@@ -60,12 +60,6 @@
if (dwReason == DLL_PROCESS_ATTACH)
{
- /* HACK - the global constructors don't run, so I placement new them here */
- new (&gModule) CBrowseUIModule;
- new (&gWinModule) CAtlWinModule;
- new (&_AtlBaseModule) CAtlBaseModule;
- new (&_AtlComModule) CAtlComModule;
-
gModule.Init(ObjectMap, hInstance, NULL);
DisableThreadLibraryCalls (hInstance);
}
Modified: trunk/reactos/dll/win32/shell32/shell32.cpp
URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/shell32.…
==============================================================================
--- trunk/reactos/dll/win32/shell32/shell32.cpp [iso-8859-1] (original)
+++ trunk/reactos/dll/win32/shell32/shell32.cpp [iso-8859-1] Sun Nov 22 21:13:14 2015
@@ -290,12 +290,6 @@
TRACE("%p 0x%x %p\n", hInstance, dwReason, fImpLoad);
if (dwReason == DLL_PROCESS_ATTACH)
{
- /* HACK - the global constructors don't run, so I placement new them here */
- new (&gModule) CShell32Module;
- new (&_AtlWinModule) CAtlWinModule;
- new (&_AtlBaseModule) CAtlBaseModule;
- new (&_AtlComModule) CAtlComModule;
-
shell32_hInstance = hInstance;
gModule.Init(ObjectMap, hInstance, NULL);