Ros-diffs April 2015

ros-diffs@reactos.org

17 participants
481 discussions

[akhaldi] 67374: [MSTSC] Make the combo box and text box equal sizes. Improve the save as dialog filter. By Jared Smudde. CORE-9596
by akhaldi＠svn.reactos.org 23 Apr '15

23 Apr '15

Author: akhaldi Date: Thu Apr 23 21:44:03 2015 New Revision: 67374 URL: http://svn.reactos.org/svn/reactos?rev=67374&view=rev Log: [MSTSC] Make the combo box and text box equal sizes. Improve the save as dialog filter. By Jared Smudde. CORE-9596 Modified: trunk/reactos/base/applications/mstsc/connectdialog.c trunk/reactos/base/applications/mstsc/lang/bg-BG.rc trunk/reactos/base/applications/mstsc/lang/ca-ES.rc trunk/reactos/base/applications/mstsc/lang/cs-CZ.rc trunk/reactos/base/applications/mstsc/lang/de-DE.rc trunk/reactos/base/applications/mstsc/lang/el-GR.rc trunk/reactos/base/applications/mstsc/lang/en-US.rc trunk/reactos/base/applications/mstsc/lang/es-ES.rc trunk/reactos/base/applications/mstsc/lang/fr-FR.rc trunk/reactos/base/applications/mstsc/lang/he-IL.rc trunk/reactos/base/applications/mstsc/lang/it-IT.rc trunk/reactos/base/applications/mstsc/lang/ja-JP.rc trunk/reactos/base/applications/mstsc/lang/ko-KR.rc trunk/reactos/base/applications/mstsc/lang/lt-LT.rc trunk/reactos/base/applications/mstsc/lang/pl-PL.rc trunk/reactos/base/applications/mstsc/lang/ro-RO.rc trunk/reactos/base/applications/mstsc/lang/ru-RU.rc trunk/reactos/base/applications/mstsc/lang/sk-SK.rc trunk/reactos/base/applications/mstsc/lang/sq-AL.rc trunk/reactos/base/applications/mstsc/lang/sv-SE.rc trunk/reactos/base/applications/mstsc/lang/tr-TR.rc trunk/reactos/base/applications/mstsc/lang/uk-UA.rc trunk/reactos/base/applications/mstsc/lang/zh-CN.rc trunk/reactos/base/applications/mstsc/lang/zh-TW.rc Modified: trunk/reactos/base/applications/mstsc/connectdialog.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/co… ============================================================================== --- trunk/reactos/base/applications/mstsc/connectdialog.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/connectdialog.c [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -34,15 +34,15 @@ DoOpenFile(PINFO pInfo) { OPENFILENAMEW ofn; - WCHAR szFileName[MAX_PATH] = L""; - static WCHAR szFilter[] = L"Remote Desktop Files (*rdp)\0*.rdp\0"; + WCHAR szFileName[MAX_PATH] = L"Default.rdp"; + static WCHAR szFilter[] = L"Remote Desktop Files (*.RDP)\0*.rdp\0"; ZeroMemory(&ofn, sizeof(ofn)); ofn.lStructSize = sizeof(OPENFILENAMEW); ofn.hwndOwner = pInfo->hGeneralPage; ofn.nMaxFile = MAX_PATH; ofn.nMaxFileTitle = MAX_PATH; - ofn.lpstrDefExt = L"rdp"; + ofn.lpstrDefExt = L"RDP"; ofn.lpstrFilter = szFilter; ofn.lpstrFile = szFileName; ofn.Flags = OFN_EXPLORER | OFN_PATHMUSTEXIST; @@ -60,15 +60,15 @@ DoSaveAs(PINFO pInfo) { OPENFILENAMEW ofn; - WCHAR szFileName[MAX_PATH] = L""; - static WCHAR szFilter[] = L"Remote Desktop Files (*rdp)\0*.rdp\0"; + WCHAR szFileName[MAX_PATH] = L"Default.rdp"; + static WCHAR szFilter[] = L"Remote Desktop Files (*.RDP)\0*.rdp\0"; ZeroMemory(&ofn, sizeof(ofn)); ofn.lStructSize = sizeof(OPENFILENAMEW); ofn.hwndOwner = pInfo->hGeneralPage; ofn.nMaxFile = MAX_PATH; ofn.nMaxFileTitle = MAX_PATH; - ofn.lpstrDefExt = L"rdp"; + ofn.lpstrDefExt = L"RDP"; ofn.lpstrFilter = szFilter; ofn.lpstrFile = szFileName; ofn.Flags = OFN_EXPLORER | OFN_PATHMUSTEXIST | OFN_OVERWRITEPROMPT; Modified: trunk/reactos/base/applications/mstsc/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/bg-BG.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/bg-BG.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -10,8 +10,8 @@ LTEXT "ÐÑÐ²ÐµÐ´ÐµÑÐµ Ð°Ð´ÑÐµÑÐ° Ð½Ð° ÑÑÑÐ²ÑÑÐ°.", IDC_STATIC, 47, 24, 150, 8 LTEXT "Ð¡ÑÑÐ²ÑÑ:", IDC_STATIC, 37, 41, 30, 8 LTEXT "ÐÐ¾ÑÑÐµÐ±Ð¸ÑÐµÐ»:", IDC_STATIC, 37, 58, 48, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 79, 55, 141, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "ÐÐ°Ð¿Ð¸Ñ", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "ÐÐ°Ð¿Ð¸Ñ ÐºÐ°ÑÐ¾...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "ÐÑÐ²Ð°ÑÑÐ½Ðµ...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/ca-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/ca-ES.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/ca-ES.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -8,10 +8,10 @@ GROUPBOX "ParÃ metres de connexiÃ³", IDC_STATIC, 7, 103, 228, 65 ICON "", IDC_LOGONICON, 15, 19, 20, 20 LTEXT "Entreu l'adreÃ§a del servidor.", IDC_STATIC, 47, 24, 81, 8 - LTEXT "Servidor:", IDC_STATIC, 47, 41, 25, 8 + LTEXT "Servidor:", IDC_STATIC, 47, 41, 33, 8 LTEXT "Nom d'usuari:", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 81, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 81, 55, 141, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "Desa", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "Desa com...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "Obre...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/cs-CZ.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/cs-CZ.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -10,7 +10,7 @@ LTEXT "Zadejte adresu serveru.", IDC_STATIC, 47, 24, 81, 8 LTEXT "Server:", IDC_STATIC, 47, 41, 25, 8 LTEXT "UÅ¾ivatelskÃ© jmÃ©no:", IDC_STATIC, 47, 58, 60, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + COMBOBOX IDC_SERVERCOMBO, 110, 39, 110, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "UloÅ¾it", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "UloÅ¾it jako...", IDC_SAVEAS, 123, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/de-DE.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -10,8 +10,8 @@ LTEXT "Serveradresse eingeben.", IDC_STATIC, 47, 24, 81, 8 LTEXT "Server:", IDC_STATIC, 47, 41, 25, 8 LTEXT "Benutzername:", IDC_STATIC, 47, 58, 50, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 101, 39, 119, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 101, 55, 119, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "Speichern", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "Speichern unter", IDC_SAVEAS, 120, 139, 55, 14 PUSHBUTTON "Ãffnen...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/el-GR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/el-GR.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -10,8 +10,8 @@ LTEXT "ÎÏÏÏÎµ ÏÎ· Î´Î¹ÎµÏÎ¸ÏÎ½ÏÎ· ÏÎ¿Ï Î´Î¹Î±ÎºÎ¿Î¼Î¹ÏÏÎ®.", IDC_STATIC, 47, 24, 81, 8 LTEXT "ÎÎ¹Î±ÎºÎ¿Î¼Î¹ÏÏÎ®Ï:", IDC_STATIC, 47, 41, 30, 8 LTEXT "ÎÎ½Î¿Î¼Î± ÏÏÎ®ÏÏÎ·:", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 89, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 89, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 89, 55, 141, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "ÎÏÎ¿Î¸Î®ÎºÎµÏÏÎ·", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "ÎÏÎ¿Î¸Î®ÎºÎµÏÏÎ· Î©Ï...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "ÎÎ½Î¿Î¹Î³Î¼Î±...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/en-US.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/en-US.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -10,8 +10,8 @@ LTEXT "Enter the server address.", IDC_STATIC, 47, 24, 85, 8 LTEXT "Server:", IDC_STATIC, 47, 41, 25, 8 LTEXT "User name:", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 89, 39, 131, 15, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 89, 55, 131, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "Save", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "Save As...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "Open...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/es-ES.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/es-ES.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -12,7 +12,7 @@ LTEXT "Introduzca la direcciÃ³n del servidor.", IDC_STATIC, 47, 24, 81, 8 LTEXT "Servidor:", IDC_STATIC, 47, 41, 28, 8 LTEXT "Nombre de usuario:", IDC_STATIC, 47, 58, 70, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + COMBOBOX IDC_SERVERCOMBO, 110, 39, 111, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "&Guardar", IDC_SAVE, 60, 139, 50, 14 //67 PUSHBUTTON "Guardar &como...", IDC_SAVEAS, 115, 139, 58,14 //123, 50 Modified: trunk/reactos/base/applications/mstsc/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/fr-FR.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -10,8 +10,8 @@ LTEXT "Entrez l'adresse du serveur.", IDC_STATIC, 47, 24, 81, 8 LTEXT "Serveur:", IDC_STATIC, 47, 41, 25, 8 LTEXT "Nom d'utilisateur:", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 79, 55, 142, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "Enregistrer", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "Enregistrer Sous...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "Ouvrir...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/he-IL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/he-IL.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/he-IL.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -10,8 +10,8 @@ LTEXT "××× ××ª ××ª×××ª ××©×¨×ª", IDC_STATIC, 47, 24, 81, 8 LTEXT "×©×¨×ª:", IDC_STATIC, 47, 41, 25, 8 LTEXT "×©× ××©×ª××©:", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 79, 55, 141, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "×©×××¨", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "×©×××¨ ××©×...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "×¤×ª×...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/it-IT.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/it-IT.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -10,8 +10,8 @@ LTEXT "Digitare il nome o indirizzo del computer.", IDC_STATIC, 47, 24, 150, 8 LTEXT "Computer:", IDC_STATIC, 47, 41, 35, 8 LTEXT "Nome utente:", IDC_STATIC, 47, 58, 68, 8 - COMBOBOX IDC_SERVERCOMBO, 90, 39, 136, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 95, 39, 131, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 95, 55, 131, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "Salva", IDC_SAVE, 43, 139, 58, 14 PUSHBUTTON "Salva con nome", IDC_SAVEAS, 107, 139, 58, 14 PUSHBUTTON "Apri", IDC_OPEN, 169, 139, 58, 14 Modified: trunk/reactos/base/applications/mstsc/lang/ja-JP.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/ja-JP.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/ja-JP.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -10,8 +10,8 @@ LTEXT "ãµã¼ãã®ã¢ãã¬ã¹ãå¥åãã¦ãã ãã", IDC_STATIC, 47, 24, 81, 8 LTEXT "ãµã¼ã:", IDC_STATIC, 47, 41, 25, 8 LTEXT "ã¦ã¼ã¶ã¼å:", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 79, 55, 141, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "ä¿å", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "ååãä»ãã¦ä¿å...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "éã...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/ko-KR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/ko-KR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/ko-KR.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -12,8 +12,8 @@ LTEXT "ìë² ì£¼ìë¥¼ ìë ¥í´ ì£¼ì¸ì.", IDC_STATIC, 47, 24, 81, 8 LTEXT "ìë² ì£¼ì:", IDC_STATIC, 47, 41, 25, 8 LTEXT "ì¬ì©ì ì´ë¦:", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 79, 55, 141, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "ì ì¥", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "ë¤ë¥¸ ì´ë¦ì¼ë¡ ì ì¥...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "ì´ê¸°...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/lt-LT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/lt-LT.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/lt-LT.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -12,8 +12,8 @@ LTEXT "Ä®veskite serverio adresÄ.", IDC_STATIC, 47, 24, 81, 8 LTEXT "Serveris:", IDC_STATIC, 47, 41, 30, 8 LTEXT "Vartotojo vardas:", IDC_STATIC, 47, 58, 60, 8 - COMBOBOX IDC_SERVERCOMBO, 107, 39, 113, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 107, 39, 113, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 107, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "Saugoti", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "Saugoti kaip...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "Atidaryti...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/pl-PL.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/pl-PL.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -20,8 +20,8 @@ LTEXT "Wpisz adres serwera.", IDC_STATIC, 47, 24, 81, 8 LTEXT "Serwer:", IDC_STATIC, 39, 42, 29, 8 LTEXT "Nazwa uÅ¼ytkownika:", IDC_STATIC, 39, 57, 42, 18 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 84, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 84, 55, 141, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "Zapisz", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "Zapisz jako...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "OtwÃ³rz...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/ro-RO.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/ro-RO.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -16,8 +16,8 @@ LTEXT "IntroduceÈi adresa unui server.", IDC_STATIC, 47, 24, 111, 8 LTEXT "Server:", IDC_STATIC, 47, 41, 25, 8 LTEXT "Nume utilizator:", IDC_STATIC, 47, 58, 58, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 101, 39, 119, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 101, 55, 119, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "&PÄstreazÄ", IDC_SAVE, 57, 139, 50, 14 PUSHBUTTON "PÄst&rare Ã®nâ¦", IDC_SAVEAS, 112, 139, 60, 14 PUSHBUTTON "&Deschidereâ¦", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/ru-RU.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/ru-RU.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -12,8 +12,8 @@ LTEXT "ÐÐ²ÐµÐ´Ð¸ÑÐµ Ð°Ð´ÑÐµÑ ÑÐµÑÐ²ÐµÑÐ°.", IDC_STATIC, 47, 24, 100, 8 LTEXT "Ð¡ÐµÑÐ²ÐµÑ:", IDC_STATIC, 52, 41, 31, 8 LTEXT "ÐÐ¼Ñ Ð¿Ð¾Ð»ÑÐ·Ð¾Ð²Ð°ÑÐµÐ»Ñ:", IDC_STATIC, 15, 58, 67, 8 - COMBOBOX IDC_SERVERCOMBO, 86, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 86, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 86, 55, 141, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "Ð¡Ð¾ÑÑ&Ð°Ð½Ð¸ÑÑ", IDC_SAVE, 49, 139, 50, 14 PUSHBUTTON "Ð¡Ð¾&ÑÑÐ°Ð½Ð¸ÑÑ ÐºÐ°Ðº...", IDC_SAVEAS, 103, 139, 70, 14 PUSHBUTTON "&ÐÑÐºÑÑÑÑ...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/sk-SK.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/sk-SK.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -13,9 +13,9 @@ ICON "", IDC_LOGONICON, 15, 19, 20, 20 LTEXT "VloÅ¾te adresu servera.", IDC_STATIC, 47, 24, 81, 8 LTEXT "Server:", IDC_STATIC, 47, 41, 25, 8 - LTEXT "PouÅ¾ÃvateÄ¾skÃ© meno:", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + LTEXT "PouÅ¾ÃvateÄ¾skÃ© meno:", IDC_STATIC, 47, 58, 45, 8 + COMBOBOX IDC_SERVERCOMBO, 95, 39, 130, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 95, 55, 130, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "&UloÅ¾iÅ¥", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "UloÅ¾iÅ¥ &ako...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "&OtvoriÅ¥...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/sq-AL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/sq-AL.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/sq-AL.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -14,8 +14,8 @@ LTEXT "Fut adresen e serverit.", IDC_STATIC, 47, 24, 81, 8 LTEXT "Server:", IDC_STATIC, 47, 41, 25, 8 LTEXT "Emri pÃ«rdoruesit:", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 79, 55, 140, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "Ruaj", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "Ruaj si...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "Hap...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/sv-SE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/sv-SE.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/sv-SE.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -16,9 +16,9 @@ ICON "", IDC_LOGONICON, 15, 19, 20, 20 LTEXT "Skriv in serveradressen.", IDC_STATIC, 47, 24, 81, 8 LTEXT "Server:", IDC_STATIC, 47, 41, 25, 8 - LTEXT "AnvÃ¤ndarnamn:", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + LTEXT "AnvÃ¤ndarnamn:", IDC_STATIC, 47, 58, 53, 8 + COMBOBOX IDC_SERVERCOMBO, 102, 39, 119, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 102, 55, 117, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "Spara", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "Spara som...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "Ãppna...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/tr-TR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/tr-TR.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -12,8 +12,8 @@ LTEXT "Sunucu adresini giriniz.", IDC_STATIC, 47, 24, 81, 8 LTEXT "Sunucu:", IDC_STATIC, 47, 41, 25, 8 LTEXT "KullanÄ±cÄ± AdÄ±:", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 79, 55, 141, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "Sakla", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "AyrÄ± Sakla...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "AÃ§...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/uk-UA.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/uk-UA.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -18,8 +18,8 @@ LTEXT "ÐÐ²ÐµÐ´ÑÑÑ Ð°Ð´ÑÐµÑÑ ÑÐµÑÐ²ÐµÑÐ°.", IDC_STATIC, 47, 24, 81, 8 LTEXT "Ð¡ÐµÑÐ²ÐµÑ:", IDC_STATIC, 47, 41, 27, 8 LTEXT "ÐÐ¾ÑÐ¸ÑÑÑÐ²Ð°Ñ:", IDC_STATIC, 47, 58, 41, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 87, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 87, 55, 141, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "ÐÐ±ÐµÑÐµÐ³ÑÐ¸", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "ÐÐ±ÐµÑÐµÐ³ÑÐ¸ ÑÐº...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "ÐÑÐ´ÐºÑÐ¸ÑÐ¸...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/zh-CN.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/zh-CN.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/zh-CN.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -12,8 +12,8 @@ LTEXT "è¾å¥æå¡å¨å°å", IDC_STATIC, 47, 24, 81, 8 LTEXT "æå¡å¨ï¼", IDC_STATIC, 47, 41, 25, 8 LTEXT "ç¨æ·åï¼", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 79, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "ä¿å", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "å¦åä¸º...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "æå¼...", IDC_OPEN, 177, 139, 50, 14 Modified: trunk/reactos/base/applications/mstsc/lang/zh-TW.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/la… ============================================================================== --- trunk/reactos/base/applications/mstsc/lang/zh-TW.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mstsc/lang/zh-TW.rc [iso-8859-1] Thu Apr 23 21:44:03 2015 @@ -17,8 +17,8 @@ LTEXT "è¼¸å¥ä¼ºæå¨å°å", IDC_STATIC, 47, 24, 81, 8 LTEXT "ä¼ºæå¨ï¼", IDC_STATIC, 47, 41, 25, 8 LTEXT "ç¨æ¶åï¼", IDC_STATIC, 47, 58, 38, 8 - COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 150, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP - EDITTEXT IDC_NAMEEDIT, 110, 55, 110, 14, WS_TABSTOP | ES_AUTOHSCROLL + COMBOBOX IDC_SERVERCOMBO, 79, 39, 141, 13, CBS_DROPDOWN | WS_VSCROLL | WS_TABSTOP + EDITTEXT IDC_NAMEEDIT, 79, 55, 141, 14, WS_TABSTOP | ES_AUTOHSCROLL PUSHBUTTON "å²å", IDC_SAVE, 67, 139, 50, 14 PUSHBUTTON "å¦åçº...", IDC_SAVEAS, 123, 139, 50, 14 PUSHBUTTON "éå...", IDC_OPEN, 177, 139, 50, 14

1 0

[cwittich] 67373: [TASKMGR] fix process cpu time CORE-9562
by cwittich＠svn.reactos.org 23 Apr '15

23 Apr '15

Author: cwittich Date: Thu Apr 23 20:18:38 2015 New Revision: 67373 URL: http://svn.reactos.org/svn/reactos?rev=67373&view=rev Log: [TASKMGR] fix process cpu time CORE-9562 Modified: trunk/reactos/base/applications/taskmgr/perfdata.c Modified: trunk/reactos/base/applications/taskmgr/perfdata.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/taskmgr/… ============================================================================== --- trunk/reactos/base/applications/taskmgr/perfdata.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/taskmgr/perfdata.c [iso-8859-1] Thu Apr 23 20:18:38 2015 @@ -331,20 +331,18 @@ /* Now alloc a new PERFDATA array and fill in the data */ pPerfData = (PPERFDATA)HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, sizeof(PERFDATA) * ProcessCount); - if (pPerfDataOld) { - HeapFree(GetProcessHeap(), 0, pPerfDataOld); - } - pPerfDataOld = pPerfData; pSPI = (PSYSTEM_PROCESS_INFORMATION)pBuffer; for (Idx=0; Idx<ProcessCount; Idx++) { /* Get the old perf data for this process (if any) */ /* so that we can establish delta values */ pPDOld = NULL; - for (Idx2=0; Idx2<ProcessCountOld; Idx2++) { - if (pPerfDataOld[Idx2].ProcessId == pSPI->UniqueProcessId) { - pPDOld = &pPerfDataOld[Idx2]; - break; + if (pPerfDataOld) { + for (Idx2=0; Idx2<ProcessCountOld; Idx2++) { + if (pPerfDataOld[Idx2].ProcessId == pSPI->UniqueProcessId) { + pPDOld = &pPerfDataOld[Idx2]; + break; + } } } @@ -447,6 +445,10 @@ pSPI = (PSYSTEM_PROCESS_INFORMATION)((LPBYTE)pSPI + pSPI->NextEntryOffset); } HeapFree(GetProcessHeap(), 0, pBuffer); + if (pPerfDataOld) { + HeapFree(GetProcessHeap(), 0, pPerfDataOld); + } + pPerfDataOld = pPerfData; LeaveCriticalSection(&PerfDataCriticalSection); }

1 0

[tfaber] 67372: [MSI] - Apply Wine commit 55b678e1 (msi: Fix an invalid memory access (valgrind).) by Hans Leidekker
by tfaber＠svn.reactos.org 23 Apr '15

23 Apr '15

Author: tfaber Date: Thu Apr 23 19:56:02 2015 New Revision: 67372 URL: http://svn.reactos.org/svn/reactos?rev=67372&view=rev Log: [MSI] - Apply Wine commit 55b678e1 (msi: Fix an invalid memory access (valgrind).) by Hans Leidekker Modified: trunk/reactos/dll/win32/msi/table.c Modified: trunk/reactos/dll/win32/msi/table.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msi/table.c?rev=… ============================================================================== --- trunk/reactos/dll/win32/msi/table.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msi/table.c [iso-8859-1] Thu Apr 23 19:56:02 2015 @@ -882,7 +882,7 @@ } rawsize = 0; - for (i = 0; i < t->row_count; i++) + for (i = 0; i < row_count; i++) { UINT ofs = 0, ofs_mem = 0;

1 0

[akhaldi] 67371: [BROWSEUI] Fix back and forward buttons so they work correctly. Brought to you by Fedor Zaytsev with an improvement suggested by Aleksey. CORE-8894
by akhaldi＠svn.reactos.org 23 Apr '15

23 Apr '15

Author: akhaldi Date: Thu Apr 23 18:54:56 2015 New Revision: 67371 URL: http://svn.reactos.org/svn/reactos?rev=67371&view=rev Log: [BROWSEUI] Fix back and forward buttons so they work correctly. Brought to you by Fedor Zaytsev with an improvement suggested by Aleksey. CORE-8894 Modified: trunk/reactos/dll/win32/browseui/shellbrowser.cpp Modified: trunk/reactos/dll/win32/browseui/shellbrowser.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/shellbr… ============================================================================== --- trunk/reactos/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/browseui/shellbrowser.cpp [iso-8859-1] Thu Apr 23 18:54:56 2015 @@ -127,6 +127,7 @@ }; static const unsigned int folderOptionsPageCountMax = 20; +static const long BTP_DONT_UPDATE_HISTORY = 0; static const long BTP_UPDATE_CUR_HISTORY = 1; static const long BTP_UPDATE_NEXT_HISTORY = 2; @@ -3001,7 +3002,7 @@ fHistoryObject = viewHistoryObject; fHistoryStream = pStream; fHistoryBindContext = pbc; - hResult = BrowseToPIDL(pidl, BTP_UPDATE_CUR_HISTORY); + hResult = BrowseToPIDL(pidl, BTP_DONT_UPDATE_HISTORY); fHistoryObject = NULL; fHistoryStream = NULL; fHistoryBindContext = NULL;

1 0

[tfaber] 67370: [NTDLL_APITEST] - Gracefully handle failures in NtMapViewOfSection test. CORE-9189 - Correctly handle unterminated strings in NtQueryKey test. Powered by DPH.
by tfaber＠svn.reactos.org 23 Apr '15

23 Apr '15

Author: tfaber Date: Thu Apr 23 18:41:08 2015 New Revision: 67370 URL: http://svn.reactos.org/svn/reactos?rev=67370&view=rev Log: [NTDLL_APITEST] - Gracefully handle failures in NtMapViewOfSection test. CORE-9189 - Correctly handle unterminated strings in NtQueryKey test. Powered by DPH. Modified: trunk/rostests/apitests/ntdll/NtMapViewOfSection.c trunk/rostests/apitests/ntdll/NtQueryKey.c Modified: trunk/rostests/apitests/ntdll/NtMapViewOfSection.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/NtMapViewO… ============================================================================== --- trunk/rostests/apitests/ntdll/NtMapViewOfSection.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/NtMapViewOfSection.c [iso-8859-1] Thu Apr 23 18:41:08 2015 @@ -236,7 +236,7 @@ if (!NT_SUCCESS(Status)) return; - ok(BaseAddress == UlongToPtr(0x40000000), "Invalid BaseAddress: %p", BaseAddress); + ok(BaseAddress == UlongToPtr(0x40000000), "Invalid BaseAddress: %p\n", BaseAddress); BaseAddress = (PVOID)0x40080000; SectionOffset.QuadPart = 0x10000; @@ -253,7 +253,7 @@ PAGE_READWRITE); ok_ntstatus(Status, STATUS_SUCCESS); - ok(BaseAddress == (PVOID)0x40080000, "Invalid BaseAddress: %p", BaseAddress); + ok(BaseAddress == (PVOID)0x40080000, "Invalid BaseAddress: %p\n", BaseAddress); /* Commit a page in the section */ BaseAddress = (PVOID)0x40000000; @@ -401,7 +401,7 @@ _SEH2_END; ok_ntstatus(Status, STATUS_SUCCESS); - ok(*(PULONG)BaseAddress2 == 2, "Value in memory was wrong"); + ok(*(PULONG)BaseAddress2 == 2, "Value in memory was wrong\n"); /* Close the mapping */ NtUnmapViewOfSection(NtCurrentProcess(), BaseAddress); @@ -444,7 +444,7 @@ #else /* WoW64 returns STATUS_INSUFFICIENT_RESOURCES */ ok((Status == STATUS_INSUFFICIENT_RESOURCES) || (Status == STATUS_SECTION_TOO_BIG), - "got wrong Status: 0x%lx", Status); + "got wrong Status: 0x%lx\n", Status); #endif /* Try to create a even huger page file backed section, but only reserved */ @@ -488,7 +488,7 @@ #else /* WoW64 returns STATUS_INVALID_PARAMETER_4 */ ok((Status == STATUS_INVALID_PARAMETER_4) || (Status == STATUS_INVALID_PARAMETER_3), - "got wrong Status: 0x%lx", Status); + "got wrong Status: 0x%lx\n", Status); #endif /* Pass 0 region size */ @@ -511,7 +511,7 @@ #else /* WoW64 returns STATUS_NO_MEMORY */ ok((Status == STATUS_NO_MEMORY) || (Status == STATUS_INVALID_VIEW_SIZE), - "got wrong Status: 0x%lx", Status); + "got wrong Status: 0x%lx\n", Status); ok(ViewSize == 0, "wrong ViewSize: 0x%Ix\n", ViewSize); #endif @@ -677,6 +677,11 @@ FILE_SHARE_READ, FILE_SYNCHRONOUS_IO_NONALERT); ok_ntstatus(Status, STATUS_SUCCESS); + if (!NT_SUCCESS(Status)) + { + skip("Failed to open file\n"); + return; + } /* Create a data section with write access */ Status = NtCreateSection(&DataSectionHandle, @@ -687,6 +692,12 @@ SEC_COMMIT, // AllocationAttributes FileHandle); ok_ntstatus(Status, STATUS_SUCCESS); + if (!NT_SUCCESS(Status)) + { + skip("Failed to create data section\n"); + NtClose(FileHandle); + return; + } /* Map the data section as flat mapping */ DataBase = NULL; @@ -703,6 +714,13 @@ PAGE_READWRITE); ok_ntstatus(Status, STATUS_SUCCESS); //ok(ViewSize == 0x3f95cc48, "ViewSize wrong: 0x%lx\n"); + if (!NT_SUCCESS(Status)) + { + skip("Failed to map view of data section\n"); + NtClose(DataSectionHandle); + NtClose(FileHandle); + return; + } /* Check the original data */ ok(*(ULONG*)DataBase == 0x00905a4d, "Header not ok\n"); @@ -725,6 +743,7 @@ SEC_IMAGE, // AllocationAttributes FileHandle); ok_ntstatus(Status, STATUS_INVALID_IMAGE_NOT_MZ); + if (NT_SUCCESS(Status)) NtClose(ImageSectionHandle); /* Restore the original header */ *(ULONG*)DataBase = 0x00905a4d; @@ -742,6 +761,13 @@ SEC_IMAGE, // AllocationAttributes FileHandle); ok_ntstatus(Status, STATUS_SUCCESS); + if (!NT_SUCCESS(Status)) + { + skip("Failed to create image section\n"); + NtClose(DataSectionHandle); + NtClose(FileHandle); + return; + } /* Map the image section */ ImageBase = NULL; @@ -761,6 +787,14 @@ #else ok_ntstatus(Status, STATUS_IMAGE_MACHINE_TYPE_MISMATCH); #endif + if (!NT_SUCCESS(Status)) + { + skip("Failed to map view of image section\n"); + NtClose(ImageSectionHandle); + NtClose(DataSectionHandle); + NtClose(FileHandle); + return; + } /* Check the header */ ok(*(ULONG*)DataBase == 0x00905a4d, "Header not ok\n"); @@ -813,6 +847,13 @@ SEC_IMAGE, // AllocationAttributes FileHandle); ok_ntstatus(Status, STATUS_SUCCESS); + if (!NT_SUCCESS(Status)) + { + skip("Failed to create image section\n"); + NtClose(DataSectionHandle); + NtClose(FileHandle); + return; + } /* Map the image section again */ ImageBase = NULL; @@ -832,6 +873,14 @@ #else ok_ntstatus(Status, STATUS_IMAGE_MACHINE_TYPE_MISMATCH); #endif + if (!NT_SUCCESS(Status)) + { + skip("Failed to map view of image section\n"); + NtClose(ImageSectionHandle); + NtClose(DataSectionHandle); + NtClose(FileHandle); + return; + } // This one doesn't always work, needs investigation /* Check the .data section again */ Modified: trunk/rostests/apitests/ntdll/NtQueryKey.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/NtQueryKey… ============================================================================== --- trunk/rostests/apitests/ntdll/NtQueryKey.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/NtQueryKey.c [iso-8859-1] Thu Apr 23 18:41:08 2015 @@ -51,8 +51,9 @@ ok_size_t(InfoLength, FIELD_OFFSET(KEY_NAME_INFORMATION, Name[HKLM_Name.Length/sizeof(WCHAR)])); ok_size_t(NameInformation->NameLength, HKLM_Name.Length); - RtlInitUnicodeString(&InfoName, NameInformation->Name); + InfoName.Buffer = NameInformation->Name; InfoName.Length = NameInformation->NameLength; + InfoName.MaximumLength = NameInformation->NameLength; ok(RtlCompareUnicodeString(&InfoName, &HKLM_Name, TRUE) == 0, "%.*S\n", InfoName.Length, InfoName.Buffer); @@ -82,8 +83,9 @@ ok_size_t(InfoLength, FIELD_OFFSET(KEY_NAME_INFORMATION, Name[HKLM_Software_Name.Length/sizeof(WCHAR)])); ok_size_t(NameInformation->NameLength, HKLM_Software_Name.Length); - RtlInitUnicodeString(&InfoName, NameInformation->Name); + InfoName.Buffer = NameInformation->Name; InfoName.Length = NameInformation->NameLength; + InfoName.MaximumLength = NameInformation->NameLength; ok(RtlCompareUnicodeString(&InfoName, &HKLM_Software_Name, TRUE) == 0, "%.*S\n", InfoName.Length, InfoName.Buffer);

1 0

[aandrejevic] 67369: [NTVDM] Store the return address in INT 22h as a far pointer. The amount of memory stored in the Env variable is EnvSize, not sizeof(Env) since Env is a pointer.
by aandrejevic＠svn.reactos.org 23 Apr '15

23 Apr '15

Author: aandrejevic Date: Thu Apr 23 15:19:48 2015 New Revision: 67369 URL: http://svn.reactos.org/svn/reactos?rev=67369&view=rev Log: [NTVDM] Store the return address in INT 22h as a far pointer. The amount of memory stored in the Env variable is EnvSize, not sizeof(Env) since Env is a pointer. Modified: trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/dos.c trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/dos.h Modified: trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/dos.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/mvdm/ntvdm/dos/… ============================================================================== --- trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/dos.c [iso-8859-1] (original) +++ trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/dos.c [iso-8859-1] Thu Apr 23 15:19:48 2015 @@ -694,7 +694,11 @@ return &DosSystemFileTable[HandleTable[DosHandle]]; } -VOID DosInitializePsp(WORD PspSegment, LPCSTR CommandLine, WORD ProgramSize, WORD Environment) +VOID DosInitializePsp(WORD PspSegment, + LPCSTR CommandLine, + WORD ProgramSize, + WORD Environment, + DWORD ReturnAddress) { PDOS_PSP PspBlock = SEGMENT_TO_PSP(PspSegment); LPDWORD IntVecTable = (LPDWORD)((ULONG_PTR)BaseAddress); @@ -709,7 +713,7 @@ PspBlock->LastParagraph = PspSegment + ProgramSize - 1; /* Save the interrupt vectors */ - PspBlock->TerminateAddress = IntVecTable[0x22]; + PspBlock->TerminateAddress = ReturnAddress; PspBlock->BreakAddress = IntVecTable[0x23]; PspBlock->CriticalAddress = IntVecTable[0x24]; @@ -744,6 +748,7 @@ IN LPCSTR ExecutablePath, IN LPCSTR CommandLine, IN LPCSTR Environment OPTIONAL, + IN DWORD ReturnAddress OPTIONAL, OUT PDWORD StackLocation OPTIONAL, OUT PDWORD EntryPoint OPTIONAL) { @@ -865,7 +870,8 @@ DosInitializePsp(Segment, CommandLine, (WORD)ExeSize, - EnvBlock); + EnvBlock, + ReturnAddress); /* The process owns its own memory */ DosChangeMemoryOwner(Segment, Segment); @@ -943,7 +949,8 @@ DosInitializePsp(Segment, CommandLine, MaxAllocSize, - EnvBlock); + EnvBlock, + ReturnAddress); if (LoadType == DOS_LOAD_AND_EXECUTE) { @@ -993,11 +1000,13 @@ IN LPCSTR Environment OPTIONAL) { DWORD Result; + LPDWORD IntVecTable = (LPDWORD)((ULONG_PTR)BaseAddress); Result = DosLoadExecutable(DOS_LOAD_AND_EXECUTE, ExecutablePath, CommandLine, Environment, + IntVecTable[0x20], // Use INT 20h NULL, NULL); @@ -1028,7 +1037,8 @@ #ifndef STANDALONE WORD DosCreateProcess(DOS_EXEC_TYPE LoadType, LPCSTR ProgramName, - PDOS_EXEC_PARAM_BLOCK Parameters) + PDOS_EXEC_PARAM_BLOCK Parameters, + DWORD ReturnAddress) { DWORD Result; DWORD BinaryType; @@ -1097,7 +1107,7 @@ CommandInfo.Title = Title; CommandInfo.TitleLen = sizeof(Title); CommandInfo.Env = Env; - CommandInfo.EnvLen = sizeof(Env); + CommandInfo.EnvLen = EnvSize; Command: /* Get the VDM command information */ @@ -1123,6 +1133,7 @@ AppName, CmdLine, Env, + ReturnAddress, &Parameters->StackLocation, &Parameters->EntryPoint); if (Result == ERROR_SUCCESS) @@ -2486,7 +2497,8 @@ DOS_EXEC_TYPE LoadType = (DOS_EXEC_TYPE)getAL(); LPSTR ProgramName = SEG_OFF_TO_PTR(getDS(), getDX()); PDOS_EXEC_PARAM_BLOCK ParamBlock = SEG_OFF_TO_PTR(getES(), getBX()); - WORD ErrorCode = DosCreateProcess(LoadType, ProgramName, ParamBlock); + DWORD ReturnAddress = MAKELONG(Stack[STACK_IP], Stack[STACK_CS]); + WORD ErrorCode = DosCreateProcess(LoadType, ProgramName, ParamBlock, ReturnAddress); if (ErrorCode == ERROR_SUCCESS) { Modified: trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/dos.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/subsystems/mvdm/ntvdm/dos/… ============================================================================== --- trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/dos.h [iso-8859-1] (original) +++ trunk/reactos/subsystems/mvdm/ntvdm/dos/dos32krnl/dos.h [iso-8859-1] Thu Apr 23 15:19:48 2015 @@ -238,19 +238,27 @@ LPDWORD NewOffset); BOOL DosFlushFileBuffers(WORD FileHandle); -VOID DosInitializePsp(WORD PspSegment, LPCSTR CommandLine, WORD ProgramSize, WORD Environment); +VOID DosInitializePsp( + WORD PspSegment, + LPCSTR CommandLine, + WORD ProgramSize, + WORD Environment, + DWORD ReturnAddress +); DWORD DosLoadExecutable( IN DOS_EXEC_TYPE LoadType, IN LPCSTR ExecutablePath, IN LPCSTR CommandLine, IN LPCSTR Environment OPTIONAL, + IN DWORD ReturnAddress OPTIONAL, OUT PDWORD StackLocation OPTIONAL, OUT PDWORD EntryPoint OPTIONAL ); WORD DosCreateProcess( DOS_EXEC_TYPE LoadType, LPCSTR ProgramName, - PDOS_EXEC_PARAM_BLOCK Parameters + PDOS_EXEC_PARAM_BLOCK Parameters, + DWORD ReturnAddress ); DWORD DosStartProcess( IN LPCSTR ExecutablePath,

1 0

[cwittich] 67368: [CRT] add ARM stub for chkstk_ms (Timo please review)
by cwittich＠svn.reactos.org 23 Apr '15

23 Apr '15

Author: cwittich Date: Thu Apr 23 12:27:08 2015 New Revision: 67368 URL: http://svn.reactos.org/svn/reactos?rev=67368&view=rev Log: [CRT] add ARM stub for chkstk_ms (Timo please review) Added: trunk/reactos/lib/sdk/crt/except/arm/chkstk_ms.s (with props) Added: trunk/reactos/lib/sdk/crt/except/arm/chkstk_ms.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/sdk/crt/except/arm/chk… ============================================================================== --- trunk/reactos/lib/sdk/crt/except/arm/chkstk_ms.s (added) +++ trunk/reactos/lib/sdk/crt/except/arm/chkstk_ms.s [iso-8859-1] Thu Apr 23 12:27:08 2015 @@ -0,0 +1,30 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS system libraries + * PURPOSE: Implementation of _chkstk and _alloca_probe + * FILE: lib/sdk/crt/except/arm/chkstk_ms.s + * PROGRAMMER: Timo Kreuzer (timo.kreuzer(a)reactos.org) + * Yuntian Zhang (yuntian.zh(a)gmail.com) + */ + +/* INCLUDES ******************************************************************/ + +#include <kxarm.h> + +/* CODE **********************************************************************/ + TEXTAREA + +MsgUnimplemented ASCII "Unimplemented", CR, LF, NUL + + LEAF_ENTRY ___chkstk_ms + UNIMPLEMENTED chkstk_ms + bx lr + LEAF_END __chkstk_ms + + LEAF_ENTRY __alloca_probe + UNIMPLEMENTED alloca_probe + bx lr + LEAF_END __alloca_probe + + END +/* EOF */ Propchange: trunk/reactos/lib/sdk/crt/except/arm/chkstk_ms.s ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[cwittich] 67367: [FREELDR] rename boot.s to boot.S
by cwittich＠svn.reactos.org 23 Apr '15

23 Apr '15

Author: cwittich Date: Thu Apr 23 12:13:54 2015 New Revision: 67367 URL: http://svn.reactos.org/svn/reactos?rev=67367&view=rev Log: [FREELDR] rename boot.s to boot.S Added: trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.S - copied unchanged from r67365, trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s Removed: trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s Removed: trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/arch/… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/arch/arm/boot.s (removed) @@ -1,27 +0,0 @@ -/* - * PROJECT: ReactOS Boot Loader - * LICENSE: BSD - See COPYING.ARM in the top level directory - * FILE: boot/freeldr/arch/arm/boot.s - * PURPOSE: Implements the entry point for ARM machines - * PROGRAMMERS: ReactOS Portable Systems Group - */ - -#include <ksarm.h> - - //.title "ARM FreeLDR Entry Point" - //.include "ntoskrnl/include/internal/arm/kxarm.h" - //.include "ntoskrnl/include/internal/arm/ksarm.h" - //.section .init - - NESTED_ENTRY _start - PROLOG_END _start - - //b ArmInit - - ENTRY_END _start - -//L_ArmInit: -// .long ArmInit - - END -/* EOF */

1 0

[tfaber] 67366: [URLMON_WINETEST] - Re-enable skipped protocol tests ROSTESTS-165 #resolve
by tfaber＠svn.reactos.org 23 Apr '15

23 Apr '15

Author: tfaber Date: Thu Apr 23 11:32:20 2015 New Revision: 67366 URL: http://svn.reactos.org/svn/reactos?rev=67366&view=rev Log: [URLMON_WINETEST] - Re-enable skipped protocol tests ROSTESTS-165 #resolve Modified: trunk/rostests/winetests/urlmon/protocol.c Modified: trunk/rostests/winetests/urlmon/protocol.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/urlmon/protocol… ============================================================================== --- trunk/rostests/winetests/urlmon/protocol.c [iso-8859-1] (original) +++ trunk/rostests/winetests/urlmon/protocol.c [iso-8859-1] Thu Apr 23 11:32:20 2015 @@ -3772,27 +3772,12 @@ thread_id = GetCurrentThreadId(); test_file_protocol(); - - if (!winetest_interactive) - skip("ROSTESTS-165: Skipping test_http_protocol() because of timeouts.\n"); - else - test_http_protocol(); - + test_http_protocol(); if(pCreateUri) - { - if (!winetest_interactive) - skip("ROSTESTS-165: Skipping test_https_protocol() because of timeouts.\n"); - else - test_https_protocol(); - } + test_https_protocol(); else win_skip("Skipping https tests on too old platform\n"); - - if (!winetest_interactive) - skip("ROSTESTS-165: Skipping test_ftp_protocol() because of timeouts.\n"); - else - test_ftp_protocol(); - + test_ftp_protocol(); test_gopher_protocol(); test_mk_protocol(); test_CreateBinding();

1 0

[tfaber] 67365: [WININET] - Add back our Winsock initialization ROS-diff. Wine has only partially fixed this at this point. CORE-9588
by tfaber＠svn.reactos.org 23 Apr '15

23 Apr '15

Author: tfaber Date: Thu Apr 23 10:57:11 2015 New Revision: 67365 URL: http://svn.reactos.org/svn/reactos?rev=67365&view=rev Log: [WININET] - Add back our Winsock initialization ROS-diff. Wine has only partially fixed this at this point. CORE-9588 Modified: trunk/reactos/dll/win32/wininet/internet.c Modified: trunk/reactos/dll/win32/wininet/internet.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/wininet/internet… ============================================================================== --- trunk/reactos/dll/win32/wininet/internet.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/wininet/internet.c [iso-8859-1] Thu Apr 23 10:57:11 2015 @@ -996,6 +996,9 @@ { appinfo_t *lpwai = NULL; +#ifdef __REACTOS__ + init_winsock(); +#endif if (TRACE_ON(wininet)) { #define FE(x) { x, #x } static const wininet_flag_info access_type[] = {

1 0

← Newer
1
...
9
10
11
12
13
14
15
...
49
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs April 2015