Ros-diffs August 2015

ros-diffs@reactos.org

15 participants
301 discussions

[tfaber] 68675: [NTDLL_APITEST] - Properly clean up after tests

by tfaber＠svn.reactos.org

Author: tfaber Date: Tue Aug 11 07:13:51 2015 New Revision: 68675 URL: http://svn.reactos.org/svn/reactos?rev=68675&view=rev Log: [NTDLL_APITEST] - Properly clean up after tests Modified: trunk/rostests/apitests/ntdll/NtMapViewOfSection.c Modified: trunk/rostests/apitests/ntdll/NtMapViewOfSection.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/NtMapViewO… ============================================================================== --- trunk/rostests/apitests/ntdll/NtMapViewOfSection.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/NtMapViewOfSection.c [iso-8859-1] Tue Aug 11 07:13:51 2015 @@ -257,8 +257,13 @@ ok_ntstatus(Status, STATUS_SUCCESS); /* Close the mapping */ - NtUnmapViewOfSection(NtCurrentProcess(), BaseAddress); - NtClose(SectionHandle); + Status = NtUnmapViewOfSection(NtCurrentProcess(), BaseAddress); + ok_ntstatus(Status, STATUS_SUCCESS); + BaseAddress = (PVOID)0x30000000; + Status = NtUnmapViewOfSection(NtCurrentProcess(), BaseAddress); + ok_ntstatus(Status, STATUS_SUCCESS); + Status = NtClose(SectionHandle); + ok_ntstatus(Status, STATUS_SUCCESS); /* Create a page file backed section, but only reserved */ MaximumSize.QuadPart = 0x20000; @@ -395,9 +400,12 @@ ok(*(PULONG)BaseAddress2 == 2, "Value in memory was wrong\n"); /* Close the mapping */ - NtUnmapViewOfSection(NtCurrentProcess(), BaseAddress); - NtUnmapViewOfSection(NtCurrentProcess(), (PUCHAR)BaseAddress2 - PAGE_SIZE); - NtClose(SectionHandle); + Status = NtUnmapViewOfSection(NtCurrentProcess(), BaseAddress); + ok_ntstatus(Status, STATUS_SUCCESS); + Status = NtUnmapViewOfSection(NtCurrentProcess(), (PUCHAR)BaseAddress2 - PAGE_SIZE); + ok_ntstatus(Status, STATUS_SUCCESS); + Status = NtClose(SectionHandle); + ok_ntstatus(Status, STATUS_SUCCESS); /* Try to create a 512 GB page file backed section with committed pages */ MaximumSize.QuadPart = 0x8000000000; @@ -633,6 +641,10 @@ Status = NtAllocateVirtualMemory(NtCurrentProcess(), &BaseAddress2, 0, &ViewSize, MEM_COMMIT, PAGE_EXECUTE_READWRITE); ok_ntstatus(Status, STATUS_SUCCESS); + Status = NtUnmapViewOfSection(NtCurrentProcess(), BaseAddress); + ok_ntstatus(Status, STATUS_SUCCESS); + Status = NtClose(SectionHandle); + ok_ntstatus(Status, STATUS_SUCCESS); } void @@ -778,7 +790,7 @@ 0, // AllocationType PAGE_READONLY); #ifdef _M_IX86 - ok_ntstatus(Status, STATUS_IMAGE_NOT_AT_BASE); + ok_ntstatus(Status, STATUS_SUCCESS); #else ok_ntstatus(Status, STATUS_IMAGE_MACHINE_TYPE_MISMATCH); #endif @@ -864,7 +876,7 @@ 0, PAGE_READONLY); #ifdef _M_IX86 - ok_ntstatus(Status, STATUS_IMAGE_NOT_AT_BASE); + ok_ntstatus(Status, STATUS_SUCCESS); #else ok_ntstatus(Status, STATUS_IMAGE_MACHINE_TYPE_MISMATCH); #endif @@ -1056,13 +1068,11 @@ ok_ntstatus(Status, STATUS_CONFLICTING_ADDRESSES); #else ok_ntstatus(Status, STATUS_SUCCESS); -#endif - - ok_ntstatus(Status, STATUS_SUCCESS); ok((ULONG_PTR)BaseAddress2 < (ULONG_PTR)BaseAddress1, "Invalid addresses: BaseAddress1=%p, BaseAddress2=%p\n", BaseAddress1, BaseAddress2); ok(((ULONG_PTR)BaseAddress1 - (ULONG_PTR)BaseAddress2) == 0x10000, "Invalid addresses: BaseAddress1=%p, BaseAddress2=%p\n", BaseAddress1, BaseAddress2); +#endif }

9 years, 4 months

[tfaber] 68674: [NTDLL_APITEST] - Look for test.dll in the right place

by tfaber＠svn.reactos.org

Author: tfaber Date: Tue Aug 11 06:45:45 2015 New Revision: 68674 URL: http://svn.reactos.org/svn/reactos?rev=68674&view=rev Log: [NTDLL_APITEST] - Look for test.dll in the right place Modified: trunk/rostests/apitests/ntdll/NtMapViewOfSection.c Modified: trunk/rostests/apitests/ntdll/NtMapViewOfSection.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/ntdll/NtMapViewO… ============================================================================== --- trunk/rostests/apitests/ntdll/NtMapViewOfSection.c [iso-8859-1] (original) +++ trunk/rostests/apitests/ntdll/NtMapViewOfSection.c [iso-8859-1] Tue Aug 11 06:45:45 2015 @@ -1,23 +1,14 @@ +/* + * PROJECT: ReactOS API Tests + * LICENSE: LGPLv2.1+ - See COPYING.LIB in the top level directory + * PURPOSE: Test for NtMapViewOfSection + * PROGRAMMERS: Timo Kreuzer + */ #include <apitest.h> - +#include <strsafe.h> #define WIN32_NO_STATUS #include <ndk/ntndk.h> - -NTSYSAPI -NTSTATUS -NTAPI -NtMapViewOfSection( - HANDLE SectionHandle, - HANDLE ProcessHandle, - PVOID *BaseAddress, - ULONG_PTR ZeroBits, - SIZE_T CommitSize, - PLARGE_INTEGER SectionOffset, - PSIZE_T ViewSize, - SECTION_INHERIT InheritDisposition, - ULONG AllocationType, - ULONG Protect); void Test_PageFileSection(void) @@ -651,11 +642,15 @@ NTSTATUS Status; OBJECT_ATTRIBUTES FileObjectAttributes; IO_STATUS_BLOCK IoStatusBlock; + WCHAR TestDllPath[MAX_PATH]; HANDLE FileHandle, DataSectionHandle, ImageSectionHandle; PVOID DataBase, ImageBase; SIZE_T ViewSize; - if (!RtlDosPathNameToNtPathName_U(L"testdata\\test.dll", + GetModuleFileNameW(NULL, TestDllPath, RTL_NUMBER_OF(TestDllPath)); + wcsrchr(TestDllPath, L'\\')[1] = UNICODE_NULL; + StringCbCatW(TestDllPath, sizeof(TestDllPath), L"testdata\\test.dll"); + if (!RtlDosPathNameToNtPathName_U(TestDllPath, &FileName, NULL, NULL)) @@ -1077,4 +1072,3 @@ Test_ImageSection(); Test_BasedSection(); } -

9 years, 4 months

[cwittich] 68673: [MSAFD] don't trace an uninitialized UNICODE_STRING

by cwittich＠svn.reactos.org

Author: cwittich Date: Mon Aug 10 17:54:57 2015 New Revision: 68673 URL: http://svn.reactos.org/svn/reactos?rev=68673&view=rev Log: [MSAFD] don't trace an uninitialized UNICODE_STRING Modified: trunk/reactos/dll/win32/msafd/misc/helpers.c Modified: trunk/reactos/dll/win32/msafd/misc/helpers.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/msafd/misc/helpe… ============================================================================== --- trunk/reactos/dll/win32/msafd/misc/helpers.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/msafd/misc/helpers.c [iso-8859-1] Mon Aug 10 17:54:57 2015 @@ -40,8 +40,8 @@ PLIST_ENTRY Helpers; INT Status; - TRACE("AddressFamily %p, SocketType %p, Protocol %p, Group %u, Flags %lx, TransportName %wZ, HelperDllContext %p, HeplperDllData %p, Events %p\n", - AddressFamily, SocketType, Protocol, Group, Flags, TransportName, HelperDllContext, HelperDllData, Events); + TRACE("AddressFamily %p, SocketType %p, Protocol %p, Group %u, Flags %lx, HelperDllContext %p, HeplperDllData %p, Events %p\n", + AddressFamily, SocketType, Protocol, Group, Flags, HelperDllContext, HelperDllData, Events); /* Check in our Current Loaded Helpers */ for (Helpers = SockHelpersListHead.Flink;

9 years, 4 months

[dreimer] 68672: [BROWSEUI] Address is untranslatable by Adam Stachowicz CORE-9977 #resolve #comment Committed (with a Unicode fix), thx ^^

by dreimer＠svn.reactos.org

Author: dreimer Date: Mon Aug 10 16:52:40 2015 New Revision: 68672 URL: http://svn.reactos.org/svn/reactos?rev=68672&view=rev Log: [BROWSEUI] Address is untranslatable by Adam Stachowicz CORE-9977 #resolve #comment Committed (with a Unicode fix), thx ^^ Modified: trunk/reactos/dll/win32/browseui/addressband.cpp Modified: trunk/reactos/dll/win32/browseui/addressband.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/browseui/address… ============================================================================== --- trunk/reactos/dll/win32/browseui/addressband.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/browseui/addressband.cpp [iso-8859-1] Mon Aug 10 16:52:40 2015 @@ -93,7 +93,11 @@ pdbi->ptActual.y = 22; } if (pdbi->dwMask & DBIM_TITLE) - wcscpy(pdbi->wszTitle, L"Address"); + { + if (!LoadStringW(_AtlBaseModule.GetResourceInstance(), IDS_ADDRESSBANDLABEL, pdbi->wszTitle, _countof(pdbi->wszTitle))) + return E_FAIL; + } + if (pdbi->dwMask & DBIM_MODEFLAGS) pdbi->dwModeFlags = DBIMF_UNDELETEABLE; if (pdbi->dwMask & DBIM_BKCOLOR)

9 years, 4 months

[dreimer] 68671: [INETCPL] Update inetcpl icon license by Jared Smudde CORE-9801 #resolve #comment Committed, thx ^^

by dreimer＠svn.reactos.org

Author: dreimer Date: Mon Aug 10 15:35:44 2015 New Revision: 68671 URL: http://svn.reactos.org/svn/reactos?rev=68671&view=rev Log: [INETCPL] Update inetcpl icon license by Jared Smudde CORE-9801 #resolve #comment Committed, thx ^^ Removed: trunk/reactos/dll/cpl/inetcpl/resources/Icon_Licence/Trusted.txt Modified: trunk/reactos/dll/cpl/inetcpl/resources/Icon_Licence/Tango.txt Modified: trunk/reactos/dll/cpl/inetcpl/resources/Icon_Licence/Tango.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/inetcpl/resources/… ============================================================================== --- trunk/reactos/dll/cpl/inetcpl/resources/Icon_Licence/Tango.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/inetcpl/resources/Icon_Licence/Tango.txt [iso-8859-1] Mon Aug 10 15:35:44 2015 @@ -2,126 +2,10 @@ released under Creative Commons Attribution-ShareAlike 2.5 License. Please see COPYING for details -1.ico -2.ico -3.ico -4.ico -5.ico -6.ico -7.ico -8.ico -9.ico -10.ico -11.ico -12.ico -13.ico -14.ico -15.ico -16.ico -17.ico -18.ico -19.ico -20.ico -21.ico -22.ico -23.ico -24.ico -25.ico -28.ico -29.ico -30.ico -32.ico -33.ico -35.ico -36.ico -37.ico -38.ico -39.ico -41.ico -44.ico -45.ico -46.ico -47.ico -48.ico -54.ico -137.ico -138.ico -151.ico -152.ico -153.ico -154.ico -155.ico -156.ico -157.ico -160.ico -161.ico -172.ico -173.ico -191.ico -192.ico -210.ico -220.ico -221.ico -222.ico -224.ico -225.ico -226.ico -228.ico -233.ico -235.ico -236.ico -237.ico -238.ico -240.ico -245.ico -246.ico -248.ico -249.ico -250.ico -252.ico -254.ico -255.ico -263.ico -265.ico -268.ico -269.ico -270.ico -271.ico -277.ico -279.ico -289.ico -290.ico -291.ico -292.ico -293.ico -294.ico -295.ico -296.ico -297.ico -298.ico -299.ico -302.ico -304.ico -305.ico -309.ico -315.ico -317.ico -318.ico -319.ico -322.ico -323.ico -324.ico -325.ico -326.ico -327.ico -328.ico -329.ico -330.ico -1001.ico -1004.ico -8240.ico -16710.ico -16715.ico -16717.ico -16718.ico -16721.ico +certificates.ico +history.ico +home.ico +restricted.ico +trusted.ico + +The file trusted.ico was retrieved from http://bit.ly/1dzQSgh. Removed: trunk/reactos/dll/cpl/inetcpl/resources/Icon_Licence/Trusted.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/cpl/inetcpl/resources/… ============================================================================== --- trunk/reactos/dll/cpl/inetcpl/resources/Icon_Licence/Trusted.txt [iso-8859-1] (original) +++ trunk/reactos/dll/cpl/inetcpl/resources/Icon_Licence/Trusted.txt (removed) @@ -1 +0,0 @@ -The file trusted.ico was retrived from here http://lists.freedesktop.org/archives/tango-artists/attachments/20051206/36… and is released under public domain.

9 years, 4 months

[dreimer] 68670: [DLL] Fix blurry 32pixel network places icon by Jared Smudde CORE-10006 #resolve #comment Committed, thx ^^

by dreimer＠svn.reactos.org

Author: dreimer Date: Mon Aug 10 15:30:24 2015 New Revision: 68670 URL: http://svn.reactos.org/svn/reactos?rev=68670&view=rev Log: [DLL] Fix blurry 32pixel network places icon by Jared Smudde CORE-10006 #resolve #comment Committed, thx ^^ Modified: trunk/reactos/dll/win32/netid/res/101.ico trunk/reactos/dll/win32/shell32/res/icons/15.ico trunk/reactos/dll/win32/shell32/res/icons/18.ico trunk/reactos/dll/win32/shell32/res/icons/19.ico Modified: trunk/reactos/dll/win32/netid/res/101.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/netid/res/101.ic… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/icons/15.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/icon… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/icons/18.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/icon… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/icons/19.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/icon… ============================================================================== Binary files - no diff available.

9 years, 4 months

[dreimer] 68669: [cmd] Remove unnecessary icon sizes by Jared Smudde CORE-9985 #resolve #comment Committed, thx ^^

by dreimer＠svn.reactos.org

Author: dreimer Date: Mon Aug 10 15:22:09 2015 New Revision: 68669 URL: http://svn.reactos.org/svn/reactos?rev=68669&view=rev Log: [cmd] Remove unnecessary icon sizes by Jared Smudde CORE-9985 #resolve #comment Committed, thx ^^ Modified: trunk/reactos/base/shell/cmd/res/terminal.ico Modified: trunk/reactos/base/shell/cmd/res/terminal.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/cmd/res/termina… ============================================================================== Binary files - no diff available.

9 years, 4 months

[dreimer] 68668: [Applications] Add better 16pixel icons by Jared Smudde CORE-10007 #resolve #comment Committed, thx ^^

by dreimer＠svn.reactos.org

Author: dreimer Date: Mon Aug 10 15:18:39 2015 New Revision: 68668 URL: http://svn.reactos.org/svn/reactos?rev=68668&view=rev Log: [Applications] Add better 16pixel icons by Jared Smudde CORE-10007 #resolve #comment Committed, thx ^^ Modified: trunk/reactos/base/applications/games/solitaire/solitaire.ico trunk/reactos/base/applications/games/spider/spider.ico trunk/reactos/base/applications/kbswitch/res/kbswitch.ico trunk/reactos/base/applications/mstsc/res/mstsc.ico trunk/reactos/base/applications/notepad/res/notepad.ico Modified: trunk/reactos/base/applications/games/solitaire/solitaire.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/so… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/base/applications/games/spider/spider.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/games/sp… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/base/applications/kbswitch/res/kbswitch.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/kbswitch… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/base/applications/mstsc/res/mstsc.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mstsc/re… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/base/applications/notepad/res/notepad.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/notepad/… ============================================================================== Binary files - no diff available.

9 years, 4 months

[tfaber] 68667: [SETUPAPI] - Always initialize file_op::dst_sd so we don't free an uninitialized pointer. CORE-10004 #resolve

by tfaber＠svn.reactos.org

Author: tfaber Date: Mon Aug 10 14:28:50 2015 New Revision: 68667 URL: http://svn.reactos.org/svn/reactos?rev=68667&view=rev Log: [SETUPAPI] - Always initialize file_op::dst_sd so we don't free an uninitialized pointer. CORE-10004 #resolve Modified: trunk/reactos/dll/win32/setupapi/queue.c Modified: trunk/reactos/dll/win32/setupapi/queue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/setupapi/queue.c… ============================================================================== --- trunk/reactos/dll/win32/setupapi/queue.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/setupapi/queue.c [iso-8859-1] Mon Aug 10 14:28:50 2015 @@ -459,6 +459,7 @@ op->src_tag = strdupAtoW( params->SourceTagfile ); op->dst_path = strdupAtoW( params->TargetDirectory ); op->dst_file = strdupAtoW( params->TargetFilename ); + op->dst_sd = NULL; /* some defaults */ if (!op->src_file) op->src_file = op->dst_file; @@ -632,6 +633,7 @@ op->src_tag = NULL; op->dst_path = strdupAtoW( part1 ); op->dst_file = strdupAtoW( part2 ); + op->dst_sd = NULL; queue_file_op( &queue->delete_queue, op ); return TRUE; } @@ -654,6 +656,7 @@ op->src_tag = NULL; op->dst_path = strdupW( part1 ); op->dst_file = strdupW( part2 ); + op->dst_sd = NULL; queue_file_op( &queue->delete_queue, op ); return TRUE; } @@ -677,6 +680,7 @@ op->src_tag = NULL; op->dst_path = strdupAtoW( TargetPath ); op->dst_file = strdupAtoW( TargetFilename ); + op->dst_sd = NULL; queue_file_op( &queue->rename_queue, op ); return TRUE; } @@ -700,6 +704,7 @@ op->src_tag = NULL; op->dst_path = strdupW( TargetPath ); op->dst_file = strdupW( TargetFilename ); + op->dst_sd = NULL; queue_file_op( &queue->rename_queue, op ); return TRUE; }

9 years, 4 months

[dreimer] 68666: [SHELL32] [INF] Improvements to winhlp32 by Jared Smudde CORE-10002 #resolve #comment Committed, thx ^^

by dreimer＠svn.reactos.org

Author: dreimer Date: Mon Aug 10 14:18:40 2015 New Revision: 68666 URL: http://svn.reactos.org/svn/reactos?rev=68666&view=rev Log: [SHELL32] [INF] Improvements to winhlp32 by Jared Smudde CORE-10002 #resolve #comment Committed, thx ^^ Modified: trunk/reactos/boot/bootdata/hivecls.inf trunk/reactos/dll/win32/shell32/res/icons/1004.ico trunk/reactos/dll/win32/shell32/res/icons/24.ico Modified: trunk/reactos/boot/bootdata/hivecls.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivecls.inf?… ============================================================================== --- trunk/reactos/boot/bootdata/hivecls.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivecls.inf [iso-8859-1] Mon Aug 10 14:18:40 2015 @@ -132,7 +132,7 @@ HKCR,"hlpfile","",0x00000000,"Help File" HKCR,"hlpfile","FriendlyTypeName",0x00020000,"@%SystemRoot%\system32\shell32.dll,-168" HKCR,"hlpfile\DefaultIcon","",0x00020000,"%SystemRoot%\system32\shell32.dll,-24" -HKCR,"hlpfile\shell\open\command","",0x00020000,"%SystemRoot%\system32\winhlp32.exe %1" +HKCR,"hlpfile\shell\open\command","",0x00020000,"%SystemRoot%\winhlp32.exe %1" HKCR,".chm","",0x00000000,"chm.file" HKCR,"chm.file","",0x00000000,"Compiled HTML Help File" Modified: trunk/reactos/dll/win32/shell32/res/icons/1004.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/icon… ============================================================================== Binary files - no diff available. Modified: trunk/reactos/dll/win32/shell32/res/icons/24.ico URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/icon… ============================================================================== Binary files - no diff available.

9 years, 4 months

← Newer
1
...
19
20
21
22
23
24
25
...
31
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2015