Ros-diffs January 2016

ros-diffs@reactos.org

13 participants
192 discussions

[ion] 70609: [CMLIB/NTOSKRNL]: Move key deletion functions to cmlib, so that UEFI boot library can use them. [BOOTLIB]: Implement BCD element deletion (bootreg: implement key deletion) [BOOTMGR]: I...
by ion＠svn.reactos.org 17 Jan '16

17 Jan '16

Author: ion Date: Sun Jan 17 21:48:00 2016 New Revision: 70609 URL: http://svn.reactos.org/svn/reactos?rev=70609&view=rev Log: [CMLIB/NTOSKRNL]: Move key deletion functions to cmlib, so that UEFI boot library can use them. [BOOTLIB]: Implement BCD element deletion (bootreg: implement key deletion) [BOOTMGR]: Implement BL_FATAL_ERROR_BCD_ENTRIES fatal error. [BOOTMGR]: Stubplement support for memory list data parsing (when memtest.efi will run), and stubplement support for boot persistent data blobs. [BOOTMGR]: Stubplement boot sequence support, create stub for boot entry population. [BOOTMGR]: Stubplement boot entry selection, create stub for boot entry enumeration. Mostly factoring-level changes to get us closer to the needed code paths. Added: trunk/reactos/lib/cmlib/cmkeydel.c - copied, changed from r70605, trunk/reactos/ntoskrnl/config/cmkeydel.c Removed: trunk/reactos/ntoskrnl/config/cmkeydel.c Modified: trunk/reactos/boot/environ/app/bootmgr/bootmgr.c trunk/reactos/boot/environ/app/bootmgr/bootmgr.h trunk/reactos/boot/environ/include/bcd.h trunk/reactos/boot/environ/include/bl.h trunk/reactos/boot/environ/lib/bootlib.c trunk/reactos/boot/environ/lib/misc/bcd.c trunk/reactos/boot/environ/lib/misc/bootreg.c trunk/reactos/lib/cmlib/CMakeLists.txt trunk/reactos/lib/cmlib/cmlib.h trunk/reactos/ntoskrnl/include/internal/cm.h trunk/reactos/ntoskrnl/ntos.cmake Modified: trunk/reactos/boot/environ/app/bootmgr/bootmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/app/bootmgr/b… ============================================================================== --- trunk/reactos/boot/environ/app/bootmgr/bootmgr.c [iso-8859-1] (original) +++ trunk/reactos/boot/environ/app/bootmgr/bootmgr.c [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -550,6 +550,23 @@ ErrorResourceId = 9002; break; + case BL_FATAL_ERROR_BCD_ENTRIES: + + /* File name is in parameter 1 */ + FileName = (PWCHAR)Parameter1; + + /* The NTSTATUS code is in parameter 2*/ + ErrorStatus = (NTSTATUS)Parameter2; + + /* Build the error string */ + swprintf(FormatString, + L"\nNo valid entries found in the boot configuration data file %s\n", + FileName); + + /* Select the resource ID message */ + ErrorResourceId = 9007; + break; + case BL_FATAL_ERROR_BCD_PARSE: /* File name isin parameter 1 */ @@ -1168,7 +1185,22 @@ VOID ) { - EfiPrintf(L"Bad page list persistence \r\n"); + BL_PD_DATA_BLOB BadMemoryData; + NTSTATUS Status; + + /* Try to get the memory data from the memtest application */ + BadMemoryData.BlobSize = 0; + BadMemoryData.Data = NULL; + BadMemoryData.DataSize = 0; + Status = BlPdQueryData(&BadMemoryGuid, NULL, &BadMemoryData); + if (Status != STATUS_BUFFER_TOO_SMALL) + { + /* No results, or some other error */ + return Status; + } + + /* Not yet implemented */ + EfiPrintf(L"Bad page list persistence not implemented\r\n"); return STATUS_NOT_IMPLEMENTED; } @@ -1179,7 +1211,37 @@ _In_ ULONG Type ) { - EfiPrintf(L"Key BCD delete not yet implemented\r\n"); + HANDLE ObjectHandle; + NTSTATUS Status; + + /* Open the object */ + Status = BcdOpenObject(BcdHandle, ObjectId, &ObjectHandle); + if (NT_SUCCESS(Status)) + { + /* Delete the element */ + BcdDeleteElement(ObjectHandle, Type); + + /* Close the object and set success */ + BiCloseKey(ObjectHandle); + Status = STATUS_SUCCESS; + } + + /* Return the result */ + return Status; +} + +NTSTATUS +BmpPopulateBootEntryList ( + _In_ HANDLE BcdHandle, + _In_ PGUID SequenceList, + _In_ ULONG Flags, + _Out_ PBL_LOADED_APPLICATION_ENTRY* BootSequence, + _Out_ PULONG SequenceCount + ) +{ + EfiPrintf(L"Fixed sequences not yet supported\r\n"); + *SequenceCount = 0; + *BootSequence = NULL; return STATUS_NOT_IMPLEMENTED; } @@ -1193,9 +1255,50 @@ _Out_ PULONG SequenceCount ) { - EfiPrintf(L"Fixed sequences not yet supported\r\n"); + PBL_LOADED_APPLICATION_ENTRY* Sequence; + ULONG Count; + NTSTATUS Status; + + /* Allocate the sequence list */ + Sequence = BlMmAllocateHeap(SequenceListCount * sizeof(*Sequence)); + if (!Sequence) + { + return STATUS_NO_MEMORY; + } + + /* Populate the sequence list */ + Status = BmpPopulateBootEntryList(BcdHandle, + SequenceList, + Flags, + Sequence, + &Count); + if (!NT_SUCCESS(Status)) + { + /* Free the list on failure */ + BlMmFreeHeap(Sequence); + } + else + { + /* Otherwise, set success and return the list and count */ + Status = STATUS_SUCCESS; + *BootSequence = Sequence; + *SequenceCount = Count; + } + + /* All done */ + return Status; +} + +NTSTATUS +BmEnumerateBootEntries ( + _In_ HANDLE BcdHandle, + _Out_ PBL_LOADED_APPLICATION_ENTRY **Sequence, + _Out_ PULONG SequenceCount + ) +{ + EfiPrintf(L"Boot enumeration not yet implemented\r\n"); + *Sequence = NULL; *SequenceCount = 0; - *BootSequence = NULL; return STATUS_NOT_IMPLEMENTED; } @@ -1207,8 +1310,69 @@ _Out_ PBOOLEAN ExitBootManager ) { + NTSTATUS Status; + PBL_LOADED_APPLICATION_ENTRY* Sequence; + PBL_LOADED_APPLICATION_ENTRY Entry, SelectedEntry; + ULONG Count, BootIndex; + + /* Initialize locals */ + BootIndex = 0; + Count = 0; + Sequence = NULL; + SelectedEntry = NULL; + + /* Enumerate all the boot entries */ + Status = BmEnumerateBootEntries(BcdHandle, &Sequence, &Count); + if (!NT_SUCCESS(Status)) + { + /* Bail out if we failed */ + goto Quickie; + } + + /* Check if there are no entries */ + if (!Count) + { + /* This is fatal -- kill the system */ + Status = STATUS_FILE_INVALID; + BmFatalErrorEx(BL_FATAL_ERROR_BCD_ENTRIES, (ULONG_PTR)L"\\BCD", Status, 0, 0); + goto Quickie; + } + EfiPrintf(L"Boot selection not yet implemented\r\n"); - return STATUS_NOT_IMPLEMENTED; + *SelectedBootEntry = NULL; + +Quickie: + /* We are done -- did we have a sequence? */ + if (Sequence) + { + /* Do we have any boot entries we parsed? */ + while (BootIndex < Count) + { + /* Get the current boot entry */ + Entry = Sequence[BootIndex]; + + /* Did we fail, or is is not the selected one? */ + if ((Entry) && ((Entry != SelectedEntry) || !(NT_SUCCESS(Status)))) + { + /* Destroy it, as it won't be needed */ + BlDestroyBootEntry(Entry); + } + else if (Entry == SelectedEntry) + { + /* It's the selected one, return its index */ + *EntryIndex = BootIndex; + } + + /* Move to the next entry */ + BootIndex++; + } + + /* Free the sequence of entries */ + BlMmFreeHeap(Sequence); + } + + /* Return the selection result */ + return Status; } NTSTATUS Modified: trunk/reactos/boot/environ/app/bootmgr/bootmgr.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/app/bootmgr/b… ============================================================================== --- trunk/reactos/boot/environ/app/bootmgr/bootmgr.h [iso-8859-1] (original) +++ trunk/reactos/boot/environ/app/bootmgr/bootmgr.h [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -53,6 +53,7 @@ } BL_PACKED_BOOT_ERROR, *PBL_PACKED_BOOT_ERROR; #define BL_FATAL_ERROR_BCD_READ 0x01 +#define BL_FATAL_ERROR_BCD_ENTRIES 0x03 #define BL_FATAL_ERROR_GENERIC 0x04 #define BL_FATAL_ERROR_BCD_PARSE 0x07 Modified: trunk/reactos/boot/environ/include/bcd.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/bcd.h… ============================================================================== --- trunk/reactos/boot/environ/include/bcd.h [iso-8859-1] (original) +++ trunk/reactos/boot/environ/include/bcd.h [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -246,6 +246,12 @@ ); NTSTATUS +BcdDeleteElement ( + _In_ HANDLE ObjectHandle, + _In_ ULONG Type + ); + +NTSTATUS BcdEnumerateAndUnpackElements ( _In_ HANDLE BcdHandle, _In_ HANDLE ObjectHandle, Modified: trunk/reactos/boot/environ/include/bl.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/include/bl.h?… ============================================================================== --- trunk/reactos/boot/environ/include/bl.h [iso-8859-1] (original) +++ trunk/reactos/boot/environ/include/bl.h [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -46,6 +46,8 @@ #include <cmlib.h> /* DEFINES *******************************************************************/ + +DEFINE_GUID(BadMemoryGuid, 0x54B8275B, 0xD431, 0x473F, 0xAC, 0xFB, 0xE5, 0x36, 0xA0, 0x84, 0x94, 0xA3); #define BL_APPLICATION_FLAG_CONVERTED_FROM_EFI 0x01 @@ -1142,6 +1144,13 @@ ULONG Y; } COORD, *PCOORD; +typedef struct _BL_PD_DATA_BLOB +{ + PVOID Data; + ULONG DataSize; + ULONG BlobSize; +} BL_PD_DATA_BLOB, *PBL_PD_DATA_BLOB; + /* INLINE ROUTINES ***********************************************************/ FORCEINLINE @@ -1535,6 +1544,13 @@ _In_ PBL_LOADED_APPLICATION_ENTRY AppEntry ); +NTSTATUS +BlPdQueryData ( + _In_ const GUID* DataGuid, + _In_ PVOID Unknown, + _Inout_ PBL_PD_DATA_BLOB DataBlob + ); + /* FIRMWARE UTILITY ROUTINES *************************************************/ EFI_STATUS @@ -1772,6 +1788,11 @@ _In_ HANDLE KeyHandle, _Out_ PWCHAR** SubKeyList, _Out_ PULONG SubKeyCount + ); + +NTSTATUS +BiDeleteKey ( + _In_ HANDLE KeyHandle ); VOID Modified: trunk/reactos/boot/environ/lib/bootlib.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/lib/bootlib.c… ============================================================================== --- trunk/reactos/boot/environ/lib/bootlib.c [iso-8859-1] (original) +++ trunk/reactos/boot/environ/lib/bootlib.c [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -20,7 +20,7 @@ BOOLEAN BlpLibraryParametersInitialized; ULONG PdPersistAllocations; -LIST_ENTRY BlBadpListHead; +LIST_ENTRY BlpPdListHead; /* FUNCTIONS *****************************************************************/ @@ -283,7 +283,7 @@ /* Initialize the boot application persistent data */ PdPersistAllocations = 0; - InitializeListHead(&BlBadpListHead); + InitializeListHead(&BlpPdListHead); #ifdef BL_TPM_SUPPORT /* Now setup the security subsystem in phase 1 */ @@ -451,3 +451,29 @@ /* Free the entry itself */ BlMmFreeHeap(AppEntry); } + +NTSTATUS +BlPdQueryData ( + _In_ const GUID* DataGuid, + _In_ PVOID Unknown, + _Inout_ PBL_PD_DATA_BLOB DataBlob + ) +{ + /* Check for invalid or missing parameters */ + if (!(DataBlob) || + !(DataGuid) || + ((DataBlob->BlobSize) && !(DataBlob->Data))) + { + return STATUS_INVALID_PARAMETER; + } + + /* Check if there's no persistent data blobs */ + if (IsListEmpty(&BlpPdListHead)) + { + return STATUS_NOT_FOUND; + } + + /* Not yet handled, TODO */ + EfiPrintf(L"Boot persistent data not yet implemented\r\n"); + return STATUS_NOT_IMPLEMENTED; +} Modified: trunk/reactos/boot/environ/lib/misc/bcd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/lib/misc/bcd.… ============================================================================== --- trunk/reactos/boot/environ/lib/misc/bcd.c [iso-8859-1] (original) +++ trunk/reactos/boot/environ/lib/misc/bcd.c [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -553,6 +553,66 @@ } /* Return the final status */ + return Status; +} + +NTSTATUS +BcdDeleteElement ( + _In_ HANDLE ObjectHandle, + _In_ ULONG Type + ) +{ + NTSTATUS Status; + HANDLE ElementsHandle, ElementHandle; + WCHAR TypeString[22]; + + /* Open the elements key */ + Status = BiOpenKey(ObjectHandle, L"Elements", &ElementsHandle); + if (NT_SUCCESS(Status)) + { + /* Convert the element ID into a string */ + if (!_ultow(Type, TypeString, 16)) + { + /* Failed to do so */ + Status = STATUS_UNSUCCESSFUL; + } + else + { + /* Open the element specifically */ + Status = BiOpenKey(ElementHandle, TypeString, &ElementHandle); + if (NT_SUCCESS(Status)) + { + /* Delete it */ + Status = BiDeleteKey(ElementHandle); + if (NT_SUCCESS(Status)) + { + /* No point in closing the handle anymore */ + ElementHandle = NULL; + } + } + else + { + /* The element doesn't exist */ + Status = STATUS_NOT_FOUND; + } + + /* Check if we should close the key */ + if (ElementHandle) + { + /* Do it */ + BiCloseKey(ElementHandle); + } + } + } + + /* Check if we should close the elements handle */ + if (ElementsHandle) + { + /* Do it */ + BiCloseKey(ElementsHandle); + } + + /* Return whatever the result was */ return Status; } Modified: trunk/reactos/boot/environ/lib/misc/bootreg.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/environ/lib/misc/boot… ============================================================================== --- trunk/reactos/boot/environ/lib/misc/bootreg.c [iso-8859-1] (original) +++ trunk/reactos/boot/environ/lib/misc/bootreg.c [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -887,3 +887,66 @@ return Status; } +NTSTATUS +BiDeleteKey ( + _In_ HANDLE KeyHandle + ) +{ + NTSTATUS Status; + PBI_KEY_OBJECT KeyObject; + PHHIVE Hive; + ULONG SubKeyCount, i; + PWCHAR* SubKeyList; + HANDLE SubKeyHandle; + + /* Get the key object and hive */ + KeyObject = (PBI_KEY_OBJECT)KeyHandle; + Hive = &KeyObject->KeyHive->Hive.Hive; + + /* Make sure the hive is writeable */ + if (!(KeyObject->KeyHive->Flags & BI_HIVE_WRITEABLE)) + { + return STATUS_MEDIA_WRITE_PROTECTED; + } + + /* Enumerate all of the subkeys */ + Status = BiEnumerateSubKeys(KeyHandle, &SubKeyList, &SubKeyCount); + if ((NT_SUCCESS(Status)) && (SubKeyCount > 0)) + { + /* Loop through each one */ + for (i = 0; i < SubKeyCount; i++) + { + /* Open a handle to it */ + Status = BiOpenKey(KeyHandle, SubKeyList[i], &SubKeyHandle); + if (NT_SUCCESS(Status)) + { + /* Recursively call us to delete it */ + Status = BiDeleteKey(SubKeyHandle); + if (Status != STATUS_SUCCESS) + { + /* Close the key on failure */ + BiCloseKey(SubKeyHandle); + } + } + } + } + + /* Check if we had a list of subkeys */ + if (SubKeyList) + { + /* Free it */ + BlMmFreeHeap(SubKeyList); + } + + /* Delete this key cell */ + Status = CmpFreeKeyByCell(Hive, KeyObject->KeyCell, TRUE); + if (NT_SUCCESS(Status)) + { + /* Mark the hive as requiring a flush */ + KeyObject->KeyHive->Flags |= BI_FLUSH_HIVE; + BiCloseKey(KeyHandle); + } + + /* All done */ + return Status; +} Modified: trunk/reactos/lib/cmlib/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/CMakeLists.txt?r… ============================================================================== --- trunk/reactos/lib/cmlib/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/CMakeLists.txt [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -6,6 +6,7 @@ list(APPEND SOURCE cminit.c cmindex.c + cmkeydel.c cmname.c cmvalue.c hivebin.c Copied: trunk/reactos/lib/cmlib/cmkeydel.c (from r70605, trunk/reactos/ntoskrnl/config/cmkeydel.c) URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmkeydel.c?p2=tr… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmkeydel.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/cmkeydel.c [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -1,14 +1,14 @@ /* * PROJECT: ReactOS Kernel * LICENSE: GPL - See COPYING in the top level directory - * FILE: ntoskrnl/config/cmkeydel.c - * PURPOSE: Configuration Manager - Key Body Deletion + * FILE: lib/cmlib/cmkeydel.c + * PURPOSE: Configuration Manager Library - Key Body Deletion * PROGRAMMERS: Alex Ionescu (alex.ionescu(a)reactos.org) */ /* INCLUDES ******************************************************************/ -#include "ntoskrnl.h" +#include "cmlib.h" #define NDEBUG #include "debug.h" @@ -214,6 +214,9 @@ HvFreeCell(Hive, CellData->u.KeyNode.ValueList.List); } + /* FIXME: This leaks the security desriptor! */ + DPRINT1("Potentially leaking key security descriptor. Please call CmpFreeSecurityDescriptor"); + /* Free the key body itself, and then return our status */ if (!CmpFreeKeyBody(Hive, Cell)) return STATUS_INSUFFICIENT_RESOURCES; return STATUS_SUCCESS; Modified: trunk/reactos/lib/cmlib/cmlib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmlib.h?rev=7060… ============================================================================== --- trunk/reactos/lib/cmlib/cmlib.h [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/cmlib.h [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -671,6 +671,13 @@ IN HSTORAGE_TYPE StorageType ); +NTSTATUS +NTAPI +CmpFreeKeyByCell( + IN PHHIVE Hive, + IN HCELL_INDEX Cell, + IN BOOLEAN Unlink +); /******************************************************************************/ Removed: trunk/reactos/ntoskrnl/config/cmkeydel.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmkeydel.c… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmkeydel.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cmkeydel.c (removed) @@ -1,220 +0,0 @@ -/* - * PROJECT: ReactOS Kernel - * LICENSE: GPL - See COPYING in the top level directory - * FILE: ntoskrnl/config/cmkeydel.c - * PURPOSE: Configuration Manager - Key Body Deletion - * PROGRAMMERS: Alex Ionescu (alex.ionescu(a)reactos.org) - */ - -/* INCLUDES ******************************************************************/ - -#include "ntoskrnl.h" -#define NDEBUG -#include "debug.h" - -/* FUNCTIONS *****************************************************************/ - -BOOLEAN -NTAPI -CmpMarkKeyDirty(IN PHHIVE Hive, - IN HCELL_INDEX Cell, - IN BOOLEAN CheckNoSubkeys) -{ - PCELL_DATA CellData, ListData, SecurityData, ValueData; - ULONG i; - - /* Get the cell data for our target */ - CellData = HvGetCell(Hive, Cell); - if (!CellData) return FALSE; - - /* Check if sanity checks requested */ - if (CheckNoSubkeys) - { - /* Do them */ - ASSERT(CellData->u.KeyNode.SubKeyCounts[Stable] == 0); - ASSERT(CellData->u.KeyNode.SubKeyCounts[Volatile] == 0); - } - - /* If this is an exit hive, there's nothing to do */ - if (CellData->u.KeyNode.Flags & KEY_HIVE_EXIT) - { - /* Release the cell and get out */ - HvReleaseCell(Hive, Cell); - return TRUE; - } - - /* Otherwise, mark it dirty and release it */ - HvMarkCellDirty(Hive, Cell, FALSE); - HvReleaseCell(Hive, Cell); - - /* Check if we have a class */ - if (CellData->u.KeyNode.Class != HCELL_NIL) - { - /* Mark it dirty */ - HvMarkCellDirty(Hive, CellData->u.KeyNode.Class, FALSE); - } - - /* Check if we have security */ - if (CellData->u.KeyNode.Security != HCELL_NIL) - { - /* Mark it dirty */ - HvMarkCellDirty(Hive, CellData->u.KeyNode.Security, FALSE); - - /* Get the security data and release it */ - SecurityData = HvGetCell(Hive, CellData->u.KeyNode.Security); - if (!SecurityData) ASSERT(FALSE); - HvReleaseCell(Hive, CellData->u.KeyNode.Security); - - /* Mark the security links dirty too */ - HvMarkCellDirty(Hive, SecurityData->u.KeySecurity.Flink, FALSE); - HvMarkCellDirty(Hive, SecurityData->u.KeySecurity.Blink, FALSE); - } - - /* Check if we have any values */ - if (CellData->u.KeyNode.ValueList.Count > 0) - { - /* Dirty the value list */ - HvMarkCellDirty(Hive, CellData->u.KeyNode.ValueList.List, FALSE); - - /* Get the list data itself, and release it */ - ListData = HvGetCell(Hive, CellData->u.KeyNode.ValueList.List); - if (!ListData) ASSERT(FALSE); - HvReleaseCell(Hive, CellData->u.KeyNode.ValueList.List); - - /* Loop all values */ - for (i = 0; i < CellData->u.KeyNode.ValueList.Count; i++) - { - /* Dirty each value */ - HvMarkCellDirty(Hive, ListData->u.KeyList[i], FALSE); - - /* Get the value data and release it */ - ValueData = HvGetCell(Hive, ListData->u.KeyList[i]); - ASSERT(ValueData); - HvReleaseCell(Hive,ListData->u.KeyList[i]); - - /* Mark the value data dirty too */ - if (!CmpMarkValueDataDirty(Hive, &ValueData->u.KeyValue)) - { - /* Failure */ - return FALSE; - } - } - } - - /* If this is an entry hive, we're done */ - if (CellData->u.KeyNode.Flags & KEY_HIVE_ENTRY) return TRUE; - - /* Otherwise mark the index dirty too */ - if (!CmpMarkIndexDirty(Hive, CellData->u.KeyNode.Parent, Cell)) - { - /* Failure */ - return FALSE; - } - - /* Finally, mark the parent dirty */ - HvMarkCellDirty(Hive, CellData->u.KeyNode.Parent, FALSE); - return TRUE; -} - -BOOLEAN -NTAPI -CmpFreeKeyBody(IN PHHIVE Hive, - IN HCELL_INDEX Cell) -{ - PCELL_DATA CellData; - - /* Get the key node */ - CellData = HvGetCell(Hive, Cell); - if (!CellData) ASSERT(FALSE); - - /* Check if we can delete the child cells */ - if (!(CellData->u.KeyNode.Flags & KEY_HIVE_EXIT)) - { - /* Check if we have a security cell */ - if (CellData->u.KeyNode.Security != HCELL_NIL) - { - /* Free the security cell */ - HvFreeCell(Hive, CellData->u.KeyNode.Security); - } - - /* Check if we have a class */ - if (CellData->u.KeyNode.ClassLength > 0) - { - /* Free it */ - HvFreeCell(Hive, CellData->u.KeyNode.Class); - } - } - - /* Release and free the cell */ - HvReleaseCell(Hive, Cell); - HvFreeCell(Hive, Cell); - return TRUE; -} - -NTSTATUS -NTAPI -CmpFreeKeyByCell(IN PHHIVE Hive, - IN HCELL_INDEX Cell, - IN BOOLEAN Unlink) -{ - PCELL_DATA CellData, ParentData, ListData; - ULONG i; - BOOLEAN Result; - - /* Mark the entire key dirty */ - CmpMarkKeyDirty(Hive, Cell ,TRUE); - - /* Get the target node and release it */ - CellData = HvGetCell(Hive, Cell); - if (!CellData) ASSERT(FALSE); - HvReleaseCell(Hive, Cell); - - /* Make sure we don't have subkeys */ - ASSERT((CellData->u.KeyNode.SubKeyCounts[Stable] + - CellData->u.KeyNode.SubKeyCounts[Volatile]) == 0); - - /* Check if we have to unlink */ - if (Unlink) - { - /* Remove the subkey */ - Result = CmpRemoveSubKey(Hive, CellData->u.KeyNode.Parent, Cell); - if (!Result) return STATUS_INSUFFICIENT_RESOURCES; - - /* Get the parent node and release it */ - ParentData = HvGetCell(Hive, CellData->u.KeyNode.Parent); - if (!ParentData) ASSERT(FALSE); - HvReleaseCell(Hive, CellData->u.KeyNode.Parent); - - /* Check if the parent node has no more subkeys */ - if (!(ParentData->u.KeyNode.SubKeyCounts[Stable] + - ParentData->u.KeyNode.SubKeyCounts[Volatile])) - { - /* Then free the cached name/class lengths */ - ParentData->u.KeyNode.MaxNameLen = 0; - ParentData->u.KeyNode.MaxClassLen = 0; - } - } - - /* Check if we have any values */ - if (CellData->u.KeyNode.ValueList.Count > 0) - { - /* Get the value list and release it */ - ListData = HvGetCell(Hive, CellData->u.KeyNode.ValueList.List); - if (!ListData) ASSERT(FALSE); - HvReleaseCell(Hive, CellData->u.KeyNode.ValueList.List); - - /* Loop every value */ - for (i = 0; i < CellData->u.KeyNode.ValueList.Count; i++) - { - /* Free it */ - if (!CmpFreeValue(Hive, ListData->u.KeyList[i])) ASSERT(FALSE); - } - - /* Free the value list */ - HvFreeCell(Hive, CellData->u.KeyNode.ValueList.List); - } - - /* Free the key body itself, and then return our status */ - if (!CmpFreeKeyBody(Hive, Cell)) return STATUS_INSUFFICIENT_RESOURCES; - return STATUS_SUCCESS; -} Modified: trunk/reactos/ntoskrnl/include/internal/cm.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/… ============================================================================== --- trunk/reactos/ntoskrnl/include/internal/cm.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/cm.h [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -1059,14 +1059,6 @@ IN BOOLEAN LockHeld ); -NTSTATUS -NTAPI -CmpFreeKeyByCell( - IN PHHIVE Hive, - IN HCELL_INDEX Cell, - IN BOOLEAN Unlink -); - VOID NTAPI CmpAcquireTwoKcbLocksExclusiveByKey( Modified: trunk/reactos/ntoskrnl/ntos.cmake URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ntos.cmake?rev=70… ============================================================================== --- trunk/reactos/ntoskrnl/ntos.cmake [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ntos.cmake [iso-8859-1] Sun Jan 17 21:48:00 2016 @@ -58,7 +58,6 @@ ${REACTOS_SOURCE_DIR}/ntoskrnl/config/cmhvlist.c ${REACTOS_SOURCE_DIR}/ntoskrnl/config/cminit.c ${REACTOS_SOURCE_DIR}/ntoskrnl/config/cmkcbncb.c - ${REACTOS_SOURCE_DIR}/ntoskrnl/config/cmkeydel.c ${REACTOS_SOURCE_DIR}/ntoskrnl/config/cmlazy.c ${REACTOS_SOURCE_DIR}/ntoskrnl/config/cmmapvw.c ${REACTOS_SOURCE_DIR}/ntoskrnl/config/cmnotify.c

1 0

[ekohl] 70608: [USERINIT] Add missing newline for MSVC.
by ekohl＠svn.reactos.org 17 Jan '16

17 Jan '16

Author: ekohl Date: Sun Jan 17 19:37:18 2016 New Revision: 70608 URL: http://svn.reactos.org/svn/reactos?rev=70608&view=rev Log: [USERINIT] Add missing newline for MSVC. Modified: trunk/reactos/base/system/userinit/resource.h Modified: trunk/reactos/base/system/userinit/resource.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/resou… ============================================================================== --- trunk/reactos/base/system/userinit/resource.h [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/resource.h [iso-8859-1] Sun Jan 17 19:37:18 2016 @@ -30,4 +30,4 @@ -#define IDS_SPAIN 3900 +#define IDS_SPAIN 3900

1 0

[ekohl] 70607: [USERINIT] Add two dialogs that are shown when the LiveCD is booted. The first dialog is used to select the language and keyboard layout. The second dialog is used to either start th...
by ekohl＠svn.reactos.org 17 Jan '16

17 Jan '16

Author: ekohl Date: Sun Jan 17 19:20:47 2016 New Revision: 70607 URL: http://svn.reactos.org/svn/reactos?rev=70607&view=rev Log: [USERINIT] Add two dialogs that are shown when the LiveCD is booted. The first dialog is used to select the language and keyboard layout. The second dialog is used to either start the shell or the GUI installer. Language and keyboard layout selection are still work in progress. Added: trunk/reactos/base/system/userinit/livecd.c (with props) trunk/reactos/base/system/userinit/res/ (with props) trunk/reactos/base/system/userinit/res/rosbitmap.bmp (with props) trunk/reactos/base/system/userinit/userinit.h (with props) Modified: trunk/reactos/base/system/userinit/CMakeLists.txt trunk/reactos/base/system/userinit/lang/bg-BG.rc trunk/reactos/base/system/userinit/lang/cs-CZ.rc trunk/reactos/base/system/userinit/lang/de-DE.rc trunk/reactos/base/system/userinit/lang/el-GR.rc trunk/reactos/base/system/userinit/lang/en-US.rc trunk/reactos/base/system/userinit/lang/es-ES.rc trunk/reactos/base/system/userinit/lang/fr-FR.rc trunk/reactos/base/system/userinit/lang/he-IL.rc trunk/reactos/base/system/userinit/lang/hu-HU.rc trunk/reactos/base/system/userinit/lang/id-ID.rc trunk/reactos/base/system/userinit/lang/it-IT.rc trunk/reactos/base/system/userinit/lang/ja-JP.rc trunk/reactos/base/system/userinit/lang/lt-LT.rc trunk/reactos/base/system/userinit/lang/nl-NL.rc trunk/reactos/base/system/userinit/lang/no-NO.rc trunk/reactos/base/system/userinit/lang/pl-PL.rc trunk/reactos/base/system/userinit/lang/pt-BR.rc trunk/reactos/base/system/userinit/lang/ro-RO.rc trunk/reactos/base/system/userinit/lang/ru-RU.rc trunk/reactos/base/system/userinit/lang/sk-SK.rc trunk/reactos/base/system/userinit/lang/sq-AL.rc trunk/reactos/base/system/userinit/lang/sv-SE.rc trunk/reactos/base/system/userinit/lang/th-TH.rc trunk/reactos/base/system/userinit/lang/tr-TR.rc trunk/reactos/base/system/userinit/lang/uk-UA.rc trunk/reactos/base/system/userinit/lang/zh-CN.rc trunk/reactos/base/system/userinit/lang/zh-TW.rc trunk/reactos/base/system/userinit/resource.h trunk/reactos/base/system/userinit/userinit.c trunk/reactos/base/system/userinit/userinit.rc Modified: trunk/reactos/base/system/userinit/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/CMake… ============================================================================== --- trunk/reactos/base/system/userinit/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/CMakeLists.txt [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,12 @@ -add_executable(userinit userinit.c userinit.rc) +list(APPEND SOURCE + livecd.c + userinit.c + userinit.h) + +add_executable(userinit ${SOURCE} userinit.rc) target_link_libraries(userinit wine) set_module_type(userinit win32gui UNICODE) -add_importlibs(userinit user32 advapi32 shell32 msvcrt kernel32 ntdll) +add_importlibs(userinit user32 gdi32 advapi32 shell32 msvcrt kernel32 ntdll) +add_pch(userinit userinit.h SOURCE) add_cd_file(TARGET userinit DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/base/system/userinit/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/bg-BG.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/bg-BG.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_BULGARIAN, SUBLANG_DEFAULT + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "ÐÑÐ¸Ð»Ð¾Ð¶ÐµÐ½Ð¸ÐµÑÐ¾ userinit Ð½Ðµ ÑÑÐ¿Ñ Ð´Ð° Ð¿ÑÑÐ½Ðµ Ð¾Ð±Ð²Ð¸Ð²ÐºÐ°ÑÐ°!\n" + IDS_SHELL_FAIL "ÐÑÐ¸Ð»Ð¾Ð¶ÐµÐ½Ð¸ÐµÑÐ¾ userinit Ð½Ðµ ÑÑÐ¿Ñ Ð´Ð° Ð¿ÑÑÐ½Ðµ Ð¾Ð±Ð²Ð¸Ð²ÐºÐ°ÑÐ°!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/cs-CZ.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/cs-CZ.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -5,7 +5,46 @@ LANGUAGE LANG_CZECH, SUBLANG_DEFAULT +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Aplikace Userinit selhala pÅi spouÅ¡tÄnÃ uÅ¾ivatelskÃ©ho rozhranÃ!\n" + IDS_SHELL_FAIL "Aplikace Userinit selhala pÅi spouÅ¡tÄnÃ uÅ¾ivatelskÃ©ho rozhranÃ!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/de-DE.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_GERMAN, SUBLANG_NEUTRAL + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit konnte die Shell nicht starten!\n" + IDS_SHELL_FAIL "Userinit konnte die Shell nicht starten!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/el-GR.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/el-GR.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -2,7 +2,46 @@ LANGUAGE LANG_GREEK, SUBLANG_DEFAULT +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "H Userinit Î´Îµ Î¼ÏÏÏÎµÏÎµ Î½Î± ÎµÎºÎºÎ¹Î½Î®ÏÎµÎ¹ ÏÎ¿ ÎºÎÎ»ÏÏÎ¿Ï!\n" + IDS_SHELL_FAIL "H Userinit Î´Îµ Î¼ÏÏÏÎµÏÎµ Î½Î± ÎµÎºÎºÎ¹Î½Î®ÏÎµÎ¹ ÏÎ¿ ÎºÎÎ»ÏÏÎ¿Ï!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/en-US.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/en-US.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit failed to start the shell!\n" + IDS_SHELL_FAIL "Userinit failed to start the shell!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/es-ES.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/es-ES.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_SPANISH, SUBLANG_NEUTRAL + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit no pudo iniciar el shell con Ã©xito!\n" + IDS_SHELL_FAIL "Userinit no pudo iniciar el shell con Ã©xito!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/fr-FR.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_FRENCH, SUBLANG_NEUTRAL + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit a Ã©chouÃ© lors du chargement de l'interface (shell) !\n" + IDS_SHELL_FAIL "Userinit a Ã©chouÃ© lors du chargement de l'interface (shell) !\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/he-IL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/he-IL.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/he-IL.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_HEBREW, SUBLANG_DEFAULT + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit × ××©× ×××¤×¢×× ××ª ××××©×§!\n" + IDS_SHELL_FAIL "Userinit × ××©× ×××¤×¢×× ××ª ××××©×§!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/hu-HU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/hu-HU.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/hu-HU.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -2,7 +2,46 @@ LANGUAGE LANG_HUNGARIAN, SUBLANG_DEFAULT +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Az Userinit nem tudja elindÃtani a rendszert!\n" + IDS_SHELL_FAIL "Az Userinit nem tudja elindÃtani a rendszert!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/id-ID.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/id-ID.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/id-ID.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_INDONESIAN, SUBLANG_DEFAULT + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit gagal untuk memulai shell!\n" + IDS_SHELL_FAIL "Userinit gagal untuk memulai shell!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/it-IT.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/it-IT.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_ITALIAN, SUBLANG_NEUTRAL + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit non ha potuto avviare l'ambiente(shell)!\n" + IDS_SHELL_FAIL "Userinit non ha potuto avviare l'ambiente(shell)!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/ja-JP.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/ja-JP.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/ja-JP.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_JAPANESE, SUBLANG_DEFAULT + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit ã¯ã·ã§ã«ãéå§ã§ãã¾ããã§ãã!\n" + IDS_SHELL_FAIL "Userinit ã¯ã·ã§ã«ãéå§ã§ãã¾ããã§ãã!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/lt-LT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/lt-LT.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/lt-LT.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -2,7 +2,46 @@ LANGUAGE LANG_LITHUANIAN, SUBLANG_DEFAULT +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit nepavyko paleisti aplinkos!\n" + IDS_SHELL_FAIL "Userinit nepavyko paleisti aplinkos!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/nl-NL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/nl-NL.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/nl-NL.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -2,7 +2,46 @@ LANGUAGE LANG_DUTCH, SUBLANG_NEUTRAL +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit kon de shell niet starten!\n" + IDS_SHELL_FAIL "Userinit kon de shell niet starten!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/no-NO.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/no-NO.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_NORWEGIAN, SUBLANG_NEUTRAL + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit mislykket Ã¥ starte skall!\n" + IDS_SHELL_FAIL "Userinit mislykket Ã¥ starte skall!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/pl-PL.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/pl-PL.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -7,7 +7,46 @@ LANGUAGE LANG_POLISH, SUBLANG_DEFAULT +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Nie powiodÅo siÄ uruchomienie powÅoki przez userinit!\n" + IDS_SHELL_FAIL "Nie powiodÅo siÄ uruchomienie powÅoki przez userinit!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/pt-BR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/pt-BR.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/pt-BR.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_PORTUGUESE, SUBLANG_NEUTRAL + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit falhou ao tentar iniciar o shell!\n" + IDS_SHELL_FAIL "Userinit falhou ao tentar iniciar o shell!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/ro-RO.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/ro-RO.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -2,7 +2,46 @@ LANGUAGE LANG_ROMANIAN, SUBLANG_NEUTRAL +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit a eÈuat Ã®n lansarea interfeÈei!\n" + IDS_SHELL_FAIL "Userinit a eÈuat Ã®n lansarea interfeÈei!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/ru-RU.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/ru-RU.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_RUSSIAN, SUBLANG_DEFAULT + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "ÐÑÐ¸Ð±ÐºÐ° Ð·Ð°Ð¿ÑÑÐºÐ° Ð¾Ð±Ð¾Ð»Ð¾ÑÐºÐ¸ Ð¿ÑÐ¸ Ð¸Ð½Ð¸ÑÐ¸Ð°Ð»Ð¸Ð·Ð°ÑÐ¸Ð¸ Ð¿Ð¾Ð»ÑÐ·Ð¾Ð²Ð°ÑÐµÐ»ÑÑÐºÐ¾Ð³Ð¾ ÑÐµÐ°Ð½ÑÐ°!\n" + IDS_SHELL_FAIL "ÐÑÐ¸Ð±ÐºÐ° Ð·Ð°Ð¿ÑÑÐºÐ° Ð¾Ð±Ð¾Ð»Ð¾ÑÐºÐ¸ Ð¿ÑÐ¸ Ð¸Ð½Ð¸ÑÐ¸Ð°Ð»Ð¸Ð·Ð°ÑÐ¸Ð¸ Ð¿Ð¾Ð»ÑÐ·Ð¾Ð²Ð°ÑÐµÐ»ÑÑÐºÐ¾Ð³Ð¾ ÑÐµÐ°Ð½ÑÐ°!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/sk-SK.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/sk-SK.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -2,7 +2,46 @@ LANGUAGE LANG_SLOVAK, SUBLANG_DEFAULT +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL, "Userinit zlyhal pri spÃºÅ¡Å¥anÃ shellu!\n" + IDS_SHELL_FAIL "Userinit zlyhal pri spÃºÅ¡Å¥anÃ shellu!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/sq-AL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/sq-AL.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/sq-AL.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -4,7 +4,46 @@ LANGUAGE LANG_ALBANIAN, SUBLANG_NEUTRAL +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit dÃ«shtuar pÃ«r tÃ« filluar shell'in!\n" + IDS_SHELL_FAIL "Userinit dÃ«shtuar pÃ«r tÃ« filluar shell'in!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/sv-SE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/sv-SE.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/sv-SE.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,7 +1,47 @@ /* Translated by David Nordenberg */ LANGUAGE LANG_SWEDISH, SUBLANG_NEUTRAL + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit misslyckades att starta anvÃ¤ndargrÃ¤nssnittet!\n" + IDS_SHELL_FAIL "Userinit misslyckades att starta anvÃ¤ndargrÃ¤nssnittet!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/th-TH.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/th-TH.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/th-TH.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,6 +1,45 @@ LANGUAGE LANG_THAI, SUBLANG_DEFAULT + +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END STRINGTABLE BEGIN - STRING_USERINIT_FAIL "à¸à¹à¸²à¸à¸¹à¹à¹à¸à¹à¸à¸´à¸à¸à¸¥à¸²à¸à¹à¸à¸à¸à¸à¹à¸à¹à¸²à¸ªà¸¹à¹à¸à¸±à¹à¸à¸ªà¸à¸²à¸à¸°!\n" + IDS_SHELL_FAIL "à¸à¹à¸²à¸à¸¹à¹à¹à¸à¹à¸à¸´à¸à¸à¸¥à¸²à¸à¹à¸à¸à¸à¸à¹à¸à¹à¸²à¸ªà¸¹à¹à¸à¸±à¹à¸à¸ªà¸à¸²à¸à¸°!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/tr-TR.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/tr-TR.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -2,7 +2,46 @@ LANGUAGE LANG_TURKISH, SUBLANG_DEFAULT +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit, kabuÄu baÅlatmada baÅarÄ±sÄ±z oldu!\n" + IDS_SHELL_FAIL "Userinit, kabuÄu baÅlatmada baÅarÄ±sÄ±z oldu!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/uk-UA.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/uk-UA.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -8,7 +8,46 @@ LANGUAGE LANG_UKRAINIAN, SUBLANG_DEFAULT +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit Ð½Ðµ Ð²Ð´Ð°Ð»Ð¾ÑÑ Ð·Ð°Ð¿ÑÑÑÐ¸ÑÐ¸ Ð¾Ð±Ð¾Ð»Ð¾Ð½ÐºÑ!\n" + IDS_SHELL_FAIL "Userinit Ð½Ðµ Ð²Ð´Ð°Ð»Ð¾ÑÑ Ð·Ð°Ð¿ÑÑÑÐ¸ÑÐ¸ Ð¾Ð±Ð¾Ð»Ð¾Ð½ÐºÑ!\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/zh-CN.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/zh-CN.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/zh-CN.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -2,7 +2,46 @@ LANGUAGE LANG_CHINESE, SUBLANG_CHINESE_SIMPLIFIED +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit æ æ³å¯å¨å¤å£³ï¼\n" + IDS_SHELL_FAIL "Userinit æ æ³å¯å¨å¤å£³ï¼\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Modified: trunk/reactos/base/system/userinit/lang/zh-TW.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/lang/… ============================================================================== --- trunk/reactos/base/system/userinit/lang/zh-TW.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/lang/zh-TW.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -2,7 +2,46 @@ LANGUAGE LANG_CHINESE, SUBLANG_CHINESE_TRADITIONAL +IDD_LOCALEPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_LOCALELOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + RTEXT "Language:", IDC_STATIC, 20, 109, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LANGUAGELIST, 132, 107, 176, 142, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + RTEXT "Keyboard layout:", IDC_STATIC, 20, 132, 106, 11, WS_CHILD | WS_VISIBLE | WS_GROUP + COMBOBOX IDC_LAYOUTLIST, 132, 130, 176, 81, CBS_DROPDOWNLIST | CBS_SORT | WS_VSCROLL | WS_CHILD | WS_VISIBLE | WS_TABSTOP + LTEXT "Select your language and keyboard layout and click Next to continue.", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + DEFPUSHBUTTON "&Next", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + +IDD_STARTPAGE DIALOGEX 0, 0, 317, 193 +STYLE DS_SHELLFONT | DS_MODALFRAME | WS_POPUP | WS_VISIBLE | WS_CAPTION +CAPTION "ReactOS LiveCD" +FONT 8, "MS Shell Dlg" +BEGIN + CONTROL "IDB_LOGO", IDC_STARTLOGO, "Static", WS_CHILD | WS_VISIBLE | SS_OWNERDRAW, 18, 0, 290, 99 + DEFPUSHBUTTON "Run ReactOS &Live CD", IDC_RUN, 71, 102, 175, 21 + PUSHBUTTON "&Install ReactOS", IDC_INSTALL, 71, 130, 175, 21 + + LTEXT "", IDC_STATIC, 7, 152, 300, 8 + + GROUPBOX "", IDC_STATIC, 0, 165, 317, 1 + PUSHBUTTON "&Previous", IDOK, 205, 172, 50, 14 + PUSHBUTTON "&Cancel", IDCANCEL, 260, 172, 50, 14 +END + STRINGTABLE BEGIN - STRING_USERINIT_FAIL "Userinit ç¡æ³ååå¤æ®¼ï¼\n" + IDS_SHELL_FAIL "Userinit ç¡æ³ååå¤æ®¼ï¼\n" + IDS_INSTALLER_FAIL "Userinit failed to start the installer!\n" END + +STRINGTABLE +BEGIN + IDS_SPAIN "Spanish (Spain)" +END Added: trunk/reactos/base/system/userinit/livecd.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/livec… ============================================================================== --- trunk/reactos/base/system/userinit/livecd.c (added) +++ trunk/reactos/base/system/userinit/livecd.c [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -0,0 +1,530 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS Userinit Logon Application + * FILE: base/system/userinit/livecd.c + * PROGRAMMERS: Eric Kohl + */ + +#include "userinit.h" + +HWND hList; +HWND hLocaleList; +BOOL bSpain = FALSE; + +static VOID +InitImageInfo(PIMGINFO ImgInfo) +{ + BITMAP bitmap; + + ZeroMemory(ImgInfo, sizeof(*ImgInfo)); + + ImgInfo->hBitmap = LoadImage(hInstance, + MAKEINTRESOURCE(IDB_ROSLOGO), + IMAGE_BITMAP, + 0, + 0, + LR_DEFAULTCOLOR); + + if (ImgInfo->hBitmap != NULL) + { + GetObject(ImgInfo->hBitmap, sizeof(BITMAP), &bitmap); + + ImgInfo->cxSource = bitmap.bmWidth; + ImgInfo->cySource = bitmap.bmHeight; + } +} + + +BOOL +IsLiveCD(VOID) +{ + HKEY ControlKey = NULL; + LPWSTR SystemStartOptions = NULL; + LPWSTR CurrentOption, NextOption; /* Pointers into SystemStartOptions */ + LONG rc; + BOOL ret = FALSE; + + TRACE("IsLiveCD()\n"); + + rc = RegOpenKeyEx(HKEY_LOCAL_MACHINE, + REGSTR_PATH_CURRENT_CONTROL_SET, + 0, + KEY_QUERY_VALUE, + &ControlKey); + if (rc != ERROR_SUCCESS) + { + WARN("RegOpenKeyEx() failed with error %lu\n", rc); + goto cleanup; + } + + rc = ReadRegSzKey(ControlKey, L"SystemStartOptions", &SystemStartOptions); + if (rc != ERROR_SUCCESS) + { + WARN("ReadRegSzKey() failed with error %lu\n", rc); + goto cleanup; + } + + /* Check for CONSOLE switch in SystemStartOptions */ + CurrentOption = SystemStartOptions; + while (CurrentOption) + { + NextOption = wcschr(CurrentOption, L' '); + if (NextOption) + *NextOption = L'\0'; + if (_wcsicmp(CurrentOption, L"MININT") == 0) + { + TRACE("Found 'MININT' boot option\n"); + ret = TRUE; + goto cleanup; + } + CurrentOption = NextOption ? NextOption + 1 : NULL; + } + +cleanup: + if (ControlKey != NULL) + RegCloseKey(ControlKey); + HeapFree(GetProcessHeap(), 0, SystemStartOptions); + + TRACE("IsLiveCD() returning %d\n", ret); + + return ret; +} + + +static BOOL CALLBACK +LocalesEnumProc(LPTSTR lpLocale) +{ + LCID lcid; + WCHAR lang[255]; + INT index; + BOOL bNoShow = FALSE; + + lcid = wcstoul(lpLocale, NULL, 16); + + /* Display only languages with installed support */ + if (!IsValidLocale(lcid, LCID_INSTALLED)) + return TRUE; + + if (lcid == MAKELCID(MAKELANGID(LANG_SPANISH, SUBLANG_SPANISH), SORT_DEFAULT) || + lcid == MAKELCID(MAKELANGID(LANG_SPANISH, SUBLANG_SPANISH_MODERN), SORT_DEFAULT)) + { + if (bSpain == FALSE) + { + LoadStringW(hInstance, IDS_SPAIN, lang, 255); + bSpain = TRUE; + } + else + { + bNoShow = TRUE; + } + } + else + { + GetLocaleInfoW(lcid, LOCALE_SLANGUAGE, lang, sizeof(lang)/sizeof(WCHAR)); + } + + if (bNoShow == FALSE) + { + index = SendMessageW(hList, + CB_ADDSTRING, + 0, + (LPARAM)lang); + + SendMessageW(hList, + CB_SETITEMDATA, + index, + (LPARAM)lcid); + } + + return TRUE; +} + + +static VOID +CreateLanguagesList(HWND hwnd) +{ + WCHAR langSel[255]; + + hList = hwnd; + bSpain = FALSE; + EnumSystemLocalesW(LocalesEnumProc, LCID_SUPPORTED); + + /* Select current locale */ + /* or should it be System and not user? */ + GetLocaleInfoW(GetUserDefaultLCID(), LOCALE_SLANGUAGE, langSel, sizeof(langSel)/sizeof(WCHAR)); + + SendMessageW(hList, + CB_SELECTSTRING, + -1, + (LPARAM)langSel); +} + + +static +VOID +InitializeDefaultUserLocale( + PLCID pNewLcid) +{ + WCHAR szBuffer[80]; + PWSTR ptr; + HKEY hLocaleKey; + DWORD ret; + DWORD dwSize; + LCID lcid; + INT i; + + struct {LCTYPE LCType; PWSTR pValue;} LocaleData[] = { + /* Number */ + {LOCALE_SDECIMAL, L"sDecimal"}, + {LOCALE_STHOUSAND, L"sThousand"}, + {LOCALE_SNEGATIVESIGN, L"sNegativeSign"}, + {LOCALE_SPOSITIVESIGN, L"sPositiveSign"}, + {LOCALE_SGROUPING, L"sGrouping"}, + {LOCALE_SLIST, L"sList"}, + {LOCALE_SNATIVEDIGITS, L"sNativeDigits"}, + {LOCALE_INEGNUMBER, L"iNegNumber"}, + {LOCALE_IDIGITS, L"iDigits"}, + {LOCALE_ILZERO, L"iLZero"}, + {LOCALE_IMEASURE, L"iMeasure"}, + {LOCALE_IDIGITSUBSTITUTION, L"NumShape"}, + + /* Currency */ + {LOCALE_SCURRENCY, L"sCurrency"}, + {LOCALE_SMONDECIMALSEP, L"sMonDecimalSep"}, + {LOCALE_SMONTHOUSANDSEP, L"sMonThousandSep"}, + {LOCALE_SMONGROUPING, L"sMonGrouping"}, + {LOCALE_ICURRENCY, L"iCurrency"}, + {LOCALE_INEGCURR, L"iNegCurr"}, + {LOCALE_ICURRDIGITS, L"iCurrDigits"}, + + /* Time */ + {LOCALE_STIMEFORMAT, L"sTimeFormat"}, + {LOCALE_STIME, L"sTime"}, + {LOCALE_S1159, L"s1159"}, + {LOCALE_S2359, L"s2359"}, + {LOCALE_ITIME, L"iTime"}, + {LOCALE_ITIMEMARKPOSN, L"iTimePrefix"}, + {LOCALE_ITLZERO, L"iTLZero"}, + + /* Date */ + {LOCALE_SLONGDATE, L"sLongDate"}, + {LOCALE_SSHORTDATE, L"sShortDate"}, + {LOCALE_SDATE, L"sDate"}, + {LOCALE_IFIRSTDAYOFWEEK, L"iFirstDayOfWeek"}, + {LOCALE_IFIRSTWEEKOFYEAR, L"iFirstWeekOfYear"}, + {LOCALE_IDATE, L"iDate"}, + {LOCALE_ICALENDARTYPE, L"iCalendarType"}, + + /* Misc */ + {LOCALE_SCOUNTRY, L"sCountry"}, + {LOCALE_SLANGUAGE, L"sLanguage"}, + {LOCALE_ICOUNTRY, L"iCountry"}, + {0, NULL}}; + + ret = RegOpenKeyExW(HKEY_USERS, + L".DEFAULT\\Control Panel\\International", + 0, + KEY_READ | KEY_WRITE, + &hLocaleKey); + if (ret != ERROR_SUCCESS) + { + return; + } + + if (pNewLcid == NULL) + { + dwSize = 9 * sizeof(WCHAR); + ret = RegQueryValueExW(hLocaleKey, + L"Locale", + NULL, + NULL, + (PBYTE)szBuffer, + &dwSize); + if (ret != ERROR_SUCCESS) + goto done; + + lcid = (LCID)wcstoul(szBuffer, &ptr, 16); + if (lcid == 0) + goto done; + } + else + { + lcid = *pNewLcid; + + swprintf(szBuffer, L"%08lx", lcid); + RegSetValueExW(hLocaleKey, + L"Locale", + 0, + REG_SZ, + (PBYTE)szBuffer, + (wcslen(szBuffer) + 1) * sizeof(WCHAR)); + } + + i = 0; + while (LocaleData[i].pValue != NULL) + { + if (GetLocaleInfo(lcid, + LocaleData[i].LCType | LOCALE_NOUSEROVERRIDE, + szBuffer, + sizeof(szBuffer) / sizeof(WCHAR))) + { + RegSetValueExW(hLocaleKey, + LocaleData[i].pValue, + 0, + REG_SZ, + (PBYTE)szBuffer, + (wcslen(szBuffer) + 1) * sizeof(WCHAR)); + } + + i++; + } + +done: + RegCloseKey(hLocaleKey); +} + + +VOID +CenterWindow(HWND hWnd) +{ + HWND hWndParent; + RECT rcParent; + RECT rcWindow; + + hWndParent = GetParent(hWnd); + if (hWndParent == NULL) + hWndParent = GetDesktopWindow(); + + GetWindowRect(hWndParent, &rcParent); + GetWindowRect(hWnd, &rcWindow); + + SetWindowPos(hWnd, + HWND_TOP, + ((rcParent.right - rcParent.left) - (rcWindow.right - rcWindow.left)) / 2, + ((rcParent.bottom - rcParent.top) - (rcWindow.bottom - rcWindow.top)) / 2, + 0, + 0, + SWP_NOSIZE); +} + + +static +VOID +OnDrawItem( + LPDRAWITEMSTRUCT lpDrawItem, + PSTATE pState, + UINT uCtlID) +{ + HDC hdcMem; + LONG left; + + if (lpDrawItem->CtlID == uCtlID) + { + /* position image in centre of dialog */ + left = (lpDrawItem->rcItem.right - pState->ImageInfo.cxSource) / 2; + + hdcMem = CreateCompatibleDC(lpDrawItem->hDC); + if (hdcMem != NULL) + { + SelectObject(hdcMem, pState->ImageInfo.hBitmap); + BitBlt(lpDrawItem->hDC, + left, + lpDrawItem->rcItem.top, + lpDrawItem->rcItem.right - lpDrawItem->rcItem.left, + lpDrawItem->rcItem.bottom - lpDrawItem->rcItem.top, + hdcMem, + 0, + 0, + SRCCOPY); + DeleteDC(hdcMem); + } + } +} + + +static +INT_PTR +CALLBACK +LocaleDlgProc( + HWND hwndDlg, + UINT uMsg, + WPARAM wParam, + LPARAM lParam) +{ + PSTATE pState; + + /* Retrieve pointer to the state */ + pState = (PSTATE)GetWindowLongPtr (hwndDlg, GWL_USERDATA); + + switch (uMsg) + { + case WM_INITDIALOG: + /* Save pointer to the global state */ + pState = (PSTATE)lParam; + SetWindowLongPtr(hwndDlg, GWL_USERDATA, (DWORD_PTR)pState); + + /* Center the dialog window */ + CenterWindow (hwndDlg); + CreateLanguagesList(GetDlgItem(hwndDlg, IDC_LANGUAGELIST)); + + EnableWindow(GetDlgItem(hwndDlg, IDCANCEL), FALSE); + return FALSE; + + case WM_DRAWITEM: + OnDrawItem((LPDRAWITEMSTRUCT)lParam, + pState, + IDC_LOCALELOGO); + return TRUE; + + case WM_COMMAND: + if (HIWORD(wParam) == BN_CLICKED) + { + switch (LOWORD(wParam)) + { + case IDOK: + { + LCID NewLcid; + INT iCurSel; + + iCurSel = SendDlgItemMessageW(hwndDlg, + IDC_LANGUAGELIST, + CB_GETCURSEL, + 0, + 0); + if (iCurSel == CB_ERR) + break; + + NewLcid = SendDlgItemMessageW(hwndDlg, + IDC_LANGUAGELIST, + CB_GETITEMDATA, + iCurSel, + 0); + if (NewLcid == (LCID)CB_ERR) + break; + + SetThreadLocale(NewLcid); + InitializeDefaultUserLocale(&NewLcid); + } + + pState->NextPage = STARTPAGE; + EndDialog(hwndDlg, 0); + break; + + default: + break; + } + } + break; + + default: + break; + } + + return FALSE; +} + + +static +INT_PTR +CALLBACK +StartDlgProc( + HWND hwndDlg, + UINT uMsg, + WPARAM wParam, + LPARAM lParam) +{ + PSTATE pState; + + /* Retrieve pointer to the state */ + pState = (PSTATE)GetWindowLongPtr (hwndDlg, GWL_USERDATA); + + switch (uMsg) + { + case WM_INITDIALOG: + /* Save pointer to the state */ + pState = (PSTATE)lParam; + SetWindowLongPtr(hwndDlg, GWL_USERDATA, (DWORD_PTR)pState); + + /* Center the dialog window */ + CenterWindow(hwndDlg); + + EnableWindow(GetDlgItem(hwndDlg, IDCANCEL), FALSE); + return FALSE; + + case WM_DRAWITEM: + OnDrawItem((LPDRAWITEMSTRUCT)lParam, + pState, + IDC_STARTLOGO); + return TRUE; + + case WM_COMMAND: + if (HIWORD(wParam) == BN_CLICKED) + { + switch (LOWORD(wParam)) + { + case IDC_RUN: + pState->NextPage = DONE; + pState->Run = SHELL; + EndDialog(hwndDlg, 0); + break; + + case IDC_INSTALL: + pState->NextPage = DONE; + pState->Run = INSTALLER; + EndDialog(hwndDlg, 0); + break; + + case IDOK: + pState->NextPage = LOCALEPAGE; + EndDialog(hwndDlg, 0); + break; + + default: + break; + } + } + break; + + default: + break; + } + + return FALSE; +} + + +VOID +RunLiveCD( + PSTATE pState) +{ + InitImageInfo(&pState->ImageInfo); + + while (pState->NextPage != DONE) + { + switch (pState->NextPage) + { + case LOCALEPAGE: + DialogBoxParam(hInstance, + MAKEINTRESOURCE(IDD_LOCALEPAGE), + NULL, + LocaleDlgProc, + (LPARAM)pState); + break; + + case STARTPAGE: + DialogBoxParam(hInstance, + MAKEINTRESOURCE(IDD_STARTPAGE), + NULL, + StartDlgProc, + (LPARAM)pState); + break; + + default: + break; + } + } + + DeleteObject(pState->ImageInfo.hBitmap); +} + +/* EOF */ Propchange: trunk/reactos/base/system/userinit/livecd.c ------------------------------------------------------------------------------ svn:eol-style = native Propchange: trunk/reactos/base/system/userinit/res/ ------------------------------------------------------------------------------ --- bugtraq:logregex (added) +++ bugtraq:logregex Sun Jan 17 19:20:47 2016 @@ -0,0 +1 @@ +((CORE|ROSTESTS|ROSAPPS)-\d+)(,? ?((CORE|ROSTESTS|ROSAPPS)-\d+))*(,? ?(and |or )?((CORE|ROSTESTS|ROSAPPS)-\d+))? Propchange: trunk/reactos/base/system/userinit/res/ ------------------------------------------------------------------------------ bugtraq:message = See issue %BUGID% for more details. Propchange: trunk/reactos/base/system/userinit/res/ ------------------------------------------------------------------------------ bugtraq:url = https://jira.reactos.org/browse/%BUGID% Propchange: trunk/reactos/base/system/userinit/res/ ------------------------------------------------------------------------------ tsvn:logminsize = 10 Added: trunk/reactos/base/system/userinit/res/rosbitmap.bmp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/res/r… ============================================================================== Binary file - no diff available. Propchange: trunk/reactos/base/system/userinit/res/rosbitmap.bmp ------------------------------------------------------------------------------ svn:mime-type = application/octet-stream Modified: trunk/reactos/base/system/userinit/resource.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/resou… ============================================================================== --- trunk/reactos/base/system/userinit/resource.h [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/resource.h [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,4 +1,33 @@ #pragma once #define RC_STRING_MAX_SIZE 2048 -#define STRING_USERINIT_FAIL 100 + +/* Bitmaps */ +#define IDB_ROSLOGO 100 + +#define IDC_STATIC -1 + + +/* Dialogs */ +#define IDD_LOCALEPAGE 200 +#define IDC_LOCALELOGO 201 +#define IDC_LANGUAGELIST 202 +#define IDC_FORMATLIST 203 +#define IDC_LAYOUTLIST 204 + +#define IDD_STARTPAGE 300 +#define IDC_STARTLOGO 301 +#define IDC_RUN 302 +#define IDC_INSTALL 303 +#define IDC_UPDATE 304 +#define IDC_REPAIR 305 + + +/* Strings */ +#define IDS_SHELL_FAIL 600 +#define IDS_INSTALLER_FAIL 601 + + + + +#define IDS_SPAIN 3900 Modified: trunk/reactos/base/system/userinit/userinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/useri… ============================================================================== --- trunk/reactos/base/system/userinit/userinit.c [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/userinit.c [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -24,37 +24,22 @@ * Hervé Poussineau (hpoussin(a)reactos.org) */ -#define WIN32_NO_STATUS -#define _INC_WINDOWS -#define COM_NO_WINDOWS_H -#include <stdarg.h> -#include <windef.h> -#include <winbase.h> -#include <winreg.h> -#include <wingdi.h> -#include <wincon.h> -#include <shellapi.h> -#include <regstr.h> -#include <shlobj.h> -#include <shlwapi.h> -#include <undocuser.h> -#include <wine/debug.h> - -#include "resource.h" - -WINE_DEFAULT_DEBUG_CHANNEL(userinit); +#include "userinit.h" #define CMP_MAGIC 0x01234567 /* GLOBALS ******************************************************************/ +HINSTANCE hInstance; + + /* FUNCTIONS ****************************************************************/ -static LONG +LONG ReadRegSzKey( IN HKEY hKey, IN LPCWSTR pszKey, - OUT LPWSTR* pValue) + OUT LPWSTR *pValue) { LONG rc; DWORD dwType; @@ -382,7 +367,7 @@ if (!TryToStartShell(Shell)) { WARN("Failed to start default shell %s\n", debugstr_w(Shell)); - LoadString( GetModuleHandle(NULL), STRING_USERINIT_FAIL, szMsg, sizeof(szMsg) / sizeof(szMsg[0])); + LoadString( GetModuleHandle(NULL), IDS_SHELL_FAIL, szMsg, sizeof(szMsg) / sizeof(szMsg[0])); MessageBox(0, szMsg, NULL, 0); } } @@ -548,6 +533,27 @@ WARN("LoadLibrary() failed with error %lu\n", GetLastError()); } +static +VOID +StartInstaller(VOID) +{ + WCHAR Shell[MAX_PATH]; + WCHAR szMsg[RC_STRING_MAX_SIZE]; + + if (GetWindowsDirectory(Shell, MAX_PATH - 12)) + wcscat(Shell, L"\\reactos.exe"); + else + wcscpy(Shell, L"reactos.exe"); + + if (!TryToStartShell(Shell)) + { + ERR("Failed to start the installer: %s\n", debugstr_w(Shell)); + LoadStringW(GetModuleHandle(NULL), IDS_INSTALLER_FAIL, szMsg, sizeof(szMsg) / sizeof(szMsg[0])); + MessageBoxW(0, szMsg, NULL, 0); + } +} + + #ifdef _MSC_VER #pragma warning(disable : 4100) #endif /* _MSC_VER */ @@ -558,9 +564,38 @@ IN LPWSTR lpszCmdLine, IN int nCmdShow) { + STATE State; + + hInstance = hInst; + SetUserSettings(); - StartShell(); - NotifyLogon(); + + if (IsLiveCD()) + { + State.NextPage = LOCALEPAGE; + State.Run = SHELL; + } + else + { + State.NextPage = DONE; + State.Run = SHELL; + } + + if (State.NextPage != DONE) + { + RunLiveCD(&State); + } + + if (State.Run == SHELL) + { + StartShell(); + NotifyLogon(); + } + else if (State.Run == INSTALLER) + { + StartInstaller(); + } + return 0; } Added: trunk/reactos/base/system/userinit/userinit.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/useri… ============================================================================== --- trunk/reactos/base/system/userinit/userinit.h (added) +++ trunk/reactos/base/system/userinit/userinit.h [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -0,0 +1,74 @@ +/* + */ + +#ifndef __USERINIT_H__ +#define __USERINIT_H__ + +#define WIN32_NO_STATUS +#define _INC_WINDOWS +#define COM_NO_WINDOWS_H +#include <stdarg.h> +#include <windef.h> +#include <winbase.h> +#include <winreg.h> +#include <wingdi.h> +#include <wincon.h> +#include <shellapi.h> +#include <regstr.h> +#include <shlobj.h> +#include <shlwapi.h> +#include <undocuser.h> +#include <winnls.h> +#include <stdio.h> + +#include <wine/debug.h> +WINE_DEFAULT_DEBUG_CHANNEL(userinit); + +#include "resource.h" + + +typedef enum +{ + LOCALEPAGE, + STARTPAGE, + DONE +} PAGESTATE; + +typedef enum +{ + SHELL, + INSTALLER +} RUN; + +typedef struct _IMGINFO +{ + HBITMAP hBitmap; + INT cxSource; + INT cySource; +} IMGINFO, *PIMGINFO; + +typedef struct +{ + PAGESTATE NextPage; + RUN Run; + IMGINFO ImageInfo; +} STATE, *PSTATE; + + +extern HINSTANCE hInstance; + +LONG +ReadRegSzKey( + IN HKEY hKey, + IN LPCWSTR pszKey, + OUT LPWSTR *pValue); + +BOOL +IsLiveCD(VOID); + + +VOID +RunLiveCD( + PSTATE State); + +#endif /* __USERINIT_H__ */ Propchange: trunk/reactos/base/system/userinit/userinit.h ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/reactos/base/system/userinit/userinit.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/userinit/useri… ============================================================================== --- trunk/reactos/base/system/userinit/userinit.rc [iso-8859-1] (original) +++ trunk/reactos/base/system/userinit/userinit.rc [iso-8859-1] Sun Jan 17 19:20:47 2016 @@ -1,4 +1,5 @@ #include <windef.h> +#include <winuser.h> #include "resource.h" @@ -6,6 +7,10 @@ #define REACTOS_STR_INTERNAL_NAME "userinit" #define REACTOS_STR_ORIGINAL_FILENAME "userinit.dll" #include <reactos/version.rc> + +/* Bitmaps */ +IDB_ROSLOGO BITMAP "res/rosbitmap.bmp" + /* UTF-8 */ #pragma code_page(65001)

1 0

[spetreolle] 70606: [FLOPPY] Check for controller configuration status. CORE-10761 #comment Please retest.
by spetreolle＠svn.reactos.org 17 Jan '16

17 Jan '16

Author: spetreolle Date: Sun Jan 17 16:59:55 2016 New Revision: 70606 URL: http://svn.reactos.org/svn/reactos?rev=70606&view=rev Log: [FLOPPY] Check for controller configuration status. CORE-10761 #comment Please retest. Modified: trunk/reactos/drivers/storage/floppy/floppy.c Modified: trunk/reactos/drivers/storage/floppy/floppy.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/storage/floppy/flo… ============================================================================== --- trunk/reactos/drivers/storage/floppy/floppy.c [iso-8859-1] (original) +++ trunk/reactos/drivers/storage/floppy/floppy.c [iso-8859-1] Sun Jan 17 16:59:55 2016 @@ -680,7 +680,11 @@ TRACE_(FLOPPY, "InitController called with Controller 0x%p\n", ControllerInfo); /* Get controller in a known state */ - HwConfigure(ControllerInfo, FALSE, TRUE, TRUE, 0, 0); + if(HwConfigure(ControllerInfo, FALSE, TRUE, TRUE, 0, 0) != STATUS_SUCCESS) + { + WARN_(FLOPPY, "InitController: unable to configure controller\n"); + return STATUS_IO_DEVICE_ERROR; + } /* Get the controller version */ ControllerVersion = HwGetVersion(ControllerInfo);

1 0

[hbelusca] 70605: [CMLIB] - Now that both FreeLdr and MKHIVE use the regular (aka. the "NT-style public") CMLIB functions, get rid of the "old-style public" cmlib functions, with the exception of C...
by hbelusca＠svn.reactos.org 17 Jan '16

17 Jan '16

Author: hbelusca Date: Sun Jan 17 02:12:37 2016 New Revision: 70605 URL: http://svn.reactos.org/svn/reactos?rev=70605&view=rev Log: [CMLIB] - Now that both FreeLdr and MKHIVE use the regular (aka. the "NT-style public") CMLIB functions, get rid of the "old-style public" cmlib functions, with the exception of CmCreateRootNode and CmPrepareHive which remain for now due to a slight different implementation difference between NT and ours. Remove the cmtools.c file containing those old functions. - Remove the now-deprecated VALUE_LIST_CELL structure (which was an old version of CELL_DATA:KeyList). - When freeing hive bins (in HvpFreeHiveBins), use the storage number count stored in the hive instead of a constant value. - Flat hives have only one storage type (they are read-only and reside only in memory). CORE-10802 CORE-10793 Removed: trunk/reactos/lib/cmlib/cmtools.c Modified: trunk/reactos/lib/cmlib/CMakeLists.txt trunk/reactos/lib/cmlib/cmdata.h trunk/reactos/lib/cmlib/cminit.c trunk/reactos/lib/cmlib/cmlib.h trunk/reactos/lib/cmlib/hiveinit.c Modified: trunk/reactos/lib/cmlib/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/CMakeLists.txt?r… ============================================================================== --- trunk/reactos/lib/cmlib/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/CMakeLists.txt [iso-8859-1] Sun Jan 17 02:12:37 2016 @@ -7,7 +7,6 @@ cminit.c cmindex.c cmname.c - cmtools.c cmvalue.c hivebin.c hivecell.c Modified: trunk/reactos/lib/cmlib/cmdata.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmdata.h?rev=706… ============================================================================== --- trunk/reactos/lib/cmlib/cmdata.h [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/cmdata.h [iso-8859-1] Sun Jan 17 02:12:37 2016 @@ -27,16 +27,16 @@ // // CM_KEY_NODE Flags // -#define KEY_IS_VOLATILE 0x01 -#define KEY_HIVE_EXIT 0x02 -#define KEY_HIVE_ENTRY 0x04 -#define KEY_NO_DELETE 0x08 -#define KEY_SYM_LINK 0x10 -#define KEY_COMP_NAME 0x20 -#define KEY_PREFEF_HANDLE 0x40 -#define KEY_VIRT_MIRRORED 0x80 -#define KEY_VIRT_TARGET 0x100 -#define KEY_VIRTUAL_STORE 0x200 +#define KEY_IS_VOLATILE 0x0001 +#define KEY_HIVE_EXIT 0x0002 +#define KEY_HIVE_ENTRY 0x0004 +#define KEY_NO_DELETE 0x0008 +#define KEY_SYM_LINK 0x0010 +#define KEY_COMP_NAME 0x0020 +#define KEY_PREFEF_HANDLE 0x0040 +#define KEY_VIRT_MIRRORED 0x0080 +#define KEY_VIRT_TARGET 0x0100 +#define KEY_VIRTUAL_STORE 0x0200 // // CM_KEY_VALUE Flags @@ -67,7 +67,7 @@ } CM_VIEW_OF_FILE, *PCM_VIEW_OF_FILE; // -// Children of Key Notes +// Children of Key Nodes // typedef struct _CHILD_LIST { @@ -117,14 +117,6 @@ } CM_KEY_NODE, *PCM_KEY_NODE; // -// Value List -// -typedef struct _VALUE_LIST_CELL -{ - HCELL_INDEX ValueOffset[ANYSIZE_ARRAY]; -} VALUE_LIST_CELL, *PVALUE_LIST_CELL; - -// // Value Key // typedef struct _CM_KEY_VALUE Modified: trunk/reactos/lib/cmlib/cminit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cminit.c?rev=706… ============================================================================== --- trunk/reactos/lib/cmlib/cminit.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/cminit.c [iso-8859-1] Sun Jan 17 02:12:37 2016 @@ -37,7 +37,11 @@ /* Get the key cell */ KeyCell = (PCM_KEY_NODE)HvGetCell(Hive, RootCellIndex); - if (!KeyCell) return FALSE; + if (!KeyCell) + { + HvFreeCell(Hive, RootCellIndex); + return FALSE; + } /* Setup the cell */ KeyCell->Signature = CM_KEY_NODE_SIGNATURE; Modified: trunk/reactos/lib/cmlib/cmlib.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmlib.h?rev=7060… ============================================================================== --- trunk/reactos/lib/cmlib/cmlib.h [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/cmlib.h [iso-8859-1] Sun Jan 17 02:12:37 2016 @@ -33,7 +33,7 @@ #ifdef _WIN32 #define strncasecmp _strnicmp #define strcasecmp _stricmp - #endif//_WIN32 + #endif // _WIN32 #if (!defined(_MSC_VER) || (_MSC_VER < 1500)) #define _In_ @@ -68,6 +68,7 @@ #define USHORT_MAX USHRT_MAX #define OBJ_NAME_PATH_SEPARATOR ((WCHAR)L'\\') + #define UNICODE_NULL ((WCHAR)0) VOID NTAPI KeQuerySystemTime( @@ -161,7 +162,7 @@ // // These define the Debug Masks Supported // -#define CMLIB_HCELL_DEBUG 0x01 +#define CMLIB_HCELL_DEBUG 0x01 #ifndef ROUND_UP #define ROUND_UP(a,b) ((((a)+(b)-1)/(b))*(b)) @@ -191,12 +192,17 @@ #include "hivedata.h" #include "cmdata.h" -#if defined(_TYPEDEFS_HOST_H) || defined(__FREELDR_H) - -#define PCM_KEY_SECURITY_CACHE_ENTRY PVOID -#define PCM_KEY_CONTROL_BLOCK PVOID -#define CMP_SECURITY_HASH_LISTS 64 -#define PCM_CELL_REMAP_BLOCK PVOID +#if defined(_TYPEDEFS_HOST_H) || defined(__FREELDR_H) // || defined(_BLDR_) + +#define PCM_KEY_SECURITY_CACHE_ENTRY PVOID +#define PCM_KEY_CONTROL_BLOCK PVOID +#define PCM_CELL_REMAP_BLOCK PVOID + +// See also ntoskrnl/include/internal/cm.h +#define CMP_SECURITY_HASH_LISTS 64 + +// #endif // Commented out until one finds a way to properly include + // this header in freeldr and in ntoskrnl. // // Use Count Log and Entry @@ -263,7 +269,7 @@ PKTHREAD CreatorOwner; } CMHIVE, *PCMHIVE; -#endif +#endif // See comment above typedef struct _HV_HIVE_CELL_PAIR { @@ -466,54 +472,8 @@ CmPrepareHive( PHHIVE RegistryHive); -BOOLEAN -NTAPI -CmCompareHash( - IN PCUNICODE_STRING KeyName, - IN PCHAR HashString, - IN BOOLEAN CaseInsensitive); - -BOOLEAN -NTAPI -CmComparePackedNames( - IN PCUNICODE_STRING Name, - IN PVOID NameBuffer, - IN USHORT NameBufferSize, - IN BOOLEAN NamePacked, - IN BOOLEAN CaseInsensitive); - -BOOLEAN -NTAPI -CmCompareKeyName( - IN PCM_KEY_NODE KeyCell, - IN PCUNICODE_STRING KeyName, - IN BOOLEAN CaseInsensitive); - -BOOLEAN -NTAPI -CmCompareKeyValueName( - IN PCM_KEY_VALUE ValueCell, - IN PCUNICODE_STRING KeyName, - IN BOOLEAN CaseInsensitive); - -ULONG -NTAPI -CmCopyKeyName( - _In_ PCM_KEY_NODE KeyNode, - _Out_ PWCHAR KeyNameBuffer, - _Inout_ ULONG BufferLength); - -ULONG -NTAPI -CmCopyKeyValueName( - _In_ PCM_KEY_VALUE ValueCell, - _Out_ PWCHAR ValueNameBuffer, - _Inout_ ULONG BufferLength); - - /* NT-style Public Cm functions */ - // // Cell Index Routines @@ -615,8 +575,8 @@ IN PHHIVE Hive, IN PCHILD_LIST ChildList, IN PUNICODE_STRING Name, - IN PULONG ChildIndex, - IN PHCELL_INDEX CellIndex + OUT PULONG ChildIndex, + OUT PHCELL_INDEX CellIndex ); @@ -695,7 +655,7 @@ CmpGetValueData( IN PHHIVE Hive, IN PCM_KEY_VALUE Value, - IN PULONG Length, + OUT PULONG Length, OUT PVOID *Buffer, OUT PBOOLEAN BufferAllocated, OUT PHCELL_INDEX CellToRelease Removed: trunk/reactos/lib/cmlib/cmtools.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmtools.c?rev=70… ============================================================================== --- trunk/reactos/lib/cmlib/cmtools.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/cmtools.c (removed) @@ -1,222 +0,0 @@ -/* - * PROJECT: Registry manipulation library - * LICENSE: GPL - See COPYING in the top level directory - * COPYRIGHT: Copyright 2005 Filip Navara <navaraf(a)reactos.org> - * Copyright 2001 - 2005 Eric Kohl - */ - -#include "cmlib.h" -#define NDEBUG -#include <debug.h> - -BOOLEAN -NTAPI -CmCompareHash( - IN PCUNICODE_STRING KeyName, - IN PCHAR HashString, - IN BOOLEAN CaseInsensitive) -{ - CHAR Buffer[4]; - - Buffer[0] = (KeyName->Length >= 2) ? (CHAR)KeyName->Buffer[0] : 0; - Buffer[1] = (KeyName->Length >= 4) ? (CHAR)KeyName->Buffer[1] : 0; - Buffer[2] = (KeyName->Length >= 6) ? (CHAR)KeyName->Buffer[2] : 0; - Buffer[3] = (KeyName->Length >= 8) ? (CHAR)KeyName->Buffer[3] : 0; - - if (CaseInsensitive) - { - return (strncasecmp(Buffer, HashString, 4) == 0); - } - else - { - return (strncmp(Buffer, HashString, 4) == 0); - } -} - -BOOLEAN -NTAPI -CmComparePackedNames( - IN PCUNICODE_STRING CompareName, - IN PVOID Name, - IN USHORT NameLength, - IN BOOLEAN NamePacked, - IN BOOLEAN CaseInsensitive) -{ - ULONG i; - - if (NamePacked) - { - PUCHAR PackedName = (PUCHAR)Name; - - if (CompareName->Length != NameLength * sizeof(WCHAR)) - { - //DPRINT1("Length doesn'T match %lu / %lu\n", CompareName->Length, NameLength); - return FALSE; - } - - if (CaseInsensitive) - { - for (i = 0; i < CompareName->Length / sizeof(WCHAR); i++) - { - //DbgPrint("%c/%c,", - // RtlUpcaseUnicodeChar(CompareName->Buffer[i]), - // RtlUpcaseUnicodeChar(PackedName[i])); - if (RtlUpcaseUnicodeChar(CompareName->Buffer[i]) != - RtlUpcaseUnicodeChar(PackedName[i])) - { - //DbgPrint("\nFailed!\n"); - return FALSE; - } - } - //DbgPrint("\nSuccess!\n"); - } - else - { - for (i = 0; i < CompareName->Length / sizeof(WCHAR); i++) - { - if (CompareName->Buffer[i] != PackedName[i]) - return FALSE; - } - } - - } - else - { - PWCHAR UnicodeName = (PWCHAR)Name; - - if (CompareName->Length != NameLength) - return FALSE; - - if (CaseInsensitive) - { - for (i = 0; i < CompareName->Length / sizeof(WCHAR); i++) - { - if (RtlUpcaseUnicodeChar(CompareName->Buffer[i]) != - RtlUpcaseUnicodeChar(UnicodeName[i])) - return FALSE; - } - } - else - { - for (i = 0; i < CompareName->Length / sizeof(WCHAR); i++) - { - if (CompareName->Buffer[i] != UnicodeName[i]) - return FALSE; - } - } - } - - return TRUE; -} - - -BOOLEAN -NTAPI -CmCompareKeyName( - IN PCM_KEY_NODE KeyNode, - IN PCUNICODE_STRING KeyName, - IN BOOLEAN CaseInsensitive) -{ - ASSERT(KeyNode->Signature == CM_KEY_NODE_SIGNATURE); - return CmComparePackedNames(KeyName, - KeyNode->Name, - KeyNode->NameLength, - (KeyNode->Flags & KEY_COMP_NAME) ? TRUE : FALSE, - CaseInsensitive); -} - -BOOLEAN -NTAPI -CmCompareKeyValueName( - IN PCM_KEY_VALUE ValueCell, - IN PCUNICODE_STRING ValueName, - IN BOOLEAN CaseInsensitive) -{ - ASSERT(ValueCell->Signature == CM_KEY_VALUE_SIGNATURE); - return CmComparePackedNames(ValueName, - ValueCell->Name, - ValueCell->NameLength, - (ValueCell->Flags & VALUE_COMP_NAME) ? TRUE : FALSE, - CaseInsensitive); -} - -ULONG -NTAPI -CmCopyPackedName( - _Out_ PWCHAR Buffer, - _In_ ULONG BufferLength, - _In_ PVOID Name, - _In_ USHORT NameLength, - _In_ BOOLEAN NamePacked) -{ - ULONG CharCount, i; - ASSERT(Name != 0); - ASSERT(NameLength != 0); - - if (NamePacked) - { - NameLength *= sizeof(WCHAR); - CharCount = min(BufferLength, NameLength) / sizeof(WCHAR); - - if (Buffer != NULL) - { - PUCHAR PackedName = (PUCHAR)Name; - - for (i = 0; i < CharCount; i++) - { - Buffer[i] = PackedName[i]; - } - } - } - else - { - CharCount = min(BufferLength, NameLength) / sizeof(WCHAR); - - if (Buffer != NULL) - { - PWCHAR UnicodeName = (PWCHAR)Name; - - for (i = 0; i < CharCount; i++) - { - Buffer[i] = UnicodeName[i]; - } - } - } - - if (BufferLength >= NameLength + sizeof(WCHAR)) - { - Buffer[NameLength / sizeof(WCHAR)] = '\0'; - } - - return NameLength + sizeof(WCHAR); -} - -ULONG -NTAPI -CmCopyKeyName( - _In_ PCM_KEY_NODE KeyNode, - _Out_ PWCHAR KeyNameBuffer, - _Inout_ ULONG BufferLength) -{ - ASSERT(KeyNode->Signature == CM_KEY_NODE_SIGNATURE); - return CmCopyPackedName(KeyNameBuffer, - BufferLength, - KeyNode->Name, - KeyNode->NameLength, - (KeyNode->Flags & KEY_COMP_NAME) ? TRUE : FALSE); -} - -ULONG -NTAPI -CmCopyKeyValueName( - _In_ PCM_KEY_VALUE ValueCell, - _Out_ PWCHAR ValueNameBuffer, - _Inout_ ULONG BufferLength) -{ - ASSERT(ValueCell->Signature == CM_KEY_VALUE_SIGNATURE); - return CmCopyPackedName(ValueNameBuffer, - BufferLength, - ValueCell->Name, - ValueCell->NameLength, - (ValueCell->Flags & VALUE_COMP_NAME) ? TRUE : FALSE); -} Modified: trunk/reactos/lib/cmlib/hiveinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/hiveinit.c?rev=7… ============================================================================== --- trunk/reactos/lib/cmlib/hiveinit.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/hiveinit.c [iso-8859-1] Sun Jan 17 02:12:37 2016 @@ -57,7 +57,7 @@ PHBIN Bin; ULONG Storage; - for (Storage = Stable; Storage < HTYPE_COUNT; Storage++) + for (Storage = 0; Storage < Hive->StorageTypeCount; Storage++) { Bin = NULL; for (i = 0; i < Hive->Storage[Storage].Length; i++) @@ -353,6 +353,8 @@ Hive->Version = ChunkBase->Minor; Hive->Flat = TRUE; Hive->ReadOnly = TRUE; + + Hive->StorageTypeCount = 1; /* Set default boot type */ ChunkBase->BootType = 0;

1 0

[hbelusca] 70604: [FREELDR] Make FreeLdr fully using the CMLIB library. CORE-10802 #resolve CORE-10793
by hbelusca＠svn.reactos.org 17 Jan '16

17 Jan '16

Author: hbelusca Date: Sun Jan 17 01:42:11 2016 New Revision: 70604 URL: http://svn.reactos.org/svn/reactos?rev=70604&view=rev Log: [FREELDR] Make FreeLdr fully using the CMLIB library. CORE-10802 #resolve CORE-10793 Modified: trunk/reactos/boot/freeldr/freeldr/windows/registry.c trunk/reactos/boot/freeldr/freeldr/windows/registry.h trunk/reactos/boot/freeldr/freeldr/windows/wlregistry.c Modified: trunk/reactos/boot/freeldr/freeldr/windows/registry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/windows/registry.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/windows/registry.c [iso-8859-1] Sun Jan 17 01:42:11 2016 @@ -29,23 +29,46 @@ static PCM_KEY_NODE RootKeyNode; static HKEY CurrentControlSetKey; +PVOID +NTAPI +CmpAllocate( + IN SIZE_T Size, + IN BOOLEAN Paged, + IN ULONG Tag) +{ + UNREFERENCED_PARAMETER(Paged); + UNREFERENCED_PARAMETER(Tag); + + return FrLdrTempAlloc(Size, Tag); +} + +VOID +NTAPI +CmpFree( + IN PVOID Ptr, + IN ULONG Quota) +{ + UNREFERENCED_PARAMETER(Quota); + FrLdrTempFree(Ptr, 0); +} + BOOLEAN RegImportBinaryHive( - _In_ PCHAR ChunkBase, + _In_ PVOID ChunkBase, _In_ ULONG ChunkSize) { NTSTATUS Status; TRACE("RegImportBinaryHive(%p, 0x%lx)\n", ChunkBase, ChunkSize); /* Allocate and initialize the hive */ - CmHive = FrLdrTempAlloc(sizeof(CMHIVE), 'eviH'); + CmHive = CmpAllocate(sizeof(CMHIVE), FALSE, 'eviH'); Status = HvInitialize(&CmHive->Hive, - HINIT_FLAT, + HINIT_FLAT, // HINIT_MEMORY_INPLACE 0, 0, ChunkBase, - NULL, - NULL, + CmpAllocate, + CmpFree, NULL, NULL, NULL, @@ -54,22 +77,16 @@ NULL); if (!NT_SUCCESS(Status)) { - FrLdrTempFree(CmHive, 'eviH'); - ERR("Invalid hive Signature!\n"); + CmpFree(CmHive, 0); + ERR("Corrupted hive %p!\n", ChunkBase); return FALSE; } /* Save the root key node */ - RootKeyNode = HvGetCell(&CmHive->Hive, CmHive->Hive.BaseBlock->RootCell); + RootKeyNode = (PCM_KEY_NODE)HvGetCell(&CmHive->Hive, CmHive->Hive.BaseBlock->RootCell); TRACE("RegImportBinaryHive done\n"); return TRUE; -} - -VOID -RegInitializeRegistry(VOID) -{ - /* Nothing to do */ } LONG @@ -203,62 +220,6 @@ return TRUE; } -static -PCM_KEY_NODE -RegpFindSubkeyInIndex( - _In_ PHHIVE Hive, - _In_ PCM_KEY_INDEX IndexCell, - _In_ PUNICODE_STRING SubKeyName) -{ - PCM_KEY_NODE SubKeyNode; - ULONG i; - TRACE("RegpFindSubkeyInIndex('%wZ')\n", SubKeyName); - - /* Check the cell type */ - if ((IndexCell->Signature == CM_KEY_INDEX_ROOT) || - (IndexCell->Signature == CM_KEY_INDEX_LEAF)) - { - ASSERT(FALSE); - - /* Enumerate subindex cells */ - for (i = 0; i < IndexCell->Count; i++) - { - /* Get the subindex cell and call the function recursively */ - PCM_KEY_INDEX SubIndexCell = HvGetCell(Hive, IndexCell->List[i]); - - SubKeyNode = RegpFindSubkeyInIndex(Hive, SubIndexCell, SubKeyName); - if (SubKeyNode != NULL) - { - return SubKeyNode; - } - } - } - else if ((IndexCell->Signature == CM_KEY_FAST_LEAF) || - (IndexCell->Signature == CM_KEY_HASH_LEAF)) - { - /* Directly enumerate subkey nodes */ - PCM_KEY_FAST_INDEX HashCell = (PCM_KEY_FAST_INDEX)IndexCell; - for (i = 0; i < HashCell->Count; i++) - { - SubKeyNode = HvGetCell(Hive, HashCell->List[i].Cell); - ASSERT(SubKeyNode->Signature == CM_KEY_NODE_SIGNATURE); - - TRACE(" RegpFindSubkeyInIndex: checking '%.*s'\n", - SubKeyNode->NameLength, SubKeyNode->Name); - if (CmCompareKeyName(SubKeyNode, SubKeyName, TRUE)) - { - return SubKeyNode; - } - } - } - else - { - ASSERT(FALSE); - } - - return NULL; -} - LONG RegEnumKey( _In_ HKEY Key, @@ -269,8 +230,9 @@ { PHHIVE Hive = &CmHive->Hive; PCM_KEY_NODE KeyNode, SubKeyNode; - PCM_KEY_INDEX IndexCell; - PCM_KEY_FAST_INDEX HashCell; + HCELL_INDEX CellIndex; + USHORT NameLength; + TRACE("RegEnumKey(%p, %lu, %p, %p->%u)\n", Key, Index, Name, NameSize, NameSize ? *NameSize : 0); @@ -278,40 +240,52 @@ KeyNode = (PCM_KEY_NODE)Key; ASSERT(KeyNode->Signature == CM_KEY_NODE_SIGNATURE); - /* Check if the index is valid */ - if ((KeyNode->SubKeyCounts[Stable] == 0) || - (Index >= KeyNode->SubKeyCounts[Stable])) - { - TRACE("RegEnumKey index out of bounds\n"); + CellIndex = CmpFindSubKeyByNumber(Hive, KeyNode, Index); + if (CellIndex == HCELL_NIL) + { + TRACE("RegEnumKey index out of bounds (%d) in key (%.*s)\n", + Index, KeyNode->NameLength, KeyNode->Name); return ERROR_NO_MORE_ITEMS; } - /* Get the index cell */ - IndexCell = HvGetCell(Hive, KeyNode->SubKeyLists[Stable]); - TRACE("IndexCell: %x, SubKeyCounts: %x\n", IndexCell, KeyNode->SubKeyCounts[Stable]); - - /* Check the cell type */ - if ((IndexCell->Signature == CM_KEY_FAST_LEAF) || - (IndexCell->Signature == CM_KEY_HASH_LEAF)) - { - /* Get the value cell */ - HashCell = (PCM_KEY_FAST_INDEX)IndexCell; - SubKeyNode = HvGetCell(Hive, HashCell->List[Index].Cell); + /* Get the value cell */ + SubKeyNode = (PCM_KEY_NODE)HvGetCell(Hive, CellIndex); + ASSERT(SubKeyNode != NULL); + ASSERT(SubKeyNode->Signature == CM_KEY_NODE_SIGNATURE); + + if (SubKeyNode->Flags & KEY_COMP_NAME) + { + NameLength = CmpCompressedNameSize(SubKeyNode->Name, SubKeyNode->NameLength); + + /* Compressed name */ + CmpCopyCompressedName(Name, + *NameSize, + SubKeyNode->Name, + SubKeyNode->NameLength); } else { - ASSERT(FALSE); - } - - *NameSize = CmCopyKeyName(SubKeyNode, Name, *NameSize); + NameLength = SubKeyNode->NameLength; + + /* Normal name */ + RtlCopyMemory(Name, SubKeyNode->Name, + min(*NameSize, SubKeyNode->NameLength)); + } + + if (*NameSize >= NameLength + sizeof(WCHAR)) + { + Name[NameLength / sizeof(WCHAR)] = UNICODE_NULL; + } + + *NameSize = NameLength + sizeof(WCHAR); + + /**/HvReleaseCell(Hive, CellIndex);/**/ if (SubKey != NULL) - { *SubKey = (HKEY)SubKeyNode; - } - - TRACE("RegEnumKey done -> %u, '%.*s'\n", *NameSize, *NameSize, Name); - return STATUS_SUCCESS; + + TRACE("RegEnumKey done -> %u, '%.*S'\n", *NameSize, *NameSize, Name); + return ERROR_SUCCESS; } LONG @@ -324,7 +298,7 @@ UNICODE_STRING CurrentControlSet = RTL_CONSTANT_STRING(L"CurrentControlSet"); PHHIVE Hive = &CmHive->Hive; PCM_KEY_NODE KeyNode; - PCM_KEY_INDEX IndexCell; + HCELL_INDEX CellIndex; TRACE("RegOpenKey(%p, '%S', %p)\n", ParentKey, KeyName, Key); /* Initialize the remaining path name */ @@ -400,27 +374,22 @@ { TRACE("RegOpenKey: next element '%wZ'\n", &SubKeyName); - /* Check if there is any subkey */ - if (KeyNode->SubKeyCounts[Stable] == 0) + /* Get the next sub key */ + CellIndex = CmpFindSubKeyByName(Hive, KeyNode, &SubKeyName); + if (CellIndex == HCELL_NIL) { + ERR("Did not find sub key '%wZ' (full %S)\n", &SubKeyName, KeyName); return ERROR_PATH_NOT_FOUND; } - /* Get the top level index cell */ - IndexCell = HvGetCell(Hive, KeyNode->SubKeyLists[Stable]); - - /* Get the next sub key */ - KeyNode = RegpFindSubkeyInIndex(Hive, IndexCell, &SubKeyName); - if (KeyNode == NULL) - { - - ERR("Did not find sub key '%wZ' (full %S)\n", &RemainingPath, KeyName); - return ERROR_PATH_NOT_FOUND; - } - } + /* Get the found key */ + KeyNode = (PCM_KEY_NODE)HvGetCell(Hive, CellIndex); + ASSERT(KeyNode); + } + + *Key = (HKEY)KeyNode; TRACE("RegOpenKey done\n"); - *Key = (HKEY)KeyNode; return ERROR_SUCCESS; } @@ -434,40 +403,27 @@ _Inout_opt_ ULONG* DataSize) { ULONG DataLength; + PVOID DataCell; /* Does the caller want the type? */ if (Type != NULL) - { *Type = ValueCell->Type; - } /* Does the caller provide DataSize? */ if (DataSize != NULL) { - /* Get the data length */ - DataLength = ValueCell->DataLength & ~CM_KEY_VALUE_SPECIAL_SIZE; + // NOTE: CmpValueToData doesn't support big data (the function will + // bugcheck if so), FreeLdr is not supposed to read such data. + // If big data is needed, use instead CmpGetValueData. + // CmpGetValueData(Hive, ValueCell, DataSize, &DataCell, ...); + DataCell = CmpValueToData(Hive, ValueCell, &DataLength); /* Does the caller want the data? */ if ((Data != NULL) && (*DataSize != 0)) { - /* Check where the data is stored */ - if ((DataLength <= sizeof(HCELL_INDEX)) && - (ValueCell->DataLength & CM_KEY_VALUE_SPECIAL_SIZE)) - { - /* The data member contains the data */ - RtlCopyMemory(Data, - &ValueCell->Data, - min(*DataSize, DataLength)); - } - else - { - /* The data member contains the data cell index */ - PVOID DataCell = HvGetCell(Hive, ValueCell->Data); - RtlCopyMemory(Data, - DataCell, - min(*DataSize, ValueCell->DataLength)); - } - + RtlCopyMemory(Data, + DataCell, + min(*DataSize, DataLength)); } /* Return the actual data length */ @@ -486,9 +442,9 @@ PHHIVE Hive = &CmHive->Hive; PCM_KEY_NODE KeyNode; PCM_KEY_VALUE ValueCell; - PVALUE_LIST_CELL ValueListCell; + HCELL_INDEX CellIndex; UNICODE_STRING ValueNameString; - ULONG i; + TRACE("RegQueryValue(%p, '%S', %p, %p, %p)\n", Key, ValueName, Type, Data, DataSize); @@ -496,54 +452,50 @@ KeyNode = (PCM_KEY_NODE)Key; ASSERT(KeyNode->Signature == CM_KEY_NODE_SIGNATURE); - /* Check if there are any values */ - if (KeyNode->ValueList.Count == 0) - { - TRACE("RegQueryValue no values in key (%.*s)\n", - KeyNode->NameLength, KeyNode->Name); - return ERROR_INVALID_PARAMETER; - } - /* Initialize value name string */ RtlInitUnicodeString(&ValueNameString, ValueName); - - ValueListCell = (PVALUE_LIST_CELL)HvGetCell(Hive, KeyNode->ValueList.List); - TRACE("ValueListCell: %x\n", ValueListCell); - - /* Loop all values */ - for (i = 0; i < KeyNode->ValueList.Count; i++) - { - /* Get the subkey node and check the name */ - ValueCell = HvGetCell(Hive, ValueListCell->ValueOffset[i]); - - /* Compare the value name */ - TRACE("checking %.*s\n", ValueCell->NameLength, ValueCell->Name); - if (CmCompareKeyValueName(ValueCell, &ValueNameString, TRUE)) - { - RepGetValueData(Hive, ValueCell, Type, Data, DataSize); - TRACE("RegQueryValue success\n"); - return STATUS_SUCCESS; - } - } - - TRACE("RegQueryValue value not found\n"); - return ERROR_INVALID_PARAMETER; -} - + CellIndex = CmpFindValueByName(Hive, KeyNode, &ValueNameString); + if (CellIndex == HCELL_NIL) + { + TRACE("RegQueryValue value not found in key (%.*s)\n", + KeyNode->NameLength, KeyNode->Name); + return ERROR_FILE_NOT_FOUND; + } + + /* Get the value cell */ + ValueCell = (PCM_KEY_VALUE)HvGetCell(Hive, CellIndex); + ASSERT(ValueCell != NULL); + + RepGetValueData(Hive, ValueCell, Type, Data, DataSize); + + HvReleaseCell(Hive, CellIndex); + + TRACE("RegQueryValue success\n"); + return ERROR_SUCCESS; +} + +/* + * NOTE: This function is currently unused in FreeLdr; however it is kept here + * as an implementation reference of RegEnumValue using CMLIB that may be used + * elsewhere in ReactOS. + */ +#if 0 LONG RegEnumValue( _In_ HKEY Key, _In_ ULONG Index, _Out_ PWCHAR ValueName, _Inout_ ULONG* NameSize, - _Out_ ULONG* Type, - _Out_ PUCHAR Data, - _Inout_ ULONG* DataSize) + _Out_opt_ ULONG* Type, + _Out_opt_ PUCHAR Data, + _Inout_opt_ ULONG* DataSize) { PHHIVE Hive = &CmHive->Hive; PCM_KEY_NODE KeyNode; + PCELL_DATA ValueListCell; PCM_KEY_VALUE ValueCell; - PVALUE_LIST_CELL ValueListCell; + USHORT NameLength; + TRACE("RegEnumValue(%p, %lu, %S, %p, %p, %p, %p (%lu))\n", Key, Index, ValueName, NameSize, Type, Data, DataSize, *DataSize); @@ -553,40 +505,55 @@ /* Check if the index is valid */ if ((KeyNode->ValueList.Count == 0) || + (KeyNode->ValueList.List == HCELL_NIL) || (Index >= KeyNode->ValueList.Count)) { ERR("RegEnumValue: index invalid\n"); return ERROR_NO_MORE_ITEMS; } - ValueListCell = (PVALUE_LIST_CELL)HvGetCell(Hive, KeyNode->ValueList.List); - TRACE("ValueListCell: %x\n", ValueListCell); + ValueListCell = (PCELL_DATA)HvGetCell(Hive, KeyNode->ValueList.List); + ASSERT(ValueListCell != NULL); /* Get the value cell */ - ValueCell = HvGetCell(Hive, ValueListCell->ValueOffset[Index]); + ValueCell = (PCM_KEY_VALUE)HvGetCell(Hive, ValueListCell->KeyList[Index]); ASSERT(ValueCell != NULL); - - if (NameSize != NULL) - { - *NameSize = CmCopyKeyValueName(ValueCell, ValueName, *NameSize); - } + ASSERT(ValueCell->Signature == CM_KEY_VALUE_SIGNATURE); + + if (ValueCell->Flags & VALUE_COMP_NAME) + { + NameLength = CmpCompressedNameSize(ValueCell->Name, ValueCell->NameLength); + + /* Compressed name */ + CmpCopyCompressedName(ValueName, + *NameSize, + ValueCell->Name, + ValueCell->NameLength); + } + else + { + NameLength = ValueCell->NameLength; + + /* Normal name */ + RtlCopyMemory(ValueName, ValueCell->Name, + min(*NameSize, ValueCell->NameLength)); + } + + if (*NameSize >= NameLength + sizeof(WCHAR)) + { + ValueName[NameLength / sizeof(WCHAR)] = UNICODE_NULL; + } + + *NameSize = NameLength + sizeof(WCHAR); RepGetValueData(Hive, ValueCell, Type, Data, DataSize); - if (DataSize != NULL) - { - if ((Data != NULL) && (*DataSize != 0)) - { - RtlCopyMemory(Data, - &ValueCell->Data, - min(*DataSize, ValueCell->DataLength)); - } - - *DataSize = ValueCell->DataLength; - } - - TRACE("RegEnumValue done\n"); - return STATUS_SUCCESS; -} + HvReleaseCell(Hive, ValueListCell->KeyList[Index]); + HvReleaseCell(Hive, KeyNode->ValueList.List); + + TRACE("RegEnumValue done -> %u, '%.*S'\n", *NameSize, *NameSize, ValueName); + return ERROR_SUCCESS; +} +#endif /* EOF */ Modified: trunk/reactos/boot/freeldr/freeldr/windows/registry.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/windows/registry.h [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/windows/registry.h [iso-8859-1] Sun Jan 17 01:42:11 2016 @@ -23,9 +23,6 @@ typedef HANDLE HKEY, *PHKEY; -VOID -RegInitializeRegistry(VOID); - LONG RegInitCurrentControlSet(BOOLEAN LastKnownGood); @@ -41,13 +38,6 @@ RegOpenKey(HKEY ParentKey, PCWSTR KeyName, PHKEY Key); - -LONG -RegSetValue(HKEY Key, - PCWSTR ValueName, - ULONG Type, - PCSTR Data, - ULONG DataSize); LONG RegQueryValue(HKEY Key, @@ -66,7 +56,7 @@ ULONG* DataSize); BOOLEAN -RegImportBinaryHive(PCHAR ChunkBase, +RegImportBinaryHive(PVOID ChunkBase, ULONG ChunkSize); #endif /* __REGISTRY_H */ Modified: trunk/reactos/boot/freeldr/freeldr/windows/wlregistry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/freeldr/freeldr/windo… ============================================================================== --- trunk/reactos/boot/freeldr/freeldr/windows/wlregistry.c [iso-8859-1] (original) +++ trunk/reactos/boot/freeldr/freeldr/windows/wlregistry.c [iso-8859-1] Sun Jan 17 01:42:11 2016 @@ -133,11 +133,8 @@ if (!Success) return FALSE; - // Initialize in-memory registry - RegInitializeRegistry(); - // Import what was loaded - Success = RegImportBinaryHive((PCHAR)VaToPa(LoaderBlock->RegistryBase), LoaderBlock->RegistryLength); + Success = RegImportBinaryHive(VaToPa(LoaderBlock->RegistryBase), LoaderBlock->RegistryLength); if (!Success) { UiMessageBox("Importing binary hive failed!");

1 0

[hbelusca] 70603: [MKHIVE] - Fix two warnings in GCC Linux build (in KeBugCheckEx and in a call to the helper function RepGetValueData). - Remove two unused RTL ANSI functions. - Fix USHORT vs. ULO...
by hbelusca＠svn.reactos.org 17 Jan '16

17 Jan '16

Author: hbelusca Date: Sun Jan 17 01:29:43 2016 New Revision: 70603 URL: http://svn.reactos.org/svn/reactos?rev=70603&view=rev Log: [MKHIVE] - Fix two warnings in GCC Linux build (in KeBugCheckEx and in a call to the helper function RepGetValueData). - Remove two unused RTL ANSI functions. - Fix USHORT vs. ULONG type misuage. - Fix SIZE_T vs. ULONG usage. Modified: trunk/reactos/tools/mkhive/mkhive.h trunk/reactos/tools/mkhive/reginf.c trunk/reactos/tools/mkhive/registry.c trunk/reactos/tools/mkhive/rtl.c Modified: trunk/reactos/tools/mkhive/mkhive.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/mkhive.h?rev=… ============================================================================== --- trunk/reactos/tools/mkhive/mkhive.h [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/mkhive.h [iso-8859-1] Sun Jan 17 01:29:43 2016 @@ -57,15 +57,6 @@ typedef LPVOID LPSECURITY_ATTRIBUTES; typedef HANDLE HKEY, *PHKEY; -NTSTATUS NTAPI -RtlAnsiStringToUnicodeString( - IN OUT PUNICODE_STRING UniDest, - IN PANSI_STRING AnsiSource, - IN BOOLEAN AllocateDestinationString); -VOID NTAPI -RtlInitAnsiString( - IN OUT PANSI_STRING DestinationString, - IN PCSTR SourceString); VOID NTAPI RtlInitUnicodeString( IN OUT PUNICODE_STRING DestinationString, @@ -79,9 +70,9 @@ IN HKEY hKey, IN LPCWSTR lpValueName, IN PULONG lpReserved, - OUT PULONG lpType, - OUT PUCHAR lpData, - OUT PSIZE_T lpcbData); + OUT PULONG lpType OPTIONAL, + OUT PUCHAR lpData OPTIONAL, + IN OUT PULONG lpcbData OPTIONAL); LONG WINAPI RegSetValueExW( @@ -90,7 +81,7 @@ IN ULONG Reserved, IN ULONG dwType, IN const UCHAR* lpData, - IN USHORT cbData); + IN ULONG cbData); LONG WINAPI RegDeleteKeyW( Modified: trunk/reactos/tools/mkhive/reginf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/reginf.c?rev=… ============================================================================== --- trunk/reactos/tools/mkhive/reginf.c [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/reginf.c [iso-8859-1] Sun Jan 17 01:29:43 2016 @@ -119,11 +119,11 @@ IN HKEY KeyHandle, IN PWCHAR ValueName, IN PWCHAR Strings, - IN SIZE_T StringSize) + IN ULONG StringSize) { - SIZE_T Size; + ULONG Size; ULONG Type; - size_t Total; + ULONG Total; PWCHAR Buffer; PWCHAR p; size_t len; @@ -182,7 +182,7 @@ 0, REG_MULTI_SZ, (PUCHAR)Buffer, - (ULONG)Total * sizeof(WCHAR)); + Total * sizeof(WCHAR)); } done: @@ -289,7 +289,7 @@ if (Str == NULL) return FALSE; - InfHostGetMultiSzField (Context, 5, Str, (ULONG)Size, NULL); + InfHostGetMultiSzField (Context, 5, Str, Size, NULL); } if (Flags & FLG_ADDREG_APPEND) @@ -319,7 +319,7 @@ if (Str == NULL) return FALSE; - InfHostGetStringField (Context, 5, Str, (ULONG)Size, NULL); + InfHostGetStringField (Context, 5, Str, Size, NULL); } } @@ -349,7 +349,7 @@ 0, Type, (PVOID)Str, - (ULONG)Size * sizeof(WCHAR)); + Size * sizeof(WCHAR)); } else { @@ -359,7 +359,7 @@ 0, Type, (PVOID)&EmptyStr, - (ULONG)sizeof(WCHAR)); + sizeof(WCHAR)); } } free (Str); @@ -387,7 +387,7 @@ 0, Type, (PVOID)Data, - (ULONG)Size); + Size); free (Data); } Modified: trunk/reactos/tools/mkhive/registry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/registry.c?re… ============================================================================== --- trunk/reactos/tools/mkhive/registry.c [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/registry.c [iso-8859-1] Sun Jan 17 01:29:43 2016 @@ -518,7 +518,7 @@ IN ULONG Reserved, IN ULONG dwType, IN const UCHAR* lpData, - IN USHORT cbData) + IN ULONG cbData) { PMEMKEY Key = HKEY_TO_MEMKEY(hKey); // ParentKey PHHIVE Hive; @@ -528,7 +528,7 @@ UNICODE_STRING ValueNameString; PVOID DataCell; - LONG DataCellSize; + ULONG DataCellSize; NTSTATUS Status; if (dwType == REG_LINK) @@ -597,7 +597,7 @@ if (!DataCell) return ERROR_UNSUCCESSFUL; - DataCellSize = -HvGetCellSize(Hive, DataCell); + DataCellSize = (ULONG)(-HvGetCellSize(Hive, DataCell)); } else { @@ -613,12 +613,12 @@ HvFreeCell(Hive, ValueCell->Data); RtlCopyMemory(&ValueCell->Data, lpData, cbData); - ValueCell->DataLength = (ULONG)(cbData | CM_KEY_VALUE_SPECIAL_SIZE); + ValueCell->DataLength = (cbData | CM_KEY_VALUE_SPECIAL_SIZE); ValueCell->Type = dwType; } else { - if (cbData > (SIZE_T)DataCellSize) + if (cbData > DataCellSize) { /* New data size is larger than the current, destroy current * data block and allocate a new one. */ @@ -642,7 +642,7 @@ /* Copy new contents to cell */ RtlCopyMemory(DataCell, lpData, cbData); - ValueCell->DataLength = (ULONG)(cbData & ~CM_KEY_VALUE_SPECIAL_SIZE); + ValueCell->DataLength = (cbData & ~CM_KEY_VALUE_SPECIAL_SIZE); ValueCell->Type = dwType; HvMarkCellDirty(Hive, ValueCell->Data, FALSE); } @@ -712,7 +712,7 @@ IN PULONG lpReserved, OUT PULONG lpType OPTIONAL, OUT PUCHAR lpData OPTIONAL, - IN OUT PSIZE_T lpcbData OPTIONAL) + IN OUT PULONG lpcbData OPTIONAL) { PMEMKEY ParentKey = HKEY_TO_MEMKEY(hKey); PHHIVE Hive = &ParentKey->RegistryHive->Hive; Modified: trunk/reactos/tools/mkhive/rtl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/rtl.c?rev=706… ============================================================================== --- trunk/reactos/tools/mkhive/rtl.c [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/rtl.c [iso-8859-1] Sun Jan 17 01:29:43 2016 @@ -16,34 +16,6 @@ #include "mkhive.h" #include <bitmap.c> - -/* - * @implemented - * - * NOTES - * If source is NULL the length of source is assumed to be 0. - */ -VOID NTAPI -RtlInitAnsiString( - IN OUT PANSI_STRING DestinationString, - IN PCSTR SourceString) -{ - SIZE_T DestSize; - - if(SourceString) - { - DestSize = strlen(SourceString); - DestinationString->Length = (USHORT)DestSize; - DestinationString->MaximumLength = (USHORT)DestSize + sizeof(CHAR); - } - else - { - DestinationString->Length = 0; - DestinationString->MaximumLength = 0; - } - - DestinationString->Buffer = (PCHAR)SourceString; -} /* * @implemented @@ -71,41 +43,6 @@ } DestinationString->Buffer = (PWCHAR)SourceString; -} - -NTSTATUS NTAPI -RtlAnsiStringToUnicodeString( - IN OUT PUNICODE_STRING UniDest, - IN PANSI_STRING AnsiSource, - IN BOOLEAN AllocateDestinationString) -{ - ULONG Length; - PUCHAR WideString; - USHORT i; - - Length = AnsiSource->Length * sizeof(WCHAR); - if (Length > MAXUSHORT) return STATUS_INVALID_PARAMETER_2; - UniDest->Length = (USHORT)Length; - - if (AllocateDestinationString) - { - UniDest->MaximumLength = (USHORT)Length + sizeof(WCHAR); - UniDest->Buffer = (PWSTR) malloc(UniDest->MaximumLength); - if (!UniDest->Buffer) - return STATUS_NO_MEMORY; - } - else if (UniDest->Length >= UniDest->MaximumLength) - { - return STATUS_BUFFER_OVERFLOW; - } - - WideString = (PUCHAR)UniDest->Buffer; - for (i = 0; i <= AnsiSource->Length; i++) - { - WideString[2 * i + 0] = AnsiSource->Buffer[i]; - WideString[2 * i + 1] = 0; - } - return STATUS_SUCCESS; } LONG NTAPI @@ -222,14 +159,14 @@ VOID NTAPI KeBugCheckEx( - IN ULONG BugCheckCode, + IN ULONG BugCheckCode, IN ULONG_PTR BugCheckParameter1, IN ULONG_PTR BugCheckParameter2, IN ULONG_PTR BugCheckParameter3, IN ULONG_PTR BugCheckParameter4) { char Buffer[70]; - printf("*** STOP: 0x%08lX (0x%08lX, 0x%08lX, 0x%08lX, 0x%08lX)", + printf("*** STOP: 0x%08X (0x%08lX, 0x%08lX, 0x%08lX, 0x%08lX)", BugCheckCode, BugCheckParameter1, BugCheckParameter2, BugCheckParameter3, BugCheckParameter4); ASSERT(FALSE);

1 0

[hbelusca] 70602: [MKHIVE] - Make mkhive tool correctly initialize the Max(Value)[Name|Data]Length members of HHIVE structure. CORE-10794 #resolve - Add default security hive descriptors to our mkh...
by hbelusca＠svn.reactos.org 17 Jan '16

17 Jan '16

Author: hbelusca Date: Sun Jan 17 00:50:03 2016 New Revision: 70602 URL: http://svn.reactos.org/svn/reactos?rev=70602&view=rev Log: [MKHIVE] - Make mkhive tool correctly initialize the Max(Value)[Name|Data]Length members of HHIVE structure. CORE-10794 #resolve - Add default security hive descriptors to our mkhive-built registry hives. CORE-10795 #resolve - Make MKHIVE fully using the CMLIB library. CORE-10802 CORE-10793 Modified: trunk/reactos/tools/mkhive/cmi.c trunk/reactos/tools/mkhive/cmi.h trunk/reactos/tools/mkhive/mkhive.c trunk/reactos/tools/mkhive/mkhive.h trunk/reactos/tools/mkhive/registry.c trunk/reactos/tools/mkhive/rtl.c Modified: trunk/reactos/tools/mkhive/cmi.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/cmi.c?rev=706… ============================================================================== --- trunk/reactos/tools/mkhive/cmi.c [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/cmi.c [iso-8859-1] Sun Jan 17 00:50:03 2016 @@ -16,7 +16,8 @@ * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -/* COPYRIGHT: See COPYING in the top level directory +/* + * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS hive maker * FILE: tools/mkhive/cmi.c * PURPOSE: Registry file manipulation routines @@ -33,7 +34,7 @@ IN BOOLEAN Paged, IN ULONG Tag) { - return (PVOID) malloc((size_t)Size); + return (PVOID)malloc((size_t)Size); } VOID @@ -69,9 +70,10 @@ { PCMHIVE CmHive = (PCMHIVE)RegistryHive; FILE *File = CmHive->FileHandles[HFILE_TYPE_PRIMARY]; - if (0 != fseek (File, *FileOffset, SEEK_SET)) + if (fseek(File, *FileOffset, SEEK_SET) != 0) return FALSE; - return BufferLength == fwrite (Buffer, 1, BufferLength, File); + + return (fwrite(Buffer, 1, BufferLength, File) == BufferLength); } static BOOLEAN @@ -96,25 +98,24 @@ { PCMHIVE CmHive = (PCMHIVE)RegistryHive; FILE *File = CmHive->FileHandles[HFILE_TYPE_PRIMARY]; - return 0 == fflush (File); + return (fflush(File) == 0); } NTSTATUS -CmiInitializeTempHive( - IN OUT PCMHIVE Hive) +CmiInitializeHive( + IN OUT PCMHIVE Hive, + IN PCWSTR Name) { NTSTATUS Status; - RtlZeroMemory ( - Hive, - sizeof(CMHIVE)); + RtlZeroMemory(Hive, sizeof(*Hive)); DPRINT("Hive 0x%p\n", Hive); Status = HvInitialize(&Hive->Hive, HINIT_CREATE, - 0, - 0, + HIVE_NOLAZYFLUSH, + HFILE_TYPE_PRIMARY, 0, CmpAllocate, CmpFree, @@ -129,94 +130,59 @@ return Status; } - if (!CmCreateRootNode (&Hive->Hive, L"")) - { - HvFree (&Hive->Hive); - return STATUS_INSUFFICIENT_RESOURCES; - } - - Hive->Flags = HIVE_NO_FILE; + // HACK: See the HACK from r31253 + if (!CmCreateRootNode(&Hive->Hive, Name)) + { + HvFree(&Hive->Hive); + return STATUS_INSUFFICIENT_RESOURCES; + } /* Add the new hive to the hive list */ InsertTailList(&CmiHiveListHead, &Hive->HiveList); - VERIFY_REGISTRY_HIVE (Hive); - return STATUS_SUCCESS; } -static NTSTATUS -CmiAddKeyToHashTable( - IN PCMHIVE RegistryHive, - IN OUT PCM_KEY_FAST_INDEX HashCell, - IN HCELL_INDEX HashCellIndex, - IN PCM_KEY_NODE NewKeyCell, - IN HCELL_INDEX NKBOffset) -{ - ULONG i; - ULONG HashKey = 0; - - if (NewKeyCell->Flags & KEY_COMP_NAME) - { - RtlCopyMemory( - &HashKey, - NewKeyCell->Name, - min(NewKeyCell->NameLength, sizeof(ULONG))); - } - - for (i = 0; i < HashCell->Count; i++) - { - if (HashCell->List[i].HashKey > HashKey) - break; - } - - if (i < HashCell->Count) - { - RtlMoveMemory(HashCell->List + i + 1, - HashCell->List + i, - (HashCell->Count - i) * - sizeof(HashCell->List[0])); - } - - HashCell->List[i].Cell = NKBOffset; - HashCell->List[i].HashKey = HashKey; - HashCell->Count++; - HvMarkCellDirty(&RegistryHive->Hive, HashCellIndex, FALSE); +NTSTATUS +CmiCreateSecurityKey( + IN PHHIVE Hive, + IN HCELL_INDEX Cell, + IN PUCHAR Descriptor, + IN ULONG DescriptorLength) +{ + HCELL_INDEX SecurityCell; + PCM_KEY_NODE Node; + PCM_KEY_SECURITY Security; + + Node = (PCM_KEY_NODE)HvGetCell(Hive, Cell); + SecurityCell = HvAllocateCell(Hive, + FIELD_OFFSET(CM_KEY_SECURITY, Descriptor) + + DescriptorLength, + Stable, + HCELL_NIL); + if (SecurityCell == HCELL_NIL) + { + HvReleaseCell(Hive, Cell); + return STATUS_INSUFFICIENT_RESOURCES; + } + + Node->Security = SecurityCell; + Security = (PCM_KEY_SECURITY)HvGetCell(Hive, SecurityCell); + Security->Signature = CM_KEY_SECURITY_SIGNATURE; + Security->ReferenceCount = 1; + Security->DescriptorLength = DescriptorLength; + + RtlMoveMemory(&Security->Descriptor, + Descriptor, + DescriptorLength); + + Security->Flink = Security->Blink = SecurityCell; + + HvReleaseCell(Hive, SecurityCell); + HvReleaseCell(Hive, Cell); + return STATUS_SUCCESS; -} - -static NTSTATUS -CmiAllocateHashTableCell ( - IN PCMHIVE RegistryHive, - OUT PCM_KEY_FAST_INDEX *HashBlock, - OUT HCELL_INDEX *HBOffset, - IN USHORT SubKeyCount, - IN HSTORAGE_TYPE Storage) -{ - PCM_KEY_FAST_INDEX NewHashBlock; - ULONG NewHashSize; - NTSTATUS Status; - - Status = STATUS_SUCCESS; - *HashBlock = NULL; - NewHashSize = FIELD_OFFSET(CM_KEY_FAST_INDEX, List) + - (SubKeyCount * sizeof(CM_INDEX)); - *HBOffset = HvAllocateCell(&RegistryHive->Hive, NewHashSize, Storage, HCELL_NIL); - - if (*HBOffset == HCELL_NIL) - { - Status = STATUS_INSUFFICIENT_RESOURCES; - } - else - { - NewHashBlock = (PCM_KEY_FAST_INDEX)HvGetCell (&RegistryHive->Hive, *HBOffset); - NewHashBlock->Signature = CM_KEY_FAST_LEAF; - NewHashBlock->Count = 0; - *HashBlock = NewHashBlock; - } - - return Status; } static NTSTATUS @@ -224,105 +190,98 @@ IN PCMHIVE RegistryHive, IN HCELL_INDEX ParentKeyCellOffset, IN PCUNICODE_STRING SubKeyName, - IN ULONG CreateOptions, + IN BOOLEAN VolatileKey, OUT HCELL_INDEX* pNKBOffset) { HCELL_INDEX NKBOffset; PCM_KEY_NODE NewKeyCell; - ULONG NewBlockSize; - NTSTATUS Status; - USHORT NameLength; - PWSTR NamePtr; - BOOLEAN Packable; + UNICODE_STRING KeyName; HSTORAGE_TYPE Storage; - ULONG i; - - /* Skip leading backslash */ - if (SubKeyName->Buffer[0] == L'\\') - { - NamePtr = &SubKeyName->Buffer[1]; - NameLength = SubKeyName->Length - sizeof(WCHAR); + + /* Skip leading path separator if present */ + if (SubKeyName->Buffer[0] == OBJ_NAME_PATH_SEPARATOR) + { + KeyName.Buffer = &SubKeyName->Buffer[1]; + KeyName.Length = KeyName.MaximumLength = SubKeyName->Length - sizeof(WCHAR); } else { - NamePtr = SubKeyName->Buffer; - NameLength = SubKeyName->Length; - } - - /* Check whether key name can be packed */ - Packable = TRUE; - for (i = 0; i < NameLength / sizeof(WCHAR); i++) - { - if (NamePtr[i] & 0xFF00) + KeyName = *SubKeyName; + } + + Storage = (VolatileKey ? Volatile : Stable); + + NKBOffset = HvAllocateCell(&RegistryHive->Hive, + FIELD_OFFSET(CM_KEY_NODE, Name) + + CmpNameSize(&RegistryHive->Hive, &KeyName), + Storage, + HCELL_NIL); + if (NKBOffset == HCELL_NIL) + { + return STATUS_INSUFFICIENT_RESOURCES; + } + + NewKeyCell = (PCM_KEY_NODE)HvGetCell(&RegistryHive->Hive, NKBOffset); + if (NewKeyCell == NULL) + { + HvFreeCell(&RegistryHive->Hive, NKBOffset); + return STATUS_INSUFFICIENT_RESOURCES; + } + + NewKeyCell->Signature = CM_KEY_NODE_SIGNATURE; + NewKeyCell->Flags = (VolatileKey ? KEY_IS_VOLATILE : 0); + KeQuerySystemTime(&NewKeyCell->LastWriteTime); + NewKeyCell->Parent = ParentKeyCellOffset; + NewKeyCell->SubKeyCounts[Stable] = 0; + NewKeyCell->SubKeyCounts[Volatile] = 0; + NewKeyCell->SubKeyLists[Stable] = HCELL_NIL; + NewKeyCell->SubKeyLists[Volatile] = HCELL_NIL; + NewKeyCell->ValueList.Count = 0; + NewKeyCell->ValueList.List = HCELL_NIL; + NewKeyCell->Security = HCELL_NIL; + NewKeyCell->Class = HCELL_NIL; + NewKeyCell->ClassLength = 0; + NewKeyCell->MaxNameLen = 0; + NewKeyCell->MaxClassLen = 0; + NewKeyCell->MaxValueNameLen = 0; + NewKeyCell->MaxValueDataLen = 0; + NewKeyCell->NameLength = CmpCopyName(&RegistryHive->Hive, NewKeyCell->Name, &KeyName); + if (NewKeyCell->NameLength < KeyName.Length) NewKeyCell->Flags |= KEY_COMP_NAME; + + /* Inherit the security from the parent */ + if (ParentKeyCellOffset == HCELL_NIL) + { + // We are in fact creating a root key. + // This is not handled there, but when we + // call CmCreateRootNode instead. + ASSERT(FALSE); + } + else + { + /* Get the parent node */ + PCM_KEY_NODE ParentKeyCell; + ParentKeyCell = (PCM_KEY_NODE)HvGetCell(&RegistryHive->Hive, ParentKeyCellOffset); + + if (ParentKeyCell) { - Packable = FALSE; - break; + /* Inherit the security block of the parent */ + NewKeyCell->Security = ParentKeyCell->Security; + if (NewKeyCell->Security != HCELL_NIL) + { + PCM_KEY_SECURITY Security; + Security = (PCM_KEY_SECURITY)HvGetCell(&RegistryHive->Hive, NewKeyCell->Security); + ++Security->ReferenceCount; + HvReleaseCell(&RegistryHive->Hive, NewKeyCell->Security); + } + + HvReleaseCell(&RegistryHive->Hive, ParentKeyCellOffset); } } - /* Adjust name size */ - if (Packable) - { - NameLength = NameLength / sizeof(WCHAR); - } - - Status = STATUS_SUCCESS; - - Storage = (CreateOptions & REG_OPTION_VOLATILE) ? Volatile : Stable; - NewBlockSize = FIELD_OFFSET(CM_KEY_NODE, Name) + NameLength; - NKBOffset = HvAllocateCell(&RegistryHive->Hive, NewBlockSize, Storage, HCELL_NIL); - if (NKBOffset == HCELL_NIL) - { - Status = STATUS_INSUFFICIENT_RESOURCES; - } - else - { - NewKeyCell = (PCM_KEY_NODE)HvGetCell (&RegistryHive->Hive, NKBOffset); - NewKeyCell->Signature = CM_KEY_NODE_SIGNATURE; - if (CreateOptions & REG_OPTION_VOLATILE) - { - NewKeyCell->Flags = KEY_IS_VOLATILE; - } - else - { - NewKeyCell->Flags = 0; - } - KeQuerySystemTime(&NewKeyCell->LastWriteTime); - NewKeyCell->Parent = ParentKeyCellOffset; - NewKeyCell->SubKeyCounts[Stable] = 0; - NewKeyCell->SubKeyCounts[Volatile] = 0; - NewKeyCell->SubKeyLists[Stable] = HCELL_NIL; - NewKeyCell->SubKeyLists[Volatile] = HCELL_NIL; - NewKeyCell->ValueList.Count = 0; - NewKeyCell->ValueList.List = HCELL_NIL; - NewKeyCell->Security = HCELL_NIL; - NewKeyCell->Class = HCELL_NIL; - - /* Pack the key name */ - NewKeyCell->NameLength = NameLength; - if (Packable) - { - NewKeyCell->Flags |= KEY_COMP_NAME; - for (i = 0; i < NameLength; i++) - { - ((PCHAR)NewKeyCell->Name)[i] = (CHAR)(NamePtr[i] & 0x00FF); - } - } - else - { - RtlCopyMemory(NewKeyCell->Name, - NamePtr, - NameLength); - } - - VERIFY_KEY_CELL(NewKeyCell); - } - - if (NT_SUCCESS(Status)) - { - *pNKBOffset = NKBOffset; - } - return Status; + HvReleaseCell(&RegistryHive->Hive, NKBOffset); + + *pNKBOffset = NKBOffset; + return STATUS_SUCCESS; } NTSTATUS @@ -330,291 +289,156 @@ IN PCMHIVE RegistryHive, IN HCELL_INDEX ParentKeyCellOffset, IN PCUNICODE_STRING SubKeyName, - IN ULONG CreateOptions, - OUT PCM_KEY_NODE *pSubKeyCell, + IN BOOLEAN VolatileKey, OUT HCELL_INDEX *pBlockOffset) { PCM_KEY_NODE ParentKeyCell; HCELL_INDEX NKBOffset; NTSTATUS Status; + /* Create the new key */ + Status = CmiCreateSubKey(RegistryHive, ParentKeyCellOffset, SubKeyName, VolatileKey, &NKBOffset); + if (!NT_SUCCESS(Status)) + return Status; + + /* Mark the parent cell as dirty */ + HvMarkCellDirty(&RegistryHive->Hive, ParentKeyCellOffset, FALSE); + + if (!CmpAddSubKey(&RegistryHive->Hive, ParentKeyCellOffset, NKBOffset)) + { + /* FIXME: delete newly created cell */ + // CmpFreeKeyByCell(&RegistryHive->Hive, NewCell /*NKBOffset*/, FALSE); + ASSERT(FALSE); + return STATUS_UNSUCCESSFUL; + } + + /* Get the parent node */ ParentKeyCell = (PCM_KEY_NODE)HvGetCell(&RegistryHive->Hive, ParentKeyCellOffset); if (!ParentKeyCell) - return STATUS_UNSUCCESSFUL; - VERIFY_KEY_CELL(ParentKeyCell); - - /* Create the new key */ - Status = CmiCreateSubKey(RegistryHive, ParentKeyCellOffset, SubKeyName, CreateOptions, &NKBOffset); - if (!NT_SUCCESS(Status)) - { - return Status; - } - - if (!CmpAddSubKey(&RegistryHive->Hive, ParentKeyCellOffset, NKBOffset)) { /* FIXME: delete newly created cell */ return STATUS_UNSUCCESSFUL; } - + VERIFY_KEY_CELL(ParentKeyCell); + + /* Update the timestamp */ KeQuerySystemTime(&ParentKeyCell->LastWriteTime); - HvMarkCellDirty(&RegistryHive->Hive, ParentKeyCellOffset, FALSE); + + /* Check if we need to update name maximum, update it if so */ + if (ParentKeyCell->MaxNameLen < SubKeyName->Length) + ParentKeyCell->MaxNameLen = SubKeyName->Length; + + /* Release the cell */ + HvReleaseCell(&RegistryHive->Hive, ParentKeyCellOffset); *pBlockOffset = NKBOffset; return STATUS_SUCCESS; -} - -#if 0 // Those two functions seem to be unused, but keep them just in case we may need to use them in the future... -static BOOLEAN -CmiCompareHash( - IN PCUNICODE_STRING KeyName, - IN PCHAR HashString) -{ - CHAR Buffer[4]; - - Buffer[0] = (KeyName->Length >= 2) ? (CHAR)KeyName->Buffer[0] : 0; - Buffer[1] = (KeyName->Length >= 4) ? (CHAR)KeyName->Buffer[1] : 0; - Buffer[2] = (KeyName->Length >= 6) ? (CHAR)KeyName->Buffer[2] : 0; - Buffer[3] = (KeyName->Length >= 8) ? (CHAR)KeyName->Buffer[3] : 0; - - return (strncmp(Buffer, HashString, 4) == 0); -} - -static BOOLEAN -CmiCompareHashI( - IN PCUNICODE_STRING KeyName, - IN PCHAR HashString) -{ - CHAR Buffer[4]; - - Buffer[0] = (KeyName->Length >= 2) ? (CHAR)KeyName->Buffer[0] : 0; - Buffer[1] = (KeyName->Length >= 4) ? (CHAR)KeyName->Buffer[1] : 0; - Buffer[2] = (KeyName->Length >= 6) ? (CHAR)KeyName->Buffer[2] : 0; - Buffer[3] = (KeyName->Length >= 8) ? (CHAR)KeyName->Buffer[3] : 0; - - return (strncasecmp(Buffer, HashString, 4) == 0); -} -#endif - -NTSTATUS -CmiScanForSubKey( - IN PCMHIVE RegistryHive, - IN HCELL_INDEX ParentKeyCellOffset, - IN PCUNICODE_STRING SubKeyName, - IN ULONG Attributes, - OUT PCM_KEY_NODE *pSubKeyCell, - OUT HCELL_INDEX *pBlockOffset) -{ - PCM_KEY_NODE KeyCell; - PCM_KEY_FAST_INDEX HashBlock; - PCM_KEY_NODE CurSubKeyCell; - BOOLEAN CaseInsensitive; - ULONG Storage; - ULONG i; - - KeyCell = (PCM_KEY_NODE)HvGetCell(&RegistryHive->Hive, ParentKeyCellOffset); - if (!KeyCell) - return STATUS_UNSUCCESSFUL; - VERIFY_KEY_CELL(KeyCell); - - ASSERT(RegistryHive); - - *pSubKeyCell = NULL; - CaseInsensitive = (Attributes & OBJ_CASE_INSENSITIVE) != 0; - - for (Storage = Stable; Storage < HTYPE_COUNT; Storage++) - { - if (KeyCell->SubKeyLists[Storage] == HCELL_NIL) - { - /* The key does not have any subkeys */ - continue; - } - - /* Get hash table */ - HashBlock = (PCM_KEY_FAST_INDEX)HvGetCell (&RegistryHive->Hive, KeyCell->SubKeyLists[Storage]); - if (!HashBlock || HashBlock->Signature != CM_KEY_FAST_LEAF) - return STATUS_UNSUCCESSFUL; - - for (i = 0; i < KeyCell->SubKeyCounts[Storage]; i++) - { - if ((HashBlock->List[i].HashKey == 0) || - (CmCompareHash(SubKeyName, (PCHAR)&HashBlock->List[i].HashKey, CaseInsensitive))) - { - CurSubKeyCell = (PCM_KEY_NODE)HvGetCell(&RegistryHive->Hive, - HashBlock->List[i].Cell); - - if (CmCompareKeyName(CurSubKeyCell, SubKeyName, CaseInsensitive)) - { - *pSubKeyCell = CurSubKeyCell; - *pBlockOffset = HashBlock->List[i].Cell; - return STATUS_SUCCESS; - } - } - } - } - - return STATUS_OBJECT_NAME_NOT_FOUND; -} - -static USHORT -CmiGetPackedNameLength( - IN PCUNICODE_STRING Name, - OUT PBOOLEAN pPackable) -{ - USHORT i; - - *pPackable = TRUE; - - for (i = 0; i < Name->Length / sizeof(WCHAR); i++) - { - if (Name->Buffer[i] & 0xFF00) - { - *pPackable = FALSE; - return Name->Length; - } - } - - return (Name->Length / sizeof(WCHAR)); -} - -static NTSTATUS -CmiAllocateValueCell( - IN PCMHIVE RegistryHive, - OUT PCM_KEY_VALUE *ValueCell, - OUT HCELL_INDEX *VBOffset, - IN PCUNICODE_STRING ValueName, - IN HSTORAGE_TYPE Storage) -{ - PCM_KEY_VALUE NewValueCell; - BOOLEAN Packable; - USHORT NameLength, i; - NTSTATUS Status; - - Status = STATUS_SUCCESS; - - NameLength = CmiGetPackedNameLength(ValueName, &Packable); - - DPRINT("ValueName->Length %u NameLength %u\n", ValueName->Length, NameLength); - - *VBOffset = HvAllocateCell(&RegistryHive->Hive, sizeof(CM_KEY_VALUE) + NameLength, Storage, HCELL_NIL); - if (*VBOffset == HCELL_NIL) - { - Status = STATUS_INSUFFICIENT_RESOURCES; - } - else - { - NewValueCell = (PCM_KEY_VALUE)HvGetCell (&RegistryHive->Hive, *VBOffset); - NewValueCell->Signature = CM_KEY_VALUE_SIGNATURE; - NewValueCell->NameLength = (USHORT)NameLength; - if (Packable) - { - /* Pack the value name */ - for (i = 0; i < NameLength; i++) - { - ((PCHAR)NewValueCell->Name)[i] = (CHAR)ValueName->Buffer[i]; - } - NewValueCell->Flags |= VALUE_COMP_NAME; - } - else - { - /* Copy the value name */ - RtlCopyMemory(NewValueCell->Name, - ValueName->Buffer, - NameLength); - NewValueCell->Flags = 0; - } - NewValueCell->Type = 0; - NewValueCell->DataLength = 0; - NewValueCell->Data = HCELL_NIL; - *ValueCell = NewValueCell; - } - - return Status; } NTSTATUS CmiAddValueKey( IN PCMHIVE RegistryHive, - IN HCELL_INDEX KeyCellOffset, + IN PCM_KEY_NODE Parent, IN PCUNICODE_STRING ValueName, OUT PCM_KEY_VALUE *pValueCell, OUT HCELL_INDEX *pValueCellOffset) { - PVALUE_LIST_CELL ValueListCell; - PCM_KEY_NODE KeyCell; + PCELL_DATA ValueListCell; PCM_KEY_VALUE NewValueCell; HCELL_INDEX ValueListCellOffset; HCELL_INDEX NewValueCellOffset; ULONG CellSize; HSTORAGE_TYPE Storage; - NTSTATUS Status; - - KeyCell = HvGetCell(&RegistryHive->Hive, KeyCellOffset); - if (!KeyCell) - return STATUS_UNSUCCESSFUL; - - Storage = (KeyCell->Flags & KEY_IS_VOLATILE) ? Volatile : Stable; - if (KeyCell->ValueList.List == HCELL_NIL) + +#ifndef FIELD_SIZE +#define FIELD_SIZE(type, field) (sizeof(((type *)0)->field)) +#endif + + Storage = (Parent->Flags & KEY_IS_VOLATILE) ? Volatile : Stable; + if (Parent->ValueList.List == HCELL_NIL) { /* Allocate some room for the value list */ - CellSize = sizeof(VALUE_LIST_CELL) + (3 * sizeof(HCELL_INDEX)); + CellSize = FIELD_SIZE(CELL_DATA, u.KeyList) + (3 * sizeof(HCELL_INDEX)); ValueListCellOffset = HvAllocateCell(&RegistryHive->Hive, CellSize, Storage, HCELL_NIL); if (ValueListCellOffset == HCELL_NIL) return STATUS_INSUFFICIENT_RESOURCES; - ValueListCell = (PVALUE_LIST_CELL)HvGetCell(&RegistryHive->Hive, ValueListCellOffset); + ValueListCell = (PCELL_DATA)HvGetCell(&RegistryHive->Hive, ValueListCellOffset); + if (!ValueListCell) + { + HvFreeCell(&RegistryHive->Hive, ValueListCellOffset); + return STATUS_UNSUCCESSFUL; + } + + Parent->ValueList.List = ValueListCellOffset; + } + else + { + ValueListCell = (PCELL_DATA)HvGetCell(&RegistryHive->Hive, Parent->ValueList.List); if (!ValueListCell) return STATUS_UNSUCCESSFUL; - KeyCell->ValueList.List = ValueListCellOffset; - HvMarkCellDirty(&RegistryHive->Hive, KeyCellOffset, FALSE); - } - else - { - ValueListCell = (PVALUE_LIST_CELL)HvGetCell(&RegistryHive->Hive, KeyCell->ValueList.List); - if (!ValueListCell) - return STATUS_UNSUCCESSFUL; - CellSize = ABS_VALUE(HvGetCellSize(&RegistryHive->Hive, ValueListCell)); - if (KeyCell->ValueList.Count >= CellSize / sizeof(HCELL_INDEX)) + if (Parent->ValueList.Count >= CellSize / sizeof(HCELL_INDEX)) { CellSize *= 2; - ValueListCellOffset = HvReallocateCell(&RegistryHive->Hive, KeyCell->ValueList.List, CellSize); + ValueListCellOffset = HvReallocateCell(&RegistryHive->Hive, Parent->ValueList.List, CellSize); if (ValueListCellOffset == HCELL_NIL) return STATUS_INSUFFICIENT_RESOURCES; - ValueListCell = (PVALUE_LIST_CELL)HvGetCell(&RegistryHive->Hive, ValueListCellOffset); + ValueListCell = (PCELL_DATA)HvGetCell(&RegistryHive->Hive, ValueListCellOffset); if (!ValueListCell) return STATUS_UNSUCCESSFUL; - KeyCell->ValueList.List = ValueListCellOffset; - HvMarkCellDirty(&RegistryHive->Hive, KeyCellOffset, FALSE); + Parent->ValueList.List = ValueListCellOffset; } } - Status = CmiAllocateValueCell(RegistryHive, - &NewValueCell, - &NewValueCellOffset, - ValueName, - Storage); - if (!NT_SUCCESS(Status)) - return Status; - - ValueListCell->ValueOffset[KeyCell->ValueList.Count] = NewValueCellOffset; - KeyCell->ValueList.Count++; - if (NewValueCell->Flags & VALUE_COMP_NAME) - { - if (NewValueCell->NameLength*sizeof(WCHAR) > KeyCell->MaxValueNameLen) - KeyCell->MaxValueNameLen = NewValueCell->NameLength*sizeof(WCHAR); + + NewValueCellOffset = HvAllocateCell(&RegistryHive->Hive, + FIELD_OFFSET(CM_KEY_VALUE, Name) + + CmpNameSize(&RegistryHive->Hive, (PUNICODE_STRING)ValueName), + Storage, + HCELL_NIL); + if (NewValueCellOffset == HCELL_NIL) + { + return STATUS_INSUFFICIENT_RESOURCES; + } + + NewValueCell = (PCM_KEY_VALUE)HvGetCell(&RegistryHive->Hive, NewValueCellOffset); + if (NewValueCell == NULL) + { + HvFreeCell(&RegistryHive->Hive, NewValueCellOffset); + return STATUS_INSUFFICIENT_RESOURCES; + } + + NewValueCell->Signature = CM_KEY_VALUE_SIGNATURE; + NewValueCell->NameLength = CmpCopyName(&RegistryHive->Hive, + NewValueCell->Name, + (PUNICODE_STRING)ValueName); + + /* Check for compressed name */ + if (NewValueCell->NameLength < ValueName->Length) + { + /* This is a compressed name */ + NewValueCell->Flags = VALUE_COMP_NAME; } else { - if (NewValueCell->NameLength > KeyCell->MaxValueNameLen) - KeyCell->MaxValueNameLen = NewValueCell->NameLength; - } - - HvMarkCellDirty(&RegistryHive->Hive, KeyCellOffset, FALSE); - HvMarkCellDirty(&RegistryHive->Hive, KeyCell->ValueList.List, FALSE); + /* No flags to set */ + NewValueCell->Flags = 0; + } + + NewValueCell->Type = 0; + NewValueCell->DataLength = 0; + NewValueCell->Data = HCELL_NIL; + + + ValueListCell->u.KeyList[Parent->ValueList.Count] = NewValueCellOffset; + Parent->ValueList.Count++; + + HvMarkCellDirty(&RegistryHive->Hive, Parent->ValueList.List, FALSE); HvMarkCellDirty(&RegistryHive->Hive, NewValueCellOffset, FALSE); *pValueCell = NewValueCell; @@ -622,53 +446,3 @@ return STATUS_SUCCESS; } - -NTSTATUS -CmiScanForValueKey( - IN PCMHIVE RegistryHive, - IN HCELL_INDEX KeyCellOffset, - IN PCUNICODE_STRING ValueName, - OUT PCM_KEY_VALUE *pValueCell, - OUT HCELL_INDEX *pValueCellOffset) -{ - PCM_KEY_NODE KeyCell; - PVALUE_LIST_CELL ValueListCell; - PCM_KEY_VALUE CurValueCell; - ULONG i; - - KeyCell = (PCM_KEY_NODE)HvGetCell(&RegistryHive->Hive, KeyCellOffset); - if (!KeyCell) - return STATUS_UNSUCCESSFUL; - - *pValueCell = NULL; - *pValueCellOffset = HCELL_NIL; - - /* The key does not have any values */ - if (KeyCell->ValueList.List == HCELL_NIL) - { - return STATUS_OBJECT_NAME_NOT_FOUND; - } - - ValueListCell = (PVALUE_LIST_CELL)HvGetCell(&RegistryHive->Hive, KeyCell->ValueList.List); - - VERIFY_VALUE_LIST_CELL(ValueListCell); - - for (i = 0; i < KeyCell->ValueList.Count; i++) - { - CurValueCell = (PCM_KEY_VALUE)HvGetCell(&RegistryHive->Hive, - ValueListCell->ValueOffset[i]); - - if (CmComparePackedNames(ValueName, - (PUCHAR)CurValueCell->Name, - CurValueCell->NameLength, - (CurValueCell->Flags & VALUE_COMP_NAME) ? TRUE : FALSE, - TRUE)) - { - *pValueCell = CurValueCell; - *pValueCellOffset = ValueListCell->ValueOffset[i]; - return STATUS_SUCCESS; - } - } - - return STATUS_OBJECT_NAME_NOT_FOUND; -} Modified: trunk/reactos/tools/mkhive/cmi.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/cmi.h?rev=706… ============================================================================== --- trunk/reactos/tools/mkhive/cmi.h [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/cmi.h [iso-8859-1] Sun Jan 17 00:50:03 2016 @@ -16,7 +16,8 @@ * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -/* COPYRIGHT: See COPYING in the top level directory +/* + * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS hive maker * FILE: tools/mkhive/cmi.h * PURPOSE: Registry file manipulation routines @@ -24,42 +25,31 @@ */ #define VERIFY_KEY_CELL(key) -#define VERIFY_VALUE_LIST_CELL(cell) NTSTATUS -CmiInitializeTempHive( - IN OUT PCMHIVE Hive); +CmiInitializeHive( + IN OUT PCMHIVE Hive, + IN PCWSTR Name); + +NTSTATUS +CmiCreateSecurityKey( + IN PHHIVE Hive, + IN HCELL_INDEX Cell, + IN PUCHAR Descriptor, + IN ULONG DescriptorLength); NTSTATUS CmiAddSubKey( IN PCMHIVE RegistryHive, IN HCELL_INDEX ParentKeyCellOffset, IN PCUNICODE_STRING SubKeyName, - IN ULONG CreateOptions, - OUT PCM_KEY_NODE *pSubKeyCell, - OUT HCELL_INDEX *pBlockOffset); - -NTSTATUS -CmiScanForSubKey( - IN PCMHIVE RegistryHive, - IN HCELL_INDEX ParentKeyCellOffset, - IN PCUNICODE_STRING SubKeyName, - IN ULONG Attributes, - OUT PCM_KEY_NODE *pSubKeyCell, + IN BOOLEAN VolatileKey, OUT HCELL_INDEX *pBlockOffset); NTSTATUS CmiAddValueKey( IN PCMHIVE RegistryHive, - IN HCELL_INDEX KeyCellOffset, + IN PCM_KEY_NODE Parent, IN PCUNICODE_STRING ValueName, OUT PCM_KEY_VALUE *pValueCell, OUT HCELL_INDEX *pValueCellOffset); - -NTSTATUS -CmiScanForValueKey( - IN PCMHIVE RegistryHive, - IN HCELL_INDEX KeyCellOffset, - IN PCUNICODE_STRING ValueName, - OUT PCM_KEY_VALUE *pValueCell, - OUT HCELL_INDEX *pValueCellOffset); Modified: trunk/reactos/tools/mkhive/mkhive.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/mkhive.c?rev=… ============================================================================== --- trunk/reactos/tools/mkhive/mkhive.c [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/mkhive.c [iso-8859-1] Sun Jan 17 00:50:03 2016 @@ -16,7 +16,8 @@ * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -/* COPYRIGHT: See COPYING in the top level directory +/* + * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS hive maker * FILE: tools/mkhive/mkhive.c * PURPOSE: Hive maker @@ -33,7 +34,7 @@ #ifdef _MSC_VER #include <stdlib.h> #define PATH_MAX _MAX_PATH -#endif//_MSC_VER +#endif // _MSC_VER #ifndef _WIN32 #ifndef PATH_MAX Modified: trunk/reactos/tools/mkhive/mkhive.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/mkhive.h?rev=… ============================================================================== --- trunk/reactos/tools/mkhive/mkhive.h [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/mkhive.h [iso-8859-1] Sun Jan 17 00:50:03 2016 @@ -16,7 +16,8 @@ * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -/* COPYRIGHT: See COPYING in the top level directory +/* + * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS hive maker * FILE: tools/mkhive/mkhive.h * PURPOSE: Hive maker @@ -54,6 +55,7 @@ typedef DWORD REGSAM; typedef LPVOID LPSECURITY_ATTRIBUTES; +typedef HANDLE HKEY, *PHKEY; NTSTATUS NTAPI RtlAnsiStringToUnicodeString( @@ -122,8 +124,6 @@ #define OBJ_NAME_PATH_SEPARATOR ((WCHAR)L'\\') -#define HIVE_NO_FILE 2 -#define VERIFY_REGISTRY_HIVE(hive) extern LIST_ENTRY CmiHiveListHead; #define ABS_VALUE(V) (((V) < 0) ? -(V) : (V)) #define PAGED_CODE() Modified: trunk/reactos/tools/mkhive/registry.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/registry.c?re… ============================================================================== --- trunk/reactos/tools/mkhive/registry.c [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/registry.c [iso-8859-1] Sun Jan 17 00:50:03 2016 @@ -16,7 +16,8 @@ * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -/* COPYRIGHT: See COPYING in the top level directory +/* + * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS hive maker * FILE: tools/mkhive/registry.c * PURPOSE: Registry code @@ -25,9 +26,7 @@ /* * TODO: - * - Implement RegDeleteKeyW() - * - Implement RegEnumValue() - * - Implement RegQueryValueExW() + * - Implement RegDeleteKeyW() and RegDeleteValueW() */ #include <stdlib.h> @@ -36,9 +35,6 @@ #define NDEBUG #include "mkhive.h" - -#define REG_DATA_SIZE_MASK 0x7FFFFFFF -#define REG_DATA_IN_OFFSET 0x80000000 static CMHIVE RootHive; static PMEMKEY RootKey; @@ -49,6 +45,291 @@ CMHIVE SystemHive; /* \Registry\Machine\SYSTEM */ CMHIVE BcdHive; /* \Registry\Machine\BCD00000000 */ +// +// TODO: Write these values in a more human-readable form. +// See http://amnesia.gtisc.gatech.edu/~moyix/suzibandit.ltd.uk/MSc/Registry%20Str… +// Appendix 12 "The Registry NT Security Descriptor" for more information. +// +// Those SECURITY_DESCRIPTORs were obtained by dumping the security block "sk" +// of registry hives created by setting their permissions to be the same as +// the ones of the BCD, SOFTWARE, or SYSTEM, SAM and .DEFAULT system hives. +// A cross-check was subsequently done with the system hives to verify that +// the security descriptors were the same. +// +UCHAR BcdSecurity[] = +{ + // SECURITY_DESCRIPTOR_RELATIVE + 0x01, // Revision + 0x00, // Sbz1 + 0x04, 0x94, // Control: SE_SELF_RELATIVE (0x8000) | + // SE_DACL_PROTECTED (0x1000) | + // SE_DACL_AUTO_INHERITED (0x0400) | + // SE_DACL_PRESENT (0x0004) + 0x48, 0x00, 0x00, 0x00, // Owner + 0x58, 0x00, 0x00, 0x00, // Group + 0x00, 0x00, 0x00, 0x00, // Sacl (None) + 0x14, 0x00, 0x00, 0x00, // Dacl + + // DACL + 0x02, // AclRevision + 0x00, // Sbz1 + 0x34, 0x00, // AclSize + 0x02, 0x00, // AceCount + 0x00, 0x00, // Sbz2 + + // (1st ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x02, // AceFlags: CONTAINER_INHERIT_ACE + 0x18, 0x00, // AceSize + 0x19, 0x00, 0x06, 0x00, // ACCESS_MASK: "Write DAC" (0x00040000) | + // "Read Control" (0x00020000) | + // "Notify" (0x00000010) | + // "Enumerate Subkeys" (0x00000008) | + // "Query Value" (0x00000001) + // (SidStart: S-1-5-32-544 "Administrators") + 0x01, 0x02, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x20, 0x00, 0x00, 0x00, + 0x20, 0x02, 0x00, 0x00, + + // (2nd ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x02, // AceFlags: CONTAINER_INHERIT_ACE + 0x14, 0x00, // AceSize + 0x3F, 0x00, 0x0F, 0x00, // ACCESS_MASK: "Full Control" (0x000F003F) + // (SidStart: S-1-5-18 "Local System") + 0x01, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x12, 0x00, 0x00, 0x00, + + // Owner SID (S-1-5-32-544 "Administrators") + 0x01, 0x02, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x20, 0x00, 0x00, 0x00, + 0x20, 0x02, 0x00, 0x00, + + // Group SID (S-1-5-21-domain-513 "Domain Users") + 0x01, 0x05, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x15, 0x00, 0x00, 0x00, + 0xAC, 0xD0, 0x49, 0xCB, + 0xE6, 0x52, 0x47, 0x9C, + 0xE4, 0x31, 0xDB, 0x5C, + 0x01, 0x02, 0x00, 0x00 +}; + +UCHAR SoftwareSecurity[] = +{ + // SECURITY_DESCRIPTOR_RELATIVE + 0x01, // Revision + 0x00, // Sbz1 + 0x04, 0x94, // Control: SE_SELF_RELATIVE (0x8000) | + // SE_DACL_PROTECTED (0x1000) | + // SE_DACL_AUTO_INHERITED (0x0400) | + // SE_DACL_PRESENT (0x0004) + 0xA0, 0x00, 0x00, 0x00, // Owner + 0xB0, 0x00, 0x00, 0x00, // Group + 0x00, 0x00, 0x00, 0x00, // Sacl (None) + 0x14, 0x00, 0x00, 0x00, // Dacl + + // DACL + 0x02, // AclRevision + 0x00, // Sbz1 + 0x8C, 0x00, // AclSize + 0x06, 0x00, // AceCount + 0x00, 0x00, // Sbz2 + + // (1st ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x02, // AceFlags: CONTAINER_INHERIT_ACE + 0x18, 0x00, // AceSize + 0x3F, 0x00, 0x0F, 0x00, // ACCESS_MASK: "Full Control" (0x000F003F) + // (SidStart: S-1-5-32-544 "Administrators") + 0x01, 0x02, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x20, 0x00, 0x00, 0x00, + 0x20, 0x02, 0x00, 0x00, + + // (2nd ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x0A, // AceFlags: INHERIT_ONLY_ACE | CONTAINER_INHERIT_ACE + 0x14, 0x00, // AceSize + 0x3F, 0x00, 0x0F, 0x00, // ACCESS_MASK: "Full Control" (0x000F003F) + // (SidStart: S-1-3-0 "Creator Owner") + 0x01, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x03, + 0x00, 0x00, 0x00, 0x00, + + // (3rd ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x02, // AceFlags: CONTAINER_INHERIT_ACE + 0x14, 0x00, // AceSize + 0x3F, 0x00, 0x0F, 0x00, // ACCESS_MASK: "Full Control" (0x000F003F) + // (SidStart: S-1-5-18 "Local System") + 0x01, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x12, 0x00, 0x00, 0x00, + + // (4th ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x02, // AceFlags: CONTAINER_INHERIT_ACE + 0x14, 0x00, // AceSize + 0x1F, 0x00, 0x03, 0x00, // ACCESS_MASK: "Read Control" (0x00020000) | + // "Delete" (0x00010000) | + // "Notify" (0x00000010) | + // "Enumerate Subkeys" (0x00000008) | + // "Create Subkey" (0x00000004) | + // "Set Value" (0x00000002) | + // "Query Value" (0x00000001) + // (SidStart: S-1-5-13 "Terminal Server Users") + 0x01, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x0D, 0x00, 0x00, 0x00, + + // (5th ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x02, // AceFlags: CONTAINER_INHERIT_ACE + 0x18, 0x00, // AceSize + 0x19, 0x00, 0x02, 0x00, // ACCESS_MASK: "Read Control" (0x00020000) | + // "Notify" (0x00000010) | + // "Enumerate Subkeys" (0x00000008) | + // "Query Value" (0x00000001) + // (SidStart: S-1-5-32-545 "Users") + 0x01, 0x02, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x20, 0x00, 0x00, 0x00, + 0x21, 0x02, 0x00, 0x00, + + // (6th ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x02, // AceFlags: CONTAINER_INHERIT_ACE + 0x18, 0x00, // AceSize + 0x1F, 0x00, 0x03, 0x00, // ACCESS_MASK: "Read Control" (0x00020000) | + // "Delete" (0x00010000) | + // "Notify" (0x00000010) | + // "Enumerate Subkeys" (0x00000008) | + // "Create Subkey" (0x00000004) | + // "Set Value" (0x00000002) | + // "Query Value" (0x00000001) + // (SidStart: S-1-5-32-547 "Power Users") + 0x01, 0x02, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x20, 0x00, 0x00, 0x00, + 0x23, 0x02, 0x00, 0x00, + + // Owner SID (S-1-5-32-544 "Administrators") + 0x01, 0x02, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x20, 0x00, 0x00, 0x00, + 0x20, 0x02, 0x00, 0x00, + + // Group SID (S-1-5-21-domain-513 "Domain Users") + 0x01, 0x05, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x15, 0x00, 0x00, 0x00, + 0xAC, 0xD0, 0x49, 0xCB, + 0xE6, 0x52, 0x47, 0x9C, + 0xE4, 0x31, 0xDB, 0x5C, + 0x01, 0x02, 0x00, 0x00 +}; + +// Same security for SYSTEM, SAM and .DEFAULT +UCHAR SystemSecurity[] = +{ + // SECURITY_DESCRIPTOR_RELATIVE + 0x01, // Revision + 0x00, // Sbz1 + 0x04, 0x94, // Control: SE_SELF_RELATIVE (0x8000) | + // SE_DACL_PROTECTED (0x1000) | + // SE_DACL_AUTO_INHERITED (0x0400) | + // SE_DACL_PRESENT (0x0004) + 0x8C, 0x00, 0x00, 0x00, // Owner + 0x9C, 0x00, 0x00, 0x00, // Group + 0x00, 0x00, 0x00, 0x00, // Sacl (None) + 0x14, 0x00, 0x00, 0x00, // Dacl + + // DACL + 0x02, // AclRevision + 0x00, // Sbz1 + 0x78, 0x00, // AclSize + 0x05, 0x00, // AceCount + 0x00, 0x00, // Sbz2 + + // (1st ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x02, // AceFlags: CONTAINER_INHERIT_ACE + 0x18, 0x00, // AceSize + 0x3F, 0x00, 0x0F, 0x00, // ACCESS_MASK: "Full Control" (0x000F003F) + // (SidStart: S-1-5-32-544 "Administrators") + 0x01, 0x02, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x20, 0x00, 0x00, 0x00, + 0x20, 0x02, 0x00, 0x00, + + // (2nd ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x0A, // AceFlags: INHERIT_ONLY_ACE | CONTAINER_INHERIT_ACE + 0x14, 0x00, // AceSize + 0x3F, 0x00, 0x0F, 0x00, // ACCESS_MASK: "Full Control" (0x000F003F) + // (SidStart: S-1-3-0 "Creator Owner") + 0x01, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x03, + 0x00, 0x00, 0x00, 0x00, + + // (3rd ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x02, // AceFlags: CONTAINER_INHERIT_ACE + 0x14, 0x00, // AceSize + 0x3F, 0x00, 0x0F, 0x00, // ACCESS_MASK: "Full Control" (0x000F003F) + // (SidStart: S-1-5-18 "Local System") + 0x01, 0x01, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x12, 0x00, 0x00, 0x00, + + // (4th ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x02, // AceFlags: CONTAINER_INHERIT_ACE + 0x18, 0x00, // AceSize + 0x19, 0x00, 0x02, 0x00, // ACCESS_MASK: "Read Control" (0x00020000) | + // "Notify" (0x00000010) | + // "Enumerate Subkeys" (0x00000008) | + // "Query Value" (0x00000001) + // (SidStart: S-1-5-32-545 "Users") + 0x01, 0x02, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x20, 0x00, 0x00, 0x00, + 0x21, 0x02, 0x00, 0x00, + + // (5th ACE) + 0x00, // AceType : ACCESS_ALLOWED_ACE_TYPE + 0x02, // AceFlags: CONTAINER_INHERIT_ACE + 0x18, 0x00, // AceSize + 0x19, 0x00, 0x02, 0x00, // ACCESS_MASK: "Read Control" (0x00020000) | + // "Notify" (0x00000010) | + // "Enumerate Subkeys" (0x00000008) | + // "Query Value" (0x00000001) + // (SidStart: S-1-5-32-547 "Power Users") + 0x01, 0x02, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x20, 0x00, 0x00, 0x00, + 0x23, 0x02, 0x00, 0x00, + + // Owner SID (S-1-5-32-544 "Administrators") + 0x01, 0x02, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x20, 0x00, 0x00, 0x00, + 0x20, 0x02, 0x00, 0x00, + + // Group SID (S-1-5-21-domain-513 "Domain Users") + 0x01, 0x05, 0x00, 0x00, + 0x00, 0x00, 0x00, 0x05, + 0x15, 0x00, 0x00, 0x00, + 0xAC, 0xD0, 0x49, 0xCB, + 0xE6, 0x52, 0x47, 0x9C, + 0xE4, 0x31, 0xDB, 0x5C, + 0x01, 0x02, 0x00, 0x00 +}; + static PMEMKEY CreateInMemoryStructure( IN PCMHIVE RegistryHive, @@ -56,7 +337,7 @@ { PMEMKEY Key; - Key = (PMEMKEY) malloc (sizeof(MEMKEY)); + Key = (PMEMKEY)malloc(sizeof(MEMKEY)); if (!Key) return NULL; @@ -83,13 +364,14 @@ PMEMKEY CurrentKey; PCMHIVE ParentRegistryHive; HCELL_INDEX ParentCellOffset; + PCM_KEY_NODE ParentKeyCell; PLIST_ENTRY Ptr; PCM_KEY_NODE SubKeyCell; HCELL_INDEX BlockOffset; DPRINT("RegpCreateOpenKey('%S')\n", KeyName); - if (*KeyName == L'\\') + if (*KeyName == OBJ_NAME_PATH_SEPARATOR) { KeyName++; ParentRegistryHive = RootKey->RegistryHive; @@ -102,14 +384,14 @@ } else { - ParentRegistryHive = HKEY_TO_MEMKEY(RootKey)->RegistryHive; - ParentCellOffset = HKEY_TO_MEMKEY(RootKey)->KeyCellOffset; + ParentRegistryHive = HKEY_TO_MEMKEY(hParentKey)->RegistryHive; + ParentCellOffset = HKEY_TO_MEMKEY(hParentKey)->KeyCellOffset; } LocalKeyName = (PWSTR)KeyName; for (;;) { - End = (PWSTR)strchrW(LocalKeyName, '\\'); + End = (PWSTR)strchrW(LocalKeyName, OBJ_NAME_PATH_SEPARATOR); if (End) { KeyString.Buffer = LocalKeyName; @@ -121,19 +403,22 @@ RtlInitUnicodeString(&KeyString, LocalKeyName); if (KeyString.Length == 0) { - /* Trailing backslash char; we're done */ + /* Trailing path separator: we're done */ break; } } - Status = CmiScanForSubKey(ParentRegistryHive, - ParentCellOffset, - &KeyString, - OBJ_CASE_INSENSITIVE, - &SubKeyCell, - &BlockOffset); - if (NT_SUCCESS(Status)) + ParentKeyCell = (PCM_KEY_NODE)HvGetCell(&ParentRegistryHive->Hive, ParentCellOffset); + if (!ParentKeyCell) + return STATUS_UNSUCCESSFUL; + + VERIFY_KEY_CELL(ParentKeyCell); + + BlockOffset = CmpFindSubKeyByName(&ParentRegistryHive->Hive, ParentKeyCell, &KeyString); + if (BlockOffset != HCELL_NIL) { + Status = STATUS_SUCCESS; + /* Search for a possible reparse point */ Ptr = CmiReparsePointsHead.Flink; while (Ptr != &CmiReparsePointsHead) @@ -149,19 +434,20 @@ Ptr = Ptr->Flink; } } - else if (Status == STATUS_OBJECT_NAME_NOT_FOUND && AllowCreation) + else if (AllowCreation) // && (BlockOffset == HCELL_NIL) { Status = CmiAddSubKey(ParentRegistryHive, ParentCellOffset, &KeyString, - Volatile ? REG_OPTION_VOLATILE : 0, - &SubKeyCell, + Volatile, &BlockOffset); } + + HvReleaseCell(&ParentRegistryHive->Hive, ParentCellOffset); + if (!NT_SUCCESS(Status)) return ERROR_UNSUCCESSFUL; -nextsubkey: ParentCellOffset = BlockOffset; if (End) LocalKeyName = End + 1; @@ -172,6 +458,7 @@ CurrentKey = CreateInMemoryStructure(ParentRegistryHive, ParentCellOffset); if (!CurrentKey) return ERROR_OUTOFMEMORY; + *Key = MEMKEY_TO_HKEY(CurrentKey); return ERROR_SUCCESS; @@ -186,54 +473,14 @@ return RegpOpenOrCreateKey(hKey, lpSubKey, TRUE, FALSE, phkResult); } -static PWSTR -MultiByteToWideChar( - IN PCSTR MultiByteString) -{ - ANSI_STRING Source; - UNICODE_STRING Destination; - NTSTATUS Status; - - RtlInitAnsiString(&Source, MultiByteString); - Status = RtlAnsiStringToUnicodeString(&Destination, &Source, TRUE); - if (!NT_SUCCESS(Status)) - return NULL; - return Destination.Buffer; -} - LONG WINAPI RegDeleteKeyW( IN HKEY hKey, IN LPCWSTR lpSubKey) { - DPRINT1("FIXME: implement RegDeleteKeyW!\n"); + DPRINT1("RegDeleteKeyW(0x%p, '%S') is UNIMPLEMENTED!\n", + hKey, (lpSubKey ? lpSubKey : L"")); return ERROR_SUCCESS; -} - -LONG WINAPI -RegDeleteKeyA( - IN HKEY hKey, - IN LPCSTR lpSubKey) -{ - PWSTR lpSubKeyW = NULL; - LONG rc; - - if (lpSubKey != NULL && strchr(lpSubKey, '\\') != NULL) - return ERROR_INVALID_PARAMETER; - - if (lpSubKey) - { - lpSubKeyW = MultiByteToWideChar(lpSubKey); - if (!lpSubKeyW) - return ERROR_OUTOFMEMORY; - } - - rc = RegDeleteKeyW(hKey, lpSubKeyW); - - if (lpSubKey) - free(lpSubKeyW); - - return rc; } LONG WINAPI @@ -265,57 +512,6 @@ } LONG WINAPI -RegOpenKeyA( - IN HKEY hKey, - IN LPCSTR lpSubKey, - OUT PHKEY phkResult) -{ - PWSTR lpSubKeyW; - LONG rc; - - lpSubKeyW = MultiByteToWideChar(lpSubKey); - if (!lpSubKeyW) - return ERROR_OUTOFMEMORY; - - rc = RegOpenKeyW(hKey, lpSubKeyW, phkResult); - free(lpSubKeyW); - return rc; -} - -static LONG -RegpOpenOrCreateValue( - IN HKEY hKey, - IN LPCWSTR ValueName, - IN BOOL AllowCreation, - OUT PCM_KEY_VALUE *ValueCell, - OUT PHCELL_INDEX ValueCellOffset) -{ - PMEMKEY ParentKey; - UNICODE_STRING ValueString; - NTSTATUS Status; - - ParentKey = HKEY_TO_MEMKEY(hKey); - RtlInitUnicodeString(&ValueString, ValueName); - - Status = CmiScanForValueKey(ParentKey->RegistryHive, - ParentKey->KeyCellOffset, - &ValueString, - ValueCell, - ValueCellOffset); - if (AllowCreation && Status == STATUS_OBJECT_NAME_NOT_FOUND) - { - Status = CmiAddValueKey(ParentKey->RegistryHive, - ParentKey->KeyCellOffset, - &ValueString, - ValueCell, - ValueCellOffset); - } - if (!NT_SUCCESS(Status)) - return ERROR_UNSUCCESSFUL; - return ERROR_SUCCESS; -} - -LONG WINAPI RegSetValueExW( IN HKEY hKey, IN LPCWSTR lpValueName OPTIONAL, @@ -324,49 +520,84 @@ IN const UCHAR* lpData, IN USHORT cbData) { - PMEMKEY Key, DestKey; - PHKEY phKey; + PMEMKEY Key = HKEY_TO_MEMKEY(hKey); // ParentKey + PHHIVE Hive; + PCM_KEY_NODE KeyNode; // ParentNode PCM_KEY_VALUE ValueCell; - HCELL_INDEX ValueCellOffset; + HCELL_INDEX CellIndex; + UNICODE_STRING ValueNameString; + PVOID DataCell; LONG DataCellSize; NTSTATUS Status; if (dwType == REG_LINK) { + PMEMKEY DestKey; + /* Special handling of registry links */ if (cbData != sizeof(PVOID)) return STATUS_INVALID_PARAMETER; - phKey = (PHKEY)lpData; - Key = HKEY_TO_MEMKEY(hKey); - DestKey = HKEY_TO_MEMKEY(*phKey); + DestKey = HKEY_TO_MEMKEY(*(PHKEY)lpData); + + // FIXME: Add additional checks for the validity of DestKey /* Create the link in registry hive (if applicable) */ if (Key->RegistryHive != DestKey->RegistryHive) return STATUS_SUCCESS; + DPRINT1("Save link to registry\n"); return STATUS_NOT_IMPLEMENTED; } - if ((cbData & REG_DATA_SIZE_MASK) != cbData) + if ((cbData & ~CM_KEY_VALUE_SPECIAL_SIZE) != cbData) return STATUS_UNSUCCESSFUL; - Key = HKEY_TO_MEMKEY(hKey); - - Status = RegpOpenOrCreateValue(hKey, lpValueName, TRUE, &ValueCell, &ValueCellOffset); + Hive = &Key->RegistryHive->Hive; + + KeyNode = (PCM_KEY_NODE)HvGetCell(Hive, Key->KeyCellOffset); + if (!KeyNode) + return ERROR_UNSUCCESSFUL; + + ASSERT(KeyNode->Signature == CM_KEY_NODE_SIGNATURE); + + /* Mark the parent as dirty since we are going to create a new value in it */ + HvMarkCellDirty(Hive, Key->KeyCellOffset, FALSE); + + /* Initialize value name string */ + RtlInitUnicodeString(&ValueNameString, lpValueName); + CellIndex = CmpFindValueByName(Hive, KeyNode, &ValueNameString); + if (CellIndex == HCELL_NIL) + { + /* The value doesn't exist, create a new one */ + Status = CmiAddValueKey(Key->RegistryHive, + KeyNode, + &ValueNameString, + &ValueCell, + &CellIndex); + } + else + { + /* The value already exists, use it. Get the value cell. */ + ValueCell = HvGetCell(&Key->RegistryHive->Hive, CellIndex); + ASSERT(ValueCell != NULL); + } + + // /**/HvReleaseCell(Hive, CellIndex);/**/ + if (!NT_SUCCESS(Status)) return ERROR_UNSUCCESSFUL; - /* Get size of the allocated cellule (if any) */ - if (!(ValueCell->DataLength & REG_DATA_IN_OFFSET) && - (ValueCell->DataLength & REG_DATA_SIZE_MASK) != 0) - { - DataCell = HvGetCell(&Key->RegistryHive->Hive, ValueCell->Data); + /* Get size of the allocated cell (if any) */ + if (!(ValueCell->DataLength & CM_KEY_VALUE_SPECIAL_SIZE) && + (ValueCell->DataLength & ~CM_KEY_VALUE_SPECIAL_SIZE) != 0) + { + DataCell = HvGetCell(Hive, ValueCell->Data); if (!DataCell) return ERROR_UNSUCCESSFUL; - DataCellSize = -HvGetCellSize(&Key->RegistryHive->Hive, DataCell); + DataCellSize = -HvGetCellSize(Hive, DataCell); } else { @@ -379,12 +610,11 @@ /* If data size <= sizeof(HCELL_INDEX) then store data in the data offset */ DPRINT("ValueCell->DataLength %u\n", ValueCell->DataLength); if (DataCell) - HvFreeCell(&Key->RegistryHive->Hive, ValueCell->Data); + HvFreeCell(Hive, ValueCell->Data); RtlCopyMemory(&ValueCell->Data, lpData, cbData); - ValueCell->DataLength = (ULONG)(cbData | REG_DATA_IN_OFFSET); + ValueCell->DataLength = (ULONG)(cbData | CM_KEY_VALUE_SPECIAL_SIZE); ValueCell->Type = dwType; - HvMarkCellDirty(&Key->RegistryHive->Hive, ValueCellOffset, FALSE); } else { @@ -396,7 +626,7 @@ DPRINT("ValueCell->DataLength %u\n", ValueCell->DataLength); - NewOffset = HvAllocateCell(&Key->RegistryHive->Hive, cbData, Stable, HCELL_NIL); + NewOffset = HvAllocateCell(Hive, cbData, Stable, HCELL_NIL); if (NewOffset == HCELL_NIL) { DPRINT("HvAllocateCell() failed with status 0x%08x\n", Status); @@ -404,52 +634,114 @@ } if (DataCell) - HvFreeCell(&Key->RegistryHive->Hive, ValueCell->Data); + HvFreeCell(Hive, ValueCell->Data); ValueCell->Data = NewOffset; - DataCell = (PVOID)HvGetCell(&Key->RegistryHive->Hive, NewOffset); + DataCell = (PVOID)HvGetCell(Hive, NewOffset); } - /* Copy new contents to cellule */ + /* Copy new contents to cell */ RtlCopyMemory(DataCell, lpData, cbData); - ValueCell->DataLength = (ULONG)(cbData & REG_DATA_SIZE_MASK); + ValueCell->DataLength = (ULONG)(cbData & ~CM_KEY_VALUE_SPECIAL_SIZE); ValueCell->Type = dwType; - HvMarkCellDirty(&Key->RegistryHive->Hive, ValueCell->Data, FALSE); - HvMarkCellDirty(&Key->RegistryHive->Hive, ValueCellOffset, FALSE); - } - - HvMarkCellDirty(&Key->RegistryHive->Hive, Key->KeyCellOffset, FALSE); + HvMarkCellDirty(Hive, ValueCell->Data, FALSE); + } + + HvMarkCellDirty(Hive, CellIndex, FALSE); + + /* Check if the maximum value name length changed, update it if so */ + if (KeyNode->MaxValueNameLen < ValueNameString.Length) + KeyNode->MaxValueNameLen = ValueNameString.Length; + + /* Check if the maximum data length changed, update it if so */ + if (KeyNode->MaxValueDataLen < cbData) + KeyNode->MaxValueDataLen = cbData; + + /* Save the write time */ + KeQuerySystemTime(&KeyNode->LastWriteTime); DPRINT("Return status 0x%08x\n", Status); return Status; } + +// Synced with freeldr/windows/registry.c +static +VOID +RepGetValueData( + IN PHHIVE Hive, + IN PCM_KEY_VALUE ValueCell, + OUT ULONG* Type OPTIONAL, + OUT PUCHAR Data OPTIONAL, + IN OUT ULONG* DataSize OPTIONAL) +{ + ULONG DataLength; + PVOID DataCell; + + /* Does the caller want the type? */ + if (Type != NULL) + *Type = ValueCell->Type; + + /* Does the caller provide DataSize? */ + if (DataSize != NULL) + { + // NOTE: CmpValueToData doesn't support big data (the function will + // bugcheck if so), FreeLdr is not supposed to read such data. + // If big data is needed, use instead CmpGetValueData. + // CmpGetValueData(Hive, ValueCell, DataSize, &DataCell, ...); + DataCell = CmpValueToData(Hive, ValueCell, &DataLength); + + /* Does the caller want the data? */ + if ((Data != NULL) && (*DataSize != 0)) + { + RtlCopyMemory(Data, + DataCell, + min(*DataSize, DataLength)); + } + + /* Return the actual data length */ + *DataSize = DataLength; + } +} + +// Similar to RegQueryValue in freeldr/windows/registry.c LONG WINAPI RegQueryValueExW( IN HKEY hKey, IN LPCWSTR lpValueName, IN PULONG lpReserved, - OUT PULONG lpType, - OUT PUCHAR lpData, - OUT PSIZE_T lpcbData) -{ - //ParentKey = HKEY_TO_MEMKEY(RootKey); + OUT PULONG lpType OPTIONAL, + OUT PUCHAR lpData OPTIONAL, + IN OUT PSIZE_T lpcbData OPTIONAL) +{ + PMEMKEY ParentKey = HKEY_TO_MEMKEY(hKey); + PHHIVE Hive = &ParentKey->RegistryHive->Hive; + PCM_KEY_NODE KeyNode; PCM_KEY_VALUE ValueCell; - HCELL_INDEX ValueCellOffset; - LONG rc; - - rc = RegpOpenOrCreateValue(hKey, - lpValueName, - FALSE, - &ValueCell, - &ValueCellOffset); - if (rc != ERROR_SUCCESS) - return rc; - - DPRINT1("RegQueryValueExW(%S) not implemented\n", lpValueName); - /* ValueCell and ValueCellOffset are valid */ - - return ERROR_UNSUCCESSFUL; + HCELL_INDEX CellIndex; + UNICODE_STRING ValueNameString; + + KeyNode = (PCM_KEY_NODE)HvGetCell(Hive, ParentKey->KeyCellOffset); + if (!KeyNode) + return ERROR_UNSUCCESSFUL; + + ASSERT(KeyNode->Signature == CM_KEY_NODE_SIGNATURE); + + /* Initialize value name string */ + RtlInitUnicodeString(&ValueNameString, lpValueName); + CellIndex = CmpFindValueByName(Hive, KeyNode, &ValueNameString); + if (CellIndex == HCELL_NIL) + return ERROR_FILE_NOT_FOUND; + + /* Get the value cell */ + ValueCell = HvGetCell(Hive, CellIndex); + ASSERT(ValueCell != NULL); + + RepGetValueData(Hive, ValueCell, lpType, lpData, lpcbData); + + HvReleaseCell(Hive, CellIndex); + + return ERROR_SUCCESS; } LONG WINAPI @@ -457,14 +749,18 @@ IN HKEY hKey, IN LPCWSTR lpValueName OPTIONAL) { - DPRINT1("RegDeleteValueW() unimplemented\n"); + DPRINT1("RegDeleteValueW(0x%p, '%S') is UNIMPLEMENTED!\n", + hKey, (lpValueName ? lpValueName : L"")); return ERROR_UNSUCCESSFUL; } + static BOOL ConnectRegistry( IN HKEY RootKey, IN PCMHIVE HiveToConnect, + IN PUCHAR Descriptor, + IN ULONG DescriptorLength, IN LPCWSTR Path) { NTSTATUS Status; @@ -476,13 +772,31 @@ if (!ReparsePoint) return FALSE; - Status = CmiInitializeTempHive(HiveToConnect); + /* + * Use a dummy root key name: + * - On 2k/XP/2k3, this is "$$$PROTO.HIV" + * - On Vista+, this is "CMI-CreateHive{guid}" + * See https://github.com/libyal/winreg-kb/blob/master/documentation/Registry%20fi… + * for more information. + */ + Status = CmiInitializeHive(HiveToConnect, L"$$$PROTO.HIV"); if (!NT_SUCCESS(Status)) { - DPRINT1("CmiInitializeTempHive() failed with status 0x%08x\n", Status); + DPRINT1("CmiInitializeHive() failed with status 0x%08x\n", Status); free(ReparsePoint); return FALSE; } + + /* + * Add security to the root key. + * NOTE: One can implement this using the lpSecurityAttributes + * parameter of RegCreateKeyExW. + */ + Status = CmiCreateSecurityKey(&HiveToConnect->Hive, + HiveToConnect->Hive.BaseBlock->RootCell, + Descriptor, DescriptorLength); + if (!NT_SUCCESS(Status)) + DPRINT1("Failed to add security for root key '%S'\n", Path); /* Create key */ rc = RegCreateKeyExW(RootKey, @@ -523,10 +837,10 @@ InitializeListHead(&CmiHiveListHead); InitializeListHead(&CmiReparsePointsHead); - Status = CmiInitializeTempHive(&RootHive); + Status = CmiInitializeHive(&RootHive, L""); if (!NT_SUCCESS(Status)) { - DPRINT1("CmiInitializeTempHive() failed with status 0x%08x\n", Status); + DPRINT1("CmiInitializeHive() failed with status 0x%08x\n", Status); return; } @@ -536,31 +850,37 @@ /* Create DEFAULT key */ ConnectRegistry(NULL, &DefaultHive, + SystemSecurity, sizeof(SystemSecurity), L"Registry\\User\\.DEFAULT"); /* Create SAM key */ ConnectRegistry(NULL, &SamHive, + SystemSecurity, sizeof(SystemSecurity), L"Registry\\Machine\\SAM"); /* Create SECURITY key */ ConnectRegistry(NULL, &SecurityHive, + NULL, 0, L"Registry\\Machine\\SECURITY"); /* Create SOFTWARE key */ ConnectRegistry(NULL, &SoftwareHive, + SoftwareSecurity, sizeof(SoftwareSecurity), L"Registry\\Machine\\SOFTWARE"); /* Create BCD key */ ConnectRegistry(NULL, &BcdHive, + BcdSecurity, sizeof(BcdSecurity), L"Registry\\Machine\\BCD00000000"); /* Create SYSTEM key */ ConnectRegistry(NULL, &SystemHive, + SystemSecurity, sizeof(SystemSecurity), L"Registry\\Machine\\SYSTEM"); /* Create 'ControlSet001' key */ Modified: trunk/reactos/tools/mkhive/rtl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/rtl.c?rev=706… ============================================================================== --- trunk/reactos/tools/mkhive/rtl.c [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/rtl.c [iso-8859-1] Sun Jan 17 00:50:03 2016 @@ -1,4 +1,5 @@ -/* COPYRIGHT: See COPYING in the top level directory +/* + * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS hive maker * FILE: tools/mkhive/rtl.c * PURPOSE: Runtime Library @@ -217,6 +218,23 @@ //DbgBreakPoint(); } +// DECLSPEC_NORETURN +VOID +NTAPI +KeBugCheckEx( + IN ULONG BugCheckCode, + IN ULONG_PTR BugCheckParameter1, + IN ULONG_PTR BugCheckParameter2, + IN ULONG_PTR BugCheckParameter3, + IN ULONG_PTR BugCheckParameter4) +{ + char Buffer[70]; + printf("*** STOP: 0x%08lX (0x%08lX, 0x%08lX, 0x%08lX, 0x%08lX)", + BugCheckCode, BugCheckParameter1, BugCheckParameter2, + BugCheckParameter3, BugCheckParameter4); + ASSERT(FALSE); +} + unsigned char BitScanForward(ULONG * Index, unsigned long Mask) { *Index = 0;

1 0

[hbelusca] 70601: [CMLIB] - One less hardcoded number. - Minor code formatting. [NTOS] - Minor code formatting (cmvalche.c). - The key-node timestamp can usually be retrieved without using another ...
by hbelusca＠svn.reactos.org 16 Jan '16

16 Jan '16

Author: hbelusca Date: Sat Jan 16 23:54:45 2016 New Revision: 70601 URL: http://svn.reactos.org/svn/reactos?rev=70601&view=rev Log: [CMLIB] - One less hardcoded number. - Minor code formatting. [NTOS] - Minor code formatting (cmvalche.c). - The key-node timestamp can usually be retrieved without using another temporary value. - The security descriptor copy allocated for the hive can be freed after it was assigned to it. [MKHIVE] - Minor formatting of the source headers. - Update the list of registry value types; add another error code (to be used later on). - Remove now unused "ntoskrnl.h" header. CORE-10793 Removed: trunk/reactos/tools/mkhive/ntoskrnl.h Modified: trunk/reactos/lib/cmlib/cmindex.c trunk/reactos/lib/cmlib/cmname.c trunk/reactos/lib/cmlib/cmvalue.c trunk/reactos/lib/cmlib/hivewrt.c trunk/reactos/ntoskrnl/config/cmparse.c trunk/reactos/ntoskrnl/config/cmsysini.c trunk/reactos/ntoskrnl/config/cmvalche.c trunk/reactos/tools/mkhive/binhive.c trunk/reactos/tools/mkhive/binhive.h trunk/reactos/tools/mkhive/reginf.c trunk/reactos/tools/mkhive/reginf.h trunk/reactos/tools/mkhive/registry.h Modified: trunk/reactos/lib/cmlib/cmindex.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmindex.c?rev=70… ============================================================================== --- trunk/reactos/lib/cmlib/cmindex.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/cmindex.c [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -10,19 +10,19 @@ #include "cmlib.h" #define NDEBUG -#include "debug.h" +#include <debug.h> /* GLOBALS *******************************************************************/ -ULONG CmpMaxFastIndexPerHblock = - (HBLOCK_SIZE - (sizeof(HBIN) + - sizeof(HCELL) + - FIELD_OFFSET(CM_KEY_FAST_INDEX, List))) / sizeof(CM_INDEX); - -ULONG CmpMaxIndexPerHblock = - (HBLOCK_SIZE - (sizeof(HBIN) + - sizeof(HCELL) + - FIELD_OFFSET(CM_KEY_INDEX, List))) / sizeof(HCELL_INDEX) - 1; +#define INVALID_INDEX 0x80000000 + +#define CmpMaxFastIndexPerHblock \ + ((HBLOCK_SIZE - (sizeof(HBIN) + sizeof(HCELL) + \ + FIELD_OFFSET(CM_KEY_FAST_INDEX, List))) / sizeof(CM_INDEX)) + +#define CmpMaxIndexPerHblock \ + ((HBLOCK_SIZE - (sizeof(HBIN) + sizeof(HCELL) + \ + FIELD_OFFSET(CM_KEY_INDEX, List))) / sizeof(HCELL_INDEX) - 1) /* FUNCTIONS *****************************************************************/ @@ -232,7 +232,7 @@ { Big: /* This was some sort of special key */ - ReturnIndex = 0x80000000; + ReturnIndex = INVALID_INDEX; goto ReturnFailure; } @@ -262,7 +262,7 @@ /* Check if we found it */ if (!Result) { - /* We got lucky...return it */ + /* We got lucky... return it */ *SubKey = LeafCell; ReturnIndex = Low; goto Return; @@ -389,7 +389,7 @@ { /* Fail with special value */ *SubKey = HCELL_NIL; - return 0x80000000; + return INVALID_INDEX; } /* Check if we got lucky and found it */ @@ -425,7 +425,7 @@ { /* Fail with special value */ *SubKey = HCELL_NIL; - return 0x80000000; + return INVALID_INDEX; } /* Check if we got lucky and found it */ @@ -448,7 +448,7 @@ { /* Fail with special value */ *SubKey = HCELL_NIL; - return 0x80000000; + return INVALID_INDEX; } /* Return the high */ @@ -625,8 +625,7 @@ if (Number < Node->SubKeyCounts[Volatile]) { /* Get the actual key index */ - Index = (PCM_KEY_INDEX)HvGetCell(Hive, - Node->SubKeyLists[Volatile]); + Index = (PCM_KEY_INDEX)HvGetCell(Hive, Node->SubKeyLists[Volatile]); if (!Index) return HCELL_NIL; /* Do a search inside it */ @@ -717,7 +716,7 @@ HvReleaseCell(Hive, CellToRelease); /* Make sure we found something valid */ - if (Found & 0x80000000) break; + if (Found & INVALID_INDEX) break; /* Get the new Index Root and set the new cell to be released */ if (SubKey == HCELL_NIL) continue; @@ -744,7 +743,7 @@ HvReleaseCell(Hive, CellToRelease); /* Make sure we found a valid index */ - if (Found & 0x80000000) break; + if (Found & INVALID_INDEX) break; } else { @@ -856,7 +855,7 @@ { /* Get the child inside the root */ Result = CmpFindSubKeyInRoot(Hive, Index, &SearchName, &Child); - if (Result & 0x80000000) goto Quickie; + if (Result & INVALID_INDEX) goto Quickie; if (Child == HCELL_NIL) continue; /* We found it, mark the cell dirty */ @@ -886,7 +885,7 @@ /* Find the child in the leaf */ Result = CmpFindSubKeyInLeaf(Hive, Index, &SearchName, &Child); - if (Result & 0x80000000) goto Quickie; + if (Result & INVALID_INDEX) goto Quickie; if (Child != HCELL_NIL) { /* We found it, free the name now */ @@ -1004,7 +1003,7 @@ /* Find the insertion point for our entry */ i = CmpFindSubKeyInLeaf(Hive, Leaf, Name, &Child); - if (i & 0x80000000) return HCELL_NIL; + if (i & INVALID_INDEX) return HCELL_NIL; ASSERT(Child == HCELL_NIL); /* Check if we're not last */ @@ -1299,7 +1298,7 @@ SubKeyIndex = CmpFindSubKeyInRoot(Hive, IndexKey, Name, &LeafCell); /* Make sure we found something valid */ - if (SubKeyIndex & 0x80000000) return HCELL_NIL; + if (SubKeyIndex & INVALID_INDEX) return HCELL_NIL; /* Try to fit it into the LeafCell, if it was found */ if (LeafCell != HCELL_NIL) @@ -1705,7 +1704,7 @@ HCELL_INDEX RootCell = HCELL_NIL, LeafCell, ChildCell; PCM_KEY_INDEX Root = NULL, Leaf; PCM_KEY_FAST_INDEX Child; - ULONG Storage, RootIndex = 0x80000000, LeafIndex; + ULONG Storage, RootIndex = INVALID_INDEX, LeafIndex; BOOLEAN Result = FALSE; HCELL_INDEX CellToRelease1 = HCELL_NIL, CellToRelease2 = HCELL_NIL; @@ -1784,7 +1783,7 @@ { /* Find the child inside the root */ RootIndex = CmpFindSubKeyInRoot(Hive, Leaf, &SearchName, &ChildCell); - if (RootIndex & 0x80000000) goto Exit; + if (RootIndex & INVALID_INDEX) goto Exit; ASSERT(ChildCell != FALSE); /* The root cell is now this leaf */ @@ -1807,7 +1806,7 @@ /* Now get the child in the leaf */ LeafIndex = CmpFindSubKeyInLeaf(Hive, Leaf, &SearchName, &ChildCell); - if (LeafIndex & 0x80000000) goto Exit; + if (LeafIndex & INVALID_INDEX) goto Exit; ASSERT(ChildCell != HCELL_NIL); /* Decrement key counts and check if this was the last leaf entry */ Modified: trunk/reactos/lib/cmlib/cmname.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmname.c?rev=706… ============================================================================== --- trunk/reactos/lib/cmlib/cmname.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/cmname.c [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -10,7 +10,7 @@ #include "cmlib.h" #define NDEBUG -#include "debug.h" +#include <debug.h> /* GLOBALS *******************************************************************/ @@ -110,8 +110,8 @@ IN PWCHAR CompressedName, IN ULONG NameLength) { - WCHAR *p; - UCHAR *pp; + WCHAR* p; + UCHAR* pp; WCHAR chr1, chr2; USHORT SearchLength; LONG Result; @@ -120,7 +120,7 @@ p = SearchName->Buffer; pp = (PUCHAR)CompressedName; SearchLength = (SearchName->Length / sizeof(WCHAR)); - while ((SearchLength) && (NameLength)) + while (SearchLength > 0 && NameLength > 0) { /* Get the characters */ chr1 = *p++; @@ -149,8 +149,8 @@ CmpFindNameInList(IN PHHIVE Hive, IN PCHILD_LIST ChildList, IN PUNICODE_STRING Name, - IN PULONG ChildIndex, - IN PHCELL_INDEX CellIndex) + OUT PULONG ChildIndex, + OUT PHCELL_INDEX CellIndex) { PCELL_DATA CellData; HCELL_INDEX CellToRelease = HCELL_NIL; @@ -199,14 +199,14 @@ /* Check if it's a compressed value name */ if (KeyValue->Flags & VALUE_COMP_NAME) { - /* Use the compressed name check */ + /* Compare compressed names */ Result = CmpCompareCompressedName(Name, KeyValue->Name, KeyValue->NameLength); } else { - /* Setup the Unicode string */ + /* Compare the Unicode name directly */ SearchName.Length = KeyValue->NameLength; SearchName.MaximumLength = SearchName.Length; SearchName.Buffer = KeyValue->Name; @@ -216,7 +216,7 @@ /* Check if we found it */ if (!Result) { - /* We did...return info to caller */ + /* We did... return info to caller */ if (ChildIndex) *ChildIndex = i; *CellIndex = CellData->u.KeyList[i]; @@ -235,7 +235,7 @@ goto Return; } - /* Nothing found...check if the caller wanted more info */ + /* Nothing found... check if the caller wanted more info */ ASSERT(ChildList->Count == 0); if (ChildIndex) *ChildIndex = 0; *CellIndex = HCELL_NIL; Modified: trunk/reactos/lib/cmlib/cmvalue.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/cmvalue.c?rev=70… ============================================================================== --- trunk/reactos/lib/cmlib/cmvalue.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/cmvalue.c [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -109,7 +109,7 @@ NULL, &CellIndex)) { - /* Santy check */ + /* Sanity check */ ASSERT(CellIndex == HCELL_NIL); } @@ -117,11 +117,14 @@ return CellIndex; } +/* + * NOTE: This function should support big values, contrary to CmpValueToData. + */ BOOLEAN NTAPI CmpGetValueData(IN PHHIVE Hive, IN PCM_KEY_VALUE Value, - IN PULONG Length, + OUT PULONG Length, OUT PVOID *Buffer, OUT PBOOLEAN BufferAllocated, OUT PHCELL_INDEX CellToRelease) @@ -144,7 +147,7 @@ return TRUE; } - /* Unsupported */ + /* Unsupported at the moment */ ASSERT_VALUE_BIG(Hive, *Length); /* Get the data from the cell */ @@ -156,6 +159,9 @@ return TRUE; } +/* + * NOTE: This function doesn't support big values, contrary to CmpGetValueData. + */ PCELL_DATA NTAPI CmpValueToData(IN PHHIVE Hive, @@ -409,7 +415,6 @@ IN PHHIVE DestinationHive, IN OUT PCHILD_LIST DestValueList, IN HSTORAGE_TYPE StorageType) - { NTSTATUS Status = STATUS_SUCCESS; HCELL_INDEX CellIndex = HCELL_NIL; Modified: trunk/reactos/lib/cmlib/hivewrt.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/lib/cmlib/hivewrt.c?rev=70… ============================================================================== --- trunk/reactos/lib/cmlib/hivewrt.c [iso-8859-1] (original) +++ trunk/reactos/lib/cmlib/hivewrt.c [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -118,10 +118,10 @@ DPRINT("FileFlush failed\n"); } - /* Update second update counter and CheckSum. */ + /* Update second update counter and CheckSum */ RegistryHive->BaseBlock->Sequence2++; RegistryHive->BaseBlock->CheckSum = - HvpHiveHeaderChecksum(RegistryHive->BaseBlock); + HvpHiveHeaderChecksum(RegistryHive->BaseBlock); /* Write hive header again with updated sequence counter. */ FileOffset = 0; @@ -170,7 +170,7 @@ RegistryHive->BaseBlock->Type = HFILE_TYPE_PRIMARY; RegistryHive->BaseBlock->Sequence1++; RegistryHive->BaseBlock->CheckSum = - HvpHiveHeaderChecksum(RegistryHive->BaseBlock); + HvpHiveHeaderChecksum(RegistryHive->BaseBlock); /* Write hive block */ FileOffset = 0; Modified: trunk/reactos/ntoskrnl/config/cmparse.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmparse.c?… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmparse.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cmparse.c [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -219,7 +219,6 @@ PCM_KEY_NODE KeyNode; PCELL_DATA CellData; ULONG StorageType; - LARGE_INTEGER SystemTime; PCM_KEY_CONTROL_BLOCK Kcb; PSECURITY_DESCRIPTOR NewDescriptor; @@ -312,8 +311,7 @@ /* Fill out the key node */ KeyNode->Signature = CM_KEY_NODE_SIGNATURE; KeyNode->Flags = Flags; - KeQuerySystemTime(&SystemTime); - KeyNode->LastWriteTime = SystemTime; + KeQuerySystemTime(&KeyNode->LastWriteTime); KeyNode->Spare = 0; KeyNode->Parent = ParentCell; KeyNode->SubKeyCounts[Stable] = 0; @@ -377,6 +375,9 @@ CmpKeyObjectType->TypeInfo.PoolType, &CmpKeyObjectType->TypeInfo.GenericMapping); } + + /* Now that the security descriptor is copied in the hive, we can free the original */ + SeDeassignSecurity(&NewDescriptor); Quickie: /* Check if we got here because of failure */ @@ -516,7 +517,7 @@ KeyBody->KeyControlBlock->ParentKcb->KcbMaxNameLen = Name->Length; } - /* Check if we need toupdate class length maximum */ + /* Check if we need to update class length maximum */ if (KeyNode->MaxClassLen < ParseContext->Class.Length) { /* Update it */ @@ -925,7 +926,7 @@ KeyBody->KeyControlBlock->ParentKcb->KcbMaxNameLen = Name.Length; } - /* Check if we need toupdate class length maximum */ + /* Check if we need to update class length maximum */ if (KeyNode->MaxClassLen < Context->Class.Length) { /* Update it */ Modified: trunk/reactos/ntoskrnl/config/cmsysini.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmsysini.c… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmsysini.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cmsysini.c [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -1030,7 +1030,6 @@ { UNICODE_STRING KeyName; PCM_KEY_NODE KeyCell; - LARGE_INTEGER SystemTime; PAGED_CODE(); /* Initialize the node name and allocate it */ @@ -1048,10 +1047,9 @@ if (!KeyCell) return FALSE; /* Setup the cell */ - KeyCell->Signature = (USHORT)CM_KEY_NODE_SIGNATURE; + KeyCell->Signature = CM_KEY_NODE_SIGNATURE; KeyCell->Flags = KEY_HIVE_ENTRY | KEY_NO_DELETE; - KeQuerySystemTime(&SystemTime); - KeyCell->LastWriteTime = SystemTime; + KeQuerySystemTime(&KeyCell->LastWriteTime); KeyCell->Parent = HCELL_NIL; KeyCell->SubKeyCounts[Stable] = 0; KeyCell->SubKeyCounts[Volatile] = 0; @@ -1068,14 +1066,11 @@ KeyCell->MaxValueDataLen = 0; /* Copy the name (this will also set the length) */ - KeyCell->NameLength = CmpCopyName(Hive, (PWCHAR)KeyCell->Name, &KeyName); - - /* Check if the name was compressed */ + KeyCell->NameLength = CmpCopyName(Hive, KeyCell->Name, &KeyName); + + /* Check if the name was compressed and set the flag if so */ if (KeyCell->NameLength < KeyName.Length) - { - /* Set the flag */ KeyCell->Flags |= KEY_COMP_NAME; - } /* Return success */ HvReleaseCell(Hive, *Index); Modified: trunk/reactos/ntoskrnl/config/cmvalche.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmvalche.c… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmvalche.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cmvalche.c [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -249,14 +249,14 @@ } /* Get the key value for this index */ - SearchResult = CmpGetValueKeyFromCache(Kcb, - CellData, - i, - CachedValue, - Value, - IndexIsCached, - ValueIsCached, - CellToRelease); + SearchResult = CmpGetValueKeyFromCache(Kcb, + CellData, + i, + CachedValue, + Value, + IndexIsCached, + ValueIsCached, + CellToRelease); if (SearchResult != SearchSuccess) { /* We either failed or need the exclusive lock */ @@ -266,7 +266,7 @@ } /* Check if the both the index and the value are cached */ - if ((IndexIsCached) && (*ValueIsCached)) + if (IndexIsCached && *ValueIsCached) { /* We don't expect this yet */ ASSERT_VALUE_CACHE(); Modified: trunk/reactos/tools/mkhive/binhive.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/binhive.c?rev… ============================================================================== --- trunk/reactos/tools/mkhive/binhive.c [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/binhive.c [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -16,7 +16,8 @@ * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -/* COPYRIGHT: See COPYING in the top level directory +/* + * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS hive maker * FILE: tools/mkhive/binhive.c * PURPOSE: Binary hive export code Modified: trunk/reactos/tools/mkhive/binhive.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/binhive.h?rev… ============================================================================== --- trunk/reactos/tools/mkhive/binhive.h [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/binhive.h [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -16,7 +16,8 @@ * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -/* COPYRIGHT: See COPYING in the top level directory +/* + * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS hive maker * FILE: tools/mkhive/binhive.h * PURPOSE: Binary hive export code Removed: trunk/reactos/tools/mkhive/ntoskrnl.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/ntoskrnl.h?re… ============================================================================== --- trunk/reactos/tools/mkhive/ntoskrnl.h [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/ntoskrnl.h (removed) @@ -1,14 +0,0 @@ -/* - * This header is used together with cmindex.c and cmname.c - */ - -#define NDEBUG -#include "mkhive.h" - -PVOID -NTAPI -CmpAllocate( - IN SIZE_T Size, - IN BOOLEAN Paged, - IN ULONG Tag -); Modified: trunk/reactos/tools/mkhive/reginf.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/reginf.c?rev=… ============================================================================== --- trunk/reactos/tools/mkhive/reginf.c [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/reginf.c [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -16,7 +16,8 @@ * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -/* COPYRIGHT: See COPYING in the top level directory +/* + * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS hive maker * FILE: tools/mkhive/reginf.c * PURPOSE: Inf file import code Modified: trunk/reactos/tools/mkhive/reginf.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/reginf.h?rev=… ============================================================================== --- trunk/reactos/tools/mkhive/reginf.h [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/reginf.h [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -16,7 +16,8 @@ * with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ -/* COPYRIGHT: See COPYING in the top level directory +/* + * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS hive maker * FILE: tools/mkhive/reginf.h * PURPOSE: Inf file import code Modified: trunk/reactos/tools/mkhive/registry.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/tools/mkhive/registry.h?re… ============================================================================== --- trunk/reactos/tools/mkhive/registry.h [iso-8859-1] (original) +++ trunk/reactos/tools/mkhive/registry.h [iso-8859-1] Sat Jan 16 23:54:45 2016 @@ -1,4 +1,5 @@ -/* COPYRIGHT: See COPYING in the top level directory +/* + * COPYRIGHT: See COPYING in the top level directory * PROJECT: ReactOS hive maker * FILE: tools/mkhive/registry.h * PURPOSE: Registry code @@ -34,23 +35,26 @@ #define ERROR_SUCCESS 0L #define ERROR_UNSUCCESSFUL 1L +#define ERROR_FILE_NOT_FOUND 2L #define ERROR_OUTOFMEMORY 14L #define ERROR_INVALID_PARAMETER 87L #define ERROR_MORE_DATA 234L #define ERROR_NO_MORE_ITEMS 259L -#define REG_NONE 0 -#define REG_SZ 1 -#define REG_EXPAND_SZ 2 -#define REG_BINARY 3 -#define REG_DWORD 4 -#define REG_DWORD_BIG_ENDIAN 5 -#define REG_DWORD_LITTLE_ENDIAN 4 -#define REG_LINK 6 -#define REG_MULTI_SZ 7 -#define REG_RESOURCE_LIST 8 -#define REG_FULL_RESOURCE_DESCRIPTOR 9 -#define REG_RESOURCE_REQUIREMENTS_LIST 10 +#define REG_NONE 0 +#define REG_SZ 1 +#define REG_EXPAND_SZ 2 +#define REG_BINARY 3 +#define REG_DWORD 4 +#define REG_DWORD_LITTLE_ENDIAN 4 +#define REG_DWORD_BIG_ENDIAN 5 +#define REG_LINK 6 +#define REG_MULTI_SZ 7 +#define REG_RESOURCE_LIST 8 +#define REG_FULL_RESOURCE_DESCRIPTOR 9 +#define REG_RESOURCE_REQUIREMENTS_LIST 10 +#define REG_QWORD 11 +#define REG_QWORD_LITTLE_ENDIAN 11 VOID RegInitializeRegistry(VOID);

1 0

[ekohl] 70600: [MMC] - Prepare the 'file open', 'file save' and 'file save as' actions. - Store the file name in the console struncture.
by ekohl＠svn.reactos.org 16 Jan '16

16 Jan '16

Author: ekohl Date: Sat Jan 16 15:17:12 2016 New Revision: 70600 URL: http://svn.reactos.org/svn/reactos?rev=70600&view=rev Log: [MMC] - Prepare the 'file open', 'file save' and 'file save as' actions. - Store the file name in the console struncture. Modified: trunk/reactos/base/applications/mmc/CMakeLists.txt trunk/reactos/base/applications/mmc/console.c trunk/reactos/base/applications/mmc/lang/bg-BG.rc trunk/reactos/base/applications/mmc/lang/ca-ES.rc trunk/reactos/base/applications/mmc/lang/cs-CZ.rc trunk/reactos/base/applications/mmc/lang/de-DE.rc trunk/reactos/base/applications/mmc/lang/el-GR.rc trunk/reactos/base/applications/mmc/lang/en-US.rc trunk/reactos/base/applications/mmc/lang/es-ES.rc trunk/reactos/base/applications/mmc/lang/fr-FR.rc trunk/reactos/base/applications/mmc/lang/he-IL.rc trunk/reactos/base/applications/mmc/lang/it-IT.rc trunk/reactos/base/applications/mmc/lang/ko-KR.rc trunk/reactos/base/applications/mmc/lang/lt-LT.rc trunk/reactos/base/applications/mmc/lang/ms-MY.rc trunk/reactos/base/applications/mmc/lang/no-NO.rc trunk/reactos/base/applications/mmc/lang/pl-PL.rc trunk/reactos/base/applications/mmc/lang/pt-BR.rc trunk/reactos/base/applications/mmc/lang/ro-RO.rc trunk/reactos/base/applications/mmc/lang/ru-RU.rc trunk/reactos/base/applications/mmc/lang/sk-SK.rc trunk/reactos/base/applications/mmc/lang/sq-AL.rc trunk/reactos/base/applications/mmc/lang/sv-SE.rc trunk/reactos/base/applications/mmc/lang/tr-TR.rc trunk/reactos/base/applications/mmc/lang/uk-UA.rc trunk/reactos/base/applications/mmc/lang/zh-CN.rc trunk/reactos/base/applications/mmc/lang/zh-TW.rc trunk/reactos/base/applications/mmc/mmc.c trunk/reactos/base/applications/mmc/precomp.h trunk/reactos/base/applications/mmc/resource.h Modified: trunk/reactos/base/applications/mmc/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/CMak… ============================================================================== --- trunk/reactos/base/applications/mmc/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/CMakeLists.txt [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -6,7 +6,8 @@ precomp.h) add_rc_deps(mmc.rc ${CMAKE_CURRENT_SOURCE_DIR}/resources/mmc.ico) -add_executable(mmcclient ${SOURCE} mmc.rc) -set_module_type(mmcclient win32gui UNICODE) -add_importlibs(mmcclient user32 gdi32 comdlg32 advapi32 shell32 comctl32 msvcrt kernel32) -add_pch(mmcclient precomp.h SOURCE) +add_executable(mmc ${SOURCE} mmc.rc) +set_module_type(mmc win32gui UNICODE) +add_importlibs(mmc user32 gdi32 comdlg32 advapi32 shell32 comctl32 msvcrt kernel32 ntdll) +add_pch(mmc precomp.h SOURCE) +add_cd_file(TARGET mmc DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/base/applications/mmc/console.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/cons… ============================================================================== --- trunk/reactos/base/applications/mmc/console.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/console.c [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -21,34 +21,14 @@ #include "resource.h" -static const TCHAR szMMCMainFrame[] = TEXT("MMCMainFrame"); -static const TCHAR szMMCChildFrm[] = TEXT("MMCChildFrm"); - -static ULONG NewConsoleCount = 0; - -static LPTSTR -CreateNewConsoleTitle(VOID) -{ - LPTSTR lpTitle; - - if (LoadAndFormatString(hAppInstance, - IDS_CONSOLETITLE, - &lpTitle, - ++NewConsoleCount) == 0) - { - lpTitle = NULL; - } - - return lpTitle; -} - +#define NDEBUG +#include <debug.h> typedef struct _CONSOLE_MAINFRAME_WND { HWND hwnd; HWND hwndMDIClient; - LPCTSTR lpConsoleTitle; HMENU hMenuConsoleSmall; HMENU hMenuConsoleLarge; INT nConsoleCount; @@ -62,6 +42,46 @@ }; } CONSOLE_MAINFRAME_WND, *PCONSOLE_MAINFRAME_WND; +typedef struct _CONSOLE_CHILDFRM_WND +{ + HWND hwnd; + PCONSOLE_MAINFRAME_WND MainFrame; + PTSTR pFileName; +} CONSOLE_CHILDFRM_WND, *PCONSOLE_CHILDFRM_WND; + +static const TCHAR szMMCMainFrame[] = TEXT("MMCMainFrame"); +static const TCHAR szMMCChildFrm[] = TEXT("MMCChildFrm"); + +static ULONG NewConsoleCount = 0; + +PCONSOLE_CHILDFRM_WND +GetActiveChildInfo(VOID) +{ + HWND hWndMDIChild; + + hWndMDIChild = (HWND)SendMessageW(hwndMDIClient, WM_MDIGETACTIVE, 0, 0); + if (hWndMDIChild == NULL) + return NULL; + + return (PCONSOLE_CHILDFRM_WND)GetWindowLongPtr(hWndMDIChild, 0); +} + + +static LPTSTR +CreateNewConsoleTitle(VOID) +{ + LPTSTR lpTitle; + + if (LoadAndFormatString(hAppInstance, + IDS_CONSOLETITLE, + &lpTitle, + ++NewConsoleCount) == 0) + { + lpTitle = NULL; + } + + return lpTitle; +} HWND CreateNewMDIChild(PCONSOLE_MAINFRAME_WND Info, @@ -96,14 +116,11 @@ LPCTSTR lpFileName = (LPCTSTR)(((LPCREATESTRUCT)lParam)->lpCreateParams); Info = HeapAlloc(hAppHeap, - 0, + HEAP_ZERO_MEMORY, sizeof(CONSOLE_MAINFRAME_WND)); if (Info == NULL) return -1; - ZeroMemory(Info, - sizeof(CONSOLE_MAINFRAME_WND)); - Info->hwnd = hwnd; SetWindowLongPtr(hwnd, @@ -120,19 +137,18 @@ { /* FIXME */ Info->AppAuthorMode = TRUE; - Info->lpConsoleTitle = TEXT("ReactOS Management Console"); +// Info->lpConsoleTitle = TEXT("ReactOS Management Console"); } else { Info->AppAuthorMode = TRUE; - Info->lpConsoleTitle = CreateNewConsoleTitle(); +// Info->lpConsoleTitle = CreateNewConsoleTitle(); } SetMenu(Info->hwnd, Info->hMenuConsoleSmall); - SetWindowText(Info->hwnd, - Info->lpConsoleTitle); + SetWindowText(Info->hwnd, TEXT("ReactOS Management Console")); ccs.hWindowMenu = GetSubMenu(Info->hMenuConsoleLarge, 1); ccs.idFirstChild = IDM_MDI_FIRSTCHILD; @@ -158,6 +174,134 @@ static VOID +SetFileName( + PCONSOLE_CHILDFRM_WND Info, + PWSTR pFileName) +{ + DPRINT1("SetFileName(&p \'%S\')\n", Info, pFileName); + + if (Info->pFileName != NULL) + { + HeapFree(GetProcessHeap(), 0, Info->pFileName); + Info->pFileName = NULL; + } + + if (pFileName != NULL) + { + Info->pFileName = HeapAlloc(GetProcessHeap(), + 0, + (_tcslen(pFileName) + 1) * sizeof(TCHAR)); + if (Info->pFileName != NULL) + _tcscpy(Info->pFileName, pFileName); + } +} + +static BOOL +DoSaveFileAs( + HWND hWnd, + PCONSOLE_CHILDFRM_WND pChildInfo); + +static BOOL +DoSaveFile( + HWND hWnd, + PCONSOLE_CHILDFRM_WND pChildInfo) +{ + DPRINT1("pChildInfo %p\n", pChildInfo); + + DPRINT1("FileName %S\n", pChildInfo->pFileName); + + if (pChildInfo->pFileName == NULL) + return DoSaveFileAs(hWnd, pChildInfo); + + /* FIXME: Save the console here! */ + + return TRUE; +} + +static BOOL +DoSaveFileAs( + HWND hWnd, + PCONSOLE_CHILDFRM_WND pChildInfo) +{ + OPENFILENAME saveas; + TCHAR szPath[MAX_PATH]; + + DPRINT1("pChildInfo %p\n", pChildInfo); + DPRINT1("FileName %S\n", pChildInfo->pFileName); + + ZeroMemory(&saveas, sizeof(saveas)); + + if (pChildInfo->pFileName != NULL) + { + _tcscpy(szPath, pChildInfo->pFileName); + } + else + { + GetWindowText(pChildInfo->hwnd, szPath, MAX_PATH); + _tcscat(szPath, TEXT(".msc")); + } + + saveas.lStructSize = sizeof(OPENFILENAME); + saveas.hwndOwner = hWnd; + saveas.hInstance = hAppInstance; + saveas.lpstrFilter = L"MSC Files\0*.msc\0"; + saveas.lpstrFile = szPath; + saveas.nMaxFile = MAX_PATH; + saveas.Flags = OFN_HIDEREADONLY | OFN_PATHMUSTEXIST | OFN_OVERWRITEPROMPT; + saveas.lpstrDefExt = L"msc"; + + if (GetSaveFileName(&saveas)) + { + /* HACK: Because in ROS, Save-As boxes don't check the validity + * of file names and thus, here, szPath can be invalid !! We only + * see its validity when we call DoSaveFile()... */ + SetFileName(pChildInfo, szPath); + + if (DoSaveFile(hWnd, pChildInfo)) + { +// UpdateWindowCaption(); + return TRUE; + } + else + { + SetFileName(pChildInfo, NULL); + return FALSE; + } + } + else + { + return FALSE; + } +} + +static BOOL +FrameOnSave( + HWND hWnd) +{ + PCONSOLE_CHILDFRM_WND pChildInfo; + + pChildInfo = GetActiveChildInfo(); + if (pChildInfo == NULL) + return FALSE; + + return DoSaveFile(hWnd, pChildInfo); +} + + +static BOOL +FrameOnSaveAs( + HWND hWnd) +{ + PCONSOLE_CHILDFRM_WND pChildInfo; + + pChildInfo = GetActiveChildInfo(); + if (pChildInfo == NULL) + return FALSE; + + return DoSaveFileAs(hWnd, pChildInfo); +} + +static VOID FrameOnCommand(HWND hwnd, UINT uMsg, WPARAM wParam, @@ -174,6 +318,14 @@ CreateNewMDIChild(Info, hwndMDIClient); SetMenu(Info->hwnd, Info->hMenuConsoleLarge); + break; + + case IDM_FILE_SAVE: + FrameOnSave(hwnd); + break; + + case IDM_FILE_SAVEAS: + FrameOnSaveAs(hwnd); break; case IDM_FILE_EXIT: @@ -310,12 +462,6 @@ } -typedef struct _CONSOLE_CHILDFRM_WND -{ - HWND hwnd; - PCONSOLE_MAINFRAME_WND MainFrame; -} CONSOLE_CHILDFRM_WND, *PCONSOLE_CHILDFRM_WND; - static LRESULT CALLBACK ConsoleChildFrmProc(IN HWND hwnd, IN UINT uMsg, @@ -331,13 +477,10 @@ { case WM_CREATE: Info = HeapAlloc(hAppHeap, - 0, + HEAP_ZERO_MEMORY, sizeof(CONSOLE_CHILDFRM_WND)); if (Info != NULL) { - ZeroMemory(Info, - sizeof(CONSOLE_CHILDFRM_WND)); - Info->hwnd = hwnd; SetWindowLongPtr(hwnd, @@ -348,7 +491,12 @@ case WM_DESTROY: if (Info != NULL) - HeapFree(hAppHeap, 0, Info); + { + if (Info->pFileName) + HeapFree(hAppHeap, 0, Info->pFileName); + + HeapFree(hAppHeap, 0, Info); + } PostMessage(hwndMainConsole, WM_USER_CLOSE_CHILD, 0, 0); break; Modified: trunk/reactos/base/applications/mmc/lang/bg-BG.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/bg-BG.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/bg-BG.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -5,6 +5,7 @@ POPUP "&Ð¤Ð°Ð¹Ð»" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "ÐÐ·&ÑÐ¾Ð´\tAlt+F4", IDM_FILE_EXIT END @@ -19,6 +20,9 @@ POPUP "&Ð¤Ð°Ð¹Ð»" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "ÐÐ·&ÑÐ¾Ð´\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/ca-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/ca-ES.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/ca-ES.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -5,6 +5,7 @@ POPUP "&Fitxer" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "&Sortida\tAlt+F4", IDM_FILE_EXIT END @@ -19,6 +20,9 @@ POPUP "&Fitxer" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "&Sortida\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/cs-CZ.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/cs-CZ.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/cs-CZ.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -10,6 +10,7 @@ POPUP "&Soubor" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "Uk&onÄit\tAlt+F4", IDM_FILE_EXIT END @@ -24,6 +25,9 @@ POPUP "&Soubor" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "Uk&onÄit\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/de-DE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/de-DE.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -5,6 +5,7 @@ POPUP "&Datei" BEGIN MENUITEM "Neu\tStrg+N", IDM_FILE_NEW + MENUITEM "Ãffnen\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "B&eenden\tAlt+F4", IDM_FILE_EXIT END @@ -19,6 +20,9 @@ POPUP "&Datei" BEGIN MENUITEM "Neu\tStrg+N", IDM_FILE_NEW + MENUITEM "Ãffnen\tStrg+O", IDM_FILE_OPEN + MENUITEM "Speichern", IDM_FILE_SAVE + MENUITEM "Speichern unter...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "B&eenden\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/el-GR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/el-GR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/el-GR.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -5,6 +5,7 @@ POPUP "&ÎÏÏÎµÎ¯Î¿" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "Î&Î¾Î¿Î´Î¿Ï\tAlt+F4", IDM_FILE_EXIT END @@ -19,6 +20,9 @@ POPUP "&ÎÏÏÎµÎ¯Î¿" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "Î&Î¾Î¿Î´Î¿Ï\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/en-US.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/en-US.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/en-US.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -5,6 +5,7 @@ POPUP "&File" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "E&xit\tAlt+F4", IDM_FILE_EXIT END @@ -19,6 +20,9 @@ POPUP "&File" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "E&xit\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/es-ES.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/es-ES.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/es-ES.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -11,6 +11,7 @@ POPUP "&Archivo" BEGIN MENUITEM "Nuevo\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "Sa&lir\tAlt+F4", IDM_FILE_EXIT END @@ -25,6 +26,9 @@ POPUP "&Archivo" BEGIN MENUITEM "Nuevo\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "Sa&lir\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/fr-FR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/fr-FR.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -5,6 +5,7 @@ POPUP "&Fichier" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "Quitter\tAlt+F4", IDM_FILE_EXIT END @@ -19,6 +20,9 @@ POPUP "&Fichier" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "Quitter\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/he-IL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/he-IL.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/he-IL.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -5,6 +5,7 @@ POPUP "&×§×××¥" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "&××¦×××\tAlt+F4", IDM_FILE_EXIT END @@ -19,6 +20,9 @@ POPUP "&×§×××¥" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "&××¦×××\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/it-IT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/it-IT.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/it-IT.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -5,6 +5,7 @@ POPUP "&File" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "E&sci\tAlt+F4", IDM_FILE_EXIT END @@ -19,6 +20,9 @@ POPUP "&File" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "E&sci\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/ko-KR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/ko-KR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/ko-KR.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -7,6 +7,7 @@ POPUP "íì¼(&F)" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "ì¢ë£(&E)\tAlt+F4", IDM_FILE_EXIT END @@ -21,6 +22,9 @@ POPUP "íì¼(&F)" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "ì¢ë£(&E)\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/lt-LT.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/lt-LT.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/lt-LT.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -7,6 +7,7 @@ POPUP "&Byla" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "&Baigti\tAlt+F4", IDM_FILE_EXIT END @@ -21,6 +22,9 @@ POPUP "&Byla" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "&Baigti\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/ms-MY.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/ms-MY.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/ms-MY.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -7,6 +7,7 @@ POPUP "&Fail" BEGIN MENUITEM "Baru\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "Keluar(&X)\tAlt+F4", IDM_FILE_EXIT END @@ -21,6 +22,9 @@ POPUP "&Fail" BEGIN MENUITEM "Baru\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "Keluar(&X)\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/no-NO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/no-NO.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/no-NO.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -5,6 +5,7 @@ POPUP "&Fil" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "&Avslutt\tAlt+F4", IDM_FILE_EXIT END @@ -19,6 +20,9 @@ POPUP "&Fil" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "&Avslutt\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/pl-PL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/pl-PL.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/pl-PL.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -12,6 +12,7 @@ POPUP "Pl&ik" BEGIN MENUITEM "Nowa\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "Za&koÅcz\tAlt+F4", IDM_FILE_EXIT END @@ -26,6 +27,9 @@ POPUP "Pl&ik" BEGIN MENUITEM "Nowa\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "Za&koÅcz\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/pt-BR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/pt-BR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/pt-BR.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -5,6 +5,7 @@ POPUP "&Arquivo" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "Sai&r\tAlt+F4", IDM_FILE_EXIT END @@ -19,6 +20,9 @@ POPUP "&Arquivo" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "Sai&r\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/ro-RO.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/ro-RO.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -11,6 +11,7 @@ POPUP "&FiÈier" BEGIN MENUITEM "&Nou\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "I&eÈire\tAlt+F4", IDM_FILE_EXIT END @@ -25,6 +26,9 @@ POPUP "&FiÈier" BEGIN MENUITEM "&Nou\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "I&eÈire\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/ru-RU.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/ru-RU.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/ru-RU.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -7,6 +7,7 @@ POPUP "&Ð¤Ð°Ð¹Ð»" BEGIN MENUITEM "&Ð¡Ð¾Ð·Ð´Ð°ÑÑ\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "&ÐÑÑÐ¾Ð´\tAlt+F4", IDM_FILE_EXIT END @@ -21,6 +22,9 @@ POPUP "&Ð¤Ð°Ð¹Ð»" BEGIN MENUITEM "&Ð¡Ð¾Ð·Ð´Ð°ÑÑ\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "&ÐÑÑÐ¾Ð´\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/sk-SK.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/sk-SK.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/sk-SK.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -13,6 +13,7 @@ POPUP "&SÃºbor" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "&SkonÄiÅ¥\tAlt+F4", IDM_FILE_EXIT END @@ -27,6 +28,9 @@ POPUP "&SÃºbor" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "&SkonÄiÅ¥\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/sq-AL.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/sq-AL.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/sq-AL.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -9,6 +9,7 @@ POPUP "&File" BEGIN MENUITEM "I Ri\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "D&il\tAlt+F4", IDM_FILE_EXIT END @@ -23,6 +24,9 @@ POPUP "&File" BEGIN MENUITEM "I Ri\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "D&il\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/sv-SE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/sv-SE.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/sv-SE.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -7,6 +7,7 @@ POPUP "&Arkiv" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "&Avsluta\tAlt+F4", IDM_FILE_EXIT END @@ -21,6 +22,9 @@ POPUP "&Arkiv" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "&Avsluta\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/tr-TR.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/tr-TR.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/tr-TR.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -7,6 +7,7 @@ POPUP "&KÃ¼tÃ¼k" BEGIN MENUITEM "&Yeni\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "&ÃÄ±kÄ±Å\tAlt+F4", IDM_FILE_EXIT END @@ -21,6 +22,9 @@ POPUP "&KÃ¼tÃ¼k" BEGIN MENUITEM "&Yeni\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "&ÃÄ±kÄ±Å\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/uk-UA.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/uk-UA.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -13,6 +13,7 @@ POPUP "&Ð¤Ð°Ð¹Ð»" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "Ð&Ð¸ÑÑÐ´\tAlt+F4", IDM_FILE_EXIT END @@ -27,6 +28,9 @@ POPUP "&Ð¤Ð°Ð¹Ð»" BEGIN MENUITEM "New\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "Ð&Ð¸ÑÑÐ´\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/zh-CN.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/zh-CN.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/zh-CN.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -13,6 +13,7 @@ POPUP "æ¡£æ¡(&F)" BEGIN MENUITEM "æ°å»º\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "ç»æ(&X)\tAlt+F4", IDM_FILE_EXIT END @@ -27,6 +28,9 @@ POPUP "æ¡£æ¡(&F)" BEGIN MENUITEM "æ°å»º\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "ç»æ(&X)\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/lang/zh-TW.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/lang… ============================================================================== --- trunk/reactos/base/applications/mmc/lang/zh-TW.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/lang/zh-TW.rc [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -13,6 +13,7 @@ POPUP "æªæ¡(&F)" BEGIN MENUITEM "æ°å»º\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN MENUITEM SEPARATOR MENUITEM "çµæ(&X)\tAlt+F4", IDM_FILE_EXIT END @@ -27,6 +28,9 @@ POPUP "æªæ¡(&F)" BEGIN MENUITEM "æ°å»º\tCtrl+N", IDM_FILE_NEW + MENUITEM "Open\tStrg+O", IDM_FILE_OPEN + MENUITEM "Save", IDM_FILE_SAVE + MENUITEM "Save as...", IDM_FILE_SAVEAS MENUITEM SEPARATOR MENUITEM "çµæ(&X)\tAlt+F4", IDM_FILE_EXIT END Modified: trunk/reactos/base/applications/mmc/mmc.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/mmc.… ============================================================================== --- trunk/reactos/base/applications/mmc/mmc.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/mmc.c [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -19,8 +19,6 @@ #include "precomp.h" -#include <tchar.h> -#include <commctrl.h> HINSTANCE hAppInstance; HANDLE hAppHeap; Modified: trunk/reactos/base/applications/mmc/precomp.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/prec… ============================================================================== --- trunk/reactos/base/applications/mmc/precomp.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/precomp.h [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -5,7 +5,11 @@ #include <windef.h> #include <winbase.h> +#include <wingdi.h> #include <winuser.h> +#include <commctrl.h> +#include <commdlg.h> +#include <tchar.h> #define WM_USER_CLOSE_CHILD (WM_USER + 1) Modified: trunk/reactos/base/applications/mmc/resource.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mmc/reso… ============================================================================== --- trunk/reactos/base/applications/mmc/resource.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/mmc/resource.h [iso-8859-1] Sat Jan 16 15:17:12 2016 @@ -10,6 +10,8 @@ #define IDM_FILE_NEW 1002 #define IDM_FILE_OPEN 1003 +#define IDM_FILE_SAVE 1004 +#define IDM_FILE_SAVEAS 1005 #define IDM_FILE_EXIT 1010 #define IDM_WINDOWS_LIST 2001 #define IDM_HELP_ABOUT 9001

1 0

← Newer
1
...
4
5
6
7
8
9
10
...
20
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs January 2016