Ros-diffs August 2016

ros-diffs@reactos.org

20 participants
462 discussions

[vmikayelyan] 72378: usb: libusb: hub_controller: Fix PnP handler In some cases our driver was changing IRP status in places where it shouldn't.
by vmikayelyan＠svn.reactos.org 19 Aug '16

19 Aug '16

Author: vmikayelyan Date: Fri Aug 19 16:20:32 2016 New Revision: 72378 URL: http://svn.reactos.org/svn/reactos?rev=72378&view=rev Log: usb: libusb: hub_controller: Fix PnP handler In some cases our driver was changing IRP status in places where it shouldn't. Modified: branches/GSoC_2016/USB/sdk/lib/drivers/libusb/hub_controller.cpp Modified: branches/GSoC_2016/USB/sdk/lib/drivers/libusb/hub_controller.cpp URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/USB/sdk/lib/drivers/l… ============================================================================== --- branches/GSoC_2016/USB/sdk/lib/drivers/libusb/hub_controller.cpp [iso-8859-1] (original) +++ branches/GSoC_2016/USB/sdk/lib/drivers/libusb/hub_controller.cpp [iso-8859-1] Fri Aug 19 16:20:32 2016 @@ -568,7 +568,8 @@ break; } } - Status = STATUS_SUCCESS; + // Here we should leave Status as is. + Status = Irp->IoStatus.Status; break; } case IRP_MN_QUERY_CAPABILITIES: @@ -611,6 +612,14 @@ // handle device interface requests // Status = HandleQueryInterface(IoStack); + + // + // If a bus driver does not export the requested interface, it + // should leave Status as is. + // + if (Status == STATUS_NOT_SUPPORTED) + Status = Irp->IoStatus.Status; + break; } case IRP_MN_REMOVE_DEVICE:

1 0

[vmikayelyan] 72377: usb: hub: Fix in USBHUB_DispatchPower In case of FDO it should pass IRP down.
by vmikayelyan＠svn.reactos.org 19 Aug '16

19 Aug '16

Author: vmikayelyan Date: Fri Aug 19 16:18:59 2016 New Revision: 72377 URL: http://svn.reactos.org/svn/reactos?rev=72377&view=rev Log: usb: hub: Fix in USBHUB_DispatchPower In case of FDO it should pass IRP down. Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/usbhub.c Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/usbhub.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/USB/drivers/usb/usbhu… ============================================================================== --- branches/GSoC_2016/USB/drivers/usb/usbhub/usbhub.c [iso-8859-1] (original) +++ branches/GSoC_2016/USB/drivers/usb/usbhub/usbhub.c [iso-8859-1] Fri Aug 19 16:18:59 2016 @@ -188,9 +188,18 @@ PIRP Irp) { PIO_STACK_LOCATION IoStack; + PHUB_DEVICE_EXTENSION DeviceExtension; IoStack = IoGetCurrentIrpStackLocation(Irp); + DeviceExtension = DeviceObject->DeviceExtension; DPRINT1("Power Function %x\n", IoStack->MinorFunction); + + if (DeviceExtension->Common.IsFDO) + { + PoStartNextPowerIrp(Irp); + IoSkipCurrentIrpStackLocation(Irp); + return PoCallDriver(DeviceExtension->LowerDeviceObject, Irp); + } if (IoStack->MinorFunction == IRP_MN_SET_POWER) {

1 0

[vmikayelyan] 72376: usb: hub: PDO: Fix in IRP_MN_QUERY_DEVICE_RELATIONS handler I don't see the reason for allocation from NonPagedPool, also the information field writing was wrong.
by vmikayelyan＠svn.reactos.org 19 Aug '16

19 Aug '16

Author: vmikayelyan Date: Fri Aug 19 16:15:31 2016 New Revision: 72376 URL: http://svn.reactos.org/svn/reactos?rev=72376&view=rev Log: usb: hub: PDO: Fix in IRP_MN_QUERY_DEVICE_RELATIONS handler I don't see the reason for allocation from NonPagedPool, also the information field writing was wrong. Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/USB/drivers/usb/usbhu… ============================================================================== --- branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c [iso-8859-1] (original) +++ branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c [iso-8859-1] Fri Aug 19 16:15:31 2016 @@ -716,7 +716,7 @@ } /* allocate device relations */ - DeviceRelation = (PDEVICE_RELATIONS)ExAllocatePool(NonPagedPool, sizeof(DEVICE_RELATIONS)); + DeviceRelation = (PDEVICE_RELATIONS)ExAllocatePool(PagedPool, sizeof(DEVICE_RELATIONS)); if (!DeviceRelation) { /* no memory */ @@ -730,7 +730,7 @@ ObReferenceObject(DeviceRelation->Objects[0]); /* store result */ - Irp->IoStatus.Information = (ULONG_PTR)DeviceRelation; + Information = (ULONG_PTR)DeviceRelation; Status = STATUS_SUCCESS; break; }

1 0

[vmikayelyan] 72375: usb: hub: FDO: Fix PnP handling issues. There is many cases where we should forward IRP instead of complete it.
by vmikayelyan＠svn.reactos.org 19 Aug '16

19 Aug '16

Author: vmikayelyan Date: Fri Aug 19 16:13:09 2016 New Revision: 72375 URL: http://svn.reactos.org/svn/reactos?rev=72375&view=rev Log: usb: hub: FDO: Fix PnP handling issues. There is many cases where we should forward IRP instead of complete it. Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/USB/drivers/usb/usbhu… ============================================================================== --- branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c [iso-8859-1] (original) +++ branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c [iso-8859-1] Fri Aug 19 16:13:09 2016 @@ -2028,7 +2028,10 @@ { Status = USBHUB_ParentFDOStartDevice(DeviceObject, Irp); } - break; + + Irp->IoStatus.Status = Status; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return Status; } case IRP_MN_QUERY_DEVICE_RELATIONS: @@ -2059,17 +2062,17 @@ Irp->IoStatus.Information = (ULONG_PTR)DeviceRelations; Irp->IoStatus.Status = Status; - return ForwardIrpAndForget(DeviceObject, Irp); + break; } case RemovalRelations: { DPRINT("IRP_MJ_PNP / IRP_MN_QUERY_DEVICE_RELATIONS / RemovalRelations\n"); - return ForwardIrpAndForget(DeviceObject, Irp); + break; } default: DPRINT("IRP_MJ_PNP / IRP_MN_QUERY_DEVICE_RELATIONS / Unknown type 0x%lx\n", Stack->Parameters.QueryDeviceRelations.Type); - return ForwardIrpAndForget(DeviceObject, Irp); + break; } break; } @@ -2078,10 +2081,11 @@ { DPRINT("IRP_MN_QUERY_STOP_DEVICE\n"); Irp->IoStatus.Status = STATUS_SUCCESS; - return ForwardIrpAndForget(DeviceObject, Irp); + break; } case IRP_MN_REMOVE_DEVICE: { + // Should be reworked later in this commits set DPRINT("IRP_MN_REMOVE_DEVICE\n"); Irp->IoStatus.Status = STATUS_SUCCESS; IoCompleteRequest(Irp, IO_NO_INCREMENT); @@ -2093,29 +2097,33 @@ } case IRP_MN_QUERY_BUS_INFORMATION: { + // Function drivers and filter drivers do not handle this IRP. DPRINT("IRP_MN_QUERY_BUS_INFORMATION\n"); break; } case IRP_MN_QUERY_ID: { DPRINT("IRP_MN_QUERY_ID\n"); + // Function drivers and filter drivers do not handle this IRP. break; } case IRP_MN_QUERY_CAPABILITIES: { + // + // If a function or filter driver does not handle this IRP, it + // should pass that down. + // DPRINT("IRP_MN_QUERY_CAPABILITIES\n"); break; } default: { DPRINT(" IRP_MJ_PNP / unknown minor function 0x%lx\n", Stack->MinorFunction); - return ForwardIrpAndForget(DeviceObject, Irp); - } - } - - Irp->IoStatus.Status = Status; - IoCompleteRequest(Irp, IO_NO_INCREMENT); - return Status; + break; + } + } + + return ForwardIrpAndForget(DeviceObject, Irp); } NTSTATUS

1 0

[vmikayelyan] 72374: usb: hub: FDO: Fix QueryInterface() The status block of an IRP must be initialized before calling driver.
by vmikayelyan＠svn.reactos.org 19 Aug '16

19 Aug '16

Author: vmikayelyan Date: Fri Aug 19 16:08:48 2016 New Revision: 72374 URL: http://svn.reactos.org/svn/reactos?rev=72374&view=rev Log: usb: hub: FDO: Fix QueryInterface() The status block of an IRP must be initialized before calling driver. Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/USB/drivers/usb/usbhu… ============================================================================== --- branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c [iso-8859-1] (original) +++ branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c [iso-8859-1] Fri Aug 19 16:08:48 2016 @@ -568,6 +568,11 @@ Stack->Parameters.QueryInterface.Version = Version; Stack->Parameters.QueryInterface.Interface = Interface; Stack->Parameters.QueryInterface.InterfaceSpecificData = NULL; + + // + // Initialize the status block before sending the IRP + // + Irp->IoStatus.Status = STATUS_NOT_SUPPORTED; Status = IoCallDriver(DeviceObject, Irp);

1 0

[vmikayelyan] 72373: usb: hub: PDO: Fix in IRP_MN_QUERY_DEVICE_RELATIONS Here we shouldn't modify information field of IRP, because for example in case of bus relations IRP must reach the stack's P...
by vmikayelyan＠svn.reactos.org 19 Aug '16

19 Aug '16

Author: vmikayelyan Date: Fri Aug 19 15:50:18 2016 New Revision: 72373 URL: http://svn.reactos.org/svn/reactos?rev=72373&view=rev Log: usb: hub: PDO: Fix in IRP_MN_QUERY_DEVICE_RELATIONS Here we shouldn't modify information field of IRP, because for example in case of bus relations IRP must reach the stack's PDO collecting on its way all relations. This was the one of the causes of MS's usbccgp fail. usbccgp was not able to report to PnP manager about it's child devices. There is also another issues in usbuhci, which prevents usbccgp from normal operation. [THIS PATCH SHULD NOT BE MERGED WITH TRUNK UNTIL UHCI BUGS ARE NOT FIXED] Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/USB/drivers/usb/usbhu… ============================================================================== --- branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c [iso-8859-1] (original) +++ branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c [iso-8859-1] Fri Aug 19 15:50:18 2016 @@ -711,6 +711,7 @@ { /* not supported */ Status = Irp->IoStatus.Status; + Information = Irp->IoStatus.Information; break; }

1 0

[vmikayelyan] 72372: usb: hub: FDO: Rework IRP_MN_QUERY_DEVICE_RELATIONS First of all we should keep in account that there might be device relations below and above this FDO, so we should save prev...
by vmikayelyan＠svn.reactos.org 19 Aug '16

19 Aug '16

Author: vmikayelyan Date: Fri Aug 19 15:47:45 2016 New Revision: 72372 URL: http://svn.reactos.org/svn/reactos?rev=72372&view=rev Log: usb: hub: FDO: Rework IRP_MN_QUERY_DEVICE_RELATIONS First of all we should keep in account that there might be device relations below and above this FDO, so we should save previous relations coming from top object and shuld pass this IRP down to stack after adding our relations. In case of success query devcie relations must be completed in the PDO. As MSDN requires, if the upper layer provided this IRP with initialized DeviceRelation, then we should replace that relation with another one which will contain our child PDOs too. And after replacement we should free the recources allocated for previous relation structure. If there is relations coming from upper layer, we shuldn't complete this IRP with fail, because that will bring upper layer into unstabile state, it will 'think' that succesfully reported it's relations. Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/USB/drivers/usb/usbhu… ============================================================================== --- branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c [iso-8859-1] (original) +++ branches/GSoC_2016/USB/drivers/usb/usbhub/fdo.c [iso-8859-1] Fri Aug 19 15:47:45 2016 @@ -1387,11 +1387,13 @@ NTSTATUS USBHUB_FdoQueryBusRelations( IN PDEVICE_OBJECT DeviceObject, + IN PDEVICE_RELATIONS RelationsFromTop, OUT PDEVICE_RELATIONS* pDeviceRelations) { PHUB_DEVICE_EXTENSION HubDeviceExtension; PDEVICE_RELATIONS DeviceRelations; ULONG i; + ULONG ChildrenFromTop = 0; ULONG Children = 0; ULONG NeededSize; @@ -1410,9 +1412,18 @@ Children++; } - NeededSize = sizeof(DEVICE_RELATIONS); - if (Children > 1) - NeededSize += (Children - 1) * sizeof(PDEVICE_OBJECT); + if (RelationsFromTop) + { + ChildrenFromTop = RelationsFromTop->Count; + if (!Children) + { + // We have nothing to add + *pDeviceRelations = RelationsFromTop; + return STATUS_SUCCESS; + } + } + + NeededSize = sizeof(DEVICE_RELATIONS) + (Children + ChildrenFromTop - 1) * sizeof(PDEVICE_OBJECT); // // Allocate DeviceRelations @@ -1421,9 +1432,21 @@ NeededSize); if (!DeviceRelations) - return STATUS_INSUFFICIENT_RESOURCES; - DeviceRelations->Count = Children; - Children = 0; + { + if (!RelationsFromTop) + return STATUS_INSUFFICIENT_RESOURCES; + else + return STATUS_NOT_SUPPORTED; + } + // Copy the objects coming from top + if (ChildrenFromTop) + { + RtlCopyMemory(DeviceRelations->Objects, RelationsFromTop->Objects, + ChildrenFromTop * sizeof(PDEVICE_OBJECT)); + } + + DeviceRelations->Count = Children + ChildrenFromTop; + Children = ChildrenFromTop; // // Fill in return structure @@ -1438,6 +1461,10 @@ DeviceRelations->Objects[Children++] = HubDeviceExtension->ChildDeviceObject[i]; } } + + // We should do this, because replaced this with our's one + if (RelationsFromTop) + ExFreePool(RelationsFromTop); ASSERT(Children == DeviceRelations->Count); *pDeviceRelations = DeviceRelations; @@ -1976,7 +2003,6 @@ { PIO_STACK_LOCATION Stack; NTSTATUS Status = STATUS_SUCCESS; - ULONG_PTR Information = 0; PHUB_DEVICE_EXTENSION HubDeviceExtension; HubDeviceExtension = (PHUB_DEVICE_EXTENSION) DeviceObject->DeviceExtension; @@ -2007,12 +2033,28 @@ case BusRelations: { PDEVICE_RELATIONS DeviceRelations = NULL; + PDEVICE_RELATIONS RelationsFromTop = (PDEVICE_RELATIONS)Irp->IoStatus.Information; DPRINT("IRP_MJ_PNP / IRP_MN_QUERY_DEVICE_RELATIONS / BusRelations\n"); - Status = USBHUB_FdoQueryBusRelations(DeviceObject, &DeviceRelations); - - Information = (ULONG_PTR)DeviceRelations; - break; + Status = USBHUB_FdoQueryBusRelations(DeviceObject, RelationsFromTop, &DeviceRelations); + + if (!NT_SUCCESS(Status)) + { + if (Status == STATUS_NOT_SUPPORTED) + { + // We should process this to not lose relations from top. + Irp->IoStatus.Status = STATUS_SUCCESS; + break; + } + // We should fail an IRP + Irp->IoStatus.Status = Status; + IoCompleteRequest(Irp, IO_NO_INCREMENT); + return Status; + } + + Irp->IoStatus.Information = (ULONG_PTR)DeviceRelations; + Irp->IoStatus.Status = Status; + return ForwardIrpAndForget(DeviceObject, Irp); } case RemovalRelations: { @@ -2066,7 +2108,6 @@ } } - Irp->IoStatus.Information = Information; Irp->IoStatus.Status = Status; IoCompleteRequest(Irp, IO_NO_INCREMENT); return Status;

1 0

[vmikayelyan] 72371: usb: hub: PDO: Changed handling of IRP_MN_REMOVE_DEVICE On this IRP we should free recources and delete child's PDO ONLY if it isn't presented physically on the bus. If it is p...
by vmikayelyan＠svn.reactos.org 19 Aug '16

19 Aug '16

Author: vmikayelyan Date: Fri Aug 19 15:43:43 2016 New Revision: 72371 URL: http://svn.reactos.org/svn/reactos?rev=72371&view=rev Log: usb: hub: PDO: Changed handling of IRP_MN_REMOVE_DEVICE On this IRP we should free recources and delete child's PDO ONLY if it isn't presented physically on the bus. If it is presented we're leaving as it was, thinking that devices on top of it already frees otained from it resources. If child PDO is presented physically, then should be already marked as remove_pending when it will receive this IRP. Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/USB/drivers/usb/usbhu… ============================================================================== --- branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c [iso-8859-1] (original) +++ branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c [iso-8859-1] Fri Aug 19 15:43:43 2016 @@ -570,10 +570,7 @@ PIO_STACK_LOCATION Stack; ULONG_PTR Information = 0; PHUB_CHILDDEVICE_EXTENSION UsbChildExtension; - ULONG Index; - ULONG bFound; PDEVICE_RELATIONS DeviceRelation; - PDEVICE_OBJECT ParentDevice; UsbChildExtension = (PHUB_CHILDDEVICE_EXTENSION)DeviceObject->DeviceExtension; Stack = IoGetCurrentIrpStackLocation(Irp); @@ -664,41 +661,46 @@ { PHUB_DEVICE_EXTENSION HubDeviceExtension = (PHUB_DEVICE_EXTENSION)UsbChildExtension->ParentDeviceObject->DeviceExtension; PUSB_BUS_INTERFACE_HUB_V5 HubInterface = &HubDeviceExtension->HubInterface; - ParentDevice = UsbChildExtension->ParentDeviceObject; DPRINT("IRP_MJ_PNP / IRP_MN_REMOVE_DEVICE\n"); - /* remove us from pdo list */ - bFound = FALSE; - for(Index = 0; Index < USB_MAXCHILDREN; Index++) - { - if (HubDeviceExtension->ChildDeviceObject[Index] == DeviceObject) + if (!IsValidPDO(DeviceObject)) + { + // Parent or child device was surprise removed, freeing resources allocated for child device. + + // Remove the usb device + if (UsbChildExtension->UsbDeviceHandle) { - /* Remove the device */ - Status = HubInterface->RemoveUsbDevice(HubDeviceExtension->UsbDInterface.BusContext, UsbChildExtension->UsbDeviceHandle, 0); - - /* FIXME handle error */ - ASSERT(Status == STATUS_SUCCESS); - - /* remove us */ - HubDeviceExtension->ChildDeviceObject[Index] = NULL; - bFound = TRUE; - break; + Status = HubInterface->RemoveUsbDevice(HubInterface->BusContext, UsbChildExtension->UsbDeviceHandle, 0); + ASSERT(Status == STATUS_SUCCESS); } - } + // Free full configuration descriptor + if (UsbChildExtension->FullConfigDesc) + ExFreePool(UsbChildExtension->FullConfigDesc); + + // Free ID buffers + if (UsbChildExtension->usCompatibleIds.Buffer) + ExFreePool(UsbChildExtension->usCompatibleIds.Buffer); + + if (UsbChildExtension->usDeviceId.Buffer) + ExFreePool(UsbChildExtension->usDeviceId.Buffer); + + if (UsbChildExtension->usHardwareIds.Buffer) + ExFreePool(UsbChildExtension->usHardwareIds.Buffer); + + if (UsbChildExtension->usInstanceId.Buffer) + ExFreePool(UsbChildExtension->usInstanceId.Buffer); + + // Delete child PDO + IoDeleteDevice(DeviceObject); + } + + // Device is physically presented, so we leave its PDO undeleted. + ASSERT(UsbChildExtension->IsRemovePending == TRUE); /* Complete the IRP */ Irp->IoStatus.Status = STATUS_SUCCESS; IoCompleteRequest(Irp, IO_NO_INCREMENT); - - /* delete device */ - IoDeleteDevice(DeviceObject); - - if (bFound) - { - /* invalidate device relations */ - IoInvalidateDeviceRelations(ParentDevice, BusRelations); - } return STATUS_SUCCESS; }

1 0

[vmikayelyan] 72370: usb: hub: PDO: Add debug prints into USBHUB_PdoHandlePnp NO-OP changes.
by vmikayelyan＠svn.reactos.org 19 Aug '16

19 Aug '16

Author: vmikayelyan Date: Fri Aug 19 15:41:30 2016 New Revision: 72370 URL: http://svn.reactos.org/svn/reactos?rev=72370&view=rev Log: usb: hub: PDO: Add debug prints into USBHUB_PdoHandlePnp NO-OP changes. Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/USB/drivers/usb/usbhu… ============================================================================== --- branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c [iso-8859-1] (original) +++ branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c [iso-8859-1] Fri Aug 19 15:41:30 2016 @@ -635,17 +635,20 @@ } case IRP_MN_QUERY_DEVICE_TEXT: { + DPRINT("IRP_MN_QUERY_DEVICE_TEXT\n"); Status = USBHUB_PdoQueryDeviceText(DeviceObject, Irp, &Information); break; } case IRP_MN_QUERY_ID: { + DPRINT("IRP_MN_QUERY_ID\n"); Status = USBHUB_PdoQueryId(DeviceObject, Irp, &Information); break; } case IRP_MN_QUERY_BUS_INFORMATION: { PPNP_BUS_INFORMATION BusInfo; + DPRINT("IRP_MN_QUERY_BUS_INFORMATION\n"); BusInfo = (PPNP_BUS_INFORMATION)ExAllocatePool(PagedPool, sizeof(PNP_BUS_INFORMATION)); RtlCopyMemory(&BusInfo->BusTypeGuid, &GUID_BUS_TYPE_USB,

1 0

[vmikayelyan] 72369: usb: hub: PDO: Fail IRP_MN_QUERY_STOP_DEVICE. We should fail this request, because we're not handling IRP_MN_STOP_DEVICE for now. On systems above win2000 we'll receive this IR...
by vmikayelyan＠svn.reactos.org 19 Aug '16

19 Aug '16

Author: vmikayelyan Date: Fri Aug 19 15:37:57 2016 New Revision: 72369 URL: http://svn.reactos.org/svn/reactos?rev=72369&view=rev Log: usb: hub: PDO: Fail IRP_MN_QUERY_STOP_DEVICE. We should fail this request, because we're not handling IRP_MN_STOP_DEVICE for now. On systems above win2000 we'll receive this IRP ONLY when the PnP manager rebalances resources. Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c Modified: branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/USB/drivers/usb/usbhu… ============================================================================== --- branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c [iso-8859-1] (original) +++ branches/GSoC_2016/USB/drivers/usb/usbhub/pdo.c [iso-8859-1] Fri Aug 19 15:37:57 2016 @@ -729,6 +729,14 @@ break; } case IRP_MN_QUERY_STOP_DEVICE: + { + // + // We should fail this request, because we're not handling IRP_MN_STOP_DEVICE for now. + // We'll receive this IRP ONLY when the PnP manager rebalances resources. + // + Status = STATUS_NOT_SUPPORTED; + break; + } case IRP_MN_QUERY_REMOVE_DEVICE: { // HERE SHOULD BE CHECKED INTERFACE COUNT PROVIED TO UPPER LAYER TO BE ZERO, AS WE ARE HANDLING

1 0

← Newer
1
...
13
14
15
16
17
18
19
...
47
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2016