Ros-diffs February 2017

ros-diffs@reactos.org

13 participants
353 discussions

[gadamopoulos] 73786: [WIN32KNT_APITEST]: Make a test for NtUserGetClassInfo more strict to test its exact return value.
by gadamopoulos＠svn.reactos.org 13 Feb '17

13 Feb '17

Author: gadamopoulos Date: Mon Feb 13 09:56:35 2017 New Revision: 73786 URL: http://svn.reactos.org/svn/reactos?rev=73786&view=rev Log: [WIN32KNT_APITEST]: Make a test for NtUserGetClassInfo more strict to test its exact return value. Modified: trunk/rostests/apitests/win32nt/ntuser/NtUserCreateWindowEx.c Modified: trunk/rostests/apitests/win32nt/ntuser/NtUserCreateWindowEx.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/win32nt/ntuser/N… ============================================================================== --- trunk/rostests/apitests/win32nt/ntuser/NtUserCreateWindowEx.c [iso-8859-1] (original) +++ trunk/rostests/apitests/win32nt/ntuser/NtUserCreateWindowEx.c [iso-8859-1] Mon Feb 13 09:56:35 2017 @@ -213,7 +213,7 @@ TEST(res.hIconSm == wclex.hIconSm); /* Get versioned class info */ - TEST(NtUserGetClassInfo(hinst, &ver_cls, &res, &pwstr, 0) != 0); + TEST(NtUserGetClassInfo(hinst, &ver_cls, &res, &pwstr, 0) == atom2); TEST(GetLastError() == 0); TEST(res.cbSize == wclex2.cbSize); TEST(res.style == wclex2.style);

1 0

[tfaber] 73785: [WIN32K:NTUSER] - Kill a noisy debug print
by tfaber＠svn.reactos.org 12 Feb '17

12 Feb '17

Author: tfaber Date: Sun Feb 12 23:09:35 2017 New Revision: 73785 URL: http://svn.reactos.org/svn/reactos?rev=73785&view=rev Log: [WIN32K:NTUSER] - Kill a noisy debug print Modified: trunk/reactos/win32ss/user/ntuser/window.c Modified: trunk/reactos/win32ss/user/ntuser/window.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/window… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/window.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/window.c [iso-8859-1] Sun Feb 12 23:09:35 2017 @@ -3021,7 +3021,7 @@ } else { - ERR("FindWindowEx: Not Desktop Parent!\n"); + TRACE("FindWindowEx: Not Desktop Parent!\n"); Ret = IntFindWindow(Parent, ChildAfter, ClassAtom, &WindowName); }

1 0

[pschweitzer] 73784: [FASTFAT] Don't attempt to verify volume if it was already verified in between
by pschweitzer＠svn.reactos.org 12 Feb '17

12 Feb '17

Author: pschweitzer Date: Sun Feb 12 19:31:31 2017 New Revision: 73784 URL: http://svn.reactos.org/svn/reactos?rev=73784&view=rev Log: [FASTFAT] Don't attempt to verify volume if it was already verified in between Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Sun Feb 12 19:31:31 2017 @@ -623,12 +623,20 @@ BOOLEAN RecognizedFS; PDEVICE_EXTENSION DeviceExt; BOOLEAN AllowRaw; + PVPB Vpb; DPRINT("VfatVerify(IrpContext %p)\n", IrpContext); DeviceToVerify = IrpContext->Stack->Parameters.VerifyVolume.DeviceObject; DeviceExt = DeviceToVerify->DeviceExtension; + Vpb = IrpContext->Stack->Parameters.VerifyVolume.Vpb; AllowRaw = BooleanFlagOn(IrpContext->Stack->Flags, SL_ALLOW_RAW_MOUNT); + + if (!BooleanFlagOn(Vpb->RealDevice->Flags, DO_VERIFY_VOLUME)) + { + DPRINT("Already verified\n"); + return STATUS_SUCCESS; + } Status = VfatBlockDeviceIoControl(DeviceExt->StorageDevice, IOCTL_DISK_CHECK_VERIFY, @@ -671,7 +679,7 @@ } } - IrpContext->Stack->Parameters.VerifyVolume.Vpb->RealDevice->Flags &= ~DO_VERIFY_VOLUME; + Vpb->RealDevice->Flags &= ~DO_VERIFY_VOLUME; return Status; }

1 0

[gadamopoulos] 73783: [WIN32KNT_APITEST]: -Make sure that NtUserUnregisterClass works when it gets the versioned class name. Show that NtUserFindWindowEx needs the non versioned class name.
by gadamopoulos＠svn.reactos.org 12 Feb '17

12 Feb '17

Author: gadamopoulos Date: Sun Feb 12 12:11:18 2017 New Revision: 73783 URL: http://svn.reactos.org/svn/reactos?rev=73783&view=rev Log: [WIN32KNT_APITEST]: -Make sure that NtUserUnregisterClass works when it gets the versioned class name. Show that NtUserFindWindowEx needs the non versioned class name. Modified: trunk/rostests/apitests/win32nt/ntuser/NtUserCreateWindowEx.c Modified: trunk/rostests/apitests/win32nt/ntuser/NtUserCreateWindowEx.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/win32nt/ntuser/N… ============================================================================== --- trunk/rostests/apitests/win32nt/ntuser/NtUserCreateWindowEx.c [iso-8859-1] (original) +++ trunk/rostests/apitests/win32nt/ntuser/NtUserCreateWindowEx.c [iso-8859-1] Sun Feb 12 12:11:18 2017 @@ -61,6 +61,7 @@ /* LARGE_STRING for NtUserCreateWindowEx */ LARGE_STRING l_dummy = {14, 32, 0, L"DummyMe"}; + LARGE_STRING l_empty = {0, 0, 0, L""}; LARGE_STRING l_wndName = {32, 32, 0, L""}; LARGE_STRING l_cls = {cls.Length, 32, 0, cls.Buffer}; LARGE_STRING l_ver_cls = {ver_cls.Length, 32, 0, ver_cls.Buffer}; @@ -181,6 +182,8 @@ /* Check what return GetClassLong */ TEST(GetClassLong(hwnd, GCW_ATOM) == atom); + + TEST(NtUserFindWindowEx(NULL, NULL, &cls, (UNICODE_STRING*)&l_empty, 0) == hwnd); /* Finally destroy it */ DestroyWindow(hwnd); @@ -245,4 +248,8 @@ TEST(NtUserUnregisterClass(&another_cls, hinst, &outClsMnu) != 0); TEST(NtUserUnregisterClass(&menu, hinst, &outClsMnu) == 0); -} + /* Make sure that the classes got destroyed */ + TEST(NtUserGetWOWClass(hinst, &cls) == 0); + TEST(NtUserGetWOWClass(hinst, &ver_cls) == 0); + TEST(NtUserGetWOWClass(hinst, &another_cls) == 0); +}

1 0

[pschweitzer] 73782: [SMSS] Remove useless nullptr check
by pschweitzer＠svn.reactos.org 12 Feb '17

12 Feb '17

Author: pschweitzer Date: Sun Feb 12 08:49:53 2017 New Revision: 73782 URL: http://svn.reactos.org/svn/reactos?rev=73782&view=rev Log: [SMSS] Remove useless nullptr check Modified: trunk/reactos/base/system/smss/smsubsys.c Modified: trunk/reactos/base/system/smss/smsubsys.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/system/smss/smsubsys.… ============================================================================== --- trunk/reactos/base/system/smss/smsubsys.c [iso-8859-1] (original) +++ trunk/reactos/base/system/smss/smsubsys.c [iso-8859-1] Sun Feb 12 08:49:53 2017 @@ -500,7 +500,7 @@ { RemoveEntryList(&NewSubsystem->Entry); NtSetEvent(NewSubsystem->Event, 0); - if (NewSubsystem) SmpDereferenceSubsystem(NewSubsystem); + SmpDereferenceSubsystem(NewSubsystem); } /* Finally, we're all done! */

1 0

[pschweitzer] 73781: [SERVMAN] Remove duplicated condition
by pschweitzer＠svn.reactos.org 12 Feb '17

12 Feb '17

Author: pschweitzer Date: Sun Feb 12 08:42:03 2017 New Revision: 73781 URL: http://svn.reactos.org/svn/reactos?rev=73781&view=rev Log: [SERVMAN] Remove duplicated condition Modified: trunk/reactos/base/applications/mscutils/servman/propsheet_logon.c Modified: trunk/reactos/base/applications/mscutils/servman/propsheet_logon.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/mscutils… ============================================================================== --- trunk/reactos/base/applications/mscutils/servman/propsheet_logon.c [iso-8859-1] (original) +++ trunk/reactos/base/applications/mscutils/servman/propsheet_logon.c [iso-8859-1] Sun Feb 12 08:42:03 2017 @@ -314,7 +314,7 @@ case IDC_LOGON_INTERACTIVE: if (HIWORD(wParam) == BN_CLICKED) { - if (pLogonData->bInitialized && pLogonData->bInitialized) + if (pLogonData->bInitialized) { pLogonData->bAccountChanged = TRUE; PropSheet_Changed(GetParent(hwndDlg), hwndDlg);

1 0

[pschweitzer] 73780: [FASTFAT] Remove useless assignement
by pschweitzer＠svn.reactos.org 12 Feb '17

12 Feb '17

Author: pschweitzer Date: Sun Feb 12 08:25:42 2017 New Revision: 73780 URL: http://svn.reactos.org/svn/reactos?rev=73780&view=rev Log: [FASTFAT] Remove useless assignement Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c Modified: trunk/reactos/drivers/filesystems/fastfat/finfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/finfo.c [iso-8859-1] Sun Feb 12 08:25:42 2017 @@ -1428,7 +1428,7 @@ PVFAT_IRP_CONTEXT IrpContext) { FILE_INFORMATION_CLASS FileInformationClass; - PVFATFCB FCB = NULL; + PVFATFCB FCB; NTSTATUS Status = STATUS_SUCCESS; PVOID SystemBuffer; @@ -1554,7 +1554,7 @@ PVFAT_IRP_CONTEXT IrpContext) { FILE_INFORMATION_CLASS FileInformationClass; - PVFATFCB FCB = NULL; + PVFATFCB FCB; NTSTATUS Status = STATUS_SUCCESS; PVOID SystemBuffer;

1 0

[tfaber] 73779: [IP] - Handle chained pbuf structures in TCPSendDataCallback CORE-10715
by tfaber＠svn.reactos.org 11 Feb '17

11 Feb '17

Author: tfaber Date: Sat Feb 11 23:13:45 2017 New Revision: 73779 URL: http://svn.reactos.org/svn/reactos?rev=73779&view=rev Log: [IP] - Handle chained pbuf structures in TCPSendDataCallback CORE-10715 Modified: trunk/reactos/sdk/lib/drivers/ip/transport/tcp/if.c Modified: trunk/reactos/sdk/lib/drivers/ip/transport/tcp/if.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/drivers/ip/transpo… ============================================================================== --- trunk/reactos/sdk/lib/drivers/ip/transport/tcp/if.c [iso-8859-1] (original) +++ trunk/reactos/sdk/lib/drivers/ip/transport/tcp/if.c [iso-8859-1] Sat Feb 11 23:13:45 2017 @@ -15,6 +15,8 @@ IP_PACKET Packet; IP_ADDRESS RemoteAddress, LocalAddress; PIPv4_HEADER Header; + ULONG Length; + ULONG TotalLength; /* The caller frees the pbuf struct */ @@ -39,7 +41,7 @@ { return ERR_RTE; } - + NdisStatus = AllocatePacketWithBuffer(&Packet.NdisPacket, NULL, p->tot_len); if (NdisStatus != NDIS_STATUS_SUCCESS) { @@ -49,19 +51,22 @@ GetDataPtr(Packet.NdisPacket, 0, (PCHAR*)&Packet.Header, &Packet.TotalSize); Packet.MappedHeader = TRUE; - if (p->tot_len != p->len || - Packet.TotalSize != p->len) + ASSERT(Packet.TotalSize == p->tot_len); + + TotalLength = p->tot_len; + Length = 0; + while (Length < TotalLength) { - DbgPrint("TCPSendDataCallback: tot_len = %u, len = %u, TotalSize = %u\n", - p->tot_len, p->len, Packet.TotalSize); - ASSERT(p->tot_len == p->len); - ASSERT(Packet.TotalSize == p->len); + ASSERT(p->len <= TotalLength - Length); + ASSERT(p->tot_len == TotalLength - Length); + RtlCopyMemory((PCHAR)Packet.Header + Length, p->payload, p->len); + Length += p->len; + p = p->next; } - - RtlCopyMemory(Packet.Header, p->payload, p->len); + ASSERT(Length == TotalLength); Packet.HeaderSize = sizeof(IPv4_HEADER); - Packet.TotalSize = p->tot_len; + Packet.TotalSize = TotalLength; Packet.SrcAddr = LocalAddress; Packet.DstAddr = RemoteAddress; @@ -77,9 +82,9 @@ { #if 0 ULONG OperationalStatus; - + GetInterfaceConnectionStatus(IF, &OperationalStatus); - + if (OperationalStatus == MIB_IF_OPER_STATUS_OPERATIONAL) netif_set_link_up(IF->TCPContext); else

1 0

[pschweitzer] 73778: [FASTFAT] In case of an error while trying to verify the volume, only return STATUS_WRONG_VOLUME is raw mounts are allowed
by pschweitzer＠svn.reactos.org 11 Feb '17

11 Feb '17

Author: pschweitzer Date: Sat Feb 11 20:26:33 2017 New Revision: 73778 URL: http://svn.reactos.org/svn/reactos?rev=73778&view=rev Log: [FASTFAT] In case of an error while trying to verify the volume, only return STATUS_WRONG_VOLUME is raw mounts are allowed Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Sat Feb 11 20:26:33 2017 @@ -622,11 +622,14 @@ FATINFO FatInfo; BOOLEAN RecognizedFS; PDEVICE_EXTENSION DeviceExt; + BOOLEAN AllowRaw; DPRINT("VfatVerify(IrpContext %p)\n", IrpContext); DeviceToVerify = IrpContext->Stack->Parameters.VerifyVolume.DeviceObject; DeviceExt = DeviceToVerify->DeviceExtension; + AllowRaw = BooleanFlagOn(IrpContext->Stack->Flags, SL_ALLOW_RAW_MOUNT); + Status = VfatBlockDeviceIoControl(DeviceExt->StorageDevice, IOCTL_DISK_CHECK_VERIFY, NULL, @@ -637,14 +640,15 @@ if (!NT_SUCCESS(Status) && Status != STATUS_VERIFY_REQUIRED) { DPRINT("VfatBlockDeviceIoControl() failed (Status %lx)\n", Status); - Status = STATUS_WRONG_VOLUME; + Status = (AllowRaw ? STATUS_WRONG_VOLUME : Status); } else { Status = VfatHasFileSystem(DeviceExt->StorageDevice, &RecognizedFS, &FatInfo, TRUE); if (!NT_SUCCESS(Status) || RecognizedFS == FALSE) { - Status = STATUS_WRONG_VOLUME; + if (NT_SUCCESS(Status) || AllowRaw) + Status = STATUS_WRONG_VOLUME; } else if (sizeof(FATINFO) == RtlCompareMemory(&FatInfo, &DeviceExt->FatInfo, sizeof(FATINFO))) {

1 0

[pschweitzer] 73777: [FASTFAT] Remove useless assignement
by pschweitzer＠svn.reactos.org 11 Feb '17

11 Feb '17

Author: pschweitzer Date: Sat Feb 11 18:33:47 2017 New Revision: 73777 URL: http://svn.reactos.org/svn/reactos?rev=73777&view=rev Log: [FASTFAT] Remove useless assignement Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c Modified: trunk/reactos/drivers/filesystems/fastfat/fsctl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/fastfa… ============================================================================== --- trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/fastfat/fsctl.c [iso-8859-1] Sat Feb 11 18:33:47 2017 @@ -618,7 +618,7 @@ PVFAT_IRP_CONTEXT IrpContext) { PDEVICE_OBJECT DeviceToVerify; - NTSTATUS Status = STATUS_SUCCESS; + NTSTATUS Status; FATINFO FatInfo; BOOLEAN RecognizedFS; PDEVICE_EXTENSION DeviceExt;

1 0

← Newer
1
...
20
21
22
23
24
25
26
...
36
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs February 2017