Ros-diffs April 2017

ros-diffs@reactos.org

14 participants
179 discussions

[gadamopoulos] 74276: [WIN32K] -MENU_TrackMouseMenuBar: Use IntGetSystemMenu instead of get_win_sys_menu because the system menu have not been initialized yet (it is delay initialized). CORE-12801
by gadamopoulos＠svn.reactos.org 05 Apr '17

05 Apr '17

Author: gadamopoulos Date: Wed Apr 5 09:09:50 2017 New Revision: 74276 URL: http://svn.reactos.org/svn/reactos?rev=74276&view=rev Log: [WIN32K] -MENU_TrackMouseMenuBar: Use IntGetSystemMenu instead of get_win_sys_menu because the system menu have not been initialized yet (it is delay initialized). CORE-12801 Modified: trunk/reactos/win32ss/user/ntuser/menu.c Modified: trunk/reactos/win32ss/user/ntuser/menu.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/menu.c… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/menu.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/menu.c [iso-8859-1] Wed Apr 5 09:09:50 2017 @@ -4240,7 +4240,7 @@ */ VOID MENU_TrackMouseMenuBar( PWND pWnd, ULONG ht, POINT pt) { - PMENU pMenu = (ht == HTSYSMENU) ? get_win_sys_menu( UserHMGetHandle(pWnd) ) : IntGetMenu( UserHMGetHandle(pWnd) ); + PMENU pMenu = (ht == HTSYSMENU) ? IntGetSystemMenu(pWnd, FALSE) : IntGetMenu( UserHMGetHandle(pWnd) ); UINT wFlags = TPM_BUTTONDOWN | TPM_LEFTALIGN | TPM_LEFTBUTTON; TRACE("wnd=%p ht=0x%04x (%ld,%ld)\n", pWnd, ht, pt.x, pt.y);

1 0

[gadamopoulos] 74275: [WIN32K] -NtGdiGetRegionData: prgn->rdh.nRgnSize is the size of kernel mode buffer for the region. After copying it to the caller we should set lpRgnData->rdh.nRgnSize to cjRe...
by gadamopoulos＠svn.reactos.org 04 Apr '17

04 Apr '17

Author: gadamopoulos Date: Tue Apr 4 10:07:07 2017 New Revision: 74275 URL: http://svn.reactos.org/svn/reactos?rev=74275&view=rev Log: [WIN32K] -NtGdiGetRegionData: prgn->rdh.nRgnSize is the size of kernel mode buffer for the region. After copying it to the caller we should set lpRgnData->rdh.nRgnSize to cjRects. Modified: trunk/reactos/win32ss/gdi/ntgdi/region.c Modified: trunk/reactos/win32ss/gdi/ntgdi/region.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/region.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/region.c [iso-8859-1] Tue Apr 4 10:07:07 2017 @@ -4105,6 +4105,7 @@ RtlCopyMemory(lpRgnData, &prgn->rdh, sizeof(RGNDATAHEADER)); RtlCopyMemory(lpRgnData->Buffer, prgn->Buffer, cjRects); lpRgnData->rdh.iType = RDH_RECTANGLES; + lpRgnData->rdh.nRgnSize = cjRects; } _SEH2_EXCEPT(EXCEPTION_EXECUTE_HANDLER) {

1 0

[rnaumann] 74274: [EXPLORER] Add modern start menu bitmap by Jared Smudde
by rnaumann＠svn.reactos.org 03 Apr '17

03 Apr '17

Author: rnaumann Date: Mon Apr 3 18:39:52 2017 New Revision: 74274 URL: http://svn.reactos.org/svn/reactos?rev=74274&view=rev Log: [EXPLORER] Add modern start menu bitmap by Jared Smudde Added: trunk/reactos/base/shell/explorer/res/bmp/170.bmp (with props) Modified: trunk/reactos/base/shell/explorer/explorer.rc Modified: trunk/reactos/base/shell/explorer/explorer.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/explor… ============================================================================== --- trunk/reactos/base/shell/explorer/explorer.rc [iso-8859-1] (original) +++ trunk/reactos/base/shell/explorer/explorer.rc [iso-8859-1] Mon Apr 3 18:39:52 2017 @@ -51,7 +51,7 @@ IDB_SYSTRAYPROP_SHOW_SECONDS BITMAP "res/bmp/154.bmp" IDB_SYSTRAYPROP_HIDE_SECONDS BITMAP "res/bmp/155.bmp" IDB_STARTMENU BITMAP "res/bmp/158.bmp" -IDB_STARTPREVIEW BITMAP "res/bmp/171.bmp" // We don't have a proper preview image for the modern start menu yet. Use the classic one so far. +IDB_STARTPREVIEW BITMAP "res/bmp/170.bmp" IDB_STARTPREVIEW_CLASSIC BITMAP "res/bmp/171.bmp" IDB_SYSTRAYPROP_HIDE_CLOCK BITMAP "res/bmp/180.bmp" IDB_SYSTRAYPROP_HIDE_NOCLOCK BITMAP "res/bmp/181.bmp" Added: trunk/reactos/base/shell/explorer/res/bmp/170.bmp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/shell/explorer/res/bm… ============================================================================== Binary file - no diff available. Propchange: trunk/reactos/base/shell/explorer/res/bmp/170.bmp ------------------------------------------------------------------------------ svn:mime-type = application/octet-stream

1 0

[tfaber] 74273: [NTOS] - Silence some more debug prints
by tfaber＠svn.reactos.org 02 Apr '17

02 Apr '17

Author: tfaber Date: Sun Apr 2 21:33:25 2017 New Revision: 74273 URL: http://svn.reactos.org/svn/reactos?rev=74273&view=rev Log: [NTOS] - Silence some more debug prints Modified: trunk/reactos/ntoskrnl/config/cmsysini.c trunk/reactos/ntoskrnl/io/pnpmgr/pnpinit.c trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c Modified: trunk/reactos/ntoskrnl/config/cmsysini.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/config/cmsysini.c… ============================================================================== --- trunk/reactos/ntoskrnl/config/cmsysini.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/config/cmsysini.c [iso-8859-1] Sun Apr 2 21:33:25 2017 @@ -510,7 +510,7 @@ if (ProfileHandle) NtClose(ProfileHandle); - DPRINT1("CmpCreateHardwareProfile() done\n"); + DPRINT("CmpCreateHardwareProfile() done\n"); return Status; } Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpinit.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/pnpinit… ============================================================================== --- trunk/reactos/ntoskrnl/io/pnpmgr/pnpinit.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/pnpmgr/pnpinit.c [iso-8859-1] Sun Apr 2 21:33:25 2017 @@ -452,7 +452,6 @@ if (Disposition == REG_CREATED_NEW_KEY) { /* FIXME: DACLs */ - DPRINT1("Need to build DACL\n"); } /* Create the root key */ Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.… ============================================================================== --- trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c [iso-8859-1] Sun Apr 2 21:33:25 2017 @@ -688,7 +688,7 @@ Status = IopQueryDeviceCapabilities(DeviceNode, &DeviceCapabilities); if (!NT_SUCCESS(Status)) { - DPRINT1("IopInitiatePnpIrp() failed (Status 0x%08lx)\n", Status); + DPRINT("IopInitiatePnpIrp() failed (Status 0x%08lx)\n", Status); } /* Invalidate device state so IRP_MN_QUERY_PNP_DEVICE_STATE is sent */ @@ -855,7 +855,10 @@ &Stack); if (!NT_SUCCESS(Status)) { - DPRINT1("IRP_MN_QUERY_CAPABILITIES failed with status 0x%x\n", Status); + if (Status != STATUS_NOT_SUPPORTED) + { + DPRINT1("IRP_MN_QUERY_CAPABILITIES failed with status 0x%lx\n", Status); + } return Status; }

1 0

[ekohl] 74272: [SCHEDSVC] Implement NetsJobEnum.
by ekohl＠svn.reactos.org 02 Apr '17

02 Apr '17

Author: ekohl Date: Sun Apr 2 20:47:48 2017 New Revision: 74272 URL: http://svn.reactos.org/svn/reactos?rev=74272&view=rev Log: [SCHEDSVC] Implement NetsJobEnum. Modified: trunk/reactos/base/services/schedsvc/rpcserver.c Modified: trunk/reactos/base/services/schedsvc/rpcserver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/services/schedsvc/rpc… ============================================================================== --- trunk/reactos/base/services/schedsvc/rpcserver.c [iso-8859-1] (original) +++ trunk/reactos/base/services/schedsvc/rpcserver.c [iso-8859-1] Sun Apr 2 20:47:48 2017 @@ -21,7 +21,7 @@ * PROJECT: ReactOS Services * FILE: base/services/schedsvc/rpcserver.c * PURPOSE: Scheduler service - * PROGRAMMER: Eric Kohl + * PROGRAMMER: Eric Kohl <eric.kohl(a)reactos.org> */ /* INCLUDES *****************************************************************/ @@ -31,6 +31,8 @@ #include "lmerr.h" WINE_DEFAULT_DEBUG_CHANNEL(schedsvc); + +#define DWORD_MAX 0xffffffffUL typedef struct _JOB { @@ -196,9 +198,124 @@ LPDWORD pTotalEntries, LPDWORD pResumeHandle) { + PLIST_ENTRY JobEntry; + PJOB CurrentJob; + PAT_ENUM pEnum; + DWORD dwStartIndex, dwIndex; + DWORD dwEntriesToRead, dwEntriesRead; + DWORD dwRequiredSize, dwEntrySize; + PWSTR pString; + DWORD dwError = ERROR_SUCCESS; + TRACE("NetrJobEnum(%S %p %lu %p %p)\n", ServerName, pEnumContainer, PreferedMaximumLength, pTotalEntries, pResumeHandle); - return ERROR_SUCCESS; + + if (pEnumContainer == NULL) + { + *pTotalEntries = 0; + return ERROR_INVALID_PARAMETER; + } + + if (*pResumeHandle >= dwJobCount) + { + *pTotalEntries = 0; + return ERROR_SUCCESS; + } + + dwStartIndex = *pResumeHandle; + TRACE("dwStartIndex: %lu\n", dwStartIndex); + + /* Acquire the job list lock exclusively */ + RtlAcquireResourceShared(&JobListLock, TRUE); + + dwEntriesToRead = 0; + dwRequiredSize = 0; + dwIndex = 0; + JobEntry = JobListHead.Flink; + while (JobEntry != &JobListHead) + { + CurrentJob = CONTAINING_RECORD(JobEntry, JOB, Entry); + + if (dwIndex >= dwStartIndex) + { + TRACE("dwIndex: %lu\n", dwIndex); + dwEntrySize = sizeof(AT_ENUM) + + (wcslen(CurrentJob->Command) + 1) * sizeof(WCHAR); + TRACE("dwEntrySize: %lu\n", dwEntrySize); + + if ((PreferedMaximumLength != DWORD_MAX) && + (dwRequiredSize + dwEntrySize > PreferedMaximumLength)) + break; + + dwRequiredSize += dwEntrySize; + dwEntriesToRead++; + } + + JobEntry = JobEntry->Flink; + dwIndex++; + } + TRACE("dwEntriesToRead: %lu\n", dwEntriesToRead); + TRACE("dwRequiredSize: %lu\n", dwRequiredSize); + + if (PreferedMaximumLength != DWORD_MAX) + dwRequiredSize = PreferedMaximumLength; + + TRACE("Allocating dwRequiredSize: %lu\n", dwRequiredSize); + pEnum = midl_user_allocate(dwRequiredSize); + if (pEnum == NULL) + { + dwError = ERROR_OUTOFMEMORY; + goto done; + } + + pString = (PWSTR)((ULONG_PTR)pEnum + dwEntriesToRead * sizeof(AT_ENUM)); + + dwEntriesRead = 0; + dwIndex = 0; + JobEntry = JobListHead.Flink; + while (JobEntry != &JobListHead) + { + CurrentJob = CONTAINING_RECORD(JobEntry, JOB, Entry); + + if (dwIndex >= dwStartIndex) + { + pEnum[dwIndex].JobId = CurrentJob->JobId; + pEnum[dwIndex].JobTime = CurrentJob->JobTime; + pEnum[dwIndex].DaysOfMonth = CurrentJob->DaysOfMonth; + pEnum[dwIndex].DaysOfWeek = CurrentJob->DaysOfWeek; + pEnum[dwIndex].Flags = CurrentJob->Flags; + pEnum[dwIndex].Command = pString; + wcscpy(pString, CurrentJob->Command); + + pString = (PWSTR)((ULONG_PTR)pString + (wcslen(CurrentJob->Command) + 1) * sizeof(WCHAR)); + + dwEntriesRead++; + } + + if (dwEntriesRead == dwEntriesToRead) + break; + + /* Next job */ + JobEntry = JobEntry->Flink; + dwIndex++; + } + + pEnumContainer->EntriesRead = dwEntriesRead; + pEnumContainer->Buffer = pEnum; + + *pTotalEntries = dwJobCount; + *pResumeHandle = dwIndex; + + if (dwEntriesRead + dwStartIndex < dwJobCount) + dwError = ERROR_MORE_DATA; + else + dwError = ERROR_SUCCESS; + +done: + /* Release the job list lock */ + RtlReleaseResource(&JobListLock); + + return dwError; }

1 0

[ekohl] 74271: [IDL] atsvc.idl: Add missing 'string' attribute which fixes NetrJobEnum.
by ekohl＠svn.reactos.org 02 Apr '17

02 Apr '17

Author: ekohl Date: Sun Apr 2 20:32:07 2017 New Revision: 74271 URL: http://svn.reactos.org/svn/reactos?rev=74271&view=rev Log: [IDL] atsvc.idl: Add missing 'string' attribute which fixes NetrJobEnum. Modified: trunk/reactos/sdk/include/reactos/idl/atsvc.idl Modified: trunk/reactos/sdk/include/reactos/idl/atsvc.idl URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/include/reactos/idl/at… ============================================================================== --- trunk/reactos/sdk/include/reactos/idl/atsvc.idl [iso-8859-1] (original) +++ trunk/reactos/sdk/include/reactos/idl/atsvc.idl [iso-8859-1] Sun Apr 2 20:32:07 2017 @@ -13,7 +13,7 @@ DWORD DaysOfMonth; unsigned char DaysOfWeek; unsigned char Flags; - wchar_t *Command; + [string] wchar_t *Command; } AT_ENUM, *PAT_ENUM, *LPAT_ENUM; typedef struct _AT_INFO

1 0

[dreimer] 74270: [RAPPS] As long as we use the current "db" format, keep these ones alive.
by dreimer＠svn.reactos.org 02 Apr '17

02 Apr '17

Author: dreimer Date: Sun Apr 2 17:52:14 2017 New Revision: 74270 URL: http://svn.reactos.org/svn/reactos?rev=74270&view=rev Log: [RAPPS] As long as we use the current "db" format, keep these ones alive. Added: trunk/reactos/base/applications/rapps/CreateCabFile.bat (with props) trunk/reactos/base/applications/rapps/CreateCabFile.sh (with props) Added: trunk/reactos/base/applications/rapps/CreateCabFile.bat URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/Cr… ============================================================================== --- trunk/reactos/base/applications/rapps/CreateCabFile.bat (added) +++ trunk/reactos/base/applications/rapps/CreateCabFile.bat [iso-8859-1] Sun Apr 2 17:52:14 2017 @@ -0,0 +1,12 @@ +@echo off + +cd ..\..\..\media + +mkdir rapps\utf16 + +for %%f in (rapps\*.txt) do ( + ..\output-MinGW-i386\host-tools\utf16le.exe "rapps\%%~nf.txt" "rapps\utf16\%%~nf.txt" +) + +..\output-MinGW-i386\host-tools\cabman.exe -M mszip -S rapps\rappmgr.cab rapps\utf16\*.txt +rmdir /s /q rapps\utf16 Propchange: trunk/reactos/base/applications/rapps/CreateCabFile.bat ------------------------------------------------------------------------------ svn:eol-style = native Added: trunk/reactos/base/applications/rapps/CreateCabFile.sh URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/Cr… ============================================================================== --- trunk/reactos/base/applications/rapps/CreateCabFile.sh (added) +++ trunk/reactos/base/applications/rapps/CreateCabFile.sh [iso-8859-1] Sun Apr 2 17:52:14 2017 @@ -0,0 +1,9 @@ +#/bin/sh +cd ../../../media +mkdir rapps/utf16 +for i in $(find -type f); do + ../../host-tools/utf16le $i utf16/$i +done +cd .. +../../host-tools/cabman -M mszip -S rapps/rappmgr.cab rapps/utf16/*.txt +rm -r rapps/uft16 Propchange: trunk/reactos/base/applications/rapps/CreateCabFile.sh ------------------------------------------------------------------------------ svn:eol-style = native

1 0

[mjansen] 74269: [RAPPS][RAPPS_NEW] Finally replace rapps with rapps_new. CORE-13017 #resolve
by mjansen＠svn.reactos.org 02 Apr '17

02 Apr '17

Author: mjansen Date: Sun Apr 2 14:46:54 2017 New Revision: 74269 URL: http://svn.reactos.org/svn/reactos?rev=74269&view=rev Log: [RAPPS][RAPPS_NEW] Finally replace rapps with rapps_new. CORE-13017 #resolve Added: trunk/reactos/base/applications/rapps/ - copied from r74268, trunk/reactos/base/applications/rapps_new/ trunk/reactos/base/applications/rapps/rappsmsg.mc - copied unchanged from r74256, trunk/reactos/base/applications/rapps_new/rappsmsg_new.mc Removed: trunk/reactos/base/applications/rapps/rappsmsg_new.mc trunk/reactos/base/applications/rapps_new/ Modified: trunk/reactos/base/applications/CMakeLists.txt trunk/reactos/base/applications/rapps/CMakeLists.txt trunk/reactos/base/applications/rapps/aboutdlg.cpp trunk/reactos/base/applications/rapps/available.cpp trunk/reactos/base/applications/rapps/installdlg.cpp trunk/reactos/base/applications/rapps/installed.cpp trunk/reactos/base/applications/rapps/integrity.cpp trunk/reactos/base/applications/rapps/lang/ro-RO.rc trunk/reactos/base/applications/rapps/lang/sv-SE.rc trunk/reactos/base/applications/rapps/lang/uk-UA.rc trunk/reactos/base/applications/rapps/loaddlg.cpp trunk/reactos/base/applications/rapps/misc.cpp trunk/reactos/base/applications/rapps/rapps.h trunk/reactos/base/applications/rapps/rapps.rc trunk/reactos/base/applications/rapps/settingsdlg.cpp trunk/reactos/base/applications/rapps/splitter.cpp trunk/reactos/base/applications/rapps/winmain.cpp Modified: trunk/reactos/base/applications/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/CMakeLis… ============================================================================== --- trunk/reactos/base/applications/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/CMakeLists.txt [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -28,7 +28,6 @@ add_subdirectory(notepad) add_subdirectory(osk) add_subdirectory(rapps) -add_subdirectory(rapps_new) add_subdirectory(regedit) add_subdirectory(regedt32) add_subdirectory(sc) Modified: trunk/reactos/base/applications/rapps/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/CM… ============================================================================== --- trunk/reactos/base/applications/rapps/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/CMakeLists.txt [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,4 +1,4 @@ -project(RAPPS_NEW) +project(rapps) set_cpp(WITH_RUNTIME) @@ -19,13 +19,13 @@ rapps.h) add_definitions(-DUSE_CERT_PINNING) -file(GLOB_RECURSE rapps_new_rc_deps res/*.*) -add_rc_deps(rapps.rc ${rapps_new_rc_deps}) -add_executable(rapps_new ${SOURCE} rapps.rc) -set_module_type(rapps_new win32gui UNICODE) -target_link_libraries(rapps_new atlnew uuid wine) -add_importlibs(rapps_new advapi32 comctl32 gdi32 wininet user32 shell32 shlwapi ole32 msvcrt kernel32 ntdll) -add_pch(rapps_new rapps.h SOURCE) -add_dependencies(rapps_new rappsmsg_new) -add_message_headers(ANSI rappsmsg_new.mc) -add_cd_file(TARGET rapps_new DESTINATION reactos/system32 FOR all) +file(GLOB_RECURSE rapps_rc_deps res/*.*) +add_rc_deps(rapps.rc ${rapps_rc_deps}) +add_executable(rapps ${SOURCE} rapps.rc) +set_module_type(rapps win32gui UNICODE) +target_link_libraries(rapps atlnew uuid wine) +add_importlibs(rapps advapi32 comctl32 gdi32 wininet user32 shell32 shlwapi ole32 msvcrt kernel32 ntdll) +add_pch(rapps rapps.h SOURCE) +add_dependencies(rapps rappsmsg) +add_message_headers(ANSI rappsmsg.mc) +add_cd_file(TARGET rapps DESTINATION reactos/system32 FOR all) Modified: trunk/reactos/base/applications/rapps/aboutdlg.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/ab… ============================================================================== --- trunk/reactos/base/applications/rapps/aboutdlg.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/aboutdlg.cpp [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,7 +1,7 @@ /* * PROJECT: ReactOS Applications Manager * LICENSE: GPL - See COPYING in the top level directory - * FILE: base/applications/rapps_new/aboutdlg.cpp + * FILE: base/applications/rapps/aboutdlg.cpp * PURPOSE: About Dialog * PROGRAMMERS: Dmitry Chapyshev (dmitry(a)reactos.org) */ Modified: trunk/reactos/base/applications/rapps/available.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/av… ============================================================================== --- trunk/reactos/base/applications/rapps/available.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/available.cpp [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,7 +1,7 @@ /* * PROJECT: ReactOS Applications Manager * LICENSE: GPL - See COPYING in the top level directory - * FILE: base/applications/rapps_new/available.cpp + * FILE: base/applications/rapps/available.cpp * PURPOSE: Functions for working with available applications * PROGRAMMERS: Dmitry Chapyshev (dmitry(a)reactos.org) * Ismael Ferreras Morezuelas (swyterzone+ros(a)gmail.com) Modified: trunk/reactos/base/applications/rapps/installdlg.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/in… ============================================================================== --- trunk/reactos/base/applications/rapps/installdlg.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/installdlg.cpp [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,7 +1,7 @@ /* * PROJECT: ReactOS Applications Manager * LICENSE: GPL - See COPYING in the top level directory - * FILE: base/applications/rapps_new/installdlg.cpp + * FILE: base/applications/rapps/installdlg.cpp * PURPOSE: "Download and Install" Dialog * PROGRAMMERS: Dmitry Chapyshev (dmitry(a)reactos.org) */ Modified: trunk/reactos/base/applications/rapps/installed.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/in… ============================================================================== --- trunk/reactos/base/applications/rapps/installed.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/installed.cpp [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,7 +1,7 @@ /* * PROJECT: ReactOS Applications Manager * LICENSE: GPL - See COPYING in the top level directory - * FILE: base/applications/rapps_new/installed.cpp + * FILE: base/applications/rapps/installed.cpp * PURPOSE: Functions for working with installed applications * PROGRAMMERS: Dmitry Chapyshev (dmitry(a)reactos.org) */ Modified: trunk/reactos/base/applications/rapps/integrity.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/in… ============================================================================== --- trunk/reactos/base/applications/rapps/integrity.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/integrity.cpp [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,7 +1,7 @@ /* * PROJECT: ReactOS Applications Manager * LICENSE: GPL - See COPYING in the top level directory - * FILE: base/applications/rapps_new/integrity.cpp + * FILE: base/applications/rapps/integrity.cpp * PURPOSE: Various integrity check mechanisms * PROGRAMMERS: Ismael Ferreras Morezuelas (swyterzone+ros(a)gmail.com) * Mark Jansen Modified: trunk/reactos/base/applications/rapps/lang/ro-RO.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/la… ============================================================================== --- trunk/reactos/base/applications/rapps/lang/ro-RO.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/lang/ro-RO.rc [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,5 +1,5 @@ /* - * FILE: base/applications/rapps_new/lang/ro-RO.rc + * FILE: base/applications/rapps/lang/ro-RO.rc * ReactOS Project (http://www.reactos.org) * TRANSLATOR: Ètefan Fulea (stefan dot fulea at mail dot md) */ Modified: trunk/reactos/base/applications/rapps/lang/sv-SE.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/la… ============================================================================== --- trunk/reactos/base/applications/rapps/lang/sv-SE.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/lang/sv-SE.rc [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,6 +1,6 @@ /* * PROJECT: ReactOS RAPPS - * FILE: base/applications/rapps_new/lang/sv-SE.rc + * FILE: base/applications/rapps/lang/sv-SE.rc * PURPOSE: Swedish resource file * Translation: Jaix Bly */ Modified: trunk/reactos/base/applications/rapps/lang/uk-UA.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/la… ============================================================================== --- trunk/reactos/base/applications/rapps/lang/uk-UA.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/lang/uk-UA.rc [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,7 +1,7 @@ /* * PROJECT: ReactOS ReactOS Applications Manager * LICENSE: GPL - See COPYING in the top level directory - * FILE: base/applications/rapps_new/lang/uk-UA.rc + * FILE: base/applications/rapps/lang/uk-UA.rc * PURPOSE: Ukraianian Language File for ReactOS ReactOS Applications Manager * TRANSLATOR: Sakara Yevhen, Igor Paliychuk */ Modified: trunk/reactos/base/applications/rapps/loaddlg.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/lo… ============================================================================== --- trunk/reactos/base/applications/rapps/loaddlg.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/loaddlg.cpp [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,6 +1,6 @@ /* PROJECT: ReactOS Applications Manager * LICENSE: GPL - See COPYING in the top level directory - * FILE: base/applications/rapps_new/loaddlg.cpp + * FILE: base/applications/rapps/loaddlg.cpp * PURPOSE: Displaying a download dialog * COPYRIGHT: Copyright 2001 John R. Sheets (for CodeWeavers) * Copyright 2004 Mike McCormack (for CodeWeavers) Modified: trunk/reactos/base/applications/rapps/misc.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/mi… ============================================================================== --- trunk/reactos/base/applications/rapps/misc.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/misc.cpp [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,7 +1,7 @@ /* * PROJECT: ReactOS Applications Manager * LICENSE: GPL - See COPYING in the top level directory - * FILE: base/applications/rapps_new/misc.cpp + * FILE: base/applications/rapps/misc.cpp * PURPOSE: Misc functions * PROGRAMMERS: Dmitry Chapyshev (dmitry(a)reactos.org) * Ismael Ferreras Morezuelas (swyterzone+ros(a)gmail.com) Modified: trunk/reactos/base/applications/rapps/rapps.h URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/ra… ============================================================================== --- trunk/reactos/base/applications/rapps/rapps.h [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/rapps.h [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -24,7 +24,7 @@ #include <strsafe.h> #include <ndk/rtlfuncs.h> -#include <rappsmsg_new.h> +#include <rappsmsg.h> #include "resource.h" Modified: trunk/reactos/base/applications/rapps/rapps.rc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/ra… ============================================================================== --- trunk/reactos/base/applications/rapps/rapps.rc [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/rapps.rc [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -52,7 +52,7 @@ #include <reactos/manifest_exe.rc> -#include <rappsmsg_new.rc> +#include <rappsmsg.rc> /* UTF-8 */ #pragma code_page(65001) Removed: trunk/reactos/base/applications/rapps/rappsmsg_new.mc URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps_ne… ============================================================================== --- trunk/reactos/base/applications/rapps/rappsmsg_new.mc [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/rappsmsg_new.mc (removed) @@ -1,27 +0,0 @@ -MessageIdTypedef=ULONG - -SeverityNames=(Success=0x0:STATUS_SEVERITY_SUCCESS -Informational=0x1:STATUS_SEVERITY_INFORMATIONAL -Warning=0x2:STATUS_SEVERITY_WARNING -Error=0x3:STATUS_SEVERITY_ERROR) - -FacilityNames=(System=0x0:FACILITY_SYSTEM) - -LanguageNames=(English=0x409:MSG00409) - -MessageId=1 -Severity=Success -Facility=Application -SymbolicName=MSG_SUCCESS_INSTALL -Language=English -Installation of the program "%1" is called. -. - -MessageId=2 -Severity=Success -Facility=Application -SymbolicName=MSG_SUCCESS_REMOVE -Language=English -Removal of the program "%1" is called. -. - Modified: trunk/reactos/base/applications/rapps/settingsdlg.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/se… ============================================================================== --- trunk/reactos/base/applications/rapps/settingsdlg.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/settingsdlg.cpp [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,7 +1,7 @@ /* * PROJECT: ReactOS Applications Manager * LICENSE: GPL - See COPYING in the top level directory - * FILE: base/applications/rapps_new/settingsdlg.cpp + * FILE: base/applications/rapps/settingsdlg.cpp * PURPOSE: Settings Dialog * PROGRAMMERS: Dmitry Chapyshev (dmitry(a)reactos.org) */ Modified: trunk/reactos/base/applications/rapps/splitter.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/sp… ============================================================================== --- trunk/reactos/base/applications/rapps/splitter.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/splitter.cpp [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,7 +1,7 @@ /* * PROJECT: ReactOS Applications Manager * LICENSE: GPL - See COPYING in the top level directory - * FILE: base/applications/rapps_new/splitter.cpp + * FILE: base/applications/rapps/splitter.cpp * PURPOSE: SplitterBar functions * PROGRAMMERS: Dmitry Chapyshev (dmitry(a)reactos.org) */ Modified: trunk/reactos/base/applications/rapps/winmain.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/base/applications/rapps/wi… ============================================================================== --- trunk/reactos/base/applications/rapps/winmain.cpp [iso-8859-1] (original) +++ trunk/reactos/base/applications/rapps/winmain.cpp [iso-8859-1] Sun Apr 2 14:46:54 2017 @@ -1,7 +1,7 @@ /* * PROJECT: ReactOS Applications Manager * LICENSE: GPL - See COPYING in the top level directory - * FILE: base/applications/rapps_new/winmain.cpp + * FILE: base/applications/rapps/winmain.cpp * PURPOSE: Main program * PROGRAMMERS: Dmitry Chapyshev (dmitry(a)reactos.org) * Ismael Ferreras Morezuelas (swyterzone+ros(a)gmail.com)

1 0

[gadamopoulos] 74268: [SHELL32] -CShellDispatch: Properly register Shell.Application. Implement CShellDispatch::ShutdownWindows. CORE-13010
by gadamopoulos＠svn.reactos.org 02 Apr '17

02 Apr '17

Author: gadamopoulos Date: Sun Apr 2 14:45:10 2017 New Revision: 74268 URL: http://svn.reactos.org/svn/reactos?rev=74268&view=rev Log: [SHELL32] -CShellDispatch: Properly register Shell.Application. Implement CShellDispatch::ShutdownWindows. CORE-13010 Modified: trunk/reactos/dll/win32/shell32/CShellDispatch.cpp trunk/reactos/dll/win32/shell32/res/rgs/shell.rgs Modified: trunk/reactos/dll/win32/shell32/CShellDispatch.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CShellDi… ============================================================================== --- trunk/reactos/dll/win32/shell32/CShellDispatch.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CShellDispatch.cpp [iso-8859-1] Sun Apr 2 14:45:10 2017 @@ -142,8 +142,8 @@ HRESULT STDMETHODCALLTYPE CShellDispatch::ShutdownWindows() { - TRACE("(%p)\n", this); - return E_NOTIMPL; + ExitWindowsDialog(NULL); + return S_OK; } HRESULT STDMETHODCALLTYPE CShellDispatch::Suspend() Modified: trunk/reactos/dll/win32/shell32/res/rgs/shell.rgs URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/res/rgs/… ============================================================================== --- trunk/reactos/dll/win32/shell32/res/rgs/shell.rgs [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/res/rgs/shell.rgs [iso-8859-1] Sun Apr 2 14:45:10 2017 @@ -8,6 +8,33 @@ { val ThreadingModel = s 'Apartment' } + ProgID = s 'Shell.Application.1' + TypeLib = s '{50a7e9b0-70ef-11d1-b75a-00a0c90564fe}' + Version = s '1.1' + VersionIndependentProgID = s 'Shell.Application' } } + + NoRemove TypeLib + { + ForceRemove {50A7E9B0-70EF-11D1-B75A-00A0C90564FE} + { + '1.1' = s 'Shell Controls And Automation' + { + '0' { win32 = s '%MODULE%' } + FLAGS = s '0' + } + } + } + + 'Shell.Application' = s 'Shell Automation Service' + { + CLSID = s '{13709620-C279-11CE-A49E-444553540000}' + CurVer = s 'Shell.Application.1' + } + + 'Shell.Application.1' = s 'Shell Automation Service' + { + CLSID = s '{13709620-C279-11CE-A49E-444553540000}' + } }

1 0

[tfaber] 74267: [NTOS:PNP] - Silence debug prints about unhandled IRP_MN_QUERY_PNP_DEVICE_STATE
by tfaber＠svn.reactos.org 02 Apr '17

02 Apr '17

Author: tfaber Date: Sun Apr 2 14:41:17 2017 New Revision: 74267 URL: http://svn.reactos.org/svn/reactos?rev=74267&view=rev Log: [NTOS:PNP] - Silence debug prints about unhandled IRP_MN_QUERY_PNP_DEVICE_STATE Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c Modified: trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.… ============================================================================== --- trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/io/pnpmgr/pnpmgr.c [iso-8859-1] Sun Apr 2 14:41:17 2017 @@ -4126,7 +4126,10 @@ Status = IopSynchronousCall(PhysicalDeviceObject, &Stack, (PVOID*)&PnPFlags); if (!NT_SUCCESS(Status)) { - DPRINT1("IRP_MN_QUERY_PNP_DEVICE_STATE failed with status 0x%x\n", Status); + if (Status != STATUS_NOT_SUPPORTED) + { + DPRINT1("IRP_MN_QUERY_PNP_DEVICE_STATE failed with status 0x%lx\n", Status); + } return; }

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs April 2017