Ros-diffs June 2017

ros-diffs@reactos.org

20 participants
526 discussions

[mjansen] 75001: [WIN32NT_APITEST] Do not assert on a driver without DirectX support.

by mjansen＠svn.reactos.org

Author: mjansen Date: Sun Jun 11 11:47:41 2017 New Revision: 75001 URL: http://svn.reactos.org/svn/reactos?rev=75001&view=rev Log: [WIN32NT_APITEST] Do not assert on a driver without DirectX support. Modified: trunk/rostests/apitests/win32nt/ntdd/NtGdiDdQueryDirectDrawObject.c Modified: trunk/rostests/apitests/win32nt/ntdd/NtGdiDdQueryDirectDrawObject.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/win32nt/ntdd/NtG… ============================================================================== --- trunk/rostests/apitests/win32nt/ntdd/NtGdiDdQueryDirectDrawObject.c [iso-8859-1] (original) +++ trunk/rostests/apitests/win32nt/ntdd/NtGdiDdQueryDirectDrawObject.c [iso-8859-1] Sun Jun 11 11:47:41 2017 @@ -68,7 +68,12 @@ /* Create ReactX handle */ hDirectDraw = (HANDLE) NtGdiDdCreateDirectDrawObject(hdc); - ASSERT(hDirectDraw != NULL); + RTEST(hDirectDraw != NULL); + if (hDirectDraw == NULL) + { + DeleteDC(hdc); + return; + } /* Start Test ReactX NtGdiDdQueryDirectDrawObject function */

7 years, 3 months

[tfaber] 75000: [NTOS:EX] - Return STATUS_SUCCESS from the SystemExtendedHandleInformation stub to make Process Explorer happy. Fixes infinite loop on AHK bot.

by tfaber＠svn.reactos.org

Author: tfaber Date: Sun Jun 11 11:28:00 2017 New Revision: 75000 URL: http://svn.reactos.org/svn/reactos?rev=75000&view=rev Log: [NTOS:EX] - Return STATUS_SUCCESS from the SystemExtendedHandleInformation stub to make Process Explorer happy. Fixes infinite loop on AHK bot. Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/sysinfo.c?rev=… ============================================================================== --- trunk/reactos/ntoskrnl/ex/sysinfo.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/sysinfo.c [iso-8859-1] Sun Jun 11 11:28:00 2017 @@ -2390,7 +2390,7 @@ /* FIXME */ HandleInformation->Count = 0; - return STATUS_NOT_IMPLEMENTED; + return STATUS_SUCCESS; }

7 years, 3 months

[mjansen] 74999: [WIN32K] Remove an unneeded check at GreGetDIBitsInternal. Patch by Victor Martinez Calvo. CORE-13413 CID 1411972

by mjansen＠svn.reactos.org

Author: mjansen Date: Sun Jun 11 11:18:57 2017 New Revision: 74999 URL: http://svn.reactos.org/svn/reactos?rev=74999&view=rev Log: [WIN32K] Remove an unneeded check at GreGetDIBitsInternal. Patch by Victor Martinez Calvo. CORE-13413 CID 1411972 Modified: trunk/reactos/win32ss/gdi/ntgdi/dibobj.c Modified: trunk/reactos/win32ss/gdi/ntgdi/dibobj.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/ntgdi/dibobj.c… ============================================================================== --- trunk/reactos/win32ss/gdi/ntgdi/dibobj.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/ntgdi/dibobj.c [iso-8859-1] Sun Jun 11 11:18:57 2017 @@ -759,7 +759,7 @@ if (Bits || bpp) { - if ((height == 0 || planes < 0 || width == 0) || (compr && compr != BI_BITFIELDS && compr != BI_RGB)) + if ((height == 0 || width == 0) || (compr && compr != BI_BITFIELDS && compr != BI_RGB)) { ScanLines = 0; goto done;

7 years, 3 months

[mjansen] 74998: [COMCTL32_IMAGELIST] Prevent dereferencing a null pointer.

by mjansen＠svn.reactos.org

Author: mjansen Date: Sun Jun 11 11:08:32 2017 New Revision: 74998 URL: http://svn.reactos.org/svn/reactos?rev=74998&view=rev Log: [COMCTL32_IMAGELIST] Prevent dereferencing a null pointer. Modified: trunk/rostests/winetests/comctl32/imagelist.c Modified: trunk/rostests/winetests/comctl32/imagelist.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/comctl32/imagel… ============================================================================== --- trunk/rostests/winetests/comctl32/imagelist.c [iso-8859-1] (original) +++ trunk/rostests/winetests/comctl32/imagelist.c [iso-8859-1] Sun Jun 11 11:08:32 2017 @@ -2046,9 +2046,9 @@ ok((bmi->bmiColors[i].rgbRed == expect[i].rgbRed && bmi->bmiColors[i].rgbGreen == expect[i].rgbGreen && bmi->bmiColors[i].rgbBlue == expect[i].rgbBlue) || - broken(bmi->bmiColors[i].rgbRed == broken_expect[i].rgbRed && + (broken_expect && broken(bmi->bmiColors[i].rgbRed == broken_expect[i].rgbRed && bmi->bmiColors[i].rgbGreen == broken_expect[i].rgbGreen && - bmi->bmiColors[i].rgbBlue == broken_expect[i].rgbBlue), + bmi->bmiColors[i].rgbBlue == broken_expect[i].rgbBlue)), "%d: %s: got color[%d] %02x %02x %02x expect %02x %02x %02x\n", depth, name, i, bmi->bmiColors[i].rgbRed, bmi->bmiColors[i].rgbGreen, bmi->bmiColors[i].rgbBlue, expect[i].rgbRed, expect[i].rgbGreen, expect[i].rgbBlue);

7 years, 3 months

[mjansen] 74997: [SHELL32] Do not fail CFSFolder::GetDisplayNameOf with a NULL pidl, preventing another crash in shell32:CFSFolder

by mjansen＠svn.reactos.org

Author: mjansen Date: Sun Jun 11 10:39:55 2017 New Revision: 74997 URL: http://svn.reactos.org/svn/reactos?rev=74997&view=rev Log: [SHELL32] Do not fail CFSFolder::GetDisplayNameOf with a NULL pidl, preventing another crash in shell32:CFSFolder Modified: trunk/reactos/dll/win32/shell32/folders/CFSFolder.cpp Modified: trunk/reactos/dll/win32/shell32/folders/CFSFolder.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/folders/… ============================================================================== --- trunk/reactos/dll/win32/shell32/folders/CFSFolder.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/folders/CFSFolder.cpp [iso-8859-1] Sun Jun 11 10:39:55 2017 @@ -634,7 +634,7 @@ HRESULT WINAPI CFSFolder::GetDisplayNameOf(PCUITEMID_CHILD pidl, DWORD dwFlags, LPSTRRET strRet) { - if (!pidl || !strRet) + if (!strRet) return E_INVALIDARG; /* If it is a complex pidl, let the child handle it */ @@ -642,7 +642,7 @@ { return SHELL32_GetDisplayNameOfChild(this, pidl, dwFlags, strRet); } - else if (!pidl->mkid.cb) /* empty pidl */ + else if (pidl && !pidl->mkid.cb) /* empty pidl */ { /* If it is an empty pidl return only the path of the folder */ if ((GET_SHGDN_FOR(dwFlags) & SHGDN_FORPARSING) &&

7 years, 3 months

[mjansen] 74996: [WIN32KNT_APITEST] Do not assert on the result of an unimplemented function.

by mjansen＠svn.reactos.org

Author: mjansen Date: Sun Jun 11 08:51:36 2017 New Revision: 74996 URL: http://svn.reactos.org/svn/reactos?rev=74996&view=rev Log: [WIN32KNT_APITEST] Do not assert on the result of an unimplemented function. Modified: trunk/rostests/apitests/win32nt/ntgdi/NtGdiEnumFontOpen.c Modified: trunk/rostests/apitests/win32nt/ntgdi/NtGdiEnumFontOpen.c URL: http://svn.reactos.org/svn/reactos/trunk/rostests/apitests/win32nt/ntgdi/Nt… ============================================================================== --- trunk/rostests/apitests/win32nt/ntgdi/NtGdiEnumFontOpen.c [iso-8859-1] (original) +++ trunk/rostests/apitests/win32nt/ntgdi/NtGdiEnumFontOpen.c [iso-8859-1] Sun Jun 11 08:51:36 2017 @@ -19,7 +19,9 @@ // FIXME: We should load the font first idEnum = NtGdiEnumFontOpen(hDC, 2, 0, 32, L"Courier", ANSI_CHARSET, &ulCount); - ASSERT(idEnum != 0); + TEST(idEnum != 0); + if (idEnum == 0) + return; /* we should have a gdi handle here */ TEST(GDI_HANDLE_GET_TYPE(idEnum) == GDI_OBJECT_TYPE_ENUMFONT);

7 years, 3 months

[mjansen] 74995: [SHELL32] Don't try to follow a null pointer inside CFSDropTarget, this fixes a crash in shell32:CFSFolder

by mjansen＠svn.reactos.org

Author: mjansen Date: Sun Jun 11 08:38:16 2017 New Revision: 74995 URL: http://svn.reactos.org/svn/reactos?rev=74995&view=rev Log: [SHELL32] Don't try to follow a null pointer inside CFSDropTarget, this fixes a crash in shell32:CFSFolder Modified: trunk/reactos/dll/win32/shell32/droptargets/CFSDropTarget.cpp Modified: trunk/reactos/dll/win32/shell32/droptargets/CFSDropTarget.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/droptarg… ============================================================================== --- trunk/reactos/dll/win32/shell32/droptargets/CFSDropTarget.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/droptargets/CFSDropTarget.cpp [iso-8859-1] Sun Jun 11 08:38:16 2017 @@ -192,6 +192,9 @@ HRESULT WINAPI CFSDropTarget::Initialize(LPWSTR PathTarget) { + if (!PathTarget) + return E_UNEXPECTED; + cfShellIDList = RegisterClipboardFormatW(CFSTR_SHELLIDLIST); if (!cfShellIDList) return E_FAIL; @@ -199,6 +202,7 @@ sPathTarget = (WCHAR *)SHAlloc((wcslen(PathTarget) + 1) * sizeof(WCHAR)); if (!sPathTarget) return E_OUTOFMEMORY; + wcscpy(sPathTarget, PathTarget); return S_OK;

7 years, 3 months

[mjansen] 74994: [SHELL32] Expose IID_CDefView in our CDefView implementation, this fixes a crash on shell32:shlview

by mjansen＠svn.reactos.org

Author: mjansen Date: Sun Jun 11 08:37:03 2017 New Revision: 74994 URL: http://svn.reactos.org/svn/reactos?rev=74994&view=rev Log: [SHELL32] Expose IID_CDefView in our CDefView implementation, this fixes a crash on shell32:shlview Modified: trunk/reactos/dll/win32/shell32/CDefView.cpp Modified: trunk/reactos/dll/win32/shell32/CDefView.cpp URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CDefView… ============================================================================== --- trunk/reactos/dll/win32/shell32/CDefView.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CDefView.cpp [iso-8859-1] Sun Jun 11 08:37:03 2017 @@ -325,6 +325,7 @@ // Windows returns E_NOINTERFACE for IOleWindow // COM_INTERFACE_ENTRY_IID(IID_IOleWindow, IOleWindow) COM_INTERFACE_ENTRY_IID(IID_IShellView, IShellView) + COM_INTERFACE_ENTRY_IID(IID_CDefView, IShellView) COM_INTERFACE_ENTRY_IID(IID_IShellView2, IShellView2) COM_INTERFACE_ENTRY_IID(IID_IFolderView, IFolderView) COM_INTERFACE_ENTRY_IID(IID_IShellFolderView, IShellFolderView)

7 years, 3 months

[tfaber] 74993: [WIN32K:NTUSER] Fix pool use after free during user32:clipboard: - Rename IntIsFormatAvailable to IntGetFormatElement to better reflect what it does - Introduce a new IntIsFormatAva...

by tfaber＠svn.reactos.org

Author: tfaber Date: Sun Jun 11 08:33:36 2017 New Revision: 74993 URL: http://svn.reactos.org/svn/reactos?rev=74993&view=rev Log: [WIN32K:NTUSER] Fix pool use after free during user32:clipboard: - Rename IntIsFormatAvailable to IntGetFormatElement to better reflect what it does - Introduce a new IntIsFormatAvailable that actually returns BOOL as implied by the name - In IntAddSynthesizedFormats, call IntGetFormatElement right before its data is actually used, since IntAddFormatedData will invalidate the element pointer. Thanks to Kamil for the initial investigation on this. CORE-13408 #resolve Modified: trunk/reactos/win32ss/user/ntuser/clipboard.c Modified: trunk/reactos/win32ss/user/ntuser/clipboard.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/ntuser/clipbo… ============================================================================== --- trunk/reactos/win32ss/user/ntuser/clipboard.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/ntuser/clipboard.c [iso-8859-1] Sun Jun 11 08:33:36 2017 @@ -36,9 +36,9 @@ return pWinStaObj; } -/* If format exists, returns a non zero value (pointing to formated object) */ +/* If format exists, returns a non-null value (pointing to formated object) */ static PCLIP FASTCALL -IntIsFormatAvailable(PWINSTATION_OBJECT pWinStaObj, UINT fmt) +IntGetFormatElement(PWINSTATION_OBJECT pWinStaObj, UINT fmt) { DWORD i; @@ -49,6 +49,12 @@ } return NULL; +} + +static BOOL FASTCALL +IntIsFormatAvailable(PWINSTATION_OBJECT pWinStaObj, UINT fmt) +{ + return IntGetFormatElement(pWinStaObj, fmt) != NULL; } static VOID FASTCALL @@ -76,7 +82,7 @@ /* Use existing entry with specified format */ if (!bEnd) - pElement = IntIsFormatAvailable(pWinStaObj, fmt); + pElement = IntGetFormatElement(pWinStaObj, fmt); /* Put new entry at the end if nothing was found */ if (!pElement) @@ -226,7 +232,7 @@ TRACE("IntSynthesizeBitmap(%p, %p)\n", pWinStaObj, pBmEl); - pDibEl = IntIsFormatAvailable(pWinStaObj, CF_DIB); + pDibEl = IntGetFormatElement(pWinStaObj, CF_DIB); ASSERT(pDibEl && !IS_DATA_SYNTHESIZED(pDibEl)); if (!pDibEl->fGlobalHandle) return; @@ -278,17 +284,17 @@ static VOID NTAPI IntAddSynthesizedFormats(PWINSTATION_OBJECT pWinStaObj) { - PCLIP pTextEl, pUniTextEl, pOemTextEl, pLocaleEl, pBmEl, pDibEl; - - pTextEl = IntIsFormatAvailable(pWinStaObj, CF_TEXT); - pOemTextEl = IntIsFormatAvailable(pWinStaObj, CF_OEMTEXT); - pUniTextEl = IntIsFormatAvailable(pWinStaObj, CF_UNICODETEXT); - pLocaleEl = IntIsFormatAvailable(pWinStaObj, CF_LOCALE); - pBmEl = IntIsFormatAvailable(pWinStaObj, CF_BITMAP); - pDibEl = IntIsFormatAvailable(pWinStaObj, CF_DIB); + BOOL bHaveText, bHaveUniText, bHaveOemText, bHaveLocale, bHaveBm, bHaveDib; + + bHaveText = IntIsFormatAvailable(pWinStaObj, CF_TEXT); + bHaveOemText = IntIsFormatAvailable(pWinStaObj, CF_OEMTEXT); + bHaveUniText = IntIsFormatAvailable(pWinStaObj, CF_UNICODETEXT); + bHaveLocale = IntIsFormatAvailable(pWinStaObj, CF_LOCALE); + bHaveBm = IntIsFormatAvailable(pWinStaObj, CF_BITMAP); + bHaveDib = IntIsFormatAvailable(pWinStaObj, CF_DIB); /* Add CF_LOCALE format if we have CF_TEXT */ - if (!pLocaleEl && pTextEl) + if (!bHaveLocale && bHaveText) { PCLIPBOARDDATA pMemObj; HANDLE hMem; @@ -307,25 +313,25 @@ } /* Add CF_TEXT. Note: it is synthesized in user32.dll */ - if (!pTextEl && (pUniTextEl || pOemTextEl)) + if (!bHaveText && (bHaveUniText || bHaveOemText)) IntAddFormatedData(pWinStaObj, CF_TEXT, DATA_SYNTH_USER, FALSE, TRUE); /* Add CF_OEMTEXT. Note: it is synthesized in user32.dll */ - if (!pOemTextEl && (pUniTextEl || pTextEl)) + if (!bHaveOemText && (bHaveUniText || bHaveText)) IntAddFormatedData(pWinStaObj, CF_OEMTEXT, DATA_SYNTH_USER, FALSE, TRUE); /* Add CF_UNICODETEXT. Note: it is synthesized in user32.dll */ - if (!pUniTextEl && (pTextEl || pOemTextEl)) + if (!bHaveUniText && (bHaveText || bHaveOemText)) IntAddFormatedData(pWinStaObj, CF_UNICODETEXT, DATA_SYNTH_USER, FALSE, TRUE); /* Add CF_BITMAP. Note: it is synthesized on demand */ - if (!pBmEl && pDibEl) + if (!bHaveBm && bHaveDib) IntAddFormatedData(pWinStaObj, CF_BITMAP, DATA_SYNTH_KRNL, FALSE, TRUE); /* Note: We need to render the DIB or DIBV5 format as soon as possible because pallette information may change */ - if (!pDibEl && pBmEl) - IntSynthesizeDib(pWinStaObj, pBmEl->hData); + if (!bHaveDib && bHaveBm) + IntSynthesizeDib(pWinStaObj, IntGetFormatElement(pWinStaObj, CF_BITMAP)->hData); } VOID NTAPI @@ -441,7 +447,7 @@ else { /* Return next format */ - pElement = IntIsFormatAvailable(pWinStaObj, fmt); + pElement = IntGetFormatElement(pWinStaObj, fmt); ++pElement; if (pElement < &pWinStaObj->pClipBase[pWinStaObj->cNumClipFormats]) Ret = pElement->fmt; @@ -885,7 +891,7 @@ goto cleanup; } - pElement = IntIsFormatAvailable(pWinStaObj, fmt); + pElement = IntGetFormatElement(pWinStaObj, fmt); if (pElement && IS_DATA_DELAYED(pElement) && pWinStaObj->spwndClipOwner) { /* Send WM_RENDERFORMAT message */ @@ -894,7 +900,7 @@ pWinStaObj->fInDelayedRendering = FALSE; /* Data should be in clipboard now */ - pElement = IntIsFormatAvailable(pWinStaObj, fmt); + pElement = IntGetFormatElement(pWinStaObj, fmt); } if (!pElement || IS_DATA_DELAYED(pElement)) @@ -909,11 +915,11 @@ case CF_UNICODETEXT: case CF_TEXT: case CF_OEMTEXT: - pElement = IntIsFormatAvailable(pWinStaObj, CF_UNICODETEXT); + pElement = IntGetFormatElement(pWinStaObj, CF_UNICODETEXT); if (IS_DATA_SYNTHESIZED(pElement)) - pElement = IntIsFormatAvailable(pWinStaObj, CF_TEXT); + pElement = IntGetFormatElement(pWinStaObj, CF_TEXT); if (IS_DATA_SYNTHESIZED(pElement)) - pElement = IntIsFormatAvailable(pWinStaObj, CF_OEMTEXT); + pElement = IntGetFormatElement(pWinStaObj, CF_OEMTEXT); break; case CF_BITMAP: IntSynthesizeBitmap(pWinStaObj, pElement); @@ -934,7 +940,7 @@ { PCLIP pLocaleEl; - pLocaleEl = IntIsFormatAvailable(pWinStaObj, CF_LOCALE); + pLocaleEl = IntGetFormatElement(pWinStaObj, CF_LOCALE); if (pLocaleEl && !IS_DATA_DELAYED(pLocaleEl)) pgcd->hLocale = pLocaleEl->hData; } @@ -942,7 +948,7 @@ { PCLIP pPaletteEl; - pPaletteEl = IntIsFormatAvailable(pWinStaObj, CF_PALETTE); + pPaletteEl = IntGetFormatElement(pWinStaObj, CF_PALETTE); if (pPaletteEl && !IS_DATA_DELAYED(pPaletteEl)) pgcd->hPalette = pPaletteEl->hData; }

7 years, 3 months

[pschweitzer] 74992: [WS2_32] Don't pass a null ptr at MSAFD to avoid dereference. Fixes crash in ws2_32:sock

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Sun Jun 11 07:56:18 2017 New Revision: 74992 URL: http://svn.reactos.org/svn/reactos?rev=74992&view=rev Log: [WS2_32] Don't pass a null ptr at MSAFD to avoid dereference. Fixes crash in ws2_32:sock Modified: trunk/reactos/dll/win32/ws2_32/src/sockctrl.c Modified: trunk/reactos/dll/win32/ws2_32/src/sockctrl.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ws2_32/src/sockc… ============================================================================== --- trunk/reactos/dll/win32/ws2_32/src/sockctrl.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ws2_32/src/sockctrl.c [iso-8859-1] Sun Jun 11 07:56:18 2017 @@ -39,54 +39,62 @@ /* Get the Socket Context */ if ((Socket = WsSockGetSocket(s))) { - while (TRUE) - { - /* Make the call */ - Status = Socket->Provider->Service.lpWSPConnect(s, - name, - namelen, - NULL, - NULL, - NULL, - NULL, - &ErrorCode); - - /* Check if error code was due to the host not being found */ - if ((Status == SOCKET_ERROR) && - ((ErrorCode == WSAEHOSTUNREACH) || - (ErrorCode == WSAENETUNREACH))) + if (!IsBadReadPtr(name, sizeof(struct sockaddr))) + { + while (TRUE) { - /* Check if we can try again */ - if (TryAgain) + /* Make the call */ + Status = Socket->Provider->Service.lpWSPConnect(s, + name, + namelen, + NULL, + NULL, + NULL, + NULL, + &ErrorCode); + + /* Check if error code was due to the host not being found */ + if ((Status == SOCKET_ERROR) && + ((ErrorCode == WSAEHOSTUNREACH) || + (ErrorCode == WSAENETUNREACH))) { - /* Save the old error code */ - OldErrorCode = ErrorCode; - - /* Make sure we don't retry 3 times */ - TryAgain = FALSE; - - /* Make the RAS Auto-dial attempt */ - if (WSAttemptAutodialAddr(name, namelen)) continue; + /* Check if we can try again */ + if (TryAgain) + { + /* Save the old error code */ + OldErrorCode = ErrorCode; + + /* Make sure we don't retry 3 times */ + TryAgain = FALSE; + + /* Make the RAS Auto-dial attempt */ + if (WSAttemptAutodialAddr(name, namelen)) continue; + } + else + { + /* Restore the error code */ + ErrorCode = OldErrorCode; + } } - else - { - /* Restore the error code */ - ErrorCode = OldErrorCode; - } + + /* Break out of the loop */ + break; } - /* Break out of the loop */ - break; - } - - /* Deference the Socket Context */ - WsSockDereference(Socket); - - /* Return Provider Value */ - if (Status == ERROR_SUCCESS) return Status; - - /* If everything seemed fine, then the WSP call failed itself */ - if (ErrorCode == NO_ERROR) ErrorCode = WSASYSCALLFAILURE; + /* Deference the Socket Context */ + WsSockDereference(Socket); + + /* Return Provider Value */ + if (Status == ERROR_SUCCESS) return Status; + + /* If everything seemed fine, then the WSP call failed itself */ + if (ErrorCode == NO_ERROR) ErrorCode = WSASYSCALLFAILURE; + } + else + { + /* Invalid user pointer */ + ErrorCode = WSAEFAULT; + } } else {

7 years, 3 months

← Newer
1
...
23
24
25
26
27
28
29
...
53
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs June 2017