ReactOS.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
List overview
Download
Ros-diffs
June 2017
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
ros-diffs@reactos.org
20 participants
526 discussions
Start a n
N
ew thread
[akhaldi] 74811: [JSCRIPT] Sync with Wine Staging 2.9. CORE-13362 59c39fa jscript: Added new debug channel printing details and backtrace of unwinded exceptions. 60232cc jscript: Always jump to fin...
by akhaldi@svn.reactos.org
Author: akhaldi Date: Sat Jun 3 22:28:19 2017 New Revision: 74811 URL:
http://svn.reactos.org/svn/reactos?rev=74811&view=rev
Log: [JSCRIPT] Sync with Wine Staging 2.9. CORE-13362 59c39fa jscript: Added new debug channel printing details and backtrace of unwinded exceptions. 60232cc jscript: Always jump to finally block from OP_pop_exept when available. 685cd43 jscript: Pass finally offset instead of catch ident to OP_push_except. 8bd99c3 jscript: Ensure that OP_pop_except is called with proper stack depth. 622eb72 jscript: Added new opcode to enter catch block and use it to setup the scope. b7bb166 jscript: Simplify pop_to_stat implementation. 1731629 jscript: Add __WINE_ALLOC_SIZE attributes to heap_xxx() functions. Modified: trunk/reactos/dll/win32/jscript/compile.c trunk/reactos/dll/win32/jscript/engine.c trunk/reactos/dll/win32/jscript/engine.h trunk/reactos/dll/win32/jscript/jscript.h trunk/reactos/media/doc/README.WINE Modified: trunk/reactos/dll/win32/jscript/compile.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/jscript/compile.…
============================================================================== --- trunk/reactos/dll/win32/jscript/compile.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/jscript/compile.c [iso-8859-1] Sat Jun 3 22:28:19 2017 @@ -1376,24 +1376,30 @@ return S_OK; } -static HRESULT pop_to_stat(compiler_ctx_t *ctx, BOOL var_stack, BOOL scope_stack, statement_ctx_t *stat_ctx) +static HRESULT pop_to_stat(compiler_ctx_t *ctx, statement_ctx_t *stat_ctx) { unsigned stack_pop = 0; statement_ctx_t *iter; + HRESULT hres; for(iter = ctx->stat_ctx; iter != stat_ctx; iter = iter->next) { - if(scope_stack) { - if(iter->using_scope && !push_instr(ctx, OP_pop_scope)) - return E_OUTOFMEMORY; - if(iter->using_except && !push_instr(ctx, OP_pop_except)) - return E_OUTOFMEMORY; + if(iter->using_scope && !push_instr(ctx, OP_pop_scope)) + return E_OUTOFMEMORY; + if(iter->using_except) { + if(stack_pop) { + hres = push_instr_uint(ctx, OP_pop, stack_pop); + if(FAILED(hres)) + return hres; + stack_pop = 0; + } + hres = push_instr_uint(ctx, OP_pop_except, ctx->code_off+1); + if(FAILED(hres)) + return hres; } stack_pop += iter->stack_use; } - if(var_stack && stack_pop) { - HRESULT hres; - + if(stack_pop) { hres = push_instr_uint(ctx, OP_pop, stack_pop); if(FAILED(hres)) return hres; @@ -1448,7 +1454,7 @@ } } - hres = pop_to_stat(ctx, TRUE, TRUE, pop_ctx); + hres = pop_to_stat(ctx, pop_ctx); if(FAILED(hres)) return hres; @@ -1485,7 +1491,7 @@ } } - hres = pop_to_stat(ctx, TRUE, TRUE, pop_ctx->next); + hres = pop_to_stat(ctx, pop_ctx->next); if(FAILED(hres)) return hres; @@ -1502,10 +1508,6 @@ return JS_E_MISPLACED_RETURN; } - hres = pop_to_stat(ctx, TRUE, FALSE, NULL); - if(FAILED(hres)) - return hres; - if(stat->expr) { hres = compile_expression(ctx, stat->expr, TRUE); if(FAILED(hres)) @@ -1514,7 +1516,7 @@ return E_OUTOFMEMORY; } - hres = pop_to_stat(ctx, FALSE, TRUE, NULL); + hres = pop_to_stat(ctx, NULL); if(FAILED(hres)) return hres; @@ -1680,9 +1682,8 @@ /* ECMA-262 3rd Edition 12.14 */ static HRESULT compile_try_statement(compiler_ctx_t *ctx, try_statement_t *stat) { - statement_ctx_t try_ctx = {0, FALSE, TRUE}, catch_ctx = {0, TRUE, FALSE}; - statement_ctx_t finally_ctx = {2, FALSE, FALSE}; - unsigned push_except; + statement_ctx_t try_ctx = {0, FALSE, TRUE}, finally_ctx = {2, FALSE, FALSE}; + unsigned push_except, finally_off = 0, catch_off = 0, pop_except, catch_pop_except = 0; BSTR ident; HRESULT hres; @@ -1698,26 +1699,25 @@ ident = NULL; } - instr_ptr(ctx, push_except)->u.arg[1].bstr = ident; - - if(!stat->catch_block) - try_ctx.stack_use = 2; - hres = compile_statement(ctx, &try_ctx, stat->try_statement); if(FAILED(hres)) return hres; - if(!push_instr(ctx, OP_pop_except)) + pop_except = push_instr(ctx, OP_pop_except); + if(!pop_except) return E_OUTOFMEMORY; if(stat->catch_block) { - unsigned jmp_finally; - - jmp_finally = push_instr(ctx, OP_jmp); - if(!jmp_finally) - return E_OUTOFMEMORY; - - instr_ptr(ctx, push_except)->u.arg[0].uint = ctx->code_off; + statement_ctx_t catch_ctx = {0, TRUE, stat->finally_statement != NULL}; + + if(stat->finally_statement) + catch_ctx.using_except = TRUE; + + catch_off = ctx->code_off; + + hres = push_instr_bstr(ctx, OP_enter_catch, ident); + if(FAILED(hres)) + return hres; hres = compile_statement(ctx, &catch_ctx, stat->catch_block->statement); if(FAILED(hres)) @@ -1726,20 +1726,33 @@ if(!push_instr(ctx, OP_pop_scope)) return E_OUTOFMEMORY; - set_arg_uint(ctx, jmp_finally, ctx->code_off); - }else { - set_arg_uint(ctx, push_except, ctx->code_off); + if(stat->finally_statement) { + catch_pop_except = push_instr(ctx, OP_pop_except); + if(!catch_pop_except) + return E_OUTOFMEMORY; + } } if(stat->finally_statement) { - hres = compile_statement(ctx, stat->catch_block ? NULL : &finally_ctx, stat->finally_statement); - if(FAILED(hres)) - return hres; - - if(!stat->catch_block && !push_instr(ctx, OP_end_finally)) + /* + * finally block expects two elements on the stack, which may be: + * - (true, return_addr) set by OP_pop_except, OP_end_finally jumps back to passed addres + * - (false, exception_value) set when unwinding an exception, which OP_end_finally rethrows + */ + finally_off = ctx->code_off; + hres = compile_statement(ctx, &finally_ctx, stat->finally_statement); + if(FAILED(hres)) + return hres; + + if(!push_instr(ctx, OP_end_finally)) return E_OUTOFMEMORY; } + instr_ptr(ctx, pop_except)->u.arg[0].uint = ctx->code_off; + if(catch_pop_except) + instr_ptr(ctx, catch_pop_except)->u.arg[0].uint = ctx->code_off; + instr_ptr(ctx, push_except)->u.arg[0].uint = catch_off; + instr_ptr(ctx, push_except)->u.arg[1].uint = finally_off; return S_OK; } Modified: trunk/reactos/dll/win32/jscript/engine.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/jscript/engine.c…
============================================================================== --- trunk/reactos/dll/win32/jscript/engine.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/jscript/engine.c [iso-8859-1] Sat Jun 3 22:28:19 2017 @@ -18,6 +18,8 @@ #include "jscript.h" +WINE_DECLARE_DEBUG_CHANNEL(jscript_except); + static const WCHAR booleanW[] = {'b','o','o','l','e','a','n',0}; static const WCHAR functionW[] = {'f','u','n','c','t','i','o','n',0}; static const WCHAR numberW[] = {'n','u','m','b','e','r',0}; @@ -30,7 +32,7 @@ unsigned stack_top; scope_chain_t *scope; unsigned catch_off; - BSTR ident; + unsigned finally_off; except_frame_t *next; }; @@ -891,59 +893,64 @@ /* ECMA-262 3rd Edition 12.14 */ static HRESULT interp_push_except(script_ctx_t *ctx) { - const unsigned arg1 = get_op_uint(ctx, 0); - const BSTR arg2 = get_op_bstr(ctx, 1); + const unsigned catch_off = get_op_uint(ctx, 0); + const unsigned finally_off = get_op_uint(ctx, 1); call_frame_t *frame = ctx->call_ctx; except_frame_t *except; - unsigned stack_top; - - TRACE("\n"); - - stack_top = ctx->stack_top; - - if(!arg2) { + + TRACE("\n"); + + except = heap_alloc(sizeof(*except)); + if(!except) + return E_OUTOFMEMORY; + + except->stack_top = ctx->stack_top; + except->scope = frame->scope; + except->catch_off = catch_off; + except->finally_off = finally_off; + except->next = frame->except_frame; + frame->except_frame = except; + return S_OK; +} + +/* ECMA-262 3rd Edition 12.14 */ +static HRESULT interp_pop_except(script_ctx_t *ctx) +{ + const unsigned ret_off = get_op_uint(ctx, 0); + call_frame_t *frame = ctx->call_ctx; + except_frame_t *except; + unsigned finally_off; + + TRACE("%u\n", ret_off); + + except = frame->except_frame; + assert(except != NULL); + + finally_off = except->finally_off; + frame->except_frame = except->next; + heap_free(except); + + if(finally_off) { HRESULT hres; - hres = stack_push(ctx, jsval_bool(TRUE)); + hres = stack_push(ctx, jsval_number(ret_off)); if(FAILED(hres)) return hres; hres = stack_push(ctx, jsval_bool(TRUE)); if(FAILED(hres)) return hres; - } - - except = heap_alloc(sizeof(*except)); - if(!except) - return E_OUTOFMEMORY; - - except->stack_top = stack_top; - except->scope = frame->scope; - except->catch_off = arg1; - except->ident = arg2; - except->next = frame->except_frame; - frame->except_frame = except; - return S_OK; -} - -/* ECMA-262 3rd Edition 12.14 */ -static HRESULT interp_pop_except(script_ctx_t *ctx) -{ - call_frame_t *frame = ctx->call_ctx; - except_frame_t *except; - - TRACE("\n"); - - except = frame->except_frame; - assert(except != NULL); - - frame->except_frame = except->next; - heap_free(except); + frame->ip = finally_off; + }else { + frame->ip = ret_off; + } + return S_OK; } /* ECMA-262 3rd Edition 12.14 */ static HRESULT interp_end_finally(script_ctx_t *ctx) { + call_frame_t *frame = ctx->call_ctx; jsval_t v; TRACE("\n"); @@ -958,8 +965,30 @@ return DISP_E_EXCEPTION; } - stack_pop(ctx); + v = stack_pop(ctx); + assert(is_number(v)); + frame->ip = get_number(v); return S_OK; +} + +static HRESULT interp_enter_catch(script_ctx_t *ctx) +{ + const BSTR ident = get_op_bstr(ctx, 0); + jsdisp_t *scope_obj; + jsval_t v; + HRESULT hres; + + hres = create_dispex(ctx, NULL, NULL, &scope_obj); + if(FAILED(hres)) + return hres; + + v = stack_pop(ctx); + hres = jsdisp_propput_name(scope_obj, ident, v); + jsval_release(v); + if(SUCCEEDED(hres)) + hres = scope_push(ctx->call_ctx->scope, scope_obj, to_disp(scope_obj), &ctx->call_ctx->scope); + jsdisp_release(scope_obj); + return hres; } /* ECMA-262 3rd Edition 13 */ @@ -2626,13 +2655,71 @@ heap_free(frame); } +static void print_backtrace(script_ctx_t *ctx) +{ + unsigned depth = 0, i; + call_frame_t *frame; + + for(frame = ctx->call_ctx; frame; frame = frame->prev_frame) { + TRACE_(jscript_except)("%u\t", depth); + depth++; + + if(frame->this_obj && frame->this_obj != to_disp(ctx->global) && frame->this_obj != ctx->host_global) + TRACE_(jscript_except)("%p->", frame->this_obj); + TRACE_(jscript_except)("%s(", frame->function->name ? debugstr_w(frame->function->name) : "[unnamed]"); + if(frame->base_scope && frame->base_scope->frame) { + for(i=0; i < frame->argc; i++) { + if(i < frame->function->param_cnt) + TRACE_(jscript_except)("%s%s=%s", i ? ", " : "", + debugstr_w(frame->function->params[i]), + debugstr_jsval(ctx->stack[local_off(frame, -i-1)])); + else + TRACE_(jscript_except)("%s%s", i ? ", " : "", + debugstr_jsval(ctx->stack[local_off(frame, -i-1)])); + } + }else { + TRACE_(jscript_except)("[detached frame]"); + } + TRACE_(jscript_except)(")\n"); + + if(!(frame->flags & EXEC_RETURN_TO_INTERP)) { + TRACE_(jscript_except)("%u\t[native code]\n", depth); + depth++; + } + } +} + static HRESULT unwind_exception(script_ctx_t *ctx, HRESULT exception_hres) { except_frame_t *except_frame; call_frame_t *frame; jsval_t except_val; - BSTR ident; - HRESULT hres; + unsigned catch_off; + HRESULT hres; + + TRACE("%08x\n", exception_hres); + + if(TRACE_ON(jscript_except)) { + jsdisp_t *error_obj; + jsval_t msg; + + static const WCHAR messageW[] = {'m','e','s','s','a','g','e',0}; + + TRACE_(jscript_except)("Exception %08x %s", exception_hres, debugstr_jsval(ctx->ei.val)); + if(jsval_type(ctx->ei.val) == JSV_OBJECT) { + error_obj = to_jsdisp(get_object(ctx->ei.val)); + if(error_obj) { + hres = jsdisp_propget_name(error_obj, messageW, &msg); + if(SUCCEEDED(hres)) { + TRACE_(jscript_except)(" (message %s)", debugstr_jsval(msg)); + jsval_release(msg); + } + } + } + TRACE_(jscript_except)(" in:\n"); + + print_backtrace(ctx); + } for(frame = ctx->call_ctx; !frame->except_frame; frame = ctx->call_ctx) { DWORD flags; @@ -2649,7 +2736,7 @@ } except_frame = frame->except_frame; - frame->except_frame = except_frame->next; + catch_off = except_frame->catch_off; assert(except_frame->stack_top <= ctx->stack_top); stack_popn(ctx, ctx->stack_top - except_frame->stack_top); @@ -2657,38 +2744,27 @@ while(except_frame->scope != frame->scope) scope_pop(&frame->scope); - frame->ip = except_frame->catch_off; + frame->ip = catch_off ? catch_off : except_frame->finally_off; + if(catch_off) assert(frame->bytecode->instrs[frame->ip].op == OP_enter_catch); except_val = ctx->ei.val; ctx->ei.val = jsval_undefined(); clear_ei(ctx); - ident = except_frame->ident; - heap_free(except_frame); - - if(ident) { - jsdisp_t *scope_obj; - - hres = create_dispex(ctx, NULL, NULL, &scope_obj); - if(SUCCEEDED(hres)) { - hres = jsdisp_propput_name(scope_obj, ident, except_val); - if(FAILED(hres)) - jsdisp_release(scope_obj); - } - jsval_release(except_val); - if(FAILED(hres)) - return hres; - - hres = scope_push(frame->scope, scope_obj, to_disp(scope_obj), &frame->scope); - jsdisp_release(scope_obj); + /* keep current except_frame if we're entering catch block with finally block associated */ + if(catch_off && except_frame->finally_off) { + except_frame->catch_off = 0; }else { - hres = stack_push(ctx, except_val); - if(FAILED(hres)) - return hres; - + frame->except_frame = except_frame->next; + heap_free(except_frame); + } + + hres = stack_push(ctx, except_val); + if(FAILED(hres)) + return hres; + + if(!catch_off) hres = stack_push(ctx, jsval_bool(FALSE)); - } - return hres; } @@ -2705,8 +2781,6 @@ op = frame->bytecode->instrs[frame->ip].op; hres = op_funcs[op](ctx); if(FAILED(hres)) { - TRACE("EXCEPTION %08x\n", hres); - hres = unwind_exception(ctx, hres); if(FAILED(hres)) return hres; Modified: trunk/reactos/dll/win32/jscript/engine.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/jscript/engine.h…
============================================================================== --- trunk/reactos/dll/win32/jscript/engine.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/jscript/engine.h [iso-8859-1] Sat Jun 3 22:28:19 2017 @@ -36,7 +36,8 @@ X(delete_ident,1,ARG_BSTR, 0) \ X(div, 1, 0,0) \ X(double, 1, ARG_DBL, 0) \ - X(end_finally,1, 0,0) \ + X(end_finally,0, 0,0) \ + X(enter_catch,1, ARG_BSTR, 0) \ X(eq, 1, 0,0) \ X(eq2, 1, 0,0) \ X(forin, 0, ARG_ADDR, 0) \ @@ -69,11 +70,11 @@ X(obj_prop, 1, ARG_BSTR, 0) \ X(or, 1, 0,0) \ X(pop, 1, ARG_UINT, 0) \ - X(pop_except, 1, 0,0) \ + X(pop_except, 0, ARG_ADDR, 0) \ X(pop_scope, 1, 0,0) \ X(postinc, 1, ARG_INT, 0) \ X(preinc, 1, ARG_INT, 0) \ - X(push_except,1, ARG_ADDR, ARG_BSTR) \ + X(push_except,1, ARG_ADDR, ARG_UINT) \ X(push_ret, 1, 0,0) \ X(push_scope, 1, 0,0) \ X(regexp, 1, ARG_STR, ARG_UINT) \ @@ -89,7 +90,7 @@ X(typeofid, 1, 0,0) \ X(typeofident,1, 0,0) \ X(refval, 1, 0,0) \ - X(ret, 0, 0,0) \ + X(ret, 0, ARG_UINT, 0) \ X(setret, 1, 0,0) \ X(sub, 1, 0,0) \ X(undefined, 1, 0,0) \ Modified: trunk/reactos/dll/win32/jscript/jscript.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/jscript/jscript.…
============================================================================== --- trunk/reactos/dll/win32/jscript/jscript.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/jscript/jscript.h [iso-8859-1] Sat Jun 3 22:28:19 2017 @@ -68,19 +68,19 @@ void heap_pool_free(heap_pool_t*) DECLSPEC_HIDDEN; heap_pool_t *heap_pool_mark(heap_pool_t*) DECLSPEC_HIDDEN; -static inline void *heap_alloc(size_t len) -{ - return HeapAlloc(GetProcessHeap(), 0, len); -} - -static inline void *heap_alloc_zero(size_t len) -{ - return HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len); -} - -static inline void *heap_realloc(void *mem, size_t len) -{ - return HeapReAlloc(GetProcessHeap(), 0, mem, len); +static inline void* __WINE_ALLOC_SIZE(1) heap_alloc(size_t size) +{ + return HeapAlloc(GetProcessHeap(), 0, size); +} + +static inline void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(size_t size) +{ + return HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size); +} + +static inline void* __WINE_ALLOC_SIZE(2) heap_realloc(void *mem, size_t size) +{ + return HeapReAlloc(GetProcessHeap(), 0, mem, size); } static inline BOOL heap_free(void *mem) Modified: trunk/reactos/media/doc/README.WINE URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/media/doc/README.WINE?rev=…
============================================================================== --- trunk/reactos/media/doc/README.WINE [iso-8859-1] (original) +++ trunk/reactos/media/doc/README.WINE [iso-8859-1] Sat Jun 3 22:28:19 2017 @@ -85,7 +85,7 @@ reactos/dll/win32/iphlpapi # Out of sync reactos/dll/win32/itircl # Synced to WineStaging-1.9.11 reactos/dll/win32/itss # Synced to WineStaging-2.2 -reactos/dll/win32/jscript # Synced to WineStaging-2.2 +reactos/dll/win32/jscript # Synced to WineStaging-2.9 reactos/dll/win32/jsproxy # Synced to WineStaging-2.2 reactos/dll/win32/loadperf # Synced to WineStaging-2.2 reactos/dll/win32/lz32 # Synced to WineStaging-1.9.11
7 years, 6 months
1
0
0
0
[akhaldi] 74810: [IMM32_WINETEST] Sync with Wine Staging 2.9. CORE-13362
by akhaldi@svn.reactos.org
Author: akhaldi Date: Sat Jun 3 22:28:03 2017 New Revision: 74810 URL:
http://svn.reactos.org/svn/reactos?rev=74810&view=rev
Log: [IMM32_WINETEST] Sync with Wine Staging 2.9. CORE-13362 Modified: trunk/rostests/winetests/imm32/imm32.c Modified: trunk/rostests/winetests/imm32/imm32.c URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/imm32/imm32.c?r…
============================================================================== --- trunk/rostests/winetests/imm32/imm32.c [iso-8859-1] (original) +++ trunk/rostests/winetests/imm32/imm32.c [iso-8859-1] Sat Jun 3 22:28:03 2017 @@ -1050,7 +1050,7 @@ CW_USEDEFAULT, CW_USEDEFAULT, 240, 120, hwnd1, NULL, GetModuleHandleW(NULL), NULL); default_ime_wnd = ImmGetDefaultIMEWnd(hwnd2); - ok(IsWindow(default_ime_wnd), "Expected IME window existance\n"); + ok(IsWindow(default_ime_wnd), "Expected IME window existence\n"); DestroyWindow(hwnd2); DestroyWindow(hwnd1);
7 years, 6 months
1
0
0
0
[akhaldi] 74809: [INETCOMM_WINETEST] Sync with Wine Staging 2.9. CORE-13362
by akhaldi@svn.reactos.org
Author: akhaldi Date: Sat Jun 3 22:27:55 2017 New Revision: 74809 URL:
http://svn.reactos.org/svn/reactos?rev=74809&view=rev
Log: [INETCOMM_WINETEST] Sync with Wine Staging 2.9. CORE-13362 Modified: trunk/rostests/winetests/inetcomm/mimeole.c Modified: trunk/rostests/winetests/inetcomm/mimeole.c URL:
http://svn.reactos.org/svn/reactos/trunk/rostests/winetests/inetcomm/mimeol…
============================================================================== --- trunk/rostests/winetests/inetcomm/mimeole.c [iso-8859-1] (original) +++ trunk/rostests/winetests/inetcomm/mimeole.c [iso-8859-1] Sat Jun 3 22:27:55 2017 @@ -323,7 +323,12 @@ static ULONG WINAPI Stream_Release(IStream *iface) { TestStream *This = impl_from_IStream(iface); - return InterlockedDecrement(&This->ref); + ULONG ref = InterlockedDecrement(&This->ref); + + if (!ref) + HeapFree(GetProcessHeap(), 0, This); + + return ref; } static HRESULT WINAPI Stream_Read(IStream *iface, void *pv, ULONG cb, ULONG *pcbRead)
7 years, 6 months
1
0
0
0
[akhaldi] 74808: [INETCOMM] Sync with Wine Staging 2.9. CORE-13362 dcc545b inetcomm: Fixed buffer leak on error path (Coverity).
by akhaldi@svn.reactos.org
Author: akhaldi Date: Sat Jun 3 22:27:45 2017 New Revision: 74808 URL:
http://svn.reactos.org/svn/reactos?rev=74808&view=rev
Log: [INETCOMM] Sync with Wine Staging 2.9. CORE-13362 dcc545b inetcomm: Fixed buffer leak on error path (Coverity). Modified: trunk/reactos/dll/win32/inetcomm/protocol.c trunk/reactos/media/doc/README.WINE Modified: trunk/reactos/dll/win32/inetcomm/protocol.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/inetcomm/protoco…
============================================================================== --- trunk/reactos/dll/win32/inetcomm/protocol.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/inetcomm/protocol.c [iso-8859-1] Sat Jun 3 22:27:45 2017 @@ -487,8 +487,10 @@ binding->url[url.mhtml_len] = 0; hres = CreateURLMoniker(NULL, binding->url, &mon); - if(FAILED(hres)) + if(FAILED(hres)) { + heap_free(binding); return hres; + } binding->IBindStatusCallback_iface.lpVtbl = &BindStatusCallbackVtbl; binding->ref = 1; Modified: trunk/reactos/media/doc/README.WINE URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/media/doc/README.WINE?rev=…
============================================================================== --- trunk/reactos/media/doc/README.WINE [iso-8859-1] (original) +++ trunk/reactos/media/doc/README.WINE [iso-8859-1] Sat Jun 3 22:27:45 2017 @@ -78,7 +78,7 @@ reactos/dll/win32/imaadp32.acm # Synced to WineStaging-2.2 reactos/dll/win32/imagehlp # Synced to WineStaging-1.9.11 reactos/dll/win32/imm32 # Synced to Wine-1.7.27 -reactos/dll/win32/inetcomm # Synced to WineStaging-2.2 +reactos/dll/win32/inetcomm # Synced to WineStaging-2.9 reactos/dll/win32/inetmib1 # Synced to WineStaging-1.9.11 reactos/dll/win32/initpki # Synced to WineStaging-1.9.11 reactos/dll/win32/inseng # Synced to WineStaging-2.2
7 years, 6 months
1
0
0
0
[akhaldi] 74807: [IEFRAME] Sync with Wine Staging 2.9. CORE-13362 2bb8458 ieframe: Return DISP_E_UNKNOWNNAME in IShellUIHelper2::GetIDsOfNames. bd8bd97 ieframe: Fix IEWinMain spec file entry. f4993...
by akhaldi@svn.reactos.org
Author: akhaldi Date: Sat Jun 3 22:27:36 2017 New Revision: 74807 URL:
http://svn.reactos.org/svn/reactos?rev=74807&view=rev
Log: [IEFRAME] Sync with Wine Staging 2.9. CORE-13362 2bb8458 ieframe: Return DISP_E_UNKNOWNNAME in IShellUIHelper2::GetIDsOfNames. bd8bd97 ieframe: Fix IEWinMain spec file entry. f499395 ieframe: Add __WINE_ALLOC_SIZE attributes to heap_xxx() functions. Modified: trunk/reactos/dll/win32/ieframe/ieframe.h trunk/reactos/dll/win32/ieframe/ieframe.spec trunk/reactos/dll/win32/ieframe/shelluihelper.c trunk/reactos/media/doc/README.WINE Modified: trunk/reactos/dll/win32/ieframe/ieframe.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ieframe/ieframe.…
============================================================================== --- trunk/reactos/dll/win32/ieframe/ieframe.h [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ieframe/ieframe.h [iso-8859-1] Sat Jun 3 22:27:36 2017 @@ -348,19 +348,19 @@ InterlockedDecrement(&module_ref); } -static inline void *heap_alloc(size_t len) -{ - return HeapAlloc(GetProcessHeap(), 0, len); -} - -static inline void *heap_alloc_zero(size_t len) -{ - return HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, len); -} - -static inline void *heap_realloc(void *mem, size_t len) -{ - return HeapReAlloc(GetProcessHeap(), 0, mem, len); +static inline void* __WINE_ALLOC_SIZE(1) heap_alloc(size_t size) +{ + return HeapAlloc(GetProcessHeap(), 0, size); +} + +static inline void* __WINE_ALLOC_SIZE(1) heap_alloc_zero(size_t size) +{ + return HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size); +} + +static inline void* __WINE_ALLOC_SIZE(2) heap_realloc(void *mem, size_t size) +{ + return HeapReAlloc(GetProcessHeap(), 0, mem, size); } static inline BOOL heap_free(void *mem) Modified: trunk/reactos/dll/win32/ieframe/ieframe.spec URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ieframe/ieframe.…
============================================================================== --- trunk/reactos/dll/win32/ieframe/ieframe.spec [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ieframe/ieframe.spec [iso-8859-1] Sat Jun 3 22:27:36 2017 @@ -1,5 +1,5 @@ # ordinal exports -101 stdcall -noname IEWinMain(str long) +101 stdcall -noname IEWinMain(wstr long) @ stdcall -private DllCanUnloadNow() @ stdcall -private DllGetClassObject(ptr ptr ptr) Modified: trunk/reactos/dll/win32/ieframe/shelluihelper.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/ieframe/shelluih…
============================================================================== --- trunk/reactos/dll/win32/ieframe/shelluihelper.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/ieframe/shelluihelper.c [iso-8859-1] Sat Jun 3 22:27:36 2017 @@ -98,9 +98,13 @@ LCID lcid, DISPID *rgDispId) { ShellUIHelper *This = impl_from_IShellUIHelper2(iface); - FIXME("(%p)->(%s %p %d %d %p)\n", This, debugstr_guid(riid), rgszNames, cNames, - lcid, rgDispId); - return E_NOTIMPL; + unsigned i; + + FIXME("(%p)->(%s %p %d %d %p)\n", This, debugstr_guid(riid), rgszNames, cNames, lcid, rgDispId); + for(i = 0; i < cNames; i++) + FIXME("%s\n", debugstr_w(rgszNames[i])); + + return DISP_E_UNKNOWNNAME; } static HRESULT WINAPI ShellUIHelper2_Invoke(IShellUIHelper2 *iface, DISPID dispIdMember, Modified: trunk/reactos/media/doc/README.WINE URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/media/doc/README.WINE?rev=…
============================================================================== --- trunk/reactos/media/doc/README.WINE [iso-8859-1] (original) +++ trunk/reactos/media/doc/README.WINE [iso-8859-1] Sat Jun 3 22:27:36 2017 @@ -74,7 +74,7 @@ reactos/dll/win32/hnetcfg # Synced to WineStaging-1.9.16 reactos/dll/win32/httpapi # Synced to WineStaging-2.9 reactos/dll/win32/iccvid # Synced to WineStaging-2.2 -reactos/dll/win32/ieframe # Synced to WineStaging-2.2 +reactos/dll/win32/ieframe # Synced to WineStaging-2.9 reactos/dll/win32/imaadp32.acm # Synced to WineStaging-2.2 reactos/dll/win32/imagehlp # Synced to WineStaging-1.9.11 reactos/dll/win32/imm32 # Synced to Wine-1.7.27
7 years, 6 months
1
0
0
0
[pschweitzer] 74806: [UDFS] Don't use perf prints
by pschweitzer@svn.reactos.org
Author: pschweitzer Date: Sat Jun 3 21:56:32 2017 New Revision: 74806 URL:
http://svn.reactos.org/svn/reactos?rev=74806&view=rev
Log: [UDFS] Don't use perf prints Modified: trunk/reactos/drivers/filesystems/udfs/udf_dbg.h Modified: trunk/reactos/drivers/filesystems/udfs/udf_dbg.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
============================================================================== --- trunk/reactos/drivers/filesystems/udfs/udf_dbg.h [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/udfs/udf_dbg.h [iso-8859-1] Sat Jun 3 21:56:32 2017 @@ -39,7 +39,7 @@ //#define UDF_SIMULATE_WRITES -#define USE_PERF_PRINT +//#define USE_PERF_PRINT #define USE_KD_PRINT #define USE_MM_PRINT
7 years, 6 months
1
0
0
0
[pschweitzer] 74805: [UDFS] Revert r74780: it indeed works here, but when the problem happens in other places (it does!) where it cannot be solved that way, we're doomed. It will be required to fin...
by pschweitzer@svn.reactos.org
Author: pschweitzer Date: Sat Jun 3 21:50:29 2017 New Revision: 74805 URL:
http://svn.reactos.org/svn/reactos?rev=74805&view=rev
Log: [UDFS] Revert r74780: it indeed works here, but when the problem happens in other places (it does!) where it cannot be solved that way, we're doomed. It will be required to find an appropriate solution... CORE-4375 Modified: trunk/reactos/drivers/filesystems/udfs/close.cpp Modified: trunk/reactos/drivers/filesystems/udfs/close.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/c…
============================================================================== --- trunk/reactos/drivers/filesystems/udfs/close.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/udfs/close.cpp [iso-8859-1] Sat Jun 3 21:50:29 2017 @@ -1109,6 +1109,7 @@ { PtrUDFIrpContextLite IrpContextLite; BOOLEAN StartWorker = FALSE; + BOOLEAN AcquiredVcb = FALSE; NTSTATUS RC; AdPrint((" UDFQueueDelayedClose\n")); @@ -1118,6 +1119,7 @@ UDFAcquireResourceExclusive(&(UDFGlobalData.DelayedCloseResource), TRUE); UDFAcquireResourceShared(&(Fcb->Vcb->VCBResource), TRUE); + AcquiredVcb = TRUE; if(Fcb->FCBFlags & UDF_FCB_DELETE_ON_CLOSE) { try_return(RC = STATUS_DELETE_PENDING); @@ -1181,7 +1183,9 @@ if(!NT_SUCCESS(RC)) { Fcb->FCBFlags &= ~UDF_FCB_DELAY_CLOSE; } - UDFReleaseResource(&(Fcb->Vcb->VCBResource)); + if(AcquiredVcb) { + UDFReleaseResource(&(Fcb->Vcb->VCBResource)); + } // Release DelayedCloseResource UDFReleaseResource(&(UDFGlobalData.DelayedCloseResource)); } _SEH2_END;
7 years, 6 months
1
0
0
0
[pschweitzer] 74804: [UDFS] Attempt to fix MSVC build CORE-4375
by pschweitzer@svn.reactos.org
Author: pschweitzer Date: Sat Jun 3 21:47:53 2017 New Revision: 74804 URL:
http://svn.reactos.org/svn/reactos?rev=74804&view=rev
Log: [UDFS] Attempt to fix MSVC build CORE-4375 Modified: trunk/reactos/drivers/filesystems/udfs/env_spec.cpp trunk/reactos/drivers/filesystems/udfs/fscntrl.cpp trunk/reactos/drivers/filesystems/udfs/udf_info/mount.cpp Modified: trunk/reactos/drivers/filesystems/udfs/env_spec.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/e…
============================================================================== --- trunk/reactos/drivers/filesystems/udfs/env_spec.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/udfs/env_spec.cpp [iso-8859-1] Sat Jun 3 21:47:53 2017 @@ -307,7 +307,7 @@ KeQuerySystemTime((PLARGE_INTEGER)&IoEnterTime); #endif //MEASURE_IO_PERFORMANCE -#if defined DBG || defined USE_PERF_PRINT +#if defined UDF_DBG || defined USE_PERF_PRINT ULONG Lba = (ULONG)(Offset>>0xb); // ASSERT(!(Lba & (32-1))); PerfPrint(("UDFPhWrite: Length: %x Lba: %lx\n",Length>>0xb,Lba)); Modified: trunk/reactos/drivers/filesystems/udfs/fscntrl.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/f…
============================================================================== --- trunk/reactos/drivers/filesystems/udfs/fscntrl.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/udfs/fscntrl.cpp [iso-8859-1] Sat Jun 3 21:47:53 2017 @@ -835,7 +835,7 @@ Irp->Tail.Overlay.CurrentStackLocation++; // Now call the appropriate file system driver with the request. - return IoCallDriver( filterDevExt->lowerFSDeviceObject, Irp ); + RC = IoCallDriver( filterDevExt->lowerFSDeviceObject, Irp ); } Modified: trunk/reactos/drivers/filesystems/udfs/udf_info/mount.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
============================================================================== --- trunk/reactos/drivers/filesystems/udfs/udf_info/mount.cpp [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/udfs/udf_info/mount.cpp [iso-8859-1] Sat Jun 3 21:47:53 2017 @@ -2333,12 +2333,14 @@ int8* Buf ) { +#ifdef UDF_DBG ImpUseVolDesc* iuvd = (ImpUseVolDesc*)Buf; ImpUseVolDescImpUse* iuvdiu = (ImpUseVolDescImpUse*)&(iuvd->impUse); UDFPrint(("UDF: Imp Use Vol Desc:\n")); UDFPrint((" volDescSeqNum = %x\n", iuvd->volDescSeqNum)); UDFPrint(("UDF: Imp Use Vol Desc Imp Use:\n")); KdDump(iuvdiu, sizeof(ImpUseVolDescImpUse)); +#endif return STATUS_SUCCESS; } // UDFLoadImpUseVolDesc()
7 years, 6 months
1
0
0
0
[hbelusca] 74803: [NTDLL][USER32]: Stub out two APIs that are called by Win32 dlls: - ntdll.dll: RtlConvertUiListToApiList(), which is a helper used by netapi32.dll; - user32.dll: GetWinStationInfo...
by hbelusca@svn.reactos.org
Author: hbelusca Date: Sat Jun 3 20:26:26 2017 New Revision: 74803 URL:
http://svn.reactos.org/svn/reactos?rev=74803&view=rev
Log: [NTDLL][USER32]: Stub out two APIs that are called by Win32 dlls: - ntdll.dll: RtlConvertUiListToApiList(), which is a helper used by netapi32.dll; - user32.dll: GetWinStationInfo() (that just calls into win32k), which is called by e.g. winmm.dll . Added: trunk/reactos/dll/ntdll/rtl/uilist.c (with props) Modified: trunk/reactos/dll/ntdll/CMakeLists.txt trunk/reactos/dll/ntdll/def/ntdll.spec trunk/reactos/win32ss/user/user32/misc/winsta.c trunk/reactos/win32ss/user/user32/user32.spec Modified: trunk/reactos/dll/ntdll/CMakeLists.txt URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/CMakeLists.txt?r…
============================================================================== --- trunk/reactos/dll/ntdll/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/CMakeLists.txt [iso-8859-1] Sat Jun 3 20:26:26 2017 @@ -20,6 +20,7 @@ ldr/ldrpe.c ldr/ldrutils.c rtl/libsupp.c + rtl/uilist.c rtl/version.c etw/trace.c include/ntdll.h) Modified: trunk/reactos/dll/ntdll/def/ntdll.spec URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/def/ntdll.spec?r…
============================================================================== --- trunk/reactos/dll/ntdll/def/ntdll.spec [iso-8859-1] (original) +++ trunk/reactos/dll/ntdll/def/ntdll.spec [iso-8859-1] Sat Jun 3 20:26:26 2017 @@ -502,7 +502,7 @@ 501 stdcall RtlConvertSharedToExclusive(ptr) 502 stdcall RtlConvertSidToUnicodeString(ptr ptr long) 503 stdcall RtlConvertToAutoInheritSecurityObject(ptr ptr ptr ptr long ptr) -# stdcall RtlConvertUiListToApiList +504 stdcall RtlConvertUiListToApiList(ptr ptr long) 505 stdcall -arch=win32 -ret64 RtlConvertUlongToLargeInteger(long) 506 stdcall RtlCopyLuid(ptr ptr) 507 stdcall RtlCopyLuidAndAttributesArray(long ptr ptr) Added: trunk/reactos/dll/ntdll/rtl/uilist.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/ntdll/rtl/uilist.c?rev…
============================================================================== --- trunk/reactos/dll/ntdll/rtl/uilist.c (added) +++ trunk/reactos/dll/ntdll/rtl/uilist.c [iso-8859-1] Sat Jun 3 20:26:26 2017 @@ -0,0 +1,40 @@ +/* + * COPYRIGHT: See COPYING in the top level directory + * PROJECT: ReactOS NT User-Mode DLL + * FILE: lib/ntdll/rtl/uilist.c + * PURPOSE: RTL UI to API network computers list conversion. + * Helper for NETAPI32.DLL + * PROGRAMMERS: Hermes Belusca-Maito + */ + +/* INCLUDES *****************************************************************/ + +#include <ntdll.h> + +#define NDEBUG +#include <debug.h> + +/* FUNCTIONS ***************************************************************/ + +/* + * @unimplemented + */ +NTSTATUS +NTAPI +RtlConvertUiListToApiList( + IN PUNICODE_STRING UiList, + OUT PUNICODE_STRING ApiList, + IN BOOLEAN SpaceAsSeparator) +{ + DPRINT1("RtlConvertUiListToApiList(%wZ, 0x%p, %s) called\n", + UiList, &ApiList, SpaceAsSeparator ? "true" : "false"); + UNIMPLEMENTED; + /* + * Experiments show that returning a success code but setting the + * ApiList length to zero is better than returning a failure code. + */ + RtlInitEmptyUnicodeString(ApiList, NULL, 0); + return STATUS_SUCCESS; +} + +/* EOF */ Propchange: trunk/reactos/dll/ntdll/rtl/uilist.c ------------------------------------------------------------------------------ svn:eol-style = native Modified: trunk/reactos/win32ss/user/user32/misc/winsta.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/misc/w…
============================================================================== --- trunk/reactos/win32ss/user/user32/misc/winsta.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/misc/winsta.c [iso-8859-1] Sat Jun 3 20:26:26 2017 @@ -286,6 +286,16 @@ /* + * @unimplemented on Win32k side + */ +BOOL WINAPI +GetWinStationInfo(PVOID pUnknown) +{ + return (BOOL)NtUserCallOneParam((DWORD_PTR)pUnknown, ONEPARAM_ROUTINE_GETWINSTAINFO); +} + + +/* * @implemented */ HWINSTA WINAPI Modified: trunk/reactos/win32ss/user/user32/user32.spec URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/user/user32/user32…
============================================================================== --- trunk/reactos/win32ss/user/user32/user32.spec [iso-8859-1] (original) +++ trunk/reactos/win32ss/user/user32/user32.spec [iso-8859-1] Sat Jun 3 20:26:26 2017 @@ -366,7 +366,7 @@ 363 stdcall GetUserObjectInformationA(long long ptr long ptr) 364 stdcall GetUserObjectInformationW(long long ptr long ptr) NtUserGetObjectInformation 365 stdcall GetUserObjectSecurity (long ptr ptr long ptr) -# GetWinStationInfo +366 stdcall GetWinStationInfo(ptr) 367 stdcall GetWindow(long long) 368 stdcall GetWindowContextHelpId(long) 369 stdcall GetWindowDC(long) NtUserGetWindowDC
7 years, 6 months
1
0
0
0
[pschweitzer] 74802: [UDFS] Make the driver really less verbose by introducing two macros UDFPrint and UDFPrintErr So far, because of sed -i, almost all KdPrint became UDFPrint. It would be interes...
by pschweitzer@svn.reactos.org
Author: pschweitzer Date: Sat Jun 3 20:09:21 2017 New Revision: 74802 URL:
http://svn.reactos.org/svn/reactos?rev=74802&view=rev
Log: [UDFS] Make the driver really less verbose by introducing two macros UDFPrint and UDFPrintErr So far, because of sed -i, almost all KdPrint became UDFPrint. It would be interesting to promote some to UDFPrintErr (if someone motivated ;-)) CORE-4375 Modified: trunk/reactos/drivers/filesystems/udfs/Include/Sys_spec_lib.cpp trunk/reactos/drivers/filesystems/udfs/Include/env_spec_w32.cpp trunk/reactos/drivers/filesystems/udfs/Include/getopt.cpp trunk/reactos/drivers/filesystems/udfs/Include/mem_tools.cpp trunk/reactos/drivers/filesystems/udfs/Include/misc_common.cpp trunk/reactos/drivers/filesystems/udfs/Include/phys_lib.cpp trunk/reactos/drivers/filesystems/udfs/Include/regtools.cpp trunk/reactos/drivers/filesystems/udfs/Include/wcache_lib.cpp trunk/reactos/drivers/filesystems/udfs/cleanup.cpp trunk/reactos/drivers/filesystems/udfs/close.cpp trunk/reactos/drivers/filesystems/udfs/create.cpp trunk/reactos/drivers/filesystems/udfs/devcntrl.cpp trunk/reactos/drivers/filesystems/udfs/dircntrl.cpp trunk/reactos/drivers/filesystems/udfs/dldetect.cpp trunk/reactos/drivers/filesystems/udfs/env_spec.cpp trunk/reactos/drivers/filesystems/udfs/fastio.cpp trunk/reactos/drivers/filesystems/udfs/fileinfo.cpp trunk/reactos/drivers/filesystems/udfs/filter.cpp trunk/reactos/drivers/filesystems/udfs/flush.cpp trunk/reactos/drivers/filesystems/udfs/fscntrl.cpp trunk/reactos/drivers/filesystems/udfs/lockctrl.cpp trunk/reactos/drivers/filesystems/udfs/misc.cpp trunk/reactos/drivers/filesystems/udfs/pnp.cpp trunk/reactos/drivers/filesystems/udfs/read.cpp trunk/reactos/drivers/filesystems/udfs/secursup.cpp trunk/reactos/drivers/filesystems/udfs/shutdown.cpp trunk/reactos/drivers/filesystems/udfs/udf_dbg.cpp trunk/reactos/drivers/filesystems/udfs/udf_info/alloc.cpp trunk/reactos/drivers/filesystems/udfs/udf_info/dirtree.cpp trunk/reactos/drivers/filesystems/udfs/udf_info/extent.cpp trunk/reactos/drivers/filesystems/udfs/udf_info/mount.cpp trunk/reactos/drivers/filesystems/udfs/udf_info/phys_eject.cpp trunk/reactos/drivers/filesystems/udfs/udf_info/remap.cpp trunk/reactos/drivers/filesystems/udfs/udf_info/udf_info.cpp trunk/reactos/drivers/filesystems/udfs/udffs.h trunk/reactos/drivers/filesystems/udfs/udfinit.cpp trunk/reactos/drivers/filesystems/udfs/unload.cpp trunk/reactos/drivers/filesystems/udfs/verfysup.cpp trunk/reactos/drivers/filesystems/udfs/volinfo.cpp trunk/reactos/drivers/filesystems/udfs/write.cpp [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/drivers/filesystems/udfs/Include/Sys_spec_lib.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/I…
Modified: trunk/reactos/drivers/filesystems/udfs/Include/env_spec_w32.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/I…
Modified: trunk/reactos/drivers/filesystems/udfs/Include/getopt.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/I…
Modified: trunk/reactos/drivers/filesystems/udfs/Include/mem_tools.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/I…
Modified: trunk/reactos/drivers/filesystems/udfs/Include/misc_common.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/I…
Modified: trunk/reactos/drivers/filesystems/udfs/Include/phys_lib.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/I…
Modified: trunk/reactos/drivers/filesystems/udfs/Include/regtools.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/I…
Modified: trunk/reactos/drivers/filesystems/udfs/Include/wcache_lib.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/I…
Modified: trunk/reactos/drivers/filesystems/udfs/cleanup.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/c…
Modified: trunk/reactos/drivers/filesystems/udfs/close.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/c…
Modified: trunk/reactos/drivers/filesystems/udfs/create.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/c…
Modified: trunk/reactos/drivers/filesystems/udfs/devcntrl.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/d…
Modified: trunk/reactos/drivers/filesystems/udfs/dircntrl.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/d…
Modified: trunk/reactos/drivers/filesystems/udfs/dldetect.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/d…
Modified: trunk/reactos/drivers/filesystems/udfs/env_spec.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/e…
Modified: trunk/reactos/drivers/filesystems/udfs/fastio.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/f…
Modified: trunk/reactos/drivers/filesystems/udfs/fileinfo.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/f…
Modified: trunk/reactos/drivers/filesystems/udfs/filter.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/f…
Modified: trunk/reactos/drivers/filesystems/udfs/flush.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/f…
Modified: trunk/reactos/drivers/filesystems/udfs/fscntrl.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/f…
Modified: trunk/reactos/drivers/filesystems/udfs/lockctrl.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/l…
Modified: trunk/reactos/drivers/filesystems/udfs/misc.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/m…
Modified: trunk/reactos/drivers/filesystems/udfs/pnp.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/p…
Modified: trunk/reactos/drivers/filesystems/udfs/read.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/r…
Modified: trunk/reactos/drivers/filesystems/udfs/secursup.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/s…
Modified: trunk/reactos/drivers/filesystems/udfs/shutdown.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/s…
Modified: trunk/reactos/drivers/filesystems/udfs/udf_dbg.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
Modified: trunk/reactos/drivers/filesystems/udfs/udf_info/alloc.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
Modified: trunk/reactos/drivers/filesystems/udfs/udf_info/dirtree.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
Modified: trunk/reactos/drivers/filesystems/udfs/udf_info/extent.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
Modified: trunk/reactos/drivers/filesystems/udfs/udf_info/mount.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
Modified: trunk/reactos/drivers/filesystems/udfs/udf_info/phys_eject.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
Modified: trunk/reactos/drivers/filesystems/udfs/udf_info/remap.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
Modified: trunk/reactos/drivers/filesystems/udfs/udf_info/udf_info.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
Modified: trunk/reactos/drivers/filesystems/udfs/udffs.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
Modified: trunk/reactos/drivers/filesystems/udfs/udfinit.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
Modified: trunk/reactos/drivers/filesystems/udfs/unload.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/u…
Modified: trunk/reactos/drivers/filesystems/udfs/verfysup.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/v…
Modified: trunk/reactos/drivers/filesystems/udfs/volinfo.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/v…
Modified: trunk/reactos/drivers/filesystems/udfs/write.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/udfs/w…
7 years, 6 months
1
0
0
0
← Newer
1
...
42
43
44
45
46
47
48
...
53
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
Results per page:
10
25
50
100
200