ReactOS.org
Sign In
Sign Up
Sign In
Sign Up
Manage this list
×
Keyboard Shortcuts
Thread View
j
: Next unread message
k
: Previous unread message
j a
: Jump to all threads
j l
: Jump to MailingList overview
2024
December
November
October
September
August
July
June
May
April
March
February
January
2023
December
November
October
September
August
July
June
May
April
March
February
January
2022
December
November
October
September
August
July
June
May
April
March
February
January
2021
December
November
October
September
August
July
June
May
April
March
February
January
2020
December
November
October
September
August
July
June
May
April
March
February
January
2019
December
November
October
September
August
July
June
May
April
March
February
January
2018
December
November
October
September
August
July
June
May
April
March
February
January
2017
December
November
October
September
August
July
June
May
April
March
February
January
2016
December
November
October
September
August
July
June
May
April
March
February
January
2015
December
November
October
September
August
July
June
May
April
March
February
January
2014
December
November
October
September
August
July
June
May
April
March
February
January
2013
December
November
October
September
August
July
June
May
April
March
February
January
2012
December
November
October
September
August
July
June
May
April
March
February
January
2011
December
November
October
September
August
July
June
May
April
March
February
January
2010
December
November
October
September
August
July
June
May
April
March
February
January
2009
December
November
October
September
August
July
June
May
April
March
February
January
2008
December
November
October
September
August
July
June
May
April
March
February
January
2007
December
November
October
September
August
July
June
May
April
March
February
January
2006
December
November
October
September
August
July
June
May
April
March
February
January
2005
December
November
October
September
August
July
June
May
April
March
February
January
2004
December
November
October
September
August
July
June
May
April
March
February
List overview
Download
Ros-diffs
August 2017
----- 2024 -----
December 2024
November 2024
October 2024
September 2024
August 2024
July 2024
June 2024
May 2024
April 2024
March 2024
February 2024
January 2024
----- 2023 -----
December 2023
November 2023
October 2023
September 2023
August 2023
July 2023
June 2023
May 2023
April 2023
March 2023
February 2023
January 2023
----- 2022 -----
December 2022
November 2022
October 2022
September 2022
August 2022
July 2022
June 2022
May 2022
April 2022
March 2022
February 2022
January 2022
----- 2021 -----
December 2021
November 2021
October 2021
September 2021
August 2021
July 2021
June 2021
May 2021
April 2021
March 2021
February 2021
January 2021
----- 2020 -----
December 2020
November 2020
October 2020
September 2020
August 2020
July 2020
June 2020
May 2020
April 2020
March 2020
February 2020
January 2020
----- 2019 -----
December 2019
November 2019
October 2019
September 2019
August 2019
July 2019
June 2019
May 2019
April 2019
March 2019
February 2019
January 2019
----- 2018 -----
December 2018
November 2018
October 2018
September 2018
August 2018
July 2018
June 2018
May 2018
April 2018
March 2018
February 2018
January 2018
----- 2017 -----
December 2017
November 2017
October 2017
September 2017
August 2017
July 2017
June 2017
May 2017
April 2017
March 2017
February 2017
January 2017
----- 2016 -----
December 2016
November 2016
October 2016
September 2016
August 2016
July 2016
June 2016
May 2016
April 2016
March 2016
February 2016
January 2016
----- 2015 -----
December 2015
November 2015
October 2015
September 2015
August 2015
July 2015
June 2015
May 2015
April 2015
March 2015
February 2015
January 2015
----- 2014 -----
December 2014
November 2014
October 2014
September 2014
August 2014
July 2014
June 2014
May 2014
April 2014
March 2014
February 2014
January 2014
----- 2013 -----
December 2013
November 2013
October 2013
September 2013
August 2013
July 2013
June 2013
May 2013
April 2013
March 2013
February 2013
January 2013
----- 2012 -----
December 2012
November 2012
October 2012
September 2012
August 2012
July 2012
June 2012
May 2012
April 2012
March 2012
February 2012
January 2012
----- 2011 -----
December 2011
November 2011
October 2011
September 2011
August 2011
July 2011
June 2011
May 2011
April 2011
March 2011
February 2011
January 2011
----- 2010 -----
December 2010
November 2010
October 2010
September 2010
August 2010
July 2010
June 2010
May 2010
April 2010
March 2010
February 2010
January 2010
----- 2009 -----
December 2009
November 2009
October 2009
September 2009
August 2009
July 2009
June 2009
May 2009
April 2009
March 2009
February 2009
January 2009
----- 2008 -----
December 2008
November 2008
October 2008
September 2008
August 2008
July 2008
June 2008
May 2008
April 2008
March 2008
February 2008
January 2008
----- 2007 -----
December 2007
November 2007
October 2007
September 2007
August 2007
July 2007
June 2007
May 2007
April 2007
March 2007
February 2007
January 2007
----- 2006 -----
December 2006
November 2006
October 2006
September 2006
August 2006
July 2006
June 2006
May 2006
April 2006
March 2006
February 2006
January 2006
----- 2005 -----
December 2005
November 2005
October 2005
September 2005
August 2005
July 2005
June 2005
May 2005
April 2005
March 2005
February 2005
January 2005
----- 2004 -----
December 2004
November 2004
October 2004
September 2004
August 2004
July 2004
June 2004
May 2004
April 2004
March 2004
February 2004
ros-diffs@reactos.org
22 participants
262 discussions
Start a n
N
ew thread
[tkreuzer] 75606: [NDK] Fix prototype of Nt/ZwQuerySystemInformation
by tkreuzer@svn.reactos.org
Author: tkreuzer Date: Fri Aug 18 08:44:08 2017 New Revision: 75606 URL:
http://svn.reactos.org/svn/reactos?rev=75606&view=rev
Log: [NDK] Fix prototype of Nt/ZwQuerySystemInformation Modified: trunk/reactos/dll/win32/kernel32/client/time.c trunk/reactos/ntoskrnl/ex/sysinfo.c trunk/reactos/sdk/include/ndk/exfuncs.h trunk/reactos/win32ss/drivers/videoprt/videoprt.c Modified: trunk/reactos/dll/win32/kernel32/client/time.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/…
============================================================================== --- trunk/reactos/dll/win32/kernel32/client/time.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/time.c [iso-8859-1] Fri Aug 18 08:44:08 2017 @@ -534,7 +534,7 @@ { PSYSTEM_PROCESSOR_PERFORMANCE_INFORMATION ProcPerfInfo; LARGE_INTEGER TotalUserTime, TotalKernTime, TotalIdleTime; - SIZE_T BufferSize, ReturnLength; + ULONG BufferSize, ReturnLength; CCHAR i; NTSTATUS Status; Modified: trunk/reactos/ntoskrnl/ex/sysinfo.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/ex/sysinfo.c?rev=…
============================================================================== --- trunk/reactos/ntoskrnl/ex/sysinfo.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/ex/sysinfo.c [iso-8859-1] Fri Aug 18 08:44:08 2017 @@ -1922,7 +1922,7 @@ { return STATUS_INFO_LENGTH_MISMATCH; } - + /* FIXME */ DPRINT1("NtQuerySystemInformation - SystemPowerInformation not implemented\n"); return STATUS_NOT_IMPLEMENTED; @@ -2599,11 +2599,14 @@ /* * @implemented */ -NTSTATUS NTAPI -NtQuerySystemInformation(IN SYSTEM_INFORMATION_CLASS SystemInformationClass, - OUT PVOID SystemInformation, - IN ULONG Length, - OUT PULONG UnsafeResultLength) +__kernel_entry +NTSTATUS +NTAPI +NtQuerySystemInformation( + _In_ SYSTEM_INFORMATION_CLASS SystemInformationClass, + _Out_writes_bytes_to_opt_(SystemInformationLength, *ReturnLength) PVOID SystemInformation, + _In_ ULONG Length, + _Out_opt_ PULONG UnsafeResultLength) { KPROCESSOR_MODE PreviousMode; ULONG ResultLength = 0; Modified: trunk/reactos/sdk/include/ndk/exfuncs.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/include/ndk/exfuncs.h?…
============================================================================== --- trunk/reactos/sdk/include/ndk/exfuncs.h [iso-8859-1] (original) +++ trunk/reactos/sdk/include/ndk/exfuncs.h [iso-8859-1] Fri Aug 18 08:44:08 2017 @@ -407,9 +407,9 @@ NTAPI NtQuerySystemInformation( _In_ SYSTEM_INFORMATION_CLASS SystemInformationClass, - _Out_ PVOID SystemInformation, - _In_ ULONG InformationLength, - _Out_opt_ PULONG ResultLength + _Out_writes_bytes_to_opt_(SystemInformationLength, *ReturnLength) PVOID SystemInformation, + _In_ ULONG SystemInformationLength, + _Out_opt_ PULONG ReturnLength ); NTSYSCALLAPI @@ -876,9 +876,9 @@ NTAPI ZwQuerySystemInformation( _In_ SYSTEM_INFORMATION_CLASS SystemInformationClass, - _Out_ PVOID SystemInformation, - _In_ SIZE_T Length, - _Out_opt_ PSIZE_T ResultLength + _Out_writes_bytes_to_opt_(SystemInformationLength, *ReturnLength) PVOID SystemInformation, + _In_ ULONG SystemInformationLength, + _Out_opt_ PULONG ReturnLength ); NTSYSAPI Modified: trunk/reactos/win32ss/drivers/videoprt/videoprt.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/drivers/videoprt/v…
============================================================================== --- trunk/reactos/win32ss/drivers/videoprt/videoprt.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/drivers/videoprt/videoprt.c [iso-8859-1] Fri Aug 18 08:44:08 2017 @@ -251,7 +251,6 @@ { WCHAR DeviceVideoBuffer[20]; PVIDEO_PORT_DEVICE_EXTENSION DeviceExtension; - SIZE_T Size; NTSTATUS Status; VIDEO_PORT_CONFIG_INFO ConfigInfo; SYSTEM_BASIC_INFORMATION SystemBasicInfo; @@ -280,11 +279,10 @@ ConfigInfo.BusInterruptLevel = DeviceExtension->InterruptLevel; ConfigInfo.BusInterruptVector = DeviceExtension->InterruptVector; - Size = sizeof(SystemBasicInfo); Status = ZwQuerySystemInformation(SystemBasicInformation, &SystemBasicInfo, - Size, - &Size); + sizeof(SystemBasicInfo), + NULL); if (NT_SUCCESS(Status)) { ConfigInfo.SystemMemorySize = SystemBasicInfo.NumberOfPhysicalPages *
7 years, 4 months
1
0
0
0
[tkreuzer] 75605: [NTOSKRNL] Fix memory area macros
by tkreuzer@svn.reactos.org
Author: tkreuzer Date: Fri Aug 18 08:42:43 2017 New Revision: 75605 URL:
http://svn.reactos.org/svn/reactos?rev=75605&view=rev
Log: [NTOSKRNL] Fix memory area macros Modified: trunk/reactos/ntoskrnl/include/internal/mm.h Modified: trunk/reactos/ntoskrnl/include/internal/mm.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/…
============================================================================== --- trunk/reactos/ntoskrnl/include/internal/mm.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/mm.h [iso-8859-1] Fri Aug 18 08:42:43 2017 @@ -200,8 +200,8 @@ }; } ROS_SECTION_OBJECT, *PROS_SECTION_OBJECT; -#define MA_GetStartingAddress(_MemoryArea) (MemoryArea->VadNode.StartingVpn << PAGE_SHIFT) -#define MA_GetEndingAddress(_MemoryArea) ((MemoryArea->VadNode.EndingVpn + 1) << PAGE_SHIFT) +#define MA_GetStartingAddress(_MemoryArea) (_MemoryArea->VadNode.StartingVpn << PAGE_SHIFT) +#define MA_GetEndingAddress(_MemoryArea) ((_MemoryArea->VadNode.EndingVpn + 1) << PAGE_SHIFT) typedef struct _MEMORY_AREA {
7 years, 4 months
1
0
0
0
[gadamopoulos] 75604: [STOBJECT] Fix bug that caused some resource strings not to be loaded. - These strings need to either be in every language file or have their own resource range but since we a...
by gadamopoulos@svn.reactos.org
Author: gadamopoulos Date: Fri Aug 18 08:38:52 2017 New Revision: 75604 URL:
http://svn.reactos.org/svn/reactos?rev=75604&view=rev
Log: [STOBJECT] Fix bug that caused some resource strings not to be loaded. - These strings need to either be in every language file or have their own resource range but since we are using the same resource ids with windows I will just duplicate them. Modified: trunk/reactos/dll/shellext/stobject/lang/cs-CZ.rc trunk/reactos/dll/shellext/stobject/lang/de-DE.rc trunk/reactos/dll/shellext/stobject/lang/en-US.rc trunk/reactos/dll/shellext/stobject/lang/es-ES.rc trunk/reactos/dll/shellext/stobject/lang/fr-FR.rc trunk/reactos/dll/shellext/stobject/lang/it-IT.rc trunk/reactos/dll/shellext/stobject/lang/ro-RO.rc trunk/reactos/dll/shellext/stobject/lang/ru-RU.rc trunk/reactos/dll/shellext/stobject/lang/tr-TR.rc trunk/reactos/dll/shellext/stobject/lang/zh-CN.rc trunk/reactos/dll/shellext/stobject/lang/zh-TW.rc trunk/reactos/dll/shellext/stobject/stobject.rc Modified: trunk/reactos/dll/shellext/stobject/lang/cs-CZ.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang…
============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/cs-CZ.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/cs-CZ.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -17,6 +17,7 @@ //Power related strings IDS_PWR_PROPERTIES "&Upravit možnosti napájenÃ" IDS_PWR_METER "&OtevÅÃt ukazatel spotÅeby" + IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" IDS_PWR_PERCENT_REMAINING "zbývá %1!u!%%" IDS_PWR_CHARGING " (nabÃjenÃ)" IDS_PWR_UNKNOWN_REMAINING "Zbývá neznámo" @@ -28,6 +29,7 @@ IDS_HOTPLUG_REMOVE_1 "BezpeÄnÄ odebrat hardware" IDS_HOTPLUG_REMOVE_2 "&BezpeÄnÄ odebrat hardwar" IDS_HOTPLUG_REMOVE_3 "BezpeÄnÄ odebrat%s" + IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" IDS_HOTPLUG_COMMA ", " IDS_HOTPLUG_DRIVE " - Jednotka(%s)" IDS_HOTPLUG_DRIVES " - Jednotky(%s)" @@ -39,6 +41,7 @@ IDS_VOL_VOLUME "Hlasitost" IDS_VOL_ADJUST "&Upravit vlastnosti zvuku" IDS_VOL_OPEN "&OtevÅÃt ovládánà hlasitosti" + IDS_VOL_RUN "SNDVOL32.EXE" IDS_VOL_MUTED "Hlasitost (ztlumeno)" //Keyboard-Mouse related strings Modified: trunk/reactos/dll/shellext/stobject/lang/de-DE.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang…
============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/de-DE.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/de-DE.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -17,6 +17,7 @@ //Power related strings IDS_PWR_PROPERTIES "&Energieverwaltungseigenschaften einstellen" IDS_PWR_METER "Batterieanzeige ö&ffnen" + IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" IDS_PWR_PERCENT_REMAINING "%1!u!%% verbleibend" IDS_PWR_CHARGING " (wird aufgeladen)" IDS_PWR_UNKNOWN_REMAINING "Unbekannt verbleibend" @@ -28,6 +29,7 @@ IDS_HOTPLUG_REMOVE_1 "Hardware sicher entfernen" IDS_HOTPLUG_REMOVE_2 "&Hardware sicher entfernen" IDS_HOTPLUG_REMOVE_3 "%s entfernen" + IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" IDS_HOTPLUG_COMMA ", " IDS_HOTPLUG_DRIVE " - Laufwerk (%s)" IDS_HOTPLUG_DRIVES " - Laufwerke (%s)" @@ -39,6 +41,7 @@ IDS_VOL_VOLUME "Lautstärke" IDS_VOL_ADJUST "&Audioeigenschaften einstellen" IDS_VOL_OPEN "&Lautstärkeregelung öffnen" + IDS_VOL_RUN "SNDVOL32.EXE" IDS_VOL_MUTED "Lautstärke (ausgeschaltet)" //Keyboard-Mouse related strings Modified: trunk/reactos/dll/shellext/stobject/lang/en-US.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang…
============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/en-US.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/en-US.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -17,6 +17,7 @@ //Power related strings IDS_PWR_PROPERTIES "&Adjust Power Properties" IDS_PWR_METER "&Open Power Meter" + IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" IDS_PWR_PERCENT_REMAINING "%1!u!%% remaining" IDS_PWR_CHARGING " (charging)" IDS_PWR_UNKNOWN_REMAINING "Unknown remaining" @@ -28,6 +29,7 @@ IDS_HOTPLUG_REMOVE_1 "Safely Remove Hardware" IDS_HOTPLUG_REMOVE_2 "&Safely Remove Hardware" IDS_HOTPLUG_REMOVE_3 "Safely remove %s" + IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" IDS_HOTPLUG_COMMA ", " IDS_HOTPLUG_DRIVE " - Drive(%s)" IDS_HOTPLUG_DRIVES " - Drives(%s)" @@ -39,6 +41,7 @@ IDS_VOL_VOLUME "Volume" IDS_VOL_ADJUST "&Adjust Audio Properties" IDS_VOL_OPEN "&Open Volume Control" + IDS_VOL_RUN "SNDVOL32.EXE" IDS_VOL_MUTED "Volume (muted)" //Keyboard-Mouse related strings Modified: trunk/reactos/dll/shellext/stobject/lang/es-ES.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang…
============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/es-ES.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/es-ES.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -18,6 +18,7 @@ //Power related strings IDS_PWR_PROPERTIES "&Ajustar propiedades de energÃa" IDS_PWR_METER "Abrir &medidor de energÃa" + IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" IDS_PWR_PERCENT_REMAINING "Queda un %1!u!%%" IDS_PWR_CHARGING " (cargando)" IDS_PWR_UNKNOWN_REMAINING "Estado de baterÃa desconocido" @@ -29,6 +30,7 @@ IDS_HOTPLUG_REMOVE_1 "Desconectar de forma segura" IDS_HOTPLUG_REMOVE_2 "&Desconectar de forma segura" IDS_HOTPLUG_REMOVE_3 "Desconectar de forma segura %s" + IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" IDS_HOTPLUG_COMMA ", " IDS_HOTPLUG_DRIVE " - Unidad(%s)" IDS_HOTPLUG_DRIVES " - Unidades(%s)" @@ -40,6 +42,7 @@ IDS_VOL_VOLUME "Volumen" IDS_VOL_ADJUST "&Ajustar propiedades de audio" IDS_VOL_OPEN "Abrir &control de volumen" + IDS_VOL_RUN "SNDVOL32.EXE" IDS_VOL_MUTED "Volumen (silenciado)" //Keyboard-Mouse related strings Modified: trunk/reactos/dll/shellext/stobject/lang/fr-FR.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang…
============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/fr-FR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/fr-FR.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -17,6 +17,7 @@ //Power related strings IDS_PWR_PROPERTIES "&Adjust Power Properties" IDS_PWR_METER "&Open Power Meter" + IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" IDS_PWR_PERCENT_REMAINING "%1!u!%% remaining" IDS_PWR_CHARGING " (charging)" IDS_PWR_UNKNOWN_REMAINING "Unknown remaining" @@ -28,6 +29,7 @@ IDS_HOTPLUG_REMOVE_1 "Safely Remove Hardware" IDS_HOTPLUG_REMOVE_2 "&Safely Remove Hardware" IDS_HOTPLUG_REMOVE_3 "Safely remove %s" + IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" IDS_HOTPLUG_COMMA ", " IDS_HOTPLUG_DRIVE " - Drive(%s)" IDS_HOTPLUG_DRIVES " - Drives(%s)" @@ -39,6 +41,7 @@ IDS_VOL_VOLUME "Volume" IDS_VOL_ADJUST "&Ajuster les propriétés audio" IDS_VOL_OPEN "&Ouvrir le controle du volume" + IDS_VOL_RUN "SNDVOL32.EXE" IDS_VOL_MUTED "Volume (muet)" //Keyboard-Mouse related strings Modified: trunk/reactos/dll/shellext/stobject/lang/it-IT.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang…
============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/it-IT.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/it-IT.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -17,6 +17,7 @@ //Power related strings IDS_PWR_PROPERTIES "&Modifica proprietà alimentazione" IDS_PWR_METER "&Apri misuratore alimentazione" + IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" IDS_PWR_PERCENT_REMAINING "%1!u!%% rimanenti" IDS_PWR_CHARGING " (in carica)" IDS_PWR_UNKNOWN_REMAINING "Autonomia sconosciuta" @@ -28,6 +29,7 @@ IDS_HOTPLUG_REMOVE_1 "Rimozione sicura dell'Hardware" IDS_HOTPLUG_REMOVE_2 "&Rimozione sicura dell'Hardware" IDS_HOTPLUG_REMOVE_3 "Rimozione sicura di %s" + IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" IDS_HOTPLUG_COMMA ", " IDS_HOTPLUG_DRIVE " - Unità disco(%s)" IDS_HOTPLUG_DRIVES " - Unità dischi(%s)" @@ -39,6 +41,7 @@ IDS_VOL_VOLUME "Volume" IDS_VOL_ADJUST "&Modifica proprietà audio" IDS_VOL_OPEN "&Apri controllo del Volume" + IDS_VOL_RUN "SNDVOL32.EXE" IDS_VOL_MUTED "Volume (spento)" //Keyboard-Mouse related strings Modified: trunk/reactos/dll/shellext/stobject/lang/ro-RO.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang…
============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/ro-RO.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/ro-RO.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -18,6 +18,7 @@ //Power related strings IDS_PWR_PROPERTIES "&Ajustare proprietÄÈi de consum energie" IDS_PWR_METER "&Deschide Contor de energie" + IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" IDS_PWR_PERCENT_REMAINING "Au mai rÄmas %1!u!%%" IDS_PWR_CHARGING " (în încÄrcare)" IDS_PWR_UNKNOWN_REMAINING "Nu este disponibil cât a mai rÄmas" @@ -29,6 +30,7 @@ IDS_HOTPLUG_REMOVE_1 "Scoate în siguranÈÄ acest dispozitiv" IDS_HOTPLUG_REMOVE_2 "S&coate în siguranÈÄ acest dispozitiv" IDS_HOTPLUG_REMOVE_3 "Scoate în siguranÈÄ %s" + IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" IDS_HOTPLUG_COMMA ", " IDS_HOTPLUG_DRIVE " - unitate (%s)" IDS_HOTPLUG_DRIVES " - unitÄÈi (%s)" @@ -40,6 +42,7 @@ IDS_VOL_VOLUME "Volum" IDS_VOL_ADJUST "&AjusteazÄ proprietÄÈi audio" IDS_VOL_OPEN "&Deschide control de volum" + IDS_VOL_RUN "SNDVOL32.EXE" IDS_VOL_MUTED "Volum (mut)" //Keyboard-Mouse related strings Modified: trunk/reactos/dll/shellext/stobject/lang/ru-RU.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang…
============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/ru-RU.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/ru-RU.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -19,6 +19,7 @@ //Power related strings IDS_PWR_PROPERTIES "&ÐаÑÑÑойка паÑамеÑÑов ÑлекÑÑопиÑаниÑ" IDS_PWR_METER "&ÐÑкÑÑÑÑ Ð¿Ð¾ÐºÐ°Ð·Ð°Ñели пиÑаниÑ" + IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" IDS_PWR_PERCENT_REMAINING "%1!u!%% оÑÑалоÑÑ" IDS_PWR_CHARGING " (заÑÑдка)" IDS_PWR_UNKNOWN_REMAINING "ÐеизвеÑÑно" @@ -30,6 +31,7 @@ IDS_HOTPLUG_REMOVE_1 "ÐезопаÑное извлеÑение ÑÑÑÑойÑÑва" IDS_HOTPLUG_REMOVE_2 "&ÐезопаÑное извлеÑение ÑÑÑÑойÑÑва" IDS_HOTPLUG_REMOVE_3 "ÐезопаÑное извлеÑение %s" + IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" IDS_HOTPLUG_COMMA ", " IDS_HOTPLUG_DRIVE " - ÐиÑк(%s)" IDS_HOTPLUG_DRIVES " - ÐиÑки(%s)" @@ -41,6 +43,7 @@ IDS_VOL_VOLUME "ÐÑомкоÑÑÑ" IDS_VOL_ADJUST "&ÐаÑÑÑойка паÑамеÑÑов аÑдио" IDS_VOL_OPEN "&ÐÑкÑÑÑÑ ÑпÑавление гÑомкоÑÑÑÑ" + IDS_VOL_RUN "SNDVOL32.EXE" IDS_VOL_MUTED "ÐÑомкоÑÑÑ (вÑклÑÑено)" //Keyboard-Mouse related strings Modified: trunk/reactos/dll/shellext/stobject/lang/tr-TR.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang…
============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/tr-TR.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/tr-TR.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -19,6 +19,7 @@ //Power related strings IDS_PWR_PROPERTIES "&Güç Husûsiyetlerini Düzenle" IDS_PWR_METER "G&üç Ãlçücüsünü Aç" + IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" IDS_PWR_PERCENT_REMAINING "%%%1!u! kaldı." IDS_PWR_CHARGING " (Yükleniyor)" IDS_PWR_UNKNOWN_REMAINING "Bilinmeyen kalan." @@ -30,6 +31,7 @@ IDS_HOTPLUG_REMOVE_1 "Donanımı Güvenli Kaldır" IDS_HOTPLUG_REMOVE_2 "&Donanımı Güvenli Kaldır" IDS_HOTPLUG_REMOVE_3 "%s Donanımını Güvenli Kaldır" + IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" IDS_HOTPLUG_COMMA ", " IDS_HOTPLUG_DRIVE " - Sürücü (%s)" IDS_HOTPLUG_DRIVES " - Sürücüler (%s)" @@ -41,6 +43,7 @@ IDS_VOL_VOLUME "Ses Düzeyi" IDS_VOL_ADJUST "&Ses Husûsiyetlerini Düzenle" IDS_VOL_OPEN "&Ses Düzeyi Denetimini Aç" + IDS_VOL_RUN "SNDVOL32.EXE" IDS_VOL_MUTED "Ses Düzeyi (Sessiz)" //Keyboard-Mouse related strings Modified: trunk/reactos/dll/shellext/stobject/lang/zh-CN.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang…
============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/zh-CN.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/zh-CN.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -19,6 +19,7 @@ //Power related strings IDS_PWR_PROPERTIES "è°æ´çµæºå±æ§(&A)" IDS_PWR_METER "å¼æ¾å¼çµæºè¡¨(&O)" + IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" IDS_PWR_PERCENT_REMAINING "å©ä½ %1!u!%%" IDS_PWR_CHARGING " (å çµä¸)" IDS_PWR_UNKNOWN_REMAINING "æªç¥å©ä½" @@ -30,6 +31,7 @@ IDS_HOTPLUG_REMOVE_1 "å®å ¨å°å é¤ç¡¬ä»¶" IDS_HOTPLUG_REMOVE_2 "å®å ¨å°å é¤ç¡¬ä»¶(&S)" IDS_HOTPLUG_REMOVE_3 "å®å ¨å°å é¤ %s" + IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" IDS_HOTPLUG_COMMA ", " IDS_HOTPLUG_DRIVE " - ç£ç(%s)" IDS_HOTPLUG_DRIVES " - ç£ç(%s)" @@ -41,6 +43,7 @@ IDS_VOL_VOLUME "é³é" IDS_VOL_ADJUST "è°æ´é³é¢å±æ§(&A)" IDS_VOL_OPEN "æå¼é³éæ§å¶(&O)" + IDS_VOL_RUN "SNDVOL32.EXE" IDS_VOL_MUTED "(éé³)" //Keyboard-Mouse related strings Modified: trunk/reactos/dll/shellext/stobject/lang/zh-TW.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/lang…
============================================================================== --- trunk/reactos/dll/shellext/stobject/lang/zh-TW.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/lang/zh-TW.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -19,6 +19,7 @@ //Power related strings IDS_PWR_PROPERTIES "調æ´é»æºå±¬æ§(&A)" IDS_PWR_METER "éæ¾å¼é»æºè¡¨(&O)" + IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" IDS_PWR_PERCENT_REMAINING "å©é¤ %1!u!%%" IDS_PWR_CHARGING " (å é»ä¸)" IDS_PWR_UNKNOWN_REMAINING "æªç¥å©é¤" @@ -30,6 +31,7 @@ IDS_HOTPLUG_REMOVE_1 "å®å ¨å°åªé¤ç¡¬é«" IDS_HOTPLUG_REMOVE_2 "å®å ¨å°åªé¤ç¡¬é«(&S)" IDS_HOTPLUG_REMOVE_3 "å®å ¨å°åªé¤ %s" + IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" IDS_HOTPLUG_COMMA ", " IDS_HOTPLUG_DRIVE " - ç£ç¢(%s)" IDS_HOTPLUG_DRIVES " - ç£ç¢(%s)" @@ -41,6 +43,7 @@ IDS_VOL_VOLUME "é³é" IDS_VOL_ADJUST "調æ´é³è¨å±¬æ§(&A)" IDS_VOL_OPEN "éåé³éæ§å¶(&O)" + IDS_VOL_RUN "SNDVOL32.EXE" IDS_VOL_MUTED "(éé³)" //Keyboard-Mouse related strings Modified: trunk/reactos/dll/shellext/stobject/stobject.rc URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/shellext/stobject/stob…
============================================================================== --- trunk/reactos/dll/shellext/stobject/stobject.rc [iso-8859-1] (original) +++ trunk/reactos/dll/shellext/stobject/stobject.rc [iso-8859-1] Fri Aug 18 08:38:52 2017 @@ -14,19 +14,6 @@ IDR_SYSTRAY REGISTRY "resources/rgs/systray.rgs" #include <reactos/manifest_dll.rc> - -// Strings common to all languages -STRINGTABLE -BEGIN - // Power related strings - IDS_PWR_RUN "shell32.dll,Control_RunDLL PowerCfg.cpl" - - // Hotplug related strings - IDS_HOTPLUG_RUN "shell32.dll,Control_RunDLL hotplug.dll" - - // Volume related strings - IDS_VOL_RUN "SNDVOL32.EXE" -END /* UTF-8 */ #pragma code_page(65001)
7 years, 4 months
1
0
0
0
[bfreisen] 75603: [PSDK][GDIPLUS] Further work on Graphics
by bfreisen@svn.reactos.org
Author: bfreisen Date: Fri Aug 18 08:09:04 2017 New Revision: 75603 URL:
http://svn.reactos.org/svn/reactos?rev=75603&view=rev
Log: [PSDK][GDIPLUS] Further work on Graphics Modified: trunk/reactos/sdk/include/psdk/gdiplusbrush.h trunk/reactos/sdk/include/psdk/gdiplusgraphics.h Modified: trunk/reactos/sdk/include/psdk/gdiplusbrush.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/include/psdk/gdiplusbr…
============================================================================== --- trunk/reactos/sdk/include/psdk/gdiplusbrush.h [iso-8859-1] (original) +++ trunk/reactos/sdk/include/psdk/gdiplusbrush.h [iso-8859-1] Fri Aug 18 08:09:04 2017 @@ -24,6 +24,7 @@ class Brush : public GdiplusBase { public: + friend class Graphics; friend class Pen; Brush *Clone(VOID) const Modified: trunk/reactos/sdk/include/psdk/gdiplusgraphics.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/include/psdk/gdiplusgr…
============================================================================== --- trunk/reactos/sdk/include/psdk/gdiplusgraphics.h [iso-8859-1] (original) +++ trunk/reactos/sdk/include/psdk/gdiplusgraphics.h [iso-8859-1] Fri Aug 18 08:09:04 2017 @@ -481,42 +481,42 @@ Status FillClosedCurve(const Brush *brush, const Point *points, INT count) { - return NotImplemented; + return SetStatus(DllExports::GdipFillClosedCurveI(graphics, brush ? brush->brush : NULL, points, count)); } Status FillClosedCurve(const Brush *brush, const Point *points, INT count, FillMode fillMode, REAL tension) { - return NotImplemented; + return SetStatus(DllExports::GdipFillClosedCurve2I(graphics, brush ? brush->brush : NULL, points, count, tension, fillMode)); } Status FillClosedCurve(const Brush *brush, const PointF *points, INT count) { - return NotImplemented; + return SetStatus(DllExports::GdipFillClosedCurve(graphics, brush ? brush->brush : NULL, points, count)); } Status FillClosedCurve(const Brush *brush, const PointF *points, INT count, FillMode fillMode, REAL tension) { - return NotImplemented; + return SetStatus(DllExports::GdipFillClosedCurve2(graphics, brush ? brush->brush : NULL, points, count, tension, fillMode)); } Status FillEllipse(const Brush *brush, const Rect &rect) { - return NotImplemented; + return SetStatus(DllExports::GdipFillEllipseI(graphics, brush ? brush->brush : NULL, rect.X, rect.Y, rect.Width, rect.Height)); } Status FillEllipse(const Brush *brush, REAL x, REAL y, REAL width, REAL height) { - return NotImplemented; + return SetStatus(DllExports::GdipFillEllipse(graphics, brush ? brush->brush : NULL, x, y, width, height)); } Status FillEllipse(const Brush *brush, const RectF &rect) { - return NotImplemented; + return SetStatus(DllExports::GdipFillEllipse(graphics, brush ? brush->brush : NULL, rect.X, rect.Y, rect.Width, rect.Height)); } Status FillEllipse(const Brush *brush, INT x, INT y, INT width, INT height) { - return NotImplemented; + return SetStatus(DllExports::GdipFillEllipseI(graphics, brush ? brush->brush : NULL, x, y, width, height)); } Status FillPath(const Brush *brush, const GraphicsPath *path) @@ -526,72 +526,72 @@ Status FillPie(const Brush *brush, const Rect &rect, REAL startAngle, REAL sweepAngle) { - return NotImplemented; + return SetStatus(DllExports::GdipFillPieI(graphics, brush ? brush->brush : NULL, rect.X, rect.Y, rect.Width, rect.Height, startAngle, sweepAngle)); } Status FillPie(const Brush *brush, INT x, INT y, INT width, INT height, REAL startAngle, REAL sweepAngle) { - return NotImplemented; + return SetStatus(DllExports::GdipFillPieI(graphics, brush ? brush->brush : NULL, x, y, width, height, startAngle, sweepAngle)); } Status FillPie(const Brush *brush, REAL x, REAL y, REAL width, REAL height, REAL startAngle, REAL sweepAngle) { - return NotImplemented; + return SetStatus(DllExports::GdipFillPie(graphics, brush ? brush->brush : NULL, x, y, width, height, startAngle, sweepAngle)); } Status FillPie(const Brush *brush, RectF &rect, REAL startAngle, REAL sweepAngle) { - return NotImplemented; + return SetStatus(DllExports::GdipFillPie(graphics, brush ? brush->brush : NULL, rect.X, rect.Y, rect.Width, rect.Height, startAngle, sweepAngle)); } Status FillPolygon(const Brush *brush, const Point *points, INT count) { - return NotImplemented; + return SetStatus(DllExports::GdipFillPolygon2I(graphics, brush ? brush->brush : NULL, points, count)); } Status FillPolygon(const Brush *brush, const PointF *points, INT count) { - return NotImplemented; + return SetStatus(DllExports::GdipFillPolygon2(graphics, brush ? brush->brush : NULL, points, count)); } Status FillPolygon(const Brush *brush, const Point *points, INT count, FillMode fillMode) { - return NotImplemented; + return SetStatus(DllExports::GdipFillPolygonI(graphics, brush ? brush->brush : NULL, points, count, fillMode)); } Status FillPolygon(const Brush *brush, const PointF *points, INT count, FillMode fillMode) { - return NotImplemented; + return SetStatus(DllExports::GdipFillPolygon(graphics, brush ? brush->brush : NULL, points, count, fillMode)); } Status FillRectangle(const Brush *brush, const Rect &rect) { - return NotImplemented; + return SetStatus(DllExports::GdipFillRectangleI(graphics, brush ? brush->brush : NULL, rect.X, rect.Y, rect.Width, rect.Height)); } Status FillRectangle(const Brush *brush, const RectF &rect) { - return NotImplemented; + return SetStatus(DllExports::GdipFillRectangle(graphics, brush ? brush->brush : NULL, rect.X, rect.Y, rect.Width, rect.Height)); } Status FillRectangle(const Brush *brush, REAL x, REAL y, REAL width, REAL height) { - return NotImplemented; + return SetStatus(DllExports::GdipFillRectangle(graphics, brush ? brush->brush : NULL, x, y, width, height)); } Status FillRectangle(const Brush *brush, INT x, INT y, INT width, INT height) { - return NotImplemented; + return SetStatus(DllExports::GdipFillRectangleI(graphics, brush ? brush->brush : NULL, x, y, width, height)); } Status FillRectangles(const Brush *brush, const Rect *rects, INT count) { - return NotImplemented; + return SetStatus(DllExports::GdipFillRectanglesI(graphics, brush ? brush->brush : NULL, rects, count)); } Status FillRectangles(const Brush *brush, const RectF *rects, INT count) { - return NotImplemented; + return SetStatus(DllExports::GdipFillRectangles(graphics, brush ? brush->brush : NULL, rects, count)); } Status FillRegion(const Brush *brush, const Region *region) @@ -630,251 +630,294 @@ Status GetClipBounds(Rect* rect) const { - return NotImplemented; + return SetStatus(DllExports::GdipGetClipBoundsI(graphics, rect)); } Status GetClipBounds(RectF* rect) const { - return NotImplemented; + return SetStatus(DllExports::GdipGetClipBounds(graphics, rect)); } CompositingMode GetCompositingMode(VOID) { - return CompositingModeSourceOver; + CompositingMode compositingMode; + SetStatus(DllExports::GdipGetCompositingMode(graphics, &compositingMode)); + return compositingMode; } CompositingQuality GetCompositingQuality(VOID) { - return CompositingQualityDefault; + CompositingQuality compositingQuality; + SetStatus(DllExports::GdipGetCompositingQuality(graphics, &compositingQuality)); + return compositingQuality; } REAL GetDpiX(VOID) { + REAL dpi; + SetStatus(DllExports::GdipGetDpiX(graphics, &dpi)); + return dpi; + } + + REAL GetDpiY(VOID) + { + REAL dpi; + SetStatus(DllExports::GdipGetDpiY(graphics, &dpi)); + return dpi; + } + + static HPALETTE GetHalftonePalette(VOID) + { + return NULL; + } + + HDC GetHDC(VOID) + { + return NULL; + } + + InterpolationMode GetInterpolationMode(VOID) + { + InterpolationMode interpolationMode; + SetStatus(DllExports::GdipGetInterpolationMode(graphics, &interpolationMode)); + return interpolationMode; + } + + Status GetLastStatus(VOID) + { + return status; + } + + Status GetNearestColor(Color* color) const + { + return NotImplemented; + } + + REAL GetPageScale(VOID) + { + REAL scale; + SetStatus(DllExports::GdipGetPageScale(graphics, &scale)); + return scale; + } + + Unit GetPageUnit(VOID) + { + Unit unit; + SetStatus(DllExports::GdipGetPageUnit(graphics, &unit)); + return unit; + } + + PixelOffsetMode GetPixelOffsetMode(VOID) + { + PixelOffsetMode pixelOffsetMode; + SetStatus(DllExports::GdipGetPixelOffsetMode(graphics, &pixelOffsetMode)); + return pixelOffsetMode; + } + + Status GetRenderingOrigin(INT *x, INT *y) + { + return NotImplemented; // FIXME: not available: SetStatus(DllExports::GdipGetRenderingOrigin(graphics, x, y)); + } + + SmoothingMode GetSmoothingMode(VOID) const + { + SmoothingMode smoothingMode; + SetStatus(DllExports::GdipGetSmoothingMode(graphics, &smoothingMode)); + return smoothingMode; + } + + UINT GetTextContrast(VOID) const + { + UINT contrast; + SetStatus(DllExports::GdipGetTextContrast(graphics, &contrast)); + return contrast; + } + + TextRenderingHint GetTextRenderingHint(VOID) const + { + TextRenderingHint mode; + SetStatus(DllExports::GdipGetTextRenderingHint(graphics, &mode)); + return mode; + } + + Status GetTransform(Matrix* matrix) + { + return NotImplemented; + } + + Status GetVisibleClipBounds(Rect* rect) const + { + return SetStatus(DllExports::GdipGetVisibleClipBoundsI(graphics, rect)); + } + + Status GetVisibleClipBounds(RectF* rect) const + { + return SetStatus(DllExports::GdipGetVisibleClipBounds(graphics, rect)); + } + + Status IntersectClip(const Rect& rect) + { + return NotImplemented; + } + + Status IntersectClip(const Region* region) + { + return NotImplemented; + } + + Status IntersectClip(const RectF& rect) + { + return NotImplemented; + } + + BOOL IsClipEmpty(VOID) const + { + BOOL result; + SetStatus(DllExports::GdipIsClipEmpty(graphics, &result)); + return result; + } + + BOOL IsVisible(const Point& point) const + { + BOOL result; + SetStatus(DllExports::GdipIsVisiblePointI(graphics, point.X, point.Y, &result)); + return result; + } + + BOOL IsVisible(const Rect& rect) const + { + BOOL result; + SetStatus(DllExports::GdipIsVisibleRectI(graphics, rect.X, rect.Y, rect.Width, rect.Height, &result)); + return result; + } + + BOOL IsVisible(REAL x, REAL y) const + { + BOOL result; + SetStatus(DllExports::GdipIsVisiblePoint(graphics, x, y, &result)); + return result; + } + + BOOL IsVisible(const RectF& rect) const + { + BOOL result; + SetStatus(DllExports::GdipIsVisibleRect(graphics, rect.X, rect.Y, rect.Width, rect.Height, &result)); + return result; + } + + BOOL IsVisible(INT x, INT y, INT width, INT height) const + { + BOOL result; + SetStatus(DllExports::GdipIsVisibleRectI(graphics, x, y, width, height, &result)); + return result; + } + + BOOL IsVisible(INT x, INT y) const + { + BOOL result; + SetStatus(DllExports::GdipIsVisiblePointI(graphics, x, y, &result)); + return result; + } + + BOOL IsVisible(const PointF& point) const + { + BOOL result; + SetStatus(DllExports::GdipIsVisiblePoint(graphics, point.X, point.Y, &result)); + return result; + } + + BOOL IsVisible(REAL x, REAL y, REAL width, REAL height) const + { + BOOL result; + SetStatus(DllExports::GdipIsVisibleRect(graphics, x, y, width, height, &result)); + return result; + } + + BOOL IsVisibleClipEmpty(VOID) const + { + return FALSE; /* FIXME: not available: + BOOL result; + SetStatus(DllExports::GdipIsVisibleClipEmpty(graphics, &result)); + return result;*/ + } + + Status MeasureCharacterRanges(const WCHAR *string, INT length, const Font *font, const RectF &layoutRect, const StringFormat *stringFormat, INT regionCount, Region *regions) const + { + return NotImplemented; + } + + Status MeasureDriverString(const UINT16 *text, INT length, const Font *font, const PointF *positions, INT flags, const Matrix *matrix, RectF *boundingBox) const + { + return NotImplemented; + } + + Status MeasureString(const WCHAR *string, INT length, const Font *font, const RectF &layoutRect, RectF *boundingBox) const + { + return NotImplemented; + } + + Status MeasureString(const WCHAR *string, INT length, const Font *font, const PointF &origin, const StringFormat *stringFormat, RectF *boundingBox) const + { + return NotImplemented; + } + + Status MeasureString(const WCHAR *string, INT length, const Font *font, const RectF &layoutRect, const StringFormat *stringFormat, RectF *boundingBox, INT *codepointsFitted, INT *linesFilled) const + { + return NotImplemented; + } + + Status MeasureString(const WCHAR *string, INT length, const Font *font, const SizeF &layoutRectSize, const StringFormat *stringFormat, SizeF *size, INT *codepointsFitted, INT *linesFilled) const + { + return NotImplemented; + } + + Status MeasureString(const WCHAR *string, INT length, const Font *font, const PointF &origin, RectF *boundingBox) const + { + return NotImplemented; + } + + Status MultiplyTransform(Matrix *matrix, MatrixOrder order) + { + return NotImplemented; + } + + VOID ReleaseHDC(HDC hdc) + { + } + + Status ResetClip(VOID) + { + return SetStatus(DllExports::GdipResetClip(graphics)); + } + + Status ResetTransform(VOID) + { + return SetStatus(DllExports::GdipResetWorldTransform(graphics)); + } + + Status Restore(GraphicsState gstate) + { + return NotImplemented; + } + + Status RotateTransform(REAL angle, MatrixOrder order) + { + return SetStatus(DllExports::GdipRotateWorldTransform(graphics, angle, order)); + } + + GraphicsState Save(VOID) + { return 0; } - REAL GetDpiY(VOID) - { - return 0; - } - - static HPALETTE GetHalftonePalette(VOID) - { - return NULL; - } - - HDC GetHDC(VOID) - { - return NULL; - } - - InterpolationMode GetInterpolationMode(VOID) - { - return InterpolationModeInvalid; - } - - Status GetLastStatus(VOID) - { - return NotImplemented; - } - - Status GetNearestColor(Color* color) const - { - return NotImplemented; - } - - REAL GetPageScale(VOID) - { - return 0; - } - - Unit GetPageUnit(VOID) - { - return UnitWorld; - } - - PixelOffsetMode GetPixelOffsetMode(VOID) - { - return PixelOffsetModeInvalid; - } - - Status GetRenderingOrigin(INT *x, INT *y) - { - return NotImplemented; - } - - SmoothingMode GetSmoothingMode(VOID) const - { - return SmoothingModeInvalid; - } - - UINT GetTextContrast(VOID) const - { - return 0; - } - - TextRenderingHint GetTextRenderingHint(VOID) const - { - return TextRenderingHintSystemDefault; - } - - Status GetTransform(Matrix* matrix) - { - return NotImplemented; - } - - Status GetVisibleClipBounds(Rect* rect) const - { - return NotImplemented; - } - - Status GetVisibleClipBounds(RectF* rect) const - { - return NotImplemented; - } - - Status IntersectClip(const Rect& rect) - { - return NotImplemented; - } - - Status IntersectClip(const Region* region) - { - return NotImplemented; - } - - Status IntersectClip(const RectF& rect) - { - return NotImplemented; - } - - BOOL IsClipEmpty(VOID) const - { - return FALSE; - } - - BOOL IsVisible(const Point& point) const - { - return FALSE; - } - - BOOL IsVisible(const Rect& rect) const - { - return FALSE; - } - - BOOL IsVisible(REAL x, REAL y) const - { - return FALSE; - } - - BOOL IsVisible(const RectF& rect) const - { - return FALSE; - } - - BOOL IsVisible(INT x, INT y, INT width, INT height) const - { - return FALSE; - } - - BOOL IsVisible(INT x, INT y) const - { - return FALSE; - } - - BOOL IsVisible(const PointF& point) const - { - return FALSE; - } - - BOOL IsVisible(REAL x, REAL y, REAL width, REAL height) const - { - return FALSE; - } - - BOOL IsVisibleClipEmpty(VOID) const - { - return FALSE; - } - - Status MeasureCharacterRanges(const WCHAR *string, INT length, const Font *font, const RectF &layoutRect, const StringFormat *stringFormat, INT regionCount, Region *regions) const - { - return NotImplemented; - } - - Status MeasureDriverString(const UINT16 *text, INT length, const Font *font, const PointF *positions, INT flags, const Matrix *matrix, RectF *boundingBox) const - { - return NotImplemented; - } - - Status MeasureString(const WCHAR *string, INT length, const Font *font, const RectF &layoutRect, RectF *boundingBox) const - { - return NotImplemented; - } - - Status MeasureString(const WCHAR *string, INT length, const Font *font, const PointF &origin, const StringFormat *stringFormat, RectF *boundingBox) const - { - return NotImplemented; - } - - Status MeasureString(const WCHAR *string, INT length, const Font *font, const RectF &layoutRect, const StringFormat *stringFormat, RectF *boundingBox, INT *codepointsFitted, INT *linesFilled) const - { - return NotImplemented; - } - - Status MeasureString(const WCHAR *string, INT length, const Font *font, const SizeF &layoutRectSize, const StringFormat *stringFormat, SizeF *size, INT *codepointsFitted, INT *linesFilled) const - { - return NotImplemented; - } - - Status MeasureString(const WCHAR *string, INT length, const Font *font, const PointF &origin, RectF *boundingBox) const - { - return NotImplemented; - } - - Status MultiplyTransform(Matrix *matrix, MatrixOrder order) - { - return NotImplemented; - } - - VOID ReleaseHDC(HDC hdc) - { - } - - Status ResetClip(VOID) - { - return NotImplemented; - } - - Status ResetTransform(VOID) - { - return NotImplemented; - } - - Status Restore(GraphicsState gstate) - { - return NotImplemented; - } - - Status RotateTransform(REAL angle, MatrixOrder order) - { - return NotImplemented; - } - - GraphicsState Save(VOID) - { - return 0; - } - Status ScaleTransform(REAL sx, REAL sy, MatrixOrder order) { - return NotImplemented; + return SetStatus(DllExports::GdipScaleWorldTransform(graphics, sx, sy, order)); } Status SetClip(const Graphics *g, CombineMode combineMode) { - return NotImplemented; + return SetStatus(DllExports::GdipSetClipGraphics(graphics, g ? g->graphics : NULL, combineMode)); } Status SetClip(const GraphicsPath *path, CombineMode combineMode) @@ -889,67 +932,67 @@ Status SetClip(const Rect &rect, CombineMode combineMode) { - return NotImplemented; + return SetStatus(DllExports::GdipSetClipRectI(graphics, rect.X, rect.Y, rect.Width, rect.Height, combineMode)); } Status SetClip(HRGN hRgn, CombineMode combineMode) { - return NotImplemented; + return SetStatus(DllExports::GdipSetClipHrgn(graphics, hRgn, combineMode)); } Status SetClip(const RectF& rect, CombineMode combineMode) { - return NotImplemented; + return SetStatus(DllExports::GdipSetClipRect(graphics, rect.X, rect.Y, rect.Width, rect.Height, combineMode)); } Status SetCompositingMode(CompositingMode compositingMode) { - return NotImplemented; + return SetStatus(DllExports::GdipSetCompositingMode(graphics, compositingMode)); } Status SetCompositingQuality(CompositingQuality compositingQuality) { - return NotImplemented; + return SetStatus(DllExports::GdipSetCompositingQuality(graphics, compositingQuality)); } Status SetInterpolationMode(InterpolationMode interpolationMode) { - return NotImplemented; + return SetStatus(DllExports::GdipSetInterpolationMode(graphics, interpolationMode)); } Status SetPageScale(REAL scale) { - return NotImplemented; + return SetStatus(DllExports::GdipSetPageScale(graphics, scale)); } Status SetPageUnit(Unit unit) { - return NotImplemented; + return SetStatus(DllExports::GdipSetPageUnit(graphics, unit)); } Status SetPixelOffsetMode(PixelOffsetMode pixelOffsetMode) { - return NotImplemented; + return SetStatus(DllExports::GdipSetPixelOffsetMode(graphics, pixelOffsetMode)); } Status SetRenderingOrigin(INT x, INT y) { - return NotImplemented; + return SetStatus(DllExports::GdipSetRenderingOrigin(graphics, x, y)); } Status SetSmoothingMode(SmoothingMode smoothingMode) { - return NotImplemented; + return SetStatus(DllExports::GdipSetSmoothingMode(graphics, smoothingMode)); } Status SetTextContrast(UINT contrast) { - return NotImplemented; + return SetStatus(DllExports::GdipSetTextContrast(graphics, contrast)); } Status SetTextRenderingHint(TextRenderingHint newMode) { - return NotImplemented; + return SetStatus(DllExports::GdipSetTextRenderingHint(graphics, newMode)); } Status SetTransform(const Matrix *matrix) @@ -959,22 +1002,22 @@ Status TransformPoints(CoordinateSpace destSpace, CoordinateSpace srcSpace, Point *pts, INT count) { - return NotImplemented; + return SetStatus(DllExports::GdipTransformPointsI(graphics, destSpace, srcSpace, pts, count)); } Status TranslateClip(INT dx, INT dy) { - return NotImplemented; + return SetStatus(DllExports::GdipTranslateClipI(graphics, dx, dy)); } Status TranslateClip(REAL dx, REAL dy) { - return NotImplemented; + return SetStatus(DllExports::GdipTranslateClip(graphics, dx, dy)); } Status TranslateTransform(REAL dx, REAL dy, MatrixOrder order) { - return NotImplemented; + return SetStatus(DllExports::GdipTranslateWorldTransform(graphics, dx, dy, order)); } private:
7 years, 4 months
1
0
0
0
[tkreuzer] 75602: [NTOSKRNL] Remove duplicate fields from MEMORY_AREA
by tkreuzer@svn.reactos.org
Author: tkreuzer Date: Fri Aug 18 07:13:34 2017 New Revision: 75602 URL:
http://svn.reactos.org/svn/reactos?rev=75602&view=rev
Log: [NTOSKRNL] Remove duplicate fields from MEMORY_AREA Modified: trunk/reactos/ntoskrnl/include/internal/mm.h trunk/reactos/ntoskrnl/mm/ARM3/virtual.c trunk/reactos/ntoskrnl/mm/marea.c Modified: trunk/reactos/ntoskrnl/include/internal/mm.h URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/include/internal/…
============================================================================== --- trunk/reactos/ntoskrnl/include/internal/mm.h [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/include/internal/mm.h [iso-8859-1] Fri Aug 18 07:13:34 2017 @@ -200,17 +200,13 @@ }; } ROS_SECTION_OBJECT, *PROS_SECTION_OBJECT; -#define MA_GetStartingAddress(_MemoryArea) ((_MemoryArea)->StartingVpn << PAGE_SHIFT) -#define MA_GetEndingAddress(_MemoryArea) (((_MemoryArea)->EndingVpn + 1) << PAGE_SHIFT) +#define MA_GetStartingAddress(_MemoryArea) (MemoryArea->VadNode.StartingVpn << PAGE_SHIFT) +#define MA_GetEndingAddress(_MemoryArea) ((MemoryArea->VadNode.EndingVpn + 1) << PAGE_SHIFT) typedef struct _MEMORY_AREA { MMVAD VadNode; - ULONG_PTR StartingVpn; - ULONG_PTR EndingVpn; - struct _MEMORY_AREA *Parent; - struct _MEMORY_AREA *LeftChild; - struct _MEMORY_AREA *RightChild; + ULONG Type; ULONG Protect; ULONG Flags; Modified: trunk/reactos/ntoskrnl/mm/ARM3/virtual.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/ARM3/virtual.c…
============================================================================== --- trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/ARM3/virtual.c [iso-8859-1] Fri Aug 18 07:13:34 2017 @@ -5383,10 +5383,10 @@ Vad->u.VadFlags.CommitCharge -= CommitReduction; // For ReactOS: shrink the corresponding memory area MemoryArea = MmLocateMemoryAreaByAddress(AddressSpace, (PVOID)StartingAddress); - ASSERT(Vad->StartingVpn == MemoryArea->StartingVpn); - ASSERT(Vad->EndingVpn == MemoryArea->EndingVpn); + ASSERT(Vad->StartingVpn == MemoryArea->VadNode.StartingVpn); + ASSERT(Vad->EndingVpn == MemoryArea->VadNode.EndingVpn); Vad->EndingVpn = (StartingAddress - 1) >> PAGE_SHIFT; - MemoryArea->EndingVpn = Vad->EndingVpn; + MemoryArea->VadNode.EndingVpn = Vad->EndingVpn; } else { Modified: trunk/reactos/ntoskrnl/mm/marea.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/ntoskrnl/mm/marea.c?rev=75…
============================================================================== --- trunk/reactos/ntoskrnl/mm/marea.c [iso-8859-1] (original) +++ trunk/reactos/ntoskrnl/mm/marea.c [iso-8859-1] Fri Aug 18 07:13:34 2017 @@ -169,13 +169,11 @@ { PEPROCESS Process = MmGetAddressSpaceOwner(AddressSpace); - marea->VadNode.StartingVpn = marea->StartingVpn; - marea->VadNode.EndingVpn = marea->EndingVpn; marea->VadNode.u.VadFlags.Spare = 1; marea->VadNode.u.VadFlags.Protection = MiMakeProtectionMask(marea->Protect); /* Build a lame VAD if this is a user-space allocation */ - if (marea->EndingVpn + 1 < (ULONG_PTR)MmSystemRangeStart >> PAGE_SHIFT) + if (marea->VadNode.EndingVpn + 1 < (ULONG_PTR)MmSystemRangeStart >> PAGE_SHIFT) { ASSERT(Process != NULL); if (marea->Type != MEMORY_AREA_OWNED_BY_ARM3) @@ -354,7 +352,7 @@ //if (MemoryArea->VadNode.StartingVpn < (ULONG_PTR)MmSystemRangeStart >> PAGE_SHIFT if (MemoryArea->Vad) { - ASSERT(MemoryArea->EndingVpn + 1 < (ULONG_PTR)MmSystemRangeStart >> PAGE_SHIFT); + ASSERT(MemoryArea->VadNode.EndingVpn + 1 < (ULONG_PTR)MmSystemRangeStart >> PAGE_SHIFT); ASSERT(MemoryArea->Type == MEMORY_AREA_SECTION_VIEW || MemoryArea->Type == MEMORY_AREA_CACHE); /* MmCleanProcessAddressSpace might have removed it (and this would be MmDeleteProcessAdressSpace) */ @@ -470,8 +468,8 @@ return STATUS_NO_MEMORY; } - MemoryArea->StartingVpn = (ULONG_PTR)*BaseAddress >> PAGE_SHIFT; - MemoryArea->EndingVpn = ((ULONG_PTR)*BaseAddress + tmpLength - 1) >> PAGE_SHIFT; + MemoryArea->VadNode.StartingVpn = (ULONG_PTR)*BaseAddress >> PAGE_SHIFT; + MemoryArea->VadNode.EndingVpn = ((ULONG_PTR)*BaseAddress + tmpLength - 1) >> PAGE_SHIFT; MmInsertMemoryArea(AddressSpace, MemoryArea); } else @@ -508,8 +506,8 @@ } } - MemoryArea->StartingVpn = (ULONG_PTR)*BaseAddress >> PAGE_SHIFT; - MemoryArea->EndingVpn = ((ULONG_PTR)*BaseAddress + tmpLength - 1) >> PAGE_SHIFT; + MemoryArea->VadNode.StartingVpn = (ULONG_PTR)*BaseAddress >> PAGE_SHIFT; + MemoryArea->VadNode.EndingVpn = ((ULONG_PTR)*BaseAddress + tmpLength - 1) >> PAGE_SHIFT; MmInsertMemoryArea(AddressSpace, MemoryArea); }
7 years, 4 months
1
0
0
0
[gadamopoulos] 75601: [WIN32K] -Fix a bug with TransparentBlt when it should really ignore the alpha channel. CORE-13040. Approved by Timo.
by gadamopoulos@svn.reactos.org
Author: gadamopoulos Date: Thu Aug 17 22:45:51 2017 New Revision: 75601 URL:
http://svn.reactos.org/svn/reactos?rev=75601&view=rev
Log: [WIN32K] -Fix a bug with TransparentBlt when it should really ignore the alpha channel. CORE-13040. Approved by Timo. Modified: trunk/reactos/win32ss/gdi/dib/dib32bpp.c Modified: trunk/reactos/win32ss/gdi/dib/dib32bpp.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/win32ss/gdi/dib/dib32bpp.c…
============================================================================== --- trunk/reactos/win32ss/gdi/dib/dib32bpp.c [iso-8859-1] (original) +++ trunk/reactos/win32ss/gdi/dib/dib32bpp.c [iso-8859-1] Thu Aug 17 22:45:51 2017 @@ -312,7 +312,7 @@ SourceSurf->sizlBitmap.cx > SourceX && SourceSurf->sizlBitmap.cy > SourceY) { Source = DIB_GetSourceIndex(SourceSurf, SourceX, SourceY); - if (Source != iTransColor) + if ((0x00FFFFFF & Source) != (0x00FFFFFF & iTransColor)) { *DestBits = XLATEOBJ_iXlate(ColorTranslation, Source); }
7 years, 4 months
1
0
0
0
[gadamopoulos] 75600: [UXTHEME] -Remove some dead code
by gadamopoulos@svn.reactos.org
Author: gadamopoulos Date: Thu Aug 17 21:31:52 2017 New Revision: 75600 URL:
http://svn.reactos.org/svn/reactos?rev=75600&view=rev
Log: [UXTHEME] -Remove some dead code Modified: trunk/reactos/dll/win32/uxtheme/nonclient.c Modified: trunk/reactos/dll/win32/uxtheme/nonclient.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/uxtheme/nonclien…
============================================================================== --- trunk/reactos/dll/win32/uxtheme/nonclient.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/uxtheme/nonclient.c [iso-8859-1] Thu Aug 17 21:31:52 2017 @@ -7,26 +7,6 @@ */ #include "uxthemep.h" - -HFONT hMenuFont = NULL; -HFONT hMenuFontBold = NULL; - -void InitMenuFont(VOID) -{ - NONCLIENTMETRICS ncm; - - ncm.cbSize = sizeof(NONCLIENTMETRICS); - - if (!SystemParametersInfo(SPI_GETNONCLIENTMETRICS, sizeof(ncm), &ncm, 0)) - { - return; - } - - hMenuFont = CreateFontIndirect(&ncm.lfMenuFont); - - ncm.lfMenuFont.lfWeight = max(ncm.lfMenuFont.lfWeight + 300, 1000); - hMenuFontBold = CreateFontIndirect(&ncm.lfMenuFont); -} static BOOL IsWindowActive(HWND hWnd, DWORD ExStyle)
7 years, 4 months
1
0
0
0
[tfaber] 75599: [USBHUB_NEW] - Fix interval calculation in USBH_Wait. Patch by Vadim Galyant.
by tfaber@svn.reactos.org
Author: tfaber Date: Thu Aug 17 19:55:13 2017 New Revision: 75599 URL:
http://svn.reactos.org/svn/reactos?rev=75599&view=rev
Log: [USBHUB_NEW] - Fix interval calculation in USBH_Wait. Patch by Vadim Galyant. Modified: trunk/reactos/drivers/usb/usbhub_new/usbhub.c Modified: trunk/reactos/drivers/usb/usbhub_new/usbhub.c URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/usb/usbhub_new/usb…
============================================================================== --- trunk/reactos/drivers/usb/usbhub_new/usbhub.c [iso-8859-1] (original) +++ trunk/reactos/drivers/usb/usbhub_new/usbhub.c [iso-8859-1] Thu Aug 17 19:55:13 2017 @@ -18,7 +18,7 @@ LARGE_INTEGER Interval; DPRINT("USBH_Wait: Milliseconds - %x\n", Milliseconds); - Interval.QuadPart = -10000 * Milliseconds + (KeQueryTimeIncrement() - 1); + Interval.QuadPart = -10000LL * Milliseconds - ((ULONGLONG)KeQueryTimeIncrement() - 1); return KeDelayExecutionThread(KernelMode, FALSE, &Interval); }
7 years, 4 months
1
0
0
0
[tfaber] 75598: [CMIDriver] - Set svn:eol-style to CRLF for inf files. Files that end up on the iso should never have 'native' line endings.
by tfaber@svn.reactos.org
Author: tfaber Date: Thu Aug 17 19:25:32 2017 New Revision: 75598 URL:
http://svn.reactos.org/svn/reactos?rev=75598&view=rev
Log: [CMIDriver] - Set svn:eol-style to CRLF for inf files. Files that end up on the iso should never have 'native' line endings. Modified: trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32-WaveRT.inf (contents, props changed) trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32.inf (contents, props changed) trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64-WaveRT.inf (contents, props changed) trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64.inf (contents, props changed) [This mail would be too long, it was shortened to contain the URLs only.] Modified: trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32-WaveRT.inf URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/drivers/…
Modified: trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CM8738-x32.inf URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/drivers/…
Modified: trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64-WaveRT.inf URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/drivers/…
Modified: trunk/reactos/drivers/wdm/audio/drivers/CMIDriver/CM8738-x64.inf URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/wdm/audio/drivers/…
7 years, 4 months
1
0
0
0
[gadamopoulos] 75597: [SHELL32] -Simplify some coe in CShellLink.cpp
by gadamopoulos@svn.reactos.org
Author: gadamopoulos Date: Thu Aug 17 16:46:15 2017 New Revision: 75597 URL:
http://svn.reactos.org/svn/reactos?rev=75597&view=rev
Log: [SHELL32] -Simplify some coe in CShellLink.cpp Modified: trunk/reactos/dll/win32/shell32/CShellLink.cpp Modified: trunk/reactos/dll/win32/shell32/CShellLink.cpp URL:
http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shell32/CShellLi…
============================================================================== --- trunk/reactos/dll/win32/shell32/CShellLink.cpp [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shell32/CShellLink.cpp [iso-8859-1] Thu Aug 17 16:46:15 2017 @@ -1690,28 +1690,31 @@ return S_OK; } -static HRESULT SHELL_PidlGetIconLocationW(IShellFolder* psf, LPCITEMIDLIST pidl, +static HRESULT SHELL_PidlGetIconLocationW(PCIDLIST_ABSOLUTE pidl, UINT uFlags, PWSTR pszIconFile, UINT cchMax, int *piIndex, UINT *pwFlags) { LPCITEMIDLIST pidlLast; + CComPtr<IShellFolder> psf; HRESULT hr = SHBindToParent(pidl, IID_PPV_ARG(IShellFolder, &psf), &pidlLast); - if (SUCCEEDED(hr)) - { - CComPtr<IExtractIconW> pei; - - hr = psf->GetUIObjectOf(0, 1, &pidlLast, IID_NULL_PPV_ARG(IExtractIconW, &pei)); - if (SUCCEEDED(hr)) - hr = pei->GetIconLocation(uFlags, pszIconFile, cchMax, piIndex, pwFlags); - - psf->Release(); - } - - return hr; + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + CComPtr<IExtractIconW> pei; + hr = psf->GetUIObjectOf(0, 1, &pidlLast, IID_NULL_PPV_ARG(IExtractIconW, &pei)); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + hr = pei->GetIconLocation(uFlags, pszIconFile, cchMax, piIndex, pwFlags); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + return S_OK; } HRESULT STDMETHODCALLTYPE CShellLink::GetIconLocation(UINT uFlags, PWSTR pszIconFile, UINT cchMax, int *piIndex, UINT *pwFlags) { + HRESULT hr; /* * It is possible for a shell link to point to another shell link, * and in particular there is the possibility to point to itself. @@ -1732,33 +1735,30 @@ if (m_pPidl || m_sPath) { - CComPtr<IShellFolder> pdsk; - - HRESULT hr = SHGetDesktopFolder(&pdsk); - if (SUCCEEDED(hr)) - { - /* first look for an icon using the PIDL (if present) */ - if (m_pPidl) - hr = SHELL_PidlGetIconLocationW(pdsk, m_pPidl, uFlags, pszIconFile, cchMax, piIndex, pwFlags); - else - hr = E_FAIL; + /* first look for an icon using the PIDL (if present) */ + if (m_pPidl) + hr = SHELL_PidlGetIconLocationW(m_pPidl, uFlags, pszIconFile, cchMax, piIndex, pwFlags); + else + hr = E_FAIL; #if 0 // FIXME: Analyse further whether this is needed... - /* if we couldn't find an icon yet, look for it using the file system path */ - if (FAILED(hr) && m_sPath) + /* if we couldn't find an icon yet, look for it using the file system path */ + if (FAILED(hr) && m_sPath) + { + LPITEMIDLIST pidl; + CComPtr<IShellFolder> pdsk; + + hr = SHGetDesktopFolder(&pdsk); + + /* LPITEMIDLIST pidl = ILCreateFromPathW(sPath); */ + hr = pdsk->ParseDisplayName(0, NULL, m_sPath, NULL, &pidl, NULL); + if (SUCCEEDED(hr)) { - LPITEMIDLIST pidl; - - /* LPITEMIDLIST pidl = ILCreateFromPathW(sPath); */ - hr = pdsk->ParseDisplayName(0, NULL, m_sPath, NULL, &pidl, NULL); - if (SUCCEEDED(hr)) - { - hr = SHELL_PidlGetIconLocationW(pdsk, pidl, uFlags, pszIconFile, cchMax, piIndex, pwFlags); - SHFree(pidl); - } + hr = SHELL_PidlGetIconLocationW(pidl, uFlags, pszIconFile, cchMax, piIndex, pwFlags); + SHFree(pidl); } + } #endif - } return hr; }
7 years, 4 months
1
0
0
0
← Newer
1
...
10
11
12
13
14
15
16
...
27
Older →
Jump to page:
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
Results per page:
10
25
50
100
200