Ros-diffs August 2017

ros-diffs@reactos.org

22 participants
262 discussions

[spetreolle] 75486: Revert r75485, MSVC needs wininet to do the UrlCrackW forward.

by spetreolle＠svn.reactos.org

Author: spetreolle Date: Fri Aug 4 23:39:15 2017 New Revision: 75486 URL: http://svn.reactos.org/svn/reactos?rev=75486&view=rev Log: Revert r75485, MSVC needs wininet to do the UrlCrackW forward. Modified: trunk/reactos/dll/win32/shlwapi/CMakeLists.txt Modified: trunk/reactos/dll/win32/shlwapi/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shlwapi/CMakeLis… ============================================================================== --- trunk/reactos/dll/win32/shlwapi/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shlwapi/CMakeLists.txt [iso-8859-1] Fri Aug 4 23:39:15 2017 @@ -38,6 +38,6 @@ set_module_type(shlwapi win32dll) target_link_libraries(shlwapi uuid wine) add_delay_importlibs(shlwapi userenv oleaut32 ole32 comdlg32 mpr mlang urlmon shell32 winmm version) -add_importlibs(shlwapi user32 gdi32 advapi32 msvcrt kernel32 ntdll) +add_importlibs(shlwapi user32 gdi32 advapi32 wininet msvcrt kernel32 ntdll) add_pch(shlwapi precomp.h SOURCE) add_cd_file(TARGET shlwapi DESTINATION reactos/system32 FOR all)

7 years, 1 month

[spetreolle] 75485: Remove a theoretical circular dependancy between wininet and shlwapi. shlwapi actually doesn't use wininet.

by spetreolle＠svn.reactos.org

Author: spetreolle Date: Fri Aug 4 23:06:54 2017 New Revision: 75485 URL: http://svn.reactos.org/svn/reactos?rev=75485&view=rev Log: Remove a theoretical circular dependancy between wininet and shlwapi. shlwapi actually doesn't use wininet. Modified: trunk/reactos/dll/win32/shlwapi/CMakeLists.txt Modified: trunk/reactos/dll/win32/shlwapi/CMakeLists.txt URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/shlwapi/CMakeLis… ============================================================================== --- trunk/reactos/dll/win32/shlwapi/CMakeLists.txt [iso-8859-1] (original) +++ trunk/reactos/dll/win32/shlwapi/CMakeLists.txt [iso-8859-1] Fri Aug 4 23:06:54 2017 @@ -38,6 +38,6 @@ set_module_type(shlwapi win32dll) target_link_libraries(shlwapi uuid wine) add_delay_importlibs(shlwapi userenv oleaut32 ole32 comdlg32 mpr mlang urlmon shell32 winmm version) -add_importlibs(shlwapi user32 gdi32 advapi32 wininet msvcrt kernel32 ntdll) +add_importlibs(shlwapi user32 gdi32 advapi32 msvcrt kernel32 ntdll) add_pch(shlwapi precomp.h SOURCE) add_cd_file(TARGET shlwapi DESTINATION reactos/system32 FOR all)

7 years, 1 month

[pschweitzer] 75484: [NFS] And make NP a bit more discrete when not really used...

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Fri Aug 4 19:46:32 2017 New Revision: 75484 URL: http://svn.reactos.org/svn/reactos?rev=75484&view=rev Log: [NFS] And make NP a bit more discrete when not really used... Modified: trunk/reactos/dll/np/nfs/nfs41_np.c Modified: trunk/reactos/dll/np/nfs/nfs41_np.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/np/nfs/nfs41_np.c?rev=… ============================================================================== --- trunk/reactos/dll/np/nfs/nfs41_np.c [iso-8859-1] (original) +++ trunk/reactos/dll/np/nfs/nfs41_np.c [iso-8859-1] Fri Aug 4 19:46:32 2017 @@ -329,7 +329,9 @@ { DWORD rc = 0; +#ifndef __REACTOS__ DbgP(( L"[aglo] GetNetCaps %d\n", nIndex )); +#endif switch ( nIndex ) { case WNNC_SPEC_VERSION:

7 years, 1 month

[pschweitzer] 75483: [NFS] Make hack introduced in r75415 more verbose. CORE-8204 CORE-11327

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Fri Aug 4 19:43:42 2017 New Revision: 75483 URL: http://svn.reactos.org/svn/reactos?rev=75483&view=rev Log: [NFS] Make hack introduced in r75415 more verbose. CORE-8204 CORE-11327 Modified: trunk/reactos/drivers/filesystems/nfs/nfs41_driver.c Modified: trunk/reactos/drivers/filesystems/nfs/nfs41_driver.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/drivers/filesystems/nfs/nf… ============================================================================== --- trunk/reactos/drivers/filesystems/nfs/nfs41_driver.c [iso-8859-1] (original) +++ trunk/reactos/drivers/filesystems/nfs/nfs41_driver.c [iso-8859-1] Fri Aug 4 19:43:42 2017 @@ -46,6 +46,7 @@ #define USE_MOUNT_SEC_CONTEXT /* debugging printout defines */ +//#define DEBUG_FSDDISPATCH #define DEBUG_MARSHAL_HEADER #define DEBUG_MARSHAL_DETAIL //#define DEBUG_OPEN @@ -2450,6 +2451,12 @@ } break; } + + default: + { + DbgP("Other node found: %x\n", NodeType(Container)); + break; + } } } } @@ -2459,6 +2466,10 @@ RxReleasePrefixTableLock(RxContext->RxDeviceObject->pRxNetNameTable); } #undef DUMP_FCB_TABLE_FROM_NETROOT + } + else + { + DbgP("RxNetNameTable is NULL for: %p\n", RxContext->RxDeviceObject); } #endif status = STATUS_REDIRECTOR_HAS_OPEN_HANDLES;

7 years, 1 month

[pschweitzer] 75482: [RDBSS] Implement RxSetDispositionInfo(): this allows deleting files on a remote NFS share! CORE-8204 CORE-11327 CORE-13636

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Fri Aug 4 19:23:42 2017 New Revision: 75482 URL: http://svn.reactos.org/svn/reactos?rev=75482&view=rev Log: [RDBSS] Implement RxSetDispositionInfo(): this allows deleting files on a remote NFS share! CORE-8204 CORE-11327 CORE-13636 Modified: trunk/reactos/sdk/lib/drivers/rdbsslib/rdbss.c Modified: trunk/reactos/sdk/lib/drivers/rdbsslib/rdbss.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/drivers/rdbsslib/r… ============================================================================== --- trunk/reactos/sdk/lib/drivers/rdbsslib/rdbss.c [iso-8859-1] (original) +++ trunk/reactos/sdk/lib/drivers/rdbsslib/rdbss.c [iso-8859-1] Fri Aug 4 19:23:42 2017 @@ -8605,12 +8605,47 @@ return Status; } +/* + * @implemented + */ NTSTATUS RxSetDispositionInfo( PRX_CONTEXT RxContext) { - UNIMPLEMENTED; - return STATUS_NOT_IMPLEMENTED; + NTSTATUS Status; + + PAGED_CODE(); + + /* First, make the mini-rdr work! */ + Status = RxpSetInfoMiniRdr(RxContext, FileDispositionInformation); + /* If it succeed, we'll keep track of the change */ + if (NT_SUCCESS(Status)) + { + PFCB Fcb; + PFILE_OBJECT FileObject; + PFILE_DISPOSITION_INFORMATION FileDispo; + + Fcb = (PFCB)RxContext->pFcb; + FileObject = RxContext->CurrentIrpSp->FileObject; + FileDispo = RxContext->CurrentIrp->AssociatedIrp.SystemBuffer; + /* Caller asks for deletion: mark as delete on close */ + if (FileDispo->DeleteFile) + { + SetFlag(Fcb->FcbState, FCB_STATE_DELETE_ON_CLOSE); + FileObject->DeletePending = TRUE; + } + /* Otherwise, clear it */ + else + { + ClearFlag(Fcb->FcbState, FCB_STATE_DELETE_ON_CLOSE); + FileObject->DeletePending = FALSE; + } + + /* Sanitize output */ + Status = STATUS_SUCCESS; + } + + return Status; } NTSTATUS

7 years, 1 month

[pschweitzer] 75481: [RDBSS] On cleanup, only take the quick path if the file was already orphaned CORE-11327

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Fri Aug 4 19:18:42 2017 New Revision: 75481 URL: http://svn.reactos.org/svn/reactos?rev=75481&view=rev Log: [RDBSS] On cleanup, only take the quick path if the file was already orphaned CORE-11327 Modified: trunk/reactos/sdk/lib/drivers/rdbsslib/rdbss.c Modified: trunk/reactos/sdk/lib/drivers/rdbsslib/rdbss.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/drivers/rdbsslib/r… ============================================================================== --- trunk/reactos/sdk/lib/drivers/rdbsslib/rdbss.c [iso-8859-1] (original) +++ trunk/reactos/sdk/lib/drivers/rdbsslib/rdbss.c [iso-8859-1] Fri Aug 4 19:18:42 2017 @@ -1847,8 +1847,8 @@ Fobx->AssociatedFileObject = NULL; - /* In case SRV_OPEN used is part of FCB */ - if (BooleanFlagOn(Fcb->FcbState, FCB_STATE_SRVOPEN_USED)) + /* In case it was already orphaned */ + if (BooleanFlagOn(Fcb->FcbState, FCB_STATE_ORPHANED)) { ASSERT(Fcb->UncleanCount != 0); InterlockedDecrement((volatile long *)&Fcb->UncleanCount);

7 years, 1 month

[pschweitzer] 75480: [RXCE] In RxRemoveNameNetFcb(), check if name was already removed. MS doesn't do this, but as we use double linked-list macros that perform extra sanity checks, this is require...

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Fri Aug 4 19:05:11 2017 New Revision: 75480 URL: http://svn.reactos.org/svn/reactos?rev=75480&view=rev Log: [RXCE] In RxRemoveNameNetFcb(), check if name was already removed. MS doesn't do this, but as we use double linked-list macros that perform extra sanity checks, this is required. This can be called twice for a single FCB. CORE-11327 CORE-13632 CORE-13636 Modified: trunk/reactos/sdk/lib/drivers/rxce/rxce.c Modified: trunk/reactos/sdk/lib/drivers/rxce/rxce.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/sdk/lib/drivers/rxce/rxce.… ============================================================================== --- trunk/reactos/sdk/lib/drivers/rxce/rxce.c [iso-8859-1] (original) +++ trunk/reactos/sdk/lib/drivers/rxce/rxce.c [iso-8859-1] Fri Aug 4 19:05:11 2017 @@ -7533,10 +7533,17 @@ ASSERT(RxIsFcbTableLockExclusive(&NetRoot->FcbTable)); ASSERT(RxIsFcbAcquiredExclusive(ThisFcb)); - RxFcbTableRemoveFcb(&NetRoot->FcbTable, ThisFcb); - DPRINT("FCB (%p) %wZ removed\n", ThisFcb, &ThisFcb->FcbTableEntry.Path); - /* Mark, so that we don't try to do it twice */ - SetFlag(ThisFcb->FcbState, FCB_STATE_NAME_ALREADY_REMOVED); +#ifdef __REACTOS__ + if (!BooleanFlagOn(ThisFcb->FcbState, FCB_STATE_NAME_ALREADY_REMOVED)) + { +#endif + RxFcbTableRemoveFcb(&NetRoot->FcbTable, ThisFcb); + DPRINT("FCB (%p) %wZ removed\n", ThisFcb, &ThisFcb->FcbTableEntry.Path); + /* Mark, so that we don't try to do it twice */ + SetFlag(ThisFcb->FcbState, FCB_STATE_NAME_ALREADY_REMOVED); +#ifdef __REACTOS__ + } +#endif } /*

7 years, 1 month

[tthompson] 75479: [NTFS] - Fix index entries storing the wrong allocated file size when the file is resident. Fix a typo in a DPRINT.

by tthompson＠svn.reactos.org

Author: tthompson Date: Fri Aug 4 17:58:06 2017 New Revision: 75479 URL: http://svn.reactos.org/svn/reactos?rev=75479&view=rev Log: [NTFS] - Fix index entries storing the wrong allocated file size when the file is resident. Fix a typo in a DPRINT. Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/finfo.c branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/rw.c Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/finfo.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesyst… ============================================================================== --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/finfo.c [iso-8859-1] (original) +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/finfo.c [iso-8859-1] Fri Aug 4 17:58:06 2017 @@ -597,7 +597,7 @@ DPRINT("Found record for %wS\n", Fcb->ObjectName); - CurrentFileSize.QuadPart = NtfsGetFileSize(DeviceExt, FileRecord, L"", 0, (PULONGLONG)&CurrentFileSize); + CurrentFileSize.QuadPart = NtfsGetFileSize(DeviceExt, FileRecord, L"", 0, NULL); // Are we trying to decrease the file size? if (NewFileSize->QuadPart < CurrentFileSize.QuadPart) @@ -673,7 +673,7 @@ FileName.Length = FileNameAttribute->NameLength * sizeof(WCHAR); FileName.MaximumLength = FileName.Length; - AllocationSize = ROUND_UP(NewFileSize->QuadPart, Fcb->Vcb->NtfsInfo.BytesPerCluster); + AllocationSize = AttributeAllocatedLength(&DataContext->Record); Status = UpdateFileNameRecord(Fcb->Vcb, ParentMFTId, Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesyst… ============================================================================== --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c [iso-8859-1] (original) +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/mft.c [iso-8859-1] Fri Aug 4 17:58:06 2017 @@ -173,7 +173,7 @@ if (AttrRecord->IsNonResident) return AttrRecord->NonResident.AllocatedSize; else - return AttrRecord->Resident.ValueLength; + return ALIGN_UP_BY(AttrRecord->Resident.ValueLength, ATTR_RECORD_ALIGNMENT); } @@ -399,7 +399,7 @@ { NTSTATUS Status = STATUS_SUCCESS; - DPRINT1("SetAttributeDataLenth(%p, %p, %p, %lu, %p, %I64u)\n", + DPRINT1("SetAttributeDataLength(%p, %p, %p, %lu, %p, %I64u)\n", FileObject, Fcb, AttrContext, Modified: branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/rw.c URL: http://svn.reactos.org/svn/reactos/branches/GSoC_2016/NTFS/drivers/filesyst… ============================================================================== --- branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/rw.c [iso-8859-1] (original) +++ branches/GSoC_2016/NTFS/drivers/filesystems/ntfs/rw.c [iso-8859-1] Fri Aug 4 17:58:06 2017 @@ -432,11 +432,8 @@ DataSize.QuadPart = WriteOffset + Length; - AllocationSize = ROUND_UP(DataSize.QuadPart, Fcb->Vcb->NtfsInfo.BytesPerCluster); - // set the attribute data length Status = SetAttributeDataLength(FileObject, Fcb, DataContext, AttributeOffset, FileRecord, &DataSize); - if (!NT_SUCCESS(Status)) { ReleaseAttributeContext(DataContext); @@ -444,6 +441,8 @@ *LengthWritten = 0; return Status; } + + AllocationSize = AttributeAllocatedLength(&DataContext->Record); // now we need to update this file's size in every directory index entry that references it // TODO: put this code in its own function and adapt it to work with every filename / hardlink

7 years, 1 month

[pschweitzer] 75478: [KERNEL32] Don't leak a handle when renaming a source file which is a MS mount point or a file without the reparse attribute while we can query its reparse information. CORE-13635

by pschweitzer＠svn.reactos.org

Author: pschweitzer Date: Fri Aug 4 12:18:52 2017 New Revision: 75478 URL: http://svn.reactos.org/svn/reactos?rev=75478&view=rev Log: [KERNEL32] Don't leak a handle when renaming a source file which is a MS mount point or a file without the reparse attribute while we can query its reparse information. CORE-13635 Modified: trunk/reactos/dll/win32/kernel32/client/file/move.c Modified: trunk/reactos/dll/win32/kernel32/client/file/move.c URL: http://svn.reactos.org/svn/reactos/trunk/reactos/dll/win32/kernel32/client/… ============================================================================== --- trunk/reactos/dll/win32/kernel32/client/file/move.c [iso-8859-1] (original) +++ trunk/reactos/dll/win32/kernel32/client/file/move.c [iso-8859-1] Fri Aug 4 12:18:52 2017 @@ -771,6 +771,11 @@ { NtClose(SourceHandle); SourceHandle = INVALID_HANDLE_VALUE; + } + else + { + /* Mount point, let's rename it */ + AttemptReopenWithoutReparse = FALSE; } }

7 years, 1 month

[gadamopoulos] 75477: [hivecls.inf] -Add an option to immediately enable an msstyles file with right click.

by gadamopoulos＠svn.reactos.org

Author: gadamopoulos Date: Fri Aug 4 09:12:33 2017 New Revision: 75477 URL: http://svn.reactos.org/svn/reactos?rev=75477&view=rev Log: [hivecls.inf] -Add an option to immediately enable an msstyles file with right click. Modified: trunk/reactos/boot/bootdata/hivecls.inf Modified: trunk/reactos/boot/bootdata/hivecls.inf URL: http://svn.reactos.org/svn/reactos/trunk/reactos/boot/bootdata/hivecls.inf?… ============================================================================== --- trunk/reactos/boot/bootdata/hivecls.inf [iso-8859-1] (original) +++ trunk/reactos/boot/bootdata/hivecls.inf [iso-8859-1] Fri Aug 4 09:12:33 2017 @@ -413,6 +413,7 @@ HKCR,"msstylesfile","",0x00000000,%MSSTYLESFILE% HKCR,"msstylesfile\DefaultIcon","","0x00020000","%SystemRoot%\system32\themeui.dll,-1" HKCR,"msstylesfile\shell\open\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:OpenMSTheme /file:""%1""" +HKCR,"msstylesfile\shell\Enable\command","",0x00000000,"%SystemRoot%\system32\rundll32.exe shell32.dll,Control_RunDLL %SystemRoot%\system32\desk.cpl desk,@Appearance /Action:ActivateMSTheme /file:""%1""" ; Theme Files HKCR,".theme","",0x00000000,"themefile"

7 years, 1 month

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs August 2017