Ros-diffs November 2018

ros-diffs@reactos.org

29 participants
250 discussions

[reactos] 01/01: [MC] Fix syntax errors in errcodes.mc
by William Kent 20 Nov '18

20 Nov '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=c1b4d51f0b1e6988ab24b… commit c1b4d51f0b1e6988ab24b2ec22679aadc6e0aceb Author: William Kent <wjk011(a)gmail.com> AuthorDate: Tue Nov 20 13:38:52 2018 -0500 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Wed Nov 21 00:15:42 2018 +0100 [MC] Fix syntax errors in errcodes.mc This was causing the MSVC build to fail. --- sdk/include/reactos/mc/errcodes.mc | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/sdk/include/reactos/mc/errcodes.mc b/sdk/include/reactos/mc/errcodes.mc index 726329129a..2e29aea662 100644 --- a/sdk/include/reactos/mc/errcodes.mc +++ b/sdk/include/reactos/mc/errcodes.mc @@ -27391,9 +27391,10 @@ ERROR_DS_SAM_INIT_FAILURE - Security Accounts Manager initialization failed beca Error Status: 0x%2. Click OK to shut down the system and reboot into Directory Services Restore Mode. Check the event log for detailed information. . Language=Polish -Language=Romanian ERROR_DS_SAM_INIT_FAILURE - Security Accounts Manager initialization failed because of the following error: %1. Error Status: 0x%2. Click OK to shut down the system and reboot into Directory Services Restore Mode. Check the event log for detailed information. +. +Language=Romanian ERROR_DS_SAM_INIT_FAILURE - Security Accounts Manager initialization failed because of the following error: %1. Error Status: 0x%2. Click OK to shut down the system and reboot into Directory Services Restore Mode. Check the event log for detailed information. . @@ -28023,9 +28024,10 @@ ERROR_SAM_INIT_FAILURE - Security Accounts Manager initialization failed because Error Status: 0x%2. Click OK to shut down the system and reboot into Safe Mode. Check the event log for detailed information. . Language=Polish -Language=Romanian ERROR_SAM_INIT_FAILURE - Security Accounts Manager initialization failed because of the following error: %1. Error Status: 0x%2. Click OK to shut down the system and reboot into Safe Mode. Check the event log for detailed information. +. +Language=Romanian ERROR_SAM_INIT_FAILURE - Security Accounts Manager initialization failed because of the following error: %1. Error Status: 0x%2. Click OK to shut down the system and reboot into Safe Mode. Check the event log for detailed information. . @@ -28366,9 +28368,10 @@ ERROR_DS_INIT_FAILURE_CONSOLE - Directory Services could not start because of th Error Status: 0x%2. Please click OK to shutdown the system. You can use the recovery console to diagnose the system further. . Language=Polish -Language=Romanian ERROR_DS_INIT_FAILURE_CONSOLE - Directory Services could not start because of the following error: %1. Error Status: 0x%2. Please click OK to shutdown the system. You can use the recovery console to diagnose the system further. +. +Language=Romanian ERROR_DS_INIT_FAILURE_CONSOLE - Directory Services could not start because of the following error: %1. Error Status: 0x%2. Please click OK to shutdown the system. You can use the recovery console to diagnose the system further. . @@ -28386,9 +28389,10 @@ ERROR_DS_SAM_INIT_FAILURE_CONSOLE - Security Accounts Manager initialization fai Error Status: 0x%2. Please click OK to shutdown the system. You can use the recovery console to diagnose the system further. . Language=Polish -Language=Romanian ERROR_DS_SAM_INIT_FAILURE_CONSOLE - Security Accounts Manager initialization failed because of the following error: %1. Error Status: 0x%2. Please click OK to shutdown the system. You can use the recovery console to diagnose the system further. +. +Language=Romanian ERROR_DS_SAM_INIT_FAILURE_CONSOLE - Security Accounts Manager initialization failed because of the following error: %1. Error Status: 0x%2. Please click OK to shutdown the system. You can use the recovery console to diagnose the system further. .

1 0

[reactos] 01/01: Update README.md (#1051)
by Adam Stachowicz 20 Nov '18

20 Nov '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=3562339a8847e3348044f… commit 3562339a8847e3348044f73e644c36383f41cea0 Author: Adam Stachowicz <saibamenppl(a)gmail.com> AuthorDate: Tue Nov 20 23:59:18 2018 +0100 Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> CommitDate: Tue Nov 20 23:59:18 2018 +0100 Update README.md (#1051) Powered by markdownlint ;) --- README.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/README.md b/README.md index 5fec87b8c0..fd21dfaddd 100644 --- a/README.md +++ b/README.md @@ -27,7 +27,7 @@ </a> </p> -## Quick Links +## Quick Links - [Website](https://reactos.org) - [Wiki](https://reactos.org/wiki) @@ -44,14 +44,14 @@ The ReactOS project, although currently focused on Windows Server 2003 compatibi The code of ReactOS is licensed under [GNU GPL 2.0](https://github.com/reactos/reactos/blob/master/COPYING). -## Building +## Building [![appveyor.badge]][appveyor.link] [![travis.badge]][travis.link] [![rosbewin.badge]][rosbewin.link] [![rosbeunix.badge]][rosbeunix.link] [![coverity.badge]][coverity.link] -To build the system it is strongly advised to use the _ReactOS Build Environment (RosBE)._ -Up-to-date versions for Windows and for Unix/GNU-Linux are available from our download page at: http://www.reactos.org/wiki/Build_Environment. +To build the system it is strongly advised to use the _ReactOS Build Environment (RosBE)._ +Up-to-date versions for Windows and for Unix/GNU-Linux are available from our download page at: ["Build Environment"](http://www.reactos.org/wiki/Build_Environment). -Alternatively one can use Microsoft Visual C++ (MSVC) version 2010+. Building with MSVC is covered here: https://www.reactos.org/wiki/Building_with_MSVC. +Alternatively one can use Microsoft Visual C++ (MSVC) version 2010+. Building with MSVC is covered here: ["Visual Studio or Microsoft Visual C++"](https://www.reactos.org/wiki/CMake#Visual_Studio_or_Microsoft_Visual_C.2B.2B). ### Binaries @@ -69,7 +69,7 @@ You can always download fresh binary builds of bootable images from the ["Daily ## Installing By default, ReactOS currently can only be installed on a machine that has a FAT16 or FAT32 partition as the active (bootable) partition. -The partition on which ReactOS is to be installed (which may or may not be the bootable partition) must also be formatted as FAT16 or FAT32. +The partition on which ReactOS is to be installed (which may or may not be the bootable partition) must also be formatted as FAT16 or FAT32. ReactOS Setup can format the partitions if needed. Starting 0.4.10, ReactOS can be installed using the BtrFS file system. But @@ -82,7 +82,7 @@ See ["Installing ReactOS"](https://www.reactos.org/wiki/Installing_ReactOS) Wiki ## Testing -If you discover a bug in ReactOS search on JIRA first - it might be reported already. If not report the bug providing logs and as many information as possible. +If you discover a bug in ReactOS search on JIRA first - it might be reported already. If not report the bug providing logs and as much information as possible. See ["File Bugs"](https://www.reactos.org/wiki/File_Bugs) for a guide. @@ -103,25 +103,25 @@ It is not another wrapper built on Linux, like WINE. It does not attempt or plan ReactOS is also not "yet another OS". It does not attempt to be a third player like any other alternative OS out there. People are not meant to uninstall Linux and use ReactOS instead; ReactOS is a replacement for Windows users who want a Windows replacement that behaves just like Windows. -More information is available at: https://www.reactos.org. +More information is available at: [reactos.org](https://www.reactos.org). Also see the [media/doc](/media/doc/) subdirectory for some sparse notes. ## Who is responsible -Active devs are listed as members of [GitHub organization](https://github.com/orgs/reactos/people). +Active devs are listed as members of [GitHub organization](https://github.com/orgs/reactos/people). See also the [CREDITS](CREDITS) file for others. ## Code mirrors -The main development is done on [GitHub](https://github.com/reactos/reactos). We have an [alternative mirror](https://git.reactos.org/?p=reactos.git) in case GitHub is down. +The main development is done on [GitHub](https://github.com/reactos/reactos). We have an [alternative mirror](https://git.reactos.org/?p=reactos.git) in case GitHub is down. There is also an obsolete [SVN archive repository](https://svn.reactos.org/svn/reactos?view=revision) that is kept for historical purposes. [travis.badge]: https://travis-ci.org/reactos/reactos.svg?branch=master [appveyor.badge]: https://ci.appveyor.com/api/projects/status/github/reactos/reactos?branch=m… [coverity.badge]: https://scan.coverity.com/projects/205/badge.svg?flat=1 -[rosbewin.badge]: https://img.shields.io/badge/RosBE_Windows-2.1.6-0688CB.svg +[rosbewin.badge]: https://img.shields.io/badge/RosBE_Windows-2.1.6-0688CB.svg [rosbeunix.badge]: https://img.shields.io/badge/RosBE_Unix-2.1.2-0688CB.svg [prwelcome.badge]: https://img.shields.io/badge/PR-welcome-0688CB.svg @@ -129,4 +129,4 @@ There is also an obsolete [SVN archive repository](https://svn.reactos.org/svn/r [appveyor.link]: https://ci.appveyor.com/project/AmineKhaldi/reactos [coverity.link]: https://scan.coverity.com/projects/205 [rosbewin.link]: https://sourceforge.net/projects/reactos/files/RosBE-Windows/i386/2.1.6/ -[rosbeunix.link]: https://sourceforge.net/projects/reactos/files/RosBE-Unix/2.1.2/ +[rosbeunix.link]: https://sourceforge.net/projects/reactos/files/RosBE-Unix/2.1.2/

1 0

[reactos] 01/01: [IPHLPAPI] Fix checking entity when enumerating TCP/UDP connections
by Pierre Schweitzer 20 Nov '18

20 Nov '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8a98c85c1f7686a27db2c… commit 8a98c85c1f7686a27db2c095061f5224047c816f Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Tue Nov 20 22:12:47 2018 +0100 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Tue Nov 20 22:14:25 2018 +0100 [IPHLPAPI] Fix checking entity when enumerating TCP/UDP connections This fixes the API not to return the current TCP connections while enumerating them (and thus, netstat not displaying them). It seems we return garbage for now though --- dll/win32/iphlpapi/ipstats_reactos.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/dll/win32/iphlpapi/ipstats_reactos.c b/dll/win32/iphlpapi/ipstats_reactos.c index 242626ea7e..d8ec38f32b 100644 --- a/dll/win32/iphlpapi/ipstats_reactos.c +++ b/dll/win32/iphlpapi/ipstats_reactos.c @@ -611,7 +611,7 @@ DWORD getNumUdpEntries(void) status = tdiGetEntityIDSet( tcpFile, &entitySet, &numEntities ); for( i = 0; i < numEntities; i++ ) { - if( isInterface( &entitySet[i] ) && + if( entitySet[i].tei_entity == CL_TL_ENTITY && hasArp( tcpFile, &entitySet[i] ) ) { status = tdiGetSetOfThings( tcpFile, @@ -670,7 +670,7 @@ PMIB_UDPTABLE getUdpTable(void) status = tdiGetEntityIDSet( tcpFile, &entitySet, &numEntities ); for( i = 0; i < numEntities; i++ ) { - if( isInterface( &entitySet[i] ) && + if( entitySet[i].tei_entity == CL_TL_ENTITY && hasArp( tcpFile, &entitySet[i] ) ) { status = tdiGetSetOfThings( tcpFile, @@ -721,7 +721,7 @@ DWORD getNumTcpEntries(void) status = tdiGetEntityIDSet( tcpFile, &entitySet, &numEntities ); for( i = 0; i < numEntities; i++ ) { - if( isInterface( &entitySet[i] ) && + if( entitySet[i].tei_entity == CO_TL_ENTITY && hasArp( tcpFile, &entitySet[i] ) ) { status = tdiGetSetOfThings( tcpFile, @@ -780,7 +780,7 @@ PMIB_TCPTABLE getTcpTable(void) status = tdiGetEntityIDSet( tcpFile, &entitySet, &numEntities ); for( i = 0; i < numEntities; i++ ) { - if( isInterface( &entitySet[i] ) && + if( entitySet[i].tei_entity == CO_TL_ENTITY && hasArp( tcpFile, &entitySet[i] ) ) { status = tdiGetSetOfThings( tcpFile,

1 0

01/01: Add support for latest VS2017 (15.0) compiler (#1050)
by William Kent 19 Nov '18

19 Nov '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=f6f1255cf7b9166645092… commit f6f1255cf7b9166645092130576a40ee44932227 Author: William Kent <wjk011(a)gmail.com> AuthorDate: Mon Nov 19 11:34:08 2018 -0500 Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org> CommitDate: Mon Nov 19 17:34:08 2018 +0100 Add support for latest VS2017 (15.0) compiler (#1050) Latest VS 2017 CL.EXE compiler (version 19.16...) wasn't being correctly detected by the configure.cmd script. --- configure.cmd | 1 + 1 file changed, 1 insertion(+) diff --git a/configure.cmd b/configure.cmd index d8f44af545..b105aca271 100755 --- a/configure.cmd +++ b/configure.cmd @@ -72,6 +72,7 @@ if defined ROS_ARCH ( cl 2>&1 | find "19.13." > NUL && set VS_VERSION=15 cl 2>&1 | find "19.14." > NUL && set VS_VERSION=15 cl 2>&1 | find "19.15." > NUL && set VS_VERSION=15 + cl 2>&1 | find "19.16." > NUL && set VS_VERSION=15 if not defined VS_VERSION ( echo Error: Visual Studio version too old ^(before 10 ^(2010^)^) or version detection failed. goto quit

1 0

01/01: [NETSHELL] Fix '0' typo, in a text
by Serge Gautherie 19 Nov '18

19 Nov '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=154ed3706252d4c1e0ca4… commit 154ed3706252d4c1e0ca4f738668cd8dcbd2b0dd Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> AuthorDate: Mon Nov 19 02:06:48 2018 +0100 Commit: Giannis Adamopoulos <gadamopoulos(a)reactos.org> CommitDate: Mon Nov 19 09:57:42 2018 +0200 [NETSHELL] Fix '0' typo, in a text --- dll/shellext/netshell/README | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/shellext/netshell/README b/dll/shellext/netshell/README index 1d96e3a99d..0cb8c73754 100644 --- a/dll/shellext/netshell/README +++ b/dll/shellext/netshell/README @@ -66,5 +66,5 @@ as is and the other is setting is to 0. What this does is that when 0, the conne in the shell folder and the tray using the system's INetConnectionManager (which resides in the system's netman service and is accessible through the system's netshell.dll). This allows us to implement and test our three components against the correct implementation of INetConnectionManager. -The other option is setting USE_CUSTOM_CONMGR to 0 which will make the shell folder and the tray +The other option is setting USE_CUSTOM_CONMGR to 1 which will make the shell folder and the tray enumerate connections with our connection manager effectively testing it in windows as well.

1 0

01/01: [MC] Add messages 3710-3790 to netmsg.dll.
by Eric Kohl 18 Nov '18

18 Nov '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=634192cccd47405998a0c… commit 634192cccd47405998a0c25b9e2d304271d9e304 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Sun Nov 18 23:58:12 2018 +0100 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Sun Nov 18 23:58:12 2018 +0100 [MC] Add messages 3710-3790 to netmsg.dll. --- sdk/include/reactos/mc/netmsgmsg.mc | 666 ++++++++++++++++++++++++++++++++++++ 1 file changed, 666 insertions(+) diff --git a/sdk/include/reactos/mc/netmsgmsg.mc b/sdk/include/reactos/mc/netmsgmsg.mc index 67b9e29b63..0ed78ade9e 100644 --- a/sdk/include/reactos/mc/netmsgmsg.mc +++ b/sdk/include/reactos/mc/netmsgmsg.mc @@ -6608,6 +6608,672 @@ Language=Russian %1 has a remembered connection to %2. . +MessageId=3710 +Severity=Success +Facility=System +SymbolicName=APPERR_3710 +Language=English +An error occurred while opening the Help file. +. +Language=Russian +An error occurred while opening the Help file. +. + +MessageId=3711 +Severity=Success +Facility=System +SymbolicName=APPERR_3711 +Language=English +The Help file is empty. +. +Language=Russian +The Help file is empty. +. + +MessageId=3712 +Severity=Success +Facility=System +SymbolicName=APPERR_3712 +Language=English +The Help file is corrupted. +. +Language=Russian +The Help file is corrupted. +. + +MessageId=3713 +Severity=Success +Facility=System +SymbolicName=APPERR_3713 +Language=English +Could not find a domain controller for domain %1. +. +Language=Russian +Could not find a domain controller for domain %1. +. + +MessageId=3714 +Severity=Success +Facility=System +SymbolicName=APPERR_3714 +Language=English +This operation is privileged on systems with earlier\nversions of the software. +. +Language=Russian +This operation is privileged on systems with earlier\nversions of the software. +. + +MessageId=3716 +Severity=Success +Facility=System +SymbolicName=APPERR_3716 +Language=English +The device type is unknown. +. +Language=Russian +The device type is unknown. +. + +MessageId=3717 +Severity=Success +Facility=System +SymbolicName=APPERR_3717 +Language=English +The log file has been corrupted. +. +Language=Russian +The log file has been corrupted. +. + +MessageId=3718 +Severity=Success +Facility=System +SymbolicName=APPERR_3718 +Language=English +Program filenames must end with .EXE. +. +Language=Russian +Program filenames must end with .EXE. +. + +MessageId=3719 +Severity=Success +Facility=System +SymbolicName=APPERR_3719 +Language=English +A matching share could not be found so nothing was deleted. +. +Language=Russian +A matching share could not be found so nothing was deleted. +. + +MessageId=3720 +Severity=Success +Facility=System +SymbolicName=APPERR_3720 +Language=English +A bad value is in the units-per-week field of the user record. +. +Language=Russian +A bad value is in the units-per-week field of the user record. +. + +MessageId=3721 +Severity=Success +Facility=System +SymbolicName=APPERR_3721 +Language=English +The password is invalid for %1. +. +Language=Russian +The password is invalid for %1. +. + +MessageId=3722 +Severity=Success +Facility=System +SymbolicName=APPERR_3722 +Language=English +An error occurred while sending a message to %1. +. +Language=Russian +An error occurred while sending a message to %1. +. + +MessageId=3723 +Severity=Success +Facility=System +SymbolicName=APPERR_3723 +Language=English +The password or user name is invalid for %1. +. +Language=Russian +The password or user name is invalid for %1. +. + +MessageId=3725 +Severity=Success +Facility=System +SymbolicName=APPERR_3725 +Language=English +An error occurred when the share was deleted. +. +Language=Russian +An error occurred when the share was deleted. +. + +MessageId=3726 +Severity=Success +Facility=System +SymbolicName=APPERR_3726 +Language=English +The user name is invalid. +. +Language=Russian +The user name is invalid. +. + +MessageId=3727 +Severity=Success +Facility=System +SymbolicName=APPERR_3727 +Language=English +The password is invalid. +. +Language=Russian +The password is invalid. +. + +MessageId=3728 +Severity=Success +Facility=System +SymbolicName=APPERR_3728 +Language=English +The passwords do not match. +. +Language=Russian +The passwords do not match. +. + +MessageId=3729 +Severity=Success +Facility=System +SymbolicName=APPERR_3729 +Language=English +Your persistent connections were not all restored. +. +Language=Russian +Your persistent connections were not all restored. +. + +MessageId=3730 +Severity=Success +Facility=System +SymbolicName=APPERR_3730 +Language=English +This is not a valid computer name or domain name. +. +Language=Russian +This is not a valid computer name or domain name. +. + +MessageId=3732 +Severity=Success +Facility=System +SymbolicName=APPERR_3732 +Language=English +Default permissions cannot be set for that resource. +. +Language=Russian +Default permissions cannot be set for that resource. +. + +MessageId=3734 +Severity=Success +Facility=System +SymbolicName=APPERR_3734 +Language=English +A valid password was not entered. +. +Language=Russian +A valid password was not entered. +. + +MessageId=3735 +Severity=Success +Facility=System +SymbolicName=APPERR_3735 +Language=English +A valid name was not entered. +. +Language=Russian +A valid name was not entered. +. + +MessageId=3736 +Severity=Success +Facility=System +SymbolicName=APPERR_3736 +Language=English +The resource named cannot be shared. +. +Language=Russian +The resource named cannot be shared. +. + +MessageId=3737 +Severity=Success +Facility=System +SymbolicName=APPERR_3737 +Language=English +The permissions string contains invalid permissions. +. +Language=Russian +The permissions string contains invalid permissions. +. + +MessageId=3738 +Severity=Success +Facility=System +SymbolicName=APPERR_3738 +Language=English +You can only perform this operation on printers and communication devices. +. +Language=Russian +You can only perform this operation on printers and communication devices. +. + +MessageId=3742 +Severity=Success +Facility=System +SymbolicName=APPERR_3742 +Language=English +%1 is an invalid user or group name. +. +Language=Russian +%1 is an invalid user or group name. +. + +MessageId=3743 +Severity=Success +Facility=System +SymbolicName=APPERR_3743 +Language=English +The server is not configured for remote administration. +. +Language=Russian +The server is not configured for remote administration. +. + +MessageId=3752 +Severity=Success +Facility=System +SymbolicName=APPERR_3752 +Language=English +No users have sessions with this server. +. +Language=Russian +No users have sessions with this server. +. + +MessageId=3753 +Severity=Success +Facility=System +SymbolicName=APPERR_3753 +Language=English +User %1 is not a member of group %2. +. +Language=Russian +User %1 is not a member of group %2. +. + +MessageId=3754 +Severity=Success +Facility=System +SymbolicName=APPERR_3754 +Language=English +User %1 is already a member of group %2. +. +Language=Russian +User %1 is already a member of group %2. +. + +MessageId=3755 +Severity=Success +Facility=System +SymbolicName=APPERR_3755 +Language=English +There is no such user: %1. +. +Language=Russian +There is no such user: %1. +. + +MessageId=3756 +Severity=Success +Facility=System +SymbolicName=APPERR_3756 +Language=English +This is an invalid response. +. +Language=Russian +This is an invalid response. +. + +MessageId=3757 +Severity=Success +Facility=System +SymbolicName=APPERR_3757 +Language=English +No valid response was provided. +. +Language=Russian +No valid response was provided. +. + +MessageId=3758 +Severity=Success +Facility=System +SymbolicName=APPERR_3758 +Language=English +The destination list provided does not match the destination list of the printer queue. +. +Language=Russian +The destination list provided does not match the destination list of the printer queue. +. + +MessageId=3759 +Severity=Success +Facility=System +SymbolicName=APPERR_3759 +Language=English +Your password cannot be changed until %1. +. +Language=Russian +Your password cannot be changed until %1. +. + +MessageId=3760 +Severity=Success +Facility=System +SymbolicName=APPERR_3760 +Language=English +%1 is not a recognized day of the week. +. +Language=Russian +%1 is not a recognized day of the week. +. + +MessageId=3761 +Severity=Success +Facility=System +SymbolicName=APPERR_3761 +Language=English +The time range specified ends before it starts. +. +Language=Russian +The time range specified ends before it starts. +. + +MessageId=3762 +Severity=Success +Facility=System +SymbolicName=APPERR_3762 +Language=English +%1 is not a recognized hour. +. +Language=Russian +%1 is not a recognized hour. +. + +MessageId=3763 +Severity=Success +Facility=System +SymbolicName=APPERR_3763 +Language=English +%1 is not a valid specification for minutes. +. +Language=Russian +%1 is not a valid specification for minutes. +. + +MessageId=3764 +Severity=Success +Facility=System +SymbolicName=APPERR_3764 +Language=English +Time supplied is not exactly on the hour. +. +Language=Russian +Time supplied is not exactly on the hour. +. + +MessageId=3765 +Severity=Success +Facility=System +SymbolicName=APPERR_3765 +Language=English +12 and 24 hour time formats may not be mixed. +. +Language=Russian +12 and 24 hour time formats may not be mixed. +. + +MessageId=3766 +Severity=Success +Facility=System +SymbolicName=APPERR_3766 +Language=English +%1 is not a valid 12-hour suffix. +. +Language=Russian +%1 is not a valid 12-hour suffix. +. + +MessageId=3767 +Severity=Success +Facility=System +SymbolicName=APPERR_3767 +Language=English +An illegal date format has been supplied. +. +Language=Russian +An illegal date format has been supplied. +. + +MessageId=3768 +Severity=Success +Facility=System +SymbolicName=APPERR_3768 +Language=English +An illegal day range has been supplied. +. +Language=Russian +An illegal day range has been supplied. +. + +MessageId=3769 +Severity=Success +Facility=System +SymbolicName=APPERR_3769 +Language=English +An illegal time range has been supplied. +. +Language=Russian +An illegal time range has been supplied. +. + +MessageId=3770 +Severity=Success +Facility=System +SymbolicName=APPERR_3770 +Language=English +Arguments to NET USER are invalid. Check the minimum password\n +length and/or arguments supplied. +. +Language=Russian +Arguments to NET USER are invalid. Check the minimum password\n +length and/or arguments supplied. +. + +MessageId=3771 +Severity=Success +Facility=System +SymbolicName=APPERR_3771 +Language=English +The value for ENABLESCRIPT must be YES. +. +Language=Russian +The value for ENABLESCRIPT must be YES. +. + +MessageId=3773 +Severity=Success +Facility=System +SymbolicName=APPERR_3773 +Language=English +An illegal country code has been supplied. +. +Language=Russian +An illegal country code has been supplied. +. + +MessageId=3774 +Severity=Success +Facility=System +SymbolicName=APPERR_3774 +Language=English +The user was successfully created but could not be added\n +to the USERS local group. +. +Language=Russian +The user was successfully created but could not be added\n +to the USERS local group. +. + +MessageId=3775 +Severity=Success +Facility=System +SymbolicName=APPERR_3775 +Language=English +The user context supplied is invalid. +. +Language=Russian +The user context supplied is invalid. +. + +MessageId=3776 +Severity=Success +Facility=System +SymbolicName=APPERR_3776 +Language=English +The dynamic-link library %1 could not be loaded, or an error\n +occurred while trying to use it. +. +Language=Russian +The dynamic-link library %1 could not be loaded, or an error\n +occurred while trying to use it. +. + +MessageId=3777 +Severity=Success +Facility=System +SymbolicName=APPERR_3777 +Language=English +Sending files is no longer supported. +. +Language=Russian +Sending files is no longer supported. +. + +MessageId=3778 +Severity=Success +Facility=System +SymbolicName=APPERR_3778 +Language=English +You may not specify paths for ADMIN$ and IPC$ shares. +. +Language=Russian +You may not specify paths for ADMIN$ and IPC$ shares. +. + +MessageId=3779 +Severity=Success +Facility=System +SymbolicName=APPERR_3779 +Language=English +User or group %1 is already a member of local group %2. +. +Language=Russian +User or group %1 is already a member of local group %2. +. + +MessageId=3780 +Severity=Success +Facility=System +SymbolicName=APPERR_3780 +Language=English +There is no such user or group: %1. +. +Language=Russian +There is no such user or group: %1. +. + +MessageId=3781 +Severity=Success +Facility=System +SymbolicName=APPERR_3781 +Language=English +There is no such computer: %1. +. +Language=Russian +There is no such computer: %1. +. + +MessageId=3782 +Severity=Success +Facility=System +SymbolicName=APPERR_3782 +Language=English +The computer %1 already exists. +. +Language=Russian +The computer %1 already exists. +. + +MessageId=3783 +Severity=Success +Facility=System +SymbolicName=APPERR_3783 +Language=English +There is no such global user or group: %1. +. +Language=Russian +There is no such global user or group: %1. +. + +MessageId=3784 +Severity=Success +Facility=System +SymbolicName=APPERR_3784 +Language=English +Only disk shares can be marked as cacheable +. +Language=Russian +Only disk shares can be marked as cacheable +. + +MessageId=3790 +Severity=Success +Facility=System +SymbolicName=APPERR_3790 +Language=English +The system could not find message: %1. +. +Language=Russian +The system could not find message: %1. +. + ; ; alertmsg.h (non-public) message definitions (5500 - 5549 ALERT2_BASE)

1 0

01/01: [SETUPLIB][USETUP] Additional partition validity checks.
by Hermès Bélusca-Maïto 18 Nov '18

18 Nov '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=70fa2e2eb4c8adf4458f0… commit 70fa2e2eb4c8adf4458f0824237dae10328c415a Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Nov 18 19:07:23 2018 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Nov 18 21:13:36 2018 +0100 [SETUPLIB][USETUP] Additional partition validity checks. Always perform the partition validity checks when creating new primary/extended/logical partitions, and also when a new partition is automatically created when unpartitioned space is selected for ReactOS installation. CORE-12246 --- base/setup/lib/utils/partlist.c | 62 +++++++++++++++++++++++++++++++---------- base/setup/lib/utils/partlist.h | 6 ++-- base/setup/usetup/usetup.c | 16 ++++++++++- 3 files changed, 65 insertions(+), 19 deletions(-) diff --git a/base/setup/lib/utils/partlist.c b/base/setup/lib/utils/partlist.c index 0d66b6c87e..10ec9d6db6 100644 --- a/base/setup/lib/utils/partlist.c +++ b/base/setup/lib/utils/partlist.c @@ -2203,6 +2203,8 @@ UpdateDiskLayout( ListEntry = ListEntry->Flink; } + ASSERT(Index <= 4); + /* Update the logical partition table */ Index = 4; ListEntry = DiskEntry->LogicalPartListHead.Flink; @@ -2356,12 +2358,13 @@ GetNextUnpartitionedEntry( return NULL; } -VOID +BOOLEAN CreatePrimaryPartition( IN PPARTLIST List, IN ULONGLONG SectorCount, IN BOOLEAN AutoCreate) { + ERROR_NUMBER Error; PDISKENTRY DiskEntry; PPARTENTRY PartEntry; PPARTENTRY NewPartEntry; @@ -2371,9 +2374,16 @@ CreatePrimaryPartition( if (List == NULL || List->CurrentDisk == NULL || List->CurrentPartition == NULL || - List->CurrentPartition->IsPartitioned != FALSE) + List->CurrentPartition->IsPartitioned) { - return; + return FALSE; + } + + Error = PrimaryPartitionCreationChecks(List); + if (Error != NOT_AN_ERROR) + { + DPRINT1("PrimaryPartitionCreationChecks() failed with error %lu\n", Error); + return FALSE; } DiskEntry = List->CurrentDisk; @@ -2408,7 +2418,7 @@ CreatePrimaryPartition( HEAP_ZERO_MEMORY, sizeof(PARTENTRY)); if (NewPartEntry == NULL) - return; + return FALSE; /* Insert the new entry into the list */ InsertTailList(&PartEntry->ListEntry, @@ -2440,6 +2450,8 @@ CreatePrimaryPartition( DiskEntry->Dirty = TRUE; AssignDriveLetters(List); + + return TRUE; } static @@ -2476,11 +2488,12 @@ AddLogicalDiskSpace( &NewPartEntry->ListEntry); } -VOID +BOOLEAN CreateExtendedPartition( IN PPARTLIST List, IN ULONGLONG SectorCount) { + ERROR_NUMBER Error; PDISKENTRY DiskEntry; PPARTENTRY PartEntry; PPARTENTRY NewPartEntry; @@ -2490,9 +2503,16 @@ CreateExtendedPartition( if (List == NULL || List->CurrentDisk == NULL || List->CurrentPartition == NULL || - List->CurrentPartition->IsPartitioned != FALSE) + List->CurrentPartition->IsPartitioned) { - return; + return FALSE; + } + + Error = ExtendedPartitionCreationChecks(List); + if (Error != NOT_AN_ERROR) + { + DPRINT1("ExtendedPartitionCreationChecks() failed with error %lu\n", Error); + return FALSE; } DiskEntry = List->CurrentDisk; @@ -2538,7 +2558,7 @@ CreateExtendedPartition( HEAP_ZERO_MEMORY, sizeof(PARTENTRY)); if (NewPartEntry == NULL) - return; + return FALSE; /* Insert the new entry into the list */ InsertTailList(&PartEntry->ListEntry, @@ -2584,14 +2604,17 @@ CreateExtendedPartition( DiskEntry->Dirty = TRUE; AssignDriveLetters(List); + + return TRUE; } -VOID +BOOLEAN CreateLogicalPartition( IN PPARTLIST List, IN ULONGLONG SectorCount, IN BOOLEAN AutoCreate) { + ERROR_NUMBER Error; PDISKENTRY DiskEntry; PPARTENTRY PartEntry; PPARTENTRY NewPartEntry; @@ -2601,9 +2624,16 @@ CreateLogicalPartition( if (List == NULL || List->CurrentDisk == NULL || List->CurrentPartition == NULL || - List->CurrentPartition->IsPartitioned != FALSE) + List->CurrentPartition->IsPartitioned) { - return; + return FALSE; + } + + Error = LogicalPartitionCreationChecks(List); + if (Error != NOT_AN_ERROR) + { + DPRINT1("LogicalPartitionCreationChecks() failed with error %lu\n", Error); + return FALSE; } DiskEntry = List->CurrentDisk; @@ -2639,7 +2669,7 @@ CreateLogicalPartition( HEAP_ZERO_MEMORY, sizeof(PARTENTRY)); if (NewPartEntry == NULL) - return; + return FALSE; /* Insert the new entry into the list */ InsertTailList(&PartEntry->ListEntry, @@ -2672,6 +2702,8 @@ CreateLogicalPartition( DiskEntry->Dirty = TRUE; AssignDriveLetters(List); + + return TRUE; } VOID @@ -3286,7 +3318,7 @@ PrimaryPartitionCreationChecks( PartEntry = List->CurrentPartition; /* Fail if the partition is already in use */ - if (PartEntry->IsPartitioned != FALSE) + if (PartEntry->IsPartitioned) return ERROR_NEW_PARTITION; /* Fail if there are already 4 primary partitions in the list */ @@ -3307,7 +3339,7 @@ ExtendedPartitionCreationChecks( PartEntry = List->CurrentPartition; /* Fail if the partition is already in use */ - if (PartEntry->IsPartitioned != FALSE) + if (PartEntry->IsPartitioned) return ERROR_NEW_PARTITION; /* Fail if there are already 4 primary partitions in the list */ @@ -3332,7 +3364,7 @@ LogicalPartitionCreationChecks( PartEntry = List->CurrentPartition; /* Fail if the partition is already in use */ - if (PartEntry->IsPartitioned != FALSE) + if (PartEntry->IsPartitioned) return ERROR_NEW_PARTITION; return ERROR_SUCCESS; diff --git a/base/setup/lib/utils/partlist.h b/base/setup/lib/utils/partlist.h index 5ffbd8cca4..f2f856cda2 100644 --- a/base/setup/lib/utils/partlist.h +++ b/base/setup/lib/utils/partlist.h @@ -284,18 +284,18 @@ PPARTENTRY GetPrevPartition( IN PPARTLIST List); -VOID +BOOLEAN CreatePrimaryPartition( IN PPARTLIST List, IN ULONGLONG SectorCount, IN BOOLEAN AutoCreate); -VOID +BOOLEAN CreateExtendedPartition( IN PPARTLIST List, IN ULONGLONG SectorCount); -VOID +BOOLEAN CreateLogicalPartition( IN PPARTLIST List, IN ULONGLONG SectorCount, diff --git a/base/setup/usetup/usetup.c b/base/setup/usetup/usetup.c index f16d6512b7..48645eca32 100644 --- a/base/setup/usetup/usetup.c +++ b/base/setup/usetup/usetup.c @@ -1607,12 +1607,26 @@ SelectPartitionPage(PINPUT_RECORD Ir) { if (PartitionList->CurrentPartition->LogicalPartition) { + Error = LogicalPartitionCreationChecks(PartitionList); + if (Error != NOT_AN_ERROR) + { + MUIDisplayError(Error, Ir, POPUP_WAIT_ANY_KEY); + return SELECT_PARTITION_PAGE; + } + CreateLogicalPartition(PartitionList, 0ULL, TRUE); } else { + Error = PrimaryPartitionCreationChecks(PartitionList); + if (Error != NOT_AN_ERROR) + { + MUIDisplayError(Error, Ir, POPUP_WAIT_ANY_KEY); + return SELECT_PARTITION_PAGE; + } + CreatePrimaryPartition(PartitionList, 0ULL, TRUE); @@ -2580,7 +2594,7 @@ DeletePartitionPage(PINPUT_RECORD Ir) * QuitPage * * SIDEEFFECTS - * Sets PartEntry->DiskEntry->LayoutBuffer->PartitionEntry[PartEntry->PartitionIndex].PartitionType (via UpdatePartitionType) + * Calls UpdatePartitionType() * Calls CheckActiveSystemPartition() * * RETURNS

1 0

03/03: [OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber.
by Hermès Bélusca-Maïto 18 Nov '18

18 Nov '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=2d320f5a8daf4627458e8… commit 2d320f5a8daf4627458e81f0ffd51bdd8f60d120 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Nov 18 21:05:32 2018 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Nov 18 21:06:22 2018 +0100 [OLE32] The CoDisconnectContext() stub added in 6a2f9673 (PR #1044) is actually Vista+. Caught by Thomas Faber. --- dll/win32/ole32/ole32.spec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dll/win32/ole32/ole32.spec b/dll/win32/ole32/ole32.spec index d4ed1163d4..97667918e9 100644 --- a/dll/win32/ole32/ole32.spec +++ b/dll/win32/ole32/ole32.spec @@ -23,7 +23,7 @@ # CoCreateObjectInContext # CoDeactivateObject @ stdcall -stub CoDisableCallCancellation(ptr) -@ stdcall -stub CoDisconnectContext(long) +@ stdcall -stub -version=0x600+ CoDisconnectContext(long) @ stdcall CoDisconnectObject(ptr long) @ stdcall CoDosDateTimeToFileTime(long long ptr) kernel32.DosDateTimeToFileTime @ stdcall -stub CoEnableCallCancellation(ptr)

1 0

02/03: [FILEBROWSER] Remove a duplicated include. Noticed by Manuel Oppermann (see ros-dev ML).
by Hermès Bélusca-Maïto 18 Nov '18

18 Nov '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=e77ffe2c72dc32cbcb47b… commit e77ffe2c72dc32cbcb47b8771750cbd9addc40ce Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Nov 18 20:58:31 2018 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Nov 18 21:06:21 2018 +0100 [FILEBROWSER] Remove a duplicated include. Noticed by Manuel Oppermann (see ros-dev ML). --- base/shell/filebrowser/filebrowser.c | 1 - 1 file changed, 1 deletion(-) diff --git a/base/shell/filebrowser/filebrowser.c b/base/shell/filebrowser/filebrowser.c index c6da047251..f6cace8be4 100644 --- a/base/shell/filebrowser/filebrowser.c +++ b/base/shell/filebrowser/filebrowser.c @@ -24,7 +24,6 @@ #include <shobjidl.h> #include <shlobj.h> #include <shlwapi.h> -#include <stdio.h> #include <browseui_undoc.h>

1 0

01/03: [CHKDSK] Fix italian translation, by Marco Savelli (addendum to cfff74da).
by Hermès Bélusca-Maïto 18 Nov '18

18 Nov '18

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=769280c520b52426b90a6… commit 769280c520b52426b90a6d55dfcab3150e79e5f9 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sun Nov 18 20:57:23 2018 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sun Nov 18 21:06:19 2018 +0100 [CHKDSK] Fix italian translation, by Marco Savelli (addendum to cfff74da). --- base/system/chkdsk/lang/it-IT.rc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/base/system/chkdsk/lang/it-IT.rc b/base/system/chkdsk/lang/it-IT.rc index e49a092592..44ef993876 100644 --- a/base/system/chkdsk/lang/it-IT.rc +++ b/base/system/chkdsk/lang/it-IT.rc @@ -23,7 +23,7 @@ Uso: %s [drive:] [-F] [-V] [-R] [-C] \n\n\ IDS_ABOUT "\n\ Chkdskx v1.0.1 di Mark Russinovich\n\ Systems Internals - http://www.sysinternals.com\n\ -Adattazione ReactOS nel 1999 di Emanuele Aliberti\n\n" +Adattamento ReactOS nel 1999 di Emanuele Aliberti\n\n" END STRINGTABLE

1 0

← Newer
1
...
7
8
9
10
11
12
13
...
25
Older →

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs November 2018