Ros-diffs February 2018

ros-diffs@reactos.org

24 participants
240 discussions

03/04: [SHELL32] CFSDropTarget: Initial implementation of right click drag menu

by Giannis Adamopoulos

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=6d91269edaf26cbea0195… commit 6d91269edaf26cbea019577b9b14faf7d04a8d33 Author: Giannis Adamopoulos <gadamopoulos(a)reactos.org> AuthorDate: Fri Feb 16 20:33:44 2018 +0200 Commit: Giannis Adamopoulos <gadamopoulos(a)reactos.org> CommitDate: Sat Feb 17 20:30:37 2018 +0200 [SHELL32] CFSDropTarget: Initial implementation of right click drag menu --- dll/win32/shell32/droptargets/CFSDropTarget.cpp | 114 +++++++++++++++++++++++- dll/win32/shell32/droptargets/CFSDropTarget.h | 13 ++- 2 files changed, 123 insertions(+), 4 deletions(-) diff --git a/dll/win32/shell32/droptargets/CFSDropTarget.cpp b/dll/win32/shell32/droptargets/CFSDropTarget.cpp index 468f6c1703..3337b455a0 100644 --- a/dll/win32/shell32/droptargets/CFSDropTarget.cpp +++ b/dll/win32/shell32/droptargets/CFSDropTarget.cpp @@ -83,7 +83,7 @@ HRESULT WINAPI CFSDropTarget::CopyItems(IShellFolder * pSFFrom, UINT cidl, SHFILEOPSTRUCTW op = {0}; op.pFrom = pszSrcList; op.pTo = wszTargetPath; - op.hwnd = GetActiveWindow(); + op.hwnd = m_hwndSite; op.wFunc = bCopy ? FO_COPY : FO_MOVE; op.fFlags = FOF_ALLOWUNDO | FOF_NOCONFIRMMKDIR; @@ -100,7 +100,9 @@ HRESULT WINAPI CFSDropTarget::CopyItems(IShellFolder * pSFFrom, UINT cidl, CFSDropTarget::CFSDropTarget(): cfShellIDList(0), fAcceptFmt(FALSE), - sPathTarget(NULL) + sPathTarget(NULL), + m_hwndSite(NULL), + m_grfKeyState(0) { } @@ -180,6 +182,70 @@ BOOL CFSDropTarget::QueryDrop(DWORD dwKeyState, LPDWORD pdwEffect) return FALSE; } +HRESULT CFSDropTarget::_GetEffectFromMenu(IDataObject *pDataObject, POINTL pt, DWORD *pdwEffect) +{ + HMENU hmenu = LoadMenuW(shell32_hInstance, MAKEINTRESOURCEW(IDM_DRAGFILE)); + if (!hmenu) + return E_OUTOFMEMORY; + + /* FIXME: We need to support shell extensions here */ + + UINT uCommand = TrackPopupMenu(GetSubMenu(hmenu, 0), + TPM_LEFTALIGN | TPM_RETURNCMD | TPM_LEFTBUTTON | TPM_RIGHTBUTTON, + pt.x, pt.y, 0, m_hwndSite, NULL); + if (uCommand == 0) + return S_FALSE; + else if (uCommand == IDM_COPYHERE) + *pdwEffect = DROPEFFECT_COPY; + else if (uCommand == IDM_MOVEHERE) + *pdwEffect = DROPEFFECT_MOVE; + else if (uCommand == IDM_LINKHERE) + *pdwEffect = DROPEFFECT_LINK; + + return S_OK; +} + +HRESULT CFSDropTarget::_RepositionItems(IShellFolderView *psfv, IDataObject *pdtobj, POINTL pt) +{ + CComPtr<IFolderView> pfv; + POINT ptDrag; + HRESULT hr = psfv->QueryInterface(IID_PPV_ARG(IFolderView, &pfv)); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + hr = psfv->GetDragPoint(&ptDrag); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + PIDLIST_ABSOLUTE pidlFolder; + PUITEMID_CHILD *apidl; + UINT cidl; + hr = SH_GetApidlFromDataObject(pdtobj, &pidlFolder, &apidl, &cidl); + if (FAILED_UNEXPECTEDLY(hr)) + return hr; + + CComHeapPtr<POINT> apt; + if (!apt.Allocate(cidl)) + { + SHFree(pidlFolder); + _ILFreeaPidl(apidl, cidl); + return E_OUTOFMEMORY; + } + + for (UINT i = 0; i<cidl; i++) + { + pfv->GetItemPosition(apidl[i], &apt[i]); + apt[i].x += pt.x - ptDrag.x; + apt[i].y += pt.y - ptDrag.y; + } + + pfv->SelectAndPositionItems(cidl, apidl, apt, SVSI_SELECT); + + SHFree(pidlFolder); + _ILFreeaPidl(apidl, cidl); + return S_OK; +} + HRESULT WINAPI CFSDropTarget::DragEnter(IDataObject *pDataObject, DWORD dwKeyState, POINTL pt, DWORD *pdwEffect) { @@ -196,6 +262,8 @@ HRESULT WINAPI CFSDropTarget::DragEnter(IDataObject *pDataObject, else if (SUCCEEDED(pDataObject->QueryGetData(&fmt2))) fAcceptFmt = TRUE; + m_grfKeyState = dwKeyState; + QueryDrop(dwKeyState, pdwEffect); return S_OK; } @@ -208,6 +276,8 @@ HRESULT WINAPI CFSDropTarget::DragOver(DWORD dwKeyState, POINTL pt, if (!pdwEffect) return E_INVALIDARG; + m_grfKeyState = dwKeyState; + QueryDrop(dwKeyState, pdwEffect); return S_OK; @@ -230,8 +300,28 @@ HRESULT WINAPI CFSDropTarget::Drop(IDataObject *pDataObject, if (!pdwEffect) return E_INVALIDARG; + IUnknown_GetWindow(m_site, &m_hwndSite); + QueryDrop(dwKeyState, pdwEffect); + if (m_grfKeyState & MK_RBUTTON) + { + HRESULT hr = _GetEffectFromMenu(pDataObject, pt, pdwEffect); + if (FAILED_UNEXPECTEDLY(hr) || hr == S_FALSE) + return hr; + } + + if (*pdwEffect == DROPEFFECT_MOVE && m_site) + { + CComPtr<IShellFolderView> psfv; + HRESULT hr = IUnknown_QueryService(m_site, SID_IFolderView, IID_PPV_ARG(IShellFolderView, &psfv)); + if (SUCCEEDED(hr) && psfv->IsDropOnSource(this) == S_OK) + { + _RepositionItems(psfv, pDataObject, pt); + return S_OK; + } + } + BOOL fIsOpAsync = FALSE; CComPtr<IAsyncOperation> pAsyncOperation; @@ -257,6 +347,24 @@ HRESULT WINAPI CFSDropTarget::Drop(IDataObject *pDataObject, return this->_DoDrop(pDataObject, dwKeyState, pt, pdwEffect); } +HRESULT +WINAPI +CFSDropTarget::SetSite(IUnknown *pUnkSite) +{ + m_site = pUnkSite; + return S_OK; +} + +HRESULT +WINAPI +CFSDropTarget::GetSite(REFIID riid, void **ppvSite) +{ + if (!m_site) + return E_FAIL; + + return m_site->QueryInterface(riid, ppvSite); +} + HRESULT WINAPI CFSDropTarget::_DoDrop(IDataObject *pDataObject, DWORD dwKeyState, POINTL pt, DWORD *pdwEffect) { @@ -474,7 +582,7 @@ HRESULT WINAPI CFSDropTarget::_DoDrop(IDataObject *pDataObject, ZeroMemory(&op, sizeof(op)); op.pFrom = pszSrcList; op.pTo = wszTargetPath; - op.hwnd = GetActiveWindow(); + op.hwnd = m_hwndSite; op.wFunc = bCopy ? FO_COPY : FO_MOVE; op.fFlags = FOF_ALLOWUNDO | FOF_NOCONFIRMMKDIR; hr = SHFileOperationW(&op); diff --git a/dll/win32/shell32/droptargets/CFSDropTarget.h b/dll/win32/shell32/droptargets/CFSDropTarget.h index e6c063d02c..091e60ee33 100644 --- a/dll/win32/shell32/droptargets/CFSDropTarget.h +++ b/dll/win32/shell32/droptargets/CFSDropTarget.h @@ -25,18 +25,24 @@ class CFSDropTarget : public CComObjectRootEx<CComMultiThreadModelNoCS>, - public IDropTarget + public IDropTarget, + public IObjectWithSite { private: UINT cfShellIDList; /* clipboardformat for IDropTarget */ BOOL fAcceptFmt; /* flag for pending Drop */ LPWSTR sPathTarget; + HWND m_hwndSite; + DWORD m_grfKeyState; + CComPtr<IUnknown> m_site; BOOL QueryDrop (DWORD dwKeyState, LPDWORD pdwEffect); virtual HRESULT WINAPI _DoDrop(IDataObject *pDataObject, DWORD dwKeyState, POINTL pt, DWORD *pdwEffect); virtual HRESULT WINAPI CopyItems(IShellFolder *pSFFrom, UINT cidl, LPCITEMIDLIST *apidl, BOOL bCopy); BOOL GetUniqueFileName(LPWSTR pwszBasePath, LPCWSTR pwszExt, LPWSTR pwszTarget, BOOL bShortcut); static DWORD WINAPI _DoDropThreadProc(LPVOID lpParameter); + HRESULT _GetEffectFromMenu(IDataObject *pDataObject, POINTL pt, DWORD *pdwEffect); + HRESULT _RepositionItems(IShellFolderView *psfv, IDataObject *pDataObject, POINTL pt); public: CFSDropTarget(); @@ -49,12 +55,17 @@ class CFSDropTarget : virtual HRESULT WINAPI DragLeave(); virtual HRESULT WINAPI Drop(IDataObject *pDataObject, DWORD dwKeyState, POINTL pt, DWORD *pdwEffect); + // IObjectWithSite + virtual HRESULT STDMETHODCALLTYPE SetSite(IUnknown *pUnkSite); + virtual HRESULT STDMETHODCALLTYPE GetSite(REFIID riid, void **ppvSite); + DECLARE_NOT_AGGREGATABLE(CFSDropTarget) DECLARE_PROTECT_FINAL_CONSTRUCT() BEGIN_COM_MAP(CFSDropTarget) COM_INTERFACE_ENTRY_IID(IID_IDropTarget, IDropTarget) + COM_INTERFACE_ENTRY_IID(IID_IObjectWithSite, IObjectWithSite) END_COM_MAP() };

6 years, 7 months

02/04: [SHELL32] CDefView: Implement several methods needed for drop targets Set the view object as the site of the drop target. Implement GetItemPosition, SelectAndPositionItems, IsDropOnSource, GetDragPoint. Use DROPEFFECT_COPY only when the item supports it.

by Giannis Adamopoulos

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8f8ab050db7fde50f0999… commit 8f8ab050db7fde50f09995f63d580f70645bece8 Author: Giannis Adamopoulos <gadamopoulos(a)reactos.org> AuthorDate: Sat Feb 17 19:29:20 2018 +0200 Commit: Giannis Adamopoulos <gadamopoulos(a)reactos.org> CommitDate: Sat Feb 17 20:30:37 2018 +0200 [SHELL32] CDefView: Implement several methods needed for drop targets Set the view object as the site of the drop target. Implement GetItemPosition, SelectAndPositionItems, IsDropOnSource, GetDragPoint. Use DROPEFFECT_COPY only when the item supports it. --- dll/win32/shell32/CDefView.cpp | 62 +++++++++++++++++++++++++++++++----------- 1 file changed, 46 insertions(+), 16 deletions(-) diff --git a/dll/win32/shell32/CDefView.cpp b/dll/win32/shell32/CDefView.cpp index c3d37e5c0e..280be9606a 100644 --- a/dll/win32/shell32/CDefView.cpp +++ b/dll/win32/shell32/CDefView.cpp @@ -101,6 +101,7 @@ class CDefView : UINT m_cScrollDelay; /* Send a WM_*SCROLL msg every 250 ms during drag-scroll */ POINT m_ptLastMousePos; /* Mouse position at last DragOver call */ POINT m_ptFirstMousePos; /* Mouse position when the drag operation started */ + DWORD m_grfKeyState; // CComPtr<IContextMenu> m_pCM; @@ -1765,8 +1766,8 @@ LRESULT CDefView::OnNotify(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandl if (GetSelections()) { CComPtr<IDataObject> pda; - DWORD dwAttributes = SFGAO_CANLINK; - DWORD dwEffect = DROPEFFECT_COPY | DROPEFFECT_MOVE; + DWORD dwAttributes = SFGAO_CANCOPY | SFGAO_CANLINK; + DWORD dwEffect = DROPEFFECT_MOVE; if (SUCCEEDED(m_pSFParent->GetUIObjectOf(m_hWnd, m_cidl, m_apidl, IID_NULL_PPV_ARG(IDataObject, &pda)))) { @@ -1774,10 +1775,7 @@ LRESULT CDefView::OnNotify(UINT uMsg, WPARAM wParam, LPARAM lParam, BOOL &bHandl if (SUCCEEDED(m_pSFParent->GetAttributesOf(m_cidl, m_apidl, &dwAttributes))) { - if (dwAttributes & SFGAO_CANLINK) - { - dwEffect |= DROPEFFECT_LINK; - } + dwEffect |= dwAttributes & (SFGAO_CANCOPY | SFGAO_CANLINK); } CComPtr<IAsyncOperation> piaso; @@ -2423,7 +2421,12 @@ HRESULT STDMETHODCALLTYPE CDefView::GetFocusedItem(int *piItem) HRESULT STDMETHODCALLTYPE CDefView::GetItemPosition(PCUITEMID_CHILD pidl, POINT *ppt) { - return E_NOTIMPL; + int lvIndex = LV_FindItemByPidl(pidl); + if (lvIndex == -1 || ppt == NULL) + return E_INVALIDARG; + + m_ListView.GetItemPosition(lvIndex, ppt); + return S_OK; } HRESULT STDMETHODCALLTYPE CDefView::GetSpacing(POINT *ppt) @@ -2488,7 +2491,21 @@ HRESULT STDMETHODCALLTYPE CDefView::SelectItem(int iItem, DWORD dwFlags) HRESULT STDMETHODCALLTYPE CDefView::SelectAndPositionItems(UINT cidl, PCUITEMID_CHILD_ARRAY apidl, POINT *apt, DWORD dwFlags) { - return E_NOTIMPL; + /* Reset the selection */ + m_ListView.SetItemState(-1, 0, LVIS_SELECTED); + + int lvIndex; + for (UINT i = 0 ; i < m_cidl; i++) + { + lvIndex = LV_FindItemByPidl(apidl[i]); + if (lvIndex != -1) + { + SelectItem(lvIndex, dwFlags); + m_ListView.SetItemPosition(lvIndex, &apt[i]); + } + } + + return S_OK; } /********************************************************** @@ -2717,14 +2734,22 @@ HRESULT STDMETHODCALLTYPE CDefView::GetSelectedObjects(PCUITEMID_CHILD **pidl, U HRESULT STDMETHODCALLTYPE CDefView::IsDropOnSource(IDropTarget *drop_target) { - FIXME("(%p)->(%p) stub\n", this, drop_target); - return E_NOTIMPL; + if ((m_iDragOverItem == -1 || m_pCurDropTarget == NULL) && + (m_pSourceDataObject.p)) + { + return S_OK; + } + + return S_FALSE; } HRESULT STDMETHODCALLTYPE CDefView::GetDragPoint(POINT *pt) { - FIXME("(%p)->(%p) stub\n", this, pt); - return E_NOTIMPL; + if (!pt) + return E_INVALIDARG; + + *pt = m_ptFirstMousePos; + return S_OK; } HRESULT STDMETHODCALLTYPE CDefView::GetDropPoint(POINT *pt) @@ -2887,6 +2912,11 @@ HRESULT CDefView::drag_notify_subitem(DWORD grfKeyState, POINTL pt, DWORD *pdwEf HRESULT hr; RECT clientRect; + /* The key state on drop doesn't have MK_LBUTTON or MK_RBUTTON because it + reflects the key state after the user released the button, so we need + to remember the last key state when the button was pressed */ + m_grfKeyState = grfKeyState; + /* Map from global to client coordinates and query the index of the listview-item, which is * currently under the mouse cursor. */ LVHITTESTINFO htinfo = {{pt.x, pt.y}, LVHT_ONITEM}; @@ -2972,6 +3002,8 @@ HRESULT CDefView::drag_notify_subitem(DWORD grfKeyState, POINTL pt, DWORD *pdwEf hr = m_pSFParent->GetUIObjectOf(m_ListView, 1, &pidl, IID_NULL_PPV_ARG(IDropTarget, &m_pCurDropTarget)); } + IUnknown_SetSite(m_pCurDropTarget, (IShellView *)this); + /* If anything failed, m_pCurDropTarget should be NULL now, which ought to be a save state. */ if (FAILED(hr)) { @@ -3039,11 +3071,9 @@ HRESULT WINAPI CDefView::Drop(IDataObject* pDataObject, DWORD grfKeyState, POINT ImageList_DragLeave(m_hWnd); ImageList_EndDrag(); - if ((m_iDragOverItem == -1 || m_pCurDropTarget == NULL) && + if ((IsDropOnSource(NULL) == S_OK) && (*pdwEffect & DROPEFFECT_MOVE) && - /*(GetKeyState(VK_LBUTTON) != 0) &&*/ - (m_pSourceDataObject.p) && - (SHIsSameObject(pDataObject, m_pSourceDataObject))) + (m_grfKeyState & MK_LBUTTON)) { if (m_pCurDropTarget) {

6 years, 7 months

01/04: [SHELL32] Add menu resource which is used when dragging files with right click

by Giannis Adamopoulos

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=5bef945cc9ef223f9c85e… commit 5bef945cc9ef223f9c85ededcbfa8f5f9410dcb9 Author: Giannis Adamopoulos <gadamopoulos(a)reactos.org> AuthorDate: Sat Feb 17 19:18:43 2018 +0200 Commit: Giannis Adamopoulos <gadamopoulos(a)reactos.org> CommitDate: Sat Feb 17 20:30:37 2018 +0200 [SHELL32] Add menu resource which is used when dragging files with right click --- dll/win32/shell32/lang/bg-BG.rc | 12 ++++++++++++ dll/win32/shell32/lang/ca-ES.rc | 12 ++++++++++++ dll/win32/shell32/lang/cs-CZ.rc | 12 ++++++++++++ dll/win32/shell32/lang/da-DK.rc | 12 ++++++++++++ dll/win32/shell32/lang/de-DE.rc | 12 ++++++++++++ dll/win32/shell32/lang/el-GR.rc | 12 ++++++++++++ dll/win32/shell32/lang/en-GB.rc | 12 ++++++++++++ dll/win32/shell32/lang/en-US.rc | 12 ++++++++++++ dll/win32/shell32/lang/es-ES.rc | 12 ++++++++++++ dll/win32/shell32/lang/et-EE.rc | 12 ++++++++++++ dll/win32/shell32/lang/fi-FI.rc | 12 ++++++++++++ dll/win32/shell32/lang/fr-FR.rc | 12 ++++++++++++ dll/win32/shell32/lang/he-IL.rc | 12 ++++++++++++ dll/win32/shell32/lang/hu-HU.rc | 12 ++++++++++++ dll/win32/shell32/lang/it-IT.rc | 12 ++++++++++++ dll/win32/shell32/lang/ja-JP.rc | 12 ++++++++++++ dll/win32/shell32/lang/ko-KR.rc | 12 ++++++++++++ dll/win32/shell32/lang/nl-NL.rc | 12 ++++++++++++ dll/win32/shell32/lang/no-NO.rc | 12 ++++++++++++ dll/win32/shell32/lang/pl-PL.rc | 12 ++++++++++++ dll/win32/shell32/lang/pt-BR.rc | 12 ++++++++++++ dll/win32/shell32/lang/pt-PT.rc | 12 ++++++++++++ dll/win32/shell32/lang/ro-RO.rc | 12 ++++++++++++ dll/win32/shell32/lang/ru-RU.rc | 12 ++++++++++++ dll/win32/shell32/lang/sk-SK.rc | 12 ++++++++++++ dll/win32/shell32/lang/sl-SI.rc | 12 ++++++++++++ dll/win32/shell32/lang/sq-AL.rc | 12 ++++++++++++ dll/win32/shell32/lang/sv-SE.rc | 12 ++++++++++++ dll/win32/shell32/lang/tr-TR.rc | 12 ++++++++++++ dll/win32/shell32/lang/uk-UA.rc | 12 ++++++++++++ dll/win32/shell32/lang/zh-CN.rc | 12 ++++++++++++ dll/win32/shell32/lang/zh-TW.rc | 12 ++++++++++++ dll/win32/shell32/shresdef.h | 7 +++++++ 33 files changed, 391 insertions(+) diff --git a/dll/win32/shell32/lang/bg-BG.rc b/dll/win32/shell32/lang/bg-BG.rc index f970f1691c..e4875ae6dd 100644 --- a/dll/win32/shell32/lang/bg-BG.rc +++ b/dll/win32/shell32/lang/bg-BG.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Търсене на папка" diff --git a/dll/win32/shell32/lang/ca-ES.rc b/dll/win32/shell32/lang/ca-ES.rc index 2041c2754d..78946e4cc1 100644 --- a/dll/win32/shell32/lang/ca-ES.rc +++ b/dll/win32/shell32/lang/ca-ES.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Browse for Folder" diff --git a/dll/win32/shell32/lang/cs-CZ.rc b/dll/win32/shell32/lang/cs-CZ.rc index 7f66bab239..22721fe890 100644 --- a/dll/win32/shell32/lang/cs-CZ.rc +++ b/dll/win32/shell32/lang/cs-CZ.rc @@ -81,6 +81,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Procházet..." diff --git a/dll/win32/shell32/lang/da-DK.rc b/dll/win32/shell32/lang/da-DK.rc index 81f8cb4d2d..dcafd7f168 100644 --- a/dll/win32/shell32/lang/da-DK.rc +++ b/dll/win32/shell32/lang/da-DK.rc @@ -81,6 +81,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Søg efter Mappe" diff --git a/dll/win32/shell32/lang/de-DE.rc b/dll/win32/shell32/lang/de-DE.rc index ef31156bc1..30031c9195 100644 --- a/dll/win32/shell32/lang/de-DE.rc +++ b/dll/win32/shell32/lang/de-DE.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Verzeichnis auswählen" diff --git a/dll/win32/shell32/lang/el-GR.rc b/dll/win32/shell32/lang/el-GR.rc index cb26eadf5e..8f18322098 100644 --- a/dll/win32/shell32/lang/el-GR.rc +++ b/dll/win32/shell32/lang/el-GR.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Αναζήτηση φακέλου" diff --git a/dll/win32/shell32/lang/en-GB.rc b/dll/win32/shell32/lang/en-GB.rc index ef0d77d766..95ea0554d4 100644 --- a/dll/win32/shell32/lang/en-GB.rc +++ b/dll/win32/shell32/lang/en-GB.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Browse for Folder" diff --git a/dll/win32/shell32/lang/en-US.rc b/dll/win32/shell32/lang/en-US.rc index 8678ac9da2..03b5eb1aa5 100644 --- a/dll/win32/shell32/lang/en-US.rc +++ b/dll/win32/shell32/lang/en-US.rc @@ -76,6 +76,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Browse for Folder" diff --git a/dll/win32/shell32/lang/es-ES.rc b/dll/win32/shell32/lang/es-ES.rc index 223315d81a..c43a4c98e4 100644 --- a/dll/win32/shell32/lang/es-ES.rc +++ b/dll/win32/shell32/lang/es-ES.rc @@ -77,6 +77,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Explorar carpeta" diff --git a/dll/win32/shell32/lang/et-EE.rc b/dll/win32/shell32/lang/et-EE.rc index 0439394598..4acbe06a3b 100644 --- a/dll/win32/shell32/lang/et-EE.rc +++ b/dll/win32/shell32/lang/et-EE.rc @@ -83,6 +83,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Browse for Folder" diff --git a/dll/win32/shell32/lang/fi-FI.rc b/dll/win32/shell32/lang/fi-FI.rc index d3f8e5006b..f20f3c046a 100644 --- a/dll/win32/shell32/lang/fi-FI.rc +++ b/dll/win32/shell32/lang/fi-FI.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Valitse Kansio" diff --git a/dll/win32/shell32/lang/fr-FR.rc b/dll/win32/shell32/lang/fr-FR.rc index 7d636bf2e3..20beb111ba 100644 --- a/dll/win32/shell32/lang/fr-FR.rc +++ b/dll/win32/shell32/lang/fr-FR.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Parcourir" diff --git a/dll/win32/shell32/lang/he-IL.rc b/dll/win32/shell32/lang/he-IL.rc index a430a45de1..2ff9d0c04b 100644 --- a/dll/win32/shell32/lang/he-IL.rc +++ b/dll/win32/shell32/lang/he-IL.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "בחירת תיקיה" diff --git a/dll/win32/shell32/lang/hu-HU.rc b/dll/win32/shell32/lang/hu-HU.rc index ede65d3df2..defd1cb52e 100644 --- a/dll/win32/shell32/lang/hu-HU.rc +++ b/dll/win32/shell32/lang/hu-HU.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Mappák böngészése" diff --git a/dll/win32/shell32/lang/it-IT.rc b/dll/win32/shell32/lang/it-IT.rc index ad5af13266..7ea9d55d4f 100644 --- a/dll/win32/shell32/lang/it-IT.rc +++ b/dll/win32/shell32/lang/it-IT.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Sfoglia Cartella" diff --git a/dll/win32/shell32/lang/ja-JP.rc b/dll/win32/shell32/lang/ja-JP.rc index 90788a57b7..b4045fb2c3 100644 --- a/dll/win32/shell32/lang/ja-JP.rc +++ b/dll/win32/shell32/lang/ja-JP.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "フォルダの参照" diff --git a/dll/win32/shell32/lang/ko-KR.rc b/dll/win32/shell32/lang/ko-KR.rc index 62919b77c0..15174d4bca 100644 --- a/dll/win32/shell32/lang/ko-KR.rc +++ b/dll/win32/shell32/lang/ko-KR.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Browse for Folder" diff --git a/dll/win32/shell32/lang/nl-NL.rc b/dll/win32/shell32/lang/nl-NL.rc index a84107d622..70cfae49da 100644 --- a/dll/win32/shell32/lang/nl-NL.rc +++ b/dll/win32/shell32/lang/nl-NL.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Browse for Folder" diff --git a/dll/win32/shell32/lang/no-NO.rc b/dll/win32/shell32/lang/no-NO.rc index 234da19a2f..aca7f9fd68 100644 --- a/dll/win32/shell32/lang/no-NO.rc +++ b/dll/win32/shell32/lang/no-NO.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Bla etter mappe" diff --git a/dll/win32/shell32/lang/pl-PL.rc b/dll/win32/shell32/lang/pl-PL.rc index 120bd0300f..a91fb1d82c 100644 --- a/dll/win32/shell32/lang/pl-PL.rc +++ b/dll/win32/shell32/lang/pl-PL.rc @@ -80,6 +80,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Wybierz folder" diff --git a/dll/win32/shell32/lang/pt-BR.rc b/dll/win32/shell32/lang/pt-BR.rc index f28f300c32..c63193da8d 100644 --- a/dll/win32/shell32/lang/pt-BR.rc +++ b/dll/win32/shell32/lang/pt-BR.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Procurar pasta" diff --git a/dll/win32/shell32/lang/pt-PT.rc b/dll/win32/shell32/lang/pt-PT.rc index 2b9c35cc56..75a34adea6 100644 --- a/dll/win32/shell32/lang/pt-PT.rc +++ b/dll/win32/shell32/lang/pt-PT.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Procurar Pastas" diff --git a/dll/win32/shell32/lang/ro-RO.rc b/dll/win32/shell32/lang/ro-RO.rc index b390cd0ed0..39413f1ec9 100644 --- a/dll/win32/shell32/lang/ro-RO.rc +++ b/dll/win32/shell32/lang/ro-RO.rc @@ -77,6 +77,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Specificare dosar" diff --git a/dll/win32/shell32/lang/ru-RU.rc b/dll/win32/shell32/lang/ru-RU.rc index d544087334..7af9e803ab 100644 --- a/dll/win32/shell32/lang/ru-RU.rc +++ b/dll/win32/shell32/lang/ru-RU.rc @@ -77,6 +77,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Обзор" diff --git a/dll/win32/shell32/lang/sk-SK.rc b/dll/win32/shell32/lang/sk-SK.rc index ea3db6ad3e..ca6165eb8c 100644 --- a/dll/win32/shell32/lang/sk-SK.rc +++ b/dll/win32/shell32/lang/sk-SK.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Browse for Folder" diff --git a/dll/win32/shell32/lang/sl-SI.rc b/dll/win32/shell32/lang/sl-SI.rc index 6a5eacd992..c01dd18118 100644 --- a/dll/win32/shell32/lang/sl-SI.rc +++ b/dll/win32/shell32/lang/sl-SI.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Browse for Folder" diff --git a/dll/win32/shell32/lang/sq-AL.rc b/dll/win32/shell32/lang/sq-AL.rc index 4edc13300f..bf831bf7e3 100644 --- a/dll/win32/shell32/lang/sq-AL.rc +++ b/dll/win32/shell32/lang/sq-AL.rc @@ -79,6 +79,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Shfleto për Dosje" diff --git a/dll/win32/shell32/lang/sv-SE.rc b/dll/win32/shell32/lang/sv-SE.rc index fc440135fe..257ccc9e25 100644 --- a/dll/win32/shell32/lang/sv-SE.rc +++ b/dll/win32/shell32/lang/sv-SE.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Bläddra efter mapp" diff --git a/dll/win32/shell32/lang/tr-TR.rc b/dll/win32/shell32/lang/tr-TR.rc index d1d53dd908..f91d2e37b1 100644 --- a/dll/win32/shell32/lang/tr-TR.rc +++ b/dll/win32/shell32/lang/tr-TR.rc @@ -77,6 +77,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Dizin İçin Göz At" diff --git a/dll/win32/shell32/lang/uk-UA.rc b/dll/win32/shell32/lang/uk-UA.rc index 50d33254d0..4230b0eb0b 100644 --- a/dll/win32/shell32/lang/uk-UA.rc +++ b/dll/win32/shell32/lang/uk-UA.rc @@ -75,6 +75,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Огляд тек" diff --git a/dll/win32/shell32/lang/zh-CN.rc b/dll/win32/shell32/lang/zh-CN.rc index 0a0a401453..b0aed09fcb 100644 --- a/dll/win32/shell32/lang/zh-CN.rc +++ b/dll/win32/shell32/lang/zh-CN.rc @@ -85,6 +85,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "浏览文件夹" diff --git a/dll/win32/shell32/lang/zh-TW.rc b/dll/win32/shell32/lang/zh-TW.rc index 515c41c7de..4c348c180b 100644 --- a/dll/win32/shell32/lang/zh-TW.rc +++ b/dll/win32/shell32/lang/zh-TW.rc @@ -83,6 +83,18 @@ BEGIN END END +IDM_DRAGFILE MENU +BEGIN + POPUP "" + BEGIN + MENUITEM "&Copy here", IDM_COPYHERE + MENUITEM "&Move here", IDM_MOVEHERE + MENUITEM "Create &shortcuts here", IDM_LINKHERE + MENUITEM SEPARATOR + MENUITEM "Cancel", 0 + END +END + IDD_BROWSE_FOR_FOLDER DIALOGEX 15, 40, 188, 192 STYLE DS_SHELLFONT | DS_MODALFRAME | WS_CAPTION | WS_SYSMENU CAPTION "Browse for Folder" diff --git a/dll/win32/shell32/shresdef.h b/dll/win32/shell32/shresdef.h index 53e4896713..5508e3f1d9 100644 --- a/dll/win32/shell32/shresdef.h +++ b/dll/win32/shell32/shresdef.h @@ -662,6 +662,13 @@ #define IDM_RENAME (FCIDM_SHVIEW_RENAME - 0x7000) #define IDM_PROPERTIES (FCIDM_SHVIEW_PROPERTIES - 0x7000) +#define IDM_DRAGFILE 0xce +#define IDM_COPYHERE 0x7 +#define IDM_MOVEHERE 0x8 +#define IDM_LINKHERE 0xB + + + /* Registrar scripts (RGS) */ #define IDR_ADMINFOLDERSHORTCUT 128 #define IDR_CONTROLPANEL 130

6 years, 7 months

01/01: [SC] Implement missing query/queryex options - PrintService: Print optional display name. - MainUsage: Print missing query options. - Parse query options and use them to enumerate services.

by Eric Kohl

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=47281571546797043d7f5… commit 47281571546797043d7f5dad0bf5da5372055274 Author: Eric Kohl <eric.kohl(a)reactos.org> AuthorDate: Sat Feb 17 19:26:06 2018 +0100 Commit: Eric Kohl <eric.kohl(a)reactos.org> CommitDate: Sat Feb 17 19:28:16 2018 +0100 [SC] Implement missing query/queryex options - PrintService: Print optional display name. - MainUsage: Print missing query options. - Parse query options and use them to enumerate services. --- base/applications/sc/control.c | 1 + base/applications/sc/print.c | 4 + base/applications/sc/query.c | 361 ++++++++++++++++++++++++++++------------- base/applications/sc/sc.h | 2 +- base/applications/sc/start.c | 1 + base/applications/sc/usage.c | 8 +- 6 files changed, 261 insertions(+), 116 deletions(-) diff --git a/base/applications/sc/control.c b/base/applications/sc/control.c index de212dd230..5e5a4e84ac 100644 --- a/base/applications/sc/control.c +++ b/base/applications/sc/control.c @@ -96,6 +96,7 @@ Control(DWORD Control, StatusEx.dwServiceFlags = 0; PrintService(ServiceName, + NULL, &StatusEx, FALSE); diff --git a/base/applications/sc/print.c b/base/applications/sc/print.c index caf82a4ae6..f08402207f 100644 --- a/base/applications/sc/print.c +++ b/base/applications/sc/print.c @@ -11,11 +11,15 @@ VOID PrintService(LPCTSTR lpServiceName, + LPCTSTR lpDisplayName, LPSERVICE_STATUS_PROCESS pStatus, BOOL bExtended) { _tprintf(_T("SERVICE_NAME: %s\n"), lpServiceName); + if (lpDisplayName) + _tprintf(_T("DISPLAY_NAME: %s\n"), lpDisplayName); + // Re-use PrintServiceStatus(), as SERVICE_STATUS_PROCESS is in fact an extension of SERVICE_STATUS. PrintServiceStatus((LPSERVICE_STATUS)pStatus); diff --git a/base/applications/sc/query.c b/base/applications/sc/query.c index d9d925f3ec..54e04277b2 100644 --- a/base/applications/sc/query.c +++ b/base/applications/sc/query.c @@ -4,25 +4,11 @@ * FILE: base/applications/sc/query.c * PURPOSE: queries service info * COPYRIGHT: Copyright 2005 - 2006 Ged Murphy <gedmurphy(a)gmail.com> - * - */ -/* - * TODO: - * Allow calling of 2 options e.g.: - * type= driver state= inactive + * Copyright 2018 Eric Kohl <eric.kohl(a)reactos.org> */ #include "sc.h" -LPTSTR QueryOpts[] = { - _T("type="), - _T("state="), - _T("bufsize="), - _T("ri="), - _T("group="), -}; - - LPSERVICE_STATUS_PROCESS QueryService(LPCTSTR ServiceName) { @@ -84,17 +70,20 @@ fail: } -static BOOL +static +DWORD EnumServices(ENUM_SERVICE_STATUS_PROCESS **pServiceStatus, - DWORD ServiceType, - DWORD ServiceState) + DWORD dwServiceType, + DWORD dwServiceState, + DWORD dwBufferSize, + DWORD dwResumeIndex, + LPCTSTR pszGroupName) { SC_HANDLE hSCManager; - DWORD BufSize = 0; DWORD BytesNeeded = 0; - DWORD ResumeHandle = 0; + DWORD ResumeHandle = dwResumeIndex; DWORD NumServices = 0; - DWORD Ret; + BOOL Ret; hSCManager = OpenSCManager(NULL, NULL, @@ -102,42 +91,49 @@ EnumServices(ENUM_SERVICE_STATUS_PROCESS **pServiceStatus, if (hSCManager == NULL) { ReportLastError(); - return FALSE; + return 0; } - Ret = EnumServicesStatusEx(hSCManager, - SC_ENUM_PROCESS_INFO, - ServiceType, - ServiceState, - (LPBYTE)*pServiceStatus, - BufSize, - &BytesNeeded, - &NumServices, - &ResumeHandle, - 0); - - if ((Ret == 0) && (GetLastError() == ERROR_MORE_DATA)) + if (dwBufferSize == 0) { - *pServiceStatus = (ENUM_SERVICE_STATUS_PROCESS *) - HeapAlloc(GetProcessHeap(), - 0, - BytesNeeded); - if (*pServiceStatus != NULL) + Ret = EnumServicesStatusEx(hSCManager, + SC_ENUM_PROCESS_INFO, + dwServiceType, + dwServiceState, + (LPBYTE)*pServiceStatus, + dwBufferSize, + &BytesNeeded, + &NumServices, + &ResumeHandle, + pszGroupName); + if ((Ret == 0) && (GetLastError() != ERROR_MORE_DATA)) { - if (EnumServicesStatusEx(hSCManager, - SC_ENUM_PROCESS_INFO, - ServiceType, - ServiceState, - (LPBYTE)*pServiceStatus, - BytesNeeded, - &BytesNeeded, - &NumServices, - &ResumeHandle, - 0)) - { - CloseServiceHandle(hSCManager); - return NumServices; - } + ReportLastError(); + return 0; + } + + dwBufferSize = BytesNeeded; + } + + *pServiceStatus = (ENUM_SERVICE_STATUS_PROCESS *) + HeapAlloc(GetProcessHeap(), + 0, + dwBufferSize); + if (*pServiceStatus != NULL) + { + if (EnumServicesStatusEx(hSCManager, + SC_ENUM_PROCESS_INFO, + dwServiceType, + dwServiceState, + (LPBYTE)*pServiceStatus, + dwBufferSize, + &BytesNeeded, + &NumServices, + &ResumeHandle, + pszGroupName)) + { + CloseServiceHandle(hSCManager); + return NumServices; } } @@ -151,6 +147,147 @@ EnumServices(ENUM_SERVICE_STATUS_PROCESS **pServiceStatus, } +static +BOOL +ParseQueryArguments( + IN LPCTSTR *ServiceArgs, + IN INT ArgCount, + OUT PDWORD pdwServiceType, + OUT PDWORD pdwServiceState, + OUT PDWORD pdwBufferSize, + OUT PDWORD pdwResumeIndex, + OUT LPCTSTR *ppszGroupName, + OUT LPCTSTR *ppszServiceName) +{ + INT TmpCount, TmpIndex; + DWORD dwValue; + + TmpCount = ArgCount; + TmpIndex = 0; + while (TmpCount > 0) + { + if (!lstrcmpi(ServiceArgs[TmpIndex], _T("type="))) + { + TmpIndex++; + TmpCount--; + + if (TmpCount > 0) + { + if (!lstrcmpi(ServiceArgs[TmpIndex], _T("service"))) + { + *pdwServiceType = SERVICE_WIN32; + } + else if (!lstrcmpi(ServiceArgs[TmpIndex], _T("driver"))) + { + *pdwServiceType = SERVICE_DRIVER; + } + else if (!lstrcmpi(ServiceArgs[TmpIndex], _T("all"))) + { + *pdwServiceType = SERVICE_TYPE_ALL; + } + else if (!lstrcmpi(ServiceArgs[TmpIndex], _T("interact"))) + { + *pdwServiceType |= SERVICE_INTERACTIVE_PROCESS; + } + else + { + _tprintf(_T("ERROR following \"type=\"!\nMust be \"driver\" or \"service\"\n")); + return FALSE; + } + + TmpIndex++; + TmpCount--; + } + } + else if (!lstrcmpi(ServiceArgs[TmpIndex], _T("state="))) + { + TmpIndex++; + TmpCount--; + + if (TmpCount > 0) + { + if (!lstrcmpi(ServiceArgs[TmpIndex], _T("active"))) + { + *pdwServiceState = SERVICE_ACTIVE; + } + else if (!lstrcmpi(ServiceArgs[TmpIndex], _T("inactive"))) + { + *pdwServiceState = SERVICE_INACTIVE; + } + else if (!lstrcmpi(ServiceArgs[TmpIndex], _T("all"))) + { + *pdwServiceState = SERVICE_STATE_ALL; + } + else + { + _tprintf(_T("ERROR following \"state=\"!\nMust be \"inactive\" or \"all\"\n")); + return FALSE; + } + + TmpIndex++; + TmpCount--; + } + } + else if (!lstrcmpi(ServiceArgs[TmpIndex], _T("bufsize="))) + { + TmpIndex++; + TmpCount--; + + if (TmpCount > 0) + { + dwValue = _tcstoul(ServiceArgs[TmpIndex], NULL, 10); + if (dwValue > 0) + { + *pdwBufferSize = dwValue; + } + + TmpIndex++; + TmpCount--; + } + } + else if (!lstrcmpi(ServiceArgs[TmpIndex], _T("ri="))) + { + TmpIndex++; + TmpCount--; + + if (TmpCount >= 0) + { + dwValue = _tcstoul(ServiceArgs[TmpIndex], NULL, 10); + if (dwValue > 0) + { + *pdwResumeIndex = dwValue; + } + + TmpIndex++; + TmpCount--; + } + } + else if (!lstrcmpi(ServiceArgs[TmpIndex], _T("group="))) + { + TmpIndex++; + TmpCount--; + + if (TmpCount > 0) + { + *ppszGroupName = ServiceArgs[TmpIndex]; + + TmpIndex++; + TmpCount--; + } + } + else + { + *ppszServiceName = ServiceArgs[TmpIndex]; + + TmpIndex++; + TmpCount--; + } + } + + return TRUE; +} + + BOOL Query(LPCTSTR *ServiceArgs, DWORD ArgCount, @@ -158,17 +295,18 @@ Query(LPCTSTR *ServiceArgs, { LPENUM_SERVICE_STATUS_PROCESS pServiceStatus = NULL; DWORD NumServices = 0; - //DWORD ServiceType; - //DWORD ServiceState; - BOOL bServiceName = TRUE; - DWORD OptSize, i; - - LPCTSTR *TmpArgs; - INT TmpCnt; + DWORD dwServiceType = SERVICE_WIN32; + DWORD dwServiceState = SERVICE_ACTIVE; + DWORD dwBufferSize = 0; + DWORD dwResumeIndex = 0; + LPCTSTR pszGroupName = NULL; + LPCTSTR pszServiceName = NULL; + DWORD i; #ifdef SCDBG - TmpArgs = ServiceArgs; - TmpCnt = ArgCount; + LPCTSTR *TmpArgs = ServiceArgs; + INT TmpCnt = ArgCount; + _tprintf(_T("Arguments:\n")); while (TmpCnt) { @@ -179,66 +317,69 @@ Query(LPCTSTR *ServiceArgs, _tprintf(_T("\n")); #endif /* SCDBG */ - /* display all running services and drivers */ - if (ArgCount == 0) - { - NumServices = EnumServices(&pServiceStatus, - SERVICE_WIN32, - SERVICE_ACTIVE); - - if (NumServices != 0) - { - for (i=0; i < NumServices; i++) - { - PrintService(pServiceStatus[i].lpServiceName, - &pServiceStatus[i].ServiceStatusProcess, - bExtended); - } - - _tprintf(_T("number : %lu\n"), NumServices); - - if (pServiceStatus) - HeapFree(GetProcessHeap(), 0, pServiceStatus); - - return TRUE; - } - + /* Parse arguments */ + if (!ParseQueryArguments(ServiceArgs, + ArgCount, + &dwServiceType, + &dwServiceState, + &dwBufferSize, + &dwResumeIndex, + &pszGroupName, + &pszServiceName)) return FALSE; - } - TmpArgs = ServiceArgs; - TmpCnt = ArgCount; - OptSize = sizeof(QueryOpts) / sizeof(QueryOpts[0]); - while (TmpCnt--) +#ifdef SCDBG + _tprintf(_T("Service type: %lx\n"), dwServiceType); + _tprintf(_T("Service state: %lx\n"), dwServiceState); + _tprintf(_T("Buffer size: %lu\n"), dwBufferSize); + _tprintf(_T("Resume index: %lu\n"), dwResumeIndex); + _tprintf(_T("Group name: %s\n"), pszGroupName); + _tprintf(_T("Service name: %s\n"), pszServiceName); +#endif + + if (pszServiceName) { - for (i=0; i < OptSize; i++) - { - if (!lstrcmpi(*TmpArgs, QueryOpts[i])) - { - bServiceName = FALSE; - } - } - TmpArgs++; - } - - - /* FIXME: parse options */ - + /* Print only the requested service */ - /* print only the service requested */ - if (bServiceName) - { LPSERVICE_STATUS_PROCESS pStatus; - LPCTSTR ServiceName = *ServiceArgs; - pStatus = QueryService(ServiceName); + pStatus = QueryService(pszServiceName); if (pStatus) { - PrintService(ServiceName, + PrintService(pszServiceName, + NULL, pStatus, bExtended); } } + else + { + /* Print all matching services */ + + NumServices = EnumServices(&pServiceStatus, + dwServiceType, + dwServiceState, + dwBufferSize, + dwResumeIndex, + pszGroupName); + if (NumServices == 0) + return FALSE; + + for (i = 0; i < NumServices; i++) + { + PrintService(pServiceStatus[i].lpServiceName, + pServiceStatus[i].lpDisplayName, + &pServiceStatus[i].ServiceStatusProcess, + bExtended); + } + +#ifdef SCDBG + _tprintf(_T("number : %lu\n"), NumServices); +#endif + + if (pServiceStatus) + HeapFree(GetProcessHeap(), 0, pServiceStatus); + } return TRUE; } diff --git a/base/applications/sc/sc.h b/base/applications/sc/sc.h index 3dbacee0c8..a896da6855 100644 --- a/base/applications/sc/sc.h +++ b/base/applications/sc/sc.h @@ -56,7 +56,7 @@ BOOL GetKeyName(LPCTSTR ServiceName); BOOL EnumDepend(LPCTSTR ServiceName); /* print and error functions */ -VOID PrintService(LPCTSTR ServiceName, LPSERVICE_STATUS_PROCESS pStatus, BOOL bExtended); +VOID PrintService(LPCTSTR ServiceName, LPCTSTR DisplayName, LPSERVICE_STATUS_PROCESS pStatus, BOOL bExtended); VOID PrintServiceStatus(LPSERVICE_STATUS pStatus); VOID ReportLastError(VOID); diff --git a/base/applications/sc/start.c b/base/applications/sc/start.c index 676355ce2f..598a6355c7 100644 --- a/base/applications/sc/start.c +++ b/base/applications/sc/start.c @@ -68,6 +68,7 @@ BOOL Start(LPCTSTR ServiceName, LPCTSTR *ServiceArgs, INT ArgCount) if (pServiceInfo != NULL) { PrintService(ServiceName, + NULL, pServiceInfo, TRUE); diff --git a/base/applications/sc/usage.c b/base/applications/sc/usage.c index 4bcf049f9d..d04907d212 100644 --- a/base/applications/sc/usage.c +++ b/base/applications/sc/usage.c @@ -68,14 +68,12 @@ VOID MainUsage(VOID) _T(" (default = service)\n") _T(" state= State of services to enumerate (inactive, all)\n") _T(" (default = active)\n") -/* _T(" bufsize= The size (in bytes) of the enumeration buffer\n") _T(" (default = 4096)\n") _T(" ri= The resume index number at which to begin the enumeration\n") _T(" (default = 0)\n") _T(" group= Service group to enumerate\n") _T(" (default = all groups)\n") -*/ _T("SYNTAX EXAMPLES\n") _T("sc query - Enumerates status for active services & drivers\n") _T("sc query messenger - Displays status for the messenger service\n") @@ -83,9 +81,9 @@ VOID MainUsage(VOID) _T("sc query type= driver - Enumerates only active drivers\n") _T("sc query type= service - Enumerates only Win32 services\n") _T("sc query state= all - Enumerates all services & drivers\n") -// _T("sc query bufsize= 50 - Enumerates with a 50 byte buffer.\n") -// _T("sc query ri= 14 - Enumerates with resume index = 14\n") -// _T("sc queryex group= "" - Enumerates active services not in a group\n") + _T("sc query bufsize= 50 - Enumerates with a 50 byte buffer.\n") + _T("sc query ri= 14 - Enumerates with resume index = 14\n") + _T("sc queryex group= "" - Enumerates active services not in a group\n") _T("sc query type= service type= interact - Enumerates all interactive services\n") _T("sc query type= driver group= NDIS - Enumerates all NDIS drivers\n")); }

6 years, 7 months

01/01: [CMAKE] Call "git describe" with the --long parameter to always output the format we are used to.

by Colin Finck

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=ef8b17ed0d54e92589d0e… commit ef8b17ed0d54e92589d0eae7e0954a3379e0776a Author: Colin Finck <colin(a)reactos.org> AuthorDate: Sat Feb 17 18:09:07 2018 +0100 Commit: Colin Finck <colin(a)reactos.org> CommitDate: Sat Feb 17 18:09:07 2018 +0100 [CMAKE] Call "git describe" with the --long parameter to always output the format we are used to. --- sdk/include/reactos/version.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sdk/include/reactos/version.cmake b/sdk/include/reactos/version.cmake index ca0ceb4c9a..a585154556 100644 --- a/sdk/include/reactos/version.cmake +++ b/sdk/include/reactos/version.cmake @@ -39,7 +39,7 @@ if(EXISTS "${REACTOS_SOURCE_DIR}/.git") endif() execute_process( - COMMAND "${GIT_EXECUTABLE}" describe --abbrev=7 + COMMAND "${GIT_EXECUTABLE}" describe --abbrev=7 --long WORKING_DIRECTORY ${REACTOS_SOURCE_DIR} OUTPUT_VARIABLE GIT_DESCRIBE_REVISION RESULT_VARIABLE GIT_CALL_RESULT

6 years, 7 months

01/01: [SHELL32_APITEST] Run the CUserNotification worker test function in a thread to copy with possible test timeouts. CORE-13177

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=b77840d3a22f370fce5f9… commit b77840d3a22f370fce5f9b77c6af42f91ff65235 Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Sat Feb 17 16:02:22 2018 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Sat Feb 17 16:02:22 2018 +0100 [SHELL32_APITEST] Run the CUserNotification worker test function in a thread to copy with possible test timeouts. CORE-13177 --- .../apitests/shell32/CUserNotification.cpp | 32 +++++++++++++++++++++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/modules/rostests/apitests/shell32/CUserNotification.cpp b/modules/rostests/apitests/shell32/CUserNotification.cpp index b10185cee9..acfd6023a8 100644 --- a/modules/rostests/apitests/shell32/CUserNotification.cpp +++ b/modules/rostests/apitests/shell32/CUserNotification.cpp @@ -171,9 +171,39 @@ TestNotification(void) ok_hr(hr, S_FALSE); } -START_TEST(CUserNotification) +DWORD +CALLBACK +TestThread(LPVOID lpParam) { + /* Initialize COM */ CoInitializeEx(NULL, COINIT_APARTMENTTHREADED); + + /* Start the test */ TestNotification(); + + /* Cleanup and return */ CoUninitialize(); + return 0; +} + +START_TEST(CUserNotification) +{ + HANDLE hThread; + DWORD dwWait; + + /* We create a test thread, because the notification tests can hang */ + hThread = CreateThread(NULL, 0, TestThread, NULL, 0, NULL); + ok(hThread != NULL, "CreateThread failed with error 0x%lu\n", GetLastError()); + if (!hThread) + { + skip("Could not create the CUserNotification test thread!"); + return; + } + + /* Wait a maximum of 1:30 for the thread to finish (the timeout tests take some time) */ + dwWait = WaitForSingleObject(hThread, 90 * 1000); + ok(dwWait == WAIT_OBJECT_0, "WaitForSingleObject returned %lu, expected WAIT_OBJECT_0\n", dwWait); + + /* Cleanup and return */ + CloseHandle(hThread); }

6 years, 7 months

01/01: [NTOSKRNL] Don't call OOM dumper in case we were trying to allocate more than 100 pages. In such case, we'll consider the caller is bogus and we'll fail in silence. Dedicated to Mark (again!)

by Pierre Schweitzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=bdae0cce6640f59b127a4… commit bdae0cce6640f59b127a4fc20309d7e87a8603dd Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Sat Feb 17 15:09:38 2018 +0100 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Sat Feb 17 15:09:38 2018 +0100 [NTOSKRNL] Don't call OOM dumper in case we were trying to allocate more than 100 pages. In such case, we'll consider the caller is bogus and we'll fail in silence. Dedicated to Mark (again!) --- ntoskrnl/mm/ARM3/expool.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/ntoskrnl/mm/ARM3/expool.c b/ntoskrnl/mm/ARM3/expool.c index 54c6990be5..de75cfbd25 100644 --- a/ntoskrnl/mm/ARM3/expool.c +++ b/ntoskrnl/mm/ARM3/expool.c @@ -1810,8 +1810,14 @@ ExAllocatePoolWithTag(IN POOL_TYPE PoolType, #if DBG // // Out of memory, display current consumption + // Let's consider that if the caller wanted more + // than a hundred pages, that's a bogus caller + // and we are not out of memory // - MiDumpPoolConsumers(FALSE, 0, 0, 0); + if (NumberOfBytes < 100 * PAGE_SIZE) + { + MiDumpPoolConsumers(FALSE, 0, 0, 0); + } #endif // @@ -2143,8 +2149,14 @@ ExAllocatePoolWithTag(IN POOL_TYPE PoolType, #if DBG // // Out of memory, display current consumption + // Let's consider that if the caller wanted more + // than a hundred pages, that's a bogus caller + // and we are not out of memory // - MiDumpPoolConsumers(FALSE, 0, 0, 0); + if (NumberOfBytes < 100 * PAGE_SIZE) + { + MiDumpPoolConsumers(FALSE, 0, 0, 0); + } #endif //

6 years, 7 months

01/01: [NTOSKRNL] Allow more chars in ExpTagAllowPrint(). Dedicated to Mark

by Pierre Schweitzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=01fcb02880039bb94cdbc… commit 01fcb02880039bb94cdbc6d3e4501b4185e29e09 Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Sat Feb 17 15:06:29 2018 +0100 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Sat Feb 17 15:06:29 2018 +0100 [NTOSKRNL] Allow more chars in ExpTagAllowPrint(). Dedicated to Mark --- ntoskrnl/mm/ARM3/expool.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ntoskrnl/mm/ARM3/expool.c b/ntoskrnl/mm/ARM3/expool.c index d13142a4a7..54c6990be5 100644 --- a/ntoskrnl/mm/ARM3/expool.c +++ b/ntoskrnl/mm/ARM3/expool.c @@ -468,7 +468,8 @@ ExpTagAllowPrint(CHAR Tag) if ((Tag >= 'a' && Tag <= 'z') || (Tag >= 'A' && Tag <= 'Z') || (Tag >= '0' && Tag <= '9') || - Tag == ' ') + Tag == ' ' || Tag == '=' || + Tag == '?' || Tag == '@') { return TRUE; }

6 years, 7 months

01/01: [FASTFAT] Drop read ahead locking routines in favor of lazy writer routines. This avoids code duplication while being consistent with MS FastFAT.

by Pierre Schweitzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=69f51d153394c8b2223ff… commit 69f51d153394c8b2223ffa3b92805dffe45f0673 Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Sat Feb 17 13:48:32 2018 +0100 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Sat Feb 17 13:49:15 2018 +0100 [FASTFAT] Drop read ahead locking routines in favor of lazy writer routines. This avoids code duplication while being consistent with MS FastFAT. --- drivers/filesystems/fastfat/fastio.c | 30 ------------------------------ drivers/filesystems/fastfat/iface.c | 4 ++-- drivers/filesystems/fastfat/vfat.h | 11 ----------- 3 files changed, 2 insertions(+), 43 deletions(-) diff --git a/drivers/filesystems/fastfat/fastio.c b/drivers/filesystems/fastfat/fastio.c index 58d3f0d587..248f39f5bf 100644 --- a/drivers/filesystems/fastfat/fastio.c +++ b/drivers/filesystems/fastfat/fastio.c @@ -753,36 +753,6 @@ VfatReleaseFromLazyWrite( ExReleaseResourceLite(&(Fcb->MainResource)); } -BOOLEAN -NTAPI -VfatAcquireForReadAhead( - IN PVOID Context, - IN BOOLEAN Wait) -{ - PVFATFCB Fcb = (PVFATFCB)Context; - ASSERT(Fcb); - DPRINT("VfatAcquireForReadAhead(): Fcb %p\n", Fcb); - - if (!ExAcquireResourceExclusiveLite(&(Fcb->MainResource), Wait)) - { - DPRINT("VfatAcquireForReadAhead(): ExReleaseResourceLite failed.\n"); - return FALSE; - } - return TRUE; -} - -VOID -NTAPI -VfatReleaseFromReadAhead( - IN PVOID Context) -{ - PVFATFCB Fcb = (PVFATFCB)Context; - ASSERT(Fcb); - DPRINT("VfatReleaseFromReadAhead(): Fcb %p\n", Fcb); - - ExReleaseResourceLite(&(Fcb->MainResource)); -} - INIT_SECTION VOID VfatInitFastIoRoutines( diff --git a/drivers/filesystems/fastfat/iface.c b/drivers/filesystems/fastfat/iface.c index c334a95aed..02e570ea45 100644 --- a/drivers/filesystems/fastfat/iface.c +++ b/drivers/filesystems/fastfat/iface.c @@ -119,8 +119,8 @@ DriverEntry( /* Cache manager */ VfatGlobalData->CacheMgrCallbacks.AcquireForLazyWrite = VfatAcquireForLazyWrite; VfatGlobalData->CacheMgrCallbacks.ReleaseFromLazyWrite = VfatReleaseFromLazyWrite; - VfatGlobalData->CacheMgrCallbacks.AcquireForReadAhead = VfatAcquireForReadAhead; - VfatGlobalData->CacheMgrCallbacks.ReleaseFromReadAhead = VfatReleaseFromReadAhead; + VfatGlobalData->CacheMgrCallbacks.AcquireForReadAhead = VfatAcquireForLazyWrite; + VfatGlobalData->CacheMgrCallbacks.ReleaseFromReadAhead = VfatReleaseFromLazyWrite; /* Fast I/O */ VfatInitFastIoRoutines(&VfatGlobalData->FastIoDispatch); diff --git a/drivers/filesystems/fastfat/vfat.h b/drivers/filesystems/fastfat/vfat.h index f6e2aa6452..487b5f9ab2 100644 --- a/drivers/filesystems/fastfat/vfat.h +++ b/drivers/filesystems/fastfat/vfat.h @@ -775,17 +775,6 @@ NTAPI VfatReleaseFromLazyWrite( IN PVOID Context); -BOOLEAN -NTAPI -VfatAcquireForReadAhead( - IN PVOID Context, - IN BOOLEAN Wait); - -VOID -NTAPI -VfatReleaseFromReadAhead( - IN PVOID Context); - /* fat.c */ NTSTATUS

6 years, 7 months

01/01: [SHELL32] Fix COM registration of IShellFolder, IShellLinkA/W, IQueryContinue and IUserNotification classes.

by Hermès Bélusca-Maïto

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=175e78e50f47e5203dde6… commit 175e78e50f47e5203dde6c625644e6593a86db3b Author: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> AuthorDate: Fri Feb 16 23:30:09 2018 +0100 Commit: Hermès Bélusca-Maïto <hermes.belusca-maito(a)reactos.org> CommitDate: Fri Feb 16 23:31:39 2018 +0100 [SHELL32] Fix COM registration of IShellFolder, IShellLinkA/W, IQueryContinue and IUserNotification classes. --- dll/win32/shell32/res/rgs/shellfsfolder.rgs | 16 +++++++------- dll/win32/shell32/res/rgs/shelllink.rgs | 30 +++++++++++++------------- dll/win32/shell32/res/rgs/usernotification.rgs | 30 +++++++++++++------------- 3 files changed, 38 insertions(+), 38 deletions(-) diff --git a/dll/win32/shell32/res/rgs/shellfsfolder.rgs b/dll/win32/shell32/res/rgs/shellfsfolder.rgs index ca0ecbcb6c..27a304abc3 100644 --- a/dll/win32/shell32/res/rgs/shellfsfolder.rgs +++ b/dll/win32/shell32/res/rgs/shellfsfolder.rgs @@ -9,16 +9,16 @@ HKCR val ThreadingModel = s 'Apartment' } } - NoRemove Interface + } + NoRemove Interface + { + ForceRemove {000214E6-0000-0000-C000-000000000046} = s 'IShellFolder' { - ForceRemove {000214E6-0000-0000-C000-000000000046} = s 'IShellFolder' + NumMethods = s '13' + { + } + ProxyStubClsid32 = s '{bf50b68e-29b8-4386-ae9c-9734d5117cd5}' { - NumMethods = s '13' - { - } - ProxyStubClsid32 = s '{bf50b68e-29b8-4386-ae9c-9734d5117cd5}' - { - } } } } diff --git a/dll/win32/shell32/res/rgs/shelllink.rgs b/dll/win32/shell32/res/rgs/shelllink.rgs index fe4b9db854..9828c97596 100644 --- a/dll/win32/shell32/res/rgs/shelllink.rgs +++ b/dll/win32/shell32/res/rgs/shelllink.rgs @@ -19,25 +19,25 @@ HKCR MayChangeDefaultMenu = s '' } } - NoRemove Interface + } + NoRemove Interface + { + ForceRemove {000214EE-0000-0000-C000-000000000046} = s 'IShellLinkA' + { + NumMethods = s '21' + { + } + ProxyStubClsid32 = s '{B8DA6310-E19B-11D0-933C-00A0C90DCAA9}' + { + } + } + ForceRemove {000214F9-0000-0000-C000-000000000046} = s 'IShellLinkW' { - ForceRemove {000214EE-0000-0000-C000-000000000046} = s 'IShellLinkA' + NumMethods = s '21' { - NumMethods = s '21' - { - } - ProxyStubClsid32 = s '{B8DA6310-E19B-11D0-933C-00A0C90DCAA9}' - { - } } - ForceRemove {000214F9-0000-0000-C000-000000000046} = s 'IShellLinkW' + ProxyStubClsid32 = s '{B8DA6310-E19B-11D0-933C-00A0C90DCAA9}' { - NumMethods = s '21' - { - } - ProxyStubClsid32 = s '{B8DA6310-E19B-11D0-933C-00A0C90DCAA9}' - { - } } } } diff --git a/dll/win32/shell32/res/rgs/usernotification.rgs b/dll/win32/shell32/res/rgs/usernotification.rgs index 61c585f432..54df10e04a 100644 --- a/dll/win32/shell32/res/rgs/usernotification.rgs +++ b/dll/win32/shell32/res/rgs/usernotification.rgs @@ -18,25 +18,25 @@ HKCR } val AppID = s '{0010890E-8789-413C-ADBC-48F5B511B3AF}' } - NoRemove Interface + } + NoRemove Interface + { + ForceRemove {7307055C-B24A-486B-9F25-163E597A28A9} = s 'IQueryContinue' + { + NumMethods = s '4' + { + } + ProxyStubClsid32 = s '{B8DA6310-E19B-11D0-933C-00A0C90DCAA9}' + { + } + } + ForceRemove {BA9711BA-5893-4787-A7E1-41277151550B} = s 'IUserNotification' { - ForceRemove {7307055C-B24A-486B-9F25-163E597A28A9} = s 'IQueryContinue' + NumMethods = s '8' { - NumMethods = s '4' - { - } - ProxyStubClsid32 = s '{B8DA6310-E19B-11D0-933C-00A0C90DCAA9}' - { - } } - ForceRemove {BA9711BA-5893-4787-A7E1-41277151550B} = s 'IUserNotification' + ProxyStubClsid32 = s '{B8DA6310-E19B-11D0-933C-00A0C90DCAA9}' { - NumMethods = s '8' - { - } - ProxyStubClsid32 = s '{B8DA6310-E19B-11D0-933C-00A0C90DCAA9}' - { - } } } }

6 years, 7 months

← Newer
1
...
8
9
10
11
12
13
14
...
24
Older →

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs February 2018