https://git.reactos.org/?p=reactos.git;a=commitdiff;h=218b8eda92bc84be24a61…
commit 218b8eda92bc84be24a61c055e567f95b5e5a16b
Author: Giannis Adamopoulos <gadamopoulos(a)reactos.org>
AuthorDate: Wed Feb 7 01:15:49 2018 +0200
Commit: Giannis Adamopoulos <gadamopoulos(a)reactos.org>
CommitDate: Wed Feb 7 01:15:49 2018 +0200
[SYSSETUP] Don't load ISOLATIONAWARE_MANIFEST_RESOURCE_ID manually
Such a manifest is meant to be activated by the caller of the exports of the dll.
This means that the user of syssetup which is setup.exe is the one that should do the proper handling of the manifests.
Since setup.exe is the one that needs to do the right thing, add a CREATEPROCESS_MANIFEST_RESOURCE_ID to it and avoid
dealing with ISOLATIONAWARE_MANIFEST_RESOURCE_ID altogether (which is supposed to be used by activating the activation context
before calling the exports of the dll that has it). We don't really use ISOLATIONAWARE_MANIFEST_RESOURCE_ID correctly in any
place in the tree so let's rely on CREATEPROCESS_MANIFEST_RESOURCE_ID for now.
This fixes one part of CORE-14228 where no image was shown in the theme selector buttons. This happened because comctl32 was
statically linked and calling ImageList_LoadImage ended up creating an image list with comctl32 v5. Then we passed this image
list to a button created with comctl32 v6 and as a result the image list was unusable. This is yet another issue that needs
to be addressed in the future. Namely, it seems that in windows comctl32 v6 can use image lists created by comctl32 v5 whereas
we cannot.
This fix is not a hack but cleverly works around these two bugs that need to be addressed some time in the future.
CORE-14228
---
base/setup/setup/setup.rc | 3 +++
dll/win32/syssetup/syssetup.rc | 2 --
dll/win32/syssetup/wizard.c | 33 ---------------------------------
3 files changed, 3 insertions(+), 35 deletions(-)
diff --git a/base/setup/setup/setup.rc b/base/setup/setup/setup.rc
index b95b0681c6..f36359966c 100644
--- a/base/setup/setup/setup.rc
+++ b/base/setup/setup/setup.rc
@@ -1,4 +1,7 @@
+#include <winuser.h>
+
#define REACTOS_STR_FILE_DESCRIPTION "ReactOS Setup"
#define REACTOS_STR_INTERNAL_NAME "setup"
#define REACTOS_STR_ORIGINAL_FILENAME "setup.exe"
+#include <reactos/manifest_exe.rc>
#include <reactos/version.rc>
diff --git a/dll/win32/syssetup/syssetup.rc b/dll/win32/syssetup/syssetup.rc
index bac2e57df0..041295dc4c 100644
--- a/dll/win32/syssetup/syssetup.rc
+++ b/dll/win32/syssetup/syssetup.rc
@@ -24,8 +24,6 @@ IDI_ICON3 ICON "resources/3.ico"
IDI_ICON4 ICON "resources/4.ico"
IDI_ICON5 ICON "resources/5.ico"
-#include <reactos/manifest_dll.rc>
-
STRINGTABLE
BEGIN
IDS_ACKPROJECTS "Wine - http://www.winehq.org\nFreeType - http://www.freetype.org\nSYSLINUX - http://syslinux.zytor.com\nMinGW - http://www.mingw.org\nBochs - http://bochs.sourceforge.net\nQEMU - http://fabrice.bellard.free.fr/qemu\nMesa3D - http://www.mesa3d.org\nadns - http://www.gnu.org/software/adns\nICU - http://www.icu-project.org/\nGraphApp - http://enchantia.com/software/graphapp/\nExt2 - http://www.ext2fsd.com/\nGNU FreeFont - http://savannah.gnu.org/projects/freefont/\nDeja [...]
diff --git a/dll/win32/syssetup/wizard.c b/dll/win32/syssetup/wizard.c
index 796476838f..b61347f8ec 100644
--- a/dll/win32/syssetup/wizard.c
+++ b/dll/win32/syssetup/wizard.c
@@ -2491,25 +2491,6 @@ ProcessUnattendSetup(
typedef DWORD(WINAPI *PFNREQUESTWIZARDPAGES)(PDWORD, HPROPSHEETPAGE *, PSETUPDATA);
-BOOL ActivateComctl32v6ActCtx(ULONG_PTR *cookie, HANDLE* hActCtx)
-{
- ACTCTXW ActCtx = {sizeof(ACTCTX), ACTCTX_FLAG_RESOURCE_NAME_VALID};
- WCHAR fileBuffer[MAX_PATH];
-
- *hActCtx = INVALID_HANDLE_VALUE;
-
- if (!GetModuleFileName(hDllInstance, fileBuffer, MAX_PATH))
- return FALSE;
-
- ActCtx.lpSource = fileBuffer;
- ActCtx.lpResourceName = ISOLATIONAWARE_MANIFEST_RESOURCE_ID;
- *hActCtx = CreateActCtx(&ActCtx);
- if (*hActCtx == INVALID_HANDLE_VALUE)
- return FALSE;
-
- return ActivateActCtx(*hActCtx, cookie);
-}
-
VOID
InstallWizard(VOID)
{
@@ -2523,9 +2504,6 @@ InstallWizard(VOID)
HMODULE hNetShell = NULL;
PFNREQUESTWIZARDPAGES pfn = NULL;
DWORD dwPageCount = 8, dwNetworkPageCount = 0;
- BOOL bActCtxActivated;
- ULONG_PTR cookie;
- HANDLE hActCtx;
LogItem(L"BEGIN_SECTION", L"InstallWizard");
@@ -2543,11 +2521,6 @@ InstallWizard(VOID)
goto done;
}
- /* Load and activate the act ctx for comctl32v6 now manually.
- * Even if the exe of the process had a manifest, at the point of its launch
- * the manifest of comctl32 wouldn't be installed so it wouldn't be loaded at all */
- bActCtxActivated = ActivateComctl32v6ActCtx(&cookie, &hActCtx);
-
hNetShell = LoadLibraryW(L"netshell.dll");
if (hNetShell != NULL)
{
@@ -2701,12 +2674,6 @@ done:
if (hNetShell != NULL)
FreeLibrary(hNetShell);
- if (bActCtxActivated)
- {
- DeactivateActCtx(0, cookie);
- ReleaseActCtx(hActCtx);
- }
-
if (pSetupData != NULL)
{
DeleteObject(pSetupData->hBoldFont);
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=579e1e6b24de8d3a25b92…
commit 579e1e6b24de8d3a25b928d1f59b6ab3b53ed01b
Author: Joachim Henze <Joachim.Henze(a)reactos.org>
AuthorDate: Tue Feb 6 17:35:08 2018 +0100
Commit: Joachim Henze <Joachim.Henze(a)reactos.org>
CommitDate: Tue Feb 6 17:35:08 2018 +0100
[EXPLORER] Update all preview bitmaps showing notification area
To reflect recent changes in taskbar height, icon spacing,
clock x and y margins.
Also make sure all shots show the exact same time
and choose a more localization agnostic time.
---
base/shell/explorer/res/bmp/154.bmp | Bin 12838 -> 12838 bytes
base/shell/explorer/res/bmp/155.bmp | Bin 12838 -> 12838 bytes
base/shell/explorer/res/bmp/180.bmp | Bin 12838 -> 12838 bytes
base/shell/explorer/res/bmp/181.bmp | Bin 12838 -> 12838 bytes
base/shell/explorer/res/bmp/182.bmp | Bin 12838 -> 12838 bytes
base/shell/explorer/res/bmp/183.bmp | Bin 12838 -> 12838 bytes
6 files changed, 0 insertions(+), 0 deletions(-)
diff --git a/base/shell/explorer/res/bmp/154.bmp b/base/shell/explorer/res/bmp/154.bmp
index 0bc115461e..ae0ba177f5 100644
Binary files a/base/shell/explorer/res/bmp/154.bmp and b/base/shell/explorer/res/bmp/154.bmp differ
diff --git a/base/shell/explorer/res/bmp/155.bmp b/base/shell/explorer/res/bmp/155.bmp
index c5824b4abf..4c9e1822d8 100644
Binary files a/base/shell/explorer/res/bmp/155.bmp and b/base/shell/explorer/res/bmp/155.bmp differ
diff --git a/base/shell/explorer/res/bmp/180.bmp b/base/shell/explorer/res/bmp/180.bmp
index 40042ddd41..2890a44076 100644
Binary files a/base/shell/explorer/res/bmp/180.bmp and b/base/shell/explorer/res/bmp/180.bmp differ
diff --git a/base/shell/explorer/res/bmp/181.bmp b/base/shell/explorer/res/bmp/181.bmp
index 7247b20fe4..461725b9c4 100644
Binary files a/base/shell/explorer/res/bmp/181.bmp and b/base/shell/explorer/res/bmp/181.bmp differ
diff --git a/base/shell/explorer/res/bmp/182.bmp b/base/shell/explorer/res/bmp/182.bmp
index f5039d18e8..07cb49445b 100644
Binary files a/base/shell/explorer/res/bmp/182.bmp and b/base/shell/explorer/res/bmp/182.bmp differ
diff --git a/base/shell/explorer/res/bmp/183.bmp b/base/shell/explorer/res/bmp/183.bmp
index 214213d448..0f7734cab4 100644
Binary files a/base/shell/explorer/res/bmp/183.bmp and b/base/shell/explorer/res/bmp/183.bmp differ
https://git.reactos.org/?p=reactos.git;a=commitdiff;h=7b718776768583be8eeab…
commit 7b718776768583be8eeaba24a6628514d878af07
Author: Bișoc George <fraizeraust99(a)gmail.com>
AuthorDate: Mon Feb 5 18:57:39 2018 +0100
Commit: Hermès BÉLUSCA - MAÏTO <hermes.belusca-maito(a)reactos.org>
CommitDate: Mon Feb 5 18:57:39 2018 +0100
[TRANSLATION] Romanian translation for FONTEXT and TIMEOUT (#363)
[FONTEXT]: At the moment there is a comment in the en-US.rc resource file that advises to not translate it. I only created this file as a basis for the future. The file will be updated later when there is the possibility for FONTEXT to be translated further.
---
base/applications/cmdutils/timeout/lang/ro-RO.rc | 40 ++++++++++++++++++++++++
base/applications/cmdutils/timeout/timeout.rc | 3 ++
dll/shellext/fontext/fontext.rc | 3 ++
dll/shellext/fontext/lang/ro-RO.rc | 13 ++++++++
4 files changed, 59 insertions(+)
diff --git a/base/applications/cmdutils/timeout/lang/ro-RO.rc b/base/applications/cmdutils/timeout/lang/ro-RO.rc
new file mode 100644
index 0000000000..b11dff1997
--- /dev/null
+++ b/base/applications/cmdutils/timeout/lang/ro-RO.rc
@@ -0,0 +1,40 @@
+/*
+ * PROJECT: ReactOS Timeout Utility
+ * LICENSE: GPL-2.0+ (https://spdx.org/licenses/GPL-2.0+)
+ * PURPOSE: Timeout Utility in Romanian language
+ * COPYRIGHT: Copyright 2018 Bișoc George (fraizeraust99 at gmail dot com)
+ */
+
+LANGUAGE LANG_ROMANIAN, SUBLANG_NEUTRAL
+
+STRINGTABLE
+BEGIN
+ IDS_USAGE "Utilitatea Timeout de ReactOS\n\
+\n\
+TIMEOUT [/?] [/T] timp [/NOBREAK]\n\
+\n\
+Descriere:\n\
+ Această utilitate așteaptă până când perioada de timp specificată (în secunde) a scurs,\n\
+ sau după ce orice tastă a fost apăsată. Un parametru de a ignora o tastă apăsată este de asemenea\n\
+ acceptată.\n\
+\n\
+Parametri:\n\
+ /? Afișează această ecrană de ajutor.\n\
+\n\
+ /T timp Specifică un număr în secunde pentru așteptare (-1 la 99999).\n\
+ O valoare de -1 înseamnă că programul va aștepta până când o tastă va fi apăsată.\n\
+ Rețineți că specificația ""/T"" este opțională, puteți să\n\
+ specificați o valoare în timp fără aceasta.\n\
+\n\
+ /NOBREAK Ignoră orice input de către tastatură cu excepția Ctrl+C.\n\
+"
+ IDS_ERROR_OUT_OF_RANGE "EROARE: Valoarea de timp trebuie să fie în acest câmp (-1 la 99999).\n"
+ IDS_ERROR_INVALID_HANDLE_VALUE "EROARE: Imposibil obținerea unui handle standard pentru consolă (eroare %lu).\n"
+ IDS_ERROR_READ_INPUT "EROARE: Imposibil citirea inputu-lui de către consolă (eroare %lu).\n"
+ IDS_ERROR_NO_TIMER_VALUE "EROARE: O valoare de timp trebuie să fie specificată (-1 la 99999).\n"
+ IDS_ERROR_ONE_TIME "EROARE: Doar o valoare de timp este necesară.\n"
+ IDS_NOBREAK_INPUT "Apasă Ctrl+C pentru a ieși..."
+ IDS_USER_INPUT "Apasă orice tastă pentru a continua..."
+ IDS_NOBREAK_INPUT_COUNT "Așteptând %d secunde, apasă Ctrl+C pentru a ieși..."
+ IDS_USER_INPUT_COUNT "Așteptând %d secunde, apasă orice tastă pentru a continua..."
+END
diff --git a/base/applications/cmdutils/timeout/timeout.rc b/base/applications/cmdutils/timeout/timeout.rc
index e5156b41b1..a8e7440fe9 100644
--- a/base/applications/cmdutils/timeout/timeout.rc
+++ b/base/applications/cmdutils/timeout/timeout.rc
@@ -22,6 +22,9 @@ LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL
#ifdef LANGUAGE_IT_IT
#include "lang/it-IT.rc"
#endif
+#ifdef LANGUAGE_RO_RO
+ #include "lang/ro-RO.rc"
+#endif
#ifdef LANGUAGE_RU_RU
#include "lang/ru-RU.rc"
#endif
diff --git a/dll/shellext/fontext/fontext.rc b/dll/shellext/fontext/fontext.rc
index 67d6d4adb8..61f9904cd3 100644
--- a/dll/shellext/fontext/fontext.rc
+++ b/dll/shellext/fontext/fontext.rc
@@ -14,6 +14,9 @@
#ifdef LANGUAGE_EN_US
#include "lang/en-US.rc"
#endif
+#ifdef LANGUAGE_RO_RO
+ #include "lang/ro-RO.rc"
+#endif
#ifdef LANGUAGE_TR_TR
#include "lang/tr-TR.rc"
#endif
diff --git a/dll/shellext/fontext/lang/ro-RO.rc b/dll/shellext/fontext/lang/ro-RO.rc
new file mode 100644
index 0000000000..af1d14c65c
--- /dev/null
+++ b/dll/shellext/fontext/lang/ro-RO.rc
@@ -0,0 +1,13 @@
+/*
+ * PROJECT: ReactOS Font Text
+ * LICENSE: GPL-2.0+ (https://spdx.org/licenses/GPL-2.0+)
+ * PURPOSE: Romanian translation for FONTEXT
+ * COPYRIGHT: Copyright 2018 Bișoc George (fraizeraust99 at gmail dot com)
+ */
+
+LANGUAGE LANG_ROMANIAN, SUBLANG_NEUTRAL
+
+STRINGTABLE
+BEGIN
+ IDS_REACTOS_FONTS_FOLDER "Folder-ul de fonturi de ReactOS"
+END