Ros-diffs September 2018

ros-diffs@reactos.org

24 participants
223 discussions

02/06: [KMTESTS:CC] Add missing FsRtlEnter/ExitFileSystem() calls

by Pierre Schweitzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=b0d1522886465977dd667… commit b0d1522886465977dd667c8daaf15f2f220be524 Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Sat Sep 1 12:18:51 2018 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Sat Sep 1 12:41:01 2018 +0200 [KMTESTS:CC] Add missing FsRtlEnter/ExitFileSystem() calls Spotted by Thomas --- modules/rostests/kmtests/ntos_cc/CcMapData_drv.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/modules/rostests/kmtests/ntos_cc/CcMapData_drv.c b/modules/rostests/kmtests/ntos_cc/CcMapData_drv.c index c7ed089ed5..6624b10e70 100644 --- a/modules/rostests/kmtests/ntos_cc/CcMapData_drv.c +++ b/modules/rostests/kmtests/ntos_cc/CcMapData_drv.c @@ -331,6 +331,8 @@ TestMessageHandler( { NTSTATUS Status = STATUS_SUCCESS; + FsRtlEnterFileSystem(); + switch (ControlCode) { case IOCTL_START_TEST: @@ -348,6 +350,8 @@ TestMessageHandler( break; } + FsRtlExitFileSystem(); + return Status; } @@ -365,6 +369,8 @@ TestIrpHandler( DPRINT("IRP %x/%x\n", IoStack->MajorFunction, IoStack->MinorFunction); ASSERT(IoStack->MajorFunction == IRP_MJ_READ); + FsRtlEnterFileSystem(); + Status = STATUS_NOT_SUPPORTED; Irp->IoStatus.Information = 0; @@ -420,5 +426,7 @@ TestIrpHandler( IoCompleteRequest(Irp, IO_NO_INCREMENT); } + FsRtlExitFileSystem(); + return Status; }

6 years

01/06: [KMTESTS:CC] That wasn't meant to be committed

by Pierre Schweitzer

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=8f284f8a0c77e20f5fc85… commit 8f284f8a0c77e20f5fc85f7750c72bb67133ad03 Author: Pierre Schweitzer <pierre(a)reactos.org> AuthorDate: Sat Sep 1 10:10:09 2018 +0200 Commit: Pierre Schweitzer <pierre(a)reactos.org> CommitDate: Sat Sep 1 12:41:00 2018 +0200 [KMTESTS:CC] That wasn't meant to be committed --- modules/rostests/kmtests/ntos_cc/CcMapData_drv.c | 5 ---- .../ntos_cc/{CcMapData_drv.c => CcPinRead_drv.c} | 2 +- modules/rostests/kmtests/ntos_cc/CcPinRead_user.c | 34 ++++++++++++++++++++++ 3 files changed, 35 insertions(+), 6 deletions(-) diff --git a/modules/rostests/kmtests/ntos_cc/CcMapData_drv.c b/modules/rostests/kmtests/ntos_cc/CcMapData_drv.c index e067124ee2..c7ed089ed5 100644 --- a/modules/rostests/kmtests/ntos_cc/CcMapData_drv.c +++ b/modules/rostests/kmtests/ntos_cc/CcMapData_drv.c @@ -27,7 +27,6 @@ typedef struct _TEST_CONTEXT ULONG Length; } TEST_CONTEXT, *PTEST_CONTEXT; -static BOOLEAN TestMap = FALSE; static ULONG TestTestId = -1; static PFILE_OBJECT TestFileObject; static PDEVICE_OBJECT TestDeviceObject; @@ -168,9 +167,7 @@ MapInAnotherThread(IN PVOID Context) Ret = FALSE; Offset.QuadPart = 0x1000; KmtStartSeh(); - TestMap = TRUE; Ret = CcMapData(TestFileObject, &Offset, TestContext->Length, MAP_WAIT, &Bcb, (PVOID *)&Buffer); - TestMap = FALSE; KmtEndSeh(STATUS_SUCCESS); if (!skip(Ret == TRUE, "CcMapData failed\n")) @@ -246,9 +243,7 @@ PerformTest( Ret = FALSE; Offset.QuadPart = 0x1000; KmtStartSeh(); - TestMap = TRUE; Ret = CcMapData(TestFileObject, &Offset, FileSizes.FileSize.QuadPart - Offset.QuadPart, MAP_WAIT, &TestContext->Bcb, &TestContext->Buffer); - TestMap = FALSE; KmtEndSeh(STATUS_SUCCESS); if (!skip(Ret == TRUE, "CcMapData failed\n")) diff --git a/modules/rostests/kmtests/ntos_cc/CcMapData_drv.c b/modules/rostests/kmtests/ntos_cc/CcPinRead_drv.c similarity index 99% copy from modules/rostests/kmtests/ntos_cc/CcMapData_drv.c copy to modules/rostests/kmtests/ntos_cc/CcPinRead_drv.c index e067124ee2..0d63e48572 100644 --- a/modules/rostests/kmtests/ntos_cc/CcMapData_drv.c +++ b/modules/rostests/kmtests/ntos_cc/CcPinRead_drv.c @@ -1,7 +1,7 @@ /* * PROJECT: ReactOS kernel-mode tests * LICENSE: LGPLv2.1+ - See COPYING.LIB in the top level directory - * PURPOSE: Test driver for CcMapData function + * PURPOSE: Test driver for CcPinRead function * PROGRAMMER: Pierre Schweitzer <pierre(a)reactos.org> */ diff --git a/modules/rostests/kmtests/ntos_cc/CcPinRead_user.c b/modules/rostests/kmtests/ntos_cc/CcPinRead_user.c new file mode 100644 index 0000000000..c7a93a5d96 --- /dev/null +++ b/modules/rostests/kmtests/ntos_cc/CcPinRead_user.c @@ -0,0 +1,34 @@ +/* + * PROJECT: ReactOS kernel-mode tests + * LICENSE: GPLv2+ - See COPYING in the top level directory + * PURPOSE: Kernel-Mode Test Suite CcPinRead test user-mode part + * PROGRAMMER: Pierre Schweitzer <pierre(a)reactos.org> + */ + +#include <kmt_test.h> + +#define IOCTL_START_TEST 1 +#define IOCTL_FINISH_TEST 2 + +START_TEST(CcPinRead) +{ + DWORD Ret; + ULONG TestId; + + KmtLoadDriver(L"CcPinRead", FALSE); + KmtOpenDriver(); + + /* 3 tests for offset + * 1 test for BCB + */ + for (TestId = 0; TestId < 4; ++TestId) + { + Ret = KmtSendUlongToDriver(IOCTL_START_TEST, TestId); + ok(Ret == ERROR_SUCCESS, "KmtSendUlongToDriver failed: %lx\n", Ret); + Ret = KmtSendUlongToDriver(IOCTL_FINISH_TEST, TestId); + ok(Ret == ERROR_SUCCESS, "KmtSendUlongToDriver failed: %lx\n", Ret); + } + + KmtCloseDriver(); + KmtUnloadDriver(); +}

6 years

01/01: [COMCTL32_WINETEST] treeview.c: Skip test_right_click()

by Serge Gautherie

https://git.reactos.org/?p=reactos.git;a=commitdiff;h=cbcfbc4322f20f19d47ff… commit cbcfbc4322f20f19d47ff5cbc3bf11d302fdb3e1 Author: Serge Gautherie <reactos-git_serge_171003(a)gautherie.fr> AuthorDate: Mon Aug 27 19:12:56 2018 +0200 Commit: Thomas Faber <thomas.faber(a)reactos.org> CommitDate: Sat Sep 1 09:22:45 2018 +0200 [COMCTL32_WINETEST] treeview.c: Skip test_right_click() until CORE-14975 is fixed upstream and WINESYNC. CORE-14975 --- modules/rostests/winetests/comctl32/treeview.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/modules/rostests/winetests/comctl32/treeview.c b/modules/rostests/winetests/comctl32/treeview.c index 007bbe8957..ceaa112588 100644 --- a/modules/rostests/winetests/comctl32/treeview.c +++ b/modules/rostests/winetests/comctl32/treeview.c @@ -2724,6 +2724,14 @@ static void test_right_click(void) LRESULT result; POINT pt; +#ifdef __REACTOS__ + if (!winetest_interactive) + { + skip("test_right_click() (set WINETEST_INTERACTIVE=1), until CORE-14975 is fixed upstream and WINESYNC\n"); + return; + } +#endif + hTree = create_treeview_control(0); fill_tree(hTree);

6 years

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

Ros-diffs September 2018